RE: RFR: (JAXP) 8020430 : NullPointerException in xml sqe nightly result on 2013-07-12

I'm so thrilled this is happening! Thanks! iris -Original Message- From: huizhe wang Sent: Monday, July 15, 2013 1:08 PM To: Iris Clark Cc: Lance Andersen; Core-Libs-Dev Subject: Re: RFR: (JAXP) 8020430 : NullPointerException in xml sqe nightly result on 2013-07-12 Yes, it just happen

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Hi Brian, This latest version looks good to go; thanks, -Joe On 07/16/2013 06:08 PM, Brian Burkhalter wrote: Hi Joe, I've updated the webrev http://cr.openjdk.java.net/~bpb/8020641/ with these last changes. I am not preparing an hg export patch

Re: Review request: JDK-7147084 (process) appA hangs when read output stream of appB which starts appC that runs forever (v.1)

Hi Alexey, I've just had a look at the webrev. Looks good. Unfortunately I'm not a reviewer here so the only benefit was for my education I'm afraid. It would be great to get Alan's input next week. For the benefit of the alias: I had asked Alexey if an intermediate launcher akin to the one

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Hi Joe, I've updated the webrev http://cr.openjdk.java.net/~bpb/8020641/ with these last changes. I am not preparing an hg export patch until 8014319 is approved. Thanks, Brian On Jul 16, 2013, at 5:57 PM, Joe Darcy wrote: > Please reformat the BigInteger comment at > > 1915 /* The

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Hi Brian, Please reformat the BigInteger comment at 1915 /* The algorithm requires two divisions by 2 and one by 3. 1916All divisions are known to be exact, that is, they do not produce 1917remainders, and all results are positive. The divisions by 2 are 1918

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Hi Joe, On Jul 16, 2013, at 4:14 PM, Joe Darcy wrote: > I've looked over all the code in BigInteger for general consistency of > braces, spacing, etc. > > Besides the changes you're made, here are additional updates to BigInteger: I fixed all the items you pointed out along with a slew of othe

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Hi Joe, On Jul 16, 2013, at 4:14 PM, Joe Darcy wrote: > I've looked over all the code in BigInteger for general consistency of > braces, spacing, etc. > > Besides the changes you're made, here are additional updates to BigInteger: > > […] Please note that I only reviewed the portions of the c

Re: Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

On 07/16/2013 02:32 PM, Brian Burkhalter wrote: Reviewers: Issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020641 (will be public soon) Webrev http://cr.openjdk.java.net/~bpb/8020641/ Note that this patch will need to be integrated after the one for 8014319 which is pending appro

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

Thanks for the suggestion Jeremy but the JVMTI agent change is being implemented as part of the original JNI static library implementation where we explicitly prohibited dynamic libraries to be loaded if a static library of the same name is baked into the launcher. "If a library L is staticall

Java 8 RFR 8020641: Clean up some code style in recent BigInteger contributions

Reviewers: Issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020641 (will be public soon) Webrev http://cr.openjdk.java.net/~bpb/8020641/ Note that this patch will need to be integrated after the one for 8014319 which is pending approval [1]. Thanks, Brian [1] http://mail.openjdk.

Re: Java 8 RFR 8020539: Clean up doclint problems in java.util package, part 2

Hi Brian, For the changes in j.u.Random, - * pseudorandomly generated and returned. All 232 + * pseudorandomly generated and returned. All 2style="font-size:smaller;">32 I would just dispense with the size adjustment of the exponent -- the tag alone should be sufficient. Plain is us

Re: class SplittableRandom

On 07/16/13 12:55, Mike Duigou wrote: I worry that it will be difficult/impractical for those who desire a different algorithm to replace SplittableRandom with their own (P)RNG whether it be for secure randomness or better statistical properties. Since SplittableRandom doesn't implement any inte

Java 8 RFR 8020539: Clean up doclint problems in java.util package, part 2

Reviewers: Issue: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020539 Webrev: http://cr.openjdk.java.net/~bpb/8020539/ I think the only dubious change in here is in the Scanner class comments. This was previously using empty tag pairs for spacing purposes. I replaced each these with  

Java 8 RFR 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion

Reviewers: Issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6476168 Webrev http://cr.openjdk.java.net/~bpb/6476168/ Change is to clarify the javadoc specification such that the implementation is in sync. Thanks, Brian

Re: class SplittableRandom

On Jul 16, 2013, at 2:57 PM, Guy Steele wrote: > . . . > So here's the punchline: this change makes my Monte Carlo calculation of pi > run over 19% faster! > Hard to believe. It's certainly avoiding most of the hard work in > addGammaModGeorge, > and perhaps also making branch prediction total

hg: jdk8/tl/jdk: 8020557: javadoc cleanup in javax.security

Changeset: f7af15e2c95b Author:juh Date: 2013-07-16 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7af15e2c95b 8020557: javadoc cleanup in javax.security Reviewed-by: darcy ! src/share/classes/javax/security/auth/AuthPermission.java ! src/share/classes/javax/security/

Re: class SplittableRandom

On 07/16/13 14:57, Guy Steele wrote: So instead I took the latest version and modified the generation of gamma values to use a 56-bit GAMMA_GAMMA value and perform arithmetic modulo 2^56-5 ... So here's the punchline: this change makes my Monte Carlo calculation of pi run over 19% faster! Ha

Re: Review request: JDK-8016579 (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded (v.2)

I agree. Is jdk_util.c or jni_util.c or any file under native/common/ a good place? The fix looks good to me. One small comment is to get the return value of swprintf() in win32Error(). If the return value is -1, an error situation needs to be handled even though it seems very rare. If it is

RFR: 8016846: Pattern.splitAsStream tests required

Hi, Please review the webrev at, http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ The test is mostly contributed by Ben Evans. Cheers, Henry

Re: class SplittableRandom

On Jul 15, 2013, at 4:13 PM, Martin Buchholz wrote: > > On Mon, Jul 15, 2013 at 9:59 AM, Martin Buchholz wrote: >> >> Also, if gamma is much less than 2^64 (say 2^56; that number of gammas >> "should be enough for anybody"), then the above will be a little more >> efficient since the wraparound

Re: class SplittableRandom

On 07/16/13 12:41, Mike Duigou wrote: On Jul 16 2013, at 05:37 , Doug Lea wrote: Mike Duigou: It's probably reasonable to let lambda and webrev versions lag a few days until a bit more stable. Until then, see http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/SplittableRa

Re: class SplittableRandom

Maybe "SplittableRandom" should be an interface, and the current implementation called, say, "SplittableRandom64" (for its 64-bit seed). --Guy On Jul 16, 2013, at 12:55 PM, Mike Duigou wrote: > > On Jul 15 2013, at 16:11 , Doug Lea wrote: > >> On 07/15/13 12:59, Martin Buchholz wrote: >>> If

Re: class SplittableRandom

On Jul 15 2013, at 16:11 , Doug Lea wrote: > On 07/15/13 12:59, Martin Buchholz wrote: >> If we make the wraparound point for seeds Long.MIN_VALUE instead of 0L, then >> we >> can optimize addGammaModGeorge. > > This was a great suggestion; thanks! > >> >> I continue to worry that we are prod

Re: class SplittableRandom

On Jul 16 2013, at 05:37 , Doug Lea wrote: > > I incorporated updates stemming from yesterday's SplittableRandom > list and off-list traffic. Thanks as always for all the helpfulness. > > Mike Duigou: It's probably reasonable to let lambda and webrev > versions lag a few days until a bit more s

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 965d876853ec Author:attila Date: 2013-07-16 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/965d876853ec 8020357: throw RangeError for too large NativeArrayBuffer size Reviewed-by: jlaskey, hannesw, sundar ! src/jdk/nashorn/internal/objects/ArrayBufferVie

Re: RFR - Changes to address CCC 8014135: Support for statically linked agents

I updated the text in VirtualMachine.java. The new webrev is here: http://cr.openjdk.java.net/~bpittore/8014135/jdk/webrev.01/ I ran it through javadoc and you can see the result here: http://cr.openjdk.java.net/~bpittore/8014135/javadoc/index.html Let me know if you have any comments. thanks,

Re: Review request: JDK-8016579 (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded (v.2)

Here is new version of fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8016579/webrev.01/ On 7/15/2013 9:08 PM, Martin Buchholz wrote: Superficial review: Looks good mostly. Historically, switching windows code to use "W" APIs has been a big TODO, but was waiting for Win98 de-support

Re: class SplittableRandom

On Jul 16, 2013, at 3:07 AM, Martin Buchholz wrote: > > Read Appleby and Stafford ... > > Hmmm mix32 has almost the same job as mix64 - have all the bits in the > seed affect all the bits in the output, so the obvious implementation is > > mix32() { return (int) mix64(); } > or more cons

Re: class SplittableRandom

I incorporated updates stemming from yesterday's SplittableRandom list and off-list traffic. Thanks as always for all the helpfulness. Mike Duigou: It's probably reasonable to let lambda and webrev versions lag a few days until a bit more stable. Until then, see http://gee.cs.oswego.edu/cgi-bin