Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 2017/6/9 12:19, Igor Ignatyev wrote: Hi Hamlin, Hi Igor, Thank you for explanation. I'm going to add explicit @build for jdk.test.lib.** classes in jdk tests which are in :tier[1-3]. Got it. unfortunately this approach does not work if a test depends on a library indirectly, e.g. you

Re: RFR(S) : 8181759 : add explicit @build actions for jdk.test.lib classes in all :tier1 tests

as it was discussed in another thread, if we remove dependency on Utils from Platform, some of @build actions won't be needed, this will be done by 8181820[1-2]. I have created new webrev[3] using dependency graph as it will be after 8181820 integration. working on it, I've noticed that some

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Hamlin, I'm going to add explicit @build for jdk.test.lib.** classes in jdk tests which are in :tier[1-3]. unfortunately this approach does not work if a test depends on a library indirectly, e.g. you might have a couple of tests which share some code (but not from /test/lib or

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

Got it, thank you for explanation. Although I don't think it's necessary, it's harmless to add the check. Thank you -Hamlin On 2017/6/9 11:10, Amy Lu wrote: Thank you Hamlin. I actually think -Dfile.encoding=UTF-8 -Dsun.jnu.encoding=UTF-8 is enough. I added Locale.setDefault(Locale.US)

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

Thank you Hamlin. I actually think -Dfile.encoding=UTF-8 -Dsun.jnu.encoding=UTF-8 is enough. I added Locale.setDefault(Locale.US) and restore "just for safe". The encoding check (and warnings/usage) is mainly for helping one who tries to run it from command line. Thanks, Amy On 6/9/17 10:14

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Igor, I'm coping Jon as it needs Jon's comments. Thank you for doing such a great refactoring, I believe it will make tests run more stable. I saw you are adding explicit @build to lots of test, are you going to clean up all tests to add explicit @build? If the answer is "yes", then I

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

Hi Amy, For refactoring MacPathTest, I wonder if it's sufficient to just change below line? - * @run shell MacPathTest.sh + * @run main/othervm -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 -Dsun.jnu.encoding=UTF-8 MacPathTest */ Thank you -Hamlin On 2017/6/7 14:14, Amy

RFR(XXS) : 8181820: jdk/test/lib/Platform should not depend on jdk/test/lib/Utils

http://cr.openjdk.java.net/~iignatyev//8181820/webrev.00/index.html > 12 lines changed: 10 ins; 0 del; 2 mod; Hi all, could you please review this small patch which removes dependency on Utils from Platform test class? this patch is basically a part of 8181124[1] which has been integrated

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On Jun 8, 2017, at 9:35 AM, Alan Bateman wrote: > > On 08/06/2017 17:18, Igor Ignatyev wrote: >> Alan, >> >> I totally agree there are many places which we need to clean up in >> testlibraries, including these weird dependencies, but it would be much >> easier to

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

A different, more incremental approach, would be to look at the totality of the functionality being provided in libraries, and to (re)design the libraries to minimize inter-library and inter-package package dependencies, with a view to using but minimizing @build directives. (Meaning, provide

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 6/8/17 9:18 AM, Igor Ignatyev wrote: Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 6/8/17 10:48 PM, Alan Bateman wrote: On 07/06/2017 16:14, Amy Lu wrote: Defaul.java System.out.println(Charset.defaultCharset()); The output for "nonexist" (not supported) LC_ALL is (at least on Solaris): US-ASCII The output is the same as set LC_ALL from commandline: $ export

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 17:18, Igor Ignatyev wrote: Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

testing showed, that I missed one test, fixed and retested. http://cr.openjdk.java.net/~iignatyev//8181761/webrev.01/index.html > diff -r 8d381ca2a358 > test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java >

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Alan, I totally agree there are many places which we need to clean up in testlibraries, including these weird dependencies, but it would be much easier to clean up test libraries after they are merged in one place. personally I don't think that NetworkConfiguration depending on Platform is a

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On 8 Jun 2017, at 16:52, Alan Bateman wrote: > > On 08/06/2017 16:24, Igor Ignatyev wrote: >> Chris/Alan, >> >> Although the test itself doesn't launch new VMs, >> jdk.test.lib.NetworkConfiguration, which this test directly depends on, >> depends on

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 16:24, Igor Ignatyev wrote: Chris/Alan, Although the test itself doesn't launch new VMs, jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on

Re: RFR: JDK-8166748 Clean out Windows IA64 support

This is totally dead code that does nothing but it’s up to you if you want to do it later. Bob. > On Jun 8, 2017, at 10:54 AM, George Triantafillou > wrote: > > Hi Bob, > > This code change is unclear to me, and it seems to be compiler related. I'll > file

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On 8 Jun 2017, at 16:24, Igor Ignatyev wrote: > > Chris/Alan, > > Although the test itself doesn't launch new VMs, > jdk.test.lib.NetworkConfiguration, which this test directly depends on, > depends on jdk.test.lib.Platform Oh I see this now. I originally wrote

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris/Alan, Although the test itself doesn't launch new VMs, jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on jdk.test.lib.process.* classes as it might start new VMs. [1] is

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

Looks good to me. /Erik On 2017-06-08 17:17, Kumar Srinivasan wrote: Oops here are the webrevs: Delta webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ Kumar 1. Added a comment in the

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

Oops here are the webrevs: Delta webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ Kumar 1. Added a comment in the LauncherCommon.gmk, fixed typo 2. Added checks for spurious EXTRA_JAVA_ARGS, both

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

1. Added a comment in the LauncherCommon.gmk, fixed typo 2. Added checks for spurious EXTRA_JAVA_ARGS, both as compile time and runtime check, the latter for a good measure. Thanks Kumar PS: Mandy, could you please file a RFE for the jlink requirements and assign it to me. On Jun 7,

Re: RFR: JDK-8166748 Clean out Windows IA64 support

Hi Bob, This code change is unclear to me, and it seems to be compiler related. I'll file an RFE for a followup cleanup for the compiler group. It looks like it might be trivial, but I'd rather not include it in this change. Thanks. -George On 6/8/2017 8:27 AM, Bob Vandette wrote: The

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 07/06/2017 16:14, Amy Lu wrote: Defaul.java System.out.println(Charset.defaultCharset()); The output for "nonexist" (not supported) LC_ALL is (at least on Solaris): US-ASCII The output is the same as set LC_ALL from commandline: $ export LC_ALL=nonexist bash: warning: setlocale: LC_ALL:

Re: RFR: JDK-8166748 Clean out Windows IA64 support

The register code area support was only added for Windows IA64. // Give OS a chance to register generated code area. // This is used on Windows 64 bit platforms to register // Structured Exception Handlers for our generated code. os::register_code_area((char*)low_bound(),

Re: RFR: JDK-8166748 Clean out Windows IA64 support

Hi Bob, On 6/8/2017 8:12 AM, Bob Vandette wrote: I don’t see these changes in your webrev but there are a few other changes that were added specifically for IA64. The os::register_code_area function and dependency checking support was added (depChecker_{arch}.?pp). If it’s your desire to

Re: RFR: JDK-8166748 Clean out Windows IA64 support

I don’t see these changes in your webrev but there are a few other changes that were added specifically for IA64. The os::register_code_area function and dependency checking support was added (depChecker_{arch}.?pp). If it’s your desire to remove all traces of IA64, these should be removed as

Re: RFR: JDK-8166748 Clean out Windows IA64 support

Hi Lois, Thanks for the review. -George On 6/7/2017 5:35 PM, Lois Foltan wrote: Looks good George. Lois On 6/7/2017 2:50 PM, George Triantafillou wrote: Please review this fix to clean out Windows IA64 support: JBS: https://bugs.openjdk.java.net/browse/JDK-8166748 open webrev (jdk):

Re: RFR: JDK-8166748 Clean out Windows IA64 support

Hi Kim, Thanks for the review. Comments inline. On 6/7/2017 5:32 PM, Kim Barrett wrote: On Jun 7, 2017, at 2:50 PM, George Triantafillou wrote: Please review this fix to clean out Windows IA64 support: JBS: https://bugs.openjdk.java.net/browse/JDK-8166748

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 08/06/2017 11:11, Chris Hegarty wrote: : Just quickly looking at some of the networking test, e.g. JoinLeave: * @bug 4091811 4148753 4102731 * @summary Test java.net.MulticastSocket joinGroup and leaveGroup * @library /test/lib + * @build jdk.test.lib.NetworkConfiguration + *

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Igor, > On 8 Jun 2017, at 08:20, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html >> 432 lines changed: 404 ins; 1 del; 27 mod; > > Hi all, > > could you please review this changeset which adds explicit @build actions to >

VM needs to handle EXCEPTION_FLT_* exceptions on Win64

Hello, Could you backport this fix in Java 8 / 64 bits ? http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2cfad8cc3bab We are affected when we start a JVM from a C program : http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7012961 Thanks in advance, Regards, Valery LEPRETRE, Stratégies SA

RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html > 432 lines changed: 404 ins; 1 del; 27 mod; Hi all, could you please review this changeset which adds explicit @build actions to tier2 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

Hello, Build changes look good with Mandy's correction. I would also like a comment sentence explaining the reason for EXTRA_JAVA_ARGS in LauncherCommon.gmk. Otherwise we risk cleaning this away in the future. /Erik On 2017-06-08 03:12, Mandy Chung wrote: On Jun 7, 2017, at 2:58 PM, Kumar

RFR(XXXS) : 8181762 : add explicit @build actions for jdk.test.lib classes in all :tier3 tests

http://cr.openjdk.java.net/~iignatyev//8181762/webrev.00/index.html > 1 line changed: 1 ins; 0 del; 0 mod; Hi all, could you please review this one line patch which adds explicit @build actions to tier3 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].

RFR(S) : 8181759 : add explicit @build actions for jdk.test.lib classes in all :tier1 tests

http://cr.openjdk.java.net/~iignatyev//8181759/webrev.00/index.html > 117 lines changed: 111 ins; 0 del; 6 mod; Hi all, could you please review this changeset which adds explicit @build actions to tier1 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].