RFR: JDK-8021560,(str) String constructors that take ByteBuffer

Hi, Please help review the proposal to add following constructors and methods in String class to take ByteBuffer as the input and output data buffer. public String(ByteBuffer bytes, Charset cs); public String(ByteBuffer bytes, String csname); public int getBytes(byte[] dst, int offset,

Re: RFR 8197462 : Inconsistent exception messages for invalid capturing group names

Hi Ivan, The code handles group name was added later. So "historically" those cases trigger "unknow look-behind group" when the first character after "<" is not "=" or "?". With the addition of the group name support, it's actually hard to say which one is more accurate, incorrect group name

Re: RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Thank you, Roger Regards, Chris > On 13 Feb 2018, at 6:37 AM, Roger Riggs wrote: > > Hi Chris, > > I don't know DNS details well enough to validate the test assertions. > Otherwise, the code is fine. > > Regards, Roger > > > On 2/5/2018 3:15 AM, Chris Yin wrote: >>

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

Hi, Roger Many thanks for your review. Yes, there are also negative tests planned Thanks & Regards, Chris > On 13 Feb 2018, at 6:36 AM, Roger Riggs wrote: > > Hi Chris, > > Looks fine. > > These are only positive tests, are there negative tests planned? > >

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

Hi Vitaly, See this thread: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2018-February/013584.html David On 13/02/2018 6:36 AM, Vitaly Davidovich wrote: Hi all, I'm not sure if core-libs is the right mailing list for jigsaw/modules questions these days (rather than jigsaw-dev), so

Re: IllegalAccessException trying to load a ResourceBundle in 9u181

On 2/12/18 12:36 PM, Vitaly Davidovich wrote: Hi all, I'm not sure if core-libs is the right mailing list for jigsaw/modules questions these days (rather than jigsaw-dev), so please feel free to forward this there if it's the more appropriate list. cc'ing  jigsaw-dev I have the following

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

Looks good! Thanks, David On 13/02/2018 6:50 AM, harold seigel wrote: Hi Karen, Thanks for looking at this! I re-ran the ParallelClassLoading tests with no options, with -XX:+AllowParallelDefineClass, and with -XX:+AlwaysLockClassLoader, and all the tests passed.  I also determined that

Re: RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Hi Chris, I don't know DNS details well enough to validate the test assertions. Otherwise, the code is fine. Regards, Roger On 2/5/2018 3:15 AM, Chris Yin wrote: Please review the added JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java, thanks It’s to verify capability to add a

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

Hi Chris, Looks fine. These are only positive tests, are there negative tests planned? Thanks, Roger On 1/23/2018 5:14 AM, Chris Yin wrote: Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and removed unused "@modules jdk.naming.dns/com.sun.jndi.dns”, updated webrev as

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

Harold, Looks good. Many thanks! Karen > On Feb 12, 2018, at 3:50 PM, harold seigel wrote: > > Hi Karen, > > Thanks for looking at this! > > I re-ran the ParallelClassLoading tests with no options, with > -XX:+AllowParallelDefineClass, and with

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

Hi Karen, Thanks for looking at this! I re-ran the ParallelClassLoading tests with no options, with -XX:+AllowParallelDefineClass, and with -XX:+AlwaysLockClassLoader, and all the tests passed.  I also determined that the few Mach5 regression test failures that I encountered were unrelated

IllegalAccessException trying to load a ResourceBundle in 9u181

Hi all, I'm not sure if core-libs is the right mailing list for jigsaw/modules questions these days (rather than jigsaw-dev), so please feel free to forward this there if it's the more appropriate list. I have the following code carried over from java 8 (actually much earlier than that, but

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

Harold, Thanks for doing this. I think you told me that 1) the version change has made it in 2) you also put 12 as an expiration date 3) you are running the ParallelClassLoading tests with the remaining two flags (you’ve already run them without any flags): AllowParallelDefineClass = true

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Looks good. Jason From: Joe Wang Sent: Monday, February 12, 2018 12:25 PM To: Jason Mehrens Cc: core-libs-dev Subject: Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer Done. Thanks

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

On 2/9/18, 1:38 PM, Roger Riggs wrote: Hi Joe, Looking good, but a few comments: AbstractStringBuilder: 111 the coder() method should be private and since there is only a few uses the function could be inlined. Indeed, the coder() method was added along with the new method. The coder

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Done. Thanks Jason! Joe On 2/9/18, 1:46 PM, Jason Mehrens wrote: Joe, In CharSequence, does it make sense to cache the result of the length calculation? As in change: for (int i = 0; i< Math.min(cs1.length(), cs2.length()); i++) { for (int i = 0, len = Math.min(cs1.length(),

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

Hi Alan, Thanks for looking at this. Harold On 2/12/2018 2:52 AM, Alan Bateman wrote: On 12/02/2018 06:54, David Holmes wrote: Hi Harold, Adding core-libs-dev so they are aware of the ClassLoader change. Thanks, that part is okay and good to see this going away. -Alan

Re: RFR 8184289: Obsolete -XX:+UnsyncloadClass and -XX:+MustCallLoadClassInternal options

On 2/12/18 1:54 AM, David Holmes wrote: Hi Harold, Adding core-libs-dev so they are aware of the ClassLoader change. On 10/02/2018 5:44 AM, harold seigel wrote: Hi David, Thanks for reviewing this. Please see updated webrev:

Re: RFR: 8196959: NullPointerException in discovery003.java

Looks good. -Sundar On 12/02/18, 5:31 PM, Srinivas Dama wrote: Hi, Please review http://cr.openjdk.java.net/~sdama/8196959/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196959 This is small modification of fix for https://bugs.openjdk.java.net/browse/JDK-8011697. Fix is to handle

RFR: 8196959: NullPointerException in discovery003.java

Hi, Please review http://cr.openjdk.java.net/~sdama/8196959/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196959 This is small modification of fix for https://bugs.openjdk.java.net/browse/JDK-8011697. Fix is to handle the corner case where the engineName is null. Regards,

Re: RFR: 8194154 patch for crash at File.getCanonicalPath()

On 09/02/2018 18:01, Alan Bateman wrote: : I'll study the patch you have but I think we also need to create issues to get us to the point where changing this system property in a running VM doesn't impact running code. Looking at it again, I think we should change java.io.UnixFileSystem (and

Re: RFR 8190378: Java EE and CORBA modules removal

One could almost shed a tear - of joy! This is exactly the use case for the module system that the developer community at large will understand. Thanks for this change and a leaner meaner JDK. Cheers, Martijn On 8 February 2018 at 13:37, Lance Andersen wrote: > > >

Re: RFR: 8041626: [Event Request] Shutdown reason

On 12/02/2018 07:07, David Holmes wrote: Okay, I’ve removed the code related to the status field, certainly makes the change a bit less intrusive. Updated webrev: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01/ Incremental: