Re: Long chains created by direct Buffer::slice

+1 I created this issue: https://bugs.openjdk.java.net/browse/JDK-8208362 The suggested fix requires a tweak though since an instance of a DirectBuffer interface is passed. This is required because views over direct ByteBuffers can be created. Florian, i will push tomorrow and assign you

Re: [12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

Looks fine; cheers, -Joe On 7/26/2018 9:26 AM, Naoto Sato wrote: Looks good. Naoto On 7/26/18 1:34 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev:

[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

https://bugs.openjdk.java.net/browse/JDK-8207744 http://cr.openjdk.java.net/~bpb/8207744/webrev.00/ This change simply adds #if defined(_AIX) #define DIR DIR64 #define opendir opendir64 #define closedir closedir64 #endif to each of src/java.base/share/native/libjli/wildcard.c

Re: Add x-IBM-1129 charset

The change looks fine. Btw, do you guy have better implementation for these two charsets? These two were left untouched when I did the reimplementation back to 6/7. Did not have time to figure out its mapping table (especially the compatibility concern when dealing with the mapping hard-coded

Re: [12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

Looks good. Naoto On 7/26/18 1:34 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/ CSR:

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

"The input to jpackager includes: a Java runtime image, and a Java application in one of several formats..." Will it be possible to NOT include the JRE, but specify instead a pre-existing location for the JRE? As an example use-case consider an office productivity suite where there are

Re: Consider making TerminatingThreadLocal public

On 26/07/2018 10:45, Andrew Dinn wrote: : Firstly, if you look back through the core-libs-dev archive you will find discussion that preceded introduction of this change -- primarily between Alan Bateman and Tony Printezis as I recall but I think others were involved. I believe that discussion

Re: Consider making TerminatingThreadLocal public

Hi Norman, On 26/07/18 09:35, Norman Maurer wrote: > So I take this as a sign that there is no interest in this ? I'm not sure that is the right conclusion to draw. It may well be that those involved in making the original change are too busy to respond right now. However, there are a two other

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Hi Chris, Thanks for writing the tests overall code looks good to me, below are few minor comments. 1`-> Fix tag order, my Netbeans always complains :) . 2->  you make AuthRecursiveBase class as public but i can not see it is being used outside,  i will suggest you to give the default

Re: Add x-IBM-1129 charset

Thank you Alan for your response. > and to be clear, I think what you are doing here is adding IBM-1129 to > java.base on AIX builds and adding it to jdk.charsets on other > platforms. There isn't any build infrastructure at this time to do > otherwise and maybe that is something that will

Re: Consider making TerminatingThreadLocal public

So I take this as a sign that there is no interest in this ? Bye Norman > On 10. Jul 2018, at 12:06, Norman Maurer wrote: > > Hi all, > > It came to my attention that you introduced TerminatingThreadLocal in openjdk > lately as an “internal class”: > >

[12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/ CSR: https://bugs.openjdk.java.net/browse/JDK-8208071 Fix: Changed the ChoiceFormat's

[12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

Please review the changes to add another 8 JNDI tests to com/sun/jndi/dns/EnvTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208279 webrev: http://cr.openjdk.java.net/~xyin/8208279/webrev.00/

Re: Add x-IBM-1129 charset

On 25/07/2018 11:52, Nasser Ebrahim wrote: Hello, I had kept aside this discussion for a while as there is a parallel discussion on whether to move the IBM charsets on openjdk to a different location or outside JDK[ http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054248.html