.
@Alexey: Then, how much work do you see in reactivating service bundler?
Cheers
Jörg
-Original Message-
From: Kevin Rushforth [mailto:kevin.rushfo...@oracle.com]
Sent: Donnerstag, 12. Juli 2018 01:09
To: Buchberger, Joerg ;
core-libs-dev@openjdk.java.net
Cc: Alexey Semenyuk ; Andy
Andy,
IMHO if you are renaming defines in C++ code, it makes sense to rename
variables/functions too:
JVMArgs -> JavaArgs in
http://cr.openjdk.java.net/~herrick/8221582/webrev.02/src/jdk.jpackage/share/native/libapplauncher/Helpers.cpp.sdiff.html
Package::ReadJVMArgs -> Package::ReadJavaArgs
think we should file this as a follow on fix.
My main concern first was the public facing names, but as with other
modified options, it would be best to go back and clean all internal
names to reflect the current naming.
/Andy
-- Kevin
On 3/28/2019 10:50 AM, Alexey Semenyuk wrote:
Andy
Hi,
RFE for jpackage to replace Inno Setup in exe installers for Windows was
filed recently and available at
https://bugs.openjdk.java.net/browse/JDK-8221333.
RFE was filed based on an assumption it will not have a major impact on
users of jpackage. Please let us know in the comments to the
dk.java.net/~almatvee/8224597/webrev.02/
Updated OS X tests to use XML APIs to parse Info.plist.
Thanks,
Alexander
On 6/6/2019 2:43 PM, Alexey Semenyuk wrote:
Any particular reason not to use xml api to read xml files?
The way to extract app attributes from xml files produced by jpackage
looks
Looks good.
- Alexey
On 6/6/2019 5:45 PM, Andy Herrick wrote:
revised to use Files.newBufferedWriter() in
JPackageHelper.cmdWithAtFilename() as suggested.
webrev: http://cr.openjdk.java.net/~herrick/8224130/webrev.02/
/Andy
On 6/6/2019 1:03 PM, Alexey Semenyuk wrote:
http
Looks good.
- Alexey
On 6/5/2019 7:52 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8222901
[2]
Looks good.
- Alexey
On 6/5/2019 8:01 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8223241
[2]
Looks good.
- Alexey
On 6/5/2019 8:03 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8223953
[2]
Looks good.
- Alexey
On 6/5/2019 8:06 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8224748
[2]
Looks good.
- Alexey
On 6/5/2019 8:14 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8223212
[2]
http://cr.openjdk.java.net/~herrick/8224130/webrev.01/test/jdk/tools/jpackage/helpers/JPackageHelper.java.sdiff.html:
---
try (PrintWriter out = new PrintWriter(new BufferedWriter(
520 new FileWriter("argfile.cmds" {
521 out.println(fileString);
522
http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html,
lines 81-93 can be replaced with a single statement, something like:
---
java.nio.file.Files.copy(
new ByteArrayInputStream(baos.toByteArray()),
Looks good.
- Alexey
On 6/5/2019 8:14 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8223586
[2]
Any particular reason not to use xml api to read xml files?
The way to extract app attributes from xml files produced by jpackage
looks fragile.
- Alexey
On 6/6/2019 5:37 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch
Looks good.
- Alexey
On 6/6/2019 3:48 PM, Andy Herrick wrote:
OK - revised MacCertificate as per below:
webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03
/Andy
On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage
Looks good.
- Alexey
On 6/14/2019 10:17 AM, Andy Herrick wrote:
Please review the revised jpackage fix [3] for issue [1]
revised to use Path.of() in JPackagePath test helper and to centralize
code that creates output dirs and/or makes sure they are empty and
writable.
[3]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Get rid of dependency on Inno Setup for .exe installers on Windows
platform.
[1] https://bugs.openjdk.java.net/browse/JDK-8221333
[2]
y
On 6/14/2019 1:09 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Get rid of dependency on Inno Setup for .exe installers on Windows
platform.
[1] https://bugs.ope
Looks good!
- Alexey
On 6/14/2019 6:42 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by disabling loading external DTD files.
[1]
, Semyon Sadetsky wrote:
On 6/7/19 9:52 AM, Alexey Semenyuk wrote:
Not quite exactly what I meant by suggesting to use xml api. Sorry
for not being specific. With DOM and Xpath this can be as simple as
the following:
XPath is DOM based = slow. That point is not clear.
--Semyon
---
package
In
http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.cpp.sdiff.html,
JavaOptions::AppendValues(), why do we need branching based on the
result of Values.GetAllowDuplicates()? Why can't we use the same logic
that was
Andy,
I was just curios why we don't use Paths. If we should then I'll use
this API in my patches. I didn't mean to ask you do the clean up in all
the sources :)
- Alexey
On 6/13/2019 3:34 PM, Andy Herrick wrote:
On 6/13/19, 2:00 PM, Alexey Semenyuk wrote:
Looks good.
Q: any good
Looks good.
Q: any good reason we are not using
Paths.get(a, b, c)
instead of
a + File.separator + b + File.separator + c
to build paths?
- Alexey
On 6/13/2019 1:21 PM, Andy Herrick wrote:
Sorry - subject was missing, this is for: JDK-8225569: jpackage
app-image layout
/Andy
On 6/13/2019
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html:
---
private static final String [] RESULT_7 = {"--module-path",
"--runtime-image", "app-image"};
---
Should it be "--app-image"?
- Alexey
On 6/19/2019 1:34 PM, Andy
Looks good.
- Alexey
On 6/20/2019 12:54 PM, Andy Herrick wrote:
On 6/19/2019 1:34 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8225428: CLI change to remove "mode",
Looks good
- Alexey
On 6/21/2019 9:01 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Trivial fix to clean up the temp directory created by jpackage.
[1]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
src\jdk.jpackage\windows\classes\jdk\jpackage\internal\WinMsiBundler.java:
- code running candle.exe on WiX sources reworked. Before the fix
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Improve code detecting version of Inno Setup to make it work with Inno
Setup v6 updates.
[1] https://bugs.openjdk.java.net/browse/JDK-8224222
[2]
s the only option that I
found working.
- Alexey
On 5/20/2019 6:07 PM, Alexander Matveev wrote:
Hi Alexey,
Is there better way to figure out InnoSetup version? Creating empty
project file seems complicated.
If there no such way, then fix looks fine.
Thanks,
Alexander
On 5/20/2019 8:27 AM, Alexe
Hi Tom,
What is your jpackage command line? Could you please rerun it with
JPACKAGE_DEBUG environment variable set to "true".
- Alexey
On 4/30/2019 11:15 AM, Tom Anderson wrote:
Hello,
I am trying out the early-access jpackage tool. It works perfectly on
Linux, but on Windows produces a
in-jar, jpackage-demo.jar]
I should note that i am running the build using JDK 11, then using the
early access JDK 13 only to run jpackage at the end.
Regards,
tom
On Wed, 1 May 2019, Alexey Semenyuk wrote:
Hi Tom,
What is your jpackage command line? Could you please rerun it with
JPACKAGE_
Some findings:
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher/Launcher-jdk.jpackage.gmk:
I think definitions of BUILD_JPACKAGE_APPLAUNCHEREXE and
BUILD_JPACKAGE_APPLAUNCHERWEXE targets should be moved to
the heat.exe tool on the
application image.
Scott
On May 2, 2019, at 5:08 PM, Andy Herrick wrote:
Alexey:
Please file Bugs for these two issues.
/Andy
On 5/2/2019 1:49 PM, Alexey Semenyuk wrote:
Some findings:
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher
Andy,
I've created the following CRs to track the findings:
https://bugs.openjdk.java.net/browse/JDK-8223325
https://bugs.openjdk.java.net/browse/JDK-8223323
- Alexey
On 5/2/2019 5:08 PM, Andy Herrick wrote:
Alexey:
Please file Bugs for these two issues.
/Andy
On 5/2/2019 1:49 PM, Alexey
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Eliminate unexpected console window in .exe installers on Windows
platform.
[1] https://bugs.openjdk.java.net/browse/JDK-8226835
[2]
Bug ID is JDK-8226835.
- Alexey
On 6/26/2019 2:52 PM, Andy Herrick wrote:
We need to investigate this further, I have created issue: JDK-8221333
to track this issue.
Thank you for you feedback.
/Andy
On 6/25/2019 9:17 AM, Rachel Greenham wrote:
I've been getting the new jpackage working
Andy,
The fix suppresses warning for system wide installations too,not just
for per user. Is this by intention?
- Alexey
On 7/12/2019 10:31 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
Looks good.
- Alexey
On 6/26/2019 7:09 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8226599
[2]
Looks good.
- Alexey
On 7/15/2019 7:48 AM, Andy Herrick wrote:
revised [3] to only suppress these warnings when
--win-per-user-install option used
[3] http://cr.openjdk.java.net/~herrick/8220807/webrev.02/
/Andy
On 7/12/2019 1:22 PM, Alexey Semenyuk wrote:
Andy,
The fix suppresses
Looks good.
On 7/1/2019 1:07 PM, Andy Herrick wrote:
Updated webrev at
https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use
Files.isReadable()
/Andy
On 6/29/2019 9:54 AM, Kevin Rushforth wrote:
The rest of the CommandLine class uses nio Paths/Files, so the
following might be
Looks good.
- Alexey
On 6/28/2019 1:59 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8226904
[2]
Looks good.
- Alexey
On 8/12/2019 8:38 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by adding --install-dir folders to RemoveFile table as per
Wixs
Looks good.
- Alexey
On 8/10/2019 6:44 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This change will remove the "bin" directory on windows and revert to
putting the
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Install license file in the correct location in stead of the app's
installation directory, update corresponding jtreg tests.
[1]
Looks good.
- Alexey
On 8/13/2019 3:56 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229138?filter=-1
[2]
Makes sense. Looks good then.
- Alexey
On 8/16/2019 3:08 PM, Andy Herrick wrote:
On 8/16/2019 2:26 PM, Alexey Semenyuk wrote:
Andy,
I think we want this change in all Windows jtreg tests as they all
use this windowless Hello test.
yes - but except for testing launching app from shortcut
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- add --linux-app-category command line option
[1] https://bugs.openjdk.java.net/browse/JDK-8213941
2]
Andy,
I think we want this change in all Windows jtreg tests as they all use
this windowless Hello test.
- Alexey
On 8/16/2019 2:22 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository
exceptions, theses two and one other were the only
places actually calling Log.debug()
/Andy
On 8/15/2019 3:09 PM, Alexey Semenyuk wrote:
Andy,
What is the reason to remove log statements in
http://cr.openjdk.java.net/~herrick/8224594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage
to decide what to include in verbose output.
We used to have both debug and verbose output, but other than printing
out exceptions, theses two and one other were the only places actually
calling Log.debug()
/Andy
On 8/15/2019 3:09 PM, Alexey Semenyuk wrote:
Andy,
What is the reason to remove log
Andy,
What is the reason to remove log statements in
http://cr.openjdk.java.net/~herrick/8224594/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java.sdiff.html
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control files to address issues reported by lintian
- fix jtreg tests
- change
Looks good.
Just curious why changes in FileAssociationsBase.java files?
- Alexey
On 8/19/2019 3:33 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- change format of the default copyright file to comply with Debian
packaging requirements;
- install copyright file in proper location to comply with
If not, would it be better to keep
"deb" in the name?
-- Kevin
On 8/19/2019 9:25 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- change format of the defau
Looks good.
BTW, we can statically link with runtime app launcher and avoid copying
a bunch of MS dll-s to install bin directory.
- Alexey
On 8/19/2019 7:23 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of
On 8/19/2019 8:17 PM, Andy Herrick wrote:
On 8/19/2019 7:51 PM, Alexey Semenyuk wrote:
Looks good.
BTW, we can statically link with runtime app launcher and avoid
copying a bunch of MS dll-s to install bin directory.
I'm not sure if that's true, but it would be great if it is. The app
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- bad merge fix
[1] https://bugs.openjdk.java.net/browse/JDK-8229750
[2] http://cr.openjdk.java.net/~asemenyuk/8229750/webrev.00/
Thanks,
Alexey
Looks good.
- Alexey
On 8/16/2019 4:36 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229791
[2]
On 8/16/2019 11:28 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- add --linux-app-category command line option
[1] https://bugs.openjdk.java.net/browse/JDK-8213941
2
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix implementation of --linux-app-release CLI option for Debian packaging;
- use value of --linux-app-release CLI option to construct Debian
package
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8224833
[2] http://cr.openjdk.java.net/~asemenyuk/8224833/webrev.00/
Thanks,
Alexey
Looks good.
- Alexey
On 8/30/2019 7:44 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
1) This file is not used and was removed.
2) This file was removed due to
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- added jtreg test for --linux-app-category option;
- added jtreg test for --linux-release option; This is to address [3] issue;
- introduced helper
out my high priority
jpackage assignments.
I'll need some help with step 3.
- Alexey
Thanks,
Alexander
On 8/30/2019 2:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage
Looks good.
Some files in the review contain no diffs though, like
http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html.
Why are they in the review?
- Alexey
On 8/28/2019 9:36 AM, Andy Herrick wrote:
Please review the
Understood. Thank you for explanation.
- Alexey
On 8/28/2019 12:43 PM, Andy Herrick wrote:
On 8/28/2019 11:47 AM, Alexey Semenyuk wrote:
Looks good.
Some files in the review contain no diffs though, like
http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows
Looks good.
- Alexey
On 8/29/2019 2:18 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8230152
[2]
The default WiX source file used by jpackage is [1].
WiX variables set by jpackage and referenced from this file have "Jp"
prefix. The meaning of the variables is explained in doc comment of [2]
file. It is also documented what WiX source files are generated by jpackage.
So if you need to
Hi Rachel,
Thank you for your feedback. I created
https://bugs.openjdk.java.net/browse/JDK-8230668 record to track work on
your suggestions.
- Alexey
On 9/5/2019 8:50 AM, Rachel Greenham wrote:
(Sorry for non-threading, i read the digest)
As you've been lacking feedback from people using
Hi Sverre,
Thank you for your feedback.
I've filed [1] bug to address Debian packaging issue.
As for your question regarding release number, it is not supported by
WiX on Windows. See [2].
Also product version string should follow quite strict rules [3].
However you can encode release value
SimplePackageTest.java:
I'd suggest to put "Installer should not create any shortcuts" in the
description or simply remove notice about shortcuts.
Did you omit adding shortcuts to LinuxDebBundler.java on purpose?
- Alexey
On 9/11/2019 9:07 PM, Andy Herrick wrote:
Please review the jpackage
Looks good.
- Alexey
On 9/11/2019 11:46 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Error mentioned in bug report was due to missing Xcode when running
SetFile.
checked file list used to
create webrev contains all changed files).
/ANdy
On 9/11/2019 10:09 PM, Alexey Semenyuk wrote:
SimplePackageTest.java:
I'd suggest to put "Installer should not create any shortcuts" in the
description or simply remove notice about shortcuts.
Did you omit adding
Looks good, though
---
List args = new ArrayList<>();
940 args.addAll(Arrays.asList("codesign",
941 "--verify",
942 file.toString()));
943
944 ProcessBuilder pb
945 = new ProcessBuilder(args.toArray(new
String[args.size()]));
Thank you, looks good.
- Alexey
On 9/12/2019 5:44 PM, Alexander Matveev wrote:
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8230629/webrev.01
I simplified isFileSigned() as you suggested.
Thanks,
Alexander
On 9/12/2019 4:13 AM, Alexey Semenyuk wrote:
Looks good, though
---
List args
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- reworked jpackage tests that produce platform specific packages to get
rid of code duplication;
- replaced install.sh/uninstall.sh scripts on Linux
http://cr.openjdk.java.net/~herrick/8230519/webrev.01/test/jdk/tools/jpackage/share/RuntimeTest.java.sdiff.html:
---
37 "--package-type", "app-image",
38 "--package-type", "app-image",
---
Duplication by accident?
On 9/9/2019 1:28 PM, Andy Herrick wrote:
On 9/9/19 1:14 PM, Kevin Rushforth wrote:
Looks good with one question:
In Arguments.java:
+ if (bundler.isDefault()) {
+ return bundler;
+ } else {
+
Looks good.
- Alexey
On 9/9/2019 3:15 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
modifies the name of options:
--temp-root, --linux-bundle-name ,
On 9/17/2019 3:17 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
On Windows when building MSI, the original application name was
determined by looking into the /app dir
Looks good.
- Alexey
On 9/17/2019 10:42 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Added link to "/Application" folder to DMG for drag and drop app to
this
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- Move common deb and rpm packaging code in the new class
(jdk.jpackage.internal.LinuxPackageBundler).
- Implement Java runtime packaging
obsolete tests as per Alexey suggestion.
Thanks,
Alexander
On 9/12/2019 8:16 PM, Alexey Semenyuk wrote:
On 9/12/2019 10:47 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.sdiff.html:
---
126
Hi Heiko,
Thank you for giving a try to jpackage and for your feedback!
Please find comments inlined.
On 9/10/2019 4:55 AM, Heiko Wagner wrote:
I am sending this feedback as suggested by the jpackage project
(https://jdk.java.net/jpackage/). I hope this is considered helpful
information.
I
On 9/12/2019 10:47 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.sdiff.html:
---
126 Path destPath = Paths.get(".").toAbsolutePath();
127 if (destPath.g
http://cr.openjdk.java.net/~almatvee/8230521/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.sdiff.html:
---
126 Path destPath = Paths.get(".").toAbsolutePath();
127 if (destPath.getFileName().toString().equals(".")) {
128 dest =
Looks good.
- Alexey
On 7/29/2019 3:19 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8228744
[2]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add comments to Windows jtreg tests to help SQE setup their testing.
[1] https://bugs.openjdk.java.net/browse/JDK-8229252
[2]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add all ascending subdirectories of application installation directory
to the package.
[1] https://bugs.openjdk.java.net/browse/JDK-8215446
[2]
the package will own "/opt" directory if installation directory of the
package would be "/opt/a/b". I just verified that uninstalling the
package doesn't affect unrelated contents of "/opt" directory.
- Alexey
Thanks,
Alexander
On 8/8/2019 8:49 AM, Alexey S
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add build flag to statically link exe wrapper for msi files with MS
runtime lib.
[1] https://bugs.openjdk.java.net/browse/JDK-8229334
[2]
Looks good.
- Alexey
On 8/8/2019 8:31 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8224788: jpackage fails on OS X when using --runtime-image
[1]
Looks good.
Unfortunately the new test helper classes don't support --module option
yet and the test can not be implemented based on them.
- Alexey
On 9/20/2019 5:54 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch
Looks good.
- Alexey
On 9/26/2019 6:57 AM, Andy Herrick wrote:
Revised [3] to remove the change to CreateJmods.gmk since it is not
needed as the module will be resolved because it provides an
implementation of ToolProvider.
[3] http://cr.openjdk.java.net/~herrick/8230649/webrev.03/
/Andy
imports.
This is how Netbeans manages imports. I don't touch this part of the
code, just click on "Fix Imports" menu item and magic happens :)
- Alexey
Looks fine.
Thanks,
Alexander
On 9/23/2019 4:49 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
Thi
Andy,
Please remove javadoc update about `--linux-deb-copyright-file` option.
It will be dropped in https://bugs.openjdk.java.net/browse/JDK-8231277
patch.
Line 180:
---
if (additional.containsKey("java-optiions")) {
---
Looks like a typo. Should be "java-options", not "java-optiions", I
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8231721
[2] http://cr.openjdk.java.net/~asemenyuk/8231721/webrev.00/
Hi Sverre,
Thank you for doing this research. I don't think we should complicate
jpackage by adding signing steps in it.
However we can add a call to custom script after msi is constructed but
before it get embedded in exe installer.
This script can sign msi.
We already support call of custom
1 - 100 of 631 matches
Mail list logo
