This is a followup to the recent discussion on:
http://mail.openjdk.java.net/pipermail/net-dev/2013-July/006889.html
(cont'd)
http://mail.openjdk.java.net/pipermail/net-dev/2013-August/006914.html
Two DatagramPacket constructors declare that they throw SocketException.
Thanks for taking this Ivan.
Can you please make the changes suggested by both David and Alan (
simply return NULL/-1/JNI_FALSE, as appropriate, if GetStringUTFChars
fails ( returns NULL ), then I will sponsor this change into jdk8 for you.
Please post an update webrev to
On 08/08/2013 03:11 AM, Jonathan Gibbons wrote:
On 08/07/2013 07:10 PM, Stuart Marks wrote:
I'd suggest putting a comment at the top of the test class saying that
this test *must* be run in othervm mode, to ensure that files are
closed properly. That way, you can take out the cleanupFiles()
Looks ok to me Paul.
-Chris.
On 08/08/2013 10:03 AM, Paul Sandoz wrote:
Hi,
The following patch fixes issues with the spliterators of ConcurrentSkipListMap:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8022326-CSLM-split/webrev/
Similar changes have already been made to TreeMap, which is
On 08/08/2013 10:00 AM, Paul Sandoz wrote:
Hi,
The following patch updates documentation for various spliterators:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8014824-split-docs/webrev/
Mostly this is just clarifying stuff that was missing, but there are a few
cases of a spec change to
-Memleak-in-NetworkInterface.patch
Sincerely yours,
Ivan
On 08.08.2013 12:43, Chris Hegarty wrote:
Thanks for taking this Ivan.
Can you please make the changes suggested by both David and Alan (
simply return NULL/-1/JNI_FALSE, as appropriate, if GetStringUTFChars
fails ( returns NULL ), then I
/
The test gets past with the fixed jdk8 and fails with jdk8-b101 and
jdk7
as expected.
Sincerely yours,
Ivan
On 08.08.2013 17:50, Chris Hegarty wrote:
Looks good to me. Thanks Ivan.
-Chris.
On 08/08/2013 02:33 PM, Ivan Gerasimov wrote:
Hello Chris!
Here's the update:
http://cr.openjdk.java.net
11:25, Chris Hegarty wrote:
On 09/08/2013 06:47, David Holmes wrote:
Sorry I messed this up. The JNI book says GetStringUTFChars will return
NULL and post OOME but the JNI spec (latest version 6.0) does not - it
only says it will return NULL on failure.
This is indeed strange. Most usages
Changeset: 84004d0e3fdd
Author:chegar
Date: 2013-08-09 13:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd
8022661: InetAddress.writeObject() performs flush() on object output stream
Reviewed-by: michaelm, alanb
! src/share/classes/java/net/InetAddress.java
On 09/08/2013 11:36, Lance Andersen - Oracle wrote:
Hi Joe,
The changes look fine
+1 Looks ok to me. Pitty we have to maintain this kind of usage!
-Chris.
Best
Lance
On Aug 9, 2013, at 1:57 AM, huizhe wang wrote:
Hi,
The root cause of this issue is that SPECJVM2008 uses a 3rd party
These changes address the remaining lint warnings in the
j.u.concurrent.** package(s).
The changes are already in the JSR166 CVS, this is a request to bring
them into jdk8.
diff -r 84004d0e3fdd
src/share/classes/java/util/concurrent/CompletableFuture.java
---
Changeset: ce1c874903cb
Author:dl
Date: 2013-08-09 17:56 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb
8022724: lint warnings in j.u.concurrent packages
Reviewed-by: chegar, lancea, darcy
! src/share/classes/java/util/concurrent/CompletableFuture.java
!
Thanks for doing this Amy.
The changes look fine to me. I wonder if there would be any opposition
to adding java/util/Collection/MOAT.java, until 8020536 can be addressed.
-Chris.
P.S. I can sponsor this change for you, if you need a sponsor.
On 12/08/2013 09:36, Amy Lu wrote:
ProblemList
Looks good to me too.
-Chris.
On 12/08/2013 09:20, Paul Sandoz wrote:
On Aug 11, 2013, at 8:12 PM, Aleksey Shipilevaleksey.shipi...@oracle.com
wrote:
On 08/11/2013 03:39 PM, Peter Levart wrote:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.02/
Thanks Peter, this
/2013 10:12, Alan Bateman wrote:
On 12/08/2013 09:57, Chris Hegarty wrote:
Thanks for doing this Amy.
The changes look fine to me. I wonder if there would be any opposition
to adding java/util/Collection/MOAT.java, until 8020536 can be addressed.
-Chris.
P.S. I can sponsor this change for you
and a regression test.
Webrev: http://cr.openjdk.java.net/~igerasim/8022584/6/webrev/
Hg export:
http://cr.openjdk.java.net/~igerasim/2commit/8022584-jdk8-Memleak-in-NetworkInterface.patch
Sincerely yours,
Ivan
On 09.08.2013 16:18, David Holmes wrote:
Hi Chris,
On 9/08/2013 8:36 PM, Chris Hegarty wrote
Changeset: 18e15d92610b
Author:chegar
Date: 2013-08-13 14:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18e15d92610b
8022779: ProblemList.txt updates (8/2013)
Summary: Update ProblemList and remove AggressiveOpts MOAT test run
Reviewed-by: chegar, alanb
Contributed-by:
On 08/13/2013 04:24 PM, Alan Bateman wrote:
On 13/08/2013 14:46, Ivan Gerasimov wrote:
Hello!
Would you please help review a simple fix of a typo in the Java doc?
s/str/this/
The fix if for jdk8.
BUGURL: http://bugs.sun.com/view_bug.do?bug_id=8016018
WEBREV:
Looks fine Joe.
-Chris.
On 08/13/2013 05:43 PM, Joe Darcy wrote:
Hello,
Please review this simple patch below which corrects a recently
introduced doclint issue (8015666: test/tools/pack200/TimeStamp.java
failing).
Thanks,
-Joe
diff -r cc64a05836a7
* @throws ArrayIndexOutOfBoundsException
* if the {@code off} is negative, or the {@code len} is
* negative, or the {@code off+len} is greater than the
* length of the array {@code b}
I agree that specifying this in CRC32 and Adler32 is the right thing to
do.
The code changes look ok to me.
-Chris.
On 14/08/2013 13:30, Alan Bateman wrote:
As part of the Compact Profiles [1] solution we updated the JAR File
specification to define a new attribute named Profile to allow both
main application and library JAR files specify the minimum subset
Profile
Source changes that follow Doug's mail on lambda-libs-spec-observers
http://mail.openjdk.java.net/pipermail/lambda-libs-spec-observers/2013-August/002361.html
These changes are already in the jsr166 CVS, and there is a test in
OpenJDK that verifies the change.
diff --git
Typo that crept in during a refactoring.
http://cs.oswego.edu/pipermail/concurrency-interest/2013-August/011695.html
This change is already in the jsr166 CVS.
diff --git
a/src/share/classes/java/util/concurrent/ConcurrentHashMap.java
Changeset: 7d7d553a8c61
Author:igerasim
Date: 2013-08-13 13:04 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7d553a8c61
8022584: Memory leak in some NetworkInterface methods
Reviewed-by: alanb, dholmes, chegar, michaelm
! src/solaris/native/java/net/NetworkInterface.c
+
Changeset: 3223342fb76e
Author:dl
Date: 2013-08-15 15:01 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3223342fb76e
8023103: FJ parallelism zero
8020537: java/util/concurrent/forkjoin/ThrowingRunnable.java
Reviewed-by: chegar, mduigou, alanb
!
Changeset: b07b19182e40
Author:dl
Date: 2013-08-15 15:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07b19182e40
8023104: ConcurrentHashMap typo
Reviewed-by: chegar, mduigou
! src/share/classes/java/util/concurrent/ConcurrentHashMap.java
Changeset: e7137695dce3
Author:chegar
Date: 2013-08-15 15:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7137695dce3
8022126: Remove throws SocketException from DatagramPacket constructors
accepting SocketAddress
Reviewed-by: smarks, alanb, michaelm, darcy
!
I see no objections to this, and I think it has been through enough
review. I'll sponsor this change for Aleksej.
-Chris.
On 13/08/2013 10:20, Aleksej Efimov wrote:
Stuart,
Thanks for your comments.
New webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.03/
On 16/08/2013 11:37, Alan Bateman wrote:
On 16/08/2013 11:27, Paul Sandoz wrote:
Hi,
This patch fixes a compilation failure in the stream-based tests:
diff -r 5649837a4cfa
test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
---
Looks ok to me.
-Chris.
On 12/08/2013 13:22, Paul Sandoz wrote:
Hi,
The following patch updates documentation for various spliterators in the
j.u.concurrent package:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8022318-concurrent-split-docs/webrev/
This syncs from the 166 repo and the
On 19/08/2013 09:35, Alan Bateman wrote:
On 19/08/2013 01:44, Dan Xu wrote:
HiAll,
Please review the simple change for JDK-8023203 - Wrap
RandomAccessFile.seek native method into a Java helper method. Itadds
a helper java method and makes it the only place that can invoke the
native method
Changeset: 00dcfaa6bc01
Author:aefimov
Date: 2013-08-16 18:40 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
!
Changeset: 11ccaabdb2a8
Author:aefimov
Date: 2013-08-16 18:41 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
+
Looks good to me Paul.
Trivially, typo in Spliterator.java
'structural interface' - 'structural interference'
-Chris.
On 12/08/2013 13:12, Paul Sandoz wrote:
Hi,
I have updated this webrev to remove documenting empty/singleton collections
(that will be tackled as a separate issue):
On 08/20/2013 07:54 PM, Mike Duigou wrote:
Paul Sandoz pointed out (again) that I let synchronized slip back into the
split out patch.
http://cr.openjdk.java.net/~mduigou/JDK-8023306/1/webrev/
Yes, the sycn free versions look better.
-Chris.
Corrects this error.
Mike
On Aug 20 2013, at
Looks good to me.
-Chris
On 21 Aug 2013, at 15:31, Markus Grönlund markus.gronl...@oracle.com wrote:
Thanks for taking a look at these old bugs Staffan.
Looks good (not a Reviewer).
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 21 augusti 2013 16:21
To:
Stuart,
I think I would have picked the more common IPv4 loopback address,
127.0.0.1, but what you have is fine.
-Chris.
On 08/22/2013 01:58 AM, Stuart Marks wrote:
Hi all,
Please review this small documentation change to the example I added to
RMISocketFactory a couple weeks ago [1]. This
On 08/20/2013 11:04 AM, Alan Bateman wrote:
On 20/08/2013 07:23, Miroslav Kos wrote:
Hi everybody,
I prepared a new changeset containing no copyright changes so we can
get further: http://cr.openjdk.java.net/~mkos/8022885/webrev.01/
We will discuss rngom changes separately and if necessary,
On 08/22/2013 08:46 PM, Alan Bateman wrote:
On 22/08/2013 20:41, Brian Burkhalter wrote:
JDK 8 Reviewers:
The proposed patch is here:
http://cr.openjdk.java.net/~bpb/6470700/
JTREG tests pass and JMH benchmarking shows a very slight performance
improvement versus the extant code.
It looks
Changeset: 223be1d3494f
Author:bpb
Date: 2013-08-22 13:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/223be1d3494f
6470700: Math.random() / Math.initRNG() uses double checked locking
Summary: Replace class Random variable with a static final holder class
Reviewed-by:
Changeset: b99d7e355d4b
Author:mkos
Date: 2013-08-23 09:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b99d7e355d4b
8022885: Update JAX-WS RI integration to 2.2.9-b14140
8013016: Rebase 8009009 against the latest jdk8/jaxws
Reviewed-by: alanb, chegar
!
Changeset: d8593d8581df
Author:mkos
Date: 2013-08-23 11:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d8593d8581df
8023636: Missing files from 8022885
Reviewed-by: alanb, chegar
+ src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/StreamingSOAP.java
+
On 23/08/2013 23:13, Mike Duigou wrote:
Looks like the same text as agreed on the Lambda EG list. So, +1
Yeap, looks good to me too. ( It has been a long road! )
-Chris.
Mike
On Aug 23 2013, at 14:35 , Henry Jen wrote:
Hi,
Please review the javadoc spec change for AutoCloseable.
On 28/08/2013 00:09, Xueming Shen wrote:
On 08/27/2013 03:07 PM, Martin Buchholz wrote:
It does seem vaguely reasonable to support any extra data.
Don't you want to also handle arbitrary byte arrays, if e.g. one the
16-bit size fields overflows the extra data?
It looks to me like getExtraLen
This is a small issue that was spotted by one of the TCK engineers.
Trivially, the args should be long.
Doug has already pull this change into his CVS. This RFR is to pull the
change into JDK8.
diff --git
a/src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java
Thanks Alan.
On 09/02/2013 01:19 PM, Alan Bateman wrote:
On 02/09/2013 13:10, Chris Hegarty wrote:
This is a small issue that was spotted by one of the TCK engineers.
Trivially, the args should be long.
Looks fine to me (and no compatibility issues as these are new methods
in 8).
Yes
Changeset: 441da45931fa
Author:chegar
Date: 2013-09-02 14:02 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/441da45931fa
8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for
new value arg
Reviewed-by: alanb, psandoz
!
On 09/02/2013 07:06 PM, Seán Coffey wrote:
This might be a slightly easier one to read. (fast path logic code first)
http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/
The 'javaAWTAccess != null ' checks are redundant. It will always be the
case, right?
-Chris.
regards,
Sean.
On 09/02/2013 06:45 PM, Nick Williams wrote:
On Sep 2, 2013, at 9:59 AM, Alan Bateman wrote:
It was a non goal of JEP 176 to provide @CallerSensitive as a public API. So
the suggestion to start out small was to leave that out and focus on some of
the use-cases initially. I don't think this
On 2 Sep 2013, at 20:07, Seán Coffey sean.cof...@oracle.com wrote:
Chris -
you're right on the redundant checks. Had to re-read it! Will get those
removed. Thanks.
Otherwise looks fine to me.
-Chris.
regards,
Sean.
On 02/09/13 19:15, Chris Hegarty wrote:
On 09/02/2013 07:06 PM
On 2 Sep 2013, at 22:58, Seán Coffey sean.cof...@oracle.com wrote:
Some minor modification (and further simplifying of conditions) :
http://cr.openjdk.java.net/~coffeys/webrev.8023563.3/webrev/
Looks good to me.
-Chris.
regards,
Sean.
On 02/09/13 21:07, Alan Bateman wrote:
On
David,
I share Alan's concerns about the maintainability of this, but I don't
have a better answer ( without much reorganizing/tagging ).
Out of interest, how did you come up with the lists? For example,
java/net/URLClassLoader/closetest/GetResourceAsStream.java is in
needs_jdk. I presume
Sean,
I remember discussing this (offlist) with you a while back, and I agree
with the proposed solution.
The logic for checking the system property looks a little odd. But I
will admit views differ on exactly what values should be accepted. So,
trivially I would suggest making keepAlive
On 09/03/2013 01:53 PM, Seán Coffey wrote:
First option sounds good to me too Miran. Sounds like we can expect this
fix to be sync'ed into JDK8 from JAXWS team over next week or two then.
Hopefully you can do the same for jdk7u-dev.
Since this is destined for 7u too. I would suggest that the
))
keepAlive = true;
WRT testing, should we be accessing impl classes from tests, keeping in
mind the
desire to restrict access to the corba.impl classes in future jdk releases?
This then might force this to be a packet level test?
regards
Mark
On 03/09/2013 13:58, Chris Hegarty wrote:
Sean,
I
://cr.openjdk.java.net/~coffeys/webrev.8017195.2/webrev/
Looks good to me.
-Chris.
regards,
Sean.
On 03/09/2013 15:23, Chris Hegarty wrote:
There is always debate over this, but I suspect, given the property name
com.sun.CORBA.transport.enableTcpKeepAlive, that if it is set
On 04/09/2013 00:23, Mike Duigou wrote:
Hello all;
Here is an updated webrev of just 8024014:
http://cr.openjdk.java.net/~mduigou/JDK-8024014/0/webrev/
I'm ok with this, and as someone who runs these test frequently I am
looking forward to being able to quickly run the different groups.
On 06/09/2013 12:08, Paul Sandoz wrote:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0
http://hg.openjdk.java.net/lambda/lambda/jdk/raw-rev/b73937e96ae0
Anyone up for reviewing this?
I skimmed the patch and nothing jumps out at me.
There does appear to be some
Changeset: 517c5e99fb2f
Author:chegar
Date: 2013-09-11 11:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/517c5e99fb2f
8024508: Fix doclint issues in com.sun.nio.sctp
Reviewed-by: alanb
! src/share/classes/com/sun/nio/sctp/Association.java
!
Changeset: d389dedd1ccb
Author:chegar
Date: 2013-09-11 11:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d389dedd1ccb
8023090: Additional debug info for java/net/NetworkInterface/Equals.java
Reviewed-by: alanb
! test/java/net/NetworkInterface/Equals.java
Changeset: c53411f89b4c
Author:msheppar
Date: 2013-09-13 12:20 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c53411f89b4c
8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows
Summary: amended test to add active, i.e. isUp(), NetworkInterfaces to
I had to look at it a few times ;-) Looks fine to me.
-Chris
On 14 Sep 2013, at 07:49, Xueming Shen xueming.s...@oracle.com wrote:
Hi,
Please help review this trivial javadoc typo fix.
http://cr.openjdk.java.net/~sherman/7186311/webrev
Thanks,
-Sherman
On some platforms, Windows, tunneling interfaces report a very bad mac
address, e.g. 00-00-00-00-00-00-00-E0. I wonder if it is worth skipping
all isVirtual() nifs?
-Chris.
On 16/09/2013 16:06, Peter Levart wrote:
Hi Doug,
This seems reasonable for majority of environments.
Regards, Peter
The changes look fine to me too.
With such a trivial change to hotspot it may be possible to push this
through TL?
Trivially, and separate to this change, I can see further cleanup
opportunities [1], as well as some tests that ref alt-rt.jar [2] [3].
Not that I really care (but I know
Changeset: b3a506a30fda
Author:ewang
Date: 2013-09-18 15:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3a506a30fda
8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java
failing intermittently [win]
Reviewed-by: chegar, alanb
!
Volker,
I skimmed over the networking part of the changes, and nothing jumps out
at me. I'd like to spend a little more time doing a more detailed
review, but I will not have time to do this until after JavaOne.
-Chris.
On 09/16/2013 08:30 PM, Volker Simonis wrote:
Resending this to more
Looks ok to me Dan.
-Chris.
On 09/27/2013 01:40 PM, Dan Xu wrote:
Hi,
Recently I made changes in TempDirectory.generateFile() method to
prevent using invalidparameters to create temporary files. But such
tight control will bring a compatibility issue. This change is going to
solve
Looks good to me Mike.
-Chris
On 27 Sep 2013, at 17:53, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
As pointed out by Roger Riggs, Optional.of (and the private Optional(T)
constructor) don't explicitly document throwing NPE in response to a null
value despite describing value
On 10/01/2013 10:09 AM, Seán Coffey wrote:
Miran,
I'm assuming that all these changes were reviewed when integrated to the
upstream JAX-WS project. I confirm that my changes from 8016271 are
present and look fine. I'm not an OpenJDK reviewer though so you'll need
someone else as reviewer.
The changes look ok to me Mike. Thanks,
-Chris,
On 09/30/2013 09:48 PM, Mike Duigou wrote:
Hello all;
When JDK-8006709 (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cff8d7768d72) was pushed
it changed the default source level for the jdk project NetBeans projects to 1.8. This
was a
The change looks fine to me.
Just curious why we don't allow sizes equal to Nodes.MAX_ARRAY_SIZE?
Rather less than.
-Chris.
On 01/10/2013 20:30, Paul Sandoz wrote:
Hi,
Please review the following patch that checks size limits for the sorted
operation and fails quickly rather than failing
On 02/10/2013 13:03, Paul Sandoz wrote:
On Oct 2, 2013, at 1:34 PM, Chris Hegartychris.hega...@oracle.com wrote:
The change looks fine to me.
Thanks.
Just curious why we don't allow sizes equal to Nodes.MAX_ARRAY_SIZE? Rather
less than.
Hmm... well observed, it's most likely a one
On 02/10/2013 04:44, Alan Bateman wrote:
On 01/10/2013 12:46, Brian Burkhalter wrote:
:
I updated the webrev
http://cr.openjdk.java.net/~bpb/8010371/
with changes in the test of the return value of getaddrinfo for Unix
Inet 4 and 6 and Windows Inet 6. The usual testing is in progress.
Brian
On 10/02/2013 08:40 PM, Brian Burkhalter wrote:
So, how about this approach:
1) If the error is EAI_AGAIN / EIA_SYSTEM+EAGAIN / WSATRY_AGAIN then do one
immediate native retry.
2) If the retry fails with the same error, then throw a UHE with a specific
message or cause.
Sounds good to
Changeset: 7d2112abbb1d
Author:coffeys
Date: 2013-10-04 16:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d2112abbb1d
8016271: wsimport -clientjar does not create portable jars on Windows due to
hardcoded backslash
Reviewed-by: mkos, chegar
+
Changeset: b0610cd08440
Author:mkos
Date: 2013-10-04 16:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0610cd08440
8025054: Update JAX-WS RI integration to 2.2.9-b130926.1035
Reviewed-by: chegar
!
Alan,
I checked the httpsever and sctp changes. All look good to me.
-Chris.
On 10/06/2013 09:03 PM, Alan Bateman wrote:
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported,
I'd like to have another attempt at adding the annotation to a number of
JDK specific APIs that are
On 10/07/2013 10:03 PM, Brian Burkhalter wrote:
On Oct 7, 2013, at 1:43 PM, Brian Burkhalter wrote:
On second thought an exception really should be thrown on negative size; will
update.
http://cr.openjdk.java.net/~bpb/8016252.2/ updated including a
not-very-exciting and perhaps unnecessary
On 10/08/2013 06:04 AM, Mandy Chung wrote:
On 10/7/2013 9:45 PM, David Holmes wrote:
Hi Mandy,
Note that unless you push both hotspot and jdk changes through the
same forest you will need separate bugs for each part. You will also
need a HSX committer to do the hotspot push.
I do plan to
Sorry Paul, I know the apiNote says for examples see ... but would you
mind providing an example. I'm scratching my head.
-Chris.
On 10/08/2013 12:42 PM, Paul Sandoz wrote:
Hi,
The following patch is a minor clarification to the documentation of
Spliterator.characteristics():
Thanks Paul. In which case, the spec clarifications seem fine.
-Chris.
On 10/08/2013 02:10 PM, Paul Sandoz wrote:
On Oct 8, 2013, at 3:02 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Sorry Paul, I know the apiNote says for examples see ... but would you mind
providing an example. I'm
On 10/08/2013 12:08 PM, Alan Bateman wrote:
On 04/10/2013 21:58, Brian Burkhalter wrote:
:
An updated webrev which I hope adequately addresses the expressed
concerns may be found at:
http://cr.openjdk.java.net/~bpb/7179567.2/
This looks much better.
Yes, this is much nicer.
I'd be
for future maintainers).
In the test then it might be better to change the @summary line to only include
the second paragraph (the bug summary is not interesting, especially when it
references a test that is not in OpenJDK).
Updated.
On Oct 8, 2013, at 8:53 AM, Chris Hegarty wrote:
Yes
On 08/10/2013 21:50, Brian Burkhalter wrote:
http://cr.openjdk.java.net/~bpb/8016252/webrev.3/
This looks good to me.
If you haven't already got a sponsor, then I would be happy to sponsor
this for you.
-Chris.
On 09/10/2013 11:41, Daniel Fuchs wrote:
Hi Mandy,
This looks good!
+1
-Chris.
(not a reviewer)
-- daniel
On 10/9/13 12:29 PM, Mandy Chung wrote:
Daniel,
Thanks for the review.
On 10/9/2013 12:38 AM, Daniel Fuchs wrote:
This looks good - but I think you could move the changes line
Dan,
Your changes look fine to me.
While looking at this I notice that there is another potential leak. If
the malloc for temp fails, then we need to free lc ( for MAC only ), right?
-Chris.
On 10/09/2013 07:51 PM, Dan Xu wrote:
Hi All,
This fix is to solve the memory leak issue in
Looks good to me Daniel.
-Chris.
On 10/10/2013 14:11, Daniel Fuchs wrote:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
https://bugs.openjdk.java.net/browse/JDK-8011638
http://cr.openjdk.java.net/~dfuchs/webrev_8011638/webrev.00/
is the workaround only for Solaris. Shall we use a more strict
macro here instead of #ifndef __linux__? Thanks!
-Dan
On 10/10/2013 02:22 AM, Chris Hegarty wrote:
Dan,
Your changes look fine to me.
While looking at this I notice that there is another potential leak.
If the malloc for temp fails, then we
On 11/10/2013 05:04, David Holmes wrote:
Ship it! :)
+1
-Chris.
Thanks,
David
On 11/10/2013 5:24 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:21 AM, Brian Burkhalter wrote:
On Oct 10, 2013, at 11:05 AM, Brian Burkhalter wrote:
Nit: In the test there are a few places where you
Changeset: 077237e4613f
Author:tyan
Date: 2013-10-14 11:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f
8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is
localhost
Reviewed-by: chegar, alanb
!
This is a request to pull a small change to ForkJoinTask into jdk8, from
the jsr166 CVS. This was first discussed over on c-i [1] a few weeks back.
diff -r 077237e4613f
src/share/classes/java/util/concurrent/ForkJoinTask.java
--- a/src/share/classes/java/util/concurrent/ForkJoinTask.java Mon
On 14 Oct 2013, at 21:03, Henry Jen henry@oracle.com wrote:
Hi,
Please review a quick one line fix for the test, we simply
pass(ignore) the test instead of skip the test.
Ignore the test is the intention. It would be ideal if we know it's
skipped intentionally, but currently jtreg
Changeset: af87dabb4263
Author:msheppar
Date: 2013-06-14 15:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/af87dabb4263
8011157: Improve CORBA portablility
Summary: fix also reviewed by Alexander Fomin
Reviewed-by: alanb, coffeys, skoivu
! common/makefiles/RMICompilation.gmk
Changeset: ecb66dc473c1
Author:joehw
Date: 2013-07-16 14:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ecb66dc473c1
8012425: Transform TransformerFactory
Reviewed-by: alanb, dfuchs, mullan
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java
!
Changeset: 43240b8b995b
Author:mkos
Date: 2013-08-01 16:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/43240b8b995b
8017505: Better Client Service
Reviewed-by: mullan, ahgross, mgrebac
!
Changeset: 81d694b1ab2f
Author:msheppar
Date: 2013-06-14 16:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/81d694b1ab2f
8011157: Improve CORBA portablility
Summary: fix also reviewed by Alexander Fomin
Reviewed-by: alanb, coffeys, skoivu
!
Changeset: 5c599c419c1d
Author:hseigel
Date: 2013-07-11 12:59 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c599c419c1d
8016256: Make finalization final
Summary: Add private methods to final methods check
Reviewed-by: coleenp, acorn, ahgross
Contributed-by:
Changeset: b3baca585b7f
Author:jbachorik
Date: 2013-04-23 09:37 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3baca585b7f
8011081: Improve jhat
Summary: Properly escape HTML output
Reviewed-by: alanb, mschoene, sundar
!
Changeset: 84df20dc604a
Author:bpatel
Date: 2013-07-24 15:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84df20dc604a
8016675: Make Javadoc pages more robust
Reviewed-by: jlaskey, ksrini
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
On 16/10/2013 11:35, David Holmes wrote:
Ship it! Quickly! :)
+1 looks good to me.
Thanks Erik,
-Chris.
Thanks,
David
On 16/10/2013 8:19 PM, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/
* Changed Node.java as David suggested.
* Added comment
601 - 700 of 2067 matches
Mail list logo
