RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

Hi all, Please review the patch: Problems: - MethodHandlesTest::testCatchException() doesn't provide enough testing of j.l.i.MethodHandles::catchException(). - MethodHandlesTest contains more than 3k lines, an auxiliary code together w/ a test code, many methods aren't connected w/ each

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

hope we'll have time in jdk 9 to refactor all tests in MethodHandles. Thanks, Igor On 03/27/2014 12:38 AM, Christian Thalinger wrote: On Mar 24, 2014, at 1:33 PM, Igor Ignatyev igor.ignat...@oracle.com wrote: Hi all, Please review the patch: Problems: - MethodHandlesTest

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

type. http://cr.openjdk.java.net/~iignatyev/8038186/webrev.02/ Thanks, Igor On 03/27/2014 12:46 AM, Igor Ignatyev wrote: Hi Chris, This is very nice. Are there plans to do this for the other existing tests as well? sure, but we didn't have enough time to do it in 8u20 timeframe. So I'd like

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

on this, if it's important. I hope the code's still quite readable and understandable. Also I've added array return type. http://cr.openjdk.java.net/~iignatyev/8038186/webrev.02/ Thanks, Igor On 03/27/2014 12:46 AM, Igor Ignatyev wrote: Hi Chris, This is very nice. Are there plans to do

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

. updated webrev: http://cr.openjdk.java.net/~iignatyev/8038186/webrev.03/ Thanks, Igor On 03/28/2014 03:31 PM, Igor Ignatyev wrote: Vladimir, thanks for review, please my comments inline. On 03/28/2014 01:29 PM, Vladimir Ivanov wrote: Igor, thanks for improving the tests on method handles! After

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

droped; Should be “dropped”. Otherwise seems ok... But more comments would be appreciated. It’s huge and really hard to understand. igor On Mar 28, 2014, at 9:04 AM, Igor Ignatyev igor.ignat...@oracle.com wrote: Vladimir, as we'd arranged, I moved ThrowMode into TestCase and give my word

Re: RFR(S) : 8038186 : [TESTBUG] improvements of test j.l.i.MethodHandles

John, unfortunately, I've already pushed my changes w/o junit annotation. But I have the dirty patch which adds jtreg support to netbeans: 1. add test.single action for test folder to 'ide-actions' section in JDK project -- jdk/make/netbeans/j2se/nbproject/project.xml:

Re: [9] RFR (M): 8049555: Move varargsArray from sun.invoke.util package to java.lang.invoke

Vladimir, instead of the trick w/ 'ClassFileInstaller', you can use 'bootclasspath' option[1] which adds all paths to the bootclasspath: * @run main/bootclasspath java.lang.invoke.VarargsArrayTest * @run main/bootclasspath * -DVarargsArrayTest.MAX_ARITY=255

Re: [9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

Paul, thanks for your review. I'll take care about this change, since Konstantin is on vacation. updated webrev: http://cr.openjdk.java.net/~iignatyev/kshefov/8057719/webrev.00/ please see inline answers. Igor On 09/11/2014 05:12 PM, Paul Sandoz wrote: On Sep 5, 2014, at 7:52 PM,

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

Vladimir/Alan, Yes, only WB.fullGC() is needed, I replaced it w/ System.gc() and removed whitebox from the changes. updated webrev : http://cr.openjdk.java.net/~iignatyev/kshefov/8057707/webrev.00/ Thanks Igor On 09/12/2014 05:41 PM, Vladimir Ivanov wrote: Alan, I wasn't aware about

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity 253 can't be cached

Hi Konstantin, 0. could you please introduce a ctor which sets the default value for 'maxArity' and use it instead of explicitly passed 'Helper.MAX_ARITY'? 1. there is a existing solution for your case w/ access to an private field of an outer class: int desiredArity =

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Konstantin, I haven't looked at code religiously, so I wouldn't say that I have reviewed it. however I have some comments, please see them inline. On 10/16/2014 02:03 PM, Konstantin Shefov wrote: Paul, Thanks for reviewing In the jtreg scripts of the three existing LFCaching tests timeout

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Konstantin, please use 'java.vm.info' instead of iteration over flags. Igor On 11/06/2014 01:44 PM, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8062904 Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/ Thanks

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

is fixed? Igor On 11/06/2014 06:20 PM, Konstantin Shefov wrote: Igor, Thanks for your comment! Here is the updated webrev: http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ -Konstantin On 06.11.2014 17:36, Igor Ignatyev wrote: Konstantin, please use 'java.vm.info' instead of iteration

RFR(S) : 8039953 : [TESTBUG] Timeout java/lang/invoke/MethodHandles/CatchExceptionTest.java

http://cr.openjdk.java.net/~iignatyev/8039953/webrev.00 98 lines changed: 93 ins; 3 del; 2 mod; Hi all, Please review the patch: Problem: on some configurations, java/lang/invoke/MethodHandles/CatchExceptionTest.java can timeout before all test cases are run Fix: interrupt test execution

Re: RFR(S) : 8039953 : [TESTBUG] Timeout java/lang/invoke/MethodHandles/CatchExceptionTest.java

http://cr.openjdk.java.net/~iignatyev/8039953/webrev.01/ to have TimeLimitedRunner more general, I've added 'factor' argument to its ctor. Thanks, Igor On 12/01/2014 02:39 PM, Igor Ignatyev wrote: Paul/Vladimir, thanks for review. On 12/01/2014 01:29 PM, Vladimir Ivanov wrote: On 12/1/14

Re: [9] Review request : JDK-8066798: TEST_RFR: Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

Hi Konstantin, 0. I don't like static variables which you introduced. were I you, I'd create a class which encapsulates them. + it looks like - doneIterations is a local for the lambda - totalIterations is almost affectively final - testCounter/failCounter are just informative variable and

Re: [9] Review request : JDK-8066798: TEST_RFR: Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

://cr.openjdk.java.net/~kshefov/8066798/webrev.01 -Konstantin On 09.12.2014 12:28, Igor Ignatyev wrote: Hi Konstantin, 0. I don't like static variables which you introduced. were I you, I'd create a class which encapsulates them. + it looks like - doneIterations is a local for the lambda

Re: [9] Review request : JDK-8066798: TEST_RFR: Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

, Igor Ignatyev wrote: Konstantin, well, now I don't see any points to have a lambda. you can simple make it a method in TestRunInfo and rename TestRunInfo into TestRun. 174 t.printStackTrace(); 175 System.err.println(FAILED); you don't print exception message. -- Igor

Re: [9] Review request : JDK-8066798: [TEST] Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

)); incorrect indent System.err.println(String.format(All %d test cases PASSED!, testCounter)); PrintStream::printf otherwise LGTM Thanks, Igor On 12/10/2014 03:25 PM, Konstantin Shefov wrote: On 09.12.2014 16:50, Igor Ignatyev wrote: on last thing to think about: does it make sense to move

RFR(XS) : 8055269 : java/lang/invoke/MethodHandles/CatchExceptionTest.java fails intermittently

http://cr.openjdk.java.net/~iignatyev/8055269/webrev.00/ 23 lines changed: 8 ins; 9 del; 6 mod Hi all, please review the tiny fix for CatchExceptionTest test. problem: the tests generates a target w/ 255 parameters, so a corresponding handler should have 256 parameters. that violates

Re: RFR(XS) : 8055269 : java/lang/invoke/MethodHandles/CatchExceptionTest.java fails intermittently

, int.class, byte.class, Integer[].class, double[].class, String.class, Best regards, Vladimir Ivanov On 5/18/15 8:51 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8055269/webrev.00/ 23 lines changed: 8

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

Konstantin, do you have an explanation why the test passes on jdk 9? from my point of view, it indicates there is a product bug in 8u which should be fixed and your fix just hides it. Igor On 06/03/2015 10:14 PM, Seán Coffey wrote: I bumped into this failure myself today. I think you've got

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

it is a product bug then. -Konstantin On 06/03/2015 11:47 PM, Igor Ignatyev wrote:try to reproduce failres Konstantin, do you have an explanation why the test passes on jdk 9? from my point of view, it indicates there is a product bug in 8u which should be fixed and your fix just hides it. Igor On 06

Re: RFR [9] 8141615: Add new public methods to sun.reflect.ConstantPool

Hi Konstantin, the fix and tests look good to me, but I think you have to wait for OK from Coleen. One minor thing —it looks like there are no tests for other s.r.CP methods, could you please file an RFE against core-libs/j.l.reflect to cover them? Thanks, — Igor > On Dec 11, 2015, at 2:54

RFR : 8132961 : JEP 279 Improve Test-Failure Troubleshooting

http://cr.openjdk.java.net/~iignatyev/8132961/webrev.00/ > 3579 lines changed: 3579 ins; 0 del; 0 mod; 0 unchg Hi, Could you please review the webrev[0] for JEP 279[1]? The scope of the JEP is an implementation of a library which uses jtreg timeout handler and observer extension points to

RFR(XXS) : 8149700 : Remove jdk_svc test group from tier * groups

http://cr.openjdk.java.net/~iignatyev/8149700/webrev.00/ > > 2 lines changed: 0 ins; 1 del; 1 mod; Hi all, could you please review the tiny patch which removes jdk_svc test group from tier2 test group? Many of svc tests fail intermittently due to different reasons, that prevents us from

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

Dima, I’d prefer to have tests moved into hotspot repo instead. none of jdk tests should depend on vm kind or any other details of vm. your change just makes things worse, we will not just have tests which depend on vm implementation details in jdk, we will also have an mechanism for other

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

uplicated in TEST.ROOT. We > don't duplicate the code, but repeat a sort of "import" statements. > So, I'm okay with the proposed change. the problem is not in code duplication, it is in making that easy to have hotspot tests in jdk. > > Thanks, > Dima > > &g

Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

Dmitry, Thank you for review. — Igor > On Sep 19, 2016, at 1:40 PM, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Igor, > > Looks good for me. > > -Dmitry > > On 2016-09-19 12:17, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/

Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

Staffan, Thank you for review! — Igor > On Sep 19, 2016, at 12:25 PM, Staffan Larsen <staffan.lar...@oracle.com> > wrote: > > Looks good! > > Thanks, > /Staffan > >> On 19 sep. 2016, at 11:17, Igor Ignatyev <igor.ignat...@oracle.com> wrote: &g

RFR(S) : 8166262 : failurehandler should not use jtreg internal API

http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ > 62 lines changed: 56 ins; 2 del; 4 mod; Hi all, could you please review this small patch which removes usage of jtreg internal API from failurehandler lib? JBS: https://bugs.openjdk.java.net/browse/JDK-8166262 webrev:

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

Hi Dima, the fix looks good to me, Cheers, — Igor > On Dec 23, 2016, at 7:13 PM, Dmitry Fazunenenko > wrote: > > Hi, > > new version: http://cr.openjdk.java.net/~dfazunen/8171441/webrev.02/ > > This comment now looks like: > > 152 /* > 153 * Checks if

Re: RFR(L) : 8176176 : fix @modules in jdk_svc tests

sEvent.java.udiff.html > > * @modules java.corba > * jdk.jdi > > Should the jdk.jdi be removed from this com/sun/jdi test? > > > Thanks, > Serguei > > > On 3/15/17 11:16, Igor Ignatyev wrote: >> Shura, >> >> Thank you for your rev

Re: RFR(L) : 8176176 : fix @modules in jdk_svc tests

va/lang/management/PlatformLoggingMXBean/TEST.properties you are > explicitly calling out java.management. You do not have to do that because > “modules” property is concatenated through the hierarchy. java.management is > already listed in test/java/lang/management/TEST.properties. &g

RFR(XS) : 8178340: remove unneeded "throws" from ProcessTools::createJavaProcessBuilder

http://cr.openjdk.java.net/~iignatyev//8178340/webrev.00/index.html > 8 lines changed: 0 ins; 2 del; 6 mod; Hi all, could you please review this tiny fix which clean up testlibary? ProcessTools::createJavaProcessBuilder methods can not throw any checked exceptions, but were declared with

Re: RFR(XS) : 8178340: remove unneeded "throws" from ProcessTools::createJavaProcessBuilder

exception checking, but class Exception is exempt from > that checking. > > Thanks, > David > > On 11/04/2017 8:42 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8178340/webrev.00/index.html >>> 8 lines changed: 0 ins; 2 del; 6 mod; >>

RFR(S) : 8178415: remove ProcessTools::getPlatformSpecificVMArgs from testlibary

http://cr.openjdk.java.net/~iignatyev/8178415/webrev.00/ > 59 lines changed: 0 ins; 59 del; 0 mod; Hi all, could you please review this small clean up of testlibaries? the only platform specific vm arguments which we had were -d64/32. they were deprecated in jdk9 by 8168010 and will be removed

Re: RFR(S) : 8178415: remove ProcessTools::getPlatformSpecificVMArgs from testlibary

Hi David, thank you for such a prompt review! -- Igor > On Apr 11, 2017, at 7:47 PM, David Holmes <david.hol...@oracle.com> wrote: > > Hi Igor, > > On 12/04/2017 12:29 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/8178415/webrev.00/ >>>

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

Hi Shura, > Quite recently the suggested improvement was discussed with a few folks from > hotspot team where the same or a similar implementation could be reused. I am > CCing Igor and Dima to comment. Right, Dima and I would really love to reuse part of this library and that’s more important

RFR(XXS) : 8176162 : com/sun/jndi/dns/Parser.java is not executed

Hi all, Could you please review this tiny fix which adds '@run main’ to jdk/test/com/sun/jndi/dns/Parser.java test? The test has only one compile action, as a result jtreg only compiles java file, but does not execute the test. Web rev:

Re: RFR(L) : 8176176 : fix @modules in jdk_svc tests

enjdk.java.net/~iignatyev/8176176/webrev.00/test/com/sun/jdi/ArgumentValuesTest.java.sdiff.html > [2] > http://cr.openjdk.java.net/~iignatyev/8176176/webrev.00/test/com/sun/jdi/ArrayLengthDumpTest.sh.sdiff.html > >> On Mar 7, 2017, at 1:07 PM, Igor Ignatyev <igor.ignat...@oracle.com>

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

017, at 12:47 PM, mandy chung <mandy.ch...@oracle.com> wrote: > On 8/10/17 9:02 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html >> <http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html> &g

RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html > 14 lines changed: 1 ins; 0 del; 13 mod; Hi all, could you please review this small patch which bumps up jtreg version? besides updating jib profiles and all TEST.ROOT files, the fix updates

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

> On Aug 10, 2017, at 9:22 PM, David Holmes <david.hol...@oracle.com> wrote: > > Hi Igor, > > On 11/08/2017 2:02 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html >>> 14 lines changed: 1 ins; 0 del; 13 mod; &

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

> On Aug 10, 2017, at 9:46 PM, David Holmes <david.hol...@oracle.com> wrote: > > On 11/08/2017 2:31 PM, Igor Ignatyev wrote: >>> On Aug 10, 2017, at 9:22 PM, David Holmes <david.hol...@oracle.com> wrote: >>> >>> Hi Igor, >>>

Re: RFR(S): 8180195: remove jaxp testlibrary

reviewer. >> >> Thanks >> Frank >> >>> -Original Message- >>> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On >>> Behalf Of Igor Ignatyev >>> Subject: RFR(S): 8180195: remove jaxp testlibrary >>> &g

RFR(S) : 8180399 : move jdk.testlibrary.LockFreeLogManager to the top level test library

http://cr.openjdk.java.net/~iignatyev//8180399/webrev.00/index.html > 186 lines changed: 87 ins; 90 del; 9 mod; Hi all, could you please review this small patch which moves LockFreeLogManager class from jdk test library to the top level test library? this fix is a part of ongoing effort on

RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html > lines changed: 2 ins; 88 del; 6 mod; Hi all, could you please review this small fix which removes TimeLimitedRunner class from jdk testlibrary? we have two TimeLimitedRunner classes one in jdk test library and another in

RFR(XXXS) : 8181762 : add explicit @build actions for jdk.test.lib classes in all :tier3 tests

http://cr.openjdk.java.net/~iignatyev//8181762/webrev.00/index.html > 1 line changed: 1 ins; 0 del; 0 mod; Hi all, could you please review this one line patch which adds explicit @build actions to tier3 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].

RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html > 432 lines changed: 404 ins; 1 del; 27 mod; Hi all, could you please review this changeset which adds explicit @build actions to tier2 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].

RFR(S) : 8181759 : add explicit @build actions for jdk.test.lib classes in all :tier1 tests

http://cr.openjdk.java.net/~iignatyev//8181759/webrev.00/index.html > 117 lines changed: 111 ins; 0 del; 6 mod; Hi all, could you please review this changeset which adds explicit @build actions to tier1 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].

Re: RFR(S) : 8181759 : add explicit @build actions for jdk.test.lib classes in all :tier1 tests

/8181759/webrev.02/index.html> Thanks, -- Igor > On Jun 7, 2017, at 11:08 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > http://cr.openjdk.java.net/~iignatyev//8181759/webrev.00/index.html >> 117 lines changed: 111 ins; 0 del; 6 mod; > > > Hi all, &

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

asses even if for the implicitly dependent classes. > Jon's strict solution is for a more complicated situation where some tests > are using explicit @build, but others are not, in this mixed situation my > solution will NOT work. But as you're cleaning up all the tests, I think it's

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

g only at ones which have jdk/test/lib classes. -- Igor > On Jun 8, 2017, at 2:26 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > >> >> On Jun 8, 2017, at 9:35 AM, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> On 08/06/2017 17:18, Igor Ig

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Chris, I haven't noticed your email and have already pushed 8181761. from my point of view, FileUtils depending on Platform class is not a bug, but having lots of seemed to be unrelated @build action is a bug, I added your comment to 8181915

Re: RFR(S) : 8182565 : remove jdk.testlibrary.Utils::tryFindJvmPid and waitForJvmPid methods

eate a lot of > intermediate webrevs. > > Roger > > > On 6/19/17 7:47 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8182565/webrev.00/index.html >>> 57 lines changed: 0 ins; 57 del; 0 mod; >> Hi all, >> >> could you please

RFR(M) : 8182154 : merge jdk.testlibrary.Platform and jdk.test.lib.Platform

http://cr.openjdk.java.net/~iignatyev/8182154/webrev.01/ > 281 lines changed: 18 ins; 223 del; 40 mod; Hi all, could you please review this changeset which removes Platform from jdk testlibrary and updates tests to use jdk.test.lib.Platform from top level testlibrary instead? as a part of this

RFR(S) : 8182565 : remove jdk.testlibrary.Utils::tryFindJvmPid and waitForJvmPid methods

http://cr.openjdk.java.net/~iignatyev//8182565/webrev.00/index.html > 57 lines changed: 0 ins; 57 del; 0 mod; Hi all, could you please review this small patch which removes two unused methods from jdk.testlibrary.Utils class? webrev:

Re: RFR(M) : 8182154 : merge jdk.testlibrary.Platform and jdk.test.lib.Platform

er.lev...@gmail.com> wrote: > > Hi Igor, > > On 06/27/2017 03:17 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/8182154/webrev.01/ >>> 281 lines changed: 18 ins; 223 del; 40 mod; >> Hi all, >> >> could you please review this cha

Re: RFR(S) : 8180399 : move jdk.testlibrary.LockFreeLogManager to the top level test library

> Does the Locks test need to depend on stuff in /lib/testlibrary ? > > Paul. > >> On 16 May 2017, at 21:21, Igor Ignatyev <igor.ignat...@oracle.com >> <mailto:igor.ignat...@oracle.com>> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//818039

RFR(S) : 8180887: move FileUtils to top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180887/webrev.00/index.html > 567 lines changed: 231 ins; 252 del; 84 mod; Hi all, could you please review this changeset which moves FileUtils class from the jdk testlibrary to the top level testlibary? webrev:

RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180805/webrev.00/index.html > 308 lines changed: 110 ins; 40 del; 158 mod Hi all, this changeset introduces jdk.test.lib.RandomFactory in the top level testlibrary and updates all but java/time/ tests to use it instead of jdk.testlibrary.RandomFactory

RFR(XS) : 8180890: move c.o.testlibrary.jsr292 classes to jdk/test/java/lang/invoke directory

http://cr.openjdk.java.net/~iignatyev//8180890/webrev.00/index.html > 41 lines changed: 5 ins; 4 del; 32 mod; Hi all, jsr292 testlibrary is used only by java/lang/invoke tests, so there is no reason to have this library in common testlibrary, this changeset moves jsr292 testlibrary classes

RFR(S) : 8180621 : remove jdk.testlibrary.management.InputArguments

http://cr.openjdk.java.net/~iignatyev//8180621/webrev.00/index.html > 88 lines changed: 0 ins; 88 del; 0 mod; Hi all, there is no usage of jdk.testlibrary.management.InputArguments by jdk/test or any other tests, so this test library class can be removed. webrev:

Re: RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

> On May 18, 2017, at 2:34 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> On May 15, 2017, at 2:00 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html >>> lines cha

RFR(S) : 8180644: move jdk.testlibrary.NetworkConfiguration to the top level test library

http://cr.openjdk.java.net/~iignatyev//8180644/webrev.00/index.html > 698 lines changed: 287 ins; 376 del; 35 mod; Hi all, could you please review this patch which moves NetworkConfiguration class to the top level test library? there were two instances of NetworkConfiguration: one in jdk

Re: RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

> On May 18, 2017, at 2:41 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On May 18, 2017, at 2:37 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >> >> >>> On May 18, 2017, at 2:34 PM, Mandy Chung <mandy.ch...@oracle.com>

Re: RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

Hi, still looking for a Reviewer. Cheers, -- Igor > On May 15, 2017, at 2:00 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html >> lines changed: 2 ins; 88 del; 6 mod; > > Hi all, > > c

Re: RFR(S) : 8180644: move jdk.testlibrary.NetworkConfiguration to the top level test library

gt; 217 Iterator iter = > config.ip6MulticastInterfaces().iterator(); > 218 if (iter.hasNext()) { > > #210 should be ip4 > > Paul. > >> On 19 May 2017, at 10:43, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >> >> http://cr.openjdk.j

RFR(XS) : 8180895 : java/security/AccessController/DoPrivAccompliceTest.java has to be improved

http://cr.openjdk.java.net/~iignatyev//8180895/webrev.00/index.html > 81 lines changed: 37 ins; 23 del; 21 mod; Hi all, could you please review the fix which improves and refactors DoPrivAccompliceTest.java test? the test had several issues: - it did not fail if the java spawned by

RFR(XS): 8180802 : move jdk.testlibrary.management.ThreadMXBeanTool to top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180802/webrev.00/index.html > 143 lines changed: 71 ins; 72 del; 0 mod; Hi all, could you please review this patch which moves ThreadMXBeanTool from jdk testlibrary to the top level testlibrary? please be aware that there are tests outside jdk repository

RFR(XS): move FilterClassLoader and ParentLastURLClassLoader to top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180395/webrev.00/index.html > 200 lines changed: 101 ins; 99 del; 0 mod; Hi all, could you please review this small fix which move FilterClassLoader and ParentLastURLClassLoader class from jdk testlibrary to top level testlibrary? this fix is a part of

RFR(S): 8180391: move SerializationUtils to top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180391/webrev.00/index.html > 119 lines changed: 56 ins; 54 del; 9 mod; Hi all, could you please review this small fix which move SerializationUtils class from jdk testlibrary to top level testlibrary? jdk.testlibrary.SerializationUtils does not have

RFR(S) : 8180397 : remove jdk.testlibrary.IOUtils

http://cr.openjdk.java.net/~iignatyev//8180397/webrev.00/index.html > 92 lines changed: 0 ins; 81 del; 11 mod; Hi all, could you please review this small clean-up which removes jdk.testlibrary.IOUtils class from test library? IOUtils provides one method readFully(InputStream), which can be

RFR(S) : 8180888: move jdk.testlibrary.JarUtils to the top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html > 354 lines changed: 148 ins; 149 del; 57 mod; Hi all, could you please review this changeset which moves JarUtils to the top level testlibrary? webrev: http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html jbs:

Re: RFR(S) : 8180888: move jdk.testlibrary.JarUtils to the top level testlibrary

ava.net/~iignatyev//8180888/webrev.00/jdk10.patch > link is empty. Anything wrong with your version of webrev? > > Thanks > Max > > On 05/31/2017 08:40 AM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html >>> 354 lines chang

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

runnable. > > "explicit" is reasonable for me. But "explicit" should not be restricted > as "explicit all, including dependencies", as it is not productive or even > realistic in the long term. > Thanks, > Felix > On 2017/6/2 7:58,

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

omeone refactors them and extract some new classes. that is to say, it's nearly impossible to have all explicit @build actions. Cheers, -- Igor > On Jun 1, 2017, at 3:37 PM, Ioi Lam <ioi@oracle.com> wrote: > > > > On 6/1/17 1:17 PM, Igor Ignatyev wrote: >>> On J

RFR(XXS) : 8181307: tests added/changed by 8166139 should be updated to use the latest testlibrary

http://cr.openjdk.java.net/~iignatyev//8181307/webrev.00/index.html > 2 lines changed: 1 ins; 0 del; 1 mod; Hi all, misfortunately, 8180887[1] was created and tested before 8166139[2] has been integrated. then the fixes met in jdk10/jdk10, java/net/URLClassLoader/closetest/CloseTest.java

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Felix, I have suggested the exact opposite change[1-3] to fix the same problem. [1] https://bugs.openjdk.java.net/browse/JDK-8181391 [2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048012.html [3] http://cr.openjdk.java.net/~iignatyev//8181391/webrev.00/index.html Thanks,

Re: RFR 8181414/10, Refactor misc test/sun/net/www/protocol/jar shell tests to plain java tests

http://cr.openjdk.java.net/~xiaofeya/8181414/webrev.00/test/sun/net/www/protocol/jar/B5105410.java.udiff.html > + # @summary ZipFile$ZipFileInputStream doesn't close handle to zipfile a typo, it should be * @summary -- Igor > On Jun 1, 2017, at 12:39 AM, Felix Yang wrote:

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

I have measured how much time it takes to run :tier1 w/ and and w/o the fix which removes @build for jdk.test.lib.** classes[1-2]: - w/o 8181391, i.e. w/ @build: real 33m4.624s, user 111m56.758s, sys 6m24.022s. [3] is a breakdown for jtreg actions - w/ 8181391, i.e. w/o @build: real

Re: RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

still looking for a Reviewer. -- Igor > On May 31, 2017, at 2:57 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > Hi Mandy, > > 8180793[1], which moved j.t.l.wrappers.* to j.t.lib package, has been > propagated to jdk10/jdk10. I have updated the patc

RFR(XXS) : 8181715 : sun/net/www/protocol/jar/jarbug/TestDriver.java fails after 8181335

http://cr.openjdk.java.net/~iignatyev//8181715/webrev.00/index.html > 2 lines changed: 1 ins; 0 del; 1 mod; Hi all, could you please review this tiny fix for sun/net/www/protocol/jar/jarbug/TestDriver.java? the test had two problems: 1. it uses CompilerUtils from default package which has been

RFR(S) : 8180898: remove JavaToolUtils testlibrary class

http://cr.openjdk.java.net/~iignatyev//8180898/webrev.00/index.html > 209 lines changed: 0 ins; 209 del; 0 mod; 0 Hi all, 8180895[1] has updated the sole user of JavaToolUtils class to use other testlibrary classes, JavaToolUtils itself does not provide any unique methods, so it should be

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

> On Jun 1, 2017, at 1:20 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > > Igor, > >> On 1 Jun 2017, at 04:32, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >> >> Hi Felix, >> >> I have suggested the exact opposite change[1-3] to

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

SendReceiveTests > * @key randomness -- Igor > On Jun 8, 2017, at 12:20 AM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html >> 432 lines changed: 404 ins; 1 del; 27 mod; > > Hi all, > >

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

man <alan.bate...@oracle.com> wrote: > > On 08/06/2017 16:24, Igor Ignatyev wrote: >> Chris/Alan, >> >> Although the test itself doesn't launch new VMs, >> jdk.test.lib.NetworkConfiguration, which this test directly depends on, >> depends on jdk.test.lib

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris/Alan, Although the test itself doesn't launch new VMs, jdk.test.lib.NetworkConfiguration, which this test directly depends on, depends on jdk.test.lib.Platform which depends on jdk.test.lib.Utils. and j.t.l.Utils depend on jdk.test.lib.process.* classes as it might start new VMs. [1] is

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

> On Jun 8, 2017, at 9:35 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 08/06/2017 17:18, Igor Ignatyev wrote: >> Alan, >> >> I totally agree there are many places which we need to clean up in >> testlibraries, including these weird depend

RFR(XXS) : 8181820: jdk/test/lib/Platform should not depend on jdk/test/lib/Utils

http://cr.openjdk.java.net/~iignatyev//8181820/webrev.00/index.html > 12 lines changed: 10 ins; 0 del; 2 mod; Hi all, could you please review this small patch which removes dependency on Utils from Platform test class? this patch is basically a part of 8181124[1] which has been integrated

Re: RFR(M) : 8181335 : remove packageless CompilerUtils

> On Jun 5, 2017, at 10:50 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 06/06/2017 06:10, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/8181335/webrev.00/index.html >> > I added this so-called "packageless" CompilerUtils so

RFR(M) : 8181335 : remove packageless CompilerUtils

http://cr.openjdk.java.net/~iignatyev/8181335/webrev.00/index.html > 298 lines changed: 61 ins; 96 del; 141 mod; Hi all, could you please review this fix which removes packageless CompilerUtils and updates all its users to use jdk.test.lib.compiler.CompilerUtils instead? webrev:

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

x.html Thanks, -- Igor > On Jun 9, 2017, at 11:50 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 09/06/2017 19:36, Igor Ignatyev wrote: >> Alan, Chris, >> >> it seems I had some problems uploading the webrev, I have reuploaded it to >> the

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Alan, Chris, it seems I had some problems uploading the webrev, I have reuploaded it to the same place -- http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html -- Igor > On Jun 9, 2017, at 2:01 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 09/06/2

Re: RFR(S) : 8180724: move ModuleInfoMaker to the top level testlibrary

sure, if you prefer that style more, I'll undo these changes before pushing. thanks for review. -- Igor > On May 24, 2017, at 2:19 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On May 19, 2017, at 4:29 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >

Re: RFR(S) : 8180399 : move jdk.testlibrary.LockFreeLogManager to the top level test library

Hi Paul, do you have other comments on this or can I consider it as reviewed? Thanks, -- Igor > On May 18, 2017, at 10:36 AM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > Paul, > > doh, too many review requests in parallel, thank you for providing the > corr

RFR(S) : 8180724: move ModuleInfoMaker to the top level testlibrary

http://cr.openjdk.java.net/~iignatyev//8180724/webrev.00/index.html > 295 lines changed: 139 ins; 140 del; 16 mod; Hi all, could you please review this small fix which moves ModuleInfoMaker class from jdk testlibrary to the top level testlibrary? since ModuleInfoMaker depends on CompilerUtil

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Alan, we believe it's a jtreg bug. we have seen similar intermittent failures in hotspot testing[1], Ioi(cc'ed) did a really great job analyzing the root cause[2], in to words jtreg puts a part of testlibrary to one path and another part to a different path. [3] is his suggested fix for

  1   2   3   4   >