On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang wrote:
> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were
> the two tests marked with bug id 8260858 and related data and methods.
Marked as reviewed by naoto
On Tue, 16 Feb 2021 17:23:35 GMT, Joe Wang wrote:
>> test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java
>> line 107:
>>
>>> 105: + "\n"
>>> 106: + "";
>>> 107:
>>
>> Could be better to use text blocks?
>
> In general, we're keeping it at source
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang wrote:
> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were
> the two tests marked with bug id 8260858 and related data and methods.
On Fri, 12 Feb 2021 20:29:28 GMT, Joe Darcy wrote:
>> This was requested by Alex, and I thought it sounded reasonable and
>> informative. I think if an MR upgrades the supported Unicode version, it
>> should be listed here.
>
> Should some acknowledgement be made to the changes in Unicode
On Fri, 12 Feb 2021 16:13:04 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed empty tag
>
> src/java.base/share/classes/java/lang/Character.java line 86:
>
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Please review this doc fix to j.l.Character, which now includes the table of
the history of supported Unicode versions. A corresponding CSR will be filed
accordingly.
-
Commit messages:
- 8261621: Delegate Unicode history from JLS to j.l.Character
Changes:
On Wed, 10 Feb 2021 23:35:54 GMT, Claes Redestad wrote:
>> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB,
>> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than
>> per-instance auxiliary decoders. Doing so reduce overheads of calling
>>
On Tue, 9 Feb 2021 21:10:18 GMT, Claes Redestad wrote:
>> src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022.java line 64:
>>
>>> 62:
>>> 63: protected final byte maximumDesignatorLength = 4;
>>> 64:
>>
>> This implementation moved to KR concrete implementation class. IIUC, this
On Tue, 9 Feb 2021 19:43:06 GMT, Claes Redestad wrote:
>> src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java.template line 116:
>>
>>> 114: int sp = src.arrayOffset() + src.position();
>>> 115: int sl = src.arrayOffset() + src.limit();
>>> 116:
>>
>> I see these
On Tue, 9 Feb 2021 12:54:12 GMT, Claes Redestad wrote:
> This refactor some `sun.nio.cs.ext` charsets, such as ISO-2022-CN-GB,
> ISO-2022-CN-CNS, ISO-2022-KR and a few others to use static rather than
> per-instance auxiliary decoders. Doing so reduce overheads of calling
>
Hello,
We are planning to implement the following JEP draft:
https://openjdk.java.net/jeps/8187041
This is a long-standing issue that has been causing cross-platform
default encoding problems. Now that UTF-8 has increasingly become the
de-facto character set out there, we believe it is high
On Mon, 8 Feb 2021 21:42:36 GMT, Naoto Sato wrote:
> Please review this simple test case fix. By sampling locales to test, it
> reduces the possibility of the time out.
This pull request has now been integrated.
Changeset: becee643
Author: Naoto Sato
URL:
On Tue, 9 Feb 2021 00:11:52 GMT, Brian Burkhalter wrote:
> Please review this really small correction to the class level documentation
> of `java.util.ServiceLoader`.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2468
On Mon, 8 Feb 2021 23:42:04 GMT, Joe Wang wrote:
>> Marked as reviewed by lancea (Reviewer).
>
> The fix looks ok to me. Just an interesting note that this test took such a
> long time to run. Given the amount of locales, limit(30) would reduce the
> time to approximately 1/5 of the time, that
On Mon, 8 Feb 2021 22:58:13 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/FilterReader.java line 81:
>>
>>> 79: * {@inheritDoc}
>>> 80: *
>>> 81: * @throws IllegalArgumentException If {@code n} is negative
>>> and the
>>
>> Does this have to be
On Thu, 28 Jan 2021 02:22:55 GMT, Brian Burkhalter wrote:
> Please review this clarification of the specification of the method
> `skip(long)` in `java.io.Reader` and its subclasses. Specifically, the
> behavior of the method is made clear for the case when the `Reader` is
> already at the
Please review this simple test case fix. By sampling locales to test, it
reduces the possibility of the time out.
-
Commit messages:
- 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out
Changes: https://git.openjdk.java.net/jdk/pull/2465/files
Webrev:
On Sun, 7 Feb 2021 19:08:18 GMT, Claes Redestad wrote:
> This patch refactor JDK internal charsets to initialize charset mapping data
> lazily when needed via holder classes. This means both a startup improvement
> in some cases, and possible throughput improvements for all DoubleByte-based
>
On Sat, 6 Feb 2021 00:38:15 GMT, Joe Wang wrote:
> A quick fix to remove isStandalone's dependency on pretty-print.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2442
On Thu, 4 Feb 2021 22:17:12 GMT, Naoto Sato wrote:
> Please review this fix. The bug was revealed while porting CLDR v39 into the
> JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
> regression tests started failing with it because COMPA
Please review this fix. The bug was revealed while porting CLDR v39 into the
JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
regression tests started failing with it because COMPAT provider's "nb"
resource was used according to the incorrect candidate locale order.
[1]
On Tue, 2 Feb 2021 17:22:18 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review integrating tzdata2021a to JDK.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8260356
>
> The fix has passed the regression and JCK tests. More information can be
> viewed at -
>
On Fri, 29 Jan 2021 00:07:59 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Wed, 27 Jan 2021 22:10:01 GMT, Roger Riggs wrote:
> A doc-only change to correct the @ since tag.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2270
On Wed, 27 Jan 2021 06:33:01 GMT, Joe Wang wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Wed, 27 Jan 2021 03:18:09 GMT, Stuart Marks wrote:
> Fix a typo, and change an example to use Stream.toList().
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2249
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2191
On Thu, 21 Jan 2021 20:48:33 GMT, Claes Redestad wrote:
>> The `StringCoding.resultCached` mechanism is used to remove the allocation
>> of a `StringCoding.Result` object on potentially hot paths used in some
>> `String` constructors. Using a `ThreadLocal` has overheads though, and the
>>
On Wed, 20 Jan 2021 23:01:19 GMT, Brian Burkhalter wrote:
> Please review this small change to handle `EINTR` from `close()` in
> `fileDescriptorClose()`. The function `handleGetLength()` is also changed to
> handle `EINTR` from `fstat64()` to match other uses of `fstat64()` in the
> file.
On Mon, 18 Jan 2021 05:52:57 GMT, Leo Jiang wrote:
>> This is the changes for JDK 16 msg drop 10.
>
> Leo Jiang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix the missing copyright year for standard.properties
Marked as reviewed by
On Fri, 15 Jan 2021 01:59:07 GMT, Leo Jiang wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
>> line 518:
>>
>>> 516: doclet.footer_specified=\
>>> 517: The -footer option is no longer supported and will be ignored.\n\
>>> 518:
On Fri, 15 Jan 2021 14:33:19 GMT, Claes Redestad wrote:
> The `StringCoding.resultCached` mechanism is used to remove the allocation of
> a `StringCoding.Result` object on potentially hot paths used in some `String`
> constructors. Using a `ThreadLocal` has overheads though, and the overhead
On Fri, 15 Jan 2021 10:24:24 GMT, Kiran Sidhartha Ravikumar
wrote:
>> Hi Guys,
>>
>> Updating the summary as tzdata2020f is available and includes tzdata2020e
>> changes also.
>>
>> Please review the integration of tzdata2020f to JDK.
>>
>> Details regarding the change can be viewed at -
On Thu, 14 Jan 2021 14:27:25 GMT, Leo Jiang wrote:
>> This is the changes for JDK 16 msg drop 10.
>
> Leo Jiang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Wed, 13 Jan 2021 18:41:05 GMT, Naoto Sato wrote:
> Please review the fix to this issue. Unused thread local StringCoding.Result
> is now wrapped with SoftReference, which can be GC'ed as needed. I confirmed
> it worked as expected with a test case
> (https://github.com/open
Please review the fix to this issue. Unused thread local StringCoding.Result is
now wrapped with SoftReference, which can be GC'ed as needed. I confirmed it
worked as expected with a test case
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote:
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This
On Wed, 13 Jan 2021 00:17:57 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/DOMConstants.java
>> line 131:
>>
>>> 129:
>>> 130: // Corresponding System property
>>> 131: public static final String SP_IS_STANDALONE =
>>>
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote:
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
> "jdk.xml.isStandalone".
>
> This
On Tue, 12 Jan 2021 16:26:27 GMT, Evan Whelan wrote:
> Hi,
>
> Please review this small change which enables the GB18030 charset to be built
> into java.base
>
> Thanks
Looks fine.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2053
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote:
> Just fixing a broken link.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/106
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
This pull request has now been integrated.
Changeset: cd73939b
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/cd73939b
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3
On Mon, 11 Jan 2021 17:35:58 GMT, Joe Wang wrote:
>> Please review this simple doc fix.
>
> src/java.base/share/classes/java/text/Normalizer.java line 48:
>
>> 46: * The {@code normalize} method supports the standard normalization forms
>> 47: * described in
>> 48: *
Please review this simple doc fix.
-
Commit messages:
- 8259528: Broken Link for [java.text.Normalizer.Form]
Changes: https://git.openjdk.java.net/jdk/pull/2028/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2028=00
Issue:
On Fri, 8 Jan 2021 20:34:10 GMT, Roger Riggs wrote:
> Cleanup of tests test/jdk/java/net and test/jdk/sun/net that format
> hexadecimal strings to use java.util.HexFormat methods.
> Also in tests test/jdk/java/util/Locale/SoftKeys.
+1
-
Marked as reviewed by naoto (Reviewer).
On Tue, 5 Jan 2021 17:59:01 GMT, Naoto Sato wrote:
> Please review this copyright notice update in the CLDR Converter tool. It is
> now synched with src/java.base/share/legal/cldr.md file.
This pull request has now been integrated.
Changeset: 4a5786b5
Author: Naoto Sato
URL:
Please review this copyright notice update in the CLDR Converter tool. It is
now synched with src/java.base/share/legal/cldr.md file.
-
Commit messages:
- 8259075: Update the copyright notice in the files generated by CLDR
Converter tool
Changes:
On Mon, 4 Jan 2021 18:11:05 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the integration of tzdata2020e to JDK.
>
> Details regarding the change can be viewed at -
> https://mm.icann.org/pipermail/tz-announce/2020-December/63.html
> Bug:
On Fri, 18 Dec 2020 23:34:04 GMT, Brent Christian wrote:
>> This change adds some extra test output for NativeLibraryTest, primarily via
>> an update to the ForceGC utility class.
>>
>> It was observed that there was nothing preventing the Cleaner from cleaning
>> the short-lived Object that
On Thu, 17 Dec 2020 01:01:38 GMT, Stuart Marks wrote:
> Back out code changes from JDK-8235812 to restore correct matching behavior.
> Adjust test to comment out cases that tested for incorrect behavior.
Backout and test changes according to it look good to me.
-
Marked as
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move to share/data, and move jdwp.spec to java.se
>
> Reviewed changes to `character
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote:
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
>
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
This pull request has now been integrated.
Changeset: 74b79c6e
Author: Nao
On Fri, 11 Dec 2020 00:15:49 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment for LOCALE_IFIRSTWEEKOFYEAR Windows return values
>
> src/java.base/windows/cl
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
A
On Thu, 10 Dec 2020 17:22:06 GMT, Brian Burkhalter wrote:
> Please review this small verbiage change to specify clearly the behavior of
> `Reader::read(char[] cbuf)` when the length of `cbuf` is zero, and that of
> `Reader::read(char[] cbuf, int off, int len)` when `len` is zero.
Looks good
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
Hello,
Please review the changes to the subject issue. getMinimalDaysInFirstWeek() for
Windows has been implemented to suffice the bug claim.
-
Commit messages:
- JDK-8257964
Changes: https://git.openjdk.java.net/jdk/pull/1741/files
Webrev:
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Mon, 7 Dec 2020 23:52:29 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test
On Mon, 7 Dec 2020 19:30:28 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test
On Sat, 5 Dec 2020 05:33:25 GMT, Alexander Matveev wrote:
> Fixed by using correct localized resources.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1638
On Fri, 4 Dec 2020 16:58:56 GMT, Brian Burkhalter wrote:
> Please review this trivial change to make the `writeBuffer` array field final
> and move it to the beginning of the class where other fields are declared.
Marked as reviewed by naoto (Reviewer).
-
PR:
On Thu, 3 Dec 2020 19:10:46 GMT, Mandy Chung wrote:
> VarHandleTestByteArrayAsInt.java intermittently fails only fastdebug build
> and slow mac os machines. I can't reproduce this locally. It fails on jdk
> 16 internal testing on a few builds. I propose to increase the timeout and
> see
On Thu, 3 Dec 2020 01:08:18 GMT, Stuart Marks wrote:
> Some small doc changes. The changes are to `@apiNote` text, which is
> non-normative, so no CSR is required.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1585
On Mon, 30 Nov 2020 20:56:17 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
mat
unusable for those use cases.
Though it would diverge from consistency with existing parsing of
hexadecimal in Character, Integer, Long, etc,
I'll post an update to use the string parsing allowing only Latin1
hexadecimal characters.
Comments?
Thanks, Roger
On 11/27/20 5:43 PM, Naot
On Fri, 27 Nov 2020 16:57:07 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 853:
>>
>>> 851: */
>>> 852: public int fromHexDigit(int ch) {
>>> 853: int value = Character.digit(ch, 16);
>>
>> Do we need to limit parsing the hex digit for
On Wed, 25 Nov 2020 22:51:44 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Mon, 23 Nov 2020 19:24:51 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix. Thanks.
This pull request has now been integrated.
Changeset: b3497f9b
Author: Naoto Sato
URL: https://git.openjdk.java.net/jdk/commit/b3497f9b
Stats: 2 lines in 1 file c
Hi,
Please review this simple doc fix. Thanks.
-
Commit messages:
- 8256839: JavaDoc for java.time.Period.negated() method
Changes: https://git.openjdk.java.net/jdk/pull/1399/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1399=00
Issue:
On Fri, 20 Nov 2020 17:55:55 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
This pull request has now been integrated.
Changeset: ae0ca743
Author: Nao
Hi,
Please review the changes to the subject issue. This is to incorporate the
latest language subtag registry definition into the JDK.
-
Commit messages:
- LSR 2020-09-29
- LSR 2020-07-17
Changes: https://git.openjdk.java.net/jdk/pull/1357/files
Webrev:
On Thu, 19 Nov 2020 17:15:11 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this doc only fix to the class description of `DecimalFormat`
> class. `localized minus sign` has never been (and should never be) used in
> the implicit negative subpattern. Actual implementation corre
On Tue, 17 Nov 2020 23:19:23 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for upgrading the CLDR data to version 38. The vast
> majority of the changes are simply the changes in CLDR upstream, and others
> are mainly test changes due to the locale data change.
Th
On Thu, 19 Nov 2020 21:41:00 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8246739: InputStream.skipNBytes could be implemented more efficiently
>> - 8246739
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote:
>> Please review this modification of `java.io.InputStream.skipNBytes(long)` to
>> improve its performance when `skip(long)` skips fewer than the requested
>> number of bytes. In the current implementation, `skip(long)` is invoked once
On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote:
> Please review this modification of `java.io.InputStream.skipNBytes(long)` to
> improve its performance when `skip(long)` skips fewer than the requested
> number of bytes. In the current implementation, `skip(long)` is invoked once
>
Hi,
Please review this doc only fix to the class description of `DecimalFormat`
class. `localized minus sign` has never been (and should never be) used in the
implicit negative subpattern. Actual implementation correctly uses ascii minus
sign for that purpose, so there won't be any
On Tue, 17 Nov 2020 23:19:23 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for upgrading the CLDR data to version 38. The vast
> majority of the changes are simply the changes in CLDR upstream, and others
> are mainly test changes due to the locale data chan
Hi,
Please review the changes for upgrading the CLDR data to version 38. The vast
majority of the changes are simply the changes in CLDR upstream, and others are
mainly test changes due to the locale data change.
-
Commit messages:
- Updated the version in `cldr.md` files
-
On Thu, 29 Oct 2020 15:59:51 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for the subject issue. This is to enhance the
> java.time package to support day periods, such as "in the morning", defined
> in CLDR. It will add a new pattern character 'B' a
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull requ
On Thu, 12 Nov 2020 21:49:16 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed the following comments:
>> - https://github.com/openjdk/jdk/
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Re-worded the spec of appendDayPeriodText, refactored calculation of
minute-of-day.
On Thu, 12 Nov 2020 15:21:52 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a test case for user defined temporal field resolution with day
>> period.
>
&g
On Thu, 12 Nov 2020 15:41:56 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a test case for user defined temporal field resolution with day
>> period.
&
On Thu, 12 Nov 2020 15:18:44 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarified 24:00 for "midnight" type in the spec. Some clean up.
>
> src/
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressed the following comments:
- https://github.com/openjdk/jdk/pull/938#disc
On Wed, 11 Nov 2020 11:58:08 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the fix for JDK-8256018 which addresses the issue that the
>> update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
>> Reference.reachabilityFence to ensure that direct byte buffer are kept
On Tue, 10 Nov 2020 21:26:59 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the fix for JDK-8256018 which addresses the issue that the
> update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
> Reference.reachabilityFence to ensure that direct byte buffer are kept kept
>
On Mon, 9 Nov 2020 01:37:39 GMT, Naoto Sato wrote:
>> I've had a look tonight, but found two more problems!
>>
>> The comments at the start of `resolveTimeLenient()` indicate that setting
>> the midpoint in `resolveTimeFields()` is a bad idea - it nee
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added a test case for user defined temporal field resolution with day period.
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Clarified 24:00 for "midnight" type in the spec. Some
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing https://github.com/openjdk/jdk/pull/938#discussion_r519061476
On Fri, 6 Nov 2020 23:59:36 GMT, Stephen Colebourne
wrote:
>> I find the whole "half way between the start and end" behaviour of day
>> periods odd anyway, but if it is to be supported then it should be
>> consistent as you've implemented.
>>
>> Another option I should have thought of
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Fixed a comment.
-
Changes:
- all: https://git.openjdk.ja
On Thu, 5 Nov 2020 23:49:25 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo/grammatical error.
>
> src/java.base/share/classes/java/time/format
and its spec are in this CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8254629
>
> Naoto
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressed the following comments:
- https://github.com/openjdk/jdk/pull/938#disc
701 - 800 of 1638 matches
Mail list logo
