RFR [15/java.xml] 8248884: Regression caused by the update to BCEL 6.0

Please refer to the previous review for 8248348. This patch should have been pushed into 15 in the first place. I hope a merge with 16 repo won't cause any trouble/conflict. JBS: https://bugs.openjdk.java.net/browse/JDK-8248884 webrev: http://cr.openjdk.java.net/~joehw/jdk15/8248884/webrev/

Re: RFR [15/java.xml] 8248884: Regression caused by the update to BCEL 6.0

On 7/6/20 4:55 PM, Stuart Marks wrote: On 7/6/20 4:37 PM, [email protected] wrote: Please refer to the previous review for 8248348. This patch should have been pushed into 15 in the first place. I hope a merge with 16 repo won't cause any trouble/conflict. JBS: https://bugs.openjdk.j

RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

Hi, Please review a patch to remove an illegal access to java.lang by the SafeThread. Note that InnocuousThread meets all the needs for SafeThread except that it also revokes permissions that the xml parser requires. This patch uses the new constructor added to Thread in JDK 9 that do not inh

Re: RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

Thanks Chris, Roger, and Mandy.  I've updated the webrev using AtomicInteger and removing java.base export. Here's the updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8248486/webrev/ -Joe On 7/10/20 9:59 AM, Mandy Chung wrote: Hi Joe, The change looks good.   You can consider using

Re: RFR[15/java.xml] Re: RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

On 7/12/20 11:11 PM, Alan Bateman wrote: On 12/07/2020 23:21, Joe Wang wrote: Hi all, Alan updated the bug to indicate it fails since JDK 9. Given we still have a couple days for JDK 15, I've rebased the patch to the jdk15 repo and would like to check in the patch into JDK 15 instead (and

hg: jdk8/tl/jaxp: 7160380: Sync JDK8 with JAXP 1.4.5

Changeset: ceae213d9812 Author:joehw Date: 2012-04-17 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ceae213d9812 7160380: Sync JDK8 with JAXP 1.4.5 Summary: bring JDK8 up to date to what we have in 7u4 Reviewed-by: lancea, mullan + src/com/sun/org/apache/xalan/intern

hg: jdk8/tl/jdk: 7160380: Sync JDK8 with JAXP 1.4.5

Changeset: 6cf68360cfaf Author:joehw Date: 2012-04-17 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cf68360cfaf 7160380: Sync JDK8 with JAXP 1.4.5 Summary: bring JDK8 up to date to what we have in 7u4 Reviewed-by: lancea, mullan ! src/share/lib/security/java.security

hg: jdk8/tl/jaxp: 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark

Changeset: 633700642caf Author:joehw Date: 2012-06-07 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/633700642caf 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark Summary: roll back XalanJ-2271 that caused the regression Reviewed

hg: jdk8/tl/jaxp: 7157608: One feature is not recognized.

Changeset: 238d2d0249af Author:joehw Date: 2012-06-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/238d2d0249af 7157608: One feature is not recognized. Summary: adding feature standard-uri-conformant into the recognized list Reviewed-by: psandoz ! src/com/sun/org/ap

hg: jdk8/tl/jaxp: 7157610: NullPointerException occurs when parsing XML doc

Changeset: f328914a04ea Author:joehw Date: 2012-06-11 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f328914a04ea 7157610: NullPointerException occurs when parsing XML doc Summary: recovers what was the original disallow-doctype-decl, reporting error when disallow-doc

hg: jdk8/tl/jaxp: 7144423: StAX EventReader swallows the cause of error

Changeset: 0c7f86d9ff8b Author:joehw Date: 2012-06-12 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c7f86d9ff8b 7144423: StAX EventReader swallows the cause of error Summary: make sure the cause of the error is properly reported Reviewed-by: lancea, psandoz ! src/co

hg: jdk8/tl/jaxp: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException

Changeset: 7920ead2cc75 Author:joehw Date: 2012-06-26 15:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7920ead2cc75 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException Summary: skip the added international character handling f

hg: jdk8/tl/jaxp: 7183760: DocumentBuilder.parse(String uri) is not IPv6 enabled

Changeset: 6e444b892c99 Author:joehw Date: 2012-07-12 21:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6e444b892c99 7183760: DocumentBuilder.parse(String uri) is not IPv6 enabled Summary: removing the hack of using escapeNonUSAscii. this is the same patch as 7166896 for

hg: jdk8/tl/jaxp: 7191547: XMLEventFactory.newFactory(String factoryId, ClassLoader loader) does not work as expected

Changeset: 2946807a6d7f Author:joehw Date: 2012-08-17 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2946807a6d7f 7191547: XMLEventFactory.newFactory(String factoryId, ClassLoader loader) does not work as expected Summary: similar to the patch for 6756677 for XMLInput

hg: jdk8/tl/jaxp: 8000172: 2 SAX features does not work properly

Changeset: 53a2a4893c8f Author:joehw Date: 2012-10-09 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/53a2a4893c8f 8000172: 2 SAX features does not work properly Summary: When external dtd is not loaded, skippedEntity event should be reported for entity references. Rev

Re: Review request for JDK-8080907 - Develop test for Xerces Update: XML Schema Validation

Hi Frank, The change looks good to me. Thanks, Joe On 6/12/2015 12:27 AM, Frank Yuan wrote: Hi Joe, Lance and all Would you like to have a review for bug: https://bugs.openjdk.java.net/browse/JDK-8080907? I added some new tests and updated some existing tests to add more coverage for JAX

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

Hi Sean, The change looks good to me. Thanks, Joe On 6/12/2015 10:29 AM, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implement

Re: [verona.stage] RFR 8087203: Add support for PATCH field and remove unused fields of new version string

Hi Alejandro, Alan's right about the JAXP version-check code. But since this is urgently needed, I agree you can push the change as is. I'll create a separate bug to re-examine version related code in jaxp. As Alan pointed out, it would be some clean-up. Thanks, Joe On 6/19/2015 9:53 AM, Al

Re: RFR: 8129572 - Cleanup usage of getResourceAsStream in jaxp

Hi Daniel, Thanks for the cleanup! The webrev looks good to me too. -Joe On 6/23/2015 8:52 AM, Mandy Chung wrote: On Jun 23, 2015, at 7:16 AM, Daniel Fuchs wrote: Hi, Please find below a patch for 8129572 - Cleanup usage of getResourceAsStream in jaxp https://bugs.openjdk.java.net/browse/

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

+1. -Joe On 6/24/2015 1:58 AM, Daniel Fuchs wrote: Hi Frank, The proposed changes look good to me. best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote: Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw chang

Re: RfR: 8129880 - Cleanup usage of Class.getResource in jaxp

+1 Thanks, Joe On 6/25/2015 8:46 AM, Daniel Fuchs wrote: Hi, Please find below a cleanup patch for jaxp: https://bugs.openjdk.java.net/browse/JDK-8129880 8129880 - Cleanup usage of getResource in jaxp Class.getResource(classFile) was used for printing the class location for debuging purposes

Re: RFR - 8129956: jaxp: CodeSource.getLocation() might return null

Maybe it's better to live with PrivilegedAction and PrivilegedAction instead? I'm using NetBeans 8.0.2, it looks like it doesn't support "source level" beyond JDK 1.8. It's a bit bothersome to have "red flags". Plus, we won't be able to build with JDK 8. What would you think? Best, Joe On

Re: RFR: 8130051 Cleanup usage of reflection in jaxp

Hi Daniel, Another great cleanup! The change looks good to me. Only minor suggestion: same as 8129956, would you want to add the types back instead of using diamond operator? It looks good, but the red flags in the NetBeans could be a bit troublesome. Plus, honestly, I still regularly compil

Re: JDK 9 RFR of JDK-8130719: Fix reference problems in jax-ws javadoc

Looks good to me. Joe On 7/7/2015 5:35 PM, joe darcy wrote: Hello, Please review the patch below which fixes some javadoc reference issues in jax-ws: JDK-8130719: Fix reference problems in jax-ws javadoc Thanks, -Joe diff -r 1d87054e2d2f src/java.xml.ws/share/classes/javax/xml/ws/ha

Re: [9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

--- old/src/java.annotations.common/share/classes/javax/annotation/PostConstruct.java 2015-07-08 13:25:02.0 +0200 +++ new/src/java.annotations.common/share/classes/javax/annotation/PostConstruct.java 2015-07-08 13:25:01.0 +0200 - * Copyright (c) 2005, 2013, Oracle and/or its aff

Re: [9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

On 7/9/2015 3:36 AM, Miroslav Kos wrote: Hi again, thanks for valuable feedback - I missed those before. Second version of a patch: http://cr.openjdk.java.net/~mkos/8130753/jaxws.02/ issues addressed: * : not backporting correctly changes done in jdk repo, will fix in standalone rep

RFR (jaxp) 8131907 : Numerous threads lock during XML processing

Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/8131907/webrev/ Thanks, Joe

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

Thanks Roger! Joe On 7/21/2015 6:36 AM, Roger Riggs wrote: Hi Joe, Looks good. Roger On 7/20/2015 5:47 PM, huizhe wang wrote: Please review a change that removes unnecessary class loading. http://cr.openjdk.java.net/~joehw/jdk9/8131907/webrev/ Thanks, Joe

Re: RFR (jaxp) 8131907 : Numerous threads lock during XML processing

On 7/21/2015 9:51 AM, Daniel Fuchs wrote: Hi Joe, Looks good to me! nit: the two statics don't agree on style: 'private static final' vs 'private final static' Good catch! Fixed. Thanks! -Joe best regards, -- daniel On 20/07/15 23:47, huizhe wang wrote: Pl

Re: RFR: 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java

Looks good to me. Thanks, Joe On 7/24/2015 1:46 AM, Daniel Fuchs wrote: Hi, Please find below a patch that fixes 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java https://bugs.openjdk.java.net/browse/JDK-8132256 webrev: http://cr.openjdk.java.net/~dfu

Re: RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

Hi Daniel, On 7/28/2015 8:22 AM, Daniel Fuchs wrote: Hi, Please find below a fix for yet another cleanup for jaxp: Thanks for yet another cleanup! And, there is a lot more to come :-) 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java https:/

Re: RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

On 7/28/2015 10:32 AM, Daniel Fuchs wrote: On 28/07/15 19:20, huizhe wang wrote: Hi Daniel, On 7/28/2015 8:22 AM, Daniel Fuchs wrote: Hi, Please find below a fix for yet another cleanup for jaxp: Thanks for yet another cleanup! And, there is a lot more to come :-) 8130059: jaxp

Re: RfR - 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java

Hi Daniel, On 7/30/2015 6:38 AM, Daniel Fuchs wrote: Hi, Please find below an updated webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.01/ Looks good to me. The only nit is it seems createDefaultErrorHandler method is a dup of createDefaultErrorListener? Instead of remov

Re: RfR - 8130058: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/Process.java

On 7/30/2015 9:08 AM, Daniel Fuchs wrote: On 30/07/15 17:55, huizhe wang wrote: Hi Daniel, On 7/30/2015 6:38 AM, Daniel Fuchs wrote: Hi, Please find below an updated webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.01/ Looks good to me. The only nit is it seems

Re: RfR - 8132550: java/util/logging/LoggingDeadlock2.java times out

Looks good to me, Daniel. -Joe On 7/31/2015 3:48 AM, Daniel Fuchs wrote: Hi, Please find below a fix for: https://bugs.openjdk.java.net/browse/JDK-8132550 8132550: java/util/logging/LoggingDeadlock2.java times out I was able to reproduce the deadlock consistently by inserting some Thread.sle

Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

Hi Frank, That looks fine. However, instead of appending an additional directory "utests", you could make the paths shorter by removing "javax/xml" and "org/w3c" or "org/xml". The short names are good enough to represent the API names, test/javax/xml/jaxp/unittest/parsers for example, is easil

Re: Review request for JDK-8132660: Change jaxp unit test package name to be different with jaxp api

.01/> Btw, I only applied this practice on unit test, not for functional test because Tristan still has a functional suite pending, I would unify the functional part sometime after that suite is finished. Best Regards Frank *From:*huizhe wang [mailto:[email protected]] *Sent:* Wednesday,

Re: RFR 8133939: javadoc clarification for java.sql.Date.toLocalDate()

Looks good, Lance. Best, Joe On 8/21/2015 5:48 AM, Lance Andersen wrote: Hi, Here is a minor javadoc update for java.sql.Date.toLocalDate(). The ccc has been approved. Best Lance hg diff Date.java diff -r 562b349a85da src/java.sql/share/classes/java/sql/Date.java --- a/src/java.sql/share

Re: Review request for JDK-8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518

Looks good to me. Thanks, Joe On 8/25/2015 2:43 AM, Frank Yuan wrote: Hi, Joe and all Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8133924? The webrev is at: http://cr.openjdk.java.net/~fyuan/8133924/webrev.00/

Re: RFR 8134426: Add serialVersionUID field to relevant javax.transaction classes

Hi Lance, The change looks good. -Joe On 8/25/2015 11:29 AM, Lance Andersen wrote: Hi, Looking for a reviewer for 8134426 This change adds a serialVersionUID field to the required javax.transaction classes as well as some basic tests. Once approved, I will work to push the same changes

Re: RFR 9: 8133528 : java/lang/ProcessHandle/OnExitTest.java fails intermittently

Looks good to me, Roger. Thanks, Joe On 9/15/2015 3:20 PM, Roger Riggs wrote: Please review this test fix to remove checks for subprocesses not spawned by the test. There are spurious processes (like virus checkers) that show up unexpectedly. webrev: http://cr.openjdk.java.net/~rriggs/web

RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the result of a merge with the upper Xerces source. The new methods implementation starts a

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

Sep 25, 2015, at 3:41 PM, huizhe wang <mailto:[email protected]>> wrote: Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the re

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

On 9/25/2015 2:18 PM, Mandy Chung wrote: On 09/25/2015 12:41 PM, huizhe wang wrote: Hi, Please review the DOM update to include the Element Traversal Specification. ElementTraversal is an interface which allows the author to restrict navigation to Element nodes. The implementation is the

Re: RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

Thanks Mandy and Lance for the review! Changes pushed. -Joe On 9/25/2015 3:40 PM, Mandy Chung wrote: On 09/25/2015 02:38 PM, huizhe wang wrote: With this application/libraries used to put xml-apis-2.11.0.jar on the endorsed/ext directory or classpath no longer needs to do that because

RFR (jaxp) 8136778: SAXParser: support stopping a parsing process

Hi, This is an enhancement to allow a SAX parsing process to be stopped and resumed. A SAX process scans through an entire document while making callbacks to its handler when defined events are met. The stop and resume methods make it easy to stop and subsequently resume the process as needed

RFR (JAXP) 8138721 : ElementTraversal: javadoc warning; also, hasFeature shall return true

Hi, Thanks Lance and Daniel for pointing out the javadoc warning! Here's the fix. Also, added ElementTraversal to the DOMImplementation supported feature list. JBS: https://bugs.openjdk.java.net/browse/JDK-8138721 http://cr.openjdk.java.net/~joehw/jdk9/8138721/webrev/ Thanks, Joe

Re: RFR (JAXP) 8138721 : ElementTraversal: javadoc warning; also, hasFeature shall return true

are any exception, so I'm going to just let it return false. http://cr.openjdk.java.net/~joehw/jdk9/8138721/webrev/ -Joe Best Lance best regards, -- daniel On 02/10/15 02:16, huizhe wang wrote: Hi, Thanks Lance and Daniel for pointing out the javadoc warning! Here's the fix.

RFR (JAXP) : 8081248: Implement JEP 268: XML Catalog API

Hi all, Please help review JEP 268 implementation: https://bugs.openjdk.java.net/browse/JDK-8081248 Catalog specification: https://www.oasis-open.org/committees/download.php/14809/xml-catalogs.html webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8081248/webrev/ A Catalog is basically an order

Re: RFR (JAXP) - JDK-8077931: Develop tests for XML Catalog API

Looks good to me, John. Best regards, Joe On 10/23/2015 12:48 AM, John Jiang wrote: Hi all, Please help review the tests for XML Catalog API: https://bugs.openjdk.java.net/browse/JDK-8077931 The webrev is at http://cr.openjdk.java.net/~fyuan/jjiang/8077931/webrev.00/ Best regards, John Jian

RFR (JAXP) : 8142900: Xerces Update: Xerces XPath

Hi, The purpose of the update was to fix the JCK issue 8069052[1], which demanded the acceptance of a full character list in reZ003v.xml as XML Schema defined words. However, since b74, the JDK has been updated to support Unicode 7.0.0[2], in particular, U+2308..U+230B were changed from Sm to

Re: RFR (JAXP) : 8142900: Xerces Update: Xerces XPath

Additional fix: Fixed all warnings in the group: [cast] redundant cast to char in REUtil, RangeToken and Token fallthrough in RegularExpression, RegexParser [rawtypes] in RegexParser Thanks, Joe On 11/12/2015 2:03 PM, huizhe wang wrote: Hi, The purpose of the update was to fix the JCK

Re: RFR (JAXP) : 8142900: Xerces Update: Xerces XPath

Thanks Lance! Joe On 11/14/2015 9:41 AM, Lance Andersen wrote: Hi Joe, Looks OK. Best Lance On Nov 13, 2015, at 6:15 PM, huizhe wang <mailto:[email protected]>> wrote: Additional fix: Fixed all warnings in the group: [cast] redundant cast to char in REUtil, RangeToken

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 11/19/2015 12:45 PM, Alan Bateman wrote: On 19/11/2015 18:36, Daniel Fuchs wrote: Hi Miran, I would expect this to fail horribly - you may not have the right to create anything under $JAVA_HOME/conf - it may even be a read-only file system... And I would be very uneasy as this may have s

Re: RFR: 8085984 Add JDBC Sharding API

Hi Lance, Looks good, except as Ulf pointed out already, in both in Connection.java and XAConnection.java, SQLFeatureNotSupportedException should have been thrown with a message "setShardingKeyIfValid not implemented" rather than "isValid not implemented" (4 occurrences in total). Best, Joe

Re: RFR: 8143165 Add Statement.isSimpleIdentifier and update enquoteLiteral

Looks good, Lance. Have a great holiday when all these improvements are done :-) Best, Joe On 11/24/2015 11:48 AM, Lance Andersen wrote: Hi, Please provide a review for http://cr.openjdk.java.net/~lancea/8143165/webrev.00/. This adds Statement.isSimpleIdentifier, adds a throws SQLException

RFR (JAXP): 8144094: Add Catalog API to java.xml module

Hi, The new Catalog API needs to be added to the java.xml module. Please review the following change: diff --git a/make/common/CORE_PKGS.gmk b/make/common/CORE_PKGS.gmk --- a/make/common/CORE_PKGS.gmk +++ b/make/common/CORE_PKGS.gmk @@ -224,6 +224,7 @@ javax.tools \ javax.transaction

RFR (JAXP): 8142463: Xml schema validation failing after Xerces update; maxOccurs ignored

Hi, This is a quick one-line fix. For the UPA [1] processing, the DFA was compacted. A flag (fIsCompactedForUPA) was added to indicate whether the DFA was compacted. In the previous update however, the line that set the flag was missed. This fix recovers the previous update. All tests pass

RFR (JAXP): 8132091: Clean up JAXP code that has dependency on Java version string

Hi, This is a clean-up of the code in jaxp that had depended on Java version string. This code came from JAXP standalone that no longer exists. jbs: https://bugs.openjdk.java.net/browse/JDK-8132091 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8132091/webrev/ Thanks, Joe

Re: RFR (JAXP): 8132091: Clean up JAXP code that has dependency on Java version string

Thanks Lance! Joe On 12/3/2015 11:16 AM, Lance Andersen wrote: Hi Joe, Looks OK… Best Lance On Dec 3, 2015, at 2:06 PM, huizhe wang <mailto:[email protected]>> wrote: Hi, This is a clean-up of the code in jaxp that had depended on Java version string. This code came

Re: RFR (JAXP): 8132091: Clean up JAXP code that has dependency on Java version string

, iris -Original Message- From: huizhe wang Sent: Thursday, December 03, 2015 11:07 AM To: [email protected] Subject: RFR (JAXP): 8132091: Clean up JAXP code that has dependency on Java version string Hi, This is a clean-up of the code in jaxp that had depended on Java

Re: [8u-dev] Request for approval: 8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518

Hi Aleksej, First of all, I'm not a reviewer for 8u. The test is fine in proving that no NPE is thrown, which indicates the 2nd nodeset is not null. However, there's a 2nd aspect of this: it should be empty. I suggest improving the test so that it further proves that it's not only "not null"

Re: [8u-dev] Request for approval: 8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518

, Joe Best Regards, Aleksej On 12/05/2015 02:18 AM, huizhe wang wrote: Hi Aleksej, First of all, I'm not a reviewer for 8u. The test is fine in proving that no NPE is thrown, which indicates the 2nd nodeset is not null. However, there's a 2nd aspect of this: it should be empty.

RFR (JAXP): 8072081 : Supplementary characters are rejected in comments

Hi, Please review https://bugs.openjdk.java.net/browse/JDK-8072081. Supplementary characters are supported as character data in xml 1.0, and also names in xml 1.1. This patch fixed the bug that rejected supplementary characters in comments, and also made sure they are accepted in names. we

Re: RFR (JAXP): 8072081 : Supplementary characters are rejected in comments

2.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]> Sent from my iPad On Dec 9, 2015, at 5:37 PM, huizhe wang <mailto:[email protected]>> wrote: Hi, Please review https://bugs.openjdk.java.n

RFR (JAXP): 8068839: newDuration(x) produces incorrect outputs for some values of x

This is a fix for an edge case. All tests passed after the fix. JBS: https://bugs.openjdk.java.net/browse/JDK-8068839 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8068839/webrev/ Thanks, Joe

RFR (JAXP): 8144967: javax.xml.transform.Source and org.xml.sax.InputSource can be empty

Hi, Adding a convenient method isEmpty to javax.xml.transform.Source and org.xml.sax.InputSource. JBS: https://bugs.openjdk.java.net/browse/JDK-8144967 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8144967/webrev/ Thanks, Joe

Re: RFR (JAXP): 8144967: javax.xml.transform.Source and org.xml.sax.InputSource can be empty

st: - This test is duplicated: + "{new SAXSource(new InputSource(new StringReader("")))}, + {new SAXSource(new InputSource(new StringReader("")))}, Fixed. http://cr.openjdk.java.net/~joehw/jdk9/8144967/webrev/ Thanks, Joe Roger On 12/17/2015 7:25 P

Re: RFR (JAXP): 8144967: javax.xml.transform.Source and org.xml.sax.InputSource can be empty

Thanks Roger! Joe On 12/22/2015 12:07 PM, Roger Riggs wrote: Hi Joe, Thanks for the updates. Looks fine. Roger On 12/21/2015 7:11 PM, huizhe wang wrote: Thanks Roger! On 12/21/2015 1:35 PM, Roger Riggs wrote: Hi Joe, A few comments: InputSource: I assume you meant

Re: RFR: 8144082: Add Statement.enquoteNCharLiteral

Looks good. A minor typo in the test: + * Validate a NullPointerException is thrown is the string passed to the 2nd "is" --> "if" Best, Joe On 12/22/2015 12:59 PM, Lance Andersen wrote: Happy Tuesday, Need a reviewer for 8144082 which adds Statement.enquoteNCharLiteral. The CCC has

RFR (JAXP): 8144966: Catalog API: Null handling and reference to Reader

Hi, This is an improvement to the new Catalog API on null handling. At the package level, a null argument shall result in NPE. However, an exception was made to the methods in CatalogManager so that they can used conveniently. With this request, we're in favor of consistency over the minor co

Re: RFR (JAXP): 8144966: Catalog API: Null handling and reference to Reader

Thanks Mandy. Please see inline. On 1/4/2016 6:50 PM, Mandy Chung wrote: On Dec 23, 2015, at 2:55 PM, huizhe wang wrote: Hi, This is an improvement to the new Catalog API on null handling. At the package level, a null argument shall result in NPE. However, an exception was made to the

Re: RFR (JAXP): 8144966: Catalog API: Null handling and reference to Reader

On 1/6/2016 4:53 PM, Mandy Chung wrote: On Jan 6, 2016, at 4:11 PM, huizhe wang wrote: What if “paths” is non-empty but all entries are invalid and no catalog file is read - will it read the system property? It will not read the system property. The assumption is that the paths specified

Re: RFR 9: 8146671 [TEST BUG] : java/lang/ref/CleanerTest.java required more memory for -UseCompressedOops runs

Looks good, Roger. -Joe On 1/12/2016 1:31 PM, Roger Riggs wrote: Please review an update to a CleanerTest; the 4m limit is not needed and causes a problem when run with CompressedOops Webrev: http://cr.openjdk.java.net/~rriggs/webrev-cleanertest-8146671/ Issue: https://bugs.openjdk.java.

RFR (JAXP): 8146606: Catalog.matchSystem() appends an extra '/' to the matched result

Please review a fix to the match method of RewriteSystem and RewriteUri that resulted in an extra slash in the URI. Webrev: http://cr.openjdk.java.net/~joehw/jdk9/8146606/webrev/ Issue: https://bugs.openjdk.java.net/browse/JDK-8146606 Thanks, Joe

RFR (JAXP): 8147051: StaxEntityResolverWrapper should create StaxXMLInputSource with a resolver indicator

Happen to notice that the indicator that the source was created by a resolver was not set in StaxEntityResolverWrapper. Also, it's "IsCreatedByResolver" rather than "hasResolver". JBS: https://bugs.openjdk.java.net/browse/JDK-8147051 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8147051/webre

Re: RFR 8146803: Update to the sharding API

Looks good overall. A few minor things and typos: CommonDataSource: Lic header: 2013 --> 2016; createShardingKeyBuilder: "@since 1.9" --> since 9 ConnectionPoolDataSource: Lic header: 2013 --> 2016; createShardingKeyBuilder: "@since 1.9" --> since 9

Re: Regarding the removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

/ On 28/07/15 19:20, huizhe wang wrote:/ >>/ Hi Daniel,/ >>/ / >>/ / >>/ On 7/28/2015 8:22 AM, Daniel Fuchs wrote:/ >>>/ Hi,/ >>>/ / >>>/ Please find below a fix for yet another cleanup for jaxp:/ >>/ / >>/ Thanks for yet anoth

Re: [9] RFR: 8144593: Suppress not recognized property/feature warning messages from SAXParser

Looks good Aleksej! -Joe On 2/3/2016 10:19 AM, Aleksej Efimov wrote: Hi, Please, help to review the fix for JDK-8144593 bug [1] in jaxp area: http://cr.openjdk.java.net/~aefimov/8144593/9/00/ Problem: JDK produces warnings when non-default parser implementation is used and this parser doesn

Re: RFR: 8149601 Update references from "1.9" to "9"

Hi Iris, The change looks good. Two of the previously included classes appeared twice in the webrev index page :-) Thanks, Joe On 2/11/2016 11:06 AM, Iris Clark wrote: Hi. A private review comment as noted that I missed a few files in the jaxp repository. The webrev has been updated in p

Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

Hi Christoph, At initialization of XSDHandler (in reset), note there are two local variables for the security / property manager, change them to instance variables, then when you need to create annotation validator, set both on the validator, e.g.: fAnnotationValidator.setProperty(SE

Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

se since there's no need to create a new instance here. Best, Joe Best Christoph -----Original Message- From: huizhe wang [mailto:[email protected]] Sent: Dienstag, 16. Februar 2016 21:03 To: Langer, Christoph Cc: [email protected] Subject: Re: JDK 9 RFR of

RFR (JAXP) 8146237: PREFER from Features API taking precedence over catalog file

Hi, Please review a fix on missing property settings read from catalog files. Values from catalog files shall override any other settings including those through the API, e.g. builder().with(CatalogFeatures.Feature.PREFER, "system"). JBS: https://bugs.openjdk.java.net/browse/JDK-8146237 webr

Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

#x27;s okay to keep the block as is. Best, Joe Thanks in advance and best regards Christoph -Original Message- From: huizhe wang [mailto:[email protected]] Sent: Mittwoch, 17. Februar 2016 00:22 To: Langer, Christoph Cc: [email protected] Subject: Re: JDK 9 RFR of JDK

Re: RFR (JAXP) 8146237: PREFER from Features API taking precedence over catalog file

Thanks Lance! On 2/17/2016 12:46 PM, Lance Andersen wrote: looks OK Joe On Feb 16, 2016, at 8:31 PM, huizhe wang <mailto:[email protected]>> wrote: Hi, Please review a fix on missing property settings read from catalog files. Values from catalog files shall override

Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

On 2/18/2016 5:15 AM, Langer, Christoph wrote: Hi Joe, here is the next version: http://cr.openjdk.java.net/~clanger/webrevs/8149915.2/ Looks good! Thanks. Copyright year in XSAttributeChecker.java is still incorrect. I meant to say the year "2016" needs to have a comma, so in this case, i

JDK-8149915 -> Re: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE

470.1/ <http://cr.openjdk.java.net/%7Eclanger/webrevs/8150470.1/> *From:*Langer, Christoph *Sent:* Dienstag, 23. Februar 2016 21:13 *To:* 'Aleksej Efimov' ; huizhe wang *Subject:* RE: JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation ca

Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees

Hi Christoph, Thanks for reporting and providing patch for the issue! Looks like a nice solution that may potentially reduce memory requirement for some large templates. Could you also verify that the patch also fixes JDK-8150699 [1] that was created the same day as yours? I assume the styl

Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees

Hi Langer, Thanks for the update. I'll do an all-test run. I'm okay with the TransformerTest, although it can be better. For the license header, I meant to say the whole header that includes updating the Apache License to its new format. You may update the webrev if you want. Otherwise, I c

Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees

like the way I read in reference result files and handle the line endings. I hope the test will run on Unix/Linuxes as well as on Windows. I tested in a Windows Cygwin environment. Furthermore, any objections against backporting to 8? Thanks for reviewing and best regards Christoph

Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees

port then. Best regards Christoph -Original Message----- From: huizhe wang [mailto:[email protected]] Sent: Donnerstag, 10. März 2016 19:07 To: Langer, Christoph Cc: [email protected] Subject: Re: [PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available'

Re: Replace uses of StringBuffer with StringBuilder[JAXP]

Hi Otavio, I'm glad to know you're interested in contributing to the JAXP project. The JAXP standalone itself has reached end-of-life. We're now concentrating on JAXP in OpenJDK. The repo is here: http://hg.openjdk.java.net/jdk9/dev/jaxp If you are interested in contributing to OpenJDK/jaxp,

Re: XMLScanner-supplementary-characters

Thanks Martin! Looks like the initial version of the jaxp port (from Xerces 2.7.1) missed the patch for reasons I don't know. I created a bug based on the very original bug report: https://bugs.openjdk.java.net/browse/JDK-8058175 Would you want to push the change into jdk9's jaxp repo? Thank

Re: Replace uses of StringBuffer with StringBuilder[JAXP]

Hi Otavio, Please let me know once you've submitted it. Best, Joe On 9/10/2014 10:40 AM, Otávio Gonçalves de Santana wrote: Hi Wang. Thank you for this information. I have the OCA On Sep 10, 2014 2:11 PM, "huizhe wang" <mailto:[email protected]>> wrote:

Re: XMLScanner-supplementary-characters

On 9/10/2014 3:20 PM, Martin Buchholz wrote: On Wed, Sep 10, 2014 at 3:11 PM, huizhe wang <mailto:[email protected]>> wrote: Thanks Martin! Looks like the initial version of the jaxp port (from Xerces 2.7.1) missed the patch for reasons I don't know. I

Re: XMLScanner-supplementary-characters

On 9/11/2014 12:43 AM, Alan Bateman wrote: On 10/09/2014 23:11, huizhe wang wrote: Thanks Martin! Looks like the initial version of the jaxp port (from Xerces 2.7.1) missed the patch for reasons I don't know. I created a bug based on the very original bug report:

Re: RFR: 8057826 minor clean-up to the java.sql Date/Time/Timestamp tests

Looks good, Lance. Best, Joe On 9/11/2014 4:46 AM, Claes Redestad wrote: Looks good to me, especially the added nanotime test coverage /Claes On 09/08/2014 07:31 PM, Lance Andersen wrote: Hi, Looking for a reviewer for this minor clean-up to the java.sql Date/Time/Timestamp tests which add

Re: Replace uses of StringBuffer with StringBuilder[JAXP]

[email protected]>> wrote: Hi Huizhe. Done. creates new remote head d053915e3689! On Wed, Sep 10, 2014 at 7:13 PM, huizhe wang mailto:[email protected]>> wrote: Hi Otavio, Please let me know once you've submitted it. Best,

Re: Replace uses of StringBuffer with StringBuilder[JAXP]

Hi Alan, Otavio, I'm very delighted that Otavio wants to help! I'm totally fine with updating the source to a higher source level, though diverging from the upstream projects in the process. I was only saying that it's currently not a high priority for me and that I don't have circles. There's

RFR (JAXP): 8036951: Xerces Update: XMLSchemaValidator.java and XMLSchemaLoader.java

Hi, This patch contains updates to 52 classes, mostly completely updated to the trunk except a few. I replaced some obsolete usages (e.g. Vector), but not all of them in order to not expand the update into more classes. With this patch, the main validation section is updated to the current tr

  1   2   3   4   5   6   >