RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/ > 34 lines changed: 0 ins; 11 del; 23 mod; Hi all, could you please review this trivial patch? from JBS: > JDK-8199290 made it unnecessary to explicitly pass > sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to ClassFileInstaller

RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 > 16 lines changed: 0 ins; 0 del; 16 mod; Hi all, could you please review this trivial cleanup in tests? from JBS: > ClassFileInstaller is a test utility class which copies class files to the > current directory, there is no point in runni

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

thanks Ioi for such a prompt review, pushed. -- Igor > On Apr 28, 2020, at 9:47 PM, Ioi Lam wrote: > > Looks good and trivial. > > Thanks > - Ioi > > On 4/28/20 9:41 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 >>

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

Hi Stefan, I've already pushed it (right after Ioi reviewed it), nevertheless I appreciate you reviewing it. -- Igor > On Apr 28, 2020, at 11:11 PM, Stefan Karlsson > wrote: > > Looks good. > > StefanK > > On 2020-04-29 06:41, Igor Ignatyev wrote: >> ht

Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

Serguei, David, thanks for your reviews. pushed. -- Igor > On Apr 28, 2020, at 11:39 PM, serguei.spit...@oracle.com wrote: > > LGTM++ > > Thanks, > Serguei > > > On 4/28/20 23:28, David Holmes wrote: >> Looks good! >> >> Thanks, >> Davi

RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00 > 8 lines changed: 2 ins; 0 del; 6 mod; Hi all, could you please review this small and trivial cleanup in TEST.ROOT files of test/jdk/ and test/hotspot/jtreg test suites? from JBS: > to make sure that classes listed in `requires.extraPropD

Re: RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

ping? -- Igor > On May 27, 2020, at 10:25 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00 >> 8 lines changed: 2 ins; 0 del; 6 mod; > > Hi all, > > could you please review this small and trivial cleanup in TEST.ROOT files of &

Re: RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

piny? -- Igor > On Jun 1, 2020, at 7:54 AM, Igor Ignatyev wrote: > > ping? > -- Igor > >> On May 27, 2020, at 10:25 AM, Igor Ignatyev wrote: >> >> http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00 >>> 8 lines changed: 2 ins; 0 del; 6 mod; >

Re: RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

Vladimir, Leonid, Thank you for your reviews! pushed. -- Igor > On Jun 4, 2020, at 3:55 PM, Leonid Mesnik wrote: > > Looks good. > > Leonid > On Jun 5, 2020, at 1:02 AM, Vladimir Ivanov > wrote: > > Looks good. > > Best regards, > Vladimir Ivanov >

Re: RFR: JDK-8246697 Test: java/util/StringJoiner/StringJoinerTest.java failing with OOM

Hi Jim, you should use another bug id, one which you are going to use to fix the problem, in the problem list. -- Igor > On Jun 5, 2020, at 7:41 AM, Jim Laskey wrote: > > Can I get a quick review for the following. Getting some unexpected OOM from > test. Pulling until I figure it out. > >

Re: RFR: JDK-8246697 - Test: StringJoinerTest and related MergeTest failing with OOM

Hi Jim, I'd also recommend you to add `@requires os.maxMemory > 4G` so the tests don't get executed on hosts which don't have enough memory for requested heap size. -- Igor > On Jun 5, 2020, at 10:46 AM, Jim Laskey wrote: > > Followup: can I get a quick review for the following. Both tests we

Re: RFR: JDK-8246697 - Test: StringJoinerTest and related MergeTest failing with OOM

2020 -0300 > @@ -25,7 +25,8 @@ > * @bug 5015163 7172553 > * @summary tests StringJoinerTest > * @modules java.base/jdk.internal.util > - * @run testng StringJoinerTest > + * @requires os.maxMemory > 4G > + * @run testng/othervm -Xmx4g StringJoinerTest > * @author Jim Gish >

RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

http://cr.openjdk.java.net/~iignatyev//8183040/webrev.00 > > 38 lines changed: 8 ins; 16 del; 14 mod; Hi all, could you please review this small clean up of testlibrary classes which updates j.t.lib.Platform and j.t.l.SA.SATestUtils (as it now contains the methods which 8183040 was about) to

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

oks like the caller doesn't expect it (it catches IOException). > > --alex > > On 06/09/2020 16:47, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8183040/webrev.00 >>> >>> 38 lines changed: 8 ins; 16 del; 14 mod; >> Hi all,

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

Hi Brian, thank you for your review. Cheers, -- Igor > On Jun 9, 2020, at 5:18 PM, Brian Burkhalter > wrote: > > Hi Igor, > >> On Jun 9, 2020, at 4:47 PM, Igor Ignatyev > <mailto:igor.ignat...@oracle.com>> wrote: >> >> could you please revi

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

Hi Alex, sure, here is the incremental diff, so now Error is thrown if bb arrays are empty -- http://cr.openjdk.java.net/~iignatyev//8183040/webrev.0-1 Thanks, -- Igor > On Jun 10, 2020, at 12:20 PM, Alex Menkov wrote: > > Hi Igor, > > On 06/09/2020 20:11, Igor Ignatyev wr

Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

thanks Alex, pushed. -- Igor > On Jun 10, 2020, at 1:05 PM, Alex Menkov wrote: > > Hi Igor, > > LGTM. > > --alex > > On 06/10/2020 12:29, Igor Ignatyev wrote: >> Hi Alex, >> sure, here is the incremental diff, so now Error is thrown if bb arrays are

RFR(S) : 8211977 : move testlibrary tests into one place

http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/ > 796 lines changed: 200 ins; 588 del; 8 mod; Hi all, could you please review this small patch which puts all tests for testlibrary classes into one location under /test/lib-test? besides moving tests from test/jdk/lib/testlibrary and t

Re: RFR(S) : 8211977 : move testlibrary tests into one place

adding build-dev > On Jun 12, 2020, at 8:36 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/ >> 796 lines changed: 200 ins; 588 del; 8 mod; > > Hi all, > > could you please review this small patch which puts all tests for test

Re: RFR(S) : 8211977 : move testlibrary tests into one place

testing revealed that LingeredAppTest.java required some love, incremental webrev w/ the fixes for LingeredAppTest -- http://cr.openjdk.java.net/~iignatyev//8211977/webrev.0-1 -- Igor > On Jun 12, 2020, at 8:38 PM, Igor Ignatyev wrote: > > adding build-dev > >> On Jun 12

Re: RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

Hi Roger, LGTM, Thanks, — Igor > On Jun 15, 2020, at 7:10 AM, Roger Riggs wrote: > > Roger

Re: RFR(S) : 8211977 : move testlibrary tests into one place

@David, Erik, Magnus, please find the answers to your comments at the bottom of this email. @all, David's and Erik's comments made me realize that some parts of the original patch were stashed away and didn't make it to webrev.00. I'm truly sorry for the confusion and inconvenience. I also agr

Re: RFR(S) : 8211977 : move testlibrary tests into one place

luate/improve/discuss the fate of the test. Thanks, -- Igor > On Jun 16, 2020, at 12:14 AM, David Holmes wrote: > > Hi Igor, > > On 16/06/2020 10:39 am, Igor Ignatyev wrote: >> @David, Erik, Magnus, >> please find the answers to your comments at the bottom of this em

Re: RFR(S) : 8211977 : move testlibrary tests into one place

Magnus, Erik, thanks for your reviews, pushed w/ a newline being added at L#654 of make/Main.gmk. Cheers, -- Igor > On Jun 16, 2020, at 7:03 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-16 15:06, Erik Joelsson wrote: >> >> On 2020-06-15 17:39, Igor Ignatyev

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

Hi Dan, LGTM Thanks, -- Igor > JDK-8248358 ProblemList > serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on > Windows > https://bugs.openjdk.java.net/browse/JDK-8248358 I guess you meant JDK-8248358 ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

Re: RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

LGTM, thanks for fixing, and sorry for introducing that. — Igor > On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty > wrote: > > Greetings, > > A trivial fix to make the validate-header Tier1 task happy. > > Here's the context diff: > > $ hg diff -r qparent > diff -r c5202ed40b86 test/lib/j

Re: RFR: 8249264: Build validate-headers task fails after JDK-8248261

LGTM — Igor > On Jul 13, 2020, at 5:35 PM, alexander.matv...@oracle.com wrote: > > Please review the jpackage fix for bug [1] at [2]. > > Added missing ",". > > [1] https://bugs.openjdk.java.net/browse/JDK-8249264 > [2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/ > > Thanks, > Al

[15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/ > 7 lines changed: 4 ins; 0 del; 3 mod; Hi all, could you please review this small and trivial patch for java/lang/invoke/RicochetTest.java test? from JBS: > a run of java/lang/invoke/RicochetTest.java w/ MAX_ARITY=255 was removed from >

[15] RFR(T) : 8249698 : java/lang/invoke/LFCaching/LFGarbageCollectedTest.java should be ProblemList-ed and not @ignored

http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00 > 3 lines changed: 1 ins; 1 del; 1 mod; Hi all, could you please review this trivial patch which removes @ignore from LFGarbageCollectedTest and adds it into problem-list instead? from 8249698: > java/lang/invoke/LFCaching/LFGarbageColl

[15] RFR(S) : 8249700 : java/io/File/GetXSpace.java should be added to exclude list, and not @ignore-d

http://cr.openjdk.java.net/~iignatyev//8249700/webrev.01/ > 9 lines changed: 1 ins; 1 del; 7 mod Hi all, could you please review this small patch which removes @ignore from java/io/File/GetXSpace.java and instead adds an entry to ProblemList.txt? from JBS: > java/io/File/GetXSpace.java is curre

Re: [15] RFR(T) : 8249698 : java/lang/invoke/LFCaching/LFGarbageCollectedTest.java should be ProblemList-ed and not @ignored

Mandy, Vladimir, thanks for your reviews, pushed to jdk15. -- Igor > On Jul 18, 2020, at 9:33 PM, Mandy Chung wrote: > > +1 > > Mandy > > On 7/17/20 8:57 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00 >> <http://cr.

Re: [15] RFR(S) : 8249700 : java/io/File/GetXSpace.java should be added to exclude list, and not @ignore-d

Hi Alan, thanks for the review, pushed to jdk15. -- Igor > On Jul 19, 2020, at 8:18 AM, Alan Bateman wrote: > > On 19/07/2020 05:28, Igor Ignatyev wrote: >> : >> the patch also includes minimal changes to make the test runnable on macosx, >> which reveled that t

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

sses w/ Xcomp and - -XX:+TieredCompilation (c1 + c2); - -XX:-TieredCompilation (c2-only); - -XX:+NeverActAsServerClassMachine (emulated-client, c1-only) the test was run 100 times on {linux,windows,macos}-x64 w/ 0 failures. Thanks, -- Igor > On Jul 18, 2020, at 9:32 PM, Mandy Chung wrote: > &

[15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 > 98 lines changed: 18 ins; 31 del; 49 mod; Hi all, could you please review this small fix to make java/io/File/GetXSpace.java work again on windows? the test has been updated to work under cygwin, which includes the following changes:

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

tions and reduce > MAX_ARITY from 50 to 10. > > This issue is not critical to target for 15. It may worth considering target > this test fix for 16. Just a suggestion. > > Mandy > > On 7/20/20 10:13 AM, Igor Ignatyev wrote: >> Hi Mandy, >> >> that

Re: RFR (trivial) 8249940: Remove unnecessary includes of jni_util.h in native tests

Hi David, looks good to me. -- Igor > On Jul 22, 2020, at 4:00 PM, David Holmes wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8249940 > webrev: http://cr.openjdk.java.net/~dholmes/8249940/webrev/ > > A number of native tests in hotspot and jdk include the jni_util.h header > file

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

ping? -- Igor > On Jul 20, 2020, at 11:28 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 >> 98 lines changed: 18 ins; 31 del; 49 mod; > > Hi all, > > could you please review this small fix to make java/io/File/GetXSpace.ja

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

t; > This test looks all right to me. > > Sorry for the late review. > > Thanks, > > Brian > >> On Jul 20, 2020, at 11:28 AM, Igor Ignatyev > <mailto:igor.ignat...@oracle.com>> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//6501010/

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

= 751619276800 free = 95019069440 usable = 95019069440 > ... > -- > > > The drives K: and O: are mapped network drives. > Do you see something similar in your landscape? Can you perhaps try to > reproduce this? > > Best regards,

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:05:48 GMT, Daniel D. Daugherty wrote: > 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on > linux-aarch64 Marked as reviewed by iignatyev (Reviewer). test/jdk/ProblemList.txt line 859: > 857: tools/jlink/JLinkReproducibleTest.java

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64

On Mon, 28 Sep 2020 16:16:52 GMT, Igor Ignatyev wrote: >> 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on >> linux-aarch64 > > test/jdk/ProblemList.txt line 859: > >> 857: tools/jlink/JLinkReproducibleTest.java 8217166 &

Re: RFR: 8253667: ProblemList tools/jlink/JLinkReproducible{, 3}Test.java on linux-aarch64 [v2]

On Mon, 28 Sep 2020 16:32:52 GMT, Daniel D. Daugherty wrote: >> 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on >> linux-aarch64 > > Daniel D. Daugherty has updated the pull request incrementally with one > additional commit since the last revision: > > Update existing en

Re: RFR: 8238263: Create at-requires mechanism for containers

On Fri, 23 Oct 2020 18:44:54 GMT, Harold Seigel wrote: > Please review this change to add an @requires mechanism called > "jdk.containerized" to help mark tests that are incompatible with containers. > Users would add "@requires jdk.containerized != true" to the incompatible > tests and then

Re: RFR: 8238263: Create at-requires mechanism for containers

On Fri, 23 Oct 2020 19:25:27 GMT, Harold Seigel wrote: > I think it depends on whether the tests will be permanently or temporarily > excluded from running with containers. I thought this mechanism would be to > permanently exclude the tests. That's why I used `@requires`. I see, if this is fo

Re: RFR: 8238263: Create at-requires mechanism for containers

On Fri, 23 Oct 2020 19:54:40 GMT, Igor Ignatyev wrote: >> Hi Igor, >> I think it depends on whether the tests will be permanently or temporarily >> excluded from running with containers. I thought this mechanism would be to >> permanently exclude the tests. Tha

Re: RFR: 8238263: Create at-requires mechanism for containers

On Mon, 26 Oct 2020 13:49:26 GMT, Harold Seigel wrote: > Defining an environment variable works when running JTReg from the command > line. But, mach5 does not pass environment variable settings to its JTReg > test runs. Some mach5 special command args would still be needed. right, yet given y

Re: RFR: 8238263: Create at-requires mechanism for containers [v2]

On Mon, 26 Oct 2020 18:13:29 GMT, Harold Seigel wrote: >> Please review this change to add an @requires mechanism called >> "jdk.containerized" to help mark tests that are incompatible with >> containers. Users would add "@requires jdk.containerized != true" to the >> incompatible tests and t

Re: RFR: 8255964: Add jcmd Thread.print to jtreg timeout handler

On Thu, 5 Nov 2020 17:09:58 GMT, Nils Eliasson wrote: > This patch adds jcmd Thread.print to the jtreg timeout handler. > > Please review. Hi Nils, It looks alright, but could you please elaborate on why we need it when there is already `jstack` action? — Igor - PR: https://git

Re: RFR: 8255964: Add all details to jstack log in jtreg timeout handler [v2]

On Fri, 6 Nov 2020 20:25:13 GMT, Nils Eliasson wrote: >> This patch adds jcmd Thread.print to the jtreg timeout handler. >> >> Please review. > > Nils Eliasson has updated the pull request incrementally with one additional > commit since the last revision: > > add extended printing to jstack

Re: RFR: 8256244: java/lang/ProcessHandle/PermissionTest.java fails with TestNG 7.1

On Thu, 12 Nov 2020 15:48:33 GMT, Roger Riggs wrote: > TestNG 7.1 changed/corrected the way that @BeforeGroups are selected at > runtime. > The test was depending on @BeforeGroups to initialize common security policy > for a number of tests. > The tests are modified to individually setup the ne

Re: RFR (XS): 8225305: ProblemList java/lang/invoke/VarHandles tests

Hi Mikael, as it looks like 8222445 isn't going to be fixed for a long time (as it's "targeted" to tbd), and the defect seems to affect only AOT run, I don't think it's a good idea to put these tests into a general problem list. I'd suggest to either create aot-specific problem list or put them

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi Severin, I don't think that tests (or test libraries for that matter) should be responsible for setting correct PATH value, it should be a part of host configuration procedure (tests can/should check that all required bins are available though). in other words, I'd prefer if you remove 'env.

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

ns? > > > Thank you, > > Misha > > On 7/16/19 11:49 AM, Igor Ignatyev wrote: >> Hi Severin, >> >> I don't think that tests (or test libraries for that matter) should be >> responsible for setting correct PATH value, it should be a part of host

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

...@oracle.com> wrote: >> Hi Severin, >> >> On 7/17/19 5:44 AM, Severin Gehwolf wrote: >>> Hi Igor, Misha, >>> >>> On Tue, 2019-07-16 at 11:49 -0700, Igor Ignatyev wrote: >>>> Hi Severin, >>>> >>>> I don't thin

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

> On Jul 18, 2019, at 8:14 AM, Severin Gehwolf wrote: > >> should we rename docker.support and DOCKER_COMMAND to something more >> abstract? > > container.support and CONTAINER_ENGINE_COMMAND perhaps? sounds good to me, but as Misha suggested (and I originally intended to write), let's do

Re: RFR: 8228434: jdk/net/Sockets/Test.java fails after JDK-8227642

haven't we identified and *fixed* all the tests which use j.t.l.Platform class and their own security policy (as part of 8210039 or other testlibrary refactoring)? in other words, all the tests which use j.t.l.Platform must have a policy file which grants Platform java.util.PropertyPermission re

Re: RFR: 8228434: jdk/net/Sockets/Test.java fails after JDK-8227642

> On Jul 19, 2019, at 12:44 PM, Alan Bateman wrote: > > On 19/07/2019 18:59, Igor Ignatyev wrote: >> haven't we identified and *fixed* all the tests which use j.t.l.Platform >> class and their own security policy (as part of 8210039 or other testlibrary >> r

Re: RFR: 8234964: failure_handler: gather more environment information on Windows, Solaris and Linux

Hi Julia, looks good to me. to make it more consistent w/ other tools, I'd move all ifconfig (incl. one on macOS) to 'net' category, i.e. rename them to net.ifconfig, this will require also moving all netstat.* on macOS and solaris to 'net' as well. I don't insist on it, though. -- Igor >

Re: RFR: 8234964: failure_handler: gather more environment information on Windows, Solaris and Linux

> On Dec 2, 2019, at 2:54 AM, Julia Boes wrote: > > Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234964/webrev.01/ > LGTM -- Igor

Re: RFR: JDK-8235453: tools/jpackage/junit/junit.java failed due to "module not found: jdk.incubator.jpackage"

can we just add '@modules jdk.incubator.jpackage' to test/jdk/tools/jpackage/junit/junit.java to solve that? or some of the tests run by test/jdk/tools/jpackage/junit/junit.java don't need jdk.incubator.jpackage module? -- Igor > On Dec 7, 2019, at 11:57 AM, Philip Race wrote: > > Yes, since

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? -- Igor > On Dec 11, 2019, at 1:00 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK

[14] RFR(S/T) : 8235866 : bump jtreg requiredVersion to 4.2b16

http://cr.openjdk.java.net/~iignatyev//8235866/webrev.00 > 5 lines changed: 0 ins; 0 del; 5 mod Hi all, could you please review this small patch which updates TEST.ROOT in all test suites to require jtreg4.2b16? 8230067[1] updated profiles to use jtreg4.2b16, but didn't update TEST.ROOT files.

Re: [14] RFR(S/T) : 8235866 : bump jtreg requiredVersion to 4.2b16

> On Dec 12, 2019, at 10:21 PM, David Holmes wrote: > > Hi Igor, > > On 13/12/2019 3:19 pm, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8235866/webrev.00 >>> 5 lines changed: 0 ins; 0 del; 5 mod >> Hi all, >> could you please revie

Re: [14] RFR(S/T) : 8235866 : bump jtreg requiredVersion to 4.2b16

Hi Kumar, I haven't heard adoptopenjdk people bringing it up. I agree w/ your hypothesis, this job started to fail after https://hg.openjdk.java.net/code-tools/jtreg/rev/deee95d5d8ff which checks that '.hg' directory exists in the

Re: [14] RFR(S/T) : 8235866 : bump jtreg requiredVersion to 4.2b16

thanks for confirming that Joe. -- Igor > On Dec 16, 2019, at 9:54 AM, Joe Wang wrote: > > > > On 12/12/19 10:46 PM, Igor Ignatyev wrote: >> @Joe/Lance, >> were there any reasons why you needed to switch jtreg's requiredVersion back >> to 4.2b13 in jax

RFR(S): 8236111 : narrow allowSmartActionArgs disabling

http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/ > 31 lines changed: 20 ins; 11 del; 0 mod; Hi all, could you please review this small patch which enables allowSmartActionArgs in hotspot and jdk test suites and disables them in a small number of test directories? the patch also removes

Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

ping? > On Dec 17, 2019, at 11:30 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/ >> 31 lines changed: 20 ins; 11 del; 0 mod; > > Hi all, > > could you please review this small patch which enables allowSmartActionArgs >

Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

Thanks David. core-libs folks, could you please review jdk part of this patch? Thanks, -- Igor > On Dec 23, 2019, at 1:33 PM, David Holmes wrote: > > Hi Igor, > > Hotspot changes seem fine. Can't comment on jdk tests. > > Thanks, > David > > On 24/1

Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

removal of the existing TEST.properties files look fine. > > Please also solicit feedback from the security libs team as their area is > affected. > > Roger, FYI the serial filter tests are updated as part of this changeset. > > Cheers, > > -Joe > > On 12/23/2019 8

RFR(S) : 8238943: switch to jtreg 5.0

http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00 > 10 lines changed: 1 ins; 0 del; 9 mod; Hi all, could you please review the patch which changes jtreg version used in jdk/jdk to the latest and greatest -- jtreg 5.0? and as (recently became) usually, this patch also bumps requiredVersio

Re: RFR(XS): 8174768: Make ProcessTools print executed process output into a separate file

Hi Evgeny, (widening the audience, given this affects not just hotspot compiler, but hotspot tests as well as core libs tests in general) overall that looks good to me. one suggestion, for the ease of failure analysis it might be worth to print out the names of created files, although this migh

Re: RFR 15 8242462: Residual Cleanup of rmic removal

Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm not sure who are the right people to review bin/unshuffle_list.txt though,.. build team (

Re: RFR: 8256894: define test groups

On Wed, 25 Nov 2020 20:31:50 GMT, Ivan Šipka wrote: >> test/jdk/TEST.groups line 327: >> >>> 325: :core_tools \ >>> 326: :jdk_other \ >>> 327: :jdk_core_manual >> >> Please don't add manual tests to jdk_core. > > Removed. aren't they already a part of `jdk_core` test group? e.g. `

Re: RFR: 8256894: define test groups

On Tue, 24 Nov 2020 16:13:59 GMT, Ivan Šipka wrote: > Defined new test groups as defined in ticket. @fguallini @frkator, you will need to open a new JBS ticket for this change. test/jdk/TEST.groups line 326: > 324: :jdk_text \ > 325: :core_tools \ > 326: :jdk_other it would seem

Re: RFR: JDK-8249836 java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore

On Fri, 27 Nov 2020 16:11:54 GMT, Mahendra Chhipa wrote: > …id as 1st word in @ignore > > https://bugs.openjdk.java.net/browse/JDK-8249836 LGTM - Marked as reviewed by iignatyev (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1482

Re: RFR: 8166026: refactor shell tests to java

On Fri, 27 Nov 2020 18:50:19 GMT, Ivan Šipka wrote: > @iignatev could you please review? Thank you. > > note to self: > jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java > test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java > test/jdk/java/lang/Thread/

Re: RFR: 8256894: define test groups [v2]

On Mon, 30 Nov 2020 21:10:13 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8257516: removing trailing space > > @frkator, you will need to open a new JBS ticket fo

Re: RFR: 8257516: define test group for manual tests [v3]

On Thu, 3 Dec 2020 22:54:13 GMT, Ivan Šipka wrote: >> Defined new test groups as defined in ticket. @fguallini > > Ivan Šipka has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content

Re: RFR: 8166026: Refactor java/lang shell tests to java [v3]

On Wed, 9 Dec 2020 15:19:58 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell tests

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v3]

On Tue, 5 Jan 2021 20:58:37 GMT, Ivan Šipka wrote: >> test/jdk/java/lang/annotation/LoaderLeakTest.java line 54: >> >>> 52: List classes = List.of("A.class", "B.class", "C.class"); >>> 53: for (String fileName : classes) { >>> 54: Files.move( >> >> I don't think it's

Re: RFR: 8259268: Refactor InheritIO shell test as java test [v3]

On Thu, 3 Dec 2020 19:46:14 GMT, Ivan Šipka wrote: >> @iignatev could you please review? Thank you. >> >> note to self: >> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java >> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >> test/jdk/java/lang/Th

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v5]

On Mon, 8 Feb 2021 20:12:03 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains four commits: > > - 8166026:

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v3]

On Fri, 11 Dec 2020 13:39:04 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8166026: Refactor java/lang shell tests to java > > test/jdk/java/lang/annotation/LoaderL

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v8]

On Mon, 22 Feb 2021 15:33:30 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8166026: Refactor java/lang shell tests to java > > test/jdk/java/lang/annotation/LoaderL

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v8]

On Mon, 22 Feb 2021 15:24:19 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell test

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v14]

On Wed, 3 Mar 2021 15:55:03 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell tests

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v15]

On Wed, 3 Mar 2021 19:56:07 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell tests

RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

Hi all, could you please review the patch which moves `ClassFileInstaller` class to `jdk.test.lib.helpers` package? to reduce changes in the tests, `ClassFileInstaller` in the default package is kept w/ just `main` method that calls `jdk.test.lib.helpers. ClassFileInstaller::main`. from JBS

Integrated: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review the patch which moves `ClassFileInstaller` class to > `jdk.test.lib.helpers` package? > to reduce changes in the tests, `ClassFileInstaller` in the default package > is kept w/

Re: RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Fri, 12 Mar 2021 02:08:09 GMT, Mikhailo Seledtsov wrote: >> Hi all, >> >> could you please review the patch which moves `ClassFileInstaller` class to >> `jdk.test.lib.helpers` package? >> to reduce changes in the tests, `ClassFileInstaller` in the default package >> is kept w/ just `main`

RFR: 8263549: 8263412 can cause jtreg testlibrary split

Hi all, could you please review this dull patch that replaces `ClassFileInstaller` w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to ensure we won't get split testlibrary, and removes `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used). from J

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split

On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this dull patch that replaces `ClassFileInstaller` w/ > `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to > ensure we won't get split testlibrary, and

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v2]

ssFileInstaller` is nowhere to be found, hence we >> get NCDFE. > > testing: > - [x] `grep ' ClassFileInstaller[^.]` > - [ ] tier1-3 > > Thanks, > -- Igor Igor Ignatyev has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

ssFileInstaller` is nowhere to be found, hence we >> get NCDFE. > > testing: > - [x] `grep ' ClassFileInstaller[^.]` > - [ ] tier1-3 > > Thanks, > -- Igor Igor Ignatyev has refreshed the contents of this pull request, and previous commits have been removed. The

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote: >> Igor Ignatyev has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains

Integrated: 8263549: 8263412 can cause jtreg testlibrary split

On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this dull patch that replaces `ClassFileInstaller` w/ > `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to > ensure we won't get split testlibrary, and

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

On Sat, 13 Mar 2021 14:20:20 GMT, Daniel D. Daugherty wrote: >> Igor Ignatyev has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > I

RFR: 8263556: remove `@modules java.base` from tests

Hi all, could you please review this trivial cleanup? from JBS: > jtreg `@modules X` directive does two things: > - exclude a test from execution if JDK under test doesn't have module X > - if JDK under test has module X, make sure it's resolved > > both these things have no sense for `java

Re: RFR: 8263556: remove `@modules java.base` from tests

On Mon, 15 Mar 2021 16:25:48 GMT, Iris Clark wrote: >> Hi all, >> >> could you please review this trivial cleanup? >> from JBS: >> >>> jtreg `@modules X` directive does two things: >>> - exclude a test from execution if JDK under test doesn't have module X >>> - if JDK under test has module

Integrated: 8263556: remove `@modules java.base` from tests

On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this trivial cleanup? > from JBS: > >> jtreg `@modules X` directive does two things: >> - exclude a test from execution if JDK under test doesn't have module X >

  1   2   3   4   >