AW: [11u] java/nio/channels/AsynchronousFileChannel/Basic.java crashes on Windows x64

, Doerr, Martin Cc: Reka Kovacs , Aditya Mandaleeka , Monica Beckwith Betreff: RE: [11u] java/nio/channels/AsynchronousFileChannel/Basic.java crashes on Windows x64 Hi Martin, We haven’t encountered this yet, to my knowledge, but we’ll see if we can reproduce it during our next sprint

[11u] java/nio/channels/AsynchronousFileChannel/Basic.java crashes on Windows x64

Hi, we observe crashes in jdk 11.0.12 on Windows: https://bugs.openjdk.java.net/browse/JDK-8267440 I haven’t found any backport which looks like obviously causing it. We had different theories which include: * Antivirus tool which keeps the test file open. * Error in handling of

RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection

Hi Götz, thanks for the review! Best regards, Martin From: Lindenmaier, Goetz Sent: Montag, 25. Januar 2021 10:49 To: Doerr, Martin ; core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph Subject: RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress

[11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection

Hi, JDK-7146776 is backported to 11.0.11-oracle. I'd like to backport it for parity. Change doesn't apply cleanly because of Copyright year changes and a minor difference in a hunk which gets removed by this change: 11u Code contains host.equals(""), patch wants to remove host.isEmpty() from

RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module

Hi Götz, thanks for the review! Best regards, Martin From: Lindenmaier, Goetz Sent: Dienstag, 22. Dezember 2020 13:02 To: Doerr, Martin ; core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph Subject: RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE

[11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module

Hi, JDK-8248901 is backported to 11.0.11-oracle. I'd like to backport it for parity. Change applies cleanly, but 11u needs minor adaptation: - Keep "import java.util.Iterator;" in Module.java. - "toModuleInfo" has one argument less in 11u, so pass one "null" less. Bug:

RE: [11u] RFR: 8235351: Lookup::unreflect should bind with the original caller independent of Method's accessible flag

Hi Götz, thanks for the review! Best regards, Martin From: Lindenmaier, Goetz Sent: Montag, 21. Dezember 2020 14:44 To: Doerr, Martin ; core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph Subject: RE: [11u] RFR: 8235351: Lookup::unreflect should bind with the original

[11u] RFR: 8235351: Lookup::unreflect should bind with the original caller independent of Method's accessible flag

Hi, JDK-8235351 is backported to 11.0.11-oracle. I'd like to backport it for parity. Change doesn't apply cleanly, because https://bugs.openjdk.java.net/browse/JDK-8233527 is not in 11u (jdk14 uses hasFullPrivilegeAccess(), but older versions use hasPrivateAccess()). Bug:

RE: [11u] RFR: 8211825: ModuleLayer.defineModulesWithXXX does not setup delegation when module reads automatic module

Hi Christoph, thanks for the review! Best regards, Martin > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 17. Dezember 2020 14:45 > To: Doerr, Martin ; core-libs-dev d...@openjdk.java.net>; jdk-updates-...@openjdk.java.net > Subject: RE:

[11u] RFR: 8211825: ModuleLayer.defineModulesWithXXX does not setup delegation when module reads automatic module

Hi, JDK-8211825 is backported to 11.0.11-oracle. I'd like to backport it for parity. The original change applies cleanly, by javac from 11u has a problem with the new AutomaticModulesTest: AutomaticModulesTest.java:70: error: reference to createJarFile is ambiguous

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

rds, Martin > -Original Message- > From: Corey Ashford > Sent: Dienstag, 1. September 2020 02:17 > To: Doerr, Martin > Cc: Michihiro Horie ; hotspot-compiler- > d...@openjdk.java.net; core-libs-dev ; > Kazunori Ogata ; jos...@br.ibm.com > Subject: Re: R

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

inexperienced in > writing openjdk code, so your patience and careful review is really > appreciated. I'm glad you work on contributions. I think we should welcome new contributors and assist as far as we can. Best regards, Martin > -----Original Message- > From: Corey Ashford > S

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

s to return the dp value matching the number of Bytes written. Best regards, Martin > -Original Message- > From: Doerr, Martin > Sent: Dienstag, 25. August 2020 15:38 > To: Corey Ashford ; Michihiro Horie > > Cc: hotspot-compiler-...@openjdk.java.net; core-libs-dev d

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

t regards, Martin > -Original Message- > From: Corey Ashford > Sent: Mittwoch, 19. August 2020 20:11 > To: Michihiro Horie > Cc: hotspot-compiler-...@openjdk.java.net; core-libs-dev d...@openjdk.java.net>; Kazunori Ogata ; > jos...@br.ibm.com; Doerr, Martin >

RE: RFR [XXS] : 8244183: linker error jpackageapplauncher on Windows 32bit

+1 Best regards, Martin From: Alexey Semenyuk Sent: Donnerstag, 30. April 2020 18:29 To: Baesken, Matthias ; core-libs-dev Cc: Doerr, Martin Subject: Re: RFR [XXS] : 8244183: linker error jpackageapplauncher on Windows 32bit Looks good assuming the patch was tested with 64bit build

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

rtin > -Original Message- > From: Alan Bateman > Sent: Dienstag, 24. März 2020 10:53 > To: Langer, Christoph ; Doerr, Martin > ; core-libs-dev@openjdk.java.net; jdk-updates- > d...@openjdk.java.net > Subject: Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: &g

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

Hi Paul, thanks for the review. We had already asked, but this one can't get opened up. I would have preferred a normal backport, too. Best regards, Martin > -Original Message- > From: Hohensee, Paul > Sent: Montag, 23. März 2020 19:29 > To: Doerr, Martin ; co

[11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

Hi, I'd like to backport JDK-8223326 from jdk/jdk. 11u backport issue: https://bugs.openjdk.java.net/browse/JDK-8241460 Original change: https://hg.openjdk.java.net/jdk/jdk/rev/29624901d8bc 11u backport webrev: http://cr.openjdk.java.net/~mdoerr/8223326_nio_socket_11u/webrev.00/ I had to

RE: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

, Martin From: Thomas Stüfe Sent: Montag, 24. Februar 2020 12:52 To: Doerr, Martin Cc: core-libs-dev@openjdk.java.net; Lindenmaier, Goetz ; Langer, Christoph Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element Hi Martin, maybe use ATTRIBUTE_ALIGNED instead

RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi, we had fixed stack array alignment for Windows 32 bit with JDK-8220348. However, there are also stack allocated jlong and jdouble used as source for SetLongArrayRegion and SetDoubleArrayRegion with insufficient alignment for this platform. Here’s my proposed fix:

RE: RFR(S): 8220348: [ntintel] asserts about copying unalinged array

is the only affected platform, I prefer not to touch other ones. Are you ok with webrev.00 as it is? Best regards, Martin From: Langer, Christoph Sent: Donnerstag, 5. Dezember 2019 12:16 To: Doerr, Martin Cc: core-libs-dev@openjdk.java.net; security-dev ; Lindenmaier, Goetz ; Thomas Stüfe Subject

RE: RFR(S): 8220348: [ntintel] asserts about copying unalinged array

: Thomas Stüfe Sent: Mittwoch, 4. Dezember 2019 17:56 To: Doerr, Martin Cc: core-libs-dev@openjdk.java.net; security-dev ; Lindenmaier, Goetz Subject: Re: RFR(S): 8220348: [ntintel] asserts about copying unalinged array Hi Martin, this makes sense. This is the right way to force alignment. I do

RFR(S): 8220348: [ntintel] asserts about copying unalinged array

Hi, I'd like to propose a fix for an old issue on 32 bit Windows (also for an 11u backport): https://bugs.openjdk.java.net/browse/JDK-8220348 Some jdk native methods use jni_SetLongArrayRegion with a stack allocated buffer. jni_SetLongArrayRegion uses Copy::conjoint_jlongs_atomic which

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

Hi Matthias and Erik, I also think this is an interesting option. I like the idea to generate smaller libraries. In addition to that, I could also imagine building with -Os (size optimized) by default and only select -O3 for performance critical files (e.g. C2's register allocation, some gc

RE: RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings

Hi Matthias, I wouldn’t say „looks good”, but I think it’s the right thing to do  The type casts look correct to fit to the AIX headers. libodm_aix: Good. Maybe we should open a new issue for freeing what’s returned by odm_set_path and we could also remove the AIX 5 support.

RE: [11u] RFR (Backport): 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, backport looks good. Best regards, Martin > -Original Message- > From: jdk-updates-dev On > Behalf Of Langer, Christoph > Sent: Freitag, 24. Mai 2019 09:52 > To: jdk-updates-...@openjdk.java.net > Cc: core-libs-dev > Subject: [11u] RFR (Backport): 8223553: Fix code

RE: RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

: Gustavo Romero Sent: Mittwoch, 12. Dezember 2018 03:08 To: Michihiro Horie Cc: core-libs-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; Doerr, Martin ; Roger Riggs ; Vladimir Kozlov ; Simonis, Volker Subject: Re: RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase

RE: RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

regards, Martin -Original Message- From: Vladimir Kozlov Sent: Montag, 10. Dezember 2018 20:33 To: Michihiro Horie ; Gustavo Romero Cc: core-libs-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; Doerr, Martin ; Roger Riggs ; Simonis, Volker Subject: Re: RFR: 8213754

RE: [XS] RFR : JDK-8181145 : add platforms to test java/nio/ByteOrder/NativeOrder.java (test change)

lker.simo...@sap.com>; Schmidt, Lutz <lutz.schm...@sap.com>; Doerr, Martin <martin.do...@sap.com> Subject: Re: [XS] RFR : JDK-8181145 : add platforms to test java/nio/ByteOrder/NativeOrder.java (test change) Looks good to me! On Fri, May 26, 2017 at 7:43 AM, Baesken, Matthias &

RE: RFR(s) 8170153: PPC64: Poor StrictMath performance due to non-optimized compilation

Hi Gustavo, thanks for providing the webrevs. I have ran the StrictMath jck tests which fail when building with -O3 and without -ffp-contract=off: FailedTests: api/java_lang/StrictMath/desc.html#acos javasoft.sqe.tests.api.java.lang.StrictMath.acos_test api/java_lang/StrictMath/desc.html#asin