Re: JDK 16 RFR of JDK-8250237: Address use of default constructors in the javax.script package

+1 Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jul 23, 2020, at 5:24 PM, Joe Darcy wrote: > > Hello, > > One class in the javax.script packa

Re: RFR 8250235: java/lang/invoke/lambda/LambdaFileEncodingSerialization.java should be on the problem list

+1 Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jul 23, 2020, at 4:28 PM, Roger Riggs wrote: > > Please review adding an intermittent test to

Re: RFR: [15,docs] JDK-8247959,doclint errors in NIO code

+1 Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jun 19, 2020, at 11:36 PM, Jonathan Gibbons > wrote: > > Please review some fixes to address

Re: RFR: [15, docs] JDK-8247899, HTML errors and warnings in threadPrimitiveDeprecation.html

Looks reasonable Jon Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jun 18, 2020, at 8:19 PM, Jonathan Gibbons > wrote: > > Please review this

Re: RFR [15,docs] JDK-8247880,bad HTML(href==...) in table

Looks good Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jun 18, 2020, at 6:40 PM, Jonathan Gibbons > wrote: > > Please review a trivial docs

Re: RFR: 8244855 : Remove unused "getParent" function from Windows jni_util_md.c

+1 Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On May 12, 2020, at 3:05 PM, Brent Christian > wrote: > > Hi, > > Please review this change to

Re: RFR: 8237508: Simplify JarFile.isInitializing

Looks good Claes Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jan 20, 2020, at 7:12 AM, Claes Redestad wrote: > > Makes sense to keep even tri

Re: 8237186: Fix typo in copyright header of java/io/Reader/TransferTo.java

Looks ok Brian Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jan 14, 2020, at 8:51 PM, Brian Burkhalter > wrote: > > Oops: correction. > > -

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

Hi joe Looks fine Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 21, 2017, at 6:48 PM, Joe Wang wrote: > > Hi Lance, > > Thanks for the review

Re: RFR: 8189331 [testbug] java/io/Serializable/maskSyntheticModifier/MaskSyntheticModifierTest.java failed incorrect serialVersionUID

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 30, 2017, at 10:20 AM, Roger Riggs wrote: > > Please review a test fix to copy the golden Foo.class into t

Re: Review Request JDK-8176333: jdeps error message should include a proper MR jar file name

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 7, 2017, at 8:45 PM, Mandy Chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8176333/webrev

Re: RFR(xs): 8168096: markup error in "since" element spec of @Deprecated

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Oct 17, 2016, at 7:20 PM, Stuart Marks wrote: > > Hi all, please review this tiny fix to the javadoc markup in

Re: JDK 9 RFR of JDK-8151798: Mark java/util/TimeZone/Bug6772689.java as intermittently failing and demote to tier2

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 14, 2016, at 5:51 AM, Amy Lu wrote: > > java/util/TimeZone/Bug6772689.java > > This test is known to fail

Re: RFR: JDK-8043329: Wrong variable used in java.util.Collections javadoc code

Looks ok Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 10, 2016, at 5:51 AM, Sergey Ustimenko wrote: > > Hi everyone! Could someone plaese review this tiny

Re: RFR (JAXP): 8072081 : Supplementary characters are rejected in comments

Hi joe, Looks ok. Assume the jck runs clean as well? Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 9, 2015, at 5:37 PM, huizhe wang wrote: > >

Re: RFR 8143015/9: 5 tests fail with error "Can't find source for class: java.util.stream.OpTestCase"

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 15, 2015, at 10:44 PM, Felix Yang wrote: > > Hi, >please review the following fix for 5 broken test ca

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi, Overall it looks ok, I would however suggest adding a couple of tests to the jdk that run with/out a security manager as a sanity check. Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.an

Re: 8142493: Utility methods to check indexes and ranges doesn't specify behavior when function produces null

Looks ok Paul Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 12, 2015, at 6:19 AM, Paul Sandoz wrote: > > Hi, > > Please review: > > > http

Re: RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

Hi Alexander Looks ok but you will need to make sure the jaxws changes get pushed to the standalone project as well Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent fr

Re: JDK 9 RFR of JDK-8130719: Fix reference problems in jax-ws javadoc

Hi joe Looks fine. I think we should get this in the jaxws workspace also Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jul 7, 2015, at 8:35 PM, jo

Re: JDK 9 RFR of 8098790: Improve cross references and wording in java.lang.reflect.AnnotatedFoo type

Looks fine Joe Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jun 15, 2015, at 8:12 PM, joe darcy wrote: > > Hello, > > Please review the small doc clarificat

Re: JDK 9 RFR of JDK-8086029: Fix doclint reference warnings in org.omg.CORBA

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jun 8, 2015, at 9:27 PM, joe darcy wrote: > > Hello, > > As an addendum to the fix-the-warnings JEP, please r

Re: JDK 9 RFR of JDK-8078136: Incorrect figure number in reference to Hacker's Delight book in Long.bitCount() method

Go for it joe😎 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On May 17, 2015, at 12:53 PM, joe darcy wrote: > > Hello, > > Please review this typo fix for > >

Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException

wrote: > > Thanks, Lance. My next stop is the CCC. :) > > -Brent > >> On 4/13/15 3:53 PM, Lance @ Oracle wrote: >> Hi Brent, >> >> This looks fine >> >> You might need to fast track a CCC request even though this is minor >> >> B

Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException

Hi Brent, This looks fine You might need to fast track a CCC request even though this is minor Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Apr 1

Re: RFR (XXS) : 8050123: Incorrect property name documented in CORBA InputStream API

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Apr 9, 2015, at 9:42 AM, Seán Coffey wrote: > > https://bugs.openjdk.java.net/browse/JDK-8050123 > > diff --g

Re: Review request for JDK-8051559: JAXP function dom tests conversion

Hi frank Can you forward the other review request as I think I thought they were the same and deleted it I will look at this again today Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander.

Re: JDK 9 RFR of JDK-8075565: Define @intermittent jtreg keyword and mark intermittently failing jdk tests

Hi joe, This looks fine based on your proposal. Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 19, 2015, at 8:12 PM, Joseph D. Darcy wrote: > >

Re: RFR: 8061293: Update javax/xml tests to remove references of jre dir

Looks fine frank Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 5, 2015, at 2:30 AM, Frank Yuan wrote: > > Hi All > > > > Would you like to review the co

Re: JDK 9 RFR of JDK-8073952: Spec of j.l.r.Method.toString/toGenericString need to be clarified

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Feb 26, 2015, at 8:28 PM, joe darcy wrote: > > Hello, > > Please review the small changes to address > >

Re: RFR: 8073394: Clock.systemUTC() should return a constant

Looks good Daniel. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Feb 24, 2015, at 5:59 AM, Daniel Fuchs wrote: > >> On 23/02/15 21:40, Stephen Colebourne wro

Re: Review request: 8073374: Re-examine jdk.xml.ws dependency on java.xml.ws SOAPNamespaceConstants

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Feb 19, 2015, at 1:24 PM, Mandy Chung wrote: > > This eliminates the dependency from jdk.xml.ws to > com.sun.x

Re: JDK 9 RFR of JDK-8071959: java.lang.Object uses implicit default constructor

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jan 29, 2015, at 7:02 PM, joe darcy wrote: > > Hello, > > Please review the patch below to fix > >JDK-80

Re: JDK 9 RFR of 6481080 : (ann) @Deprecated annotation has no effect on packages

Hi joe, The update is clear Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Jan 6, 2015, at 6:12 PM, joe darcy wrote: > > Hello, > > As part of cle

Re: RFR: JDK-8051563: Convert JAXP function tests in xslt components: : org.apache.qetest.dtm package, org.apache.qetest.trax package to openjdk

Hi Tristan, I will look at this but doubt I will get to this tomorrow Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 30, 2014, at 5:28 PM, Tri

Re: RFR: 8067377: My hobby: caning, then then canning, the the can-can

Good eyes Daniel! Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 13, 2014, at 7:27 AM, Daniel Fuchs wrote: > >> On 12/12/14 10:34 PM, Martin Buchholz wrote:

Re: RFR(xs): 8066633: Fix deprecation warnings in java.rmi module

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 11, 2014, at 8:56 PM, Stuart Marks wrote: > > Hi all, > > Please review this tiny fix to remove the sourc

Re: JDK 9 RFR of JDK-8066643: (zipfs) Suppress deprecation warnings in jdk.zipfs module

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 8, 2014, at 1:24 AM, joe darcy wrote: > > Hello, > > Please review the simple patch below to fix > >

Re: JDK 9 RFR of JDK-8066641: Suppress deprecation warnings in jdk.naming module

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 4, 2014, at 9:23 PM, joe darcy wrote: > > Hello, > > Please review the small fix below for > >JDK-80

Re: RFR 8066188: BaseRowSet default value for escape processing is not correct

Thank you Alan. Yes, the spec is silent on thread safety. Once I finish with adding tests, I will look to update the javadocs to clarify this. Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.

Re: RFR(s): 8056313: TEST_BUG: java/util/Timer/NameConstructors.java fails intermittently

Look fine Stuart Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 20, 2014, at 6:51 PM, Stuart Marks wrote: > > Hi all, > > Here's a small test c

Re: RFR (XS) 8065096: java.net.Authenticator.theAuthenticator should be properly synchronized

Looks fine aleksey Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 17, 2014, at 5:35 AM, Aleksey Shipilev > wrote: > > Hi, > > Please review and commit thi

Re: 8025690: Default FileHandler constructor doesn't throw NullPointerException if pattern is empty and count > 1

Hi Daniel, The revised changes look fine. Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Oct 1, 2014, at 6:00 AM, Daniel Fuchs wrote: > > Hi Lance

Re: RFR: 8054555, javadoc clean-up in java.sql, javax.sql.*

Hi joe, Thank you for the quick review. I will change those to {@code Inputstream} Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Aug 7, 2014, at 7

Re: RFR: 8037948: Improve documentation for org.w3c.dom package

Hi joe, Should be a comma at the end of line 8 before the and on line 9 Looks ok otherwise Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 30, 20

Re: RFR JDK-5077522 : Duration.compare incorrect for some values

Agree this is better and cleaner! Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 21, 2014, at 4:27 AM, Daniel Fuchs wrote: > Thanks Joe! > > This is much cle

Re: RFR: 8046389: Add missing @since tag under javax.sql.**

This is fine Henry Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 9, 2014, at 5:39 PM, Henry Jen wrote: > Hi, > > Please review a trivial webrev

Re: RFR: 8042789: org.omg.CORBA.ORBSingletonClass loading no longer uses context class loader

Hi Sean I think this makes sense and the change looks fine Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 6, 2014, at 1:22 PM, Seán Coffey wrote:

Re: 8043958: Remove unused com.sun.pept classes from jdk repository

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On May 26, 2014, at 7:11 AM, Alan Bateman wrote: > > As part of modularity motivated clean-up, I'd like to remov

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

x27;s >>> good to get these lint warnings fixed now since we are planning to do a >>> large scale fix later on. I also made a similar fix in >>> ElementSchemePointer.java. If you see anything else, then let me know. >>> >>> http://cr.openjdk.java.ne

Re: RFR: 8035284: (xs) Remove redundant null initialization

Looks fine mike Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 11, 2014, at 3:22 PM, Mike Duigou wrote: > Hello all; > > This is a simple cleanup changeset t

Re: RFR (JAXP): 8037259: Xerces Update: XPointer update

Overall it looks ok. I think you will get some unchecked warnings from com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java Any reason not to address this for your HashMap and ArrayList? Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java En

Re: JDK 9 RFR of JDK-8039864: Fix fallthrough lint warnings in other libs

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 10, 2014, at 1:02 AM, Joe Darcy wrote: > Hello, > > I've started looking at cleaning up the fallthrough lin

Re: [9] Review Request for 8039488: tidy warnings cleanup for javax.sql

I think this looks ok but a couple of suggestions src/share/classes/javax/sql/rowset/spi/package.html - The URL links at the bottom of the page need updated, please address them as part of this putback if possible src/share/classes/javax/sql/package.html - I would use ™ as part of the change

Re: [9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

note; the summaries were removed, please see the updated > webrev: > http://cr.openjdk.java.net/~yan/8039172/webrev.01/ > > Regards, > Alexander > > On 04.04.2014 15:16, Lance @ Oracle wrote: >> Looks ok but have one concern/question as to why you added the summary >

Re: [9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

Looks ok but have one concern/question as to why you added the summary attribute to the table tag as it has been deprecated and believe it is not supported in HTML 5. I would probably not include it Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java En

Re: [9] Review request for 8039041: tidy warnings cleanup for javax.naming

Looks fine Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 3, 2014, at 5:01 AM, alexander stepanov wrote: > Hello, > > Could you please review the fix for t

Re: JDK 9 RFR of JDK-8039038: Fix serial lint warnings in com.sun.jmx.snmp

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 2, 2014, at 2:39 AM, Joe Darcy wrote: > Hello, > > *fingers crossed* The patch below should be the last cha

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

With the change to stringbuilder I am ok with it Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Mar 26, 2014, at 1:44 PM, Aleksej Efimov wrote: > Lanc

Re: [9] Review Request for 8038493: tidy warnings cleanup for java.sql

Looks fine Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Mar 28, 2014, at 6:58 AM, alexander stepanov wrote: > Hello, > > Could you please review the fix for t

Re: JDK 9 RFR of JDK-8036744: Fix raw lint warnings in java.lang.reflect.WeakCache

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Mar 5, 2014, at 7:52 PM, Joe Darcy wrote: > Hello, > > Please review the simple patch below which resolves two

Re: RFR [8023022] Some more typos in javadoc

Looks fine Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Feb 16, 2014, at 2:07 PM, Ivan Gerasimov wrote: > Hello! > > It was reported that there is a typo in th

Re: A hole in the serialization spec

IMHO, I think that is a tall task. There is such a large base of code that uses it or java.sql.Date, that having warnings for deprecation will cause a lot of angst. That code is not going to migrate quickly, if at all to the new types. Best Lance Lance Andersen| Principal Member of Technica

Re: RFR (JAXP): 8033980 : Xerces Update: datatype XMLGregorianCalendarImpl and DurationImpl

Hi joe It looks like you changed the serialversionuid in Durationimpl, did it get changed incorrectly previously? Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On F

Re: Time to remove sun.misc.Service?

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Feb 11, 2014, at 6:19 AM, Alan Bateman wrote: > > It was never meant to be used by anything outside of the JDK

Re: JDK 9 RFR of JDK-8033527: Fix raw type lint warning in sun.nio.ch

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Feb 4, 2014, at 1:09 AM, Joe Darcy wrote: > Hello, > > Please review this small fix to address > >JDK-8033

Re: RFR java.time cleanup of javadoc and messages

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Feb 3, 2014, at 5:43 PM, roger riggs wrote: > Please review this group of java.time updates: > > 8032749

Re: RFR: (8031737) CHECK_NULL and CHECK_EXCEPTION macros cleanup

Looks fine Which releases are you think of including this in if any besides 9? Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Feb 1, 2014, at 1:03 PM, roger riggs

Re: RFR (JAXP): 8027359: XML parser returns incorrect parsing results

Looks ok joe Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 3, 2014, at 1:07 PM, huizhe wang wrote: > Hi, > > This is an issue with the XML 1.1 scanner. Any

Re: RFR: 8029236: Update copyright year to match last edit in jdk8 jaxp repository for 2013

Looks ok assuming they were all modified Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Dec 23, 2013, at 12:56 PM, huizhe wang wrote: > Update copyright date on

Re: Review Request for 8029216: (jdeps) Provide a specific option to report JDK internal APIs

+1 Mandy Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 26, 2013, at 6:59 PM, Mandy Chung wrote: > This is a simple patch that adds a new jdeps -jdkinternals

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 25, 2013, at 4:51 PM, huizhe wang wrote: > Hi, > > This is a patch to fix an error in StAX factories' newFa

Re: RFR: JDK-8028628 - java/nio/channels/FileChannel/Size.java failed once in the same binary run

Looks ok Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 19, 2013, at 6:57 PM, Dan Xu wrote: > Hi All, > > Please review the simple fix towards Size.java test

Re: RFR 8028092 Lint cleanup of java.time.format

Looks good roger Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 9, 2013, at 2:14 PM, roger riggs wrote: > Please review this lint cleanup in java.time.format

Re: JDK 8 RFR 8026832: Clean up straggling doclint warnings in java.math

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 17, 2013, at 6:00 PM, Brian Burkhalter wrote: > Please review … > > Issue:https://bugs.openjdk.java.ne

Re: RFR (JAXP): 8016500 : Unlocalized warnigs.

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 17, 2013, at 5:51 PM, huizhe wang wrote: > Hi, > > This is a fix to use the existing localized messages on

Re: JDK 8 code review request for JDK-8025913 - Rename jdk.Supported to jdk.Exported

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 4, 2013, at 2:43 AM, Joe Darcy wrote: > Hello, > > Per previous discussions on the mailing list, we've deci

Re: RFR: JDK-8025686 : (s) Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support

Looks ok to me as well Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Oct 1, 2013, at 5:32 AM, Chris Hegarty wrote: > The changes look ok to me Mike. Thanks, > >

Re: JDK 8 RFR java.nio doclint fixes

Looks fine joe Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jul 20, 2013, at 1:17 PM, Joe Darcy wrote: > Hello, > > Please review the latest batch of doclint f

Re: JDK 8 code review request for doclint issues in java.util.spi

Looks fine Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jul 1, 2013, at 4:35 PM, Joe Darcy wrote: > Hello, > > There are a few doclint issues to be fixed in ja

Re: JDK 8 code review request for doclint issues in java.lang.instrument

Looks good Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jul 1, 2013, at 2:24 PM, Joe Darcy wrote: > Hello, > > Yet another found of doclint fixes for review; t

Re: RFR (JAXP): 8012683 : Some ObjectFactory classes should be removed.

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On May 20, 2013, at 7:26 PM, huizhe wang wrote: > Hi, > > This is a quick fix to remove a copy of obsolete ObjectF

Re: RFEs implementing JEP 170

Yes I am away right now but will follow up when I am back mid next week Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On May 2, 2013, at 11:45 AM, Alan Ba

Re: RFR: 8006036, (process) cleanup code in java/lang/Runtime/exec/WinCommand.java

I can look to do this Monday for you for Sunday eve I am away from my primary system right now Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 5, 2013, at 5:29

Re: 8011373: Property java.runtime.profile should be removed (left-over code)

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 3, 2013, at 7:14 AM, Alan Bateman wrote: > > I need a reviewer for a trivial change to remove code that set

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Yes sorry if that was not clear but that is my plan with the ccc and javadoc update I will get the JBS entry and ccc submitted later today and make a few of the minor suggestions from ulf and push out the revised webrev later today or Tuesday Best Lance Lance Andersen| Principal Member of Te

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Yes I just noticed this The code was written before my time I will add them though Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 13, 2013, at 7:28 AM, Ulf Zi

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jan 13, 2013, at 5:56 AM, Ulf Zibis wrote: > Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle: >> Hi >> This i