I think this OK.
The comments with the o--o did not do much for me though and found them a bit
confusing but perhaps I need more coffee this morning ?
Also, not sure we need the @author tag but I think its usage varies in the
workspace
Best
Lance
On Mar 19, 2014, at 7:10 PM, David Li wrote:
>
On Mar 5, 2014, at 5:10 PM, huizhe wang wrote:
>
> On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote:
>> On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
>>
>>> nitpicking,
>>>
>>> (1) shouldn't the variable at #468 to be updated to "lch
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote:
> nitpicking,
>
> (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as
> well?
I would agree given you are now calling Character.toLowerCase
> (2) StringBuilder can be used to replace the StringBuffer in toString().
Agree
+1
On Feb 28, 2014, at 5:25 PM, roger riggs wrote:
> Please review this fix for a broken link in the javadoc.
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-link-broken-8035813/
>
> Thanks, Roger
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java En
Looks fine.
On Feb 28, 2014, at 5:11 PM, David Li wrote:
> Hi,
>
> This is an update from Xerces for a fixed encoding map entry in file
> EncodingMap.java. For details, please refer to:
> https://bugs.openjdk.java.net/browse/JDK-8035469
>
> Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/803
Looks Ok. Kind of surprised the tck tests have no assertion details in the
tests. Minor nit would have been nice to have even a minor comment for the new
method DateTimeFormatterBuilder though that seems to be the norm in some
scenarios for the smaller methods.
On Feb 28, 2014, at 4:48 PM, r
looks fine. Took me a moment to figure out the change but makes sense :-)
On Feb 28, 2014, at 4:45 PM, roger riggs wrote:
> Please review a typo correction in java.time.format.Parsed.
> The exception message is corrected.
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-parsed-typo-80351
Looks fine. assume the will be addressed as part of a full sweep
of javax/naming
On Feb 14, 2014, at 2:48 PM, Ivan Gerasimov wrote:
> Hello!
>
> May I please have a review of the fix?
>
> It's not meant to be a proof reading, I only fixed some obvious typos.
> Some of them were reported at th
Hi Mandy
This looks OK to me
On Feb 12, 2014, at 12:46 PM, Mandy Chung wrote:
> This patch cleans up a few trivial native warnings (mainly remove local
> unreferenced variable)
> https://bugs.openjdk.java.net/browse/JDK-8030010
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs
looks fine. getting rid of and , is something I guess we should
look to do throughout all of our code?
On Jan 31, 2014, at 1:33 PM, roger riggs wrote:
> Please review a typo and javadoc cleanup for java.util.Date
>
> webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/
>
+1
On Jan 24, 2014, at 3:31 PM, huizhe wang wrote:
> Hi,
>
> Please review a javadoc change to javax.xml.stream factories. This change
> makes it clear that the two args ServiceLoader#load method is used when the
> specified classLoader is not null.
>
> http://cr.openjdk.java.net/~joehw/jdk9/8
looks fine Roger as am sure this will make the doclint warnings less
On Jan 22, 2014, at 4:26 PM, roger riggs wrote:
> Please review this javadoc improvement to add @param tags to readObject
>
> Webrev:
>
> http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/
>
> Thanks, Roger
>
looks good Joe
On Jan 7, 2014, at 6:58 PM, Joe Darcy wrote:
> Hello,
>
> Please review the fix below to address
>
>JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}
>
> by a quick-and-dirty generification and deprecation of some very old classes
>
>http://cr.openjdk.ja
+1
On Jan 7, 2014, at 3:30 PM, Joe Darcy wrote:
> Hello,
>
> Please review another minor lint fix of a raw type issues in the core
> libraries:
>
>diff -r 2647b91dbc2a
> src/share/classes/java/lang/management/ManagementFactory.java
> --- a/src/share/classes/java/lang/management/ManagementF
ileSystemPreferences.java is that it retries if anything fails. So I don't
> touch L914 to keep its old logic un-changed. Please let me know if you have
> some good suggestions. Thanks!
>
> -Dan
>
>
> On 01/06/2014 02:35 PM, Lance Andersen - Oracle wrote:
>>
Dan,
Looks OK, but line 914 which you did not change, notice the comments not sure
if that is common in this code but seemed a bit off to me:
914 //// If at first, you don't succeed...
On Jan 6, 2014, at 5:29 PM, Dan Xu wrote:
> Hi All,
>
> Please review the simple fix for JNI
+1
On Jan 6, 2014, at 4:41 PM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below to add a @SuppressWarning("serial") to
> java.lang.Enum to resolve a lint warning in the core libraries.
>
> Thanks,
>
> -Joe
>
> --- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014
+1
On Jan 6, 2014, at 3:53 PM, Joe Darcy wrote:
> Hello,
>
> Please review the simple change to fix JDK-8027063
> SecurityManger.getClassContext returns a raw type, which changes a signature
> of a protected method in SecurityManger to remove a use of raw types in the
> core libraries:
>
> --
looks fine Roger
On Jan 6, 2014, at 2:09 PM, roger riggs wrote:
> Please review this minor specification correction to the
> java.time.Duration.toDays() and
> toHours() methods. Only the javadoc is corrected, no code or tests are
> affected.
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/web
e the section below deleted, perhaps the change did not get pushed
to where you generated the webrev from?
> and replaced "br/" to "br" for compliance with html 3.2
>
>
> On 12/05/2013 10:39 PM, Lance Andersen - Oracle wrote:
>> Hi Serge
>>
>>
>&
Joe,
I thought this looked OK also
On Dec 17, 2013, at 12:26 PM, huizhe wang wrote:
>
> On 12/17/2013 4:10 AM, Daniel Fuchs wrote:
>> Hi Joe,
>>
>> The fix looks good - though I wonder at whether incrementing
>> whiteSpaceLookup by a fix amount wouldn't be better than
>> doubling its length.
looks fine joe
On Dec 11, 2013, at 4:10 PM, huizhe wang wrote:
>
> On 12/11/2013 12:21 PM, Alan Bateman wrote:
>> On 11/12/2013 19:52, huizhe wang wrote:
>>> Hi,
>>>
>>> This is a quick documentation change to fix an error in
>>> javax.xml.stream.XMLOutputFactory:
>>>
>>> http://cr.openjdk.jav
Hi Serge
This looks OK.
For
--- old/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.587885460
+
+++ new/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.435885464
+
Please remove the following
Package Specification
• Specificat
looks OK
On Dec 3, 2013, at 8:40 PM, Stuart Marks wrote:
> Hi all,
>
> Please review the following small javadoc change. The StringJoiner doc for a
> couple methods uses "i.e." in the first sentence, which screws up the javadoc
> logic that pulls the first sentence into the Method Summary. This
Hi all
This is a review request for some minor javadoc clarifications for JDBC 4.2
based on some feedback that I received.
The webrev can be found http://cr.openjdk.java.net/~lancea/8029417/webrev.00
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java E
looks OK Joe
On Nov 26, 2013, at 5:27 PM, huizhe wang wrote:
>
> On 11/26/2013 1:59 PM, roger riggs wrote:
>> Hi,
>>
>> I looked at that twice also.java.time had a similar situation.
>>
>> To get to the TCCL you need to call ServiceLoader.load(type).
>>
>> The FactoryFinder:348 findService
looks fine
On Nov 19, 2013, at 5:24 PM, Stuart Marks wrote:
> Hi all,
>
> Please review this small fix for an intermittent timeout. Nothing seems to be
> going wrong except that if the machine running the test is exceptionally
> slow, spurious timeouts will occur. The solution is to raise the t
The changes seem OK. I did not run the tests though
On Nov 19, 2013, at 2:08 PM, Dan Xu wrote:
> Hi All,
>
> We have java/io/pathNames/GeneralWin32.java testcase to do the general
> exhaustive test of pathname handling on windows. I am adding a new test
> GeneralSolaris.java to test the pathna
looks fine joe
On Nov 13, 2013, at 3:02 PM, huizhe wang wrote:
> Hi,
>
> The issue is that the limits applied to each processing process rather than
> each file processing. This applies to not only StAX as reported, but also
> other parsers and validators. The fix is to add reset to XMLSecurity
+1
On Nov 12, 2013, at 2:29 PM, Mandy Chung wrote:
> This is a simple code deletion in sun.misc.JavaAWTAccess and its
> implementation class:
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/
>
> This patch removes the methods from sun.misc.JavaAWTAccess that are
The wording changes seem fine to me.
Thanks for the specdiff as it made it much easier to review
On Nov 12, 2013, at 11:43 AM, Stuart Marks wrote:
> Hi all,
>
> Here's an updated version of the String spec change. Changes from the
> previous version address comments made by Brent Christian an
Looks Ok Joe
On Nov 12, 2013, at 4:28 AM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below which would remove another batch of raw type
> javac lint warnings from the core libraries.
>
> No signatures of public or protected methods in the Java SE specification
> have been modified.
looks fine Joe
On Nov 8, 2013, at 2:40 PM, Joe Darcy wrote:
> Hello,
>
> Please review the simple patch below which addresses a handful of raw types
> lint warning in the core reflection implementation code.
>
> (If memory serves, this code dates back from a time during the development of
> JD
+1
On Nov 7, 2013, at 5:29 PM, roger riggs wrote:
> Please review this straightforward typo correction:
>
> Webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-doc-readlong-8024458/
>
> Thanks, Roger
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Enginee
+1
On Nov 7, 2013, at 4:59 PM, Mandy Chung wrote:
> This reverts
> com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl back to the
> previous serial version.
>
> diff --git
> a/src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java
>
> b/src/sh
Hi Joe,
I think this is all OK
Best
Lance
On Oct 30, 2013, at 11:40 AM, huizhe wang wrote:
>
> On 10/30/2013 2:58 AM, Daniel Fuchs wrote:
>> On 10/30/13 1:14 AM, huizhe wang wrote:
>>> I updated the webrev to also fix the error message that showed the
>>> actual number of attributes parsed rath
+1
On Oct 29, 2013, at 5:13 PM, huizhe wang wrote:
> A quick fix to add the missing braces and correct the misspellings.
>
> webrevs: http://cr.openjdk.java.net/~joehw/jdk8/8027484/webrev/
>
> The following is where the braces were missing, others were a global
> substitution of the misspelling
+1
On Oct 25, 2013, at 4:50 PM, Stuart Marks wrote:
> Hi all,
>
> Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs
> are:
>
> https://bugs.openjdk.java.net/browse/JDK-5063500
> https://bugs.openjdk.java.net/browse/JDK-7126305
> https://bugs.openjdk.java.net/browse/J
looks OK joe
On Oct 23, 2013, at 3:42 PM, huizhe wang wrote:
> Hi Daniel,
>
> Thanks for the review and the detailed list. I've updated the webrev:
>
> http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/
>
> Thanks,
> Joe
>
> On 10/23/2013 11:25 AM, Daniel Fuchs wrote:
>> Hi Joe,
>>
>> I b
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.734881244 -0400
+++ new/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.558891607 -0400
@@ -54,21 +54,21 @@
*
* Implementa
Hi all,
Need a reviewer for 8026812 which addresses the new doclint warnings.
Webrev is at: http://cr.openjdk.java.net/~lancea/8026812/webrev.00/
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lanc
+1
On Oct 16, 2013, at 2:53 PM, huizhe wang wrote:
> Hi,
>
> This is a conformance issue. The issue is that a JCK test fails since invalid
> URI such as "//" was not caught. The fix is to check and allow empty
> authority only if there's non empty path, query component or fragment
> identifier
+1
On Oct 17, 2013, at 1:15 PM, roger riggs wrote:
> Please review a couple of issues with javadoc in java.lang.invoke to cleanup
> javadoc warnings.
>
> https://bugs.openjdk.java.net/browse/JDK-8026183
> https://bugs.openjdk.java.net/browse/JDK-8015808
>
> Webrev:
> http://cr.openjdk.java.ne
l for
> that would restore the spacing.
>
> Roger
>
> On 10/16/2013 4:37 PM, Lance Andersen - Oracle wrote:
>> Hi Roger,
>>
>> I think what you have done is OK.
>>
>> I do have questions on should more be done in general so that we use
>>
Hi Roger,
I think what you have done is OK.
I do have questions on should more be done in general so that we use
(as I thought that was no required vs just a solo ?). As I started to look
through some of the JDBC warnings, I saw more tags that I thought should have
been reported by doclin
openjdk.java.net/~joehw/jdk8/8003262/webrev/
>
> Thanks,
> Joe
>
>
> On 10/9/2013 10:58 AM, Lance Andersen - Oracle wrote:
>> +1
>> On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
>>
>>> Hi,
>>>
>>> These resource bundles in JAXP we
+1
On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
> Hi,
>
> These resource bundles in JAXP were refactored due to request by WPTG. Now
> that the WPTG tool has been approved to support the original format, I'm
> reverting the previous change back to the original format:
>
> http://cr.openjdk.j
+1
On Oct 9, 2013, at 10:38 AM, roger riggs wrote:
> Ping... any Reviewer...
>
> Thanks
>
> On 10/4/2013 3:37 PM, roger riggs wrote:
>> Hi,
>>
>> Please review these small improvements in messages resulting from
>> parsing date and time errors and corresponding tests.
>>
>> Webrev:
>> http:/
+1
On Oct 9, 2013, at 10:36 AM, roger riggs wrote:
> Please Review a locale sensitive test correction:
>
> The API under test is based on Locale.getDefault(Locale.Category.FORMAT)
> and the test data should be using the same Locale.
> The failure was seen in locale: ar_EG with Locale.Category.FOR
+1
On Sep 30, 2013, at 1:23 PM, huizhe wang wrote:
> Aleksej,
>
> The change looks good.
>
> Thanks,
> Joe
>
> On 9/28/2013 7:54 AM, Aleksej Efimov wrote:
>> Joe,
>> Thank you for a suggestion. But I modified it a little bit:
>> public Node item(int index) {
>> if (m_iter != null)
On Sep 17, 2013, at 7:14 AM, Alan Bateman wrote:
> On 17/09/2013 11:55, Lance Andersen - Oracle wrote:
>> Hi Folks,
>>
>> Aleksey has been kind enough to review this change. Still need the blessing
>> of a reviewer to put this back...
>>
>> any takers
Hi Folks,
Aleksey has been kind enough to review this change. Still need the blessing of
a reviewer to put this back...
any takers :-)
Best
Lance
Begin forwarded message:
> From: Lance Andersen - Oracle
> Date: September 16, 2013 7:12:09 AM EDT
> To: Aleksey Shipilev
> Cc: c
Thanks for the input.
On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote:
> On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote:
>> I added a webrev
>> http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be
>> a bit easier for this review.
>
> Notes:
I added a webrev http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it
might be a bit easier for this review.
Best
lance
On Sep 13, 2013, at 4:40 PM, Lance Andersen - Oracle wrote:
> Hi Everyone,
>
> Looking for a reviewer for this trivial fix to correct the sample example
Hi Everyone,
Looking for a reviewer for this trivial fix to correct the sample example in
the Predicate javadoc for the evaluate method()
--
!hg
hg diff Predicate.java
diff -r 60d6f60416ca src/share/classes/javax/sql/rowset/Predicate.java
--- a/src/share/classes/javax/sql/rowse
Looking for a reviewer for this trivial fix:
hg diff PreparedStatement.java
diff -r 262a625809fd src/share/classes/java/sql/PreparedStatement.java
--- a/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 01:47:05
2013 -0700
+++ b/src/share/classes/java/sql/PreparedStatement.java Thu
Looking for a reviewer for this trivial change to clarify the long outstanding
behavior of registererDriver:
$ hg diff DriverManager.java
diff -r 262a625809fd src/share/classes/java/sql/DriverManager.java
--- a/src/share/classes/java/sql/DriverManager.java Thu Sep 12 01:47:05
2013 -0700
++
looks fine dan!
On Aug 23, 2013, at 1:26 PM, Daniel Fuchs wrote:
> On 8/23/13 5:50 PM, Mandy Chung wrote:
>> Hi Daniel,
>>
>> The fix looks good. It might be good to clarify the spec in the case
>> when the given resourceBundleName parameter is null? Perhaps in the
>> @params resourceBundleN
Looking at the jdk7 source and comparing your change this looks OK. Would be
good to get one more pair of eyes on this as well but I think you should be
good to go
Best
Lance
On Aug 23, 2013, at 10:41 AM, Daniel Fuchs wrote:
> Hi,
>
> Please find below a fix for:
>
> 8005899: Logger.getLogg
I think this look OK Alan
Best
Lance
On Aug 20, 2013, at 8:13 AM, Alan Bateman wrote:
>
> For some time now we have been chipping away at the make files that are used
> to run the jdk tests. Mike has his wielded his axe on several occasions
> recently to remove logic and rules that are no long
Hi all,
Need a reviewer for the following trivial javadoc typo. Bug is 8022753
Best
Lance
hg diff SQLXML.java
diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java
--- a/src/share/classes/java/sql/SQLXML.javaSat Jun 29 06:12:28 2013 -0400
+++ b/src/share/classes/java/sql/SQLXML.java
Looks OK Dan
Best
Lance
On Aug 8, 2013, at 7:26 PM, Dan Xu wrote:
> Hi All,
>
> Please review a simple bug fix for JDK8021977. For the backward
> compatibility, I have to remove the code that might throw out IOExceptionin
> the native side. The issue has never been reported.But it exists in a
looks fine chris
Best
Lance
On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote:
> These changes address the remaining lint warnings in the j.u.concurrent.**
> package(s).
>
> The changes are already in the JSR166 CVS, this is a request to bring them
> into jdk8.
>
> diff -r 84004d0e3fdd
> src/
Hi Joe,
The changes look fine
Best
Lance
On Aug 9, 2013, at 1:57 AM, huizhe wang wrote:
> Hi,
>
> The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM
> 1.1 to convert the output to its canonical form. The XOM parser directly
> references to the JDK parser implementati
looks fine Dan
On Aug 7, 2013, at 1:49 PM, Dan Xu wrote:
> Hi All,
>
> Please review the simple warning fix in
> src/share/classes/sun/invoke/anon/ConstantPoolPatch.java.
>
> webrev: http://cr.openjdk.java.net/~dxu/8022554/webrev/
>
> Thanks,
>
> -Dan
Lance Andersen| Principal Member of Tec
Hi Stuart,
On the surface the changes look fine, including what you did for SwitchData.
Certainly another pair of eyes would be good also on this.
Best
Lance
On Aug 7, 2013, at 2:28 AM, Stuart Marks wrote:
> Hi,
>
> Please review the fix for this warnings cleanup bug.
>
> Bug: http://bugs.sun
Looks fine joe
On Jul 25, 2013, at 4:33 PM, Joe Darcy wrote:
> Hello,
>
> Please review these changes to remove the javac lint warnings from the
> java.lang.ref package:
>
>8021429 Fix lint warnings in java.lang.ref
>http://cr.openjdk.java.net/~darcy/8021429.0/
>
> Care was taken to no
d):
> http://cr.openjdk.java.net/~joehw/7u40/8021148/webrev/
>
> Thanks,
> Joe
>
> On 7/24/2013 3:41 AM, Lance Andersen - Oracle wrote:
>> Agree with the change and making fSecurityPropertyMgr final
>>
>> Best
>> Lance
>> On Jul 24, 2013, a
Good to go
On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:
> This is a request for review for some doclint warnings in the java.net
> package. Trivially, the list type should be left to the CSS.
>
> Note: with these changes there are still warnings for two DatagramPacket
> constructors that a
Agree with the change and making fSecurityPropertyMgr final
Best
Lance
On Jul 24, 2013, at 5:04 AM, chris Hegarty wrote:
> Joe,
>
> I can see in SAXParserImpl constructor, setFeature0 could throw, leaving the
> fSecurityPropertyMgr uninitialized. There my be other code paths too.
>
> I agree w
looks fine Mike
Best
Lance
On Jul 22, 2013, at 3:24 PM, Mike Duigou wrote:
> Hello all;
>
> A simple rewiew for the addition of another constructor to PriorityQueue.
> Currently if you wish to specify a Comparator you must also supply a size.
> This addition allows use of the default size whic
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test locations?
Best
Lance
On Jul 12, 2013, at 5:44 AM, Chris Hegarty wrote:
> The source changes look fine to me.
>
> The tests should be located elsewhere, otherwise they will collide with an
Hi Joe
Looks good
Best
Lance
On Jul 8, 2013, at 9:07 PM, huizhe wang wrote:
> Hi,
>
> I've updated webrev with improved property management, and quality backed by
> 320 test cases. Thanks Daniel for the help expanding the test suite!
>
> Here's the webrev:
> http://cr.openjdk.java.net/~joehw/
Looks fine Joe including Mandy's feedback
Best
Lance
On Jul 8, 2013, at 10:10 PM, Joe Darcy wrote:
> Hello,
>
> Please review my changes to resolve (almost all of):
>
>JDK-8020095 Fix doclint warnings in java.util.regex
>http://cr.openjdk.java.net/~darcy/8020095.0/
>
> Full text of the
looks good Joe
On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote:
> Hello,
>
> Pack200 has some doclint issues; please review the fixes to them below.
>
> Thanks,
>
> -Joe
>
> --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11
> 2013 -0700
> +++ b/src/share/classes/java/util
Hi,
Looking for a reviewer for this minor typo in ResultSet.next()
$ hg diff
diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10:21:22 2013 +0100
+++ b/src/share/classes/java/sql/ResultSet.java Fri Jun 28 18:09:36 2013 -0400
Hi Joe,
Looks good.
fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy.
Not sure if it matters below but thought I would point it out if you want a
smaller heading
Best
Lance
On Jun 28, 2013, at 1:54 PM, Joe Darcy wrote:
> Hello,
>
> Still more doclint fixes for re
looks fine joe
On Jun 27, 2013, at 3:47 PM, Joe Darcy wrote:
> Hello,
>
> Please review the next patch in a series of patches to resolve doclint
> warnings in the JDK; this time in javax.script.
>
> Thanks,
>
> -Joe
>
> diff -r b8f16cb2d95b src/share/classes/javax/script/Invocable.java
> ---
+1
On Jun 27, 2013, at 2:58 PM, Joe Darcy wrote:
> Hello,
>
> Please review the patch below which resolves doclint warnings in
> java.util.logging.
>
> Thanks,
>
> -Joe
>
> diff -r 1c31082f0a51 src/share/classes/java/util/logging/Handler.java
> --- a/src/share/classes/java/util/logging/Handle
rev=3134
>
> Thanks,
> Joe
>
> On 6/10/2013 9:44 AM, Lance Andersen - Oracle wrote:
>> looks fine joe
>>
>> -lance
>> On Jun 8, 2013, at 4:11 PM, huizhe wang wrote:
>>
>>> Hi,
>>>
>>> This patch is to continue
looks fine joe
-lance
On Jun 8, 2013, at 4:11 PM, huizhe wang wrote:
> Hi,
>
> This patch is to continue the support of plugging in 3rd party parser impls
> (such as Xerces) that do not support JAXP 1.5. The fix is to catch
> SAXNotRecognizedException, print out a warning, and then continue as
This looks good. Thank you for taking this on Alan.
Best
Lance
On Jun 10, 2013, at 6:31 AM, Alan Bateman wrote:
>
> About 8 months ago I tried an early build of doclint [1] and used it to fix
> up a bunch issues at the time [2]. It's been awhile, so I decided to try out
> the latest version t
Hi Joe,
The change looks OK. I know the messages have to be translated by the
globalization team for the other languages.
Best
Lance
On Jun 6, 2013, at 5:42 PM, huizhe wang wrote:
> This is a quick fix to improve the error message so that it's clearly
> differentiated from those reported by t
sage has to be in the repository before the tool can pull them out.
>
I know it takes time, to get that done. Thank you for clarifying the error
message.
Best
Lance
> Best,
> Joe
>
> On 6/6/2013 2:51 PM, Lance Andersen - Oracle wrote:
>> Hi Joe,
>>
>> The chang
}
* @param map a java.util.Map object in which
*each entry consists of 1) a String object
*giving the fully qualified name of a UDT and 2) the
On Jun 6, 2013, at 4:34 PM, Aleksey Shipilev wrote:
> Hi Lance,
>
> On 06/07/2013 12:09 AM, Lance Andersen - Ora
Hi,
Need a reviewer for this minor javadoc update for bug 8016101
SerialStruct was missing a javadoc @param tag in the constructor
SerialRef had an extra '.'
Best
Lance
hg diff
diff -r b4742d038100 src/share/classes/javax/sql/rowset/serial/SerialRef.java
--- a/src/share/classes/javax/sql/ro
the changes make sense to me
On Jun 4, 2013, at 6:57 PM, Seán Coffey wrote:
> The com.sun.corba.se.impl package is a private package. The API is subject to
> change at any time and no 3rd party code should be using it. As a result, I'd
> like to add it to the package restricted list. I've run ou
looks fine Joe
On May 20, 2013, at 4:15 PM, huizhe wang wrote:
> Hi,
>
> This is a patch to remove redundant property settings. In the previous patch,
> the new jaxp properties were set while copying features onto DOM/SAX parsers.
> However, this is already done during the initialization of DOM
Looks fine Xuelei
best
Lance
On May 16, 2013, at 5:08 AM, Xuelei Fan wrote:
> Hi,
>
> There is another fix to avoid the use of mutable objects.
>
> webrev: http://cr.openjdk.java.net/~xuelei/8010814/webrev.00/
>
> Thanks,
> Xuelei
Lance Andersen| Principal Member of Technical Staff | +1.781.
+1
On May 14, 2013, at 8:16 AM, Alan Bateman wrote:
>
> The bootcycle-images target is currently broken in jdk8/tl.
>
> Jon has taken 8014461 to fix genstubs but once you get past that then the
> CLDRConverter fails parsing LDML due to DTD references that aren't allowed by
> the default policy
Hi Neil,
Just back from holiday and catching up (or trying to)
On May 2, 2013, at 7:13 AM, Neil Richards wrote:
>
> Hi Lance,
> I've been trying to identify the Java bug ids for the RFEs which
> implement JEP 170 (which, from what I can tell, should be in OpenJDK 8
> since milestone 6 [1]).
Hi Mike,
The changes look good to me.
Best
Lance
On Apr 29, 2013, at 10:11 PM, Mike Duigou wrote:
> Hello All;
>
> This is a review for three changes to the J2SE Netbeans project. If necessary
> I can break this up into three separate patches but I would rather not if
> possible.
>
>
> ht
This is good to go. Also reviewed by Russ Gold from the Corba team
Best
Lance
On Apr 12, 2013, at 6:48 AM, Dmeetry Degrave wrote:
>
> Hi all,
>
> I'm looking for a review for two ancient issues in idlj.
>
> First is an issue with uncompilable java code generated for unions with
> boolean dis
On Apr 26, 2013, at 8:35 AM, Alan Bateman wrote:
> On 25/04/2013 21:53, Lance Andersen - Oracle wrote:
>> http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos
>> that were pointed out and also fixes a couple javadoc warnings
>>
> This looks ok
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that
were pointed out and also fixes a couple javadoc warnings
Best,
Lance
On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote:
>
> On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
>
>> On 2
stent (or as
much as it can be)
> DriverManager line 355: missing space after comma.
fixed this. thank for this
Best
Lance
>
> -Ulf
>
> Am 21.04.2013 13:45, schrieb Lance Andersen - Oracle:
>> Thank you for the feedback Alan,
>>
>> Please see below and the web
On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
> On 21/04/2013 12:45, Lance Andersen - Oracle wrote:
>> :
>>>
>>> DriverManager
>>>
>>> - one point that isn't covered in the spec is whether the DriverAction's
>>> deregister
Thank you for the feedback Alan,
Please see below and the webrev
http://cr.openjdk.java.net/~lancea/8010416/webrev.02/
On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote:
> On 19/04/2013 18:34, Lance Andersen - Oracle wrote:
>> Hi,
>>
>> We have been asked by a few JDBC dri
still looking for a committer to bless this webrev so I can put it back
thank you in advance
best
Lance
On Apr 9, 2013, at 11:58 AM, Lance Andersen - Oracle wrote:
> Thank you ulf, I made the change in my workspace so that it will be
> accommodated as part of the putback
>
>
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC driver to be
notified when/if it was deregistered via DriverManager.deregisterDriver if
desired.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01
Best
Lance
Lance Andersen| Principal Memb
1 - 100 of 299 matches
Mail list logo
