[9] RFR 8138838: docs cleanup for java.desktop

2015-10-14 Thread Alexander Stepanov
Sorry, just a reminder. If the activity is untimely, then could you please review the following minimum part of fix? http://cr.openjdk.java.net/~avstepan/8138838/webrev.min.00/index.html (some misprints + midget JDK-8138893 fixed). Thanks, Alexander On 10/5/2015 2:12 PM, Alexander Stepanov

Re: P.S.: RFR [9] 8133651: automated replacing of old-style tags in docs

2015-10-05 Thread Alexander Stepanov
ure if these changes are desired at all for now. Thanks, Alexander (Just in case, adding the prehistory and sending a copy to core-libs-dev). On 10/1/2015 2:31 PM, Alexander Stepanov wrote: Hello Martin, Stuart, Thank you for the notes, Yes, the initial utility is quite ugly, I just tried to prep

[9] RFR 8138838: docs cleanup for java.desktop

2015-10-05 Thread Alexander Stepanov
Sorry; wrong subject... On 10/5/2015 2:12 PM, Alexander Stepanov wrote: Hello, Could you please review the fix for https://bugs.openjdk.java.net/browse/JDK-8138838 Patch + webrev zipped + specdiff report: http://cr.openjdk.java.net/~avstepan/8138838 Just some cosmetic changes for docs

Re: P.S.: RFR [9] 8133651: automated replacing of old-style tags in docs

2015-10-01 Thread Alexander Stepanov
-insensitive regex? Here's an emacs-lisp one-liner I've been known to use: (defun tt-code () (interactive) (query-replace-regexp "<\\(tt\\|code\\)>\\([^&<>]+\\)" "{@code \\2}")) With more work, one can

Re: P.S.: RFR [9] 8133651: automated replacing of old-style tags in docs

2015-10-01 Thread Alexander Stepanov
to the external workspace at the same time for the technology so these should definitely be kept separate. Best Lance On Oct 1, 2015, at 7:31 AM, Alexander Stepanov <alexander.v.stepa...@oracle.com <mailto:alexander.v.stepa...@oracle.com>> wrote: So if you don't have objections

Re: P.S.: RFR [9] 8133651: automated replacing of old-style tags in docs

2015-09-29 Thread Alexander Stepanov
, Alexander On 9/27/2015 4:52 PM, Alexander Stepanov wrote: Hello Martin, Here is some simple app. to replace tags with a new-style {@code } one (which is definitely not so elegant as the Perl one-liners): http://cr.openjdk.java.net/~avstepan/tmp/codeTags/SimpleTagEditor.java Corresponding patch

Re: RFR [9] 8133651: replace some tags (obsolete in html5) in core-libs docs

2015-09-24 Thread Alexander Stepanov
ut of this change Yes, I see. Reverted (please update the web page): http://cr.openjdk.java.net/~avstepan/8133651/jdk.00/index.html Thanks, Alexander P.S. The replacement job is mostly (I guess, ~80%) complete. But probably this approach should be used if some similar replacement task for, e.g., ta

RFR [9] 8133651: replace some tags (obsolete in html5) in core-libs docs

2015-09-19 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8133651/jdk.00/ http://cr.openjdk.java.net/~avstepan/8133651/jaxws.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8133651 Just another portion of deprecated (and ) tags replaced with {@code }.

RFR [9] 8133650: replace some tags (obsolete in html5) in CORBA docs

2015-09-13 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133650/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8133650 Just another portion of deprecated tags replaced with {@code }. A single (expected) change was indicated by specdiff (in ORB.java).

Re: RFR [9] 8133650: replace some tags (obsolete in html5) in CORBA docs

2015-09-13 Thread Alexander Stepanov
Thanks! Regards, Alexander On 9/13/2015 7:10 PM, Lance Andersen wrote: I did not see any issues looking at the udiffs. I assume based on your specdiff comment this should be good to go On Sep 13, 2015, at 11:25 AM, Alexander Stepanov <alexander.v.stepa...@oracle.

RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

2015-08-18 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8132478/jdk.00/index.html http://cr.openjdk.java.net/~avstepan/8132478/jaxws.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8132478 Just a minor fix for docs (a few tidy warnings + some invalid

Re: RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

2015-08-18 Thread Alexander Stepanov
, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8132478/jdk.00/index.html http://cr.openjdk.java.net/%7Eavstepan/8132478/jdk.00/index.html http

Re: RFR [9] 8133480: replace some tt tags (obsolete in html5) in core-libs docs

2015-08-14 Thread Alexander Stepanov
Thanks! Regards, Alexander On 8/13/2015 8:42 PM, Lance Andersen wrote: looks OK. Nothing obvious stands out. Best Lance On Aug 13, 2015, at 10:42 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello, Could you please review

RFR [9] 8133480: replace some tt tags (obsolete in html5) in core-libs docs

2015-08-13 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133480/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133480 Just another portion of deprecated tt tags replaced with {@code }. A single misprint was fixed; no other changes indicated by specdiff.

RFR [9] 8133459: replace tt tags (obsolete in html5) in java.nio docs

2015-08-12 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133459/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8133459 Just a next portion of deprecated 'tt' tags replaced (didn't touch all these multiple 'nbsp;'s to avoid undesirable

Re: RFR [9] 8133459: replace tt tags (obsolete in html5) in java.nio docs

2015-08-12 Thread Alexander Stepanov
Hello Lance, Thanks! Regards, Alexander On 8/12/2015 7:41 PM, Lance Andersen wrote: Hi Alexander, Nothing seems amiss in the changes and you indicated the specdiff shows no issues so you should be good to go Best Lance On Aug 12, 2015, at 11:46 AM, Alexander Stepanov alexander.v.stepa

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

2015-08-11 Thread Alexander Stepanov
Navigable*.java On Mon, Aug 10, 2015 at 6:39 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133188/webrev.01 http://cr.openjdk.java.net

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

2015-08-11 Thread Alexander Stepanov
Thanks! Regards, Alexander On 8/11/2015 7:10 PM, Martin Buchholz wrote: Thanks! Looks good to me. On Tue, Aug 11, 2015 at 4:33 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello Martin, the changes were reverted

RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

2015-08-10 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133188/webrev.01 for https://bugs.openjdk.java.net/browse/JDK-8133188 Just a next portion of tt tags removed. specdiff report:

Re: RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-06 Thread Alexander Stepanov
files; I'm presuming that others have.) s'marks On 8/5/15 5:01 AM, Alexander Stepanov wrote: Hello Stuart, Please see the final version of File.java (please update the page) - just replacing tt with code in the mentioned places: http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/src

Re: RFR [9] 8133040: docs: replace tt tags (obsolete in html5) for java.management

2015-08-06 Thread Alexander Stepanov
Hello Daniel, Thanks! Regards, Alexander On 8/6/2015 1:14 PM, Daniel Fuchs wrote: Hi Alexander, Cursory inspection of the patch file has not revealed anything wrong. Specdiff looks OK, so that's good for me. best regards, -- daniel On 05/08/15 19:37, Alexander Stepanov wrote

RFR [9] 8133115: docs: replace tt tags (obsolete in html5) for java.util.logging, java.util.prefs, java.util.zip, java.util.jar

2015-08-06 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133115/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133115 Just a next portion of tt tags removed. specdiffs did not detect any changes for java.util package:

Re: RFR [9] 8133115: docs: replace tt tags (obsolete in html5) for java.util.logging, java.util.prefs, java.util.zip, java.util.jar

2015-08-06 Thread Alexander Stepanov
Thanks! On 8/6/2015 6:33 PM, Lance Andersen wrote: Looks fine Best Lance On Aug 6, 2015, at 11:08 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan

Re: RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-05 Thread Alexander Stepanov
Thanks! On 8/5/2015 11:14 AM, Daniel Fuchs wrote: Hi Alexander, On 04/08/15 19:34, Alexander Stepanov wrote: Hello Daniel, The review was re-uploaded as specdiff indeed discovered a couple of unwanted changes (in 'InitialContext' and 'ReferralException'), so your and Pavel's recommendations

Re: RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-05 Thread Alexander Stepanov
restore the italic 'f' it'll look bad, so you'll want to restore the nbsp; as well. s'marks On 8/3/15 9:03 AM, Alexander Stepanov wrote: Hello Pavel Hi Alexander, if I were you I would run specdiff Thanks; but sorry, I'm afraid I haven't enough time for the extra experiments just now

RFR [9] 8133040: docs: replace tt tags (obsolete in html5) for java.management

2015-08-05 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8133040/webrev.00 for https://bugs.openjdk.java.net/browse/JDK-8133040 specdiffs: java.lang.management - no changes detected:

Re: RFR [9] 8133040: docs: replace tt tags (obsolete in html5) for java.management

2015-08-05 Thread Alexander Stepanov
javax.management - one (expected) change in TabularDataSupport: (full package diff: http://cr.openjdk.java.net/~avstepan/8133040/javax.management/overview-summary.html) On 8/5/2015 8:22 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix: http

Re: RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-04 Thread Alexander Stepanov
, and there's nothing that caught my eye. However - it would be good if you could generate a specdiff so that we could verify that no mistake has crept in. best regards, -- daniel On 03/08/15 17:39, Alexander Stepanov wrote: just in case, the updated webrev: http://cr.openjdk.java.net/~avstepan

Re: RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-03 Thread Alexander Stepanov
just in case, the updated webrev: http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/index.html On 8/3/2015 4:01 PM, Alexander Stepanov wrote: P.S. I have also to replace code{@link ...}/code with just {@link ...} in a couple of places here (as in the previous RFR 8132468...) Regards

Re: RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-03 Thread Alexander Stepanov
, Pavel Rappo wrote: On 3 Aug 2015, at 16:07, Alexander Stepanov alexander.v.stepa...@oracle.com wrote: Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/ removed wrapping code/code around the links (mostly PrintStream.java, PrintWriter.java, File.java), plus

RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-03 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132468/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132468 Just some cleanup for docs (replacing obsolete tt/tt). Thanks, Alexander

RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-03 Thread Alexander Stepanov
Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132877/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132877 Just some cleanup for docs (replacing obsolete tt/tt). Thanks, Alexander

Re: RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-03 Thread Alexander Stepanov
Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/ removed wrapping code/code around the links (mostly PrintStream.java, PrintWriter.java, File.java), plus other changes in File.java Thanks, Alexander On 8/3/2015 3:40 PM, Alexander Stepanov wrote: Hello

Re: RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-03 Thread Alexander Stepanov
Lance On Aug 3, 2015, at 5:43 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: http://cr.openjdk.java.net/~avstepan/8132877/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/8132877/webrev.00/ http://oracle.com/us/design/oracle-email-sig

Re: RFR [9] 8132877: docs: replace tt tags (obsolete in html5) for java.naming

2015-08-03 Thread Alexander Stepanov
P.S. I have also to replace code{@link ...}/code with just {@link ...} in a couple of places here (as in the previous RFR 8132468...) Regards, Alexander On 8/3/2015 3:57 PM, Alexander Stepanov wrote: Thanks! On 8/3/2015 3:53 PM, Lance Andersen wrote: I think this looks ok also. I agree

Re: RFR [9] 8132468: docs: replace tt tags (obsolete in html5) for java.io, java.lang, java.math

2015-08-03 Thread Alexander Stepanov
was to replace just tt/tt (as the tag is deprecated for HTML5, in contrast to the code). So the touched packages (and even files) still have a lot of code tags. Thanks, Alexander On 8/3/2015 3:17 PM, Daniel Fuchs wrote: On 03/08/15 11:31, Alexander Stepanov wrote: Hello, Could you please

RFR [9] 8130247: fix some new tidy warnings from jaxws and CORBA

2015-07-01 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8130247/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8130247 Just a minor correction for the docs. Some empty trimming p tidy warnings fixed; some deprecated tt tags were replaced with {@code }

Re: RFR [9] 8081517: minor cleanup for docs

2015-06-08 Thread alexander stepanov
Thanks! On 05.06.2015 21:32, Roger Riggs wrote: Hi Alexander, Looks good, thanks for the updates. Roger On 6/5/2015 1:33 PM, alexander stepanov wrote: Hello Lance, Roger, Thank you for the notes, please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8081517/webrev.01

RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread alexander stepanov
Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8081517 Just some cleanup for docs. Thanks, Alexander

Re: RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread alexander stepanov
transient Connection con; 3) CachedRowSetWriter.java: +1056: The tag @ param should be tighted up to @param Thanks, Roger On 6/5/2015 8:51 AM, alexander stepanov wrote: Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ for https://bugs.openjdk.java.net

Re: RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread alexander stepanov
: The tag @ param should be tighted up to @param Thanks, Roger On 6/5/2015 8:51 AM, alexander stepanov wrote: Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8081517 Just some cleanup for docs. Thanks

Re: RFR [9] 8040147: minor cleanup for docs

2015-05-26 Thread alexander stepanov
Alexander, Overal this looks OK. One suggestion for webrevs is to change code/code to {@code} while you are updating specific comments (not the entire file, but at least the lines you are touching). Thank you for making the changes. Best Lance On May 25, 2015, at 5:40 AM, alexander stepanov

Re: RFR [9] 8040147: minor cleanup for docs

2015-05-26 Thread alexander stepanov
Thanks! On 26.05.2015 15:30, Lance Andersen wrote: Hi Alexander, the updates look fine as well Best Lance On May 26, 2015, at 7:45 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello Lance, Thank you. One suggestion for webrevs

RFR [9] 8040147: minor cleanup for docs

2015-05-25 Thread alexander stepanov
Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8040147/webrev.02/ for https://bugs.openjdk.java.net/browse/JDK-8040147 Just a minor fix for docs (some tidy warnings + misprints). Thanks, Alexander

Re: RFR [9] 8080422: some docs cleanup for core libs

2015-05-18 Thread alexander stepanov
/misc/resources/Messages_* files: Thanks, Roger On 5/18/2015 10:08 AM, alexander stepanov wrote: Please see the updated webrev http://cr.openjdk.java.net/~avstepan/8080422/webrev.01/ - some misprints were fixed as well (not 100% sure if comparision should be replaced with comparison

RFR [9] 8080422: some docs cleanup for core libs

2015-05-18 Thread alexander stepanov
Please see the updated webrev http://cr.openjdk.java.net/~avstepan/8080422/webrev.01/ - some misprints were fixed as well (not 100% sure if comparision should be replaced with comparison, but the latter looks more suitable). Thanks, Alexander On 15.05.2015 20:16, alexander stepanov wrote

Re: RFR [9] 8080422: some docs cleanup for core libs

2015-05-18 Thread alexander stepanov
, Alexander On 18.05.2015 18:54, Lance Andersen wrote: The revised changes seem OK in addition to the previous webrev Best Lance On May 18, 2015, at 11:36 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello Roger, Fixed; please see http

RFR [9] 8080422: some docs cleanup for core libs

2015-05-15 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8080422/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8080422 Just some HTML markup fix. The affected packages should (probably) not be visible in the new modular system, but nevertheless...

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

2015-05-06 Thread alexander stepanov
Andersen wrote: The changes seem reasonable those the comments in ValueBoxGen24 are somewhat cryptic to me at least :-) On May 5, 2015, at 12:30 PM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: _variableName in the public javadocs

RFR [9] 8079342: some docs cleanup for CORBA - part 2

2015-05-05 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8079342/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079342 Just some HTML markup fix for CORBA. Thanks, Alexander

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

2015-05-05 Thread alexander stepanov
But yes, for 'writeValue' it could be renamed without any thoughts, thanks... On 05.05.2015 18:41, alexander stepanov wrote: Hello Lance, It just seemed to be less hazardous. E.g., method 'readValue' (in ValueHandlerImpl) contains inner variable 'in' and parameter '_in' being documented

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

2015-05-05 Thread alexander stepanov
, 2015, at 11:21 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8079342/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/8079342/webrev.00/ for https

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

2015-05-05 Thread alexander stepanov
... Thanks, Alexander On 05.05.2015 18:46, Lance Andersen wrote: Hi Alexander, Thank you, I guess I am not a fan of _variableName in the public javadocs as it is not something we normally see. Understand less is more, especially with CORBA. On May 5, 2015, at 11:41 AM, alexander stepanov

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

2015-04-30 Thread alexander stepanov
, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8079075/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079075 Just some HTML markup fix for CORBA. Thanks, Alexander

RFR [9] 8040147: tidy warnings cleanup for javax.transaction

2015-04-30 Thread alexander stepanov
Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8040147/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8040147 Just a very minor fix of docs markup. Thanks, Alexander

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

2015-04-30 Thread alexander stepanov
in the code anymore. It would probably be fine to just drop the extra '' symbols. And around the author initials. klr -- klr Regards, Roger On 4/30/2015 7:56 AM, alexander stepanov wrote: P.S. Sorry, not sure if changes like d62023 - {@literal d62023} (see, e.g., ValueBoxGen24.java

Re: RFR [9] 8079075: some docs cleanup for CORBA - part 1

2015-04-30 Thread Alexander Stepanov
- part 1 Hi Alexander, The improvements look good to me. Thank you, Roger On 4/30/2015 12:35 PM, alexander stepanov wrote: Hello Roger, Thank you for the notes; please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8079075/webrev.01/ Regards, Alexander On 30.04.2015 16:47

RFR [9] 8076224: some tidy warning from core libs

2015-04-28 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8076224/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8076224 Just some HTML cleanup for docs (remove tidy warnings; remove some unnecessary tt tags as they are not supported in HTML5). Thanks,

Re: RFR [9] 8076224: some tidy warning from core libs

2015-04-28 Thread alexander stepanov
/28/2015 8:22 AM, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8076224/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8076224 Just some HTML cleanup for docs (remove tidy warnings; remove some unnecessary tt tags

Re: RFR [9] 8076224: some tidy warning from core libs

2015-04-28 Thread alexander stepanov
thanks! On 28.04.2015 19:25, Lance Andersen wrote: This seems better now :-) On Apr 28, 2015, at 12:09 PM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello Roger, Thanks! Generally, avoiding line breaks of {@link x} across lines

RFR [9] 8078622: remove tidy warnings from JPDA docs

2015-04-24 Thread alexander stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8078622/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8078622 Just some HTML cleanup for docs. Thanks, Alexander

Re: RFR [9] 8038764: tidy warnings cleanup for javax.activation

2015-04-20 Thread alexander stepanov
Thanks! On 20.04.2015 18:10, Lance Andersen wrote: Looks fine. Need to get this into the upstream project though so they are not lost on the next update Best Lance On Apr 20, 2015, at 11:01 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote

RFR [9] 8038764: tidy warnings cleanup for javax.activation

2015-04-20 Thread alexander stepanov
Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8038764/webrev.00/ for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038764 Just a minor HTML markup fix (few 'trimming empty p' warnings fixed). Probably the code affected is an upstream. Regards,

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-17 Thread alexander stepanov
? Thanks, Joe On 4/16/2015 7:07 AM, alexander stepanov wrote: I'm sorry, two extra files touched - http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/jaxws/src/java.activation/share/classes/javax/activation/MailcapCommandMap.java.udiff.html http://cr.openjdk.java.net/~avstepan/8077332/webrev.01

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-17 Thread alexander stepanov
Thanks! Regards, Alexander On 17.04.2015 19:33, huizhe wang wrote: Hi Alexander, That fixed the issue in the existing Javadoc. The JAXP changes look good now. Thanks for doing this! Best, Joe On 4/17/2015 4:36 AM, alexander stepanov wrote: Hello Joe, [jw] as I mentioned, pre/pre

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
/java.annotations.common/share/classes/javax/annotation/PreDestroy.java.udiff.html On 15.04.2015 19:12, alexander stepanov wrote: Hello Joe, The copyright changes were reverted. Please review the updated fix: http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/ (code/code replaced with {@code}, removed

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
/MimetypesFileTypeMap.java.udiff.html Hopefully that's all for this bug... Thanks, Alexander On 16.04.2015 15:48, alexander stepanov wrote: Please note also that a couple of new files were touched: http://cr.openjdk.java.net/~avstepan/8077332/webrev.01/jaxws/src/java.annotations.common/share

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
; * } - * /code + * } [jw] as I mentioned, pre/pre is needed for the code snippet. BTW, have you compiled and verified the Javadoc after the changes? Thanks, Joe On 4/16/2015 7:07 AM, alexander stepanov wrote: I'm sorry, two extra files touched - http://cr.openjdk.java.net/~avstepan/8077332

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-16 Thread alexander stepanov
Hello Lance, Thanks. Regards, Alexander On 16.04.2015 19:58, Lance Andersen wrote: Hi Alexander, These seem to be OK Best Lance On Apr 16, 2015, at 10:07 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: I'm sorry, two extra files

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-15 Thread alexander stepanov
:42 AM, Alan Bateman wrote: On 13/04/2015 12:22, alexander stepanov wrote: Hello Joe, Thank you for the notes; Copyright year shall not be changed. That seems to be a bit controversial point; sometimes (while cleaning docs) I was asked to do that, other times - not to do that. Our internal

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
Thanks! On 10.04.2015 20:07, Sean Mullan wrote: On 04/10/2015 12:01 PM, Alan Bateman wrote: On 10/04/2015 16:50, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8077332/ for https://bugs.openjdk.java.net/browse/JDK-8077332

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
and remove all /p* Thanks, Joe On 4/10/2015 8:50 AM, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8077332/ for https://bugs.openjdk.java.net/browse/JDK-8077332 Some HTML cleanup for docs. Thanks, Alexander

Re: RFR [9] 8077332: tidy warnings from javax/xml

2015-04-13 Thread alexander stepanov
Hello Alan, Thank you. Regards, Alexander On 10.04.2015 19:01, Alan Bateman wrote: On 10/04/2015 16:50, alexander stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8077332/ for https://bugs.openjdk.java.net/browse/JDK-8077332 Some HTML

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-08 Thread alexander stepanov
Thanks! On 07.04.2015 20:13, Roger Riggs wrote: Thanks, looks fine. Roger On 4/7/2015 1:00 PM, alexander stepanov wrote: Hello Roger, Thank you for the notes, fixed: http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/portable

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-08 Thread alexander stepanov
Thanks! On 07.04.2015 20:48, Lance Andersen wrote: Hi Alexander, InTypeCode.java you might want to use {@code} vs code so that you do not have to use gt; lt; Otherwise it is OK Best Lance On Apr 7, 2015, at 1:00 PM, alexander stepanov alexander.v.stepa...@oracle.com

Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8039440 Just an HTML markup fix for CORBA. Thanks, Alexander

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
Thanks! On 07.04.2015 17:45, Yuri Nesterenko wrote: I'm not sure either but the fix looks OK to me. -yan On 04/07/2015 05:40 PM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following fix? http://cr.openjdk.java.net/~avstepan

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

2015-04-07 Thread alexander stepanov
as well. */ + public abstract class TypeCode implements IDLEntity { (RR) There should not be blank line between comment and class definition. Thanks, Roger On 4/7/2015 10:40 AM, alexander stepanov wrote: Hello, I'm not if the mail list is correct, but could anyone please review the following

Re: Core Libs Dev[9] Review request for 8029451: Tidy warnings cleanup for java.util package; minor changes in java.nio, java.sql

2014-04-30 Thread alexander stepanov
Sorry, could please anybody else review the changes? We need at least two positive responses to push the changes. Thanks, Alexander On 18.04.2014 23:47, Lance Andersen wrote: looks fine On Apr 18, 2014, at 10:04 AM, alexander stepanov alexander.v.stepa...@oracle.com

Re: Core Libs Dev[9] Review request for 8029451: Tidy warnings cleanup for java.util package; minor changes in java.nio, java.sql

2014-04-30 Thread alexander stepanov
Hello Lance, oh yes, thanks! Regards, Alexander On 30.04.2014 14:39, Lance Andersen wrote: On Apr 30, 2014, at 4:23 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Sorry, could please anybody else review the changes? We need at least

Core Libs Dev[9] Review request for 8029451: Tidy warnings cleanup for java.util package; minor changes in java.nio, java.sql

2014-04-18 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8029451 Webrev corresponding: http://cr.openjdk.java.net/~yan/JDK-8029451/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards,

Core Libs Dev[9] Review Request for 8030709: Tidy warnings cleanup for java.lang package

2014-04-15 Thread alexander stepanov
Sorry, the webrev was updated to include one other minor change in javax/script/ScriptEngineFactory.java to avoid creation of separate review request: http://cr.openjdk.java.net/~yan/8030709/webrev.01/ Regards, Alexander On 10.04.2014 12:24, alexander stepanov wrote: BigInteger.java from

Re: Core Libs Dev[9] Review Request for 8030709: Tidy warnings cleanup for java.lang package

2014-04-15 Thread alexander stepanov
thanks! On 15.04.2014 17:24, Lance Andersen wrote: looks ok On Apr 15, 2014, at 9:11 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Sorry, the webrev was updated to include one other minor change in javax/script/ScriptEngineFactory.java

Core Libs Dev[9] Review Request for 8030709: Tidy warnings cleanup for java.lang package

2014-04-10 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8030709 Webrev corresponding: http://cr.openjdk.java.net/~yan/8030709/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. BigInteger.java from

Core Libs Dev[9] Review Request for 8030709: Tidy warnings cleanup for java.lang package

2014-04-10 Thread alexander stepanov
BigInteger.java from java.lang was also touched. sorry, from java.math On 10.04.2014 12:23, alexander stepanov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8030709 Webrev corresponding: http://cr.openjdk.java.net/~yan/8030709

Core Libs Dev[9] Review Request for 8039488: tidy warnings cleanup for javax.sql

2014-04-09 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8039488 Webrev corresponding: http://cr.openjdk.java.net/~yan/8039488/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Re: Core Libs Dev[9] Review Request for 8039488: tidy warnings cleanup for javax.sql

2014-04-09 Thread alexander stepanov
:+1.781.442.2037 Oracle Java Engineering 1 Network Drive x-apple-data-detectors://34/0 Burlington, MA 01803 x-apple-data-detectors://34/0 lance.ander...@oracle.com mailto:lance.ander...@oracle.com Sent from my iPad On Apr 9, 2014, at 5:45 AM, alexander stepanov alexander.v.stepa...@oracle.com

Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8039172 Webrev corresponding: http://cr.openjdk.java.net/~yan/8039172/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Engineering 1 Network Drive x-apple-data-detectors://34/0 Burlington, MA 01803 x-apple-data-detectors://34/0 lance.ander...@oracle.com mailto:lance.ander...@oracle.com Sent from my iPad On Apr 4, 2014, at 4:55 AM, alexander stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Thanks; the line in net-properties.html was splitted. Regards, Alexander On 04.04.2014 19:25, Alan Bateman wrote: On 04/04/2014 12:53, alexander stepanov wrote: Hello Lance, Thank you for the note; the summaries were removed, please see the updated webrev: http://cr.openjdk.java.net/~yan

Core Libs Dev[9] Review request for 8039041: tidy warnings cleanup for javax.naming

2014-04-03 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8039041 Webrev corresponding: http://cr.openjdk.java.net/~yan/8039041/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038795 Webrev corresponding: http://cr.openjdk.java.net/~yan/8038795/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Re: Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread alexander stepanov
Thanks! On 01.04.2014 16:57, Alan Bateman wrote: I think you are looking for jmx-dev so forwarding to that list. On 01/04/2014 13:51, alexander stepanov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038795 Webrev

Core Libs Dev[9] Review Request for 8038493: tidy warnings cleanup for java.sql

2014-03-28 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038493 Webrev corresponding: http://cr.openjdk.java.net/~yan/8038493/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander