Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-11-14 Thread Bob Vandette
-Original Message- >> From: Alan Bateman >> Sent: Samstag, 20. Oktober 2018 10:06 >> To: Baesken, Matthias >> Cc: hotspot-dev Source Developers ; core- >> libs-...@openjdk.java.net; Moldenhauer, Niclas >> >> Subject: Re: RFR : 8211106: [windows] Up

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-11-14 Thread Baesken, Matthias
Niclas > > Subject: Re: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > On 19/10/2018 13:11, Baesken, Matthias wrote: > > Hi Alan, I agree it is a pity that the minor version (dwMinorVersion) > > was > not increased

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-22 Thread Baesken, Matthias
Subject: Re: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > On 19/10/2018 13:11, Baesken, Matthias wrote: > > Hi Alan, I agree it is a pity that the minor version (dwMinorVersion) > > was > not increased . > > Looki

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-20 Thread Alan Bateman
On 19/10/2018 13:11, Baesken, Matthias wrote: Hi Alan, I agree it is a pity that the minor version (dwMinorVersion) was not increased . Looking at the build number was not my preferred way to handle this . My understanding (checked with our internal SAP-MS porting guys) is that the

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-19 Thread Weijun Wang
According to https://en.wikipedia.org/wiki/Windows_Server: Microsoft releases Windows Server in a LTS channel every few years named Windows Server 2016, Windows Server 2019, ... It also releases in a semi-annual channel named Windows Server, version 1803, 1809, ... I'm not sure if we can find

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-19 Thread Alan Bateman
On 19/10/2018 10:22, Baesken, Matthias wrote: Thanks for the remarks , I updated my changes , new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.2/ Do you know if there is anything on the Microsoft site to explain why the minor version wasn't bumped? It looks unusual to have

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-19 Thread Baesken, Matthias
s/8211106.2/ Best regards, Matthias From: Bob Vandette Sent: Donnerstag, 18. Oktober 2018 16:36 To: Baesken, Matthias Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net; Langer, Christoph Subject: Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-18 Thread Roger Riggs
al Message- From: Baesken, Matthias Sent: Freitag, 12. Oktober 2018 08:57 To: 'Bob Vandette' Cc: 'hotspot-...@openjdk.java.net' ; 'core-libs-dev@openjdk.java.net' ; Langer, Christoph Subject: RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019 I got

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-18 Thread Bob Vandette
tthias >> Sent: Freitag, 12. Oktober 2018 08:57 >> To: 'Bob Vandette' >> Cc: 'hotspot-...@openjdk.java.net' ; >> 'core-libs-dev@openjdk.java.net' ; >> Langer, Christoph >> Subject: RE: RFR : 8211106: [windows] Update OS detection code to >> recognize Wind

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-18 Thread Baesken, Matthias
bject: RE: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > I got the info that the GA of Windows Server 2019 has build number 17763 > . > Should I update the webrev to check this build number (would mean we do > not detect the

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-12 Thread Baesken, Matthias
I got the info that the GA of Windows Server 2019 has build number 17763 . Should I update the webrev to check this build number (would mean we do not detect the preview as Windows Server 2019) , or keep it the way it is ? Current webrev :

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-11 Thread Baesken, Matthias
n . Best regards, Matthias > -Original Message- > From: Baesken, Matthias > Sent: Dienstag, 2. Oktober 2018 17:03 > To: Bob Vandette > Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net; > Moldenhauer, Niclas > Subject: RE: RFR : 8211106: [windows] Update OS detection

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-02 Thread Baesken, Matthias
et; core-libs-dev@openjdk.java.net; > Moldenhauer, Niclas > Subject: Re: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > Matthias, > > We don’t usually add logic to the JDK related to unreleased operating system > previews. > &

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-10-02 Thread Bob Vandette
Matthias, We don’t usually add logic to the JDK related to unreleased operating system previews. Has the ReleaseID been updated on the system you are testing on? This is the documented way of determining the OS version you are running on? The latest preview release is build 17744. Are you