Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-11 Thread Igor Ignatyev
Hi Mandy, thank you for your review. although jdk.test.lib.compiler.CompilerUtils is easy to use, it introduces dependency on jdk.compiler module and currently FragmentMetaspaceSimple.java depends only on java.base module and I would prefer it remain so. Thanks, -- Igor > On Aug 11, 2017,

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-11 Thread mandy chung
On 8/10/17 9:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html hotspot/test/runtime/Metaspace/FragmentMetaspaceSimple.java 26 * @library /test/lib classes 27 * @build test.Empty 28 * @run driver ClassFileInstaller test.Empty

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-11 Thread Roger Riggs
Hi Igor, In (some of) the TEST.ROOT files, maintenance of the files can be simplified by removing the version number from the comment. The version that is in jaxp is reasonable: "# Minimum jtreg version" and should be applied to the hotspot, jdk, langtools, and nashorn TEST.ROOT files.

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread David Holmes
Thanks Ioi, and Igor, for clarifying. David On 11/08/2017 3:23 PM, Ioi Lam wrote: On 8/10/17 9:46 PM, David Holmes wrote: On 11/08/2017 2:31 PM, Igor Ignatyev wrote: On Aug 10, 2017, at 9:22 PM, David Holmes wrote: Hi Igor, On 11/08/2017 2:02 PM, Igor

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread Ioi Lam
On 8/10/17 9:46 PM, David Holmes wrote: On 11/08/2017 2:31 PM, Igor Ignatyev wrote: On Aug 10, 2017, at 9:22 PM, David Holmes wrote: Hi Igor, On 11/08/2017 2:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html 14

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread Igor Ignatyev
> On Aug 10, 2017, at 9:46 PM, David Holmes wrote: > > On 11/08/2017 2:31 PM, Igor Ignatyev wrote: >>> On Aug 10, 2017, at 9:22 PM, David Holmes wrote: >>> >>> Hi Igor, >>> >>> On 11/08/2017 2:02 PM, Igor Ignatyev wrote:

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread David Holmes
On 11/08/2017 2:31 PM, Igor Ignatyev wrote: On Aug 10, 2017, at 9:22 PM, David Holmes wrote: Hi Igor, On 11/08/2017 2:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html 14 lines changed: 1 ins; 0 del; 13 mod; Hi all,

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread Igor Ignatyev
> On Aug 10, 2017, at 9:22 PM, David Holmes wrote: > > Hi Igor, > > On 11/08/2017 2:02 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html >>> 14 lines changed: 1 ins; 0 del; 13 mod; >> Hi all, >> could you please review this

Re: RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread David Holmes
Hi Igor, On 11/08/2017 2:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html 14 lines changed: 1 ins; 0 del; 13 mod; Hi all, could you please review this small patch which bumps up jtreg version? besides updating jib profiles and all TEST.ROOT

RFR(XS) : 8186095 : upgrade to jtreg 4.2 b08

2017-08-10 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8186095/webrev.00/index.html > 14 lines changed: 1 ins; 0 del; 13 mod; Hi all, could you please review this small patch which bumps up jtreg version? besides updating jib profiles and all TEST.ROOT files, the fix updates