Re: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Am 28.08.2011 22:54, schrieb Mario Torre: Il giorno dom, 28/08/2011 alle 21.35 +0200, Sebastian Sickelmann ha scritto: Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Hi, Hi created a new webrev with your suggested changes at:

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Am 29.08.2011 21:10, schrieb Xueming Shen: Hi Sebastian, I will help to push the patch, if people all agreed the changes proposed. Thanks for supporting this. I pulled your patch and generated the webrev at http://cr.openjdk.java.net/~sherman/7084245/webrev I already created a new webrev

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Sorry i have forgotten the webrev url. http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_1/ Am 30.08.2011 10:20, schrieb Sebastian Sickelmann: Am 29.08.2011 21:10, schrieb Xueming Shen: Hi Sebastian, I will help to push the patch, if people all agreed the changes

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Xueming Shen
Hi Sebastian, On 08/30/2011 01:23 AM, Sebastian Sickelmann wrote: Sorry i have forgotten the webrev url. http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_1/ with couple changes from your original patch. (1) Undo the changes in DecimalFormat.java and Format.java.

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Xueming Shen
Sebastian, src/share/classes/sun/misc/Launcher.java in new patch appears to miss a ending } at ln#487 -Sherman On 08/30/2011 10:20 AM, Xueming Shen wrote: Hi Sebastian, On 08/30/2011 01:23 AM, Sebastian Sickelmann wrote: Sorry i have forgotten the webrev url.

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Sebastian Sickelmann
Am 29.08.2011 02:02, schrieb David Holmes: On 29/08/2011 5:35 AM, Sebastian Sickelmann wrote: Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Xuelei Fan
I reviewed the security part. In general, it looks fine. But sometimes, from my very personal view, the exception-chain might be over used. For example, the following code: try { md = MessageDigest.getInstance(SHA); } catch (NoSuchAlgorithmException nsae) { throw new

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Kumar Srinivasan
Hi, Sorry for the delay, was on vacation...comment inlined. Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to java.util.concurrent should go

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Xueming Shen
Hi Sebastian, I will help to push the patch, if people all agreed the changes proposed. I pulled your patch and generated the webrev at http://cr.openjdk.java.net/~sherman/7084245/webrev with couple changes from your original patch. (1) Undo the changes in DecimalFormat.java and Format.java.

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-28 Thread David Holmes
On 29/08/2011 5:35 AM, Sebastian Sickelmann wrote: Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to java.util.concurrent should go through Doug