On Wed, 13 Dec 2023 23:10:05 GMT, Naoto Sato wrote:
> Small document correction on a return description.
Marked as reviewed by joehw (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17098#pullrequestreview-1781215288
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
This pull request has now been integrated.
Changeset: ddbbd36e
Author:Joe Wang
URL:
On Fri, 10 Feb 2023 17:38:51 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
Updated the version to 23-ea and year to 2024.
This initial generation also picks up the unpublished changes from:
- [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
jarsigner)
- [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK 23
backport)
-
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors
On Thu, 14 Dec 2023 03:56:11 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
jpackage part looks fine.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1780705685
On Wed, 13 Dec 2023 23:10:05 GMT, Naoto Sato wrote:
> Small document correction on a return description.
Marked as reviewed by jlu (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/17098#pullrequestreview-1780672305
Hi Pavel,
Thanks for the reply. If I understand correctly, I need this change to be
discussed in one of the mailing lists there, so that someone would sponsor
me to create a tracking issue in JBS. Do you know which mailing list is the
most relevant for me to propose the change?
Thanks,
Valeh
On
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
@JoeWang-Java can u review the xml changes?
@jonathan-gibbons can u review the compiler changes?
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1854853944
PR Comment:
Sorry, there's a necessary process that a PR must follow. You seem to have
signed OCA already. For the rest, see this resource:
https://openjdk.org/guide/. In particular, this part:
https://openjdk.org/guide/#contributing-to-an-openjdk-project.
-Pavel
> On 13 Dec 2023, at 23:09, Valeh Hajiyev
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
@alexeysemenyukoracle please review jpackage part
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1854847266
Small document correction on a return description.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/17098/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17098=00
Issue: https://bugs.openjdk.org/browse/JDK-8321958
Stats: 2 lines in 1 file
Hi all,
I have raised the following PR, could someone please help me to get it
merged?
https://github.com/openjdk/jdk/pull/17045
*More details:*
*This commit addresses the current limitation in the `PriorityQueue`
implementation, which lacks a constructor to efficiently create a
Translation drop for JDK22 RDP1
-
Commit messages:
- translated files
Changes: https://git.openjdk.org/jdk/pull/17096/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17096=00
Issue: https://bugs.openjdk.org/browse/JDK-8322041
Stats: 290 lines in 36 files changed: 166 ins;
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Tue, 12 Dec 2023 22:21:29 GMT, Joe Darcy wrote:
> As the core reflection code will encounter record classes compiled before and
> after the javac code generation change, if the old behavior can be triggered
> in javac using `--release $OLD`/`--source $OLD`, that would be helpful to
>
On Wed, 13 Dec 2023 21:25:13 GMT, Jorn Vernee wrote:
>> Right, I suggested putting that in parentheses. Historically we haven't been
>> very formal about distinguishing between normative (Java SE) specifications
>> and informative text that talks about implementations. In this case I felt
>>
The test java/lang/String/CompactString/MaxSizeUTF16String.java fails when run
with -Xcomp.
Both the java implementation and the intrinsic for StringUTF16.toBytes()
allocate memory for a copy of the string.
The java implementation of `toBytes()` throws an exception with a message in
terms of
On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs wrote:
> One of the three `XMLStreamException` constructors that takes a `Throwable`
> fails to pass it to the superclass constructor.
>
> This simple patch fixes that omission.
>
> It's worth considering if there is any code out there that is
On Wed, 13 Dec 2023 05:19:25 GMT, Stuart Marks wrote:
>> The `-D` command-line option is not a part of the Java SE specification but
>> an allowed behavior, so it may not be a normative description here.
>
> Right, I suggested putting that in parentheses. Historically we haven't been
> very
On Wed, 13 Dec 2023 21:19:34 GMT, Joe Wang wrote:
>> One of the three `XMLStreamException` constructors that takes a `Throwable`
>> fails to pass it to the superclass constructor.
>>
>> This simple patch fixes that omission.
>>
>> It's worth considering if there is any code out there that is
On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs wrote:
> One of the three `XMLStreamException` constructors that takes a `Throwable`
> fails to pass it to the superclass constructor.
>
> This simple patch fixes that omission.
>
> It's worth considering if there is any code out there that is
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780499321
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780488559
On Wed, 13 Dec 2023 20:54:16 GMT, Joe Wang wrote:
> Doc-only change: fix incorrect links in module-info.java and StAX factories.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17093#pullrequestreview-1780486241
On Wed, 13 Dec 2023 20:53:17 GMT, Justin Lu wrote:
> > I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`:
>
> Hi Eirik,
>
> Please let me know if I'm misunderstanding,
I claim `TooManyOpenTabsException` :-) Sorry, this comment was for #16115
-
PR Comment:
On Wed, 13 Dec 2023 18:35:40 GMT, Eirik Bjorsnos wrote:
> I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`:
Hi Eirik,
Please let me know if I'm misunderstanding,
But this change hasn't been integrated into the master branch yet. Your linked
PR does not appear to contain the
Doc-only change: fix incorrect links in module-info.java and StAX factories.
-
Commit messages:
- 8320279: Link issues in java.xml module-info.java
Changes: https://git.openjdk.org/jdk/pull/17093/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17093=00
Issue:
One of the three `XMLStreamException` constructors that takes a `Throwable`
fails to pass it to the superclass constructor.
This simple patch fixes that omission.
-
Commit messages:
- Propagate cause to superclass constructor in XMLStreamException constructor.
Changes:
On Wed, 13 Dec 2023 19:37:15 GMT, Brian Burkhalter wrote:
> Modify the `collapse()` function to remove each instance of ".." when the
> path is absolute and there is no preceding name.
Without this change the updated test fails as:
FAILED GetCanonicalPath::goodPathsUnix '[3]
Modify the `collapse()` function to remove each instance of ".." when the path
is absolute and there is no preceding name.
-
Commit messages:
- 8259637: java.io.File.getCanonicalPath() returns different values for same
path
Changes: https://git.openjdk.org/jdk/pull/17089/files
On Wed, 13 Dec 2023 16:46:16 GMT, Alan Bateman wrote:
>>> It doesn't make sense here to add a new package com.sun.io for a single
>>> method class. This PR does not need to introduce any new classes at this
>>> point. I think this PR needs to focus solely on BIS.
>>
>> So you actually prefer
On Wed, 13 Dec 2023 18:47:50 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
On Wed, 13 Dec 2023 18:33:13 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java line 317:
>
>> 315: * If the default
On Wed, 13 Dec 2023 18:38:11 GMT, Tim Prinzing wrote:
>>> It could also be interesting to provide the `timeout` that was given to the
>>> selection operation.
>>
>> I've tried to work through issues, esp. around selector spinning, and being
>> able to distinguish select from selectNow is
On Wed, 13 Dec 2023 18:38:09 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Thu, 23 Nov 2023 11:18:45 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/SelectionEvent.java line 43:
>>
>>> 41:
>>> 42: @Label("Selection Count")
>>> 43: @Description("Number of channels selected")
>>
>> I suspect you'll need to rename this event to something
On Fri, 8 Dec 2023 06:30:21 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/event/SelectionEvent.java line 38:
>>
>>> 36: public class SelectionEvent extends Event {
>>> 37:
>>> 38: public int count;
>>
>> It could also be interesting to provide the `timeout` that was
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Wed, 13 Dec 2023 18:01:55 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but
Better Error Handling for Jar Tool Processing of "@File"
This is a new PR for this PR since the original developer left the team. See
all of the review history at https://github.com/openjdk/jdk/pull/16423.
Thank you.
-
Commit messages:
- 8318971 : Better Error Handling for Jar
On Mon, 11 Dec 2023 23:20:25 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
Hi all,
This pull request contains a backport of commit
[7ece9e90](https://github.com/openjdk/jdk/commit/7ece9e90c0198f92cdf8d620e346c4a9832724cd)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Jorn Vernee on 13 Dec 2023 and was
On Mon, 11 Dec 2023 13:01:25 GMT, Jorn Vernee wrote:
> Improve the test by being more lenient to related code cache exhaustion
> errors. The important thing is that we don't terminate with a fatal error,
> which the new code now checks for explicitly. The check for that is based on
> what is
On Wed, 13 Dec 2023 16:20:58 GMT, Markus KARG wrote:
> > It doesn't make sense here to add a new package com.sun.io for a single
> > method class. This PR does not need to introduce any new classes at this
> > point. I think this PR needs to focus solely on BIS.
>
> So you actually prefer
On Wed, 13 Dec 2023 15:53:09 GMT, Alan Bateman wrote:
> It doesn't make sense here to add a new package com.sun.io for a single
> method class. This PR does not need to introduce any new classes at this
> point. I think this PR needs to focus solely on BIS.
So you actually prefer
My immediate interest is symlinks.
Alan
> On Dec 13, 2023, at 1:55 AM, Alan Bateman wrote:
>
> On 12/12/2023 20:17, Alan Snyder wrote:
>> ZipEntry is a public class and I am aware that it is used outside the JDK.
>> Presumably that is not a problem.
>>
>> I’m wondering why the class stores
On Wed, 13 Dec 2023 10:01:30 GMT, Alan Bateman wrote:
>> So what is the target package for this utility class?
>
>> So what is the target package for this utility class?
>
> If you really want a utility class then a non-public class in java.io is
> okay. However, I think the starting point for
On Wed, 13 Dec 2023 10:01:30 GMT, Alan Bateman wrote:
>> So what is the target package for this utility class?
>
>> So what is the target package for this utility class?
>
> If you really want a utility class then a non-public class in java.io is
> okay. However, I think the starting point for
On Wed, 13 Dec 2023 11:39:19 GMT, Aleksei Voitylov
wrote:
>> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
>> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
>> the last elements of the source codepoints array are stripped from the
>>
On Wed, 13 Dec 2023 11:39:29 GMT, Aleksei Voitylov
wrote:
> If you think it's worth it, I can go through some tests and add some more
> -XX:-CompactStrings mode to java.lang.String tests here and there, lightly.
> It's not the first time we hit this issue.
Verifying the coverage of the tests
On Wed, 13 Dec 2023 11:39:19 GMT, Aleksei Voitylov
wrote:
>> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
>> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
>> the last elements of the source codepoints array are stripped from the
>>
On Wed, 13 Dec 2023 07:08:53 GMT, David Holmes wrote:
>> Improve the test by being more lenient to related code cache exhaustion
>> errors. The important thing is that we don't terminate with a fatal error,
>> which the new code now checks for explicitly. The check for that is based on
>>
On Tue, 12 Dec 2023 19:11:43 GMT, Roger Riggs wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/java/lang/String/Chars.java line 50:
>
>> 48: testChars(cc, ccExp);
>>
On Wed, 13 Dec 2023 11:39:19 GMT, Aleksei Voitylov
wrote:
>> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
>> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
>> the last elements of the source codepoints array are stripped from the
>>
> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
> the last elements of the source codepoints array are stripped from the
> resulting UTF16 string, which fires in other places (e.g. during
On Wed, 13 Dec 2023 09:47:50 GMT, Sergey Tsypanov wrote:
> So what is the target package for this utility class?
If you really want a utility class then a non-public class in java.io is okay.
However, I think the starting point for this change is not the utility class,
it's about deciding
On 12/12/2023 20:17, Alan Snyder wrote:
ZipEntry is a public class and I am aware that it is used outside the JDK.
Presumably that is not a problem.
I’m wondering why the class stores the external file attributes field but does
not provide public accessors for it.
I would find it useful to
On Tue, 12 Dec 2023 17:33:12 GMT, Srinivas Vamsi Parasa
wrote:
>> @vamsi-parasa You said:
>>> Made sure that OpenJDK builds without errors using both GCC 7.5 and GCC 6.4.
>>
>> but now we have https://bugs.openjdk.org/browse/JDK-8321688. Did you
>> introduce any changes after you tested with
On Wed, 13 Dec 2023 09:09:29 GMT, Alan Bateman wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Fix JavaDoc
>
> src/java.base/share/classes/com/sun/io/IOStreams.java line 26:
>
>> 24: */
>> 25:
>>
On Wed, 13 Dec 2023 08:15:21 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>>
On Wed, 13 Dec 2023 08:41:37 GMT, Vladimir Sitnikov
wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Fix JavaDoc
>
> test/jdk/java/io/BufferedInputStream/TransferToTrusted.java line 52:
>
>> 50:
On Wed, 13 Dec 2023 08:04:59 GMT, Markus KARG wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Whitespaces
>
> src/java.base/share/classes/com/sun/io/IOStreams.java line 53:
>
>> 51: public static
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
On Thu, 7 Dec 2023 07:53:58 GMT, Adam Sotona wrote:
>> ClassFile API throws `IndexOutOfBoundsException` when classfile structure is
>> corrupted so the parser attempts to read beyond the classfile bounds.
>> General contract is that only `IllegalArgumentException` or its subclasses
>> is
On Mon, 11 Dec 2023 10:19:52 GMT, Adam Sotona wrote:
> 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec
> contains a copy-paste error
This pull request has now been integrated.
Changeset: a55e18ba
Author:Adam Sotona
URL:
On Wed, 13 Dec 2023 08:15:21 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>>
On Tue, 12 Dec 2023 20:18:15 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>>
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
On Tue, 12 Dec 2023 20:18:15 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>>
On Mon, 11 Dec 2023 10:19:52 GMT, Adam Sotona wrote:
> 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec
> contains a copy-paste error
Marked as reviewed by alanb (Reviewer).
-
PR Review:
On Mon, 11 Dec 2023 20:09:09 GMT, Sergey Tsypanov wrote:
>> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 212:
>>
>>> 210: // 'tmpbuf' is null if and only if 'out' is trusted
>>> 211: byte[] tmpbuf;
>>> 212: if (IOStreams.isTrusted(out))
79 matches
Mail list logo
