On Wed, 1 Oct 2025 17:22:39 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version.
On Fri, 3 Oct 2025 09:50:23 GMT, Pavel Rappo wrote:
>> We have [recently discussed][] a possibility of adding the `Duration.MIN`
>> and `Duration.MAX` constants. Can we now start implementation? If and when
>> we are in agreement on this PR, I will file a CSR.
>>
>> I drafted a minimal specifi
On Wed, 8 Oct 2025 14:04:16 GMT, Roger Riggs wrote:
>> I also wonder if close of streams should happen after first wait on destroy
>> or on interruption. I'm thinking the difference is that streams would still
>> be usable to fetch buffered data.
>
> Looping co
On Wed, 8 Oct 2025 14:11:28 GMT, Chen Liang wrote:
> Given this patch obviously has so many performance optimization
> opportunities, I recommend handling those in subsequent RFEs so that we can
> review this purely from a specification point of view.
There is adequate time before RPD1 (Dec 4,
On Wed, 8 Oct 2025 13:59:39 GMT, Jason Mehrens wrote:
>> src/java.base/share/classes/java/lang/Process.java line 235:
>>
>>> 233: destroyForcibly();
>>> 234: // Re-assert the interrupt
>>> 235: Thread.currentThread().interrupt();
>>
>> I think thi
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
b
On Fri, 3 Oct 2025 19:56:22 GMT, Xueming Shen wrote:
> ### Summary
>
> Case folding is a key operation for case-insensitive matching (e.g., string
> equality, regex matching), where the goal is to eliminate case distinctions
> without applying locale or language specific conversions.
>
> Curr
ested by IntelliJ, if the advice should not be taken,
> I'll revert and update the IDE settings.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Fix indentation on method declarations
-
Changes:
- all: https://g
ested by IntelliJ, if the advice should not be taken,
> I'll revert and update the IDE settings.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove a unnecessary `public` access in StringUTF16.java
-
Changes:
-
On Tue, 5 Aug 2025 01:42:53 GMT, Shaojin Wen wrote:
> The DateTimeFormatterBuilder::FIELD_MAP is of type Map TemporalField>, with key values in the range 'A-Z' and 'a-z'.
>
> We can change the type of FIELD_MAP to an array of length 128 and then use
> char as an index to access the array.
>
>
On Thu, 2 Oct 2025 16:02:56 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to insensitive.
>
> src/java.base/share/classes/java/lang/StringLatin1.jav
On Thu, 2 Oct 2025 16:58:41 GMT, Justin Lu wrote:
>> Please review this PR which case folds grandfathered BCP47 tags on demand.
>> (Instead of keeping the case compliant versions stored.)
>>
>> This facilitates the cleanup of the `LEGACY` map (which contains a String to
>> String Array mapping
On Thu, 2 Oct 2025 03:08:32 GMT, Shaojin Wen wrote:
>> I propose to make j.t.f.DateTimePrintContext immutable.
>>
>> Currently, DateTimePrintContext has only one mutable field, optional. This
>> can be replaced by adding an optional parameter to the
>> DateTimeFormatter.formatTo method.
>>
>>
ested by IntelliJ, if the advice should not be taken,
> I'll revert and update the IDE settings.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Revert to insensitive.
-
Changes:
- all: https://git.openjdk.org
Code cleanup in java.lang.StringLatin1 and StringUTF16.
Remove the `public` qualifier from methods where it is not needed.
Remove an unused toBytes method.
Remove unused codePointXXX methods.
Remove unnecessary casts of primitive types.
Some of these are suggested by IntelliJ, if the advice should
On Thu, 2 Oct 2025 03:08:32 GMT, Shaojin Wen wrote:
>> I propose to make j.t.f.DateTimePrintContext immutable.
>>
>> Currently, DateTimePrintContext has only one mutable field, optional. This
>> can be replaced by adding an optional parameter to the
>> DateTimeFormatter.formatTo method.
>>
>>
On Wed, 1 Oct 2025 22:51:30 GMT, Justin Lu wrote:
>> Please review this PR which case folds grandfathered BCP47 tags on demand.
>> (Instead of keeping the case compliant versions stored.)
>>
>> This facilitates the cleanup of the `LEGACY` map (which contains a String to
>> String Array mapping
On Wed, 1 Oct 2025 22:31:42 GMT, Sergey Bylokhov wrote:
> Please review the application of the `@Serial` annotation
> ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the
> java.scripting module to enable stricter compile-time checking of
> serialization-related declara
On Thu, 2 Oct 2025 03:08:32 GMT, Shaojin Wen wrote:
>> I propose to make j.t.f.DateTimePrintContext immutable.
>>
>> Currently, DateTimePrintContext has only one mutable field, optional. This
>> can be replaced by adding an optional parameter to the
>> DateTimeFormatter.formatTo method.
>>
>>
On Tue, 30 Sep 2025 15:01:14 GMT, Jaikiran Pai wrote:
>> I think those warnings are already present.
>> - `process is terminated without waiting`
>> - `the caller should read the streams for any data or text and call waitFor
>> if the exit value is needed`
>> - `Calling waitFor before calling cl
On Mon, 29 Sep 2025 15:08:14 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Tue, 23 Sep 2025 10:04:03 GMT, Kieran Farrell wrote:
>> @kieran-farrell Is there a last-minute plan to make use of `nextLong()` as
>> suggested by @RogerRiggs?
>> Otherwise looks good
>
> Thanks @rgiulietti, the need for a nextLong() API existed whenwe were using
> higher percision bits in t
On Sun, 28 Sep 2025 08:50:40 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update close() to use "terminate" consistently.
>
> test/jdk/java/lang/Process
> Instead of raising the timeout, leave the execution of the -Xcomp tests to
> higher tiers in the CI.
> Remove the explicit -Xcomp run.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
There is no need for an explicit ext
On Wed, 27 Aug 2025 19:18:17 GMT, Chen Liang wrote:
>> As another step toward the removal of the old generics infrastructure, I
>> propose to remove the usages of generic parsing utilities and use the
>> facilities provided by BytecodeDescriptor, already used by
>> MethodType.fromDescriptorStr
On Thu, 25 Sep 2025 20:28:31 GMT, Roger Riggs wrote:
> TreeTest failure is intermittent, getting the complete output may help with
> the diagnosis.
>
> Add maxOutputSize for ProcessHandle TEST.properties for the directory of
> ProcessHandle tests.
This pull request has now
On Thu, 25 Sep 2025 20:28:31 GMT, Roger Riggs wrote:
> TreeTest failure is intermittent, getting the complete output may help with
> the diagnosis.
>
> Add maxOutputSize for ProcessHandle TEST.properties for the directory of
> ProcessHandle tests.
I bumped up the maxOutput
On Mon, 22 Sep 2025 08:13:55 GMT, Alan Bateman wrote:
> The no-arg Thread.stop has been deprecated since JDK 1.2, deprecated for
> removal since JDK 18, and re-specified to throw UOE unconditionally since JDK
> 20. It is time to finally remove the method. Its more evil sibling
> Thread.stop(Th
On Mon, 22 Sep 2025 18:22:36 GMT, Roger Riggs wrote:
> 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception:
> Stack trace
> With MacOsX Sequoia 15.7 the command environment contains a new TMPDIR
> variable.
> The ProcessBuild/Basic test checks for
On Wed, 10 Sep 2025 19:46:12 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
TreeTest failure is intermittent, getting the complete output may help with the
diagnosis.
Add maxOutputSize for ProcessHandle TEST.properties for the directory of
ProcessHandle tests.
-
Commit messages:
- 8368683: [process] Increase jtreg debug output maxOutputSize for TreeTest
On Wed, 10 Sep 2025 19:46:12 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Tue, 23 Sep 2025 14:43:19 GMT, Thomas Stuefe wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify the code to match and remove expected environment variables on
>>
es variables that are set by the OS or runtime, now including TMPDIR.
>
> In the Basic test, for MacOSX, checks of the environment in the child should
> ignore TMPDIR in addition
> to the other existing environment variables that are expected.
Roger Riggs has updated the pull request
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Update close() to use "terminate" consist
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove volatile from "closed&qu
On Sun, 21 Sep 2025 00:18:59 GMT, Guanqiang Han wrote:
>> Please review this patch.
>>
>> **Description:**
>>
>> Currently, ModifiedUtf.utfLen returns a signed int. For very large strings,
>> this may overflow and produce negative values, leading to incorrect behavior
>> in code that relies o
es variables that are set by the OS or runtime, now including TMPDIR.
>
> In the Basic test, for MacOSX, checks of the environment in the child should
> ignore TMPDIR in addition
> to the other existing environment variables that are expected.
Roger Riggs has updated the pull request
On Mon, 22 Sep 2025 09:38:49 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> The CSR review prompted the expansion of the description of
>> responsibilities
&g
8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception:
Stack trace
With MacOsX Sequoia 15.7 the command environment contains a new TMPDIR variable.
The ProcessBuild/Basic test checks for a small set of variables set in the
parent
and ignores variables that are set by the OS o
On Sun, 21 Sep 2025 10:31:06 GMT, Tagir F. Valeev wrote:
>> Please review this small change. If you have more ideas which classes may
>> miss specializations of SequencedCollection methods, I can add them to this
>> PR as well.
>
> Tagir F. Valeev has updated the pull request incrementally with
On Wed, 17 Sep 2025 12:50:56 GMT, SendaoYan wrote:
> Hi all,
>
> After [JDK-8260555](https://bugs.openjdk.org/browse/JDK-8260555) changed the
> default TIMEOUT_FACTOR from 4 to 1, test java/io/FileDescriptor/Sync.java
> intermittent timed out when run with other test simultancely.
>
> If I ru
Problem list test/jdk/java/lang/ProcessBuilder/Basic.java#id0 until it can be
fixed.
It is likely due to an upgrade in macosx but need to be addressed.
See: [JDK-8368192 Test java/lang/ProcessBuilder/Basic.java#id0 fails with
Exception: Stack trace](https://bugs.openjdk.org/browse/JDK-8368192)
On Mon, 22 Sep 2025 14:57:34 GMT, Roger Riggs wrote:
> Problem list test/jdk/java/lang/ProcessBuilder/Basic.java#id0 until it can be
> fixed.
> It is likely due to an upgrade in macosx but need to be addressed.
>
> See: [JDK-8368192 Test java/lang/ProcessBuilder/Basic.java
On Mon, 22 Sep 2025 14:57:34 GMT, Roger Riggs wrote:
> Problem list test/jdk/java/lang/ProcessBuilder/Basic.java#id0 until it can be
> fixed.
> It is likely due to an upgrade in macosx but need to be addressed.
>
> See: [JDK-8368192 Test java/lang/ProcessBuilder/Basic.java
On Tue, 16 Sep 2025 17:10:18 GMT, Pavel Rappo wrote:
>> Please review this documentation-only change, which I believe does **NOT**
>> require CSR.
>>
>> The change touches java.time.** classes that I happen to have been using a
>> lot recently. While the diff is pretty self-describing, here's
On Sat, 23 Aug 2025 11:27:55 GMT, Shaojin Wen wrote:
> I propose to make j.t.f.DateTimePrintContext immutable.
>
> Currently, DateTimePrintContext has only one mutable field, optional. This
> can be replaced by adding an optional parameter to the
> DateTimeFormatter.formatTo method.
>
> Immut
On Fri, 19 Sep 2025 13:10:33 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
The CSR review prompted the expansion of the description
On Thu, 14 Aug 2025 11:49:15 GMT, Jaikiran Pai wrote:
>> Kieran Farrell has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update note to @api note
>
> Hello Kieran,
>
>> Hi All, Would it be possible to progress review with this?
>
> I h
On Mon, 15 Sep 2025 05:37:58 GMT, Guanqiang Han wrote:
> trivial fix
Looks good.
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27280#pullrequestreview-3224763568
On Mon, 15 Sep 2025 21:18:12 GMT, Justin Lu wrote:
> During parse routines, DecimalFormat uses DigitList to append digits from the
> parsed text.
>
> Note that `digit` is always the int value 0 through 9 (and subsequently the
> code point 48 through 57) when passed to `append`.
>
> Currently,
On Thu, 18 Sep 2025 21:25:13 GMT, Roger Riggs wrote:
> Propagate [backout] Change java.time month/day field types to 'byte' to jdk
> 25.
> Previously reviewed as: https://github.com/openjdk/jdk/pull/27346
Wrong backport target.
-
PR Comment: https://git.openjdk
On Thu, 18 Sep 2025 21:25:13 GMT, Roger Riggs wrote:
> Propagate [backout] Change java.time month/day field types to 'byte' to jdk
> 25.
> Previously reviewed as: https://github.com/openjdk/jdk/pull/27346
This pull request has been closed without being integrated.
-
Propagate [backout] Change java.time month/day field types to 'byte' to jdk 25.
Previously reviewed as: https://github.com/openjdk/jdk/pull/27346
-
Commit messages:
- Backport 0756ecb214b8ab76cb69f354063d153b72f978c2
Changes: https://git.openjdk.org/jdk/pull/27375/files
Webrev: ht
On Thu, 18 Sep 2025 12:49:50 GMT, Guanqiang Han wrote:
>> Please review this patch.
>>
>> **Description:**
>>
>> Currently, ModifiedUtf.utfLen returns a signed int. For very large strings,
>> this may overflow and produce negative values, leading to incorrect behavior
>> in code that relies o
On Wed, 17 Sep 2025 13:39:18 GMT, Roger Riggs wrote:
> This reverts commit 4ced4e73fc0a517df826860839681004bb67e624.
>
> Restore the previous field types to maintain compatibility with previous
> releases of the serialized form
> of classes of java.time.
> The classes reve
On Sun, 7 Sep 2025 14:50:56 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
This reverts commit 4ced4e73fc0a517df826860839681004bb67e624.
Restore the previous field types to maintain compatibility with previous
releases of the serialized form
of classes of java.time.
The classes reverted are LocalDate, MonthDay, YearMonth, and HijrahDate.
-
Commit message
On Wed, 17 Sep 2025 13:39:18 GMT, Roger Riggs wrote:
> This reverts commit 4ced4e73fc0a517df826860839681004bb67e624.
>
> Restore the previous field types to maintain compatibility with previous
> releases of the serialized form
> of classes of java.time.
> The classes reve
On Mon, 15 Sep 2025 07:32:13 GMT, Guanqiang Han wrote:
> Please review this patch.
>
> **Description:**
>
> Currently, ModifiedUtf.utfLen returns a signed int. For very large strings,
> this may overflow and produce negative values, leading to incorrect behavior
> in code that relies on the U
On Wed, 17 Sep 2025 13:39:18 GMT, Roger Riggs wrote:
> This reverts commit 4ced4e73fc0a517df826860839681004bb67e624.
>
> Restore the previous field types to maintain compatibility with previous
> releases of the serialized form
> of classes of java.time.
> The classes reve
On Wed, 17 Sep 2025 16:19:31 GMT, Aleksey Shipilev wrote:
>>> Is this a straight backout of
>>> [4ced4e7](https://github.com/openjdk/jdk/commit/4ced4e73fc0a517df826860839681004bb67e624)?
>>> Shouldn't this be `[BACKOUT] ...` issue then?
>>
>> Yes, it is a straight backout; I can add the [backo
On Wed, 17 Sep 2025 15:10:49 GMT, Pavel Rappo wrote:
>> Please review this documentation-only change, which I believe does **NOT**
>> require CSR.
>>
>> The change touches java.time.** classes that I happen to have been using a
>> lot recently. While the diff is pretty self-describing, here's
On Wed, 17 Sep 2025 14:08:52 GMT, David Lloyd wrote:
> Would it not have been sufficient to add a `serialPersistentFields` which
> defines the fields as their "old" types?
Using serialPersistenFields is an option; but to correct the regression, it was
cleaner to just revert/backout the change.
On Wed, 17 Sep 2025 14:08:51 GMT, Alan Bateman wrote:
> Are you planning to add tests to catch this sort of issue, even if only for
> the classes in java.time for now, or are you thinking about a follow-up issue?
I'm working on a new test to serialize classes to an archive and compare the
arch
On Tue, 16 Sep 2025 21:55:36 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/time/Duration.java line 480:
>>
>>> 478: *
>>> 479: * The result of this method can be a negative duration if the end
>>> is before the start.
>>> 480: * To guarantee a positive or zero dura
On Wed, 17 Sep 2025 13:39:18 GMT, Roger Riggs wrote:
> This reverts commit 4ced4e73fc0a517df826860839681004bb67e624.
>
> Restore the previous field types to maintain compatibility with previous
> releases of the serialized form
> of classes of java.time.
> The classes reve
On Tue, 16 Sep 2025 17:10:18 GMT, Pavel Rappo wrote:
>> Please review this documentation-only change, which I believe does **NOT**
>> require CSR.
>>
>> The change touches java.time.** classes that I happen to have been using a
>> lot recently. While the diff is pretty self-describing, here's
On Tue, 16 Sep 2025 17:10:18 GMT, Pavel Rappo wrote:
>> Please review this documentation-only change, which I believe does **NOT**
>> require CSR.
>>
>> The change touches java.time.** classes that I happen to have been using a
>> lot recently. While the diff is pretty self-describing, here's
On Tue, 16 Sep 2025 13:01:34 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Tue, 16 Sep 2025 13:30:40 GMT, Matthias Baesken wrote:
> Similar to JDK-8367138 , we should add a JNI exception check to
> os_getCmdlineAndUserInfo on AIX .
looks good. Thanks
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27313#pullreq
On Mon, 15 Sep 2025 21:18:12 GMT, Justin Lu wrote:
> During parse routines, DecimalFormat uses DigitList to append digits from the
> parsed text.
>
> Note that `digit` is always the int value 0 through 9 (and subsequently the
> code point 48 through 57) when passed to `append`.
>
> Currently,
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Monor improvements to javadoc, move close() near the con
On Thu, 11 Sep 2025 12:13:04 GMT, Magnus Ihse Bursie wrote:
>> In the static JDK image, a single humongous java executable is generated,
>> and no other launcher, such as javac. This makes it impossible to run our
>> jtreg tests, which assume these are present.
>>
>> The solution is fortunatel
On Mon, 15 Sep 2025 16:35:49 GMT, Alan Bateman wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove debug code
>
> src/java.base/windows/native/launcher/relauncher.c line 40:
>
>> 38: static char* launcher
On Sat, 13 Sep 2025 09:35:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses the issue noted in
>> https://bugs.openjdk.org/browse/JDK-8367597?
>>
>> As noted in that issue, on certain occasions, during shutdown of the JVM,
>> the logging in `Runtime.exit(
On Wed, 10 Sep 2025 19:46:12 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Tue, 9 Sep 2025 01:05:37 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
On Wed, 10 Sep 2025 19:57:56 GMT, Kieran Farrell wrote:
>> test/jdk/java/util/UUID/UUIDTest.java line 52:
>>
>>> 50: unixEpochTimeMillisTest();
>>> 51: unixEpochTimeMillisTest_Multi();
>>> 52: unixEpochTimeMillis_userInputTest();
>>
>> Also rename the tests to use the `e
On Wed, 10 Sep 2025 21:03:32 GMT, Roger Riggs wrote:
> JNI exception pending in os_getCmdlineAndUserInfo of
> ProcessHandleImpl_macosx.c:306
> Minor cleanup of a missing check for exception pending.
This pull request has now been integrated.
Changeset: 56f2f7a3
Author: Roger R
JNI exception pending in os_getCmdlineAndUserInfo of
ProcessHandleImpl_macosx.c:306
Minor cleanup of a missing check for exception pending.
-
Commit messages:
- 8367138: JNI exception pending in os_getCmdlineAndUserInfo of
ProcessHandleImpl_macosx.c:306
Changes: https://git.openjd
On Wed, 10 Sep 2025 22:05:26 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Thu, 11 Sep 2025 00:34:00 GMT, David Beaumont wrote:
>> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 379:
>>
>>> 377: // exist, so it skips checking the nodes cache and only
>>> checks for
>>> 378: // an ImageLocation.
>>> 379: if
On Sat, 6 Sep 2025 20:44:55 GMT, Saint Wesonga wrote:
> This test fails with errors like
> >'=C:=,=ExitValue=3,PROCESSOR_ARCHITECTURE=ARM64,SystemRoot=C:\Windows,'< not
> equal to '=C:=,=ExitValue=3,SystemRoot=C:\Windows,'
>
> The test does not expect the PROCESSOR_ARCHITECTURE variable to be
On Thu, 4 Sep 2025 11:22:31 GMT, Volkan Yazici wrote:
>> [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused
>> `tier1` failures, and hence, backed out in [JDK-8366693] (#27050). This PR
>> reintroduces JDK-8356439 with sufficient fixes.
>>
>> [JDK-8356439]: https://bugs.open
On Thu, 3 Jul 2025 09:53:30 GMT, Kieran Farrell wrote:
>> src/java.base/share/classes/java/util/UUID.java line 212:
>>
>>> 210: * @since 26
>>> 211: */
>>> 212: public static UUID unixEpochTimeMillis() {
>>
>> Is there a list anywhere on the names that have been discussed already?
On Thu, 4 Sep 2025 22:03:51 GMT, Justin Lu wrote:
> This PR cleans up the existing DecimalFormatSymbols, DecimalFormat, and
> NumberFormat serialization tests.
>
> As mentioned in https://github.com/openjdk/jdk/pull/27008 these tests can be
> re-visited.
>
> These older tests are either not r
On Wed, 9 Jul 2025 02:58:28 GMT, Sergey Bylokhov wrote:
> Please review the application of the `@Serial` annotation
> ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the
> java.logging module to enable stricter compile-time checking of
> serialization-related declarati
On Thu, 4 Sep 2025 22:03:51 GMT, Justin Lu wrote:
> This PR cleans up the existing DecimalFormatSymbols, DecimalFormat, and
> NumberFormat serialization tests.
>
> As mentioned in https://github.com/openjdk/jdk/pull/27008 these tests can be
> re-visited.
>
> These older tests are either not r
On Thu, 4 Sep 2025 12:28:15 GMT, David Lloyd wrote:
>> `DestroyForcibly` is an escalation that should only be used with a known
>> poorly behaved process; and that's up to the programmer. It is the
>> equivalent of `kill -9`.
>> It should not be used in the normal case. Unfortunately, Windows d
On Thu, 3 Jul 2025 08:47:20 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version.
es.
>
> The actions of the `close()` method are to close each stream and destroy the
> process if it has not terminated.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
b
On Wed, 3 Sep 2025 17:06:32 GMT, Naoto Sato wrote:
>> Adding a `@throws` clause for NPE in `java.text.DateFormatSymbols(Locale)`
>> constructor. The bug suggests it should throw a `MissingResourceException`,
>> but I don't think we can change this long standing behavior. Instead,
>> explicitl
On Tue, 20 May 2025 19:25:13 GMT, Philippe Marschall wrote:
>> Kieran Farrell has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available.
>
> src/java.base/share/classes/java/util/UUID.java line 242:
>
>> 240: ns['C']
On Thu, 4 Sep 2025 13:22:08 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
On Thu, 4 Sep 2025 14:40:36 GMT, Chen Liang wrote:
>> Guanqiang Han has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commits sin
Hi,
I'd be interested in the range of use cases for Duration.MAX or MIN.
But for deadlines, I think the code should compute the deadline from a
Duration of its choice based on the use.
Maybe there is a use for Duration.REALLY_BIG or _SMALL, but that ignores
information about the particular use
On Fri, 29 Aug 2025 08:49:27 GMT, David Beaumont wrote:
>> This PR addresses several issues found while adding unit tests for
>> ExplodedImage.
>> I have added review comments for changes (some of which are a little
>> preferential, but bring the code into line with things like ImageReader in
On Wed, 3 Sep 2025 19:00:26 GMT, David Lloyd wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc tweaks
>
> src/java.base/share/classes/java/lang/Process.java line 664:
>
>
1 - 100 of 1911 matches
Mail list logo
