RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

> -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Hi Frank, > > On 14/02/17 13:43, Frank Yuan wrote: > > > >> -Original Message- > >> From: Daniel Fuchs

RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

Hi, Please review the test change for JDK-8174248 issue: https://bugs.openjdk.java.net/browse/JDK-8174248 webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev The change is to simply rename the entry name from "IAmNotTheEntryPoint" to a "packaged" one as "

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Thanks Lance, Daniel! -Joe On 2/14/2017 10:53 AM, Lance Andersen wrote: Looks good… ship it. On Feb 14, 2017, at 1:41 PM, Daniel Fuchs > wrote: On 14/02/17 17:21, huizhe wang wrote: Thanks! Here's an updated webrev:

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Looks good to me as well. For the CR and LF question, XML processors are required by the specification to normalize and translate both CRLF sequence and any CR not followed by LF to a single LF. For that reason, you don't have check CR since the content the serializer gets is parsed. Best,

Re: RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

> On 14 Feb 2017, at 19:09, Xueming Shen wrote: > > Hi, > > Please review the test change for JDK-8174248 > > issue: https://bugs.openjdk.java.net/browse/JDK-8174248 > webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev Looks fine Sherman. -Chris. > The

Re: RFR JDK-8174248: partialUpdateFooMainClass test in tools/jar/modularJar/Basic.java needs to be re-examined

Looks fine Sherman.. > On Feb 14, 2017, at 2:09 PM, Xueming Shen wrote: > > Hi, > > Please review the test change for JDK-8174248 > > issue: https://bugs.openjdk.java.net/browse/JDK-8174248 > webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev > > The change

RFR(XS): 8174950: Gracefully handle null Supplier in Objects.requireNonNull

Hi, can I please have another review for the following trivial fix: http://cr.openjdk.java.net/~simonis/webrevs/2017/8174950/ https://bugs.openjdk.java.net/browse/JDK-8174950 This change has already been discussed in length on the mailing list:

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Looks good… ship it. > On Feb 14, 2017, at 1:41 PM, Daniel Fuchs wrote: > > On 14/02/17 17:21, huizhe wang wrote: >> Thanks! >> >> Here's an updated webrev: >> http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ > > +1 > > -- daniel > >> >> -Joe >> >> On

Re: RFR(XS): 8174950: Gracefully handle null Supplier in Objects.requireNonNull

On 14 Feb 2017, at 18:52, Volker Simonis wrote: > > Hi, > > can I please have another review for the following trivial fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2017/8174950/ Looks good. -Chris.

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

On 14/02/17 17:21, huizhe wang wrote: Thanks! Here's an updated webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ +1 -- daniel -Joe On 2/14/2017 4:07 AM, Lance Andersen wrote: Looks good overall Joe. I would agree that I would clean up the minor comment alignment issues.

Re: RFR 8174151: URLClassLoader no longer uses custom URLStreamHandler for jar URLs

> On 14 Feb 2017, at 18:37, Paul Sandoz wrote: > >> >> On 14 Feb 2017, at 05:58, Chris Hegarty wrote: >> >> >>> On 13 Feb 2017, at 22:52, Paul Sandoz wrote: >>> >>> Hi, >>> >>> Please review. >>> >>>

[9] RFR: 8174779: Locale issues with Mac 10.12

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8174779 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8174779/webrev.01/ The root cause of the problem was that starting from macOS 10.12, it returns the preferred user language

RFR: 8174735 Update JAX-WS RI integration to latest version

Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/ You can find change list in the description of JBS and its linked issues. Most diffs are

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Looks good overall Joe. I would agree that I would clean up the minor comment alignment issues. Best Lance > On Feb 13, 2017, at 9:27 PM, huizhe wang wrote: > > A quick fix for the error parsing xml declaration. This is one of the three > outstanding issues in the xml

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

On 02/14/2017 01:05 PM, Alan Bateman wrote: Is the webrev missing the update to java.base's module-info.java? I assume we can drop the exporting of sun.reflect.misc to java.xml.ws. Thanks Alan, Mandy's patch for jaxws own MethodUtil is integrated, so sun.reflect.misc export should now be

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Looks good Joe. I wonder about this though (which may be an issue for another time): 102 [25] Eq ::= S? '=' S? Do we support space (new line?) before and after the '=' sign? best regards, -- daniel On 14/02/17 02:27, huizhe wang wrote: A quick fix for the error parsing xml

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

On 14/02/2017 12:00, Roman Grigoriadi wrote: Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/ You can find change list in the

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Hi Joe As you suggested, I made pretty-print a little better based on the fix. That is when adding indentation, just check the beginning character(s), in case of '\n' or '\r' then, ignore it/them. Please check the new webrev: http://cr.openjdk.java.net/~fyuan/8174025/webrev.01/ Thanks Frank

Re: RFR 8174151: URLClassLoader no longer uses custom URLStreamHandler for jar URLs

On 13/02/2017 22:52, Paul Sandoz wrote: Hi, Please review. http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8174151-url-class-path-loader/webrev/index.html This is a nasty edge case when a URLStreamHandler is registered (via the system property) to process jar: URLs. The support for

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Hi Frank, Should you skip '\r' if it's not followed by '\n'? best regards, -- daniel On 14/02/17 10:33, Frank Yuan wrote: Hi Joe As you suggested, I made pretty-print a little better based on the fix. That is when adding indentation, just check the beginning character(s), in case of '\n'

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

On 14/02/2017 12:28, Roman Grigoriadi wrote: On 02/14/2017 01:05 PM, Alan Bateman wrote: Is the webrev missing the update to java.base's module-info.java? I assume we can drop the exporting of sun.reflect.misc to java.xml.ws. Thanks Alan, Mandy's patch for jaxws own MethodUtil is integrated,

Re: RFR 8174151: URLClassLoader no longer uses custom URLStreamHandler for jar URLs

> On 13 Feb 2017, at 22:52, Paul Sandoz wrote: > > Hi, > > Please review. > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8174151-url-class-path-loader/webrev/index.html If I understand this correctly then the only optimisation ( by-pass of openConnection ),

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

> -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Hi Frank, > > Should you skip '\r' if it's not followed by '\n'? > Does it matter? Since XML processor should

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Thanks! Here's an updated webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ -Joe On 2/14/2017 4:07 AM, Lance Andersen wrote: Looks good overall Joe. I would agree that I would clean up the minor comment alignment issues. Best Lance On Feb 13, 2017, at 9:27 PM, huizhe wang

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

On 2/14/2017 3:16 AM, Daniel Fuchs wrote: Looks good Joe. I wonder about this though (which may be an issue for another time): 102 [25] Eq ::= S? '=' S? Do we support space (new line?) before and after the '=' sign? Yes, we do. I've added a couple of test cases to cover

RE: jdk10 : simplify jexec build settings

Hello, here is the webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/ bug : https://bugs.openjdk.java.net/browse/JDK-8174242 As discussed , I deleted the macosx jexec.c. Btw. I found out that jexec does not work (fully?) in jdk8 / 9 ( seems this has to do with

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

Thanks Christoph. Will fix those comments. -Joe On 2/13/2017 11:56 PM, Langer, Christoph wrote: Hi Joe, this looks right to me, quite straightforward. I just have some formatting nits for the test: 1. Line 107 (XMLInputFactory xif=): space missing before '=' 2. Method comments on test

Re: jdk10 : simplify jexec build settings

Hello, Looks good to me. Fixing jexec is a separate issue and not really build related. /Erik On 2017-02-14 17:27, Baesken, Matthias wrote: Hello, here is the webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/ bug :

Re: RFR 8174151: URLClassLoader no longer uses custom URLStreamHandler for jar URLs

> On 14 Feb 2017, at 05:58, Chris Hegarty wrote: > > >> On 13 Feb 2017, at 22:52, Paul Sandoz wrote: >> >> Hi, >> >> Please review. >> >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8174151-url-class-path-loader/webrev/index.html > > If I

Re: RFR(XS): 8174950: Gracefully handle null Supplier in Objects.requireNonNull

+1 Paul. > On 14 Feb 2017, at 10:52, Volker Simonis wrote: > > Hi, > > can I please have another review for the following trivial fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2017/8174950/ > https://bugs.openjdk.java.net/browse/JDK-8174950 > > This change

JDK 9 RFR of JDK-8174960: Mark WakeupAfterClose.java as failing intermittentl

Hello, The test java/nio/channels/Selector/WakeupAfterClose.java has been seen to fail intermittently at a low frequency (JDK-8143614). The test should be marked accordingly; patch below. Thanks, -Joe --- a/test/java/nio/channels/Selector/WakeupAfterClose.java Mon Feb 13 11:35:00 2017

RFR 8165035 jar --help-extra should provide information on the -n/--normalize option

Hi, Please review this minor fix to the --help-extra option to to report the -n/--normalize option: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8165035-jar-tool-n/webrev/ It will report the following (and will be formatted correctly for a fixed width font): " Operation modifiers valid

Re: RFR 8165035 jar --help-extra should provide information on the -n/--normalize option

Looks ok Paul... > On Feb 14, 2017, at 3:45 PM, Paul Sandoz wrote: > > Hi, > > Please review this minor fix to the --help-extra option to to report the > -n/--normalize option: > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8165035-jar-tool-n/webrev/ > > It will

Re: RFR(XS): 8174950: Gracefully handle null Supplier in Objects.requireNonNull

On 14/02/2017 18:52, Volker Simonis wrote: Hi, can I please have another review for the following trivial fix: http://cr.openjdk.java.net/~simonis/webrevs/2017/8174950/ https://bugs.openjdk.java.net/browse/JDK-8174950 This change has already been discussed in length on the mailing list:

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

Hi Roman, I made a pass through the changes. And here are some general comments which are mostly minor in nature…. HTH Best Lance -- JAXBRIContext.java: - The comment “If true, despite of the specification….”; This does not read well can this be clarified?

Re: [9] RFR: 8174779: Locale issues with Mac 10.12

Looks good to me, Naoto. -Brent On 02/14/2017 11:05 AM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8174779 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8174779/webrev.01/ The root cause of the problem

Re: JDK 9 RFR of JDK-8174960: Mark WakeupAfterClose.java as failing intermittentl

+1 Brian On Feb 14, 2017, at 12:16 PM, Roger Riggs wrote: > +1 > > Thanks joe > > On 2/14/2017 3:01 PM, joe darcy wrote: >> Hello, >> >> The test >> >> java/nio/channels/Selector/WakeupAfterClose.java >> >> has been seen to fail intermittently at a low frequency

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

> -Original Message- > From: huizhe wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by > JDK-8087303 > > Looks good to me as well. > > For the CR and LF question, XML processors are required by the > specification to

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Hi Joe and Daniel I tested more and checked the code, both of you are right. CRLF, CR, LF in the xml file are all normalized to LF, and finally output to the platform-related line.separator if it's serialized. The serializer only handle LF as newline. User can create CR text node

Re: RFR(XS): 8174950: Gracefully handle null Supplier in Objects.requireNonNull

Looks good to me! Thanks, David On 15/02/2017 4:52 AM, Volker Simonis wrote: Hi, can I please have another review for the following trivial fix: http://cr.openjdk.java.net/~simonis/webrevs/2017/8174950/ https://bugs.openjdk.java.net/browse/JDK-8174950 This change has already been discussed

RE: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Thank you very much for the check! Pushed. Frank > -Original Message- > From: huizhe wang [mailto:huizhe.w...@oracle.com] > Sent: Wednesday, February 15, 2017 11:35 AM > To: Frank Yuan; 'Daniel Fuchs' > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR [JAXP] JDK-8174025 Regression

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Sounds good. The change to check LF only looks good. Thanks, Joe On 2/14/2017 7:22 PM, Frank Yuan wrote: Hi Joe and Daniel I tested more and checked the code, both of you are right. CRLF, CR, LF in the xml file are all normalized to LF, and finally output to the platform-related

Re: RFR 8165035 jar --help-extra should provide information on the -n/--normalize option

On 14/02/2017 20:45, Paul Sandoz wrote: Hi, Please review this minor fix to the --help-extra option to to report the -n/--normalize option: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8165035-jar-tool-n/webrev/ It will report the following (and will be formatted correctly for a fixed

Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303

Hi Frank, On 14/02/17 13:43, Frank Yuan wrote: -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Subject: Re: RFR [JAXP] JDK-8174025 Regression in XML Transform caused by JDK-8087303 Hi Frank, Should you skip '\r' if it's not followed by '\n'? Well - I'll let