The javac part looks OK to me.
A nit comment, in:
launcher/Main.java/MemoryFileManager#createInMemoryClassFile, there is:
return new FilterOutputStream(new ByteArrayOutputStream()) { ...
It could I think be written as:
return new ByteArrayOutputStream() {
@Override
public void close() th
On Sat, Mar 31, 2018 at 12:17 AM, Brian Burkhalter
wrote:
> Hi Raffaello,
>
> On Mar 30, 2018, at 2:57 PM, raffaello.giulie...@gmail.com wrote:
>
[…]
The new code also has a better specification than the current one, while
being mostly compatible. Indeed, the current specificat
Given that patch is big, I am sending patch as attachment again after changing
some mail settings. Hopefully, it will make to community this time.
Thanks,
Bhaktavatsal Reddy
-Bhaktavatsal R Maram/India/IBM wrote: -
To: core-libs-dev@openjdk.java.net
From: Bhaktavatsal R Maram/India
No luck! :(
How can I attach patch? Any suggestions?
Thanks,
Bhaktavatsal Reddy
-Bhaktavatsal R Maram/India/IBM wrote: -
To: core-libs-dev@openjdk.java.net
From: Bhaktavatsal R Maram/India/IBM
Date: 04/13/2018 03:05PM
Subject: Re: Missing many locales support on AIX platform
Given t
On 13/04/2018 10:35, Bhaktavatsal R Maram wrote:
Given that patch is big, I am sending patch as attachment again after changing
some mail settings. Hopefully, it will make to community this time.
Your patch was attached.
If I read it correctly, you've switched IBM943C to a template but there
One small followup question - the test SourceLauncherTest is not
covering any shebang cases - is that deliberate? I see that those seem
to be covered in the launcher test too, but I wonder if we should have
tests for clearly broken stuff, such as
'#'
'#!'
'#!\n'
Another small question - I s
Hi Alan,
Thank you for your response. I'm happy that my patch was attached. But, I don't
see attachment. So, I inlined patch which contain diffs from 2 changesets in
mail text. If a Jira bug is opened for this issue, probably I can attach
complete and consolidated patch there.
At high level, I
Hi,
The question has come up before: [1]
Most OpenJDK mailing lists, ..., allow these attachment types:
text/plain
text/x-diff
text/x-patch
message/rfc822
Attachments with the following filename extensions are dropped:
exe
bat
cmd
com
pif
scr
vbs
cpl
Regards, Roger
Hi Alan, Peter,
I see that native memory is tracked in java.nio.Bits, but that only
includes what the user thinks they are allocating.
When the VM adds extra memory to the allocation amount this extra bit is
not represented in the Bits total.
A cursory glance shows, minimum, that we round the
The javadoc of InetAddress.getByName(host) and getAllByName(host) states
that:
If the host is null then an InetAddress representing an address of the
loopback interface is returned.
For non-null values the javadoc explains what the implementation does.
However, there seems to be no mention o
Hi Jaikiran,
On 13/04/18 15:29, Jaikiran Pai wrote:
The javadoc of InetAddress.getByName(host) and getAllByName(host) states
that:
If the host is null then an InetAddress representing an address of the
loopback interface is returned.
For non-null values the javadoc explains what the impleme
Hi Bhaktavatsal Reddy,
thanks for addressing this long standing issue. I've opened "8201540:
[AIX] Extend the set of supported charsets in java.base" [1] to track
this issue.
As I wrote in the bug report, this problem is the consequence of an
emergency fix (JDK-8081332) I did back in 2015 to fix
Hi Chris,
Thank you creating that JIRA.
If the fix involves just updating the javadoc, is this something that
youwould like me to contribute as a patch? I have a signed and approved
OCA, but I will need a sponsor if I do come up with the patch.
-Jaikiran
On 13/04/18 8:41 PM, Chris Hegarty
Hi Volker,
Thank you. I will take help of my colleagues and host webrev with all the
default charsets that are missing for AIX.
- Bhaktavatsal Reddy
-Volker Simonis wrote: -
To: Bhaktavatsal R Maram
From: Volker Simonis
Date: 04/13/2018 08:51PM
Cc: Alan Bateman , Java Core Libs
,
Build changes look good.
/Erik
On 2018-04-12 17:34, Naoto Sato wrote:
Hi,
Please review the fix to the subject issue. While fixing 8189784 [1],
I noticed that not only CLDR zones but also tzdb link entries are also
hard coded. So I further modified j.t.f.ZoneName to generate tzdb
entries a
Hi Naoto,
Looks fine.
Regards, Roger
On 4/12/18 8:34 PM, Naoto Sato wrote:
Hi,
Please review the fix to the subject issue. While fixing 8189784 [1],
I noticed that not only CLDR zones but also tzdb link entries are also
hard coded. So I further modified j.t.f.ZoneName to generate tzdb
entr
On 13/04/2018 15:14, Adam Farley8 wrote:
Hi Alan, Peter,
I see that native memory is tracked in java.nio.Bits, but that only
includes what the user thinks they are allocating.
When the VM adds extra memory to the allocation amount this extra bit
is not represented in the Bits total.
A cursor
Hi,
Please help review the change for JDK-8194750.
issue: https://bugs.openjdk.java.net/browse/JDK-8194750
webrev: http://cr.openjdk.java.net/~sherman/8194750/webrev
*fix has been manually verified. No new auto-regression test added.
Thanks,
Sherman
Emacs users thank you for working on this. To repro, try emacs -q, M-x
shell and run your manual test in there. You'll see stty -a reports -echo.
This is trickier than I expected, since you have to manage saving/restoring
around each call to readPassword AND have an exit hook to restore in case
Hi All,
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8184693
Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/
The related jtreg test was run and the test passed .
Regards
Vivek
20 matches
Mail list logo
