Re: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi, The change looks fine and passes the current tests. So ok to push. I think the test isn't correct, but I have not yet worked up a revised test. Thanks, Roger On 12/10/2018 09:00 AM, Lindenmaier, Goetz wrote: Hi Steve, I will push it once Roger gives his ok. Best regards, Goetz.

Re: RFR: 8212703: Remove sun.java2d.fontpath property from java launcher code

On 09/12/2018 07:59, Philip Race wrote: Here is an update with a Java-only test, using ProcessBuilder. http://cr.openjdk.java.net/~prr/8212703.1/index.html Looks okay to me. -Alan

Re: RFR: 8215017: Improve String::equals warmup characteristics

Hi, Tobias weighed in on this in another thread[1], and while he thinks the proposed patch is semantically correct, concerns was raised that maybe the UTF16 intrinsics could be superior (on some platforms). I ran the microbenchmark below as well as existing string-density- benchmark[2] suite,

Re: RFR: 8215017: Improve String::equals warmup characteristics

Claes, make sure you've mind-melded with Aleksey on this, e.g. via https://www.youtube.com/watch?v=wIyeOaitmWM On Fri, Dec 7, 2018 at 4:07 PM Claes Redestad wrote: > Hi, > > following up from discussions during review of JDK-8214971[1], I > examined the startup and peak performance of a few

Re: RFR: 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

On 12/9/18 5:28 PM, Michihiro Horie wrote: Hi Vladimir, Thanks a lot for your review. I also fixed the copyright in intrinsicnode.hpp. >Did you look on code generated by C2 with your latest changes? Yes,I usually check generated code with Oprofile and they were as expected like: : 90 0.0905 :

Re: RFR: 8170769 Provide a simple hexdump facility for binary data

Hi, Looks good, though some points to clarify. - The methods that use ByteBuffers should be clear that accesses to the ByteBuffers    are relative and use and modify the position and ByteBuffer exceptions may be thrown. - The methods that write output (Strings) to an output stream might be

Re: RFR: 8212703: Remove sun.java2d.fontpath property from java launcher code

Looks fine, Thanks for the test update. Roger On 12/09/2018 02:59 AM, Philip Race wrote: Here is an update with a Java-only test, using ProcessBuilder. http://cr.openjdk.java.net/~prr/8212703.1/index.html -phil. On 12/1/18, 9:27 AM, Alan Bateman wrote: On 30/11/2018 23:11, Roger Riggs

Re: Add convenience collect methods to the Stream interface

Hi Rob, i will add to the answer of Brian that if you have too many .collect(toList()), it's perhaps your application perhaps suffers of the equivalent of the n + 1 select query you have with SQL but with the Stream API. You should try to see if returning a Stream instead of a List for some of

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

Sounds good to me. /Erik On 2018-12-10 05:19, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however,

JEP 343: Packaging Tool Implementation - Status Update

RFR: JDK-8212780: JEP 343: Packaging Tool Implementation The initial request for review was sent out on October 23, with a refresh on November 11. Since then we have been continuing to fix bugs and add needed functionality in response to the feedback we have received (full list below).

Re: RFR: 8170769 Provide a simple hexdump facility for binary data

Hi Vincent, On 12/10/2018 03:59 PM, Vincent Ryan wrote: Comments in-line. Thanks. On 10 Dec 2018, at 16:59, Roger Riggs > wrote: Hi, Looks good, though some points to clarify. - The methods that use ByteBuffers should be clear that accesses to the

Re: RFR(XS): 8215009: GCC 8 compilation eror in libjli

Hi Dmitry, On 11/12/2018 12:16 am, Dmitry Chuyko wrote: Hello, Please review a small fix in java_md_solinux.c: continuation is not truly compatible with pthread_create start_routine's signature but we control what actually happens. So it makes sense to add intermediate void* cast to silence

RFR: 8215159: Improve initial setup of system Properties

Hi, by inverting the order in which the internal property maps are created, we avoid some classloading and get a slightly more efficient code execution profile in System.initPhase1. Webrev: http://cr.openjdk.java.net/~redestad/8215159/jdk.00/ Bug:

RE: Add convenience collect methods to the Stream interface

Hi Remi, There are certainly places where we could do this when we are simply iterating over the results but that is not always the case. However I was disappointed to find that the enhanced for loop can't iterate over a stream so if callers of your example methods where doing something like

Re: [PATCH] Windows 32-bit DLL name decoration

> On 10 Dec 2018, at 15:11, Magnus Ihse Bursie > wrote: > > > > On 2018-12-10 16:02, Alexey Ivanov wrote: >> >> >> On 10/12/2018 10:41, Magnus Ihse Bursie wrote: >>> >>> >>> On 2018-12-07 22:18, Simon Tooke wrote: Looking at the code, it seems (to me) the "correct" thing to do is

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

Hi Alexey, I’ve searched for |GetProcAddress| usages across source code and couldn’t find (hopefully tbh) other occurrences of such mismatches. Regards, Ali > On 7 Dec 2018, at 20:24, Alexey Ivanov wrote: > > Hi Ali, > > On 06/12/2018 22:49, Ali İnce wrote: >> Hi Magnus, Alexey, >> >> I

Re: [PATCH] Windows 32-bit DLL name decoration

Looking at the code, it seems (to me) the "correct" thing to do is to is to create a Windows-specific version of dbgsysBuildFunName() in linker_md.c, and have it decorate the function name as appropriate for 32-bit windows.  Note that in transport.c, you'd need to pass in the parameter stack size

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however, the semantics

Re: RFR: 8170769 Provide a simple hexdump facility for binary data

Comments in-line. Thanks. > On 10 Dec 2018, at 16:59, Roger Riggs wrote: > > Hi, > > Looks good, though some points to clarify. > > - The methods that use ByteBuffers should be clear that accesses to the > ByteBuffers >are relative and use and modify the position and ByteBuffer

Re: Type variable information is not always maintained for anonymous classes

Hi David, Thanks for checking it, I'll continue working on it then. Just wondering if you have any thoughts on how fix would look like. Regards, Sergei On Tue, 11 Dec 2018 at 02:34, David Holmes wrote: > Hi Sergey, > > I've had a look and I don't think this issue is relevant to JDK-8171335. >

Re: RFR: 8170769 Provide a simple hexdump facility for binary data

On 12/7/18 10:22 AM, Vincent Ryan wrote: I'm not convinced that the overloads that send output to an OutputStream pull their weight. They basically wrap the OutputStream in a PrintStream, which conveniently doesn't declare IOException, making it easy to use from a lambda passed to

Re: Type variable information is not always maintained for anonymous classes

Hi Sergey, I've had a look and I don't think this issue is relevant to JDK-8171335. The problem seems to occur when you have a "hidden" enclosing context for the type, and that doesn't change with JDK-8171335. David On 9/12/2018 6:04 am, Sergey wrote: Hi David, Thanks for pointing that

Re: Type variable information is not always maintained for anonymous classes

On 11/12/2018 4:27 pm, Sergei Ustimenko wrote: Hi David, Thanks for checking it, I'll continue working on it then. Just wondering if you have any thoughts on how fix would look like. No. I tried tracking through the Java code to see how this works but the path is too long and convoluted :(

Re: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi Roger, just to clarify - do you want us to push the last version [1] which adds "|| forceNullOutputStream)" to the Solaris version as well? Thank you and best regards, Volker [1] http://cr.openjdk.java.net/~sgroeger/jtreg/8211844/webrev.01/ On Mon, Dec 10, 2018 at 6:30 PM Roger Riggs wrote:

Re: RFR 8214971 : Replace use of string.equals("") with isEmpty()

Hi Claes, the difference is the "array encoding" (ae) argument passed to the intrinsic. See MacroAssembler::string_compare(... int ae). If we compare an UTF16 String, we know that the number of bytes is always even (two byte / char encoding), whereas a Latin1 string has a byte encoding. So

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi, I ran the fix through our tests. There are no new regressions, and the addressed test works. So reviewed from my side. I increased the bug to P3 so we can push it to jdk12 in case we miss Thursday. Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf Of

Re: [PATCH] Windows 32-bit DLL name decoration

On 2018-12-07 22:18, Simon Tooke wrote: Looking at the code, it seems (to me) the "correct" thing to do is to is to create a Windows-specific version of dbgsysBuildFunName() in linker_md.c, and have it decorate the function name as appropriate for 32-bit windows. Note that in transport.c,

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

On 2018-12-07 21:24, Alexey Ivanov wrote: Hi Ali, On 06/12/2018 22:49, Ali İnce wrote: Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Unfortunately, no one has replied as of now. Have you found any issues with jdwpTransport_OnLoad after

Re: [PATCH] Windows 32-bit DLL name decoration

On 2018-11-27 19:49, Andrew Luo wrote: By the way, in hotspot we are generating a .def file dynamically while keeping the JNICALL calling convention (for symbols such as JNI_CreateJavaVM) I believe (just by looking through the code in

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? Thanks, Nick On 28/11/2018 11:33, Martin Buchholz wrote: > > > On Tue, Nov 27, 2018 at 7:25 PM, Nick Gasson > wrote: > > > I missed one thing then looking at this.

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement. Is there any alternative?

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 2018-12-10 11:56, Nick Gasson (Arm Technology China) wrote: Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? I think Alan reviewed it as OK with just a minor fix, and offered to sponsor it for you. Then the discussion started about some major

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

On 10/12/2018 11:05, Magnus Ihse Bursie wrote: On 2018-12-10 11:56, Nick Gasson (Arm Technology China) wrote: Hi, Any update on this one? Or do we want to give up on it until JDK-8165620 is implemented? I think Alan reviewed it as OK with just a minor fix, and offered to sponsor it for you.

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

On 10/12/2018 11:01, Magnus Ihse Bursie wrote: On 2018-12-07 21:20, Roger Riggs wrote: Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem

Re: RFR(xs): 8199394: Object.hashCode should not mention anything about memory addresses

On 07/12/2018 18:17, Stuart Marks wrote: > Hi Andrew, Aleksey, Rémi, > > Thanks for looking at the patch. Could one or more of you add yourselves > as reviewers on the corresponding CSR? > > https://bugs.openjdk.java.net/browse/JDK-8215025 Done. regards, Andrew Dinn --- Senior

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

Hello Roger, Magnus and Alan. I may need to put alias information into charsets file. stdcs-xxx cannot handle this information... Still AIX needs IBM-29626C charset for default encoding... I appreciate if you give me further suggestions. Thanks, Ichiroh Takiguchi On 2018-12-10 20:50, Alan

[12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The problem is that calling convention was changed on ZIP_InflateFully function in zip.dll. Yet it hasn't been updated

Re: [12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

Hi Alexey, On 2018-12-10 13:32, Alexey Ivanov wrote: Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The fix looks good to me. /Magnus The problem is that calling

Re: [12] RFR for JDK-8215123: Crash in runtime image built with jlink --compress=2

On 10/12/2018 13:01, Magnus Ihse Bursie wrote: Hi Alexey, On 2018-12-10 13:32, Alexey Ivanov wrote: Hi, Could you please review the following fix for jdk12? bug: https://bugs.openjdk.java.net/browse/JDK-8215123 webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/ The fix looks

Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however, the semantics will not. Currently, we "mis-use" the JNIEXPORT define to

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi Goetz, It is good that the tests you ran passed. What needs to be done now to get this change pushed into the main code? Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi Steve, I will push it once Roger gives his ok. Best regards, Goetz. > -Original Message- > From: Steve Groeger > Sent: Montag, 10. Dezember 2018 14:42 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net; Roger Riggs > Subject: RE: JDK-8211844 [aix] ProcessBuilder:

RFR(XS): 8215009: GCC 8 compilation eror in libjli

Hello, Please review a small fix in java_md_solinux.c: continuation is not truly compatible with pthread_create start_routine's signature but we control what actually happens. So it makes sense to add intermediate void* cast to silence the error. bug:

Re: [PATCH] Windows 32-bit DLL name decoration

On 10/12/2018 10:41, Magnus Ihse Bursie wrote: On 2018-12-07 22:18, Simon Tooke wrote: Looking at the code, it seems (to me) the "correct" thing to do is to is to create a Windows-specific version of dbgsysBuildFunName() in linker_md.c, and have it decorate the function name as appropriate

Re: [PATCH] Windows 32-bit DLL name decoration

On 2018-12-10 16:02, Alexey Ivanov wrote: On 10/12/2018 10:41, Magnus Ihse Bursie wrote: On 2018-12-07 22:18, Simon Tooke wrote: Looking at the code, it seems (to me) the "correct" thing to do is to is to create a Windows-specific version of dbgsysBuildFunName() in linker_md.c, and have

Re: Add convenience collect methods to the Stream interface

As will surprise no one, this was extensively discussed during the development of the Streams API.  (Our default position on "convenience methods" is hostile.  While everyone sees the benefit of convenience methods (it's convenient!), most people don't see the cost, which includes the

Re: Add convenience collect methods to the Stream interface

FTR: already tracking as JDK-8180352. On 12/9/2018 5:44 PM, Rob Griffin (rgriffin) wrote: Hi, I have raised an enhancement request (Incident Report 913453) about adding some convenience methods to the Stream interface that collect the stream and Pallavi Sonal asked me to start a thread here