On 01/06/2021 21:28, John Rose wrote:
:
Note to self and other reviewers of future versions
of the JVMS: When you see proposed language like
the “unless…” of JVMS 4.7.17, remember today's
conversation and try to avoid putting dark corners
like that into the JVMS.
The
On Wed, 2 Jun 2021 01:56:00 GMT, Xiaohong Gong wrote:
>> Currently `"VectorMask.eq()" `is not vectorized:
>>
>> public VectorMask eq(VectorMask m) {
>> // FIXME: Generate good code here.
>> return bOp(m, (i, a, b) -> a == b);
>> }
>>
>> This can be implemented by
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The
On Wed, 2 Jun 2021 06:30:11 GMT, Jonathan Gibbons wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> The fix was supposed to be just about disentangling
On Wed, 2 Jun 2021 00:39:25 GMT, Stuart Marks wrote:
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] -
On Mon, 31 May 2021 10:25:26 GMT, Xiaohong Gong wrote:
> Currently `"VectorMask.eq()" `is not vectorized:
>
> public VectorMask eq(VectorMask m) {
> // FIXME: Generate good code here.
> return bOp(m, (i, a, b) -> a == b);
> }
>
> This can be implemented by calling
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart wrote:
>> ...hm, it seems that mere presence of any RUNTIME annotation that was
>> RUNTIME already at the use compile time somehow affects
>> -XX:+PreserveAllAnnotations option so that now RUNTIME annotations that were
>> CLASS annotations at use
On Wed, 2 Jun 2021 00:39:25 GMT, Stuart Marks wrote:
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов
wrote:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
src/java.base/share/classes/java/lang/Double.java line 881:
> 879: public
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as is available from the "native.encoding"
> system
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/invoke/MemberName.java line
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
We
On Thu, 27 May 2021 20:33:50 GMT, Brian Burkhalter wrote:
> Modify the specification of `java.io.File.equals` to clarify that equality is
> based only on a comparison of abstract pathnames as opposed to the file
> system objects that the `File`s represent.
This pull request has now been
On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the annotation covering too big a portion it's easy to
On Wed, 2 Jun 2021 13:24:10 GMT, David Holmes wrote:
> Sorry now I see what happens. We aren't combining two arrays of
> annotations we're concatenating two streams of byes, each of which
> represents a set of annotations, starting with the length.
>
> The code that receives this on the JDK
Please find below a fix that will make
`java/net/DatagramSocket/DatagramSocketMulticasting.java` more resilient to the
rare case where addresses bound to a network interfaces are updated while the
test is running.
Instead of using `NetworkInterface::equals` to compare network interfaces, the
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 14:50:23 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/lang/Double.java line 881:
>
>> 879:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Inline local vars
Hi,
Could someone please review my code for updating the code in the `java.lang`
packages to make use of the switch expressions?
Kind regards,
Patrick
-
Commit messages:
- 8268124: Update java.lang to use switch expressions
Changes:
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
src/java.base/share/classes/java/lang/runtime/ObjectMethods.java
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests
On Wed, 2 Jun 2021 14:51:35 GMT, liach
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Delegate to Double.hashCode()
>
> src/java.desktop/macosx/classes/apple/laf/JRSUIConstants.java line 115:
>
>>
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8268113: Delegate to
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP,
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On 2/06/2021 10:17 pm, Peter Levart wrote:
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart wrote:
...hm, it seems that mere presence of any RUNTIME annotation that was RUNTIME
already at the use compile time somehow affects -XX:+PreserveAllAnnotations
option so that now RUNTIME annotations
On Wed, 2 Jun 2021 13:24:00 GMT, Erik Joelsson wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> We do not require brew to install packages on mac, the
On Wed, 2 Jun 2021 11:34:18 GMT, Peter Levart wrote:
>> test/jdk/java/lang/annotation/AnnotationType/AnnotationTypeChangedToRuntimeTest.java
>> line 81:
>>
>>> 79: " should not be visible at runtime");
>>> 80: }
>>> 81: }
>>
>> I'm trying to understand
The motivation here is that we wanted to preserve the ability to
describe "special" indy sites with special objects. The standard
implementation can describe any indy site (bootstrap, static args,
invocation name and type), but some indy sites (e.g., lambda capture)
are "special". It would
JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
as SCR
-
Commit messages:
- JDK-8267764: jpackage cannot handle window screensaver files when EXE
renamed as SCR
Changes: https://git.openjdk.java.net/jdk/pull/4306/files
Webrev:
On Wed, 2 Jun 2021 12:33:37 GMT, Peter Levart wrote:
> I suggest the following patch for the bug in AnnotationParser:
>
An alternative would be to change the `ClassFileParser::assemble_annotations`
in the VM to no be so "dumb", but to construct correct concatenation.
-
PR:
Never mind ...
On 2/06/2021 10:47 pm, David Holmes wrote:
On 2/06/2021 10:17 pm, Peter Levart wrote:
On Wed, 2 Jun 2021 11:40:13 GMT, Peter Levart
wrote:
...hm, it seems that mere presence of any RUNTIME annotation that
was RUNTIME already at the use compile time somehow affects
On Wed, 2 Jun 2021 05:59:05 GMT, David Holmes wrote:
> Sorry Jaroslav but I don't really see this test as a basic functional
> test of the PreserveAllAnnotations flag. There is no need for any
> dynamic retention mode switch. All you need as I've said previously is a
> class with all the CLASS
On Fri, 26 Feb 2021 10:48:33 GMT, Сергей Цыпанов
wrote:
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
This pull request has been closed without being
On Wed, 2 Jun 2021 10:36:06 GMT, Peter Levart wrote:
>> There doesn't seem to be much support for the complete changes in #4245. To
>> get at least something useful from that endeavor I have extracted the test
>> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
After I've renamed remove branch GitHub for some reason has closed original
https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
-
Commit messages:
- Merge branch 'master' into 8263561
- Merge branch 'master' into purge-linked-list
- 8263561: Use sized
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
We do
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on
There is a few JDK classes duplicating the contents of Long.hashCode() for hash
code calculation. They should explicitly delegate to Long.hashCode().
-
Commit messages:
- 8268113: Re-use Long.hashCode() where possible
Changes: https://git.openjdk.java.net/jdk/pull/4309/files
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов
wrote:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
src/java.base/share/classes/java/util/BitSet.java line 1040:
> 1038: h
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as is available from the "native.encoding"
> system
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 07:35:25 GMT, Rémi Forax wrote:
> i wonder if we should not declare SimpleImmutableEntry final, while it's not
> a backward compatible change,
> it's may be better on the long term because SimpleImmutableEntry is already
> used as an immutable type,
> so instead of
> I'm fixing this along with a couple intertwined issues.
>
> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>
> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
> really immutable) but that subclasses can be modifiable.
>
> 3. Clarify some confusing,
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
>
On Wed, 2 Jun 2021 17:58:29 GMT, Vyom Tewari wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/util/BitSet.java line 105:
>
>> 103:
If the reflection runtime doesn't implement the semantics of
-XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
option now.
-Joe
On 6/2/2021 7:48 AM, Peter Levart wrote:
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
There doesn't seem to be much support for
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Patrick, some minor comments.
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Changes to Math and Long look fine.
-
Marked as
On Fri, 28 May 2021 02:14:45 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/action/PatternAction.java
> line
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
>
This patch overhauls the library loading mechanism used by the Foreign Linker
API. We realized that, while handy, the *default* lookup abstraction
(`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
This patch replaces `LibraryLookup` with a simpler `SymbolLookup`
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I
On Wed, 2 Jun 2021 16:37:49 GMT, Сергей Цыпанов
wrote:
>> There is a few JDK classes duplicating the contents of Long.hashCode() for
>> hash code calculation. They should explicitly delegate to Long.hashCode().
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
Special characters are different in File and URI. Treat File input as File
using FileInputStream instead of converting to an URI, but fall back to URI in
case of error for compatibility (in error handling).
-
Commit messages:
- 8266019: StreamResult(File) writes to incorrect file
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4306
On Wed, 2 Jun 2021 17:12:21 GMT, Stuart Marks wrote:
> A quick search reveals that Guava has a public subclass of
> SimpleImmutableEntry:
> https://guava.dev/releases/30.1.1-jre/api/docs/com/google/common/cache/RemovalNotification.html
>There are possibly others. It doesn't seem worth the
> The specification of `forEachRemaining`, accepting a primitive functional
> interface, on the primitive iterators is updated to be the same as for
> `Iterator.forEachRemaining`, specifically the following is added:
>
>
> *
> * Subsequent behavior of an iterator is unspecified if
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
This pull request has now been integrated.
Changeset: ef01e478
Author:Jonathan Gibbons
URL:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the stack following the normal calling
> convention. To
On Tue, 1 Jun 2021 19:51:39 GMT, Raffaello Giulietti
wrote:
> Trivial changes to this non-normative document.
Marked as reviewed by smarks (Reviewer).
Looks good. Thanks for noticing and fixing this!
-
PR: https://git.openjdk.java.net/jdk/pull/4289
On Thu, 3 Jun 2021 03:23:13 GMT, Brian Goetz wrote:
> reasonable options are to either leave it alone, deprecate it, or engage
> in a much more deliberate redesign.?
My favorite option is to leave it alone and test it a bit with the test already
provided in this PR. That however requires one
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote:
> 8267630: Start of release updates for JDK 18
JDK 18 is right around the corner, time for the usual start-of-release
changeset for review.
Typical structure for these kinds of changes. I'll update the symbol file
information of JDK 17 b25
8267630: Start of release updates for JDK 18
-
Commit messages:
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into 8267630
- Merge branch 'master' into
On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote:
>> I'm fixing this along with a couple intertwined issues.
>>
>> 1. Add Map.Entry::copyOf as an idempotent copy operation.
>>
>> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
>> really immutable) but that
On 3/06/2021 12:39 am, Peter Levart wrote:
On Wed, 2 Jun 2021 05:59:05 GMT, David Holmes wrote:
Sorry Jaroslav but I don't really see this test as a basic functional
test of the PreserveAllAnnotations flag. There is no need for any
dynamic retention mode switch. All you need as I've said
On 3/06/2021 2:54 am, Joe Darcy wrote:
If the reflection runtime doesn't implement the semantics of
-XX+PreserveAllAnnotations, I suggest deprecating/obsoleting/etc. that
option now.
I have to agree with Joe now. I mistakenly thought the raw annotation
stream was exposed to some parts of
On Wed, 2 Jun 2021 22:22:55 GMT, Paul Sandoz wrote:
>> The specification of `forEachRemaining`, accepting a primitive functional
>> interface, on the primitive iterators is updated to be the same as for
>> `Iterator.forEachRemaining`, specifically the following is added:
>>
>>
>> *
>>
On Wed, 2 Jun 2021 07:48:47 GMT, Nils Eliasson wrote:
> Please wait until you have two reviewers before integrating.
Sure! Thanks so much for looking at this PR!
-
PR: https://git.openjdk.java.net/jdk/pull/4272
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Wed, 2 Jun 2021 02:32:54 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Wed, 2 Jun 2021 13:48:47 GMT, Andy Herrick wrote:
> JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed
> as SCR
Marked as reviewed by almatvee (Reviewer).
Can we add a simple test for .scr executables?
-
PR:
On 3/06/2021 1:38 am, Peter Levart wrote:
On Wed, 2 Jun 2021 13:24:10 GMT, David Holmes wrote:
Sorry now I see what happens. We aren't combining two arrays of
annotations we're concatenating two streams of byes, each of which
represents a set of annotations, starting with the length.
The
On Thu, 3 Jun 2021 00:47:45 GMT, Jonathan Gibbons wrote:
> Please review a small test fix, to include hamcrest.jar, as required by the
> latest version of JUnit in jtreg 6.
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4328
On Wed, 2 Jun 2021 18:07:55 GMT, Daniel Fuchs wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tiny editorial tweaks.
>
> src/java.base/share/classes/java/util/Map.java line 396:
>
>> 394:
>> 395: /**
>> 396:
Please review a small test fix, to include hamcrest.jar, as required by the
latest version of JUnit in jtreg 6.
-
Commit messages:
- JDK-8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating
for jtreg 6
Changes: https://git.openjdk.java.net/jdk/pull/4328/files
On Wed, 2 Jun 2021 21:50:24 GMT, Bradford Wetmore wrote:
>> A trivial copyright fix.
>
> LGTM
@bradfordwetmore - Thanks for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/4323
On Tue, 1 Jun 2021 23:37:10 GMT, Stuart Marks wrote:
>> Yeah, well spotted. I agree it's awkward. How about we lean on the behavior
>> of the boxed counterpart:
>>
>> /**
>> * Performs the given action for each remaining element until all
>> elements
>> * have been processed or
Please review a test fix to refer to the new name of the TestNG module.
-
Commit messages:
- JDK-8268147: need to update reference to testng module for jtreg6
Changes: https://git.openjdk.java.net/jdk/pull/4325/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4325=00
The Vector API toShuffle method can be optimized using existing vector
conversion intrinsic.
The following changes are made:
1) vector.toShuffle java implementation is changed to call
VectorSupport.convert.
2) The conversion intrinsic (inline_vector_convert()) in vectorIntrinsics.cpp
is
On Tue, 1 Jun 2021 17:43:45 GMT, Igor Veresov wrote:
>> Thank you @veresov!
>>
>> I'm glad to have more comments from hotspot-compiler group.
>>
>> Later, I'd like to integrate it if there are no more comments/objections.
>>
>> Thanks!
>> Yang
>
> @kelthuzadx Sorry about the delay. Could
It seems pretty clear that this "feature" is a leftover from an early
implementation, doesn't clearly say what it is supposed to do, is more
complicated than it looks, and is buggily implemented. While I
understand the temptation to "fix" it, at this point we'd realistically
be adding a
On Thu, 3 Jun 2021 00:29:00 GMT, Sandhya Viswanathan
wrote:
> The Vector API toShuffle method can be optimized using existing vector
> conversion intrinsic.
>
> The following changes are made:
> 1) vector.toShuffle java implementation is changed to call
> VectorSupport.convert.
> 2) The
On Thu, 3 Jun 2021 00:29:00 GMT, Sandhya Viswanathan
wrote:
> The Vector API toShuffle method can be optimized using existing vector
> conversion intrinsic.
>
> The following changes are made:
> 1) vector.toShuffle java implementation is changed to call
> VectorSupport.convert.
> 2) The
1 - 100 of 137 matches
Mail list logo