On Wed, 15 Sep 2021 12:56:34 GMT, David Holmes wrote:
> Did you test building all variants into one image?
Yes, I did, but I think the build system is confused about the VM feature sets.
I have a vague recollection that ether @magicus or someone else at one point
suggested eliminating
On Wed, 15 Sep 2021 09:33:10 GMT, wxiang
wrote:
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the
On Wed, 15 Sep 2021 12:00:07 GMT, Daniel Fuchs wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two
On Tue, 14 Sep 2021 17:21:29 GMT, Alexey Semenyuk wrote:
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
This pull request has now been integrated.
Changeset: a3ca7702
Author:Alexey Semenyuk
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
dummy commit
-
Changes:
On Mon, 6 Sep 2021 13:22:03 GMT, Aleksey Shipilev wrote:
>> During the review of JDK-8272914 that added hotspot:tier{2,3} groups,
>> @iignatev suggested to create tier4 groups that capture all tests not in
>> tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they
>> take
On Thu, 9 Sep 2021 04:19:07 GMT, Ian Graves wrote:
> Relaxing some assertion bounds to allow for small error values that still
> show improvement over previous summation method.
This pull request has now been integrated.
Changeset: f531b5c7
Author:Ian Graves
URL:
On Mon, 13 Sep 2021 11:06:15 GMT, Сергей Цыпанов
wrote:
> Currently the method is implemented like
>
> public List> parameterList() {
> return Collections.unmodifiableList(Arrays.asList(ptypes.clone()));
> }
>
> This seems to be excessive, as three objects are allocated here. Instead we
>
On Wed, 15 Sep 2021 12:02:51 GMT, Daniel Fuchs wrote:
> Another question is where to document this property. We will obviously need a
> CSR and releases notes. I also wonder if it should be promoted into a
> networking property - which would make it possible to document it in the
>
On Wed, 15 Sep 2021 10:16:36 GMT, Aleksey Shipilev wrote:
> This currently manifests if you run Zero with compiler/codecache/cli tests
> (part of tier1):
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/cli/
>
> STDERR:
> java.lang.RuntimeException:
On Wed, 15 Sep 2021 10:29:36 GMT, Aleksey Shipilev wrote:
> Happens with Zero tests:
>
>
> $ CONF=linux-x86_64-zero-fastdebug make exploded-test
> TEST=compiler/codecache/CheckSegmentedCodeCache.java
> ...
>
> java.lang.NullPointerException: Cannot invoke
>
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
Currently, the Platform.is64Bit() hard coded for judging whether the target
arch is 64-bit.
The `classes_nocoops.jsa not found` issue can be found while testing
CDSPluginTest.java on 64-bit platform, excluding x64 and AARCH64, like mips64.
For solving this issue, we assume that the bits of
On Wed, 15 Sep 2021 06:11:31 GMT, Jaikiran Pai wrote:
>> I think we want the entries to be sorted by default; that is the most useful
>> to the most people.
>> Checking for the overloaded method seems like trying too hard.
>> Changing the entrySet to return them sorted (always) would add
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote:
> See the bug report for more details. I would appreciate if people with their
> corporate testing systems would run this through their systems to avoid
> surprises. (ping @RealCLanger, @iignatev).
I haven't recognized problems I can
On Wed, 15 Sep 2021 12:09:31 GMT, Alan Bateman wrote:
>> Another question is where to document this property. We will obviously need
>> a CSR and releases notes. I also wonder if it should be promoted into a
>> networking property - which would make it possible to document it in the
>>
On Wed, 15 Sep 2021 09:33:10 GMT, wxiang
wrote:
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the
On Wed, 15 Sep 2021 07:46:34 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Wed, 15 Sep 2021 18:29:44 GMT, Lance Andersen wrote:
>>> Maybe this should use the same pattern than the other property above:
>>>
>>> ```
>>> ENABLE_JAR_INDEX = p != null ? p.equals("true") || p.isEmpty() : false;
>>> ```
>>
>> Yes, the intention is that
On Wed, 15 Sep 2021 08:42:40 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
>> line 152:
>>
>>> 150: return server;
>>> 151: }
>>> 152:
>>
>> Too bad we couldn't simplify the setting up a basic certificate for https.
>
> That
On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote:
> As the follow-up for Zero-specific JDK-8273494, we might want to clean up
> build system logic for all VM variants: stop impersonating "server" VMs for
> all of them. This basically leaves "core" and "custom" variants to be handled
>
On Wed, 15 Sep 2021 06:11:23 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Wed, 15 Sep 2021 06:28:25 GMT, Remilia Scarlet
wrote:
> Currently, the Platform.is64Bit() hard coded for judging whether the target
> arch is 64-bit.
> The `classes_nocoops.jsa not found` issue can be found while testing
> CDSPluginTest.java on 64-bit platform, excluding x64 and AARCH64,
On Mon, 24 May 2021 11:18:57 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Wed, 15 Sep 2021 15:48:55 GMT, Alan Bateman wrote:
>>> Another question is where to document this property. We will obviously need
>>> a CSR and releases notes. I also wonder if it should be promoted into a
>>> networking property - which would make it possible to document it in the
>>>
On Wed, 1 Sep 2021 01:05:32 GMT, Mandy Chung wrote:
>> This reimplements core reflection with method handles.
>>
>> For `Constructor::newInstance` and `Method::invoke`, the new implementation
>> uses `MethodHandle`. For `Field` accessor, the new implementation uses
>> `VarHandle`.For the
On Wed, 15 Sep 2021 18:59:08 GMT, Daniel Fuchs wrote:
>> I assume the reason for specifically checking for a value of true or an
>> empty string as you envision allowing the property to be explicitly set to
>> false in the future?
>>
>> Otherwise we could just check if the property is
On Fri, 3 Sep 2021 14:25:53 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
On Fri, 3 Sep 2021 14:25:53 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
On Wed, 15 Sep 2021 21:47:39 GMT, David Holmes wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to using BasicSleep on Windows
>> Added diagnostic output for a test that sometimes fails on Linux when
>>
On Wed, 15 Sep 2021 22:36:14 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 2452:
>>
>>> 2450:
>>> 2451: if (p.waitFor(10, TimeUnit.MILLISECONDS)) {
>>> 2452: System.out.println("WaitFor didn't wait long enough:
>>> " +
The message should probably more along the line of be „external sleep process
terminated unexpected early“. But maybe it is better to actually fail the test
when true is returned as it should not happen instead of diag output? (And for
diag output the exit code would be more helpful than the
On Wed, 15 Sep 2021 15:59:53 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Clarify how overriden Properties#entrySet() method impacts the order of
>> stored properties
>> - Tests to verify
On Wed, 15 Sep 2021 21:46:59 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/Properties.java line 819:
>>
>>> 817: *
>>> 818: * If the {@systemProperty java.util.Properties.storeDate} is set
>>> and
>>> 819: * is non-empty (as determined by {@link
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On 15/09/21 9:48 pm, Daniel Fuchs wrote:
On Wed, 15 Sep 2021 15:31:45 GMT, Roger Riggs wrote:
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
- Clarify how overriden Properties#entrySet() method impacts the order of
stored
> Currently, the Platform.is64Bit() hard coded for judging whether the target
> arch is 64-bit.
> The `classes_nocoops.jsa not found` issue can be found while testing
> CDSPluginTest.java on 64-bit platform, excluding x64 and AARCH64, like mips64.
>
> For solving this issue, we assume that the
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Fri, 3 Sep 2021 14:25:53 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the code is removed.
> A system property can be used to
> Currently, the Platform.is64Bit() hard coded for judging whether the target
> arch is 64-bit.
> The `classes_nocoops.jsa not found` issue can be found while testing
> CDSPluginTest.java on 64-bit platform, excluding x64 and AARCH64, like mips64.
>
> For solving this issue, we assume that the
On Wed, 15 Sep 2021 15:31:45 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Clarify how overriden Properties#entrySet() method impacts the order of
>> stored properties
>> - Tests to verify
On Wed, 15 Sep 2021 01:45:49 GMT, wxiang
wrote:
> Yes, I will take care of it. Need I create a new PR?
Up to you, it's okay to continue with this one if you want, we would just need
to change the description here and in JBS.
-
PR: https://git.openjdk.java.net/jdk/pull/5383
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Tue, 14 Sep 2021 21:09:34 GMT, Roger Riggs wrote:
>> Hmm, so if someone has subclassed `Properties` and overridden `entrySet` for
>> the purpose of ordering entries, that trick will no longer work with the new
>> code. I wonder - should we sort entries only when the
>>
On Thu, 9 Sep 2021 10:17:02 GMT, Aleksey Shipilev wrote:
> Currently, the build system defaults the libjvm.so location to "server".
> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
> need to see if moving the libjvm.so to a proper location breaks anything.
>
>
On Thu, 9 Sep 2021 10:17:02 GMT, Aleksey Shipilev wrote:
> Currently, the build system defaults the libjvm.so location to "server".
> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
> need to see if moving the libjvm.so to a proper location breaks anything.
>
>
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method is run when the above command is
> executed. This is
On Wed, 15 Sep 2021 03:14:04 GMT, Jaikiran Pai wrote:
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
>> FWIW `.z` is the extension of the old Unix `compress` program.
>
> Thank you Florent, I wasn't aware of that.
related PR for reference:
On Wed, 15 Sep 2021 07:46:34 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Tue, 14 Sep 2021 16:51:40 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java
>> line 129:
>>
>>> 127: * response body bytes are a {@code UTF-8} encoded byte
>>> sequence of
>>> 128: * {@code body}. The response {@linkplain
>>>
On Wed, 15 Sep 2021 07:40:35 GMT, Ravi Reddy wrote:
> Hi all,
>
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close
> operations on GZip we are not setting the deflator to a finished state which
> is
Hi all,
Please review this fix for Infinite loop in ZipOutputStream.close().
The main issue here is when ever there is an exception during close operations
on GZip we are not setting the deflator to a finished state which is leading to
an infinite loop when we try writing on the same GZip
On Tue, 14 Sep 2021 13:38:27 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java line
>> 106:
>>
>>> 104: var h = headers.entrySet().stream()
>>> 105: .collect(Collectors.toUnmodifiableMap(
>>> 106:
On Tue, 14 Sep 2021 16:45:08 GMT, Daniel Fuchs wrote:
>> Just a rewording, maybe.
>
> Hmm... Maye that should be "The response headers *are sent*". The non-obvious
> technical details is that the response headers are sent before the body - as
> soon as you call `sendResponseHeaders`. The link
> 8273711: Remove redundant stream() call before forEach in jdk.jlink
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8273711: Remove redundant stream() call before forEach in jdk.jlink
use method references where applicable
On Tue, 14 Sep 2021 18:23:49 GMT, Severin Gehwolf wrote:
>> Oh, I misunderstood the test. "no_value_expected" was passed in from
>> `testPids()` in this file, but that's confusing because you are expecting an
>> integer value. Maybe it should be "any_integer"?
>
>> Maybe it should be
> https://bugs.openjdk.java.net/browse/JDK-8266490
> extended the OSContainer API in order to also support the pids controller of
> cgroups. However only pids.max output was added with 8266490.
> There is a second parameter pids.current , see
>
On Wed, 15 Sep 2021 07:09:54 GMT, Matthias Baesken wrote:
>>> Maybe it should be "any_integer"?
>>
>> +1
>
>> Is "no_value_expected" generated by Docker? I searched the entire HotSpot
>> source code and couldn't find it. I also couldn't find "WARNING: Your kernel
>> does not support pids
On Fri, 10 Sep 2021 12:36:35 GMT, Severin Gehwolf wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Some simplifications and test adjustment suggested by Severin
>
>
On Wed, 15 Sep 2021 07:49:38 GMT, Michael McMahon wrote:
>> Or maybe - which would be more accurate:
>>
>>
>> with the given {@code statusCode} and the body bytes' length (or {@code -1}
>> if the body is empty).
>
> I agree with your second suggestion. It's better not to refer to the
>
On Tue, 14 Sep 2021 15:56:28 GMT, Jim Laskey wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main
There is a bug for URLClassPath.findResources with JarIndex.
Currently, there was agreement on dropping the support from the URLClassLoader
implementation but it was suggested that it should be disabled for a release or
two before the code is removed.
A system property can be used to re-enable
As the follow-up for Zero-specific JDK-8273494, we might want to clean up build
system logic for all VM variants: stop impersonating "server" VMs for all of
them. This basically leaves "core" and "custom" variants to be handled with
this patch.
Additional testing:
- [x] Linux x86_64 `core`
On Wed, 15 Sep 2021 05:59:13 GMT, Alan Bateman wrote:
> > Yes, I will take care of it. Need I create a new PR?
>
> Up to you, it's okay to continue with this one if you want, we would just
> need to change the description here and in JBS.
I created a new PR
This currently manifests if you run Zero with compiler/codecache/cli tests
(part of tier1):
$ CONF=linux-x86_64-zero-fastdebug make exploded-test
TEST=compiler/codecache/cli/
STDERR:
java.lang.RuntimeException: Unknown VM mode.
at
Happens with Zero tests:
$ CONF=linux-x86_64-zero-fastdebug make exploded-test
TEST=compiler/codecache/CheckSegmentedCodeCache.java
...
java.lang.NullPointerException: Cannot invoke
"String.contains(java.lang.CharSequence)" because
"jdk.test.lib.Platform.compiler" is null
at
67 matches
Mail list logo
