Re: RFR: 8286182: C2: crash with SIGFPE when executing compiled code

On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote: > This patch backs out the changes made by > [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and > [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there > are failures due to div nodes floating above

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/jdk.sctp/share/classes/com/sun/nio/sctp/ShutdownNotification.java line 28: > 26: >

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/opto/graphKit.cpp line 3626: > 3624: // The optional arguments are

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348: > 346: > 347: /** >

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v6]

On Wed, 18 May 2022 23:22:42 GMT, Vladimir Ivanov wrote: > Interesting. But AArch64 code does cover vector cases which just adds > confusion. `UsePopCountInsturction` is always true in AArch64. @XiaohongGong removed the `predicate` in aarch64 rules, and I think we can even remove the option

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Thu, 19 May 2022 06:00:06 GMT, Ioi Lam wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Refactor hotspot gtest >> - Separate into function. Fix comment. > > src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp

Re: RFR: 8286182: C2: crash with SIGFPE when executing compiled code

On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote: > This patch backs out the changes made by > [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and > [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there > are failures due to div nodes floating above

Integrated: 8286462: Incorrect copyright year for src/java.base/share/classes/jdk/internal/vm/FillerObject.java

On Tue, 10 May 2022 14:58:28 GMT, zhw970623 wrote: > The copyright year of > src/java.base/share/classes/jdk/internal/vm/FillerObject.java should be 2022. This pull request has now been integrated. Changeset: 022e7170 Author:yyrrzhang Committer: Jie Fu URL:

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Thu, 19 May 2022 05:53:19 GMT, Ioi Lam wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Refactor hotspot gtest >> - Separate into function. Fix comment. > > src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 84: > 82: > 83: /** >

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v6]

On Thu, 19 May 2022 08:53:31 GMT, Ningsheng Jian wrote: >>> LUT should be generated only if UsePopCountInsturction is false >> >> Should there be `!UsePopCountInsturction` check then? >> >>> restrict the scope of flag to only scalar popcount operation >> >> Interesting. But AArch64 code does

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/cds/filemap.cpp line 1914: > 1912: > 1913: // the current value

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. OK. I started with serviceability but then went through everything as it's hard to

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v2]

On Wed, 18 May 2022 18:10:45 GMT, Severin Gehwolf wrote: >> @iklam yes I meant `Find the longest common prefix`. Fixed the comment. > > I'm not convinced the extra function makes the code more readable, but here > it is. I can revert back if this is too much. @jerboaa Feel free to go back to

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/interpreter/bytecodeUtils.cpp line 186: > 184: static const int

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >>

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v2]

On Thu, 19 May 2022 07:02:13 GMT, Thomas Stuefe wrote: >> I'm not convinced the extra function makes the code more readable, but here >> it is. I can revert back if this is too much. > > @jerboaa Feel free to go back to your original variant. This was only a > proposal. understood.

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Thu, 19 May 2022 05:58:31 GMT, Ioi Lam wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Refactor hotspot gtest >> - Separate into function. Fix comment. > > src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp

RFR: 8287013: StringConcatFactory: remove short and byte mixers/prependers

The current short and byte mixers and prependers simply delegate to the int variants. At the LambdaForm level the values has already been implicitly cast to int, so removing this indirection and directly adapting to call the int-based variants is possible. This is a cleanup with minimal effect

Re: Question: Is it possible to introduce ASCII coder for compact strings to optimize performance for ASCII compatible encoding?

Yes, I think 20% is close to an upper bound, with less gain on smaller strings due improved cache-locality. And as you say such a small speed-up might not be very noticeable in practice when I/O is involved. /Claes On 2022-05-19 14:17, Glavo wrote: Thank you very much for your work, it seems

Re: RFR: 8286956: Loom: Define test groups for development/porting use

On Wed, 18 May 2022 11:10:58 GMT, Aleksey Shipilev wrote: > It would be beneficial to bring over the Loom-specific test groups from the > loom repo to aid development/porting work. > > https://github.com/openjdk/loom/blob/fibers/test/jdk/TEST.groups#L97-L108 >

Re: RFR: 8287013: StringConcatFactory: remove short and byte mixers/prependers

On Thu, 19 May 2022 10:47:23 GMT, Claes Redestad wrote: > The current short and byte mixers and prependers simply delegate to the int > variants. At the LambdaForm level the values has already been implicitly cast > to int, so removing this indirection and directly adapting to call the >

RFR: 8286654: Add an optional description accessor on ToolProvider interface

This PR adds an optional description accessor on `ToolProvider` interface. This PR also adds short description for each of the listed tool: - `jar` - `javac` - `javadoc` - `javap` and `jdeps` - `jlink` and `jmod` - `jpackage` - Commit messages: - Add localized description for

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps` > - `jlink` and `jmod` > -

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 21:47:25 GMT, Jonathan Gibbons wrote: >> This PR adds an optional description accessor on `ToolProvider` interface. >> >> This PR also adds short description for each of the listed tool: >> - `jar` >> - `javac` >> - `javadoc` >> - `javap` and `jdeps` >> - `jlink` and `jmod`

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Thu, 19 May 2022 06:21:40 GMT, Christian Stein wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties >> line 387: >> >>> 385: >>> 386: javac.description=Read Java declarations and compile them into class >>> files >>> 387: >> >> for your general

Re: Question: Is it possible to introduce ASCII coder for compact strings to optimize performance for ASCII compatible encoding?

Thank you very much for your work, it seems that the decoding speed of the new version of JDK has been greatly improved. However, `hasNegatives` still has a cost on my device. I tried removing the call to hasNegatives in `String.encodeUTF8` based on JDK 17.0.3, then I tested its performance

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v2]

On Thu, 21 Apr 2022 03:44:18 GMT, liach wrote: >> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, >> the interfaces are iterated twice. The two passes can be merged into one, >> yielding the whole proxy definition context (module, package, whether >> there's

Re: RFR: 8202449: overflow handling in Random.doubles [v2]

> Extend the range of Random.doubles(double, double) and similar methods. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8202449: overflow handling in Random.doubles - Changes: - all:

Re: RFR: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing [v2]

On Thu, 19 May 2022 15:29:29 GMT, Quan Anh Mai wrote: >> This patch backs out the changes made by >> [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and >> [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there >> are failures due to div nodes floating

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps` > - `jlink` and `jmod` > -

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps` > - `jlink` and `jmod` > -

Re: RFR: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02

On Wed, 18 May 2022 16:28:02 GMT, Naoto Sato wrote: > This is to incorporate the latest language subtag registry definition > (version 2022-03-02) into JDK19. Looks fine. - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8776

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. The security/crypto parts look good to me. - Marked as reviewed by xuelei

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

On Thu, 19 May 2022 09:31:07 GMT, Kevin Walls wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> Also, I fixed a couple of spelling mistakes. > > test/jdk/sun/security/tools/jarsigner/OldSig.java line 32: > >> 30: /* >> 31: *

Re: RFR: 8286182: C2: crash with SIGFPE when executing compiled code [v2]

> This patch backs out the changes made by > [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and > [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there > are failures due to div nodes floating above their validity checks. > > Thanks. Quan Anh Mai has

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v3]

On Wed, 18 May 2022 23:28:22 GMT, Vladimir Ivanov wrote: >> Its more of a chicken-egg problem here, for masked reverse operation, >> Reverse IR node is followed by a Blend Node, thus in such a case doing an >> eager Identity transform in Reverse::Identity will not work, also deferring >> this

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v3]

On Wed, 18 May 2022 23:35:54 GMT, Vladimir Ivanov wrote: >> It was an attempt to facilitate in-lining of these APIs over targets which >> do not intrinsify them. I agree its not a generic fix since three APIs are >> piggybacking on same entry point and without the knowledge of opcode it will

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps` > - `jlink` and `jmod` > -

RFR: 8202449: overflow handling in Random.doubles

Extend the range of Random.doubles(double, double) and similar methods. - Commit messages: - 8202449: overflow handling in Random.doubles Changes: https://git.openjdk.java.net/jdk/pull/8791/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8791=00 Issue:

Integrated: 8286654: Add an optional description accessor on ToolProvider interface

On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps` > - `jlink` and `jmod` > -

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

> Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. Alexey Ivanov has updated the pull request incrementally with seven additional commits since the last revision: - ...set to the values... -

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

On Thu, 19 May 2022 09:38:40 GMT, Kevin Walls wrote: >> Alexey Ivanov has updated the pull request incrementally with seven >> additional commits since the last revision: >> >> - ...set to the values... >> - ...will result in a Zip64 Extra (EXT) header >> - ...in addition to the main

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v2]

On Thu, 21 Apr 2022 03:44:18 GMT, liach wrote: >> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, >> the interfaces are iterated twice. The two passes can be merged into one, >> yielding the whole proxy definition context (module, package, whether >> there's

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base [v2]

On Thu, 19 May 2022 08:47:47 GMT, Kevin Walls wrote: >> Alexey Ivanov has updated the pull request incrementally with seven >> additional commits since the last revision: >> >> - ...set to the values... >> - ...will result in a Zip64 Extra (EXT) header >> - ...in addition to the main

Integrated: 8286182: [BACKOUT] x86: Handle integral division overflow during parsing

On Wed, 18 May 2022 15:44:10 GMT, Quan Anh Mai wrote: > This patch backs out the changes made by > [JDK-8285390](https://bugs.openjdk.java.net/browse/JDK-8285390) and > [JDK-8284742](https://bugs.openjdk.java.net/browse/JDK-8284742) since there > are failures due to div nodes floating above

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Thu, 19 May 2022 09:06:18 GMT, Severin Gehwolf wrote: >> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 63: >> >>> 61: } else { >>> 62: char *p = strstr(cgroup_path, _root); >>> 63: if (p != NULL && p == cgroup_path) { >> >> What happens if cgroup_path is

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Thu, 19 May 2022 19:59:18 GMT, Ioi Lam wrote: >>> What happens if cgroup_path is "/foo/bar" and _root is "/fo"? >> >> With a mount path of `/bar` this ends up being `/bar/o/bar`. Pretty strange, >> but then again it's a bit of a contrived example as those paths come from >> `/proc`

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v7]

> Hi All, > > Patch adds the planned support for new vector operations and APIs targeted > for [JEP 426: Vector API (Fourth > Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173) > > Following is the brief summary of changes:- > > 1) Extends the scope of existing lanewise API for

Re: RFR: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

On Thu, 19 May 2022 19:13:12 GMT, Alexey Semenyuk wrote: > 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8794

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

> On May 19, 2022, at 5:38 PM, Alexander Matveev > wrote: > > Hi Michael, Alexander > > I think it will be a problem to implement this for native launchers. Each of the native commands is it’s own app launcher? I didn’t know this. I don’t think it was ever really indicated in the

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, > the interfaces are iterated twice. The two passes can be merged into one, > yielding the whole proxy definition context (module, package, whether there's > package-private interface) when determining the module. >

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

On Thu, 19 May 2022 23:44:12 GMT, liach wrote: >> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, >> the interfaces are iterated twice. The two passes can be merged into one, >> yielding the whole proxy definition context (module, package, whether >> there's

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

> > Alexander > >> >> I think it will be a problem to implement this for native launchers. > Basically you are telling the developer in https://bugs.openjdk.java.net/browse/JDK-8286122 that it isn’t currently possible for their

Integrated: 8267038: Update IANA Language Subtag Registry to Version 2022-03-02

On Wed, 18 May 2022 16:28:02 GMT, Naoto Sato wrote: > This is to incorporate the latest language subtag registry definition > (version 2022-03-02) into JDK19. This pull request has now been integrated. Changeset: 7b19226b Author:Naoto Sato URL:

Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v9]

On Tue, 17 May 2022 01:19:30 GMT, Ichiroh Takiguchi wrote: >> On JDK19 with Linux ja_JP.eucjp locale, >> System.getenv() returns unexpected value if environment variable has >> Japanese EUC characters. >> It seems this issue happens because of JEP 400. >> Arguments for ProcessBuilder have same

Re: RFR: 8285973: x86_64: Improve fp comparison and cmove for eq/ne [v2]

On Wed, 18 May 2022 14:59:49 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch optimises the matching rules for floating-point comparison with >> respects to eq/ne on x86-64 >> >> 1, When the inputs of a comparison is the same (i.e `isNaN` patterns), `ZF` >> is always set, so we don't need

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v3]

On Thu, 19 May 2022 15:33:49 GMT, Jatin Bhateja wrote: >> Do you mean it's important to apply the transformation at the right node >> (pick the right node as the root) and it is hard to make a decision during >> GVN? > > Yes, that what I meant, but with recently added >

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v7]

On Thu, 19 May 2022 21:11:41 GMT, Jatin Bhateja wrote: >> Hi All, >> >> Patch adds the planned support for new vector operations and APIs targeted >> for [JEP 426: Vector API (Fourth >> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173) >> >> Following is the brief summary of

RFR: 8287064: Modernize ProxyGenerator.PrimitiveTypeInfo

Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace the hash map with a simple lookup, similar to what's done in [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242) - Commit messages: - 8287064: Modernize ProxyGenerator.PrimitiveTypeInfo

Re: RFR: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable [v2]

On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote: >> Method `Class.isAssignableFrom` is often used in form of: >> >> if (clazz.isAssignableFrom(obj.getClass())) { >> Such condition could be simplified to more shorter and performarnt code >> >> if (clazz.isInstance(obj)) { >>

RFR: 8287053: Avoid redundant HashMap.containsKey calls in ZoneInfoFile.getZoneInfo0

Instead of pair `HashMap.containsKey`/`HashMap.get` method calls, we can use single call `HashMap.getOrDefault`. It's faster and clearer. - Commit messages: - [PATCH] Avoid redundant HashMap.containsKey calls in ZoneInfoFile Changes:

Re: RFR: 8284960: Integration of JEP 426: Vector API (Fourth Incubator) [v7]

On Thu, 19 May 2022 21:11:41 GMT, Jatin Bhateja wrote: >> Hi All, >> >> Patch adds the planned support for new vector operations and APIs targeted >> for [JEP 426: Vector API (Fourth >> Incubator).](https://bugs.openjdk.java.net/browse/JDK-8280173) >> >> Following is the brief summary of

Integrated: 8280035: Use Class.isInstance instead of Class.isAssignableFrom where applicable

On Thu, 13 Jan 2022 08:25:22 GMT, Andrey Turbanov wrote: > Method `Class.isAssignableFrom` is often used in form of: > > if (clazz.isAssignableFrom(obj.getClass())) { > Such condition could be simplified to more shorter and performarnt code > > if (clazz.isInstance(obj)) { > >

RFR: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

8281682: Redundant .ico files in Windows app-image cause unnecessary bloat - Commit messages: - Trailing whitespace removed - Drop unused WinIconVerifierException - remove accidentally added space char - jtreg descriptions fixed - 8281682: Redundant .ico files in Windows

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

Hi Michael, I think it will be a problem to implement this for native launchers. - If we extract native launchers inside installed app bundle it will invalidate signature and most likely will require privileged permissions to write inside app bundle. - If we extract to some known and accessible

Integrated: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character

On Sun, 24 Apr 2022 09:18:54 GMT, Ichiroh Takiguchi wrote: > On JDK19 with Linux ja_JP.eucjp locale, > System.getenv() returns unexpected value if environment variable has Japanese > EUC characters. > It seems this issue happens because of JEP 400. > Arguments for ProcessBuilder have same kind

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v4]

> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, > the interfaces are iterated twice. The two passes can be merged into one, > yielding the whole proxy definition context (module, package, whether there's > package-private interface) when determining the module. >

Re: RFR: 8285401: Proxy class initializer should use 3-arg `Class.forName` to avoid unnecessary class initialization [v2]

> Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of > `Class.forName(String)`. `make test > TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new > `LazyInitializationTest` failing the eager initialization check on the > baseline and passing with this patch.

Withdrawn: 8282178: Replace simple iterations of Map.entrySet with Map.forEach calls

On Wed, 23 Feb 2022 22:33:42 GMT, liach wrote: > Replaces simple `for (Map.Entry entry : map.entrySet())` with > `map.forEach((k, v) ->)` calls. This change is better for thread-safety and > reduces allocation for some map implementations. > > A more in-depth description of benefits is

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

On Fri, 20 May 2022 00:08:36 GMT, Mandy Chung wrote: > a named module can't have unnamed package Since this is mandated by the Java Language Specification 7.4.2, I am tempted to change the thrown exception to `InternalError`, but I cannot find any restriction in the JVM Specification that

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

> On May 19, 2022, at 7:14 PM, Michael Hall wrote: > > > >> >> Alexander >> >>> >>> I think it will be a problem to implement this for native launchers. >> > > Basically you are telling the developer in > https://bugs.openjdk.java.net/browse/JDK-8286122 >

RFR: 8285401: Proxy class initializer should use 3-arg `Class.forName` to avoid unnecessary class initialization

Simplify calls `Class.forName(String, boolean, ClassLoader)` instead of `Class.forName(String)`. `make test TEST="jtreg:test/jdk/java/lang/reflect/Proxy"` passes, with the new `LazyInitializationTest` failing the eager initialization check on the baseline and passing with this patch. On a