Re: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-11 Thread huizhe wang
Thanks Daniel! Best regards, Joe On 8/11/2017 3:31 AM, Daniel Fuchs wrote: Hi Joe, Thanks, looks fine now! best regards, -- daniel On 10/08/2017 04:13, huizhe wang wrote: On 8/9/2017 6:30 AM, Daniel Fuchs wrote: Hi Joe, This not an easy patch to review ;-) Indeed, took several minutes

Re: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-11 Thread huizhe wang
Thanks Frank for looking into and verifying the relevant tests. We have a rich set of tests that have been very helpful with this update. I've addressed a number of failures during the work, but it's true that Bug8003147Test never failed. Best regards, Joe On 8/11/2017 1:08 AM, Frank Yuan wr

Re: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-11 Thread Daniel Fuchs
Hi Joe, Thanks, looks fine now! best regards, -- daniel On 10/08/2017 04:13, huizhe wang wrote: On 8/9/2017 6:30 AM, Daniel Fuchs wrote: Hi Joe, This not an easy patch to review ;-) Indeed, took several minutes just to copy the webrevs :-) Thanks for explaining how you arrived at the

RE: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-11 Thread Frank Yuan
Hi Joe and Daniel > > So far so good, most of them still seem to be present in > > your changes, but I have a doubt about these two: > > > > https://bugs.openjdk.java.net/browse/JDK-8062608 > > https://bugs.openjdk.java.net/browse/JDK-8064516 > > > > Has the issue been fixed upstream in a differen

Re: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-09 Thread huizhe wang
On 8/9/2017 6:30 AM, Daniel Fuchs wrote: Hi Joe, This not an easy patch to review ;-) Indeed, took several minutes just to copy the webrevs :-) Thanks for explaining how you arrived at the final result. The method you used as described below seems right. I haven't clicked through all the

Re: RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-09 Thread Daniel Fuchs
Hi Joe, This not an easy patch to review ;-) Thanks for explaining how you arrived at the final result. The method you used as described below seems right. I haven't clicked through all the files, but instead I had a look at all the JIRA issues revealed by: hg log -k share/classes/com/sun/org

RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-08 Thread huizhe wang
Please review an update to BCEL release 6.0 [1]. The sources are basically that from the release bundle with the following exceptions: * Classes that were not included in the original version are excluded; * Classes that are deprecated in BCEL 6.0 are removed; * Classes that are used only f