Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

2014-05-26 Thread Christopher Faylor
On Mon, May 26, 2014 at 04:27:10PM +0100, David Stacey wrote: On 26/05/14 14:36, Peter Rosin wrote: I believe the comment refers to if static is the right answer to the problem. Is there a need to handle concurrent calls? I can't really comment on that. As the code stands, neither of the two

Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

2014-05-26 Thread Christopher Faylor
On Mon, May 26, 2014 at 10:39:03PM +0200, Peter Rosin wrote: On 2014-05-26 18:35, Christopher Faylor wrote: On Mon, May 26, 2014 at 04:27:10PM +0100, David Stacey wrote: On 26/05/14 14:36, Peter Rosin wrote: I believe the comment refers to if static is the right answer to the problem

Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

2014-05-26 Thread Christopher Faylor
On Mon, May 26, 2014 at 05:40:49PM -0400, Christopher Faylor wrote: On Mon, May 26, 2014 at 10:39:03PM +0200, Peter Rosin wrote: On 2014-05-26 18:35, Christopher Faylor wrote: On Mon, May 26, 2014 at 04:27:10PM +0100, David Stacey wrote: On 26/05/14 14:36, Peter Rosin wrote: I believe

Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

2014-05-26 Thread Christopher Faylor
On Mon, May 26, 2014 at 05:46:10PM -0400, Christopher Faylor wrote: Btw, the latest version of freebsd can't have this particular problem since ahostbuf is now gone. We probably should pull in the latest version into Cygwin's tree. ...and that's apparently because Corinna added the code

Re: Rename detached debug info as cygwin1.dll.dbg

2014-05-24 Thread Christopher Faylor
On Fri, May 23, 2014 at 04:05:34PM +0200, Corinna Vinschen wrote: On May 23 14:40, Jon TURNEY wrote: Not sure if this is wanted, and it obviously has some knock on effects on package and snapshot generation. But, cygport names detached debug info files by appending the .dbg suffix. This is

Re: stdio.h patches for g++ -std=c++11

2014-05-02 Thread Christopher Faylor
On Fri, May 02, 2014 at 03:40:17PM +0200, zosrothko wrote: This is a patch for exposing the new stdio functions added by the c++11 standard. Without this patch the snprintf for example is not exposed as Patches for newlib should go to the newlib mailing list at sourceware.org.

Re: [PATCH] minidumper patches

2014-04-21 Thread Christopher Faylor
On Mon, Apr 21, 2014 at 06:02:19PM +0100, Jon TURNEY wrote: Attached are a couple of patches for the minidumper utility which could probably use some review. This is your utility so, as far as I'm concerned, you have carte blanche to check things in, i.e., you don't need any approval. I didn't

Re: patch for command line containing equals sign

2014-03-20 Thread Christopher Faylor
On Thu, Mar 20, 2014 at 09:10:05PM +, Weber, Mark wrote: See http://cygwin.com/ml/cygwin-patches/2014-q1/msg00017.html and related. Thanks for posting how the new behavior is different from the old. I am having a related issue, with C++ code that parses the command line. The command line we

Re: [PATCH] Fix errno codes set by opendir() in case of problems with the path argument

2014-03-03 Thread Christopher Faylor
On Mon, Mar 03, 2014 at 10:34:59PM +0400, Oleg Kravtsov wrote: Currently cygwin has a problem with errno code set by opendir() function. It always sets errno to ENOENT. After applying the path opendir() sets errno to 'ENAMETOOLONG' when path or a path component is too long, 'ELOOP' when a loop

Re: [PATCH] Expand $CYGWIN error_start processing

2014-02-09 Thread Christopher Faylor
On Sun, Feb 09, 2014 at 12:25:40AM +, Ray Donnelly wrote: I want to use QtCreator as my debugger but the hardcoded nature of error_start makes that impossible. This change allows a formatted commandline to be used where '|' is used to represent spaces and program-name and process-id are

Re: [PATCH] Add minidump write utility

2014-02-08 Thread Christopher Faylor
On Sat, Feb 08, 2014 at 03:00:18PM +, Jon TURNEY wrote: On 07/02/2014 16:36, Jon TURNEY wrote: This patch adds a 'minidumper' utility, which functions identically to 'dumper' except it writes a Windows minidump, rather than a core file. I'm not sure if this is of use to anyone but

Re: [PATCH] Add minidump write utility

2014-02-07 Thread Christopher Faylor
On Fri, Feb 07, 2014 at 04:36:01PM +, Jon TURNEY wrote: This patch adds a 'minidumper' utility, which functions identically to 'dumper' except it writes a Windows minidump, rather than a core file. I'm not sure if this is of use to anyone but me, but since I've had the patch sitting

Re: [PATCH] Snapshot install instructions use bz2, not xz

2014-01-29 Thread Christopher Faylor
On Wed, Jan 29, 2014 at 04:46:09PM +, Adam Dinwoodie wrote: I've attached a minor correction to the FAQ entry on installing snapshots, to note that snapshots are now .xz archives, rather than .bz2. Thanks for the heads up. I've made some more general wording changes in faq-setup.xml. cgf

Re: [PATCH] Fix parameter passing containing quote/equal to Windows batch command

2014-01-24 Thread Christopher Faylor
On Sun, Jan 19, 2014 at 10:02:56PM -0800, Daniel Dai wrote: We notice one issue when running a Windows batch command inside cygwin. Here is one example. Simple batch file: a.bat: echo %1 Run it under cygwin: ./a.bat a=b a ./a.bat a=b a If we pass additional \ ./a.bat \a=b\ \a There seems no

Re: [PATCH] Fix parameter passing containing quote/equal to Windows batch command

2014-01-24 Thread Christopher Faylor
On Fri, Jan 24, 2014 at 03:14:30PM -0800, Daniel Dai wrote: Hi, Christopher, The current logic is: if the parameter contains quote, then put a quote around the parameter (winf.cc:78). However, if the quote is in the beginning/end, cygwin will still quote it, and thus double quoted parameter (such

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-08 Thread Christopher Faylor
On Wed, Jan 08, 2014 at 11:00:14AM +, Ray Donnelly wrote: On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: - PWCHAR p; + PWCHAR p = NULL; AFAICT, that would result in a NULL dereference. I've checked

Some of my email didn't go through in December

2014-01-07 Thread Christopher Faylor
I changed my email configuration in December and that resulted in some sourceware.org mailing lists not thinking I was subscribed. So some of my timely responses to messages here are showing up here in an untimely manner. I noticed this when Corinna made the same observation that I thought I had

Re: fix off-by-one in dup2

2013-12-05 Thread Christopher Faylor
On Thu, Dec 05, 2013 at 06:45:22AM -0700, Eric Blake wrote: On 12/04/2013 10:51 AM, Christopher Faylor wrote: One question, though. Assuming start is == size, then the current code in CVS extends the fd table by only 1. If that happens often, the current code would have to call ccalloc

Re: fix off-by-one in dup2

2013-12-04 Thread Christopher Faylor
On Wed, Dec 04, 2013 at 01:04:08PM +0100, Corinna Vinschen wrote: On Dec 4 12:36, Corinna Vinschen wrote: On Dec 4 10:32, Corinna Vinschen wrote: Hi guys, [...etc...] The problem is still present in the current sources. [...] Ouch, ouch, ouch! I tested the wrong DLL. Actually current

Re: fix off-by-one in dup2

2013-12-04 Thread Christopher Faylor
On Wed, Dec 04, 2013 at 06:23:24PM +0100, Corinna Vinschen wrote: On Dec 4 12:00, Christopher Faylor wrote: On Wed, Dec 04, 2013 at 01:04:08PM +0100, Corinna Vinschen wrote: On Dec 4 12:36, Corinna Vinschen wrote: On Dec 4 10:32, Corinna Vinschen wrote: Hi guys, [...etc

Re: Fix sem_getvalue

2013-09-25 Thread Christopher Faylor
On Wed, Sep 25, 2013 at 12:41:17PM +0200, Paul Kunysch wrote: That looks like a reasonable fix. Did you trace through all of the callers of semaphore::_getvalue to make sure that some of them aren't relying on the old behavior? I did not look for other callers. I just wrote a very simple

Re: Fix sem_getvalue

2013-09-18 Thread Christopher Faylor
On Wed, Sep 18, 2013 at 11:53:20AM +0200, Paul Kunysch wrote: Hello In 1.7.24 and 1.7.25 sem_getvalue() returns the current value instead of setting the out-parameter and returning 0/-1 for success/error. I attached a simple fix. That looks like a reasonable fix. Did you trace through all of

Re: [PATCH] cygcheck: xz packages

2013-09-16 Thread Christopher Faylor
On Fri, Sep 13, 2013 at 02:06:19PM -0400, Christopher Faylor wrote: On Fri, Sep 13, 2013 at 12:10:47PM -0500, Yaakov (Cygwin/X) wrote: cygcheck needs fixing wrt .tar.xz packages; patch attached. Thanks for noticing this but I think I'd like to see a more general fix. In upset, I just completely

Re: [PATCH] cygcheck: xz packages

2013-09-13 Thread Christopher Faylor
On Fri, Sep 13, 2013 at 12:10:47PM -0500, Yaakov (Cygwin/X) wrote: cygcheck needs fixing wrt .tar.xz packages; patch attached. Thanks for noticing this but I think I'd like to see a more general fix. In upset, I just completely relaxed the checking of .gz/.bz2/.xz in favor of just checking for

Re: [PATCH] Fix cygcheck -p

2013-08-23 Thread Christopher Faylor
On Fri, Aug 23, 2013 at 03:11:24PM -0500, Yaakov (Cygwin/X) wrote: On 2013-08-23 14:46, Yaakov (Cygwin/X) wrote: On 2013-08-23 14:22, Christopher Faylor wrote: On Fri, Aug 23, 2013 at 01:27:13PM -0400, Christopher Faylor wrote: I'm working on bringing Cygwin's package search into the multi-arch

Re: [PATCH] DocBook XML toolchain modernization

2013-05-03 Thread Christopher Faylor
On Wed, May 01, 2013 at 06:14:34PM -0600, Warren Young wrote: On 4/30/2013 19:28, Warren Young wrote: I have decided: the script shall be called bodysnatcher.pl. :) I've created this. There is a new output, winsup/doc/faq/faq.body, generated from faq.html whenever it changes. The core of the

Re: [PATCH] DocBook XML toolchain modernization

2013-05-03 Thread Christopher Faylor
On Fri, May 03, 2013 at 04:22:40PM -0600, Warren Young wrote: On 5/3/2013 14:30, Christopher Faylor wrote: It looks like you broke the ability to build outside of the source tree. Sorry about that. It looks like you're in the middle of fixing it, so rather than fight with you over the tree

Re: [PATCH] fix GCC 4.7 warnings

2013-04-30 Thread Christopher Faylor
On Mon, Apr 29, 2013 at 09:49:06PM -0500, Yaakov (Cygwin/X) wrote: The attached patch fixes the remaining warnings in HEAD with GCC 4.7.3. OK to apply? Thanks for doing this. As you may have seen I started doing this earlier and Corinna told me to stop because it interfered with the 64-bit

Re: [PATCH] DocBook XML toolchain modernization

2013-04-30 Thread Christopher Faylor
On Tue, Apr 30, 2013 at 12:58:49PM -0600, Warren Young wrote: On 4/30/2013 12:47, Christopher Faylor wrote: If fill out the form at http://sourceware.org/cgi-bin/pdw/ps_form.cgi, I'll sponsor you for CVS access to Cygwin. Thanks! The updatekey process documented on that page seems to imply

Re: [PATCH] DocBook XML toolchain modernization

2013-04-30 Thread Christopher Faylor
On Tue, Apr 30, 2013 at 02:09:52PM -0600, Warren Young wrote: On 4/30/2013 13:07, Christopher Faylor wrote: On Tue, Apr 30, 2013 at 12:58:49PM -0600, Warren Young wrote: Do you mean for me to check these changes in when I get my sourceware account? Yes, with the implied assumption that you

Re: [PATCH 64bit] Export io.h symbols with underscore

2013-02-22 Thread Christopher Faylor
On Fri, Feb 22, 2013 at 11:02:55AM +0100, Corinna Vinschen wrote: On Feb 22 10:51, Corinna Vinschen wrote: On Feb 22 03:40, Yaakov wrote: On Fri, 22 Feb 2013 09:49:51 +0100, Corinna Vinschen wrote: access should go, no doubt about it. For get_osfhandle and setmode I would prefer

Re: [PATCH 64bit] Export io.h symbols with underscore

2013-02-21 Thread Christopher Faylor
On Fri, Feb 22, 2013 at 12:18:48AM -0600, Yaakov wrote: On Thu, 21 Feb 2013 14:42:36 -0500, Christopher Faylor wrote: I wasn't fulling grokking the fact that Cygwin explicitly defined the get_osfhandle without an underscore in io.h. Sigh. That's probably my fault too. But we definitely

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-18 Thread Christopher Faylor
On Mon, Feb 18, 2013 at 04:19:17AM -0600, Yaakov wrote: On Sun, 17 Feb 2013 11:51:59 -0500, Christopher Faylor wrote: +my $uscore = ($target =~ /^x86_64\-/ ? undef : '_'); There is no reason to quote the dash here. But, I would actually prefer a substr check since that is a little faster

Re: Qsort defects (in C-library)

2013-02-18 Thread Christopher Faylor
On Mon, Feb 18, 2013 at 10:05:11PM +0100, Corinna Vinschen wrote: On Feb 18 08:51, Dennis de Champeaux wrote: // I hope this is the proper mailing list Unfortunately it's not. Qsort is not implemented in Cygwin itself, but rather in newlib, the underlying C lib. The right mailing list is

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Christopher Faylor
On Sun, Feb 17, 2013 at 04:46:22AM -0600, Yaakov wrote: 2013-02-16 Yaakov Selkowitz yselkowitz@... * Makefile.in (libcygwin.a): Move --target flag from here... (toolopts): to here, to be used by both mkimport and speclib. * speclib: Omit leading underscore in symbol names

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Christopher Faylor
On Sun, Feb 17, 2013 at 02:41:41PM +0100, Corinna Vinschen wrote: On Feb 17 04:46, Yaakov wrote: 2013-02-16 Yaakov Selkowitz yselkowitz@... * Makefile.in (libcygwin.a): Move --target flag from here... (toolopts): to here, to be used by both mkimport and speclib. * speclib:

Re: [PATCH 64bit] Fix speclib for x86_64

2013-02-17 Thread Christopher Faylor
On Sun, Feb 17, 2013 at 06:09:44PM +0100, Corinna Vinschen wrote: On Feb 17 11:52, Christopher Faylor wrote: On Sun, Feb 17, 2013 at 02:41:41PM +0100, Corinna Vinschen wrote: On Feb 17 04:46, Yaakov wrote: 2013-02-16 Yaakov Selkowitz yselkowitz@... * Makefile.in (libcygwin.a): Move

Re: [PATCH] add cfsetspeed

2012-11-21 Thread Christopher Faylor
On Wed, Nov 21, 2012 at 04:54:03AM -0600, Yaakov (Cygwin/X) wrote: This patchset adds cfsetspeed(3), a BSD extension also available in glibc: http://man7.org/linux/man-pages/man3/termios.3.html Per the description, cfsetspeed() is the equivalent of cfsetospeed() and cfsetispeed() with the same

Re: Try #3 for changes to Cygwin configure

2012-11-14 Thread Christopher Faylor
On Wed, Nov 14, 2012 at 12:57:07PM +0100, Corinna Vinschen wrote: On Nov 13 22:39, Christopher Faylor wrote: Try #3. This is a smaller patch with some bug fixes found after building from-scratch, cleanly on a Fedora system with Yaakov's cross tools (ok, so I lied and did end up setting up

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-13 Thread Christopher Faylor
On Tue, Nov 13, 2012 at 10:33:01AM +0100, Corinna Vinschen wrote: On Nov 12 22:31, Christopher Faylor wrote: On Mon, Nov 12, 2012 at 07:02:57PM -0500, Christopher Faylor wrote: On Mon, Nov 12, 2012 at 10:50:23PM +0100, Corinna Vinschen wrote: I'm a bit puzzled about the necessity of some

Re: [WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-13 Thread Christopher Faylor
On Tue, Nov 13, 2012 at 07:47:32PM +0100, Corinna Vinschen wrote: On Nov 13 13:34, Christopher Faylor wrote: On Tue, Nov 13, 2012 at 12:39:00PM -0500, Christopher Faylor wrote: Maybe I can use -isystem with ccwraper. I'd previously gotten things working without the wrapper, using idirafter so

[WIP] mingw64 related changes to Cygwin configure and other assorted files with departed w32api/mingw

2012-11-12 Thread Christopher Faylor
I decided over the weekend to port over configury changes that I made to Cygwin's now-out-of-date GIT repository. These changes basically just cleaned up some of the configure scripts and made it easier to pinpoint where windows headers and libraries come from by adding a --with-windows-headers

Re: [PATCH] additional sys/termios.h defines

2012-11-04 Thread Christopher Faylor
On Sun, Nov 04, 2012 at 08:41:46PM -0600, Yaakov (Cygwin/X) wrote: The attached patch adds a few defines to sys/termios.h to make it compatible with Linux and *BSD. 2012-11-04 Yaakov Selkowitz yselkowitz@... * include/sys/termios.h (CBRK): Define as alias of CEOL. (CREPRINT):

Re: [patch cygwin]: Rename strechr to strchrnul

2012-10-26 Thread Christopher Faylor
On Fri, Oct 26, 2012 at 10:13:07PM +0200, Kai Tietz wrote: Hello, this patch replaces strechr by strchrnul symbol-name. The strchrnul name is that one also present in new-libc for this function behavior. ChangeLog 2012-10-26 Kai Tietz * dcrt0.cc (quoted): Renamed strechr to strchrnul.

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-25 Thread Christopher Faylor
On Thu, Oct 25, 2012 at 10:48:39AM +0200, Corinna Vinschen wrote: On Oct 24 18:02, Kai Tietz wrote: 2012/10/24 Christopher Faylor wrote: On Wed, Oct 24, 2012 at 11:07:47AM -0400, Ryan Johnson wrote: On 24/10/2012 5:16 AM, Kai Tietz wrote: Hello, this patch replaces the inline-assember used

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-25 Thread Christopher Faylor
On Thu, Oct 25, 2012 at 04:51:25PM +0200, Corinna Vinschen wrote: On Oct 25 10:17, Christopher Faylor wrote: On Thu, Oct 25, 2012 at 10:48:39AM +0200, Corinna Vinschen wrote: On Oct 24 18:02, Kai Tietz wrote: 2012/10/24 Christopher Faylor wrote: On Wed, Oct 24, 2012 at 11:07:47AM -0400, Ryan

Re: [patch cygwin]: Replace inline-assembler in string.h by C implementation

2012-10-24 Thread Christopher Faylor
On Wed, Oct 24, 2012 at 11:07:47AM -0400, Ryan Johnson wrote: On 24/10/2012 5:16 AM, Kai Tietz wrote: Hello, this patch replaces the inline-assember used in string.h by C implementation. There are three reasons why I want to suggest this. First, the C-code might be optimized further by fixed

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-22 Thread Christopher Faylor
On Mon, Oct 22, 2012 at 10:29:13AM +0200, Corinna Vinschen wrote: On Oct 22 00:09, Christopher Faylor wrote: Yeah, since the changes to the configury separate Cygwin from mingw and w32api, staying in src/winsup is no problem at all. I always thought mingw is part of the src tree for gcc bootstrap

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-21 Thread Christopher Faylor
On Sun, Oct 21, 2012 at 01:33:20PM +0200, Corinna Vinschen wrote: On Oct 19 20:46, Corinna Vinschen wrote: On Oct 19 11:33, Yaakov (Cygwin/X) wrote: On Fri, 2012-10-19 at 11:21 +0200, Corinna Vinschen wrote: Other than that, I think it's good to go in after the 1.7.17 release. I'll try to do the

Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building

2012-10-21 Thread Christopher Faylor
On Sun, Oct 21, 2012 at 01:32:41PM -0500, Yaakov (Cygwin/X) wrote: On Sun, 2012-10-21 at 13:10 -0400, Christopher Faylor wrote: That said, is it time to ask the mingw.org stuff to relocate their CVS repo? I could tar up the affected CVS directories for them if so. What about some CVSROOT/modules

Re: [PATCH] suggestion for faster pseudo-reloc.

2012-09-05 Thread Christopher Faylor
On Wed, Sep 05, 2012 at 10:59:23PM +0800, JonY wrote: On 9/5/2012 22:48, Christopher Faylor wrote: On Wed, Sep 05, 2012 at 09:46:45PM +0800, JonY wrote: On 9/3/2012 19:24, Corinna Vinschen wrote: It differs a lot from the original source, so you might contemplate to send a follow up mail

Re: [PATCH] Add pointer to instructions for uninstalling cygwin LSA to uninstall FAQ

2012-08-23 Thread Christopher Faylor
On Thu, Aug 23, 2012 at 05:04:44PM +0100, Jon TURNEY wrote: The uninstall instructions in the FAQ will fail if cygwin LSA is installed. Wouldn't it be better to add the instructions directly to the FAQ? cgf

Re: New modes for cygpath that terminate path with null byte, nothing

2012-08-14 Thread Christopher Faylor
On Tue, Aug 14, 2012 at 02:49:17PM -0700, Daniel Colascione wrote: On 7/27/2012 2:32 AM, Corinna Vinschen wrote: There's just the problem of the copyright assignment. If you want to provide a non-obvious patch, or if the patch adds new functionality, we need a copyright assignment from you.

Re: rebaseall info out of date

2012-07-31 Thread Christopher Faylor
On Tue, Jul 31, 2012 at 03:01:02PM -0600, Warren Young wrote: This paragraph in the rebase package README: Note that rebaseall is only a stop-gap measure. Eventually the rebase functionality will be added to Cygwin's setup.exe, so that rebasing will happen automatically. ...should be

Re: New modes for cygpath that terminate path with null byte, nothing

2012-07-27 Thread Christopher Faylor
On Fri, Jul 27, 2012 at 01:08:02AM -0700, Daniel Colascione wrote: I wrote this patch because I often write this: $ cygpath -aw foo /dev/clipboard Today, cygpath always appends a newline to the information in the clipboard, which is annoying when trying to paste into a program that interprets

Re: *Very* outdated FAQ entry

2012-07-17 Thread Christopher Faylor
On Tue, Jul 17, 2012 at 07:31:02PM -0500, Yaakov (Cygwin/X) wrote: On 2012-07-17 14:08, Corinna Vinschen wrote: due to Aram's request for permission to translate the FAQ, I accidentally stumbled over FAQ entry 6.40, How should I port my Unix GUI to Windows?,

Re: [PATCH] regex: fix for kernel cross-compile

2012-06-11 Thread Christopher Faylor
On Mon, Jun 11, 2012 at 03:58:36PM -0500, Yaakov (Cygwin/X) wrote: The attached patch fixes the issue I reported previously: http://cygwin.com/ml/cygwin/2012-06/msg00161.html According to POSIX[1], a '|' following '(' produces undefined results. However, glibc and PCRE both allow the regex in

Re: elf.h incomplete

2012-06-10 Thread Christopher Faylor
On Sun, Jun 10, 2012 at 01:19:05PM -0500, Yaakov (Cygwin/X) wrote: On 2012-06-05 22:52, Christopher Faylor wrote: Sounds like it is good enough to check in. We can tweak it as needed. That didn't take long. :-) I had been testing with 3.3.7; the attached additional defines are needed

Re: elf.h incomplete

2012-06-05 Thread Christopher Faylor
On Tue, Jun 05, 2012 at 10:45:26PM -0500, Yaakov (Cygwin/X) wrote: On 2012-05-03 17:03, Yaakov (Cygwin/X) wrote: On 2012-05-03 10:24, Christopher Faylor wrote: Right. I've noticed the incompleteness of elf.h from time to time too but extending it would be tedious since you can't just cut/paste

Re: [PATCH] Ctrl-C and non-Cygwin programs

2012-05-26 Thread Christopher Faylor
On Fri, May 25, 2012 at 11:43:11AM -0700, Mark Lofdahl wrote: References: 4f73cf37.4020...@elfmimi.jp On 28/03/2012 10:55 PM, Ein Terakawa wrote: What it does actually is it generates CTRL_BREAK_EVENT with Windows Console API GenerateConsoleCtrlEvent on the arrival of SIGINT. And to make this

Re: elf.h incomplete

2012-05-03 Thread Christopher Faylor
On Thu, May 03, 2012 at 05:03:23PM -0500, Yaakov (Cygwin/X) wrote: On 2012-05-03 10:24, Christopher Faylor wrote: Right. I've noticed the incompleteness of elf.h from time to time too but extending it would be tedious since you can't just cut/paste from a GPLv* file. Maybe one of the BSDs has

Re: Building for nocygwin

2012-04-23 Thread Christopher Faylor
On Mon, Apr 23, 2012 at 02:35:16PM -0500, Yaakov (Cygwin/X) wrote: On 2012-04-23 10:37, Christopher Faylor wrote: On Mon, Apr 23, 2012 at 04:52:54PM +0200, Michel Bardiaux wrote: I *get* that. My problem was, the web is so cluttered with pages mentioning the no-cygwin thing (including

Re: Regenerate configures

2012-04-23 Thread Christopher Faylor
On Mon, Apr 23, 2012 at 05:17:10PM -0500, Yaakov (Cygwin/X) wrote: cygwin/doc/configure and cygwin/testsuite/configure are now the only configure scripts in the winsup tree which were generated with autoconf-2.5x. Any objections to regenerating them with 2.68? No, go ahead. cgf

Re: [PATCH] Setting TZ may break time() in non-Cygwin programs

2012-04-17 Thread Christopher Faylor
On Tue, Apr 17, 2012 at 09:06:15AM +0200, Corinna Vinschen wrote: On Apr 11 20:52, Christian Franke wrote: Yes. Patch is attached. Christian Thanks for the patch. I'm just wondering if we shouldn't generalize this right from the start by keeping an array of variables to skip when starting

Re: [PATCH] Setting TZ may break time() in non-Cygwin programs

2012-04-17 Thread Christopher Faylor
On Tue, Apr 17, 2012 at 10:37:18PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Tue, Apr 17, 2012 at 09:06:15AM +0200, Corinna Vinschen wrote: On Apr 11 20:52, Christian Franke wrote: Yes. Patch is attached. Christian Thanks for the patch. I'm just wondering if we shouldn't

Re: console: new mouse modes, request/response attempt

2012-04-02 Thread Christopher Faylor
On Mon, Apr 02, 2012 at 08:46:31PM +0200, Thomas Wolff wrote: This patch includes 2 things (to be fixed and separated anyway; change log still missing) for discussion: * mouse modes 6 and 15 (numeric mouse coordinates) * semi-fix for missing terminal status responses The fix tries to detect the

Re: console: new mouse modes, request/response attempt

2012-04-02 Thread Christopher Faylor
On Mon, Apr 02, 2012 at 09:50:17PM +0200, Thomas Wolff wrote: Am 02.04.2012 20:50, schrieb Christopher Faylor: On Mon, Apr 02, 2012 at 08:46:31PM +0200, Thomas Wolff wrote: This patch includes 2 things (to be fixed and separated anyway; change log still missing) for discussion: * mouse modes 6

Re: [PATCH] Ctrl-C and non-Cygwin programs

2012-04-01 Thread Christopher Faylor
On Thu, Mar 29, 2012 at 11:55:51AM +0900, Ein Terakawa wrote: This is a proof of concept demonstration which makes Ctrl-C behave in a way a lot of people expect concerning non-Cygwin console programs. What it does actually is it generates CTRL_BREAK_EVENT with Windows Console API

Re: Compiler warnings when building latest cygwin cvs with gcc-4.6 (1/2)

2012-03-29 Thread Christopher Faylor
On Thu, Mar 29, 2012 at 10:38:54AM -0400, Ryan Johnson wrote: On 29/03/2012 10:36 AM, Ryan Johnson wrote: Patch 1: fix function attribute conflicts Sorry, I appreciate the effort but I'd rather deal with these types of issues when we have a newer version of gcc available. If we don't have that

Re: [PATCH] doc: update tcl/tk FAQ

2012-02-29 Thread Christopher Faylor
On Wed, Feb 29, 2012 at 11:56:38PM -0600, Yaakov (Cygwin/X) wrote: On Wed, 2012-02-29 at 20:15 -0500, Christopher Faylor wrote: On Wed, Feb 29, 2012 at 06:57:27PM -0600, Yaakov (Cygwin/X) wrote: Using X requires user intervention to start an X server first. No amount of automatic dependencies

Re: fix tcgetsid return type

2012-02-27 Thread Christopher Faylor
On Mon, Feb 27, 2012 at 04:25:36PM -0700, Eric Blake wrote: Detected by gnulib's unit tests. POSIX requires tcgetsid to return pid_t, not int. 2012-02-27 Eric Blake ebl...@redhat.com * include/sys/termios.h (tcgetsid): Fix return type. * termios.cc (tcgetsid): Likewise. *

Re: [PATCH] Add pldd(1)

2012-02-24 Thread Christopher Faylor
On Fri, Feb 24, 2012 at 10:47:07AM +0100, Corinna Vinschen wrote: On Feb 24 02:38, Yaakov (Cygwin/X) wrote: The pldd(1) command apparently originates from Solaris and was added to glibc-2.15[1]. Patches and new file attached. Looks good, works fine. Please apply. It's not entirely fine.

Re: [PATCH] Add scandirat(3)

2012-02-21 Thread Christopher Faylor
On Tue, Feb 21, 2012 at 04:44:58PM -0600, Yaakov (Cygwin/X) wrote: scandirat(3) was added in glibc-2.15[1] and has supposedly been proposed for addition to POSIX.1[2]. Patch attached. Yaakov [1] http://sourceware.org/git/?p=glibc.git;a=blob_plain;f=NEWS [2]

Re: [PATCH] pthread.h: include time.h

2012-02-12 Thread Christopher Faylor
On Sun, Feb 12, 2012 at 04:04:02PM -0600, Yaakov (Cygwin/X) wrote: POSIX states: Inclusion of the pthread.h header shall make symbols defined in the headers sched.h and time.h visible. The reason being that some pthread functions take a clockid_t argument, and the CLOCK_* symbolic names are

Re: [PATCH] ldd: support .oct and .so modules

2012-01-23 Thread Christopher Faylor
On Mon, Jan 23, 2012 at 11:53:23PM -0600, Yaakov (Cygwin/X) wrote: Octave modules use the .oct extension, and several programs use .so for modules even on Cygwin (e.g. Apache2, Mesa, OpenSSL, Ruby). Currently, running ldd(1) on any of these returns ENOEXEC. The attached patch fixes ldd to treat

Re: [PATCH] Add get_current_dir_name(3)

2012-01-02 Thread Christopher Faylor
On Mon, Jan 02, 2012 at 05:56:26AM -0700, Eric Blake wrote: On 01/01/2012 12:13 AM, Yaakov (Cygwin/X) wrote: You have to check st_dev here too don't you? Of course. Revised patch for winsup/cygwin attached. +extern C char * +get_current_dir_name (void) +{ + char *pwd = getenv (PWD); +

Re: [PATCH] Add pthread_sigqueue(3)

2012-01-02 Thread Christopher Faylor
On Sun, Jan 01, 2012 at 12:59:00PM -0600, Yaakov (Cygwin/X) wrote: This patchset adds pthread_sigqueue(3), a GNU extension: http://www.kernel.org/doc/man-pages/online/pages/man3/pthread_sigqueue.3.html The implementation is based on the existing sigqueue(2) and pthread_kill(3) code. Patches for

Re: [PATCH] Add pthread_sigqueue(3)

2012-01-02 Thread Christopher Faylor
On Mon, Jan 02, 2012 at 10:09:21AM -0800, Daniel Colascione wrote: On 1/2/12 9:59 AM, Christopher Faylor wrote: On Sun, Jan 01, 2012 at 12:59:00PM -0600, Yaakov (Cygwin/X) wrote: I guess this can go in since I already implemented sigqueue but SI_QUEUE isn't actually fully functional. Cygwin

Re: [PATCH] Add get_current_dir_name(3)

2012-01-01 Thread Christopher Faylor
On Sun, Jan 01, 2012 at 01:13:25AM -0600, Yaakov (Cygwin/X) wrote: On Sun, 2012-01-01 at 01:46 -0500, Christopher Faylor wrote: On Sat, Dec 31, 2011 at 08:45:07PM -0600, Yaakov (Cygwin/X) wrote: +extern C char * +get_current_dir_name (void) +{ + char *pwd = getenv (PWD); + char *cwd

Re: [PATCH] Add get_current_dir_name(3)

2011-12-31 Thread Christopher Faylor
On Sat, Dec 31, 2011 at 08:45:07PM -0600, Yaakov (Cygwin/X) wrote: This patchset adds get_current_dir_name(3), a GNU extension: [snip] diff -u -p -r1.644 path.cc --- path.cc24 Dec 2011 13:11:34 - 1.644 +++ path.cc27 Dec 2011 11:28:06 - @@ -2855,6 +2855,27 @@ getwd (char *buf)

Re: [PATCH] Add getpt(3)

2011-12-30 Thread Christopher Faylor
On Fri, Dec 30, 2011 at 12:44:57AM -0600, Yaakov (Cygwin/X) wrote: getpt(3) is a GNU extension which predates posix_openpt(3): http://www.kernel.org/doc/man-pages/online/pages/man3/getpt.3.html The code itself is quite simple, but let me preempt some questions: 1) Yes, portable code should use

Re: [PATCH] Fix cancellation points list

2011-12-29 Thread Christopher Faylor
On Fri, Dec 30, 2011 at 12:25:25AM -0600, Yaakov (Cygwin/X) wrote: pthread_rwlock_timedrdlock and pthread_rwlock_timedwrlock aren't implemented yet. Patch attached. Yaakov 2011-12-30 Yaakov Selkowitz yselkowitz@... * thread.cc: Mark pthread_rwlock_timedrdlock and

Re: Add support for creating native windows symlinks

2011-12-23 Thread Christopher Faylor
On Fri, Dec 23, 2011 at 01:38:07PM -0800, Russell Davis wrote: Sigh... I've already addressed all of these ponts (there are simple ways to handle to all of them). I'm done fighting this battle. Actually, I don't think you did answer all of them. But, regardless, to summarize, what you were

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-08 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 07:42:48AM +0100, Christian Franke wrote: Christopher Faylor wrote: On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: Christopher Faylor wrote: ... /usr/local/src/trunk/objdir.withada/./prev-gcc/g++ -B/usr/local/src/trunk/objdir.withada/./prev-gcc

Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:17:49PM -0400, Christopher Faylor wrote: On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: ... OK, __INSIDE_CYGWIN__ is not needed here in practice

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: Christopher Faylor wrote: I guess this is why there was a __INSIDE_CYGWIN__ test. Christian, could you submit a new patch to rectify this problem? OK, will try soon. ... /usr/local/src/trunk/objdir.withada/./prev-gcc/g

Re: ptsname_r

2011-11-10 Thread Christopher Faylor
On Tue, Nov 08, 2011 at 01:04:18AM -0500, Christopher Faylor wrote: On Mon, Nov 07, 2011 at 01:59:40PM -0700, Eric Blake wrote: On 11/07/2011 01:46 PM, Eric Blake wrote: Thanks. Also, even with your patches of today, ptsname() is still not thread-safe; should we be sticking that in a thread

Re: ptsname_r

2011-11-07 Thread Christopher Faylor
On Mon, Nov 07, 2011 at 01:59:40PM -0700, Eric Blake wrote: On 11/07/2011 01:46 PM, Eric Blake wrote: Thanks. Also, even with your patches of today, ptsname() is still not thread-safe; should we be sticking that in a thread-local buffer rather than in static storage, similar to how other

Re: Extend faq.using to discuss fork failures

2011-11-04 Thread Christopher Faylor
On Fri, Nov 04, 2011 at 01:34:09PM +, Jon TURNEY wrote: On 03/11/2011 21:05, Christopher Faylor wrote: I would still prefer eschewing actively negative words like hostile and just neutrally stating that Windows does not use a fork/exec model and does not offer any easy way to implement

Re: Extend faq.using to discuss fork failures

2011-11-03 Thread Christopher Faylor
On Thu, Nov 03, 2011 at 04:35:25PM +, Jon TURNEY wrote: On 30/08/2011 14:41, Ryan Johnson wrote: That sounds reasonable, though I suspect we'd want want to keep the concluding bits in the FAQ as well. Unfortunately, summertime free time has come to an end so I don't know when I'll get to

Re: [PATCH] Prevent restart of crashing non-Cygwin exe

2011-11-03 Thread Christopher Faylor
On Thu, Nov 03, 2011 at 01:07:20PM +0100, Corinna Vinschen wrote: On Nov 2 20:53, Christian Franke wrote: On Jun 24, Corinna Vinschen wrote: Hi Christian, On Jun 23 19:52, Christian Franke wrote: If a non-Cygwin .exe started from a Cygwin shell window segfaults, Cygwin restarts the .exe 5

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: ... diff --git a/winsup/cygwin/include

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: ... OK, __INSIDE_CYGWIN__ is not needed here in practice (but possibly in theory :-) I would rather see as little __INSIDE_CYGWIN__

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: The file include/sys/wait.h provides union wait but neither the wait() functions nor the W*() macros allow to actually use it. Compilation of cdrkit 1.1.11 fails because the configure check assumes that union wait is the status

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: Christopher Faylor wrote: On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: ... diff --git a/winsup/cygwin/include/cygwin/wait.h b/winsup/cygwin/include/cygwin/wait.h index bed81b7..e4edba2 100644 --- a/winsup

Re: Fix strace tracing of forked processes when attaching to a process with --pid

2011-09-13 Thread Christopher Faylor
On Tue, Sep 13, 2011 at 01:04:55PM +0100, Jon TURNEY wrote: At the moment, --trace-children (enabled by default) only works when the straced process is started by using strace with a command line. This patch uses the undocumented NtSetInformationProcess(ProcessDebugFlags) call to make

Re: [PATCH] Fix strace -T

2011-09-08 Thread Christopher Faylor
On Thu, Sep 08, 2011 at 07:37:29PM +0100, Jon TURNEY wrote: strace -T to toggle stracing of a process doesn't seem to work at the moment. Attached is a patch to make it work again. 2011-09-08 Jon TURNEY jon.tur...@dronecode.org.uk * include/sys/strace.h (strace): Add toggle() method

Re: Extend faq.using to discuss fork failures

2011-08-30 Thread Christopher Faylor
On Tue, Aug 30, 2011 at 11:00:20AM +0200, Corinna Vinschen wrote: Hi Ryan, Thanks for the FAQ entry. I had a look now, finally. Two nits: On Aug 25 22:08, Ryan Johnson wrote: Index: winsup/doc/faq-using.xml === RCS file:

Re: [PATCH] profile support

2011-08-29 Thread Christopher Faylor
On Tue, Aug 30, 2011 at 05:10:39AM +0900, jojelino wrote: On 2011-08-23 PM 2:40, Christopher Faylor wrote: On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: Index: winsup/cygwin/Makefile.in === RCS file: /cvs/src/src

Re: Overflow cygthreads (those which use simplestub) don't set notify_detached event which may cause timer_delete to hung

2011-08-25 Thread Christopher Faylor
On Thu, Aug 25, 2011 at 08:06:08PM +0100, Rafal Zwierz wrote: * cygthread.cc (cygthread::simplestub): Notify that the thread has detached also in freerange thread case. Looks good. I'll check this in. Thanks. cgf

  1   2   3   4   5   6   7   8   9   10   >