Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

On Thu, Dec 20, 2007 at 07:15:53AM -0800, Brian Dessent wrote: >Brian Dessent wrote: > >> Fortunately, I have VMware with a Win98 image here. >> >> The problem is that bloda.c calls NtQuerySystemInformation without using >> any kind of autoload.cc-type indirection, and so cygcheck gets a hard >> d

Re: Cygheap page boundary allocation bug.

On Tue, Dec 11, 2007 at 02:26:17PM -, Dave Korn wrote: >On 11 December 2007 14:19, Christopher Faylor wrote: > >> On Tue, Dec 11, 2007 at 12:18:17PM -, Dave Korn wrote: >>> 2007-12-11 Dave Korn <[EMAIL PROTECTED]> >>> >>> * cyghea

Re: Cygheap page boundary allocation bug.

On Tue, Dec 11, 2007 at 12:18:17PM -, Dave Korn wrote: >2007-12-11 Dave Korn <[EMAIL PROTECTED]> > > * cygheap.cc (_csbrk): Don't request zero bytes from VirtualAlloc, > as windows treats that as an invalid parameter and returns an error. Ok. cgf

Re: Resource Temporarily Unavailable workaround

On Thu, Nov 22, 2007 at 05:55:05PM +, Andrew STUBBS wrote: >Christopher Faylor wrote: >>On Thu, Nov 22, 2007 at 12:00:51PM -0500, Christopher Faylor wrote: >>>On Thu, Nov 22, 2007 at 04:41:54PM +, Andrew STUBBS wrote: >>>>The attached patch adds a &

Re: Resource Temporarily Unavailable workaround

On Thu, Nov 22, 2007 at 12:00:51PM -0500, Christopher Faylor wrote: >On Thu, Nov 22, 2007 at 04:41:54PM +, Andrew STUBBS wrote: >>The attached patch adds a 'retry' to the fork system call. Basically >>it waits 10 seconds to allow the 'resource temporarily unavail

Re: Resource Temporarily Unavailable workaround

On Thu, Nov 22, 2007 at 04:41:54PM +, Andrew STUBBS wrote: >The attached patch adds a 'retry' to the fork system call. Basically >it waits 10 seconds to allow the 'resource temporarily unavailable' to >become (temporarily) available once more, and tries again, up to a >maximum of three attempt

Re: [Patch] Encode invalid chars in /proc/registry entries

On Fri, Nov 16, 2007 at 08:35:48PM +0100, Christian Franke wrote: > Christopher Faylor wrote: >> .. >>>> Patch is tested with 1.5.24-2. Merge with HEAD looks good, but was not >>>> actually tested. Therefore, no changelog provided yet. >>>>

Re: [Patch] Encode invalid chars in /proc/registry entries

On Fri, Nov 16, 2007 at 12:09:01PM +0100, Corinna Vinschen wrote: >Hi Christian, > >On Nov 15 22:56, Christian Franke wrote: >> Registry key and value names may contain chars which are not allowed within >> file names ('/', '\', ":"). But Cygwin's /proc/registry returns these names >> unchanged t

Re: Rewrite/fix cygwin1.dbg generation

On Thu, Nov 08, 2007 at 12:03:59AM +, Pedro Alves wrote: > Christopher Faylor wrote: > >> That would be fine with me. OTOH, if the dllfixdbg isn't doing the >> right thing for gdb couldn't it be adapted to include the required >> sections? > &

Re: Rewrite/fix cygwin1.dbg generation

On Mon, Nov 05, 2007 at 12:20:48PM +0100, Corinna Vinschen wrote: >On Nov 5 10:19, Pedro Alves wrote: >> Corinna Vinschen wrote: >> > On Nov 4 04:00, Pedro Alves wrote: >> > > >> > > Ah, got it. VirtualAlloc fails on the first _csbrk, since it >> > > is tripping on the VMA of .gnu_debuglink ...

Re: Rewrite/fix cygwin1.dbg generation

On Sun, Nov 04, 2007 at 12:48:38AM -0700, Brian Dessent wrote: >Pedro Alves wrote: > >> 10 .cygheap 000a 611e 611e 2**2 >> ALLOC >> 11 .gnu_debuglink 0010 6128 6128 001d0a00 2**2 >> CONTENTS, READONLY, DEBUGGING >> >

Re: Rewrite/fix cygwin1.dbg generation

On Sat, Nov 03, 2007 at 10:44:26AM -0700, Brian Dessent wrote: >Pedro Alves wrote: > >> The dllfixdbg hunk looks hard to read. Here's what is looks >> like after patching: > >I think that if whatever bugs used to exist in older binutils PE support >that necessitated this hackery are now gone, we c

Re: [patch] inline __getreent in newlib

On Fri, Sep 07, 2007 at 04:19:12PM -0700, Brian Dessent wrote: >Brian Dessent wrote: > >> Done. I added the following comment to config.h to hopefully clarify >> the situation: >> >> /* The following provides an inline version of __getreent() for newlib, >>which will be used throughout the li

Re: [patch] inline __getreent in newlib

On Thu, Sep 06, 2007 at 04:38:04PM -0700, Brian Dessent wrote: > >I noticed today that all instances of _REENT in newlib go through a >function call to __getreent(). All this function does is get the value >of %fs:4 and subtract a fixed offset from it, so this seems rather >wasteful. And we alrea

Re: [patch] Fix multithreaded snprintf

On Thu, Sep 06, 2007 at 11:53:02AM -0700, Brian Dessent wrote: >Christopher Faylor wrote: >> Nice catch! > >I wish I could say I caught this by inspection but it was only by single >stepping through python guts that it became apparent what was going on. Better you than me. :-) cgf

Re: [patch] Fix multithreaded snprintf

On Thu, Sep 06, 2007 at 11:30:17AM -0700, Brian Dessent wrote: > >I tracked down the problem reported in >. The crash was >occuring in pthread_mutex_lock, but that's a bit of a red herring. The >real problem is that both newlib and Cygwin pro

Re: FW: mkgroup (366): [2123] The API return buffer is too small.

On Thu, Aug 30, 2007 at 05:44:39PM +0100, Dave Korn wrote: >On 30 August 2007 01:35, Brian Egge wrote: > >> When running mkgroup after installing cygwin I receive the following >> error: >> >> $ mkgroup -l -d > /etc/group >> mkgroup (366): [2123] The API return buffer is too small. >> >> I suspe

Re: Signal handler not executed

On Mon, Aug 13, 2007 at 12:25:49PM -0700, Peter Rehley wrote: > On Aug 9, 2007, at 10:19 AM, Christopher Faylor wrote: >>On Thu, Aug 09, 2007 at 01:09:48PM -0400, Ernie Coskrey wrote: >>>There's a very small window of vulnerability in _sigbe, which can lead >>>to si

Re: Signal handler not executed

On Thu, Aug 09, 2007 at 01:09:48PM -0400, Ernie Coskrey wrote: >There's a very small window of vulnerability in _sigbe, which can lead >to signal handlers not being executed. In _sigbe, the _cygtls lock is >released before incyg is decremented. If setup_handler acquires the >lock just after _sigb

Re: Doc change request

On Wed, Jul 18, 2007 at 08:05:59AM -0700, Brian Dessent wrote: >Christopher Faylor wrote: >> Could I ask someone to do a search and replace on the docs and >> change all occurrences of /usr/man and /usr/doc to /usr/share/man >> and /usr/share/doc? >> >> Brian

Re: Failure in rebuilding Cygwin-1.5.24-2 with recent newlib

On Sat, Jun 16, 2007 at 09:47:41PM +0200, Corinna Vinschen wrote: >On Jun 16 08:38, Brian Dessent wrote: >> This is just due to __FBSDID not getting #defined to blank properly. >> The file includes sys/cdefs.h and newlib's copy contains the required >> bit (#define __FBSDID(x) /* nothing */) howev

Re: [Patch] "strace ./app.exe" probably runs application from /bin

On Sat, Jun 02, 2007 at 04:28:34PM -0700, Brian Dessent wrote: >Christopher Faylor wrote: > >> Let me rephrase the problem: >> >> "cygpath does not properly deal with the current directory" >> >> Thanks for the patch but we won't be applying i

Re: [Patch] "strace ./app.exe" probably runs application from /bin

On Sun, Jun 03, 2007 at 06:21:12PM +0200, Christian Franke wrote: > The attached patch is a quick hack (again, sorry ;-) to fix this. Was I too polite in my previous refusal of a "quick hack"? cgf

Re: [Patch] "strace ./app.exe" probably runs application from /bin

On Sat, Jun 02, 2007 at 04:51:31PM +0200, Christian Franke wrote: >Running an application with strace from current directory may not work >as expected. >The "./" is not passed to CreateProcess() and the default app search >rules apply >(1. strace.exe directory, 2. cwd, ..., 6. PATH) > >Therefore

Re: [Patch] Segfault on unaligned lseek() on /dev/sdX (was: [ITP] ddrescue 1.3)

On Fri, May 18, 2007 at 10:23:41PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >>On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote: >> >>>... >>> >>> >>> >> >>It seems like this could be done without

Re: [Patch] Segfault on unaligned lseek() on /dev/sdX (was: [ITP] ddrescue 1.3)

On Fri, May 18, 2007 at 09:02:15PM +0200, Christian Franke wrote: >Hi, > >Cygwin 1.5.24-2 segfaults on unaligned lseek() on raw block devices with >sector size >512 bytes. > >Testcases: >$ dd skip=1000 bs=2047 if=/dev/scd0 of=/dev/null > >$ ddrescue -c 1 /dev/scd0 file.iso > > >This is due to a fi

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Mon, Apr 16, 2007 at 10:50:04AM -0400, Christopher Faylor wrote: >On Fri, Apr 06, 2007 at 02:46:12PM -0400, Ryan C. Gordon wrote: >>>>Actually, I'd appreciate it if the patch could be resubmitted against >>>>current CVS. >>>I'll do this shortly.

Re: export a few newlib functions

On Mon, May 14, 2007 at 06:51:32PM -0600, Eric Blake wrote: >As discussed this morning: > >2007-05-14 Eric Blake <[EMAIL PROTECTED]> > > * cygwin.din (asnprintf, dprint, _Exit, vasnprintf, vdprintf): > Export. > * include/cygwin/version.h: Bump API minor number. Applied. Thank

Re: Dumper produces unuseable dumps (fix).

On Fri, Apr 27, 2007 at 04:01:29PM +0100, Pedro Alves wrote: >On 4/27/07, Corinna Vinschen wrote: > >>Unfortunately, the patch is too big to fall under the trivial patch >>rule, so Red Hat needs a signed copyright assignment from you. >>Please have a look on http://cygwin.com/contrib.html, especial

Re: [patch] support -gdwarf-2 when creating cygwin1.dbg

On Wed, Apr 18, 2007 at 06:17:59AM -0700, Brian Dessent wrote: >Christopher Faylor wrote: > >> Thanks for doing this. Please check in. Can we switch to dwarf-2 by >> default in the cygwin makefile(s)? > >I thought about that, but the problem is anything you do to *FLAGS

Re: [patch] support -gdwarf-2 when creating cygwin1.dbg

On Wed, Apr 18, 2007 at 05:44:25AM -0700, Brian Dessent wrote: > >The attached patch allows for dllfixdbg to copy DWARF-2 debug sections >into the .dbg file. There was also an (accidently?) duplicated section >in the cygwin.sc linker script that I removed while I was there. > >The advantages of be

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Fri, Apr 06, 2007 at 02:46:12PM -0400, Ryan C. Gordon wrote: >>>Actually, I'd appreciate it if the patch could be resubmitted against >>>current CVS. >>I'll do this shortly. > >I just checked...the patch still applies cleanly to the latest CVS...the >changed files haven't been altered between

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Wed, Apr 04, 2007 at 02:18:33PM -0400, Christopher Faylor wrote: >On Wed, Apr 04, 2007 at 06:03:09PM +0200, Corinna Vinschen wrote: >>Ryan, >> >>On Apr 4 10:49, Corinna Vinschen wrote: >>> On Apr 4 04:26, Ryan C. Gordon wrote: >>> > >>> >

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Wed, Apr 04, 2007 at 06:03:09PM +0200, Corinna Vinschen wrote: >Ryan, > >On Apr 4 10:49, Corinna Vinschen wrote: >> On Apr 4 04:26, Ryan C. Gordon wrote: >> > >> > >mnt_type is always "system" or "user" ... this patch changes this to >> > >make an earnest effort to match what a GNU/Linux sys

Re: PATCH: Fix resource leak in cygpath.cc

Hi Mark, On Fri, Mar 30, 2007 at 03:42:26PM -0700, Mark Mitchell wrote: >Mark Mitchell wrote: >> The cygpath utility calls FindFirstFile, but never calls FindClose. As >> a result, in leaks search handles. When you're using it for just one >> file, that's not a big deal, but if you feed it enough

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Mon, Mar 19, 2007 at 12:58:26PM -0400, Ryan C. Gordon wrote: >>Thanks for the patch and I hope you will be able/willing to send in >>an assignment to Red Hat. > >No problem. I wasn't sure if this qualified as "big enough" to require >the form, but I'll send it in today. It's not really that bi

Re: [PATCH] getmntent()->mnt_type values that match Linux...

On Mon, Mar 19, 2007 at 02:30:16AM -0400, Ryan C. Gordon wrote: > >There was a discussion quite some time ago about getmntent()'s mnt_type >field: > > http://www.cygwin.com/ml/cygwin-developers/2002-09/msg00078.html > >...but nothing seems to have come of it. I noticed that Cygwin builds of >Ph

Re: Bug in pread/pwrite ?

On Fri, Mar 09, 2007 at 12:05:47AM +0100, Christophe GRENIER wrote: >After upgrading my compiler from cygwin 1.5.17-1 to 1.5.24-2, TestDisk >& PhotoRec, my GPL data recovery programs, were unable to read data! Please calm down. >I have written a little program (see attachment) to reproduce the >p

Re: Increase st_blksize to 64k

On Wed, Jan 03, 2007 at 02:35:57PM +0100, Corinna Vinschen wrote: >On Jan 3 06:20, Eric Blake wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> According to Corinna Vinschen on 1/3/2007 5:16 AM: >> > >> > Setting st_blksize to 64K might be a good idea for disk I/O if the value >>

Re: Increase st_blksize to 64k

On Tue, Jan 02, 2007 at 12:04:49PM -0600, Brian Ford wrote: >As suggested here: > >http://cygwin.com/ml/cygwin/2006-12/msg00911.html > >2007-01-02 Brian Ford <[EMAIL PROTECTED]> > > * fhandler.cc (fhandler_base::fstat): Use system page size (64k) > as the st_blksize prefered I/O size

Re: Additional Proxy support needed

On Wed, Dec 27, 2006 at 01:17:47PM -0500, Stephen More wrote: >Currently setup only supports Proxy-Authenticate: Basic > >If a proxy does not support basic, it no longer stays in a loop, it >will log and return. > >At some point I hope to submit another patch that implements >Proxy-Authenticate: NT

Re: [RFC][patch] cygwin/singal.h is not compatible with -std=c89 or -std=c99

On Mon, Nov 27, 2006 at 05:24:14PM +0100, Corinna Vinschen wrote: >On Nov 27 11:16, Christopher Faylor wrote: >> On Mon, Nov 27, 2006 at 04:35:19PM +0100, Corinna Vinschen wrote: >> >On Nov 27 10:17, Christopher Faylor wrote: >> >> How about the alternative "Don&

Re: [RFC][patch] cygwin/singal.h is not compatible with -std=c89 or -std=c99

On Mon, Nov 27, 2006 at 04:35:19PM +0100, Corinna Vinschen wrote: >On Nov 27 10:17, Christopher Faylor wrote: >> How about the alternative "Don't do that" approach? I think there are >> other parts of the header files which won't work with -std=c89.

Re: [RFC][patch] cygwin/singal.h is not compatible with -std=c89 or -std=c99

On Mon, Nov 27, 2006 at 09:33:41AM +0100, Corinna Vinschen wrote: >On Nov 25 16:46, V?clav Haisman wrote: >> [FreeBSD] >> struct sigaction { >> union { >> void(*__sa_handler)(int); >> void(*__sa_sigaction)(int, struct __siginfo *, void *); >>

Re: Missing DEV_SD1_MAJOR in dtable.cc

On Mon, Nov 06, 2006 at 10:23:15AM -0600, Loh, Joe wrote: >Thank you so much Eric for setting us straight on submitting patches, >and Corinna for making change before we had a chance to followup with >Eric's recommendation. > >We will be sorting out the necessary documentation in order to >submitti

Re: [PATCH] cygcheck: follow symbolic links

On Thu, Oct 05, 2006 at 05:29:59PM +0200, Corinna Vinschen wrote: >On Sep 28 09:06, Igor Peshansky wrote: >> On Mon, 24 Jul 2006, Corinna Vinschen wrote: >> [...] >> > The latest fax was about this change, so I think this should still be >> > covered, shouldn't it? Ping the guy nevertheless. We s

Re: [ANNOUNCEMENT] Updated [experimental]: bash-3.1-7

On Wed, Sep 13, 2006 at 06:57:15AM -0600, Eric Blake wrote: >According to Christopher Faylor on 9/12/2006 9:15 AM: >>> 2006-09-11 Eric Blake <[EMAIL PROTECTED]> >>> >>> * cygcheck.cc (main): Restore POSIXLY_CORRECT before displaying >>> use

Re: [ANNOUNCEMENT] Updated [experimental]: bash-3.1-7

On Tue, Sep 12, 2006 at 12:05:06PM +, Eric Blake wrote: >> > That is being set by cygcheck, just before invoking external programs. It >> > probably had something to do with forcing external programs to not >> > rearrange >> > option arguments (for example, "ls foo --all" treats --all as an

Re: [RFC] Simplify MinGW canadian crosses

Grr. My mailer added a Reply-To to the previous message. Apologies to all who were impacted! cgf

Re: [RFC] Simplify MinGW canadian crosses

On Tue, Aug 29, 2006 at 06:49:06PM +0200, Corinna Vinschen wrote: >On Aug 29 12:09, Daniel Jacobowitz wrote: >> On Tue, Aug 29, 2006 at 06:04:06PM +0200, Corinna Vinschen wrote: >> > On Aug 29 11:47, Christopher Faylor wrote: >> > > Btw, I agree with Daniel's s

Re: [RFC] Simplify MinGW canadian crosses

On Tue, Aug 29, 2006 at 05:35:40PM +0200, Corinna Vinschen wrote: >On Aug 29 11:09, Daniel Jacobowitz wrote: >> On Tue, Aug 29, 2006 at 10:59:27AM -0400, DJ Delorie wrote: >> > >> > > If you want to build some code that runs on mingw, I don't think >> > > that having mingw tools installed is an un

Re: [PATCH] do_mount bug fix

On Mon, Aug 21, 2006 at 02:17:19PM -0400, Wang Yiping wrote: >>cgf wrote: >>>Please provide a simple and complete test case which illustrates the >>>problem. >>> >On Mon, Aug 21, 2006 at 02:11:44PM -0400, Wang Yiping wrote: >>OK, here is the test-case :-) >> >>mkdir /tmp/test123 mount -u -o managed

Re: [PATCH] do_mount bug fix

On Mon, Aug 21, 2006 at 01:52:06PM -0400, Wang Yiping wrote: >When doing managed mount with none exist win32path It can't umount again. >We have to delete the entry from the windows registry by hand. > >$ df >Filesystem 1K-blocks Used Available Use% Mounted on >D:\dev\cygwin\home\ype

Re: [PATCH] pread bug fix

On Sun, Aug 20, 2006 at 03:11:37AM +0900, Hideki IWAMOTO wrote: >When current file offset is not zero, pread from disk file always fails. > > >2006-08-20 Hideki Iwamoto <[EMAIL PROTECTED]> > > * fhandler_disk_file.cc (fhandler_disk_file::pread): Fix comparison > of return value of lsee

Re: Prevent closing a NULL pinfo handle

On Thu, Aug 17, 2006 at 03:09:13PM -0500, Brian Ford wrote: >I confess to not having a clue what is really going on here, but I'm >seeing the following errors from a CVS build (yes, I know debugging has >been turned on), and it looks like this would be the right thing to do: > >CloseHandle(moreinfo

Re: FW: Patch for script of util-linux-2.12r-2 with zsh.

On Thu, Aug 17, 2006 at 12:19:48PM -0400, Charli Li wrote: >Redirected to the Cygwin-Patches Mailing List. WHY? Go back and read the description for this mailing list. It isn't appropriate here. Sheesh. cgf

Re: get_readahead; remove duplicate

On Wed, Jul 26, 2006 at 10:18:45PM -0500, Brian Ford wrote: >One more tiny one. > >2006-07-26 Brian ford <[EMAIL PROTECTED]> > > * fhandler.cc (fhandler_base::read): Call > get_readahead_into_buffer instead of duplicating it. Applied. Thanks. cgf

Re: check_iovec cleanup

On Wed, Jul 26, 2006 at 07:15:43PM -0500, Brian Ford wrote: >On Wed, 26 Jul 2006, Christopher Faylor wrote: > >> Thanks for the patch, > >Thanks for the review. > >> but I'm not convinced that this patch duplicates the functionality that >> you eliminated f

Re: check_iovec cleanup

On Wed, Jul 26, 2006 at 05:53:35PM -0500, Brian Ford wrote: >I think this removes some redundancy and a questionable check while being >more straight forward and covering more possible fault cases. Please let >me know if I missed a reason it had to be that way. > >2006-07-26 Brian Ford <[EMAIL P

Re: allow read into untouched noreserve mappings

On Tue, Jul 18, 2006 at 08:22:38AM -0500, Brian Ford wrote: >On Mon, 17 Jul 2006, Brian Ford wrote: >> Untested this time because I have to run to an appointment. > >Now tested and working fine with no changes. > >I guess I can infer from cgf's mail to cygwin-developers that this will >not make it

Re: UTF-8 Cygwin

On Fri, Jul 07, 2006 at 01:14:36PM +0900, SUZUKI Hisao wrote: >Christopher Faylor wrote: >>I hate to say this but I really don't like doing things this way. If >>we need to use wide character support then it should just be a >>wholesale replacement, not a bunch o

Re: UTF-8 Cygwin

On Fri, Jul 07, 2006 at 09:41:52AM +0900, SUZUKI Hisao wrote: >Dave Korn wrote: >>On 06 July 2006 07:28, SUZUKI Hisao wrote: >> >> >>>Sorry, but I cannot access to CVS server because of firewall. So the >>>patch file was made from the cygwin-1.5.20-1-src. >> >> Here it is, blindly applied to curr

Re: Command line argument to setup.exe for a package list to install

On Thu, Jul 06, 2006 at 12:30:03PM +0100, Mike Rose wrote: >Hi, > >We like cygwin for remotely managing windows computers using ssh. Therefore >we like a command line install of cygwin sshd: >http://www.tcm.phy.cam.ac.uk/~mr349/cygwin_install.html > >Here's the patch that my colleague did: >http:/

Re: UTF-8 Cygwin

On Tue, Jun 27, 2006 at 02:46:56PM +0900, SUZUKI Hisao wrote: ># I should have posted this message to this list from the first. > >I made a patch to cygwin1.dll to support UTF-8. > >It allows you to use all of characters and file (or path) names >allowed in Windows, while keeping binary-compatibili

Re: [Patch] Updating cygwin_dll_init()

On Tue, May 30, 2006 at 02:12:22PM -0700, Max Kaehn wrote: >The recent change (on 2006-05-24) to _dll_crt0() calls dll_crt0_1() >via _cygtls::call() instead of calling it directly. The call in >_cygtls::call2() to ExitThread() means that anyone using >cygwin_dll_init() will find that their main th

Re: Fix leaky pipe

On Tue, May 30, 2006 at 02:19:14AM +0100, Dave Korn wrote: >On 29 May 2006 23:01, Christopher Faylor wrote: >>On Mon, May 29, 2006 at 09:48:50AM +0100, Dave Korn wrote: >>>As discussed elsewhere, here's a patch that solves the race problem >>>without leaking handle

Re: Fix leaky pipe

On Mon, May 29, 2006 at 09:48:50AM +0100, Dave Korn wrote: >As discussed elsewhere, here's a patch that solves the race problem >without leaking handles any more by placing the master-pipe-closing >logic where it really belongs, in fhandler_tty_common::close where the >send-an-EOF decision is made.

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Thu, Apr 13, 2006 at 12:24:56PM -0400, Christopher Faylor wrote: >On Thu, Apr 13, 2006 at 05:48:22AM -0700, Gary Zablackis wrote: >>> The exception handler is supposed to be initialized >>> in >>> _cygtls::init_thread which is called from >>> initialize_

Re: Using newer autoconf in src/winsup directory

On Tue, May 23, 2006 at 10:51:59AM -0400, Christopher Faylor wrote: >On Tue, May 23, 2006 at 07:45:32PM +1200, Danny Smith wrote: >>RE: http://cygwin.com/ml/cygwin-patches/2006-q2/msg00051.html >> >>I am not subscribed to cygwin-patches so I'm posting here. Forgive

Re: fhandler_base::readv

On Tue, May 23, 2006 at 10:23:38PM -0400, Lev Bishop wrote: >On 5/23/06, Lev Bishop wrote: > >>It does make sense. Try this version. > >Sorry, no. I'm stupid - ignore that version. There's not much point in >doing assert(len>=0) given that len is unsigned, it's pretty much a >given :-) How about ju

Re: select.cc exitsock error cleanup

On Tue, May 23, 2006 at 10:28:51PM -0400, Lev Bishop wrote: >On 5/23/06, Christopher Faylor wrote: >>I've checked in a variation of this patch but I've used si->exitsock >>for consistency. > >I'm sure that's wrong. With your version, the next time selec

Re: fhandler_base::readv

On Tue, May 23, 2006 at 08:28:58PM -0400, Lev Bishop wrote: >2006-05-23 Lev Bishop <[EMAIL PROTECTED]> > > * fhandler.cc (readv): Deal with tot not precalculated. >Index: fhandler.cc >=== >RCS file: /cvs/src/src/winsup/cygwin/

Re: select.cc exitsock error cleanup

On Tue, May 23, 2006 at 08:04:31PM -0400, Lev Bishop wrote: >2006-05-23 Lev Bishop <[EMAIL PROTECTED]> > > * select.cc (start_thread_socket): Clean up exitsock in case of > error. >Index: select.cc >=== >RCS file: /cvs/

Re: Using newer autoconf in src/winsup directory

On Tue, May 23, 2006 at 07:45:32PM +1200, Danny Smith wrote: >RE: http://cygwin.com/ml/cygwin-patches/2006-q2/msg00051.html > >I am not subscribed to cygwin-patches so I'm posting here. Forgive me >if I've transgressed boundares, but I've always considered mingw as a >cygwin-dependent app. > >Appl

Re: Using newer autoconf in src/winsup directory

On Thu, May 04, 2006 at 01:47:25PM -0700, Steve Ellcey wrote: >I have been working to move the src tree at soureware.org to a newer >version of autoconf. The reason for this is so that we can, in turn, >move to a newer version of libtool. Would it be possible to rebuild the >configure scripts in

Re: Getting the pipe guard

On Sun, May 21, 2006 at 10:56:53AM -0400, Lev Bishop wrote: >>On 5/21/06, Christopher Faylor wrote: >> >>> I've checked in a variation of the above plus some modifications to >>> pipe.cc which prevent some handle stomping and may make things work >>> b

Re: Getting the pipe guard

On Sat, May 20, 2006 at 09:43:16PM -0400, Lev Bishop wrote: >Index: select.cc >=== >RCS file: /cvs/src/src/winsup/cygwin/select.cc,v >retrieving revision 1.123 >diff -u -p -d -r1.123 select.cc >--- select.cc 24 Apr 2006 15:16:45 -

Re: Open sockets non-overlapped?

On Fri, May 19, 2006 at 04:17:56PM -0400, Lev Bishop wrote: >On 5/19/06, Christopher Faylor wrote: >>On Fri, May 19, 2006 at 11:19:45AM -0400, Lev Bishop wrote: >>>Here's a trivial little patch for your consideration (while I wait for >>>my copyright assignment to

Re: Open sockets non-overlapped?

On Fri, May 19, 2006 at 11:19:45AM -0400, Lev Bishop wrote: >Here's a trivial little patch for your consideration (while I wait for >my copyright assignment to go through). > >It makes it so that cygwin sockets can be passed usefully to windows >processes. Eg: >$ cmd /c dir > /dev/tcp/localhost/500

Re: [patch] make clean

On Wed, May 10, 2006 at 02:04:59AM -0700, Brian Dessent wrote: > >Doing a "make clean" inside winsup/cygwin leaves behind a stale >cygwin1.dbg file. Go ahead and check this in, Brian. Thanks. cgf >2006-05-10 Brian Dessent <[EMAIL PROTECTED]> > > * Makefile.in (clean): Also delete *.dbg.

Re: [Patch] Adding ".." may not work in readdir()

On Mon, May 08, 2006 at 04:42:27PM +0200, Christian Franke wrote: >Both else-if conditions at the end of readdir() are identical, so ".." >case will never be executed. > >The attached patch for fhandler_disk_file.cc 1.183 may fix this >(untested blind patch, sorry ;-) Thanks for the patch. I've

Re: [Patch] Make getenv() functional before the environment is initialized

On Mon, Apr 24, 2006 at 12:35:59PM -0400, Christopher Faylor wrote: >I get a "it works" when I do this. > >#include > >int >main (int argc, char **argv) >{ > if (*argv[0] == 'f') >puts ("it works"); >} But, in keeping with my

Re: [Patch] Make getenv() functional before the environment is initialized

On Mon, Apr 24, 2006 at 12:16:34PM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Christopher Faylor" >To: >Sent: Friday, April 21, 2006 5:39 PM >Subject: Re: [Patch] Make getenv() functional before the environment is >initialized > > >

Re: [Patch] Make getenv() functional before the environment is initialized

I just talked to Corinna about this on IRC and neither of us really cares enough about this to merit a long discussion so I've just checked in a variation of the cmalloc patch. The only change that I made was to define a HEAP_2_STR value so that the HEAP_1_MAX usage is confined to cygheap.cc where

Re: [Patch] Make getenv() functional before the environment is initialized

On Fri, Apr 21, 2006 at 04:32:25PM -0400, Pierre A. Humblet wrote: >From: "Christopher Faylor" <...> >To: http://cygwin.com/acronyms/#PCYMTNQREAIYR cgf

Re: [Patch] Make getenv() functional before the environment is initialized

On Fri, Apr 21, 2006 at 03:45:54PM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Christopher Faylor" <[EMAIL PROTECTED]> ^^^ >To: <[EMAIL PROTECTED]>

Re: [Patch] Make getenv() functional before the environment is initialized

On Fri, Apr 21, 2006 at 02:52:06PM -0400, Pierre A. Humblet wrote: >- Original Message - >From: "Corinna Vinschen" >To: >Sent: Friday, April 21, 2006 1:23 PM >Subject: Re: [Patch] Make getenv() functional before the environment is >initialized > > >>On Apr 6 12:35, Pierre A. Humblet wro

Re: mkstemp vs. text mode

On Mon, Apr 17, 2006 at 06:18:38AM -0600, Eric Blake wrote: >Should we change mkstemp to always open in binary mode, regardless of >the mount mode of the directory of the template name? Arguments for >this is that mkstemp is often used by programs for binary data, where a >text-mode /tmp mount poi

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Thu, Apr 13, 2006 at 05:48:22AM -0700, Gary Zablackis wrote: >> The exception handler is supposed to be initialized >> in >> _cygtls::init_thread which is called from >> initialize_main_tls. >> Why is that not happening? > >It does happen. However, later on when the program calls dlopen () >(wh

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Wed, Apr 12, 2006 at 06:53:33AM -0700, Gary Zablackis wrote: >The code below corrects this problem. > >CHANGELOG: >2006-04-11 Gary Zablackis [EMAIL PROTECTED] > * (Thanks to Bernhard Loos for pointing the way) > * dll_init.cc (dll_dllcrt0()): install Cygwin >exception handler so that Cygwin can

Re: Patch to dcrt0.cc for dmalloc

On Wed, Apr 05, 2006 at 08:16:22PM -0400, Pierre A. Humblet wrote: >2006-04-06 Pierre Humblet <[EMAIL PROTECTED]> > > * drct0.cc (dll_crt0_1): Move malloc_init after >user_data->resourcelocks->Init. As I mentioned in cygwin-developers "those two lines" (i.e., the ->Init lines that are requ

Re: wtf fix for sh prep

On Fri, Mar 31, 2006 at 02:47:24PM +, Bryan D. Thomas wrote: >http://cygwin.com/acronyms/#KOTPPLAUOP > >wtf didn't have this one. Sorry but this is not a list for random patches to packages. This is a list for submitting patches to the Cygwin DLL and the other components of the "winsup" direct

Re: fcntl debug

On Wed, Mar 22, 2006 at 04:19:55PM +, Eric Blake wrote: >2006-03-22 Eric Blake <[EMAIL PROTECTED]> > > * fhandler.cc (fcntl): Print flags in hex. I'll apply this shortly. Thanks. cgf

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Thu, Mar 09, 2006 at 07:04:23AM -0800, Gary Zablackis wrote: >--- Brian Dessent <[EMAIL PROTECTED]> wrote: >>If you are trying to track down why you get a SIGSEGV in >>pthread_key_create while running your app in gdb you are wasting your >>time. This is not a fault, it is expected and normal.

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Fri, Mar 03, 2006 at 09:13:53AM -0800, Gary Zablackis wrote: >--- Christopher Faylor ><[EMAIL PROTECTED]> wrote: > >>The "efault.faulted()" two lines above your change is supposed to catch >>NULL dereferences. I suspect that you were probably misled by the

Re: Patch for silent crash with Cygwin1.dll v 1.5.19-4

On Thu, Mar 02, 2006 at 10:11:39AM -0800, Gary Zablackis wrote: >Since installing Cygwin1.dll v 1.5.19-4, I have a problem with the >computer algebra system SAGE dying at startup with no error messages >(i.e. I get returned to the bash prompt with no messages of any sort). >I tracked the problem d

Re: raw email addresses and ChangeLog entries?

On Fri, Feb 17, 2006 at 03:24:41PM -0600, Brian Ford wrote: >On Fri, 17 Feb 2006, Corinna Vinschen wrote: >>On Feb 17 09:52, Brian Ford wrote: >>>On Fri, 17 Feb 2006, Corinna Vinschen wrote: On Feb 16 10:46, Jerry D. Hedden wrote: Would you please don't copy raw email addresses in your

Re: [PATCH] Add missing include to mntent.h

On Mon, Feb 13, 2006 at 01:47:48PM -0500, Igor Peshansky wrote: >== >2006-02-03 Igor Peshansky <[EMAIL PROTECTED]> > > * include/mntent.h: Add missing #include. Applied, but please see the previous comment about us

Re: [PATCH] Fix typo in gentls_offsets

On Mon, Feb 13, 2006 at 01:46:48PM -0500, Igor Peshansky wrote: >2004-07-06 Igor Peshansky <[EMAIL PROTECTED]> > > * gentls_offsets: Fix typo in error message. Please use the proper date in your ChangeLogs. The patch + correctly-dated ChangeLog has been checked in. Thanks. cgf

Re: clock_[get|set]time timespec conversions

On Fri, Feb 10, 2006 at 07:09:10PM -0500, Christopher Faylor wrote: >On Fri, Feb 10, 2006 at 05:53:45PM -0600, Brian Ford wrote: >>2006-02-10 Brian Ford <[EMAIL PROTECTED]> >> >> * times.cc (clock_gettime): Properly convert ms period to struct >>

<    1   2   3   4   5   6   7   8   9   10   >