from:"Serafeim Zanikolas"

Package: wnpp
Severity: normal

I request an adopter for the socnetv package.

The package description is:
 SocNetV is a graphical application designed to be an easy tool for Social
 Networks Analysis and Visualisation (not to be confused with social
 networking, as in online communities). With it, one can load and visualise
 networks of various formats (GraphViz, Adjacency, Pajek, etc), and/or visually
 create and modify a network in a point and click fashion.
 .
 The program can also compute network statistics and properties (such as
 distances, centralities, diameter) and apply some layout algorithms for more
 meaningful visualisation of your networks. Furthermore, socnetv can create
 simple random networks (lattice, same degree, etc).


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#758456: RFA: beanstalkd -- simple, in-memory, workqueue service

Package: wnpp
Severity: normal

I request an adopter for the beanstalkd package.

The package description is:
 Beanstalkd is a simple, fast, workqueue service (a specific case of message
 queueing), in which messages are organised in tubes. Beanstalk clients can
 insert and consume messages into and from such tubes.
 .
 The beanstalk interface is generic, but was originally designed for reducing
 the latency of page views in high-volume web applications by running
 time-consuming tasks asynchronously.
 .
 Beanstalkd is meant to be ran in a trusted network, as it has no
 authorisation/authentication mechanisms.
 .
 This package has the server files.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#758457: RFA: cflow -- Analyze control flow in C source files

Package: wnpp
Severity: normal

I request an adopter for the cflow package.

The package description is:
 GNU cflow analyzes a collection of C source files and prints a graph, charting
 control flow within the program.
 .
 GNU cflow is able to produce both direct and inverted flowgraphs for C
 sources. Optionally a cross-reference listing can be generated. Two output
 formats are implemented: POSIX and GNU (extended).
 .
 Input files can optionally be preprocessed before analyzing.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#758455: RFA: bogofilter -- fast Bayesian spam filter (dummy package)

Package: wnpp
Severity: normal

I request an adopter for the bogofilter package.

The package description is:
 This package implements a fast Bayesian spam filter along the lines suggested
 by Paul Graham in his article A Plan For Spam.
 .
 This version substantially improves on Paul's proposal by doing smarter
 lexical analysis.  In particular, hostnames and IP addresses are retained
 as recognition features rather than broken up. Various kinds of MTA
 cruft such as dates and message-IDs are discarded so as not to bloat
 the word lists.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733866: nyancat-server: drop reconf-inetd dependency

2014-07-18 Thread Serafeim Zanikolas

Hi Jonathan,


 What are my options apart from manually removing reconf-inet's entries
 from /etc/inetd.conf and restart inetd using invoke-rc.d?


It's unfortunate that the same link is used for both reconf-inetd and
systemd.  Can't you ship a new systemd service file that refers to another
(newly shipped) link?

Failing that, you can always do it manually (it's ugly but you wouldn't be
the first, and it's a one-off solution anyhow).

Cheers,
Serafeim

Bug#750944: RM: nodebox-web -- ROM; low popcon, no response to RFA

2014-06-08 Thread Serafeim Zanikolas

Package: ftp.debian.org
Severity: normal

From my RFA, #749340, two weeks ago:

I request an adopter for the nodebox-web package.

I packaged it several years ago because it was needed for another package, one
that is not in the Debian archive anymore. nodebox-web has low popcon and no
rdepends, so adopt it only if you (plan to) use it yourself.

I intend to request its removal from the archive if nobody steps up within a
few weeks.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#736327: an update on the situation

2014-05-29 Thread Serafeim Zanikolas

Hi Jon,

On Thu, May 29, 2014 at 07:54:11PM +0100, Jonathan Dowland wrote:
 I've recently revisited this issue. I've discovered two things: firstly, there
 are two distinct class heirarchies/families within the 'mailbox' library: the
[..]

Thanks for your interest in archivemail.

In case you've not noticed, archivemail has been removed from testing due to
#724043 (which is trivial to fix, but the maintainer is MIA and nobody else
bothered). If you care enough, I would encourage you to step up and make an
NMU for both bugs.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#749339: O: cflow -- Analyze control flow in C source files

2014-05-26 Thread Serafeim Zanikolas

Package: wnpp
Severity: normal

I intend to orphan the cflow package; I don't have the time for it.

The package description is:
 GNU cflow analyzes a collection of C source files and prints a graph, charting
 control flow within the program.
 .
 GNU cflow is able to produce both direct and inverted flowgraphs for C
 sources. Optionally a cross-reference listing can be generated. Two output
 formats are implemented: POSIX and GNU (extended).
 .
 Input files can optionally be preprocessed before analyzing.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#749340: RFA: nodebox-web -- collection of web-related Python modules

2014-05-26 Thread Serafeim Zanikolas

Package: wnpp
Severity: normal

I request an adopter for the nodebox-web package.

I packaged it several years ago because it was needed for another package, one
that is not in the Debian archive anymore. nodebox-web has low popcon and no
rdepends, so adopt it only if you (plan to) use it yourself.

I intend to request its removal from the archive if nobody steps up within a
few weeks.

The package description is:
 Nodebox Web is a collection of Python modules to get content from the web.
 One can query Yahoo! and Google for links, images, news and spelling
 suggestions, read RSS and Atom newsfeeds, retrieve articles from Wikipedia,
 collect quality images from morgueFile or Flickr, browse through HTML
 documents, clean up HTML, validate URLs, and create GIF images from math
 equations using mimeTeX.
 .
 The library uses a caching mechanism that stores things you download from the
 web, so they can be retrieved faster the next time. Many of the services also
 work asynchronously.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#746814: Should build against and link with system's libtrio

2014-05-08 Thread Serafeim Zanikolas

Bonjour Didier!

On Sat, May 03, 2014 at 11:35:59PM +0200, Didier Raboud wrote:
 I've noticed that bogofilter embeds a copy of libtrio's source files; the 
 build system
 should ensure that libtrio-dev's header files are used and that bogofilter is 
 linked
 against the system version of libtrio.

Thanks for the heads-up and giving me the excuse to indulge into the joy of
autoconf incantations :)

FWIW bogofilter also embeds a (forked, slightly modified) version of gnu gcl.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733866: nyancat-server: drop reconf-inetd dependency

2014-04-14 Thread Serafeim Zanikolas

Hi Jon,

On Sat, Apr 12, 2014 at 09:37:51PM +0100, Jonathan McCrohan wrote:
 Given that you have already orphaned both reconf-inetd and update-inetd,
 and nobody else has come forward, I think it would be best for nyancat
 not to depend on either of them.

I've RFA'd them; I'm still the maintainer.

 I have already created systemd service files for nyancat and sent them
 upstream. I would like to use systemd on linux, with perhaps manual
 instructions on !linux archs.

Sounds great.

 Can you please provide a tested patch to cleanly remove any existing
 entries in /etc/inetd.conf prior to systemd service file installation?

I recalled that nyancat-server was a symlink just for reconf-inetd, so you can
stop shipping it. If you also stop shipping the reconf-inet fragments, then
reconf-inetd will remove its inetd.conf entries upon upgrading to the new
package (via a dpkg trigger, ie. you don't need to call anything on postinst,
in fact you should drop postinst altogether).

Here's a tested patch (not including dropping the postinst file, which is a
no-op for upgrading from wheezy onwards):

diff -Nurp orig/nyancat-1.2.2/debian/nyancat-server.install 
patched2/nyancat-1.2.2/debian/nyancat-server.install
--- orig/nyancat-1.2.2/debian/nyancat-server.install2013-06-04 
22:06:46.0 +0100
+++ patched2/nyancat-1.2.2/debian/nyancat-server.install1970-01-01 
01:00:00.0 +0100
@@ -1,2 +0,0 @@
-debian/reconf-inetd/nyancat-server.tcp usr/share/reconf-inetd/
-debian/reconf-inetd/nyancat-server.tcp6 usr/share/reconf-inetd/
diff -Nurp orig/nyancat-1.2.2/debian/nyancat-server.links 
patched2/nyancat-1.2.2/debian/nyancat-server.links
--- orig/nyancat-1.2.2/debian/nyancat-server.links  2013-06-04 
22:06:46.0 +0100
+++ patched2/nyancat-1.2.2/debian/nyancat-server.links  2014-04-13 
22:07:19.0 +0100
@@ -1,2 +1 @@
-usr/bin/nyancat usr/bin/nyancat-server
-/usr/share/man/man1/nyancat.1.gz /usr/share/man/man1/nyancat-server.1.gz

cheers,

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733866: nyancat-server: drop reconf-inetd dependency

2014-04-05 Thread Serafeim Zanikolas

Hi Jon,

On Tue, Apr 01, 2014 at 11:51:09PM +0100, Jonathan McCrohan wrote:
 Hi Serafeim,
 
 On 02/01/14 23:13, Serafeim Zanikolas wrote:
  Here's a list of instructions instead:
  
  - don't ship anything under /usr/share/reconf-inetd/
  - replace dependency on reconf-inetd with one on update-inetd
  - revert postinst script to the one you had before, and put
reconf-inetd || true before invoking update-inetd --add ...
(the former will remove any entries added by reconf-inetd, for which 
  there's
no fragment under /usr/share/reconf-inetd)
  
  Let me know if you run into any issues.
 
 Have you tested this yourself? I have tried above and it doesn't work.

I haven't tested it, and in fact my suggestion shouldn't work (sorry). I
didn't remember that reconf-inetd won't delete an inetd.conf entry that refers
to an existing path (that's a feature; see table in
http://dep.debian.net/deps/dep9/#index3h1).

 How you do you propose you fix this?

I see two alternatives. Either we leave nyancat on reconf-inetd (it does work
and in fact it's the only way to have both ip4  ipv6 entries, it's just that
it doesn't make much sense to keep reconf-inetd for just one package).

Alternatively, you can put in postinst update-inetd --multi --pattern nyancat
--remove telnet on the condition that the nyancat server package is being
upgraded from 1.2.2-1 (the latest version that uses reconf-inetd) *and*
inetd.conf has telnet entries exactly as they were shipped by that version.
That's more or less the example snippet at
http://dep.debian.net/deps/dep9/#index5h1 but adding the new entries with
update-inetd (instead of reconf-inetd).

If you're okay with the latter idea, I'll send you a patch.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733866: nyancat-server: drop reconf-inetd dependency

2014-01-02 Thread Serafeim Zanikolas

Hi Jon,

On Thu, Jan 02, 2014 at 02:33:22AM +, Jonathan McCrohan wrote:
 Can you please supply a patch for this. DEP9 provides no guidance on how
 correctly to migrate users away from reconf-inetd in the postinst.

Here's a list of instructions instead:

- don't ship anything under /usr/share/reconf-inetd/
- replace dependency on reconf-inetd with one on update-inetd
- revert postinst script to the one you had before, and put
  reconf-inetd || true before invoking update-inetd --add ...
  (the former will remove any entries added by reconf-inetd, for which there's
  no fragment under /usr/share/reconf-inetd)

Let me know if you run into any issues.

Cheers,

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733866: nyancat-server: drop reconf-inetd dependency

2014-01-01 Thread Serafeim Zanikolas

Package: nyancat-server
Version: 1.2.2-1
Severity: normal

Hi,

I plan to remove reconf-inetd from the Debian archive, since jessie will most
likely be released with a modern init system which makes inetd even more
irrelevant (and thus reconf-inetd not a worthwhile project).

Please drop nyncat-server's dependency on reconf-inetd (eg. by switching back
to update-inetd).

Thanks for giving a try to reconf-inetd and apologies for the wasted time in
doing so.

Thanks,
Serafeim


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#728579: O: pdfshuffler -- merge, split and re-arrange pages from PDF documents

2013-11-03 Thread Serafeim Zanikolas

Package: wnpp
Severity: normal

I have orphaned the pdfshuffler package due to no interest in it.

The package description is:
 PDF-Shuffler is a small application which allows one to merge or split pdf
 documents and rotate, crop and rearrange their pages using an interactive
 and intuitive graphical interface.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#719792: RFA: reconf-inetd DEP9 -- maintainer script for programmatic updates of inetd.conf

2013-08-15 Thread Serafeim Zanikolas

Package: wnpp
Severity: normal

I request an adopter for the reconf-inetd package.

The package description is:
reconf-inetd is a dpkg-trigger script that updates the configuration of the
internet superserver. It is a replacement for update-inetd, as per DEP9.
.
If the above does not mean anything to you, then you most certainly do not
need this package.

I do not have the time to be the sole driver of DEP9, and its implementation,
reconf-inetd. reconf-inetd is pretty much complete, it works, and it comes
with dozens of system tests. Remaining work includes:

- port to python 3
- use of a Debian python helper to manage byte-compilation
- file bug reports to the reverse dependencies of update-inetd to migrate to
reconf-inetd, as described in DEP9 (which also describes how to prepare
patches)

The last item is a lot of work, and will require interacting with lots of
other maintainers via the BTS. The adopter must know python (reconf-inetd is a
native package), have packaging experience, and lots of motivation.

I'm not sure anymore whether DEP9 (ie. replacing update-inetd with
reconf-inetd) is worthwhile, because inetd (which is what update/reconf-inetd
configure) will eventually be deprecated by systemd and upstart. Having said
that, inetd is unlikely to vanish anytime now, and in the meantime
update-inetd is buggy and has 120k installations.

I'll be around to sponsor (if necessary) answer questions, but will
otherwise not be actively involved.

Links:

- functional description of reconf-inetd plan of migration away from
update-inetd: http://dep.debian.net/deps/dep9/

- pts git:
http://packages.qa.debian.org/r/reconf-inetd.html
http://git.debian.org/?p=collab-maint/reconf-inetd.git;a=summary

- vaguely related talk at fosdem (includes a description of the reconf-inetd
system tests)

http://video.fosdem.org/2012/crossdistro/How_to_replace_a_legacy_tool_with_100k_installations.webm

--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#719794: RFA: update-inetd -- inetd configuration file updater

2013-08-15 Thread Serafeim Zanikolas

Package: wnpp
Severity: normal

I request an adopter for the update-inetd package.

The package description is:
 This package provides a program used by other packages to
 automatically update /etc/inetd.conf, the configuration file shared
 by all implementations of the Internet super-server.
 .
 Note that xinetd is not supported by this package.

update-inetd is a native package, implemented in perl, and with system tests
in python.

update-inetd has serious design flaws and is meant to be replaced by another
tool, as described in DEP9 (http://dep.debian.net/deps/dep9/)

The adopter should look at DEP9, and consider also adopting reconf-inetd
(also RFA'd, see #719792).


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671728: AptHookFd test fixture script

2013-08-13 Thread Serafeim Zanikolas

Francesco,

As discussed off-line, here's a script to somewhat emulate apt's behaviour
according to the patch in this bug report, for the sake of testing.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


apt-hook-fd-fixture.rb
Description: application/ruby

Bug#441689: refreshed patch for the current apt-listbugs release

2013-08-13 Thread Serafeim Zanikolas

Attached the patch that was submitted six(!) years ago, refreshed for current
apt-listbugs. I've modified it to change -F to a boolean switch, rather than
one that requires an argument (as per msg #30 in this bug report).

As discussed off-line, it'd be great if force-pin would default to true in
case of failure to open /dev/tty.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff --git a/apt-listbugs b/apt-listbugs
index 251b5dd..fbbc815 100755
--- a/apt-listbugs
+++ b/apt-listbugs
@@ -125,6 +125,12 @@ apt-listbugs [-h] [-v] [-s severities] [-T tags] [-S states] [-B bug#] [
 
   Specifies the apt configuration file to use.
 
+* -F | --force-pin
+
+  When set it will automatically pin all packages without any prompt. If not
+  specified in the command line, apt.conf is consulted for
+  AptListbugs::Force-Pin.
+
 * -y, --force-yes
 
   Assumes that you select yes for all questions.
@@ -211,8 +217,6 @@ notable configuration options are
   Summary:
apt-listbugs(2 bugs)
 
-
-
 == EXIT CODE
 
 : 0
diff --git a/lib/apt-listbugs/logic.rb b/lib/apt-listbugs/logic.rb
index 66dec3c..c994f61 100644
--- a/lib/apt-listbugs/logic.rb
+++ b/lib/apt-listbugs/logic.rb
@@ -55,6 +55,7 @@ class AppConfig
   _( -E title   : Title of RSS output.\n),
   _( -q   : Don't display progress bar.\n),
   _( -C apt.conf: apt.conf file to use.\n),
+  _( -F   : Pin any package found with a bug and exit.\n),
   _( -y   : Assume that you select yes for all questions.\n),
   _( -n   : Assume that you select no for all questions.\n),
   _( -d   : Debug.\n),
@@ -95,6 +96,7 @@ class AppConfig
 @apt_conf = nil
 
 @yes = nil
+@force_pin = false
 
 @arrow = -
 @xarrow = -gt;
@@ -106,7 +108,7 @@ class AppConfig
 
   attr_accessor :severity, :stats, :quiet, :title
   attr_accessor :show_downgrade, :hostname, :tag, :fbugs
-  attr_accessor :frontend, :pin_priority, :yes, :ignore_regexp
+  attr_accessor :frontend, :pin_priority, :yes, :ignore_regexp, :force_pin
   attr_reader :command, :parser, :querybts, :ignore_bugs, :system_ignore_bugs, :browser, :arrow, :xarrow
 
   def parse_options
@@ -124,6 +126,7 @@ class AppConfig
['--title', '-E', GetoptLong::REQUIRED_ARGUMENT],
['--quiet', '-q', GetoptLong::NO_ARGUMENT],
['--aptconf', '-C', GetoptLong::REQUIRED_ARGUMENT],
+   ['--force-pin', '-F', GetoptLong::NO_ARGUMENT],
['--force-yes', '-y', GetoptLong::NO_ARGUMENT],
['--force-no', '-n', GetoptLong::NO_ARGUMENT],
['--debug', '-d', GetoptLong::NO_ARGUMENT]
@@ -171,6 +174,8 @@ class AppConfig
   @yes = true
 when '--force-no'
   @yes = false
+when '--force-pin'
+  @force_pin = true
 end
   }
 rescue GetoptLong::AmbigousOption, GetoptLong::NeedlessArgument,
@@ -179,6 +184,13 @@ class AppConfig
   exit 1
 end
 
+if @force_pin.nil?
+  if /true/ =~ `apt-config #{@apt_conf} shell force_pin AptListbugs::Force-Pin`
+@force_pin = true
+  end
+end
+@force_pin = false if @force_pin.nil?
+
 if ! $stdout.isatty
   @quiet = true
   @yes = false if @yes.nil?
@@ -359,22 +371,28 @@ class Viewer
   answer = n
   hold_pkgs = []
   while true
-ask_str = _(Are you sure you want to install/upgrade the above packages?).dup
-if @config.querybts != nil || @config.browser != nil
-  if hold_pkgs.empty?
-ask_str   [Y/n/?/...]
+if @config.force_pin
+  @config.frontend.puts $intl._(Pinning all ackages at your request ...)
+  a = p
+else
+  ask_str = _(Are you sure you want to install/upgrade the above packages?).dup
+  if @config.querybts != nil || @config.browser != nil
+if hold_pkgs.empty?
+  ask_str   [Y/n/?/...]
+else
+  ask_str   [N/?/...]
+end
   else
-ask_str   [N/?/...]
+ask_str   [Y/n]
+  end
+  if @config.yes.nil?
+a = @config.frontend.ask ask_str
+  else
+a = y if @config.yes
+a = n if ! @config.yes
   end
-else
-  ask_str   [Y/n]
-end
-if @config.yes.nil?
-  a = @config.frontend.ask ask_str
-else
-  a = y if @config.yes
-  a = n if ! @config.yes
 end
+
 if a == 
   if hold_pkgs.empty?
 answer = y
@@ -456,7 +474,9 @@ class Viewer
 }
   end
   if pkgs.size != 0
-if @config.frontend.yes_or_no? ngettext(
+if @config.force_pin
+  h = pinned(pkgs.keys, cur_pkgs, bugs)
+elsif @config.frontend.yes_or_no? ngettext(

Bug#671726: apt: should be able to provide hook information through a named pipe

2013-08-12 Thread Serafeim Zanikolas

Daniel, David,

On Sun, Mar 17, 2013 at 11:52:49PM +0100, Serafeim Zanikolas wrote:
 On Sun, Mar 17, 2013 at 08:15:32PM +0800, Daniel Hartwig wrote:
  On 17 March 2013 19:56, Serafeim Zanikolas s...@debian.org wrote:
   On Sun, Mar 17, 2013 at 02:14:50PM +0800, Daniel Hartwig wrote:
   The data can be passed through an open fd, similar to dpkg --status-fd
   argument.  Then there are no issues due to filesystems global
   namespace and it removes the fs as an unrequired middle-man.
  
[..]
 Attached the updated patches for apt and apt-listbugs, which implement
 Daniel's proposal of using an fd rather than a fifo.

Ping? Is there anything blocking the application of this patch?

cheers,
sez (currently at DebConf)

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#705198: reconf-inetd: port to python 3k

2013-04-11 Thread Serafeim Zanikolas

Package: reconf-inetd
Version: 1.120603
Severity: normal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#705199: reconf-inetd: use a debian python helper to manage byte-compiled files

2013-04-11 Thread Serafeim Zanikolas

Package: reconf-inetd
Version: 1.120603
Severity: normal


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: apt-listbugs: please use debconf

2013-04-07 Thread Serafeim Zanikolas

Hi Francesco,

On Sun, Apr 07, 2013 at 07:22:27PM +0200, Francesco Poli wrote [edited]:
 On Sun, 24 Mar 2013 01:09:43 +0100 Serafeim Zanikolas wrote:
 The current apt-listbugs text user interface displays the bugs that
 affect the installation/upgrade and then offers the user the following
 possible choices:
  * go on
  * go on and permanently mark the bugs as ignored
  * stop everything
  * display one bug log
  * pin some or all the packages
  * mark a bug as ignored
  * open a browser to display one bug log
 
 How can we do something similar via debconf without forcing the user to
 go through a tree of multiple successive screens (that would feel like
 a horrible call center menu system: dial 1 to learn about our
 fantastic promotional offers, dial 2 to receive commercial
 assistance, ...)?

I care about implementing the two basic use cases (newbie  advanced) in the
simplest possible interaction using debconf -- to ease integration with
higher-level programs, so that Debian testing users (read: Desktop users that
normally don't use a terminal) can benefit from latest updates while avoiding
RC bugs.

The rest of the choices are secondary for these two specific use cases.
Newbies wouldn't even see the debconf screen and advanced users know how to
lookup a bug report given its number.

You've made it clear that you care about preserving all current choices. I
don't agree, but I sense that a debate would be pointless, so that leaves us
with one choice: default to the current (feature rich, terminal-based)
interaction mode, and support the (simple  scriptable) debconf one as an
option eg. via an environment variable.

  Going forward from here, one possibility would be for the apt-listbugs ruby
  script to invoke the debconf script (passing on the package/bug num/bug 
  title
  info and getting back the user reply, via a tempfile or something along 
  those
  lines).
 
 To be frank, I am not too enthusiastic about the idea to let a Ruby
 program invoke a POSIX shell script in order to get a user interface...

You get a bit more than a user interface: an implementation of the debconf
protocol.

 If we have to implement a debconf interface for apt-listbugs, I would
 strongly prefer that it be done directly in Ruby.

Sure, in a world of infinite available time we'd all prefer that. In reality,
I'd go for the least amount of work which is a shell script, and I expect you
to accept such a patch if it works as advertised. You are, of course, most
welcome to put in the extra effort to implement a ruby debconf library.

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#704288: Upstream version 1.8 is out

2013-03-31 Thread Serafeim Zanikolas

On Sun, Mar 31, 2013 at 10:50:46AM +0200, Dennis Kaarsemaker wrote:
 Package: beanstalkd
 Version: 1.7-1
 
 Beanstalkd is quite often going berserk and using 10% CPU on my machine.
 Looking at the beanstalkd bugtracker, this should be fixed in 1.8, which
 was released a few months ago.

Thanks for the report. Uploads to unstable are best avoided during the freeze,
but this sounds severe enough to warrant an upload.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#704256: reconf-inetd: add support for unlisted services

2013-03-30 Thread Serafeim Zanikolas

Package: reconf-inetd
Version: 1.120603
Severity: wishlist

reconf-inetd currenly only supports services that are associated with a
well-known port (by being listed in /etc/services).

unlisted services, such as approx, cannot be migrated to reconf-inetd until
this bug is fixed.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: Fwd: [OT] flag RC-buggy packages to users of testing

2013-03-26 Thread Serafeim Zanikolas

- Forwarded message -

From: Serafeim Zanikolas s...@debian.org
To: debian-v...@lists.debian.org
Subject: [OT] flag RC-buggy packages to users of testing

[M-F-T set to 628...@bugs.debian.org, as I believe this is becoming OT]

On Tue, Mar 12, 2013 at 12:17:29PM +0800, Paul Wise wrote:
[..]
 On Tue, Mar 12, 2013 at 3:30 AM, Moray Allan wrote:
[..]
  Flag up RC bugs: To tackle things earlier in the cycle, perhaps we could
  push use of some tools[1] that more actively flag up new RC-buggy packages
  to users of testing?

 There is apt-listbugs but does that work for things like PackageKit or
 software-center?

software-center is unaware of apt-listbugs and PackageKit explicitly disables
it (because it otherwise hangs while apt-listbugs waits for console-based
input).

Two things need to happen:

- apt-listbugs design should be revised for invocation by programs (as opposed
  to manual/interactive invocation)

- high level package managers must learn how to interact with apt-listbugs

-- 
Every great idea is worthless without someone to do the work. --Neil Williams

- End forwarded message -

-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#660568: linux-ftpd-ssl: please migrate away from update-inetd to reconf-inetd as per DEP9

2013-03-25 Thread Serafeim Zanikolas

Control: severity -1 normal
Control: tag -1 +patch

Hi,

Please find attached a patch for migrating your package to reconf-inetd, as
per dep9 [0], in order to eliminate cross-package issues such as #168847.

I'll be happy to answer any questions.

cheers,
sez

[0] http://dep.debian.net/deps/dep9/#index5h1

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff --git a/debian/control b/debian/control
index f3db1fa..8fa9aae 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Standards-Version: 3.9.1
 
 Package: ftpd-ssl
 Architecture: any
-Depends: openbsd-inetd | inet-superserver, libpam-modules, openssl (= 0.9.8g-9), ${shlibs:Depends}, ${misc:Depends}
+Depends: openbsd-inetd | inet-superserver, libpam-modules, openssl (= 0.9.8g-9), ${shlibs:Depends}, ${misc:Depends}, reconf-inetd
 Provides: ftp-server
 Conflicts: ftp-server, ftpd
 Replaces: ftpd
diff --git a/debian/dirs b/debian/dirs
index 0ccb9c9..de748b1 100644
--- a/debian/dirs
+++ b/debian/dirs
@@ -3,3 +3,4 @@ usr/share/man/man5
 usr/share/man/man8
 usr/sbin
 etc/ftpd-ssl
+/usr/share/reconf-inetd
diff --git a/debian/postinst b/debian/postinst
index 434e7ae..d6a75cb 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -3,22 +3,28 @@
 
 set -e
 
-if grep -q '[[:blank:]]/usr/sbin/in\.ftpd.*-z' /etc/inetd.conf 2/dev/null; then
-	update-inetd --pattern '/usr/sbin/in\.ftpd' --remove .*ftp
-fi
-
-if grep -q '[[:blank:]]/usr/sbin/in\.ftpd\' /etc/inetd.conf 2/dev/null; then
-	if ! grep -q '^ftp\' /etc/inetd.conf; then
-		update-inetd --pattern '/usr/sbin/in\.ftpd' --multi --enable ftp
-	fi
-else
-	FTPENTRY=ftp		stream	tcp	nowait	root	/usr/sbin/tcpd	/usr/sbin/in.ftpd
-	if grep -q '^ftp\' /etc/inetd.conf 2/dev/null; then
-		update-inetd --group STANDARD --add ## $FTPENTRY
-	else
-		update-inetd --group STANDARD --add $FTPENTRY
-	fi
-fi
+# assuming that ftpd-ssl migrates to reconf-inetd in jessie, this whole
+# snippet can be removed completely in jessie+1.
+#
+# exact inetd.conf entry previously added using update-inetd
+OLD_FTPENTRY=ftp		stream	tcp	nowait	root	/usr/sbin/tcpd	/usr/sbin/in.ftpd
+# last release that does not use reconf-inetd
+REL=0.17.33+0.3-1
+case $1 in
+configure)
+# remove inetd.conf entry if not modified locally, and not managed
+# already by reconf-inetd
+if dpkg --compare-versions $2 le-nl $REL; then
+if fgrep -qx $OLD_FTPENTRY /etc/inetd.conf || \
+   fgrep -qx #off# $OLD_FTPENTRY /etc/inetd.conf; then
+# remove all inetd.conf entries for ftpd-ssl
+update-inetd --pattern 'usr/sbin/in\.ftpd' --remove ftp || true
+# re-add entries that are managed by reconf-inetd
+reconf-inetd || true
+fi
+fi
+;;
+esac
 
 if [ ! -f /etc/inetd.conf -a -d /etc/xinetd.d -a -x /usr/sbin/xinetd ]; then
 	cat -TEXT
diff --git a/debian/postrm b/debian/postrm
deleted file mode 100644
index 7f1a14d..000
--- a/debian/postrm
+++ /dev/null
@@ -1,12 +0,0 @@
-#!/bin/sh
-# $Id: postrm,v 1.1 1999/04/16 07:00:28 herbert Exp $
-
-set -e
-
-if [ $1 = purge ]; then
-	if command -v update-inetd /dev/null 21; then
-		update-inetd --pattern '/usr/sbin/in\.ftpd' --remove #off# ftp
-	fi
-fi
-
-#DEBHELPER#
diff --git a/debian/prerm b/debian/prerm
deleted file mode 100644
index 48509b0..000
--- a/debian/prerm
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/bin/sh
-# $Id: prerm,v 1.1 1999/04/16 07:00:29 herbert Exp $
-
-set -e
-
-update-inetd --pattern '/usr/sbin/in\.ftpd' --multi --disable ftp
-
-#DEBHELPER#
diff --git a/debian/reconf-inetd/ftpd-ssl.tcp b/debian/reconf-inetd/ftpd-ssl.tcp
new file mode 100644
index 000..63ffa30
--- /dev/null
+++ b/debian/reconf-inetd/ftpd-ssl.tcp
@@ -0,0 +1,9 @@
+service ftp
+{
+	socket_type	= stream
+	protocol	= tcp
+	wait		= no
+	user		= root
+	server		= /usr/sbin/in.ftpd
+	server_args	= -l
+}
diff --git a/debian/reconf-inetd/ftpd-ssl.tcp6 b/debian/reconf-inetd/ftpd-ssl.tcp6
new file mode 100644
index 000..fe49d6a
--- /dev/null
+++ b/debian/reconf-inetd/ftpd-ssl.tcp6
@@ -0,0 +1,10 @@
+service ftp
+{
+	flags		= IPv6
+	protocol	= tcp6
+	socket_type	= stream
+	wait		= no
+	user		= root
+	server		= /usr/sbin/in.ftpd
+	server_args	= -l
+}
diff --git a/debian/rules b/debian/rules
index 3ff01e5..47153c0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -48,6 +48,7 @@ install: build
 	cp debian/ftpchroot debian/ftpusers debian/ftpd-ssl/etc
 	cp debian/pam.d/ftp debian/ftpd-ssl/etc/pam.d
 	cp debian/openssl.cnf debian/ftpd-ssl/etc/ftpd-ssl/
+	cp debian/reconf-inetd/* debian/ftpd-ssl/usr/share/reconf-inetd
 
 # Build architecture-independent files here.
 binary-indep: build install

Bug#660569: leafnode: please migrate away from update-inetd to reconf-inetd as per DEP9

2013-03-25 Thread Serafeim Zanikolas

Control: tag -1 +patch
Control: severity -1 normal
Control: affects 638791 +leafnode

Hi,

Please find attached a patch for migrating your package to reconf-inetd, as
per dep9 [0], in order to eliminate cross-package issues such as #168847.

I'll be happy to answer any questions.

cheers,
sez

[0] http://dep.debian.net/deps/dep9/#index5h1

--
Every great idea is worthless without someone to do the work. --Neil Williams
commit 8b9b33eb0218b54858f574bde051182fdfe712af
Author: Serafeim Zanikolas s...@debian.org
Date:   Sun Mar 24 20:23:40 2013 +0100

inetd.conf entry: migrate away from inetd-conf to reconf-inetd

diff --git a/debian/control b/debian/control
index 9234722..9a89114 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Architecture: any
 Provides: news-transport-system
 Conflicts: news-transport-system, newsx
 Depends: netbase, tcpd, logrotate, openbsd-inetd | inet-superserver,
- ${shlibs:Depends}, ${misc:Depends}
+ reconf-inetd, ${shlibs:Depends}, ${misc:Depends}
 Suggests: slrn | news-reader, ${perl:Depends} 
 Description: NNTP server for small leaf sites
  Leafnode is a news server suitable for small, limited-bandwidth sites 
diff --git a/debian/leafnode.dirs b/debian/leafnode.dirs
index 594cce4..1f3b714 100644
--- a/debian/leafnode.dirs
+++ b/debian/leafnode.dirs
@@ -12,3 +12,4 @@ usr/share/man/man1
 usr/share/man/man8
 usr/share/leafnode
 usr/share/bug
+usr/share/reconf-inetd
diff --git a/debian/leafnode.postinst b/debian/leafnode.postinst
index f7982bb..78e64ab 100644
--- a/debian/leafnode.postinst
+++ b/debian/leafnode.postinst
@@ -188,6 +188,29 @@ NETWORK=permanent\\  /etc/news/leafnode/debian-config  /etc/news/leafnode/deb
 			${TEXPIRE} -r
 		fi
 	fi
+#
+# This enables leafnode in inetd.conf, by removing the line using
+# update-inetd and adding it with reconf-inetd. Assuming that the switch
+# happens in jessie, this whole snippet can be dropped in jessie+1.
+#
+# the exact inetd.conf entry, as previously added using update-inetd
+OLD_INETD_ENTRY=nntp   stream  tcp nowait  news/usr/sbin/tcpd  /usr/sbin/leafnode
+# last package release before switching to reconf-inetd
+REL=2.0.0.alpha20090406a-1
+
+# remove inetd.conf entry if not modified locally, and not managed
+# already by reconf-inetd
+if dpkg --compare-versions $2 le-nl $REL; then
+if fgrep -qx $OLD_INETD_ENTRY /etc/inetd.conf || \
+   fgrep -qx #off# $OLD_INETD_ENTRY /etc/inetd.conf;
+then
+# remove all inetd.conf entries for leafnode
+update-inetd --pattern leafnode --remove nntp || true
+# re-add entries that are managed by reconf-inetd
+reconf-inetd || true
+fi
+fi
+
 fi
 
 # Old versions had this line wrong in the config file. Correct.
@@ -197,13 +220,7 @@ if grep -q maxcount /etc/news/leafnode/config; then
 	rm -f /etc/news/leafnode/config.new
 fi
 
-#
-# This enables leafnode in inetd.conf, so save for last.
-#
 
-update-inetd --comment-chars #disabled# --disable nntp
-update-inetd --group MAIL --add --comment-chars #disabled# \
-	nntp   stream  tcp nowait  news /usr/sbin/tcpd /usr/sbin/leafnode
 
 if [ $1 = purge ]; then
db_purge || true
diff --git a/debian/leafnode.postrm b/debian/leafnode.postrm
index d00d93a..a06a547 100644
--- a/debian/leafnode.postrm
+++ b/debian/leafnode.postrm
@@ -41,8 +41,6 @@ case $1 in
 	fi
   ;;
   remove)
-   update-inetd --remove .*leafnode.*
-   update-inetd --comment-chars #disabled# --enable nntp
   ;;
   upgrade|deconfigure)
   ;;
diff --git a/debian/reconf-inetd/leafnode.tcp b/debian/reconf-inetd/leafnode.tcp
new file mode 100644
index 000..3c509ea
--- /dev/null
+++ b/debian/reconf-inetd/leafnode.tcp
@@ -0,0 +1,9 @@
+service nntp
+{
+	socket_type = stream
+	protocol = tcp
+	wait = no
+	user = news
+	server = /usr/sbin/tcpd
+	server_args = /usr/sbin/leafnode
+}
diff --git a/debian/reconf-inetd/leafnode.tcp6 b/debian/reconf-inetd/leafnode.tcp6
new file mode 100644
index 000..dc6b950
--- /dev/null
+++ b/debian/reconf-inetd/leafnode.tcp6
@@ -0,0 +1,9 @@
+service nntp
+{
+	socket_type = stream
+	protocol = tcp6
+	wait = no
+	user = news
+	server = /usr/sbin/tcpd
+	server_args = /usr/sbin/leafnode
+}
diff --git a/debian/rules b/debian/rules
index 0d70ec1..9a86053 100755
--- a/debian/rules
+++ b/debian/rules
@@ -57,6 +57,7 @@ binary-arch: build
 	(cd debian/leafnode/usr/share/doc/leafnode/examples ; ln -s ../../../leafnode/config.example . )
 	mv debian/leafnode/usr/share/man/man5/moderators.5 debian/leafnode/usr/share/man/man5/leafnode-moderators.5
 	touch debian/leafnode/etc/news/leafnode/local.groups
+	cp debian/reconf-inetd/leafnode.tcp debian/reconf-inetd/leafnode.tcp6 debian/leafnode/usr/share/reconf-inetd
 	dh_installmenu
 	dh_installdebconf
 	dh_installcron

Bug#693577: libfso-glib: not properly built from source (actual source is in fso-specs)

2013-03-23 Thread Serafeim Zanikolas

Control: tag -1 -pending

Removing months-old pending tag.


-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#702233: Patches so far

2013-03-23 Thread Serafeim Zanikolas

Hi Uli,

Any progress on the upload that you were preparing for this past week?

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: apt-listbugs: please use debconf

2013-03-23 Thread Serafeim Zanikolas

Hi guys,

Attached a proof-of-concept for the advanced use case (in which the user
actually wants to review which buggy packages to pin or upgrade). Consider
this as a basis for further discussion, rather than something anywhere near a
working patch.

To give it a try, save the attached files in the same directory (doesn't
matter where), make apt-listbugs executable and run it as root (debconf needs
to write /var/cache/debconf/{config,templates}.dat).

The template file declares the contents of the debconf screen, whereby the
multi-choice options are populated by the shell script via the $packages
variable.

The script overrides the seen debconf flag so that the question is asked
every single time (to override the default debconf behaviour; feels like a
hack).

Going forward from here, one possibility would be for the apt-listbugs ruby
script to invoke the debconf script (passing on the package/bug num/bug title
info and getting back the user reply, via a tempfile or something along those
lines).

One issue with the debconf approach is that you can't fire up a browser to
lookup a bug report before making the pin/upgrade decision (something that's
possible with the current non-debconf based interaction). You also can't ^Z
the debconf screen to do so manually. Any ideas about working around this?

Another issue that should be straightforward: use debconf in postinst to ask
the user to choose between newbie and advance use (ie. whether one should go
through the above dialog on every invocation, or let apt-listbugs upgrade only
non-rc-buggy packages without asking) -- defaulting to newbie mode?

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
#!/bin/sh

set -e

export DEBCONF_DEBUG=developer

# debconf fails when DEBCONF_PACKAGE is set, but without it the
# template entry in /var/cache/dpkg/config.dat has an unkown Owner,
# which means that we can't remove it when apt-listbugs is purged.
#export DEBCONF_PACKAGE=apt-listbugs

# other values: text, dialog, kde, web (the two latter hang for me)
#export DEBIAN_FRONTEND=gnome

# source debconf libary.
. /usr/share/debconf/confmodule

# to be constructed on the fly, based on apt  bts input
PACKAGES=package0 #abcdef (short description), package1 #abcdef (short 
description)

# ask debconf to *always* show this question. without this, the
# question will be shown only the first time, even for different
# value sof $PACKAGES
db_fset apt-listbugs/select-packages seen false

# populate the template question with the list of RC-buggy packages
# and associated bug numbers
db_subst apt-listbugs/select-packages packages $PACKAGES

# priority has to be high-enough, otherwise priority overrides the seen: 
false false
db_input critical apt-listbugs/select-packages || true
db_go || true

db_get apt-listbugs/select-packages || true
PACKAGES_TO_UPGRADE=$RET

# Close all fd's
db_stop

exit 0

Template: apt-listbugs/select-packages
Type: multiselect
Choices: ${packages}
Description: Select packages to upgrade, at your own risk:
 The packages below will be pinned to the currently installed version, because
 their latest version is known to have a serious bug.
 .
 If you know what you are doing, you can nevertheless upgrade certain packages
 by selecting them in the list below.

Bug#703553: patch for delayed NMU

2013-03-22 Thread Serafeim Zanikolas

Control: tag -1 +pending

Dear maintainer,

I've uploaded an NMU to delayed/5, using a repackaged source based on Prach
Pongpanich's patch. Please feel free to override it.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#703725: unblock: apt-spacewalk/1.0.6-2.1

2013-03-22 Thread Serafeim Zanikolas

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package apt-spacewalk

It fixes RC bugs #703207, #700821 (both reports are about the same issue;
please consult #700821 for details). FWIW the NMU has been welcomed privately
to me by package uploader bernd.

Here's the diff against 1.0.6-2:

diff -Nurp orig/apt-spacewalk-1.0.6/50spacewalk apt-spacewalk-1.0.6/50spacewalk
--- orig/apt-spacewalk-1.0.6/50spacewalk2012-06-17 12:24:16.0 
+0200
+++ apt-spacewalk-1.0.6/50spacewalk 2013-03-20 15:23:00.0 +0100
@@ -11,5 +11,5 @@ APT {
   }
 };
 DPkg::Post-Invoke {
-/usr/lib/apt-spacewalk/post_invoke.py;
+if [ -x /usr/lib/apt-spacewalk/post_invoke.py ]; then 
/usr/lib/apt-spacewalk/post_invoke.py; fi;
 };
diff -Nurp orig/apt-spacewalk-1.0.6/debian/changelog 
apt-spacewalk-1.0.6/debian/changelog
--- orig/apt-spacewalk-1.0.6/debian/changelog   2013-03-20 14:02:02.0 
+0100
+++ apt-spacewalk-1.0.6/debian/changelog2013-03-20 15:45:04.0 
+0100
@@ -1,3 +1,13 @@
+apt-spacewalk (1.0.6-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Add postrm/preinst scripts for removing/disabling/enabling the apt hook
+file, and change the latter to test the existence of post_invoke.py before
+invoking it (Closes: #703207, 700821).
+  * Setting high urgency due to RC bugs
+
+ -- Serafeim Zanikolas s...@debian.org  Wed, 20 Mar 2013 13:45:30 +0100
+
 apt-spacewalk (1.0.6-2) unstable; urgency=low
 
   * [22c43b83] Rename binary package to apt-transport-spacewalk
diff -Nurp orig/apt-spacewalk-1.0.6/debian/postrm 
apt-spacewalk-1.0.6/debian/postrm
--- orig/apt-spacewalk-1.0.6/debian/postrm  1970-01-01 01:00:00.0 
+0100
+++ apt-spacewalk-1.0.6/debian/postrm   2013-03-20 14:01:28.0 +0100
@@ -0,0 +1,34 @@
+#! /bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+
+case $1 in
+purge)
+rm -f $hook.disabled
+;;
+
+remove)
+mv $hook $hook.disabled
+;;
+
+abort-install)
+if test x$2 != x  test -f $hook
+then
+mv $hook $hook.disabled
+fi
+;;
+
+upgrade|failed-upgrade|abort-upgrade|disappear)
+;;
+
+*)
+echo postrm called with unknown argument \`$1' 2
+exit 1
+
+esac
+
+#DEBHELPER#
+
+exit 0
diff -Nurp orig/apt-spacewalk-1.0.6/debian/preinst 
apt-spacewalk-1.0.6/debian/preinst
--- orig/apt-spacewalk-1.0.6/debian/preinst 1970-01-01 01:00:00.0 
+0100
+++ apt-spacewalk-1.0.6/debian/preinst  2013-03-20 14:01:28.0 +0100
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+if test -f $hook.disabled
+then
+mv $hook.disabled $hook
+fi
+
+#DEBHELPER#
+
+exit 0 


$ debdiff /var/cache/apt/archives/apt-transport-spacewalk_1.0.6-2_all.deb \
  apt-transport-spacewalk_1.0.6-2.1_all.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-
-rwxr-xr-x  root/root   DEBIAN/postrm
-rwxr-xr-x  root/root   DEBIAN/preinst

Control files: lines which differ (wdiff format)

Installed-Size: [-89-] {+90+}
Version: [-1.0.6-2-] {+1.0.6-2.1+}

thanks,
sez

unblock apt-spacewalk/1.0.6-2.1

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#703731: unblock: keepassx/0.4.3+dfsg-0.1

2013-03-22 Thread Serafeim Zanikolas

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package keepassx

Sourceful NMU keepassx/0.4.3+dfsg-0.1 fixes RC bug #698832 (missing origin and
license of image icons). Note, the bug has not been closed upon acceptance to
sid because of a typo in the changelog entry; I've sent a notfound command to
control@bugs.d.o but it's not applied as of this momment.

Here's the diffstat:

 LICENSE.LGPL-2.1 |  502 +++
 LICENSE.LGPL-3   |  165 +++
 debian/README.source |   18 +
 debian/changelog |   18 +
 debian/copyright |  205 ++
 debian/watch |3 
 share/keepassx/icons/clientic.png|binary
 share/keepassx/icons/text_block.png  |binary
 share/keepassx/icons/text_bold.png   |binary
 share/keepassx/icons/text_center.png |binary
 share/keepassx/icons/text_italic.png |binary
 share/keepassx/icons/text_left.png   |binary
 share/keepassx/icons/text_right.png  |binary
 share/keepassx/icons/text_under.png  |binary
 14 files changed, 909 insertions(+), 2 deletions(-)

... the source diff (OK'ed by keepassx uploader fgeyer@d.o at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698832#74):

diff -Nurp keepassx-0.4.3/debian/changelog 
felix/keepassx-0.4.3+dfsg/debian/changelog
--- keepassx-0.4.3/debian/changelog 2012-04-07 18:17:45.0 +0200
+++ felix/keepassx-0.4.3+dfsg/debian/changelog  2013-03-20 18:03:52.0 
+0100
@@ -1,3 +1,21 @@
+keepassx (0.4.3+dfsg-0.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Use repackaged upstream tarball by Felix Geyer, which replaces icons of
+unknown origin (clientic.png text_block.png text_bold.png text_center.png
+text_italic.png text_left.png text_right.png text_under.png) and adds full
+text of associated licenses (LICENSE.LGPL-2.1 LICENSE.LGPL-3).
+  * Use patch by Felix Geyer to update debian/copyright with the origin and
+license of png files, and update README.source accordingly.
+  * Additionally, update debian/copyright to document the origin and copyright
+of go-*.png and help_about.png icons (project Oxygen, and license CC-BY-SA
+3.0 or LGPL respectively).
+  * The above three items close #698832
+  * Update debian/watch for version mangling.
+  * Setting high urgency due to RC bug.
+
+ -- Serafeim Zanikolas s...@debian.org  Wed, 20 Mar 2013 14:04:39 +0100
+
 keepassx (0.4.3-2) unstable; urgency=low
 
   * Fix FTBFS with gcc 4.7. (Closes: #667224)
diff -Nurp keepassx-0.4.3/debian/copyright 
felix/keepassx-0.4.3+dfsg/debian/copyright
--- keepassx-0.4.3/debian/copyright 2012-04-07 18:14:51.0 +0200
+++ felix/keepassx-0.4.3+dfsg/debian/copyright  2013-03-20 17:45:32.0 
+0100
@@ -158,4 +158,207 @@ src/crypto/twofish.cpp:
  * might very well be flawed; you have been warned.
  * This software is provided as-is, without any kind of warrenty or
  * guarantee. And that is really all you can expect when you download 
- * code for free from the Internet. 
+ * code for free from the Internet.
+
+
+share/keepassx/icons/alarmclock.png
+share/keepassx/icons/appsettings.png
+share/keepassx/icons/autotype.png
+share/keepassx/icons/clock.png
+share/keepassx/icons/cloneentry.png
+share/keepassx/icons/copypwd.png
+share/keepassx/icons/copyusername.png
+share/keepassx/icons/dbsettings.png
+share/keepassx/icons/delete.png
+share/keepassx/icons/deleteentry.png
+share/keepassx/icons/deletegroup.png
+share/keepassx/icons/dice.png
+share/keepassx/icons/document.png
+share/keepassx/icons/down.png
+share/keepassx/icons/editentry.png
+share/keepassx/icons/expired.png
+share/keepassx/icons/fileclose.png
+share/keepassx/icons/filedelete.png
+share/keepassx/icons/filenew.png
+share/keepassx/icons/fileopen.png
+share/keepassx/icons/filesave.png
+share/keepassx/icons/filesaveas.png
+share/keepassx/icons/generator.png
+share/keepassx/icons/help.png
+share/keepassx/icons/key.png
+share/keepassx/icons/manual.png
+share/keepassx/icons/newentry.png
+share/keepassx/icons/openurl.png
+share/keepassx/icons/swap.png
+share/keepassx/icons/templates.png
+share/keepassx/icons/trashcan.png
+share/keepassx/icons/up.png
+share/keepassx/icons/dbsearch.png
+share/keepassx/icons/editgroup.png
+share/keepassx/icons/filesavedisabled.png
+share/keepassx/icons/groupsearch.png
+share/keepassx/icons/newgroup.png
+share/keepassx/icons/restore.png:
+
+These files are from the Nuvola icon theme and are partly modified.
+
+Copyright 2003-2004 David Vignoni
+Copyright 2006 Tarek Saidi
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Lesser General Public
+License as published by the Free Software Foundation; either
+version 2.1 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY

Bug#692948: remove pending tag (it's been there for several months)

2013-03-21 Thread Serafeim Zanikolas

Control: tag -1 -pending

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#692948: patch

2013-03-21 Thread Serafeim Zanikolas

Control: tag -1 +patch

Hi,

Attached an NMU patch against 2.5.2~svn+54698.ds4-2 (which is now both in
testing and sid).

I wasn't able to reproduce the upgrade issue so I won't NMU unless someone
that can do so verifies the fix. Damyan, you're of course welcome to take over
if you find the time.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff -Nurp sid/firebird2.5-2.5.2~svn+54698.ds4/debian/changelog sid-patched/firebird2.5-2.5.2~svn+54698.ds4/debian/changelog
--- sid/firebird2.5-2.5.2~svn+54698.ds4/debian/changelog	2013-03-18 16:23:51.0 +0100
+++ sid-patched/firebird2.5-2.5.2~svn+54698.ds4/debian/changelog	2013-03-21 18:46:06.0 +0100
@@ -1,3 +1,19 @@
+firebird2.5 (2.5.2~svn+54698.ds4-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Apply fixes from Debian git repo:
++ [4b23b851] Damyan Ivanov d...@debian.org:
+   *.postinst: prevent leaving empty directories from pre-common-doc times
++ [1723e16d]: Damyan Ivanov d...@debian.org:
+   import functions.sh before using migrateDocSymlink
+   also include the usual boilerplate
++ [78abe27e] Slávek Banko slavek.ba...@axis.cz:
+   add dependency -common on packages that use common functions.sh
+  * In migrateDocSymlink(), remove multi-arch string from pkg name, if any
+  * All the above close #692948 (high urgency due to RC severity)
+
+ -- Serafeim Zanikolas s...@debian.org  Thu, 21 Mar 2013 17:32:04 +0100
+
 firebird2.5 (2.5.2~svn+54698.ds4-2) unstable; urgency=high
 
   * High urgency for upload fixing security issues
diff -Nurp sid/firebird2.5-2.5.2~svn+54698.ds4/debian/control sid-patched/firebird2.5-2.5.2~svn+54698.ds4/debian/control
--- sid/firebird2.5-2.5.2~svn+54698.ds4/debian/control	2013-03-18 15:24:11.0 +0100
+++ sid-patched/firebird2.5-2.5.2~svn+54698.ds4/debian/control	2013-03-21 18:05:59.0 +0100
@@ -175,6 +175,7 @@ Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${shlibs:Depends}, ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Description: Firebird UDF support library
  Firebird is a relational database offering many ANSI SQL-99 features that
@@ -210,6 +211,7 @@ Description: common files for firebird 2
 Package: firebird2.5-server-common
 Architecture: any
 Depends: adduser, ${misc:Depends}, ${shlibs:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Conflicts: firebird2.1-server-common,
  firebird2.0-server-common
@@ -231,6 +233,7 @@ Conflicts: firebird-udf, firebird-utils,
  firebird2.1-classic, firebird2.1-super,
  firebird2.0-super, firebird2.0-classic
 Depends: ${misc:Depends}, ${shlibs:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Description: common files for firebird 2.5 classic and superclassic
  This package contains the command line utilities and UDFs (user-defined
@@ -249,6 +252,7 @@ Replaces: firebird2.0-dev, firebird2.1-d
 Provides: firebird2.1-dev, firebird2.5-dev
 Depends: libfbclient2 (= ${binary:Version}), libib-util,
  ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Suggests: libfbembed2.5, firebird2.5-examples
 Description: Development files for Firebird - an RDBMS based on InterBase 6.0 code
@@ -261,6 +265,7 @@ Package: firebird2.5-examples
 Section: doc
 Architecture: all
 Depends: ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Recommends: firebird-dev
 Description: Examples for Firebird - an RDBMS based on InterBase 6.0 code
@@ -275,6 +280,7 @@ Package: firebird2.5-doc
 Section: doc
 Architecture: all
 Depends: ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version})
 Description: Documentation files for firebird database version 2.5
  Various documents for firebird 2.5. These include the list of enhancements
@@ -307,6 +313,7 @@ Section: debug
 Priority: extra
 Architecture: any
 Depends: ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version}),
  firebird2.5-super (= ${binary:Version}),
  libfbclient2-dbg
@@ -325,6 +332,7 @@ Architecture: any
 Depends: ${misc:Depends},
  firebird2.5-classic (= ${binary:Version}) | firebird2.5-superclassic (= ${binary:Version}),
  firebird2.5-classic-common (= ${binary:Version}),
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version}),
  libfbembed2.5 (= ${binary:Version})
 Provides: firebird-dbg
@@ -340,6 +348,7 @@ Section: debug
 Priority: extra
 Architecture: any
 Depends: ${misc:Depends},
+ firebird2.5-common (= ${source:Version}),
  firebird2.5-common-doc (= ${source:Version}),
  libfbclient2 (= ${binary:Version})
 Breaks: firebird2.5-super-dbg ( 2.5.1.26349-0~rc1.ds4-2~)
diff -Nurp sid/firebird2.5-2.5.2~svn+54698.ds4

Bug#698832: NMU upload

2013-03-21 Thread Serafeim Zanikolas

Control: notfound -1 0.4.3+dfsg-0.1

On Thu, Mar 21, 2013 at 01:30:58PM +0100, Felix Geyer wrote:
 The upload looks good except that it doesn't close this bug (close
 vs. closes in the changelog).

Oops, that's right. Thanks for the review.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#698832: Copyright patch

Felix,

Of course, you should disregard my comments about NMU in the changelog -- I've
only now noticed that you're in the uploaders list.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#703207: patch needs more work: works for dpkg, but not for apt

tag 700821 -pending
tag 703207 -pending
tag 700821 -patch
tag 703207 -patch
thanks

$ sudo dpkg -i apt-transport-spacewalk_1.0.6-2.1_all.deb
Selecting previously unselected package apt-transport-spacewalk.
(Reading database ... 369115 files and directories currently installed.)
Unpacking apt-transport-spacewalk (from 
apt-transport-spacewalk_1.0.6-2.1_all.deb) ...
Setting up apt-transport-spacewalk (1.0.6-2.1) ...

$ sudo dpkg -r apt-transport-spacewalk
(Reading database ... 369119 files and directories currently installed.)
Removing apt-transport-spacewalk ...

$ sudo dpkg -i apt-transport-spacewalk_1.0.6-2.1_all.deb
Selecting previously unselected package apt-transport-spacewalk.
(Reading database ... 369115 files and directories currently installed.)
Unpacking apt-transport-spacewalk (from
apt-transport-spacewalk_1.0.6-2.1_all.deb) ...
Setting up apt-transport-spacewalk (1.0.6-2.1) ...

$ sudo apt-get remove apt-transport-spacewalk
Reading package lists... Done
Building dependency tree   
Reading state information... Done
The following packages were automatically installed and are no longer
required:
  python-dmidecode python-ethtool python-newt python-rhn rhn-client-tools
Use 'apt-get autoremove' to remove them.
The following packages will be REMOVED:
  apt-transport-spacewalk
0 upgraded, 0 newly installed, 1 to remove and 53 not upgraded.
After this operation, 92.2 kB disk space will be freed.
Do you want to continue [Y/n]? 
[master 298c89d] saving uncommitted changes in /etc prior to apt run
 Author: sez sez@mobee
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename apt/apt.conf.d/{50spacewalk.disabled = 50spacewalk} (100%)
(Reading database ... 369119 files and directories currently installed.)
Removing apt-transport-spacewalk ...
[master 6338b79] committing changes in /etc after apt run
 Author: sez sez@mobee
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename apt/apt.conf.d/{50spacewalk = 50spacewalk.disabled} (100%)
sh: 1: /usr/lib/apt-spacewalk/post_invoke.py: not found
E: Problem executing scripts DPkg::Post-Invoke
'/usr/lib/apt-spacewalk/post_invoke.py'
E: Sub-process returned an error code

Looking at other package's DPkg::Post-Invoke hook netries (eg.
etckeeper/debsums, the way around this is to simply check for the script's
existence before invoking it.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#700821: NMU patch

tag 700821 +pending
tag 703207 +pending
thanks

Dear maintainer,

I've uploaded an NMU to delayed/2 (since #700821 has been open for a month).

Please find attached the patch for the NMU upload.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff -Nurp orig/apt-spacewalk-1.0.6/50spacewalk apt-spacewalk-1.0.6/50spacewalk
--- orig/apt-spacewalk-1.0.6/50spacewalk	2012-06-17 12:24:16.0 +0200
+++ apt-spacewalk-1.0.6/50spacewalk	2013-03-20 15:23:00.0 +0100
@@ -11,5 +11,5 @@ APT {
   }
 };
 DPkg::Post-Invoke {
-/usr/lib/apt-spacewalk/post_invoke.py;
+if [ -x /usr/lib/apt-spacewalk/post_invoke.py ]; then /usr/lib/apt-spacewalk/post_invoke.py; fi;
 };
diff -Nurp orig/apt-spacewalk-1.0.6/debian/changelog apt-spacewalk-1.0.6/debian/changelog
--- orig/apt-spacewalk-1.0.6/debian/changelog	2013-03-20 14:02:02.0 +0100
+++ apt-spacewalk-1.0.6/debian/changelog	2013-03-20 15:45:04.0 +0100
@@ -1,3 +1,13 @@
+apt-spacewalk (1.0.6-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Add postrm/preinst scripts for removing/disabling/enabling the apt hook
+file, and change the latter to test the existence of post_invoke.py before
+invoking it (Closes: #703207, 700821).
+  * Setting high urgency due to RC bugs
+
+ -- Serafeim Zanikolas s...@debian.org  Wed, 20 Mar 2013 13:45:30 +0100
+
 apt-spacewalk (1.0.6-2) unstable; urgency=low
 
   * [22c43b83] Rename binary package to apt-transport-spacewalk
diff -Nurp orig/apt-spacewalk-1.0.6/debian/postrm apt-spacewalk-1.0.6/debian/postrm
--- orig/apt-spacewalk-1.0.6/debian/postrm	1970-01-01 01:00:00.0 +0100
+++ apt-spacewalk-1.0.6/debian/postrm	2013-03-20 14:01:28.0 +0100
@@ -0,0 +1,34 @@
+#! /bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+
+case $1 in
+purge)
+rm -f $hook.disabled
+;;
+
+remove)
+mv $hook $hook.disabled
+;;
+
+abort-install)
+if test x$2 != x  test -f $hook
+then
+mv $hook $hook.disabled
+fi
+;;
+
+upgrade|failed-upgrade|abort-upgrade|disappear)
+;;
+
+*)
+echo postrm called with unknown argument \`$1' 2
+exit 1
+
+esac
+
+#DEBHELPER#
+
+exit 0
diff -Nurp orig/apt-spacewalk-1.0.6/debian/preinst apt-spacewalk-1.0.6/debian/preinst
--- orig/apt-spacewalk-1.0.6/debian/preinst	1970-01-01 01:00:00.0 +0100
+++ apt-spacewalk-1.0.6/debian/preinst	2013-03-20 14:01:28.0 +0100
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+if test -f $hook.disabled
+then
+mv $hook.disabled $hook
+fi
+
+#DEBHELPER#
+
+exit 0

Bug#698832: NMU upload

Dear maintainer,

I've done an NMU upload to delayed/2; please see the attached patch.

It's mostly based on Felix's work, and additionally documents the origin and
license of go-*.png and help_about.png files in debian/copyright.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff -Nurp keepassx-0.4.3/debian/changelog felix/keepassx-0.4.3+dfsg/debian/changelog
--- keepassx-0.4.3/debian/changelog	2012-04-07 18:17:45.0 +0200
+++ felix/keepassx-0.4.3+dfsg/debian/changelog	2013-03-20 18:03:52.0 +0100
@@ -1,3 +1,21 @@
+keepassx (0.4.3+dfsg-0.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Use repackaged upstream tarball by Felix Geyer, which replaces icons of
+unknown origin (clientic.png text_block.png text_bold.png text_center.png
+text_italic.png text_left.png text_right.png text_under.png) and adds full
+text of associated licenses (LICENSE.LGPL-2.1 LICENSE.LGPL-3).
+  * Use patch by Felix Geyer to update debian/copyright with the origin and
+license of png files, and update README.source accordingly.
+  * Additionally, update debian/copyright to document the origin and copyright
+of go-*.png and help_about.png icons (project Oxygen, and license CC-BY-SA
+3.0 or LGPL respectively).
+  * The above three items close #698832
+  * Update debian/watch for version mangling.
+  * Setting high urgency due to RC bug.
+
+ -- Serafeim Zanikolas s...@debian.org  Wed, 20 Mar 2013 14:04:39 +0100
+
 keepassx (0.4.3-2) unstable; urgency=low
 
   * Fix FTBFS with gcc 4.7. (Closes: #667224)
diff -Nurp keepassx-0.4.3/debian/copyright felix/keepassx-0.4.3+dfsg/debian/copyright
--- keepassx-0.4.3/debian/copyright	2012-04-07 18:14:51.0 +0200
+++ felix/keepassx-0.4.3+dfsg/debian/copyright	2013-03-20 17:45:32.0 +0100
@@ -158,4 +158,207 @@ src/crypto/twofish.cpp:
  * might very well be flawed; you have been warned.
  * This software is provided as-is, without any kind of warrenty or
  * guarantee. And that is really all you can expect when you download 
- * code for free from the Internet. 
+ * code for free from the Internet.
+
+
+share/keepassx/icons/alarmclock.png
+share/keepassx/icons/appsettings.png
+share/keepassx/icons/autotype.png
+share/keepassx/icons/clock.png
+share/keepassx/icons/cloneentry.png
+share/keepassx/icons/copypwd.png
+share/keepassx/icons/copyusername.png
+share/keepassx/icons/dbsettings.png
+share/keepassx/icons/delete.png
+share/keepassx/icons/deleteentry.png
+share/keepassx/icons/deletegroup.png
+share/keepassx/icons/dice.png
+share/keepassx/icons/document.png
+share/keepassx/icons/down.png
+share/keepassx/icons/editentry.png
+share/keepassx/icons/expired.png
+share/keepassx/icons/fileclose.png
+share/keepassx/icons/filedelete.png
+share/keepassx/icons/filenew.png
+share/keepassx/icons/fileopen.png
+share/keepassx/icons/filesave.png
+share/keepassx/icons/filesaveas.png
+share/keepassx/icons/generator.png
+share/keepassx/icons/help.png
+share/keepassx/icons/key.png
+share/keepassx/icons/manual.png
+share/keepassx/icons/newentry.png
+share/keepassx/icons/openurl.png
+share/keepassx/icons/swap.png
+share/keepassx/icons/templates.png
+share/keepassx/icons/trashcan.png
+share/keepassx/icons/up.png
+share/keepassx/icons/dbsearch.png
+share/keepassx/icons/editgroup.png
+share/keepassx/icons/filesavedisabled.png
+share/keepassx/icons/groupsearch.png
+share/keepassx/icons/newgroup.png
+share/keepassx/icons/restore.png:
+
+These files are from the Nuvola icon theme and are partly modified.
+
+Copyright 2003-2004 David Vignoni
+Copyright 2006 Tarek Saidi
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Lesser General Public
+License as published by the Free Software Foundation; either
+version 2.1 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public
+License along with this library; if not, write to the Free Software
+Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+
+On Debian systems, the complete text of the GNU Lesser General
+Public License can be found in `/usr/share/common-licenses/LGPL-2.1'.
+
+
+share/keepassx/icons/exit.png
+share/keepassx/icons/i18n.png
+share/keepassx/icons/lock.png
+share/keepassx/icons/ok.png
+share/keepassx/icons/search.png
+share/keepassx/icons/bookmark*.png:
+
+These files are from the Crystal Clear icon theme and are partly modified.
+
+Copyright 2002 Everaldo Coelho
+Copyright 2006 Tarek Saidi
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2

Bug#702791: confirmed in a not extremely slow box

2013-03-19 Thread Serafeim Zanikolas

Control: tag -1 -pending

Untagging as it's been pending for over a week.

FWIW I've reproduced the issue in a reasonably modern laptop (lenovo x201):

Ran 2173 tests in 600.905s
FAILED (skips=21, failures=1, errors=2, successes=2149)

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: apt-listbugs: please use debconf [was: Bug#628996: Bug#671726: Bug#671728: Bug#671726: apt: should be able to provide hook information through a named pipe]

2013-03-19 Thread Serafeim Zanikolas

Hi guys,

On Tue, Mar 19, 2013 at 12:07:20AM +0100, Francesco Poli wrote:
 On Sun, 17 Mar 2013 17:34:03 +0800 Daniel Hartwig wrote:
 
 [...]
  On 17 March 2013 16:17, Francesco Poli invernom...@paranoici.org wrote:
[..]
· -n, --force-no Assumes that you select no for  all  questions.
This  option  is  assumed  if  stdout  is  not  a terminal or if
/dev/tty cannot be opened.
 
 Hence, I would say that, when there is no controlling terminal,
 apt-listbugs falls back to a non-interactive behavior (assuming a
 negative answer for each question that would otherwise be asked to the
 user).
 This implies that, if the upgrade or installation risks introducing RC
 bugs into the system, then the (non-interactive) apt session is forced
 to stop. Otherwise, everything goes on, as if apt-listbugs were never
 invoked.
[..]
  - abort always when RC bugs.
  
  The second is, IMO, the more reasonable default.
 
 I believe it's the currently implemented default.
 
  Ideally, the minimum
  severity of bugs to cause abort should be configurable but that is yet
  another wishlist :-)
 
 Assuming I am not misinterpreting what you wrote, this is already
 possible: by modifying /etc/apt/apt.conf.d/10apt-listbugs the user may
 add options to the apt-listbugs invocation, among which the -s option
 may be used to define which bug severities he/she is interested in.

It might be useful to forget about mechanics for a moment and think about the
use cases that we'd like to support for Debian testing users of high level
package managers (packagekit and the like).

I think technical minded users would appreciate the same level of options
currently provided by apt-get ran as root, ie. to be able to upgrade selected
RC-buggy packages while pinning others.

Less savvy users (eg. someone who can't tell the different between
a DFSG-violation and system-wide breakage) would be served best by upgrading
all upgrade-able packages except for those that are RC-buggy.  In practise,
this means pinning any RC-buggy packages (what the patch for #441689 does) and
proceeding with the upgrade (after an apt-get re-invocation, or whatever
action is required for the pinning to become effective).

Do you agree about these use cases or do you have others to suggest as more
important?

Back to mechanics:

The current non-interactive default (with --force-no) of aborting the whole
upgrade in the face of any RC bug means that users are denied of (potentially
security-critical) updates to packages that are safely upgrade-able. I
consider this unacceptable if we're serious about supporting Debian testing.

Severity based filtering (-s) seems meaningless to me. I'd never do blind
upgrades based on a ignore bugs up to X severity policy, because that
doesn't say anything about the packages and package features that I rely on as
a user.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: Bug#671726: Bug#671728: Bug#671726: apt: should be able to provide hook information through a named pipe

Hi Daniel,

On Sun, Mar 17, 2013 at 05:34:03PM +0800, Daniel Hartwig wrote:
 Control: reopen 628996
 Control: retitle 628996 apt-listbugs: please use debconf
 #Control: tags 628996 - moreinfo
 
 On 17 March 2013 16:17, Francesco Poli invernom...@paranoici.org wrote:
  On Sun, 17 Mar 2013 10:41:52 +0800 Daniel Hartwig wrote:
 
  [...]
  Debconf may provide a suitable interface there
 
  Please see the bug log of #628996 for more details about a possible
  Debconf frontend and the related difficulties...
[..]
 Debconf is the standard way to handle this type of user interaction
 during Apt activity, and provides more control to the user (i.e. using
 DEBIAN_FRONTEND and preconfiguring).  At the moment, current
 non-interactive behaviour is one of:
 - avoid running apt-listbugs, due to work-around for #662983;
 - abort always when RC bugs.
 
 The second is, IMO, the more reasonable default.  Ideally, the minimum
 severity of bugs to cause abort should be configurable but that is yet
 another wishlist :-)
[..]

No doubt the current behaviour of noop is not doing apt-listbugs justice.
I agree that debconf is generally the best way to handle a situation where
terminal interaction may or may not be possible.

But as far as I understand, debconf could only be used to set/retrieve a generic
policy decision: whether and at what level of severity should packages be
pin'ed, right? If that is so, then debconf can not support the current
granularity of user interaction: ie. I want to pin this and that package and
I'm OK upgrading this other one.

If I understand correctly, debconf can only be used with predefined templates,
thus predefined generic policy questions (as opposed to questions that can be
different on every invocation).

If that is so, then debconf would be an improvement over the current noop, but
would still leave something be desired.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#628996: apt-listbugs: please use debconf

On Mon, Mar 18, 2013 at 08:00:51PM +0800, Daniel Hartwig wrote:
 On 18 March 2013 18:56, Serafeim Zanikolas s...@debian.org wrote:
[..]
  If I understand correctly, debconf can only be used with predefined 
  templates,
  thus predefined generic policy questions (as opposed to questions that can 
  be
  different on every invocation).
 
 Yes, the templates are predefined, but the questions are not.  A
 question is a template with potentially some substitutions made.  The
 substitutions can be arbitrary, including multi-line strings, and
 there should be little if any flexability lost.  Effectively it is no
 different to printf type string templates, coupled with pre-determined
 responses (such as, what action to take for pkg X with bugs Y).

Daniel, thanks for taking the time to clarify. It makes sense now.

Francesco, implementation details aside, are you OK with the direction?

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#698832: Copyright patch

Control: tag -1 +patch

Hi Felix,

Thanks for preparing the patch. Some minor points:

- the release version should be 0.4.3+dfsg-0.1 (as per
  http://wiki.debian.org/NonMaintainerUpload)

- the changelog entry should start with:

   * Non-maintainer upload.

- the urgency should be bumped to medium or high, and the changelog should be
  explicit about the closed bug being RC.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#703207: proposed patch

Control: tag -1 +patch

Works for me.

commit 2674f3279495191233db770302d7e71d8647ce41
Author: Serafeim Zanikolas s...@debian.org
Date:   Mon Mar 18 23:09:23 2013 +0100

add postrm/preinst scripts to handle apt hook file

fixes #703207

diff --git a/debian/apt-transport-spacewalk.postrm 
b/debian/apt-transport-spacewalk.postrm
new file mode 100755
index 000..c797dec
--- /dev/null
+++ b/debian/apt-transport-spacewalk.postrm
@@ -0,0 +1,34 @@
+#! /bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+
+case $1 in
+purge)
+rm -f $hook.disabled
+;;
+
+remove)
+mv $hook $hook.disabled
+;;
+
+abort-install)
+if test x$2 != x  test -f $hook
+then
+mv $hook $hook.disabled
+fi
+;;
+
+upgrade|failed-upgrade|abort-upgrade|disappear)
+;;
+
+*)
+echo postrm called with unknown argument \`$1' 2
+exit 1
+
+esac
+
+#DEBHELPER#
+
+exit 0
diff --git a/debian/apt-transport-spacewalk.preinst 
b/debian/apt-transport-spacewalk.preinst
new file mode 100755
index 000..0bcb043
--- /dev/null
+++ b/debian/apt-transport-spacewalk.preinst
@@ -0,0 +1,13 @@
+#!/bin/sh
+
+set -e
+
+hook=/etc/apt/apt.conf.d/50spacewalk
+if test -f $hook.disabled
+then
+mv $hook.disabled $hook
+fi
+
+#DEBHELPER#
+
+exit 0 

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: Bug#671728: Bug#671726: apt: should be able to provide hook information through a named pipe

2013-03-17 Thread Serafeim Zanikolas

On Sun, Mar 17, 2013 at 12:36:22AM +0100, Francesco Poli wrote:
 On Sun, 17 Mar 2013 00:07:21 +0100 Serafeim Zanikolas wrote:
  Do you agree then that adding the fifo feature to apt and adapting
  apt-listbugs accordingly is not needed nor does it suffice for fixing 
  #662983?
 
 No, I don't agree.
 If I recall bug #662983 correctly, the trick is that, if apt-listbugs
 can read hook info through a named pipe, then it may interact with the
 user through stdin and stdout *without* having to explicitly
 reopen /dev/tty (this is the operation which is forbidden within an su
 -c command).

Francesco, thank you for the clarification. This does make sense now.

 I think this is due to the fact that your patch for apt-listbugs does
 not modify what apt-listbugs does *after* parsing the hook info sent by
 apt.

ie. not re-open /dev/tty

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: apt: should be able to provide hook information through a named pipe

2013-03-17 Thread Serafeim Zanikolas

On Sun, Mar 17, 2013 at 02:14:50PM +0800, Daniel Hartwig wrote:
 On 17 March 2013 06:56, Serafeim Zanikolas s...@debian.org wrote:
  Hi Francesco,
 
  On Sat, Mar 16, 2013 at 11:25:36PM +0100, Francesco Poli wrote [edited]:
  On Sat, 16 Mar 2013 12:05:09 +0100 David Kalnischkies wrote:
  [..]
   Using a hook-defined fifoname rather than a random fifoname should be
   okay as the later isn't more secure than the former (if an attacker has
   root rights to write to it we are doomed anyway …)
 
  Please excuse my ignorance: isn't a pre-defined fifoname prone to a
  symlink attack?
 
  It's prone only in a publicly-writable directory, which is not the case for
  /var/run.
 
   and in fact creating
   a randomly named fifo could be hard in practice …
 
  Isn't there anything like mkstemp(3) for named pipes?
 
  I'm not aware of any -- but we can get away without one anyway.
 
 The data can be passed through an open fd, similar to dpkg --status-fd
 argument.  Then there are no issues due to filesystems global
 namespace and it removes the fs as an unrequired middle-man.

Sure, that'd be an improvement. Would you make apt pass the fd number to
apt-listbugs in the command line?

   I guess the apt-listbugs patch is just for testing, but I say it 
   non-the-less:
   It would be good if at least apt-listbugs/wheezy would support both so we
   don't create backport problems that early in the (not even started) 
   wheezy
   release cycle. ;)
 
  At this point of the wheezy freeze, I cannot introduce any change into
  apt-listbugs/wheezy, except for those that fix important or RC bugs.
 
 Due to this issue and current work-around for #662983, the
 functionality of the package is severly downgraded.  Introducing a new
 interface (named pipe or open fd) is desirable for the reasons David
 says, and has potential for wheezy especially if backed by the apt
 developers.

While I appreciate the backing, I seriously doubt that anyone could make a
convincing case for a deep freeze exception, for a feature that's not even
fully developed yet (and that's not even that relevant for stable).

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: apt: should be able to provide hook information through a named pipe

2013-03-17 Thread Serafeim Zanikolas

On Sun, Mar 17, 2013 at 08:15:32PM +0800, Daniel Hartwig wrote:
 On 17 March 2013 19:56, Serafeim Zanikolas s...@debian.org wrote:
  On Sun, Mar 17, 2013 at 02:14:50PM +0800, Daniel Hartwig wrote:
  The data can be passed through an open fd, similar to dpkg --status-fd
  argument.  Then there are no issues due to filesystems global
  namespace and it removes the fs as an unrequired middle-man.
 
  Sure, that'd be an improvement. Would you make apt pass the fd number to
  apt-listbugs in the command line?
 
 or just using a well known env. variable that will also work with
 substituation in the command line.

Attached the updated patches for apt and apt-listbugs, which implement
Daniel's proposal of using an fd rather than a fifo.

The HookFifoFilename option is replaced by:

DPkgs::Tools::Options::/usr/sbin/apt-listbugs::HookAvoidStdin yes;

The default value of Pipes[0] (the fd to be inherited and read by
apt-listbugs) was normally 3, which seems to be FD_CLOEXEC'd somewhere before
the exec to apt-listbugs (apt-listbugs was failing with EBADF), so I'm using
instead 20 as a minimum.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff --git a/apt-listbugs b/apt-listbugs
index 58d67cb..b387947 100755
--- a/apt-listbugs
+++ b/apt-listbugs
@@ -289,7 +289,19 @@ when apt
   puts if $DEBUG
   puts Pre-Install-Pkgs hook info: if $DEBUG
   state=1
-  STDIN.each { |pkg|
+  apt_hook_fd = ENV[AptHookFd]
+  if apt_hook_fd.nil?
+  $stderr.puts sprintf(_(E: AptHookFd is undefined))
+  exit(1)
+  end
+  begin
+  apt_hook_stream = IO.open(apt_hook_fd, 'r')
+  rescue Errno::ENOENT
+$stderr.puts sprintf(_(W: Cannot open file descriptor %s), apt_hook_fd)
+exit(1)
+  end
+
+  apt_hook_stream.each { |pkg|
 pkg=pkg.rstrip
 case state
 when 1
@@ -353,6 +365,7 @@ when apt
   end
 end
   }
+  apt_hook_stream.close
   puts if $DEBUG
 when list, rss
   ARGV.each { |pkg|
diff --git a/apt-pkg/deb/dpkgpm.cc b/apt-pkg/deb/dpkgpm.cc
index 6cb8bc6..dabf48c 100644
--- a/apt-pkg/deb/dpkgpm.cc
+++ b/apt-pkg/deb/dpkgpm.cc
@@ -328,8 +328,9 @@ bool pkgDPkgPM::SendV2Pkgs(FILE *F)
 // DPkgPM::RunScriptsWithPkgs - Run scripts with package names on stdin /*{{{*/
 // -
 /* This looks for a list of scripts to run from the configuration file
-   each one is run and is fed on standard input a list of all .deb files
-   that are due to be installed. */
+   each one is run and is fed on standard input (or another fd, if
+   HookAvoidStdin is set) a list of all .deb files that are due to be
+   installed. */
 bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
 {
Configuration::Item const *Opts = _config-Tree(Cnf);
@@ -352,10 +353,14 @@ bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
   
   unsigned int Version = _config-FindI(OptSec+::Version,1);
 
+  // Feed subprocess via stdin, unless HookAvoidStdin is true
+  bool const UseStdin = !_config-FindB(OptSec+::HookAvoidStdin,false);
+
   // Create the pipes
   int Pipes[2];
   if (pipe(Pipes) != 0)
 return _error-Errno(pipe,Failed to create IPC pipe to subprocess);
+  if (UseStdin == true)
   SetCloseExec(Pipes[0],true);
   SetCloseExec(Pipes[1],true);
   
@@ -364,7 +369,21 @@ bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
   if (Process == 0)
   {
 	 // Setup the FDs
+	 if (UseStdin == true)
 		dup2(Pipes[0],STDIN_FILENO);
+   else
+   {
+		// small fd numbers (5) are closed down the process tree, so use
+		// a higher number instead
+		int ChildReadFd = fcntl(Pipes[0], F_DUPFD, 20);
+		if (ChildReadFd  0)
+			return _error-Errno(fcntl,Failed to duplicate file descriptor);
+		char AptHookEnv[80];
+		if (sprintf(AptHookEnv, AptHookFd=%d, ChildReadFd)  0)
+			return _error-Errno(sprintf,Failed to contruct environment variable value);
+		if (putenv(AptHookEnv) != 0)
+			return _error-Errno(putenv,Failed to set environment variable AptHookFd);
+   }
 	 SetCloseExec(STDOUT_FILENO,false);
 	 SetCloseExec(STDIN_FILENO,false);  
 	 SetCloseExec(STDERR_FILENO,false);

Bug#671726: apt: should be able to provide hook information through a named pipe

Hi David  Francesco,

Thanks for the quick feedback.

On Sat, Mar 16, 2013 at 12:05:09PM +0100, David Kalnischkies wrote [edited]:
 Using a hook-defined fifoname rather than a random fifoname should be
 okay as the later isn't more secure than the former (if an attacker has
 root rights to write to it we are doomed anyway …) and in fact creating
 a randomly named fifo could be hard in practice …

Exactly my thinking.

 I guess the apt-listbugs patch is just for testing, but I say it non-the-less:
 It would be good if at least apt-listbugs/wheezy would support both so we
 don't create backport problems that early in the (not even started) wheezy
 release cycle. ;)

Indeed apt-listbugs is mostly for testing and unstable.

The apt-listbugs releases that ship with a fifo option will version-depend on
the earliest apt release that supports the feature. In the unlikely event of
a backport of apt-listbugs, we could always revert apt-listbugs to use stdin.

Francesco,

To test the patch you have to temporarily point
/usr/lib/i386-linux-gnu/libapt-pkg.so.4.12 to build/bin/libapt-pkg.so in an
apt checkout (and of course apply the patch to /usr/sbin/apt-listbugs).

This new apt feature opens the way for #671728, but really fixing the latter
would also require a non-interactive apt-listbugs frontend (to be used for
programmatic invocation).

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: apt: should be able to provide hook information through a named pipe

On Sat, Mar 16, 2013 at 10:32:40PM +0800, Daniel Hartwig wrote:
 Right.  Apt-listbugs is effectively called in the same context as
 maintainer scripts, and those are not guaranteed to have an
 interactive shell.  The program must be smart enough to detect this
 and do the right thing (I'm not sure if it already does :-).

By default, apt-listbugs relies on /dev/tty, but that can be overriden via the
APT_LISTBUGS_FRONTEND env variable. The only valid frontend alternative at the
moment is none, which makes apt-listbugs a noop (to avoid hanging when
invoked non-interactively). The idea would be to add a programmatic or so
frontend, which would rely on some form of IPC instead of the terminal.

 This is all regardless of the aptitude–su–login issue that prompted
 this bug report IIRC.

Indeed. In fact, I'm not sure any more that using a fifo instead of stdin is
needed for a programmatic frontend. After all, the tracebacks in #662983
suggest that the failure occurs only when apt-listbugs tries to access
/dev/tty, at which point it has already parsed the apt hook data from stdin.

Francesco, am I missing something?

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: apt: should be able to provide hook information through a named pipe

Hi Francesco,

On Sat, Mar 16, 2013 at 11:25:36PM +0100, Francesco Poli wrote [edited]:
 On Sat, 16 Mar 2013 12:05:09 +0100 David Kalnischkies wrote:
[..]
  Using a hook-defined fifoname rather than a random fifoname should be
  okay as the later isn't more secure than the former (if an attacker has
  root rights to write to it we are doomed anyway …)
 
 Please excuse my ignorance: isn't a pre-defined fifoname prone to a
 symlink attack?

It's prone only in a publicly-writable directory, which is not the case for
/var/run.

  and in fact creating
  a randomly named fifo could be hard in practice …
 
 Isn't there anything like mkstemp(3) for named pipes?

I'm not aware of any -- but we can get away without one anyway.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: Bug#671728: Bug#671726: apt: should be able to provide hook information through a named pipe

On Sat, Mar 16, 2013 at 11:25:18PM +0100, Francesco Poli wrote:
 On Sat, 16 Mar 2013 16:04:38 +0100 Serafeim Zanikolas wrote:
 
 [...]
  I'm not sure any more that using a fifo instead of stdin is
  needed for a programmatic frontend. After all, the tracebacks in #662983
  suggest that the failure occurs only when apt-listbugs tries to access
  /dev/tty, at which point it has already parsed the apt hook data from stdin.
 
 It seems to me that you are right: if I recall correctly, the failure
 indeed happens after the hook info parsing step.

Do you agree then that adding the fifo feature to apt and adapting
apt-listbugs accordingly is not needed nor does it suffice for fixing #662983?

 Anyway, implementing a new alternative frontend is an even more radical
 modification for apt-listbugs. Let's not forget that here we were only
 talking about fixing #671726 and #671728 (in order to fix #662983 in a
 better way)...

#662983, ie. relying on tty input, is not fixed by switching to a fifo: I've
reproduced the issue with fifo-based apt  apt-listbugs.

I see no other way than a non-interactive frontend (but this is a discussion
we shouldn't have on an apt bug report).

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#671726: apt: should be able to provide hook information through a named pipe

tag 671726 +patch
thanks

Hi,

The attached patch enables apt to pass Pre-Install-Pkgs hook data via a fifo,
instead of via stdin (which remains the default, of course).

Unlike the proposal in the initial bug report, the fifo filename is not
randomised, but instead declared via the following configuration option in
/etc/apt/apt.conf.d/10apt-listbugs:

DPkg::Tools::Options::/usr/sbin/apt-listbugs::HookFifoFilename 
/var/run/apt-listbugs-hook

I've tested the patch successfully with a locally modified version of
apt-listbugs, so as to make it read from the fifo instead of stdin (see second
patch, if you're interested).

This bug is one of the issues that's blocking integration of apt-listbugs with
higher level package managers (which would be nice for Debian testing users,
who are more likely to use a GUI package manager than directly apt-get).

thanks,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff --git a/apt-pkg/deb/dpkgpm.cc b/apt-pkg/deb/dpkgpm.cc
index 6cb8bc6..e84a6db 100644
--- a/apt-pkg/deb/dpkgpm.cc
+++ b/apt-pkg/deb/dpkgpm.cc
@@ -328,8 +328,9 @@ bool pkgDPkgPM::SendV2Pkgs(FILE *F)
 // DPkgPM::RunScriptsWithPkgs - Run scripts with package names on stdin /*{{{*/
 // -
 /* This looks for a list of scripts to run from the configuration file
-   each one is run and is fed on standard input a list of all .deb files
-   that are due to be installed. */
+   each one is run and is fed on standard input (or on a FIFO, if
+   HookFifoFilename is set) a list of all .deb files that are due to be
+   installed. */
 bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
 {
Configuration::Item const *Opts = _config-Tree(Cnf);
@@ -351,20 +352,35 @@ bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
   OptSec = DPkg::Tools::Options:: + string(Opts-Value.c_str(),Pos);
   
   unsigned int Version = _config-FindI(OptSec+::Version,1);
-  
-  // Create the pipes
+
+  // Feed subprocess via stdin, unless HookFifoFilename is set
+  string const FifoFilename = _config-Find(OptSec+::HookFifoFilename);
+  bool const UseFifo = (FifoFilename.empty() != true);
+
   int Pipes[2];
-  if (pipe(Pipes) != 0)
-	 return _error-Errno(pipe,Failed to create IPC pipe to subprocess);
-  SetCloseExec(Pipes[0],true);
-  SetCloseExec(Pipes[1],true);
+
+  // Create pipes or fifo
+  if (UseFifo == true)
+  {
+  // try to remove stale hook fifo if it exists
+  if ((unlink(FifoFilename.c_str()) == -1)  (errno != ENOENT))
+return _error-Errno(unlink,Failed to remove stale hook fifo);
+  if (mkfifo(FifoFilename.c_str(), 600) == -1)
+return _error-Errno(mkfifo,Failed to create hook fifo);
+  } else {
+  if (pipe(Pipes) != 0)
+return _error-Errno(pipe,Failed to create IPC pipe to subprocess);
+  SetCloseExec(Pipes[0],true);
+  SetCloseExec(Pipes[1],true);
+  }
   
   // Purified Fork for running the script
   pid_t Process = ExecFork();  
   if (Process == 0)
   {
 	 // Setup the FDs
-	 dup2(Pipes[0],STDIN_FILENO);
+	 if (UseFifo == false)
+		dup2(Pipes[0],STDIN_FILENO);
 	 SetCloseExec(STDOUT_FILENO,false);
 	 SetCloseExec(STDIN_FILENO,false);  
 	 SetCloseExec(STDERR_FILENO,false);
@@ -378,8 +394,15 @@ bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
 	 execv(Args[0],(char **)Args);
 	 _exit(100);
   }
-  close(Pipes[0]);
-  FILE *F = fdopen(Pipes[1],w);
+
+FILE *F;
+if (UseFifo == true)
+{
+F = fopen(FifoFilename.c_str(), w);
+} else {
+close(Pipes[0]);
+F = fdopen(Pipes[1],w);
+}
   if (F == 0)
 	 return _error-Errno(fdopen,Faild to open new FD);
   
@@ -409,7 +432,10 @@ bool pkgDPkgPM::RunScriptsWithPkgs(const char *Cnf)
   fclose(F);
   
   // Clean up the sub process
-  if (ExecWait(Process,Opts-Value.c_str()) == false)
+  int RetStatus = ExecWait(Process,Opts-Value.c_str());
+  if ((UseFifo == true)  (unlink(FifoFilename.c_str()) == -1))
+	 return _error-Errno(unlink,Failed to remove hook fifo);
+  if (RetStatus == false)
 	 return _error-Error(Failure running script %s,Opts-Value.c_str());
}
 
diff --git a/apt-listbugs b/apt-listbugs
index 58d67cb..bed944f 100755
--- a/apt-listbugs
+++ b/apt-listbugs
@@ -289,7 +289,15 @@ when apt
   puts if $DEBUG
   puts Pre-Install-Pkgs hook info: if $DEBUG
   state=1
-  STDIN.each { |pkg|
+  apt_fifo_filename = /var/run/apt-listbugs-hook
+  begin
+  apt_fifo_fd = open(apt_fifo_filename, 'r')
+  rescue Errno::ENOENT
+$stderr.puts sprintf(_(W: Cannot open %s), apt_fifo_filename)
+exit(1)
+  end
+
+  apt_fifo_fd.each { |pkg|
 pkg=pkg.rstrip
 case state
 when 1
@@ -353,6 +361,7 @@ when apt
   end
 end
   }
+  apt_fifo_fd.close
   puts if $DEBUG
 when list, rss

Bug#703050: www.debian.org: Please document the criteria for debian.net services to be integrated into debian.org

2013-03-15 Thread Serafeim Zanikolas

Hi Sebastian,

On Fri, Mar 15, 2013 at 03:41:40AM +0100, Sebastian Harl wrote [edited]:
 On Thu, Mar 14, 2013 at 05:08:29PM +0100, Serafeim Zanikolas wrote:
  Some debian.net services would serve their purpose better if they were
  integrated into the www.d.o namespace, but the criteria for deciding which
  services would qualify is not documented.
 
 I don't think that it makes sense to write down any such list of
 criteria. Imho, this needs to be a case-by-case decision and the exact
 criteria greatly depend on what kind of service is offered. E.g., in the
[..]

I agree that there can't be an exhaustive and general-enough list of such
criteria.

Having said that, it would be useful to set some broad expectations on what it
takes for a d.n service to graduate to an official one. Even some generic
guidelines would have the benefit of informing developers at the beginning of
a developing a service (eg. likelihood of support of certain technical
choices), and could later on be the starting point of a discussion of
promoting that service to an official one.

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#703050: www.debian.org: Please document the criteria for debian.net services to be integrated into debian.org

2013-03-14 Thread Serafeim Zanikolas

Package: www.debian.org
Severity: normal

Hi,

Some debian.net services would serve their purpose better if they were
integrated into the www.d.o namespace, but the criteria for deciding which
services would qualify is not documented.

Here's some suggestions that could be a useful start:

- there is consensus and/or evidence that the service is useful enough to
  warrant attention from d.o visitors

- the developer of the service is willing to stay around to maintain the
  service, and/or produce sufficient documentation for its maintenance

- the service's web site uses d.o's stylesheets and navigation, and meets the
  web team's accessibility requirements

- the web team feels comfortable to support the service from a security
  perspective (eg. because the site is a bunch of static HTML files, or
  if it's dynamic, it uses a stack that's considered acceptable)

- the original developer is willing to address any other concerns the web team
  might have

cheers,
sez

ps. my personal motivation for this bug report is wnpp-by-tags.d.n which I
think would serve its purpose better by relocating to eg.
www.d.o/devel/wnpp/by_tags and linked to from www.d.o/devel/wnpp


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#701617: maint-guide: new URL for wnpp-by-tags

2013-02-25 Thread Serafeim Zanikolas

Package: maint-guide
Version: 1.2.31
Severity: normal
Tags: patch

Hi,

Please apply the attached patch to update the URL for the wnpp-by-tags
service.

Thanks,
sez

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

maint-guide depends on no packages.

maint-guide recommends no packages.

Versions of packages maint-guide suggests:
ii  debian-policy 3.9.4.0
ii  developers-reference  3.4.9
ii  devscripts2.12.6
ii  dh-make   0.61
ii  doc-base  0.10.4
ii  dput  0.9.6.3+nmu1
ii  fakeroot  1.18.4-2
ii  lintian   2.5.10.4
ii  pbuilder  0.213
ii  quilt 0.60-7

-- no debconf information
diff --git a/common.ent b/common.ent
index a6bc5af..f4d588b 100644
--- a/common.ent
+++ b/common.ent
@@ -169,7 +169,7 @@ Remember, the *first* definition of an entity wins.
 !ENTITY utf8 http://en.wikipedia.org/wiki/UTF-8;
 !ENTITY virtual-package http://www.debian.org/doc/packaging-manuals/virtual-package-names-list.txt;
 !ENTITY wnpp-bts http://bugs.debian.org/wnpp;
-!ENTITY wnpp-debtags http://members.hellug.gr/serzan/wnpp/;
+!ENTITY wnpp-debtags http://wnpp-by-tags.debian.net/;
 !ENTITY wnpp-dn http://wnpp.debian.net/;
 !ENTITY wnpp-do http://www.debian.org/devel/wnpp/;

Bug#698140: Beanstalkd: OUT_OF_MEMORY after crash

2013-01-14 Thread Serafeim Zanikolas

Hi Gregory,

Thanks for the bug report.

On Mon, Jan 14, 2013 at 01:04:37PM +0200, Gregory Potamianos wrote:
[..]
 Beanstalkd reports OUT_OF_MEMORY error after unclean termination (crash) [1]
 Fix [2] seems to apply cleanly in 1.4.6-4

Unfortunately, it'll have to wait for an update after wheezy's release, as the
issue does not meet the release team's criteria for a freeze exception.

http://release.debian.org/wheezy/freeze_policy.html

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#698140: Beanstalkd: OUT_OF_MEMORY after crash

2013-01-14 Thread Serafeim Zanikolas

Hi again,

On Mon, Jan 14, 2013 at 04:24:45PM +0200, Potamianos Gregory wrote:
[..]
 If the server crashes with an empty binlog, on the next startup it
 answers every submitted job with out of memory error and discards
 it. So the service is rendered useless and requires manual
 intervention.

 Furthermore the patch is very trivial. Maybe it should be reconsidered?

Sure. Preparing the release is trivial -- it's bugging the release team for a
package with a small number of users I was concerned about.

bye,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#698160: tpu: beanstalkd/1.4.6-5 (pre-approval)

2013-01-14 Thread Serafeim Zanikolas

Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: tpu

Hi,

I'd like to get your approval about the upload of beanstalkd 1.4.6-5 to
testing-proposed-updates to add a two-line RC bug fix that's already applied
upstream.

Please find below the source diff and debdiff against the current release in
testing.

thanks,
sez


diff --git a/debian/changelog b/debian/changelog
index 1e5ee8c..e6d62ba 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+beanstalkd (1.4.6-5) testing-proposed-updates; urgency=low
+
+  * Add fix-empty-binlog-oom.diff (from upstream commit 70b63d5) to fix
+OUT_OF_MEMORY error after crash (Closes: #698140, aka upstream issue 44)
+
+ -- Serafeim Zanikolas s...@debian.org  Mon, 14 Jan 2013 17:17:27 +0100
+
 beanstalkd (1.4.6-4) testing-proposed-updates; urgency=low
 
   * Add fiu-fix.diff (upstream commit 3176e28) to fix FTBFS due to
diff --git a/debian/patches/fix-empty-binlog-oom.diff 
b/debian/patches/fix-empty-binlog-oom.diff
new file mode 100644
index 000..43ef743
--- /dev/null
+++ b/debian/patches/fix-empty-binlog-oom.diff
@@ -0,0 +1,16 @@
+# Description: eliminate OOM error after server crash
+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698140
+# Origin: 
https://github.com/kr/beanstalkd/commit/70b63d5f52010d5b286f146058573849d8b95a81
+--- a/binlog.c
 b/binlog.c
+@@ -111,6 +111,10 @@
+ 
+ oldest_binlog = b-next;
+ 
++if (newest_binlog == b) {
++newest_binlog = b-next; /* == 0 */
++}
++
+ unlink(b-path);
+ free(b);
+ }
diff --git a/debian/patches/series b/debian/patches/series
index f30298a..97715b5 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
+fix-empty-binlog-oom.diff
 fiu-fix.diff
 rename-dprintf.diff
 randomise-port.diff


$ debdiff /var/cache/pbuilder/result/beanstalkd_1.4.6-4_i386.deb 
/var/cache/pbuilder/result/beanstalkd_1.4.6-5_i386.deb
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Version: [-1.4.6-4-] {+1.4.6-5+}

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#482446: The Debian package debram, and your ancient patch

2013-01-03 Thread Serafeim Zanikolas

Hi Thaddeus,

On Thu, Jan 03, 2013 at 05:38:22PM +, Thaddeus H. Black wrote:
 Long ago, you submitted a patch to the Debian package
 Debram, on which I never acted.  I have had plans to
[..]
 You can take over maintenance of the package if you
 wish.  You can become the regular maintainer of Debram.

Thanks for getting back to me, even if it's several years later :)

debram's a nice program but the purpose its meant to serve is well addressed
by debtags and I don't see a good reason for maintaining two different package
classifications.

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#695715: fixed in cflow 1:1.4+dfsg1-1

2012-12-14 Thread Serafeim Zanikolas

Dear Adam,

On Wed, Dec 12, 2012 at 08:22:30PM +, Adam D. Barratt wrote:
 On Wed, 2012-12-12 at 19:32 +, Serafeim Zanikolas wrote:
   cflow (1:1.4+dfsg1-1) unstable; urgency=high
   .
 * Repackage with non DFSG-free texinfo files stripped out of the source 
  and
   binary package (closes: #695715).
 
 Thanks for fixing this. Unfortunately, the fact that you also made this
 change:
 
 * Raise debhelper compatibility level to 9 and update the debhelper 
  version
   dependency, to enable security hardening
 
 means the package is unlikely to get unblocked. fwiw, this is explicitly
 mentioned in rule #1 on
 http://release.debian.org/wheezy/freeze_policy.html

I've reverted the latter change and re-uploaded to unstable.

Below's the diff against the previous version in unstable (and attached the
diff against the version in testing).

Please unblock cflow 1:1.4+dfsg1-2.

Thanks,
sez


diff --git a/debian/changelog b/debian/changelog
index ed739e3..545c4bb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+cflow (1:1.4+dfsg1-2) unstable; urgency=high
+
+  * Revert debian/compat to 7 and versioned dependency on debhelper to
+7.0.50~, to meet current freeze rules.
+
+ -- Serafeim Zanikolas s...@debian.org  Fri, 14 Dec 2012 10:41:13 +0100
+
 cflow (1:1.4+dfsg1-1) unstable; urgency=high
 
   * Repackage with non DFSG-free texinfo files stripped out of the source and
diff --git a/debian/compat b/debian/compat
index ec63514..7f8f011 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+7
diff --git a/debian/control b/debian/control
index 612f05f..f29c233 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,7 @@ Source: cflow
 Section: devel
 Priority: optional
 Maintainer: Serafeim Zanikolas s...@debian.org
-Build-Depends: debhelper (= 9), docbook-xml (= 4.5), docbook-xsl, xsltproc
+Build-Depends: debhelper (= 7.0.50~), docbook-xml (= 4.5), docbook-xsl, 
xsltproc
 Standards-Version: 3.9.2
 Homepage: http://www.gnu.org/software/cflow/
 Vcs-Hg: http://hg.debian.org/hg/collab-maint/cflow/


$ debdiff /var/cache/pbuilder/result/cflow_1.4+dfsg1-1_i386.deb 
/var/cache/pbuilder/result/cflow_1.4+dfsg1-2_i386.deb

File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Depends: libc6 (= [-2.4)-] {+2.3)+}
Version: [-1:1.4+dfsg1-1-] {+1:1.4+dfsg1-2+}

-- 
Every great idea is worthless without someone to do the work. --Neil Williams
diff --git a/debian/README.source b/debian/README.source
new file mode 100644
index 000..0f8e3d4
--- /dev/null
+++ b/debian/README.source
@@ -0,0 +1,2 @@
+The upstream source has been repackaged without these non-DFSG-free files:
+cflow.info cflow.texi fdl.texi
diff --git a/debian/changelog b/debian/changelog
index 35ef08d..545c4bb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,24 @@
+cflow (1:1.4+dfsg1-2) unstable; urgency=high
+
+  * Revert debian/compat to 7 and versioned dependency on debhelper to
+7.0.50~, to meet current freeze rules.
+
+ -- Serafeim Zanikolas s...@debian.org  Fri, 14 Dec 2012 10:41:13 +0100
+
+cflow (1:1.4+dfsg1-1) unstable; urgency=high
+
+  * Repackage with non DFSG-free texinfo files stripped out of the source and
+binary package (closes: #695715).
+  - Add dversionmangle in debian/watch
+  - Add debian/patches/nodocs to patch upstream Makefile to not traverse
+into the doc directory
+  - debian/rules clean: wipe autogenerated doc/Makefile
+  - Add debian/README.source
+  * Raise debhelper compatibility level to 9 and update the debhelper version
+dependency, to enable security hardening
+
+ -- Serafeim Zanikolas s...@debian.org  Wed, 12 Dec 2012 17:25:47 +0100
+
 cflow (1:1.4-1) unstable; urgency=low
 
   * New upstream release.
diff --git a/debian/info b/debian/info
deleted file mode 100644
index 911fe2b..000
--- a/debian/info
+++ /dev/null
@@ -1 +0,0 @@
-doc/cflow.info
diff --git a/debian/patches/nodocs b/debian/patches/nodocs
new file mode 100644
index 000..b8fc265
--- /dev/null
+++ b/debian/patches/nodocs
@@ -0,0 +1,15 @@
+# Description: do not run make in the doc directory
+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695715
+# Author: Serafeim Zanikolas
+# Last-Update: 2012-12-12
+--- a/Makefile.in
 b/Makefile.in
+@@ -734,7 +734,7 @@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ ACLOCAL_AMFLAGS = -I m4
+-SUBDIRS = gnu src elisp po doc tests
++SUBDIRS = gnu src elisp po tests
+ EXTRA_DIST = ChangeLog.2007
+ 
+ # Define the following variables in order to use the ChangeLog rule below:
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..456c63c
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+nodocs
diff --git a/debian/rules b/debian/rules
index 2a6207c..9b6f481 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,8 +15,12 @@ override_dh_auto_install

Bug#695715: fixed in cflow 1:1.4+dfsg1-1

2012-12-12 Thread Serafeim Zanikolas

On Wed, Dec 12, 2012 at 08:22:30PM +, Adam D. Barratt wrote:
 On Wed, 2012-12-12 at 19:32 +, Serafeim Zanikolas wrote:
   cflow (1:1.4+dfsg1-1) unstable; urgency=high
   .
 * Repackage with non DFSG-free texinfo files stripped out of the source 
  and
   binary package (closes: #695715).
 
 Thanks for fixing this. Unfortunately, the fact that you also made this
 change:
 
 * Raise debhelper compatibility level to 9 and update the debhelper 
  version
   dependency, to enable security hardening
 
 means the package is unlikely to get unblocked. fwiw, this is explicitly
 mentioned in rule #1 on
 http://release.debian.org/wheezy/freeze_policy.html

oh sorry about that :-/

Shall I target the new release to unstable or testing-proposed-updates? (in
the case of the latter, I'll post a diff before doing the upload).

thanks,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#665199: Initiate dumping of dbs, but actual dumping yet to be fixed

2012-12-11 Thread Serafeim Zanikolas

Hi,

Here's a tested patch for the part of the problem that's described in message
#17 in this bug report. We still need a solution for the issue described in
message #68.

Cheers,
sez


--- openldap-2.4.31/debian/slapd.postinst   2012-12-11 14:34:47.0 
+0100
+++ new/openldap-2.4.31/debian/slapd.postinst   2012-12-11 20:58:39.0 
+0100
@@ -78,6 +78,9 @@ fi
 if is_initial_configuration $@; then
postinst_initial_configuration
 else
+   if [ $MODE = configure ]  previous_version_older 2.4.31-1; then
+   dump_databases
+   fi
postinst_upgrade_configuration
 fi
 

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#695377: sysbench: /usr/share/doc/sysbench/manual.html is empty

2012-12-07 Thread Serafeim Zanikolas

Package: sysbench
Version: 0.4.12-1+b1
Severity: normal

hi,

sysbench ships an empty html manual file.

$ ls -l /usr/share/doc/sysbench/manual.html
-rw-r--r-- 1 root root 0 Jun  9 19:50 /usr/share/doc/sysbench/manual.html

thanks,
sez


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sysbench depends on:
ii  libc6 2.13-37
ii  libmysqlclient18  5.5.28+dfsg-1

sysbench recommends no packages.

sysbench suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#695198: pu: package bogofilter/1.2.2-2

2012-12-05 Thread Serafeim Zanikolas

Package: release.debian.org
Severity: serious
User: release.debian@packages.debian.org
Usertags: pu security

Hi,

Please pre-approve an upload to stable-security to update bogofilter for
http://security-tracker.debian.org/tracker/CVE-2012-5468

Here's the diff against the package in squeeze (which, other than targeting
stable-security, is the same as the one in unblock request #695139, for
wheezy).

Thanks,
sez

ps. I've verified that 1.2.2-2+squeeze1 is less than the wheezy release
1.2.2+dfsg1-1


diff --git a/debian/changelog b/debian/changelog
index eb7c512..6b93ab8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+bogofilter (1.2.2-2+squeeze1) stable-security; urgency=high
+
+  * Cherry-pick fix and test for CVE-2012-5468 (aka bogofilter-SA-2012-01)
+from upstream release 1.2.3. Setting urgency to high. closes: #695139.
+
+ -- Serafeim Zanikolas s...@debian.org  Tue, 04 Dec 2012 20:08:50 +0100
+
 bogofilter (1.2.2-2) unstable; urgency=high
 
   * Add debian/bogofilter-{bdb,sqlite,tokyocabinet}.preinst to remove
diff --git a/debian/patches/sa-2012-01-fix.diff 
b/debian/patches/sa-2012-01-fix.diff
new file mode 100644
index 000..3214560
--- /dev/null
+++ b/debian/patches/sa-2012-01-fix.diff
@@ -0,0 +1,70 @@
+# Description: apply fix and test for CVE-2012-5468 (aka bogofilter-SA-2012-01)
+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695139
+# Author: Matthias Andree
+# Last-Update: 2012-12-03
+--- a/src/iconvert.c
 b/src/iconvert.c
+@@ -76,7 +76,7 @@
+   outbuf = (char *)dst-t.u.text + dst-t.leng;
+   outbytesleft = dst-size - dst-read - dst-t.leng;
+ 
+-  if (outbytesleft == 0)
++  if (outbytesleft = 0)
+   break;
+ 
+   /*
+@@ -141,6 +141,10 @@
+   switch (err) {
+   case EILSEQ:/* invalid multibyte sequence */
+   case EINVAL:/* incomplete multibyte sequence */
++  if(outbytesleft = 0) {
++done = true;
++break;
++  }
+   /* copy 1 byte (or substitute a '?') */
+   if (!replace_nonascii_characters)
+   *outbuf = *inbuf;
+--- a/src/tests/Makefile.am
 b/src/tests/Makefile.am
+@@ -45,6 +45,7 @@
+   t.multiple.tokens.head t.multiple.tokens.body t.multiple.tokens.min.mul 
\
+   $(ENCODING_TESTS) \
+   t.rfc2047_broken t.rfc2047_folded \
++  t.crash-invalid-base64 \
+   t.message_addr t.message_id t.queue_id
+ 
+ WORDLIST_TESTS = t.dump.load t.nonascii.replace t.maint t.robx t.regtest 
t.upgrade.subnet.prefix t.multiple.wordlists t.probe t.bf_compact
+--- /dev/null
 b/src/tests/t.crash-invalid-base64
+@@ -0,0 +1,21 @@
++#! /bin/sh
++
++. ${srcdir:=.}/t.frame
++
++# make sure that we do not crash on excessively long tokens
++# Test program by Julius Plenz, TU Berlin.
++perl -e '
++print EOF
++Content-Type: multipart/mixed;boundary==_20121014031204_57463
++
++--=_20121014031204_57463
++Content-Type: text/plain; charset=utf-8
++
++--=_20121014031204_57463
++Content-Transfer-Encoding: base64
++
++EOF
++;
++print((vfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvf\n)x600);
++print --=_20121014031204_57463--;' \
++| $VAL $BOGOFILTER -p -e -C  /dev/null
+--- a/src/tests/Makefile.in
 b/src/tests/Makefile.in
+@@ -269,6 +269,7 @@
+   t.multiple.tokens.head t.multiple.tokens.body t.multiple.tokens.min.mul 
\
+   $(ENCODING_TESTS) \
+   t.rfc2047_broken t.rfc2047_folded \
++  t.crash-invalid-base64 \
+   t.message_addr t.message_id t.queue_id
+ 
+ WORDLIST_TESTS = t.dump.load t.nonascii.replace t.maint t.robx t.regtest 
t.upgrade.subnet.prefix t.multiple.wordlists t.probe t.bf_compact
diff --git a/debian/patches/series b/debian/patches/series
index 623fd92..cbc11bd 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+sa-2012-01-fix.diff
 use-tar-instead-of-pax.diff


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#695139: bogofilter-common: CVE-2012-5468

2012-12-04 Thread Serafeim Zanikolas

On Tue, Dec 04, 2012 at 04:16:05PM +0100, Moritz Muehlenhoff wrote:
 Package: bogofilter-common
 Severity: grave
 Tags: security
[..]
 Please upload an isolated fix to unstable and ask the release managers for
 an unblock.

I have it in mind for tonight, thanks.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#695189: unblock: bogofilter/1.2.2+dfsg1-2

2012-12-04 Thread Serafeim Zanikolas

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package bogofilter to apply a fix for
http://security-tracker.debian.org/tracker/CVE-2012-5468

Here's the diff against the package in testing:

diff --git a/debian/changelog b/debian/changelog
index cba2961..edb917e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+bogofilter (1.2.2+dfsg1-2) unstable; urgency=high
+
+  * Cherry-pick fix and test for CVE-2012-5468 (aka bogofilter-SA-2012-01)
+from upstream release 1.2.3. Setting urgency to high. closes: #695139.
+
+ -- Serafeim Zanikolas s...@debian.org  Tue, 04 Dec 2012 20:08:50 +0100
+
 bogofilter (1.2.2+dfsg1-1) unstable; urgency=low
 
   * Rebuild with repackaged source to exclude non-DFSG-free licensed security
diff --git a/debian/patches/sa-2012-01-fix.diff 
b/debian/patches/sa-2012-01-fix.diff
new file mode 100644
index 000..3214560
--- /dev/null
+++ b/debian/patches/sa-2012-01-fix.diff
@@ -0,0 +1,70 @@
+# Description: apply fix and test for CVE-2012-5468 (aka bogofilter-SA-2012-01)
+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695139
+# Author: Matthias Andree
+# Last-Update: 2012-12-03
+--- a/src/iconvert.c
 b/src/iconvert.c
+@@ -76,7 +76,7 @@
+   outbuf = (char *)dst-t.u.text + dst-t.leng;
+   outbytesleft = dst-size - dst-read - dst-t.leng;
+ 
+-  if (outbytesleft == 0)
++  if (outbytesleft = 0)
+   break;
+ 
+   /*
+@@ -141,6 +141,10 @@
+   switch (err) {
+   case EILSEQ:/* invalid multibyte sequence */
+   case EINVAL:/* incomplete multibyte sequence */
++  if(outbytesleft = 0) {
++done = true;
++break;
++  }
+   /* copy 1 byte (or substitute a '?') */
+   if (!replace_nonascii_characters)
+   *outbuf = *inbuf;
+--- a/src/tests/Makefile.am
 b/src/tests/Makefile.am
+@@ -45,6 +45,7 @@
+   t.multiple.tokens.head t.multiple.tokens.body t.multiple.tokens.min.mul 
\
+   $(ENCODING_TESTS) \
+   t.rfc2047_broken t.rfc2047_folded \
++  t.crash-invalid-base64 \
+   t.message_addr t.message_id t.queue_id
+ 
+ WORDLIST_TESTS = t.dump.load t.nonascii.replace t.maint t.robx t.regtest 
t.upgrade.subnet.prefix t.multiple.wordlists t.probe t.bf_compact
+--- /dev/null
 b/src/tests/t.crash-invalid-base64
+@@ -0,0 +1,21 @@
++#! /bin/sh
++
++. ${srcdir:=.}/t.frame
++
++# make sure that we do not crash on excessively long tokens
++# Test program by Julius Plenz, TU Berlin.
++perl -e '
++print EOF
++Content-Type: multipart/mixed;boundary==_20121014031204_57463
++
++--=_20121014031204_57463
++Content-Type: text/plain; charset=utf-8
++
++--=_20121014031204_57463
++Content-Transfer-Encoding: base64
++
++EOF
++;
++print((vfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvfvf\n)x600);
++print --=_20121014031204_57463--;' \
++| $VAL $BOGOFILTER -p -e -C  /dev/null
+--- a/src/tests/Makefile.in
 b/src/tests/Makefile.in
+@@ -269,6 +269,7 @@
+   t.multiple.tokens.head t.multiple.tokens.body t.multiple.tokens.min.mul 
\
+   $(ENCODING_TESTS) \
+   t.rfc2047_broken t.rfc2047_folded \
++  t.crash-invalid-base64 \
+   t.message_addr t.message_id t.queue_id
+ 
+ WORDLIST_TESTS = t.dump.load t.nonascii.replace t.maint t.robx t.regtest 
t.upgrade.subnet.prefix t.multiple.wordlists t.probe t.bf_compact
diff --git a/debian/patches/series b/debian/patches/series
index 623fd92..cbc11bd 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+sa-2012-01-fix.diff
 use-tar-instead-of-pax.diff


unblock bogofilter/1.2.2+dfsg1-2

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#690545: /usr/bin/fiu-ctrl: ignores deprecated options silently

2012-10-18 Thread Serafeim Zanikolas

On Wed, Oct 17, 2012 at 09:00:33PM +0100, Alberto Bertogli wrote [edited]:
 Allright, I found the problems (there were more than one), hopefully
 they should all be fixed in 82621d9
 (http://blitiri.com.ar/git/?p=libfiu;a=commitdiff;h=82621d9).

My problem was with -e not being effective and I see that that's fixed now.
Thanks!

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#690545: /usr/bin/fiu-ctrl: ignores deprecated options silently

2012-10-16 Thread Serafeim Zanikolas

On Mon, Oct 15, 2012 at 10:55:16PM +0100, Alberto Bertogli wrote:
 Thanks for the bug report!
 
 I've wrote commit 17fdac5 that should fix it:
 http://blitiri.com.ar/git/?p=libfiu;a=commit;h=17fdac56.

Thank you too Alberto.

If you don't mind some nitpicking: deprecated means still supported but going
away in the future. That's not the case for fiu-ctrl's deprecated options, so
you might want to change the wording to something more explicit, eg. ignoring
deprecated option.

https://en.wikipedia.org/wiki/Deprecation

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#690545: /usr/bin/fiu-ctrl: ignores deprecated options silently

2012-10-15 Thread Serafeim Zanikolas

Package: fiu-utils
Version: 0.91-1+b1
Severity: normal
File: /usr/bin/fiu-ctrl

Hi,

fiu-ctrl ignores deprecated options silently. Please make it print a warning
on stdout, if not fail loudly.

Also, the listing of deprecated options in -h output does not include -d.

Thanks,

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687402: beanstalkd: proposed TPU (diff for NMU version 1.4.6-3.1)

2012-10-13 Thread Serafeim Zanikolas

Thanks Jonathan.

Dear RMs, here's an almost identical patch (also, dropping -i as it's also
deprecated, and adding VCS headers).

Thanks,
sez


diff --git a/debian/changelog b/debian/changelog
index df8d3cd..4e560e6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+beanstalkd (1.4.6-4) testing-proposed-updates; urgency=low
+
+  * Add fiu-fix.diff (upstream commit 3176e28) to fix FTBFS due to
+fiu-ctrl silently ignoring obsolete command line arguments
+(Closes: #687402)
+  * Bump up Standards-Version to 3.9.4
+- Add Vcs-* headers in debian/control
+
+ -- Serafeim Zanikolas s...@debian.org  Mon, 08 Oct 2012 18:57:43 +0200
+
 beanstalkd (1.4.6-3) unstable; urgency=high
 
   * Patch sh-tests/common.functions to randomise the listener port during
diff --git a/debian/control b/debian/control
index 0eacaeb..ad2d77e 100644
--- a/debian/control
+++ b/debian/control
@@ -5,8 +5,10 @@ Maintainer: Serafeim Zanikolas s...@debian.org
 Build-Depends: debhelper (= 7.0.50~), autotools-dev, libtool,
libevent-dev (= 1.4.1), fiu-utils (=0.13-3), procps,
net-tools, python-minimal
-Standards-Version: 3.9.2
+Standards-Version: 3.9.4
 Homepage: http://xph.us/software/beanstalkd/
+Vcs-Git: git://git.debian.org/collab-maint/beanstalkd.git
+Vcs-Browser: http://git.debian.org/?p=collab-maint/beanstalkd.git
 
 Package: beanstalkd
 Architecture: any
diff --git a/debian/patches/fiu-fix.diff b/debian/patches/fiu-fix.diff
new file mode 100644
index 000..dcc2b7d
--- /dev/null
+++ b/debian/patches/fiu-fix.diff
@@ -0,0 +1,60 @@
+# Description: correct fiu-ctrl arguments for 0.90
+# Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687402
+# Author: Keith Rarick k...@xph.us
+# Last-Update: 2012-10-08
+--- a/sh-tests/binlog-diskfull-delete.sh
 b/sh-tests/binlog-diskfull-delete.sh
+@@ -2,7 +2,6 @@
+ 
+ . $SRCDIR/sh-tests/common.functions
+ 
+-ENOSPC=28
+ server=localhost
+ tmpdir=$TMPDIR
+ size=1000
+@@ -81,7 +80,7 @@
+ }
+ 
+ # Make beanstalkd think the disk is full now.
+-fiu-ctrl -e posix/io/oc/open -i $ENOSPC $bpid
++fiu-ctrl -c 'enable name=posix/io/oc/open' $bpid
+ 
+ # Insert enough jobs to create another binlog file
+ $nc $server $port EOF  $out1
+@@ -138,7 +137,7 @@
+ test ! -e $logdir/binlog.1 || fail First binlog file is still there
+ 
+ # Now make beanstalkd think the disk once again has space.
+-fiu-ctrl -d posix/io/oc/open $bpid
++fiu-ctrl -c 'disable name=posix/io/oc/open' $bpid
+ 
+ # Insert enough jobs to create another binlog file
+ $nc $server $port EOF  $out1
+--- a/sh-tests/binlog-diskfull.sh
 b/sh-tests/binlog-diskfull.sh
+@@ -2,7 +2,6 @@
+ 
+ . $SRCDIR/sh-tests/common.functions
+ 
+-ENOSPC=28
+ server=localhost
+ tmpdir=$TMPDIR
+ size=1000
+@@ -39,7 +38,7 @@
+ start_beanstalkd $logdir -s $size fiu-run -x
+ 
+ # Make beanstalkd think the disk is full now.
+-fiu-ctrl -e posix/io/oc/open -i $ENOSPC $bpid
++fiu-ctrl -c 'enable name=posix/io/oc/open' $bpid
+ 
+ # Insert enough jobs to create another binlog file
+ $nc $server $port EOF  $out1
+@@ -70,7 +69,7 @@
+ test $res -eq 0 || exit $res
+ 
+ # Now make beanstalkd think the disk once again has space.
+-fiu-ctrl -d posix/io/oc/open $bpid
++fiu-ctrl -c 'disable name=posix/io/oc/open' $bpid
+ 
+ # Insert enough jobs to create another binlog file
+ $nc $server $port EOF  $out1
diff --git a/debian/patches/series b/debian/patches/series
index e47659f..f30298a 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
+fiu-fix.diff
 rename-dprintf.diff
 randomise-port.diff

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#687402: beanstalkd: proposed TPU (diff for NMU version 1.4.6-3.1)

2012-10-13 Thread Serafeim Zanikolas

On Sat, Oct 13, 2012 at 09:19:24PM +0100, Adam D. Barratt wrote:
 On 13.10.2012 20:22, Serafeim Zanikolas wrote:
 Dear RMs, here's an almost identical patch (also, dropping -i as
 it's also
 deprecated, and adding VCS headers).
 
 On the whole, this looks fine; thanks. However:
 
 +  * Bump up Standards-Version to 3.9.4
 
 The d-d-a mail announcing the release of policy 3.9.4 specifically
 asked people *not* to do that.

oh sorry about that; will upload with S-V set to 3.9.3 then.

thanks,

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#687402: beanstalkd: FTBFS: tests failed

2012-10-08 Thread Serafeim Zanikolas

On Mon, Oct 08, 2012 at 12:20:11AM -0700, Keith Rarick wrote:
 On Mon, Oct 8, 2012 at 12:15 AM, Keith Rarick k...@xph.us wrote:
  You can see the change at
 
  https://github.com/kr/beanstalkd/compare/fiu

Thanks. No need for an upstream release.

I'll also drop -i from the fiu-ctrl invocation (it's silently ignored too).

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687402: beanstalkd: FTBFS: tests failed

2012-09-26 Thread Serafeim Zanikolas

That's fine Keith. Let me know please when you have something ready.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#687402: beanstalkd: FTBFS: tests failed

2012-09-25 Thread Serafeim Zanikolas

Keith,

On Mon, Sep 24, 2012 at 05:03:45PM -0700, Keith Rarick wrote:
 If libevent 1.4 is not an option, I'll get the 1.4.x series of beanstalkd
 working with libevent 2 and make a bugfix release.

Not, it's not an option.

 Should I do that?

Your previous email sort of implied that you wouldn't do that.

If that's not the case, and you don't mind supporting 1.4.x for some years to
come, then by all means. But please, whatever you choose, stick to that.

If you confirm, I'll close #688244 (see bugs.debian.org/688244)

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#688244: unblock: beanstalkd/1.7-1

2012-09-20 Thread Serafeim Zanikolas

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi,

The beanstalkd version in testing (1.4.6) is FTBFS (#687402) since libevent
was upgraded from 1.4 to 2.0.

Meanwhile beanstalkd 1.5 was released and dropped the libevent dependency all
together, but didn't make it to testing in time for the freeze because of
failing tests (which have been fixed post-freeze).

Since upstream has dropped libevent as a dependency, they're not interested in
porting beanstalkd 1.4.6 to libevent 2.0, so the release team is called to
choose between:

- drop beanstalkd in wheezy

- grant an exception to unblock beanstalkd 1.7 (1.6  1.7 were bug-fixing
  releases; 1.7-1 is in sid and builds fine on all arches)

I understand that there's no excuse for not having seen this coming before the
long-announced freeze date, so I won't argue against the first option.

Having said that, beanstalkd is a leaf package with a small popcon.

Thanks,
sez

ps. I've opted to spare you the debdiff for obvious reasons:
 137 files changed, 6436 insertions(+), 16240 deletions(-)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#687402: beanstalkd: FTBFS: tests failed

2012-09-19 Thread Serafeim Zanikolas

Hi Keith,

beanstalkd 1.4.6 does not pass anymore the test binlog-diskfull-delete.sh.
(Just a reminder: 1.4.6 is the version intended for the upcoming Debian
stable, since 1.5  1.6 had failing tests and were not fixed before the Debian
freeze deadline.)

On Wed, Sep 12, 2012 at 03:07:51PM +0200, Lucas Nussbaum wrote:
 Source: beanstalkd
 Version: 1.4.6-3
 Severity: serious
 Tags: wheezy sid
 User: debian...@lists.debian.org
 Usertags: qa-ftbfs-20120912 qa-ftbfs
 Justification: FTBFS in wheezy on amd64
 
 Hi,
 
 During a rebuild of all packages in *wheezy*, your package failed to
 build on amd64.
 
 Relevant part:
  make[1]: Entering directory `/«PKGBUILDDIR»'
  gcc -DHAVE_CONFIG_H -I. -g -O2  -Wall -Werror -I/usr/include -c -o 
  cutgen.o cutgen.c
  gcc  -g -O2  -Wall -Werror -I/usr/include  -L/usr/lib -o cutgen cutgen.o  
  -levent -levent  -levent
  mkdir -p tests
  ./cutgen -o tests/cutcheck.c ./tests/test_job.c ./tests/test_pq.c
- parsing './tests/test_job.c'... done.
- parsing './tests/test_pq.c'... done.
  gcc -DHAVE_CONFIG_H -I. -g -O2  -Wall -Werror -I/usr/include -c -o 
  tests/cutcheck.o tests/cutcheck.c
  gcc -DHAVE_CONFIG_H -I. -g -O2  -Wall -Werror -I/usr/include -c -o 
  cut.o cut.c
  gcc -DHAVE_CONFIG_H -I. -g -O2  -Wall -Werror -I/usr/include -c -o 
  tests/test_job.o tests/test_job.c
  gcc -DHAVE_CONFIG_H -I. -g -O2  -Wall -Werror -I/usr/include -c -o 
  tests/test_pq.o tests/test_pq.c
  gcc  -g -O2  -Wall -Werror -I/usr/include  -L/usr/lib -o tests/cutcheck 
  tests/cutcheck.o cut.o binlog.o conn.o job.o ms.o net.o port.o pq.o 
  primes.o prot.o tube.o util.o tests/test_job.o tests/test_pq.o  -levent 
  -levent  -levent
  tests/cutcheck
  
  0..   10...
  
  13 tests; 0 failures; 0 errors.
  SRCDIR=. ./check.sh ./sh-tests/*.commands sh-tests/*.sh
  loopback interface is configured, getting on with tests
  ./sh-tests/allow-underscore.commands
   ./beanstalkd -l 127.0.0.1 -p 40874 -z 10 
  Started beanstalkd (pid: 14488), listening on port 40874
[..]
  Started beanstalkd (pid: 14595), listening on port 41544
  sh-tests/binlog-diskfull-delete.sh
  fiu-run -x ./beanstalkd -l 127.0.0.1 -p 32452 -b /tmp/bnch14602.d -s 1000 
  Started beanstalkd (pid: 14605), listening on port 32452
  4,5c4,5
   OUT_OF_MEMORY
 
   OUT_OF_MEMORY
 
  ---
   INSERTED 9
 
   INSERTED 10
 
  FAIL: sh-tests/binlog-diskfull-delete.sh
  make[1]: *** [check-shell] Error 1

1.4.6 used to pass over a year ago (1.4.6 is what was shipped in the current
Debian stable) but it now fails with an OOM protocol error.

The failure is reproducible on amd64 and i686 (I'd guess in all arches).
Since there's been no code changes in the meantime, I'd guess this might be
due to changes in dependencies.

You can compare the list of dependencies from the failing and the latest
successful builds on amd64 from the pages below (libevent stands out; changed
from libevent-core-1.4-2 to libevent-core-2.0-5).

failing build log:
http://people.debian.org/~lucas/logs/2012/09/12/beanstalkd_1.4.6-3_wheezy.log

latest successful build log:
https://buildd.debian.org/status/fetch.php?pkg=beanstalkdarch=amd64ver=1.4.6-3stamp=1313331895

In replies, please keep the bug report in CC.

cheers,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#666775: failing beanstalkd tests (was: Beanstalkd 1.5 .deb package)

2012-09-11 Thread Serafeim Zanikolas

tag 666775 pending
thanks

On Mon, Sep 10, 2012 at 01:22:45AM -0700, Keith Rarick wrote:
 Ok, I believe this is fixed now in
[..]
 If this looks good, I'm set to make a release.

Thanks Keith. I've verified the fix on ppc, sparc  mips. Please go ahead with
a release.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#666775: failing beanstalkd tests (was: Beanstalkd 1.5 .deb package)

2012-08-30 Thread Serafeim Zanikolas

[adding back bug report in CC]

On Wed, Aug 29, 2012 at 02:31:47PM -0700, Keith Rarick wrote:
 On Wed, Aug 29, 2012 at 6:09 AM, Serafeim Zanikolas s...@debian.org wrote:
  I'm happy to keep 1.4 if you as upstream commit to support it for serious 
  bug
  and security issues for another 3+ years.
 
 I'm happy to support 1.4 for serious bug and security issues for 3+ years.
 
  As an aside, I'm not actually using beanstalkd (the reason I've packaged it 
  is
  not there any more) but I'm OK doing the packaging given a responsive
  upstream.
 
 Ok, understood. I'll try to make life easier on you in the future.
 Thanks for all your work packaging beanstalkd so far and for
 as long as you want to continue. :)

Thank you too Keith. We keep 1.4 then.

Going back to the subject of the bug report, please let me know when you have
a potential fix for the failing tests, and I'll test it on whatever arches you
don't have access to.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#666775: failing beanstalkd tests (was: Beanstalkd 1.5 .deb package)

2012-08-29 Thread Serafeim Zanikolas

Hi Keith,

Thanks for the prompt response.

On Tue, Aug 28, 2012 at 10:09:09PM -0700, Keith Rarick wrote:
 On Tue, Aug 28, 2012 at 6:29 AM, Serafeim Zanikolas s...@debian.org wrote:
  Since I haven't heard from you on a fix for 1.6, 1.5 tests never ran
  successfully, and I do not wish to keep 1.4 in the next Debian stable 
  release,
  I'm going to request the removal of beanstalkd from the Debian archive.
 
  Even if you were to prepare a fix now, I'm not sure that the release team
  would accept a new upstream version.
 
 That's too bad. Is there a compelling reason why 1.4 isn't suitable?

I'm happy to keep 1.4 if you as upstream commit to support it for serious bug
and security issues for another 3+ years.

As an aside, I'm not actually using beanstalkd (the reason I've packaged it is
not there any more) but I'm OK doing the packaging given a responsive
upstream.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#666775: failing beanstalkd tests (was: Beanstalkd 1.5 .deb package)

2012-08-28 Thread Serafeim Zanikolas

Hi Keith,

On Mon, Jul 30, 2012 at 12:45:14AM +0200, Serafeim Zanikolas wrote:
 Hi Keith,
 
 On Wed, May 23, 2012 at 01:34:48AM +0200, Serafeim Zanikolas wrote:
  On Mon, May 21, 2012 at 07:08:38PM -0700, Keith Rarick wrote:
   On Sun, May 20, 2012 at 11:35 AM, Serafeim Zanikolas s...@debian.org 
   wrote:
I've uploaded 1.6 but many tests fail with a timeout in powerpc  
s390(x)
   
   Looks like it fails on all the big-endian architectures.
   Debugging this would be much easier if I had access
   to a big-endian machine. I'll work on it.
  
  Great. Let me know if I can help by verifying a potential fix in any of 
  these
  arches.
 
 Any news on this bug? Debian's in release freeze and this is a
 release-critical bug ...

Since I haven't heard from you on a fix for 1.6, 1.5 tests never ran
successfully, and I do not wish to keep 1.4 in the next Debian stable release,
I'm going to request the removal of beanstalkd from the Debian archive.

Even if you were to prepare a fix now, I'm not sure that the release team
would accept a new upstream version.

Thanks anyway,

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


signature.asc
Description: Digital signature

Bug#666775: failing beanstalkd tests (was: Beanstalkd 1.5 .deb package)

2012-07-29 Thread Serafeim Zanikolas

Hi Keith,

On Wed, May 23, 2012 at 01:34:48AM +0200, Serafeim Zanikolas wrote:
 On Mon, May 21, 2012 at 07:08:38PM -0700, Keith Rarick wrote:
  On Sun, May 20, 2012 at 11:35 AM, Serafeim Zanikolas s...@debian.org 
  wrote:
   I've uploaded 1.6 but many tests fail with a timeout in powerpc  s390(x)
  
  Looks like it fails on all the big-endian architectures.
  Debugging this would be much easier if I had access
  to a big-endian machine. I'll work on it.
 
 Great. Let me know if I can help by verifying a potential fix in any of these
 arches.

Any news on this bug? Debian's in release freeze and this is a
release-critical bug ...

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#675589: reconf-inetd: in certain cases, inetd.conf entries are concatenated

Package: reconf-inetd
Version: 1.120523
Severity: important

see http://lists.debian.org/debian-mentors/2012/05/msg00479.html



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#673600: RFS: nyancat/1.0+git20120519.5fe3de9-1

quoting Jakub Wilk:
 But next reconf-inetd run can happen a month later. (Or never.) In the mean
 time, nyancat server won't be running, will it? Or did I misunderstand
 something?

That's right. I take responsibility for that; I didn't realise that the
postinst script would run after the reconf-inetd trigger.

In any case, the solution is simple: invoke reconf-inetd right after
update-inetd in postinst.

On a different topic, nyancat/1.0+git20120519.5fe3de9-1 checks for only a
specific release:

if [ $2 = 0.1+git20120401.5a88b86-1 ]; then

whereas ideally it'd take action on any release less than or equal to that.
(perhaps that's not relevant to nyancat, but it'd be nice to get it right,
because I suspect that other maintainers will copy from it)

thanks,
sez

-- 
Every great idea is worthless without someone to do the work. --Neil Williams



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#675679: reconf-inetd: managed fragments are not removed upon purge

Hi Jon,

On Sat, Jun 02, 2012 at 05:26:14PM +0100, Jonathan McCrohan wrote [edited]:
 reconf-inetd does not remove managed fragments when reconf-inetd itself is
 being purged. These fragments are, however, removed when reconf-inetd
 installed again.

Thanks for reporting this. If you have the time, please test whether a prerm
script that calls reconf-inetd, would solve the issue.

# cp /var/lib/dpkg/info/reconf-inetd.postinst 
/var/lib/dpkg/info/reconf-inetd.prerm

cheers,
sez



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#673600: RFS: nyancat/1.0+git20120519.5fe3de9-1

On Sat, Jun 02, 2012 at 05:27:30PM +, Jakub Wilk wrote [edited]:
[..]
 I would add -x/--line-regexp to the fgrep call.
 
 Wouldn't it be nice if the postinst also take care of the case when the 
 user enabled the service?

the line I'm suggesting in dep9 is:

if fgrep -q '^exact entry previously added by update-inetd$' 
/etc/inetd.conf \

which is not really concerned with whether the line is disabled or not. I
think both cases are valid for removal, as long as they have not been locally
modified (hence the '^...$' pattern).

-x is a fine suggestion.

thanks again to both of you.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#673600: RFS: nyancat/1.0+git20120519.5fe3de9-1

On Sat, Jun 02, 2012 at 07:03:33PM +, Jakub Wilk wrote:
 * Jonathan McCrohan jmccro...@gmail.com, 2012-06-02, 19:27:
 I would add -x/--line-regexp to the fgrep call.
 
 Wouldn't it be nice if the postinst also take care of the case when 
 the user enabled the service?
 
 Couldn't both of these issues be addressed by removing '#off# ' from 
 the grep?
 
 I think we do need -x (or an equivalent of it). If the user appended 
 some options to nyancat-server command-line, we must not remove such 
 entry.

agreed. I'd keep it simple and use two fgrep -x invocations; one with and
another without '#off# '

 BTW, shouldn't you use --pattern (instead of, or maybe in addition to, 
 --multi)?

--patern is not implemented for --remove. I guess I should add support for it.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#673600: RFS: nyancat/1.0+git20120519.5fe3de9-1