** Changed in: firefox (Ubuntu)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla
https://hg.mozilla.org/releases/mozilla-esr68/rev/0ac711f85da7
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Fix
Comment on attachment 9104623
Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno
Fixes a Linux-only WebRTC crash. Approved for 68.4esr.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #13)
> Looks like this grafts cleanly to ESR68 - did you want to nominate it for
> uplift?
Yes, let's do it.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Comment on attachment 9104623
Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno
### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR
consideration**: This fixes a crash that can easily occur when using WebRTC.
* **User impact if
There's quite a few crashes coming from ESR68 on Debian. The patch is
not large and low-risk, maybe we could uplift it. I'll see if it applies
cleanly there.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Hi Gabriele, is qa needed here? And if so, could you please provide us
some steps? Thanks!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
No testing is needed, thanks Catalin.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Fix Released
Status in
Looks like this grafts cleanly to ESR68 - did you want to nominate it
for uplift?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in
[Bugbug](https://github.com/mozilla/bugbug/) thinks this bug is a
regression, but please revert this change in case of error.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
** Changed in: firefox (Ubuntu)
Status: New => Fix Committed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
** Changed in: firefox
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Fix
https://hg.mozilla.org/mozilla-central/rev/59fb6760bb67
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Fix
Taking this as I've got a WIP patch. It just needs some good testing.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Pushed by gsve...@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59fb6760bb67
Use poll() instead of select() in WebRTC code r=drno
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Created attachment 9104623
Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno
The use of select() was leading to crashes when the file descriptor value was
larger than FD_SETSIZE. Recent versions of glibc have checks in the FD_CLR(),
FD_SET() and FD_ISSET() macros that will
** Bug watch added: Mozilla Bugzilla #1581193
https://bugzilla.mozilla.org/show_bug.cgi?id=1581193
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related
(In reply to Gabriele Svelto [:gsvelto] from comment #2)
> I did some further digging and this is happening all over the place but
> mostly in code we don't control. It's always `select()`'s fault though.
> Daniel, this code is different from upstream WebRTC (which is also using
> `select()`
(In reply to Dan Minor [:dminor] from comment #3)
> Hi Gabriele, this code is our local modification to webrtc.org that we have
> never merged upstream. As such, feel free to rewrite it to use poll() if that
> will fix things. I'm not the original author, I just happened to do the last
>
Launchpad has imported 3 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1590984.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
** Changed in: firefox (Ubuntu)
Importance: Undecided => High
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
Status in Mozilla Firefox:
Nevermind, this isn't WebRTC-specific and not even Ubuntu-specific since
I could find Debian instances of it. It's caused by select() being used
instead of more modern methods that don't have limits on the file
descriptor values you pass to them. Sorry for the noise.
--
You received this bug
** Also affects: firefox via
https://bugzilla.mozilla.org/show_bug.cgi?id=1590984
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
I did some further digging and this isn't a WebRTC-specific issue though
it tends to crash WebRTC code more often than other code.
See this for another similar crash in code we don't control (and which
might also be using select() and thus triggering the safety check):
Public bug reported:
In Mozilla we've detected a spike of crashes in the Ubuntu-packaged
version of Firefox 69.0.x. All the crashes are happening in the WebRTC
code and specifically libc's FD_SET, FD_CLR and FD_ISSET range-checking
safety is causing an abort. Is it possible that Firefox is being
Here's the relevant bug on our tracker:
https://bugzilla.mozilla.org/show_bug.cgi?id=1590984
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1849615
Title:
WebRTC-related crashes
26 matches
Mail list logo
