[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-09 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132247035 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java --- @@ -77,12 +81,12 @@ * Generates a trace

[GitHub] accumulo issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based...

2017-08-09 Thread glitch
Github user glitch commented on the issue: https://github.com/apache/accumulo/pull/289 Ok a brief update. For the transitive dependencies, this is what adding jersey-bean-validation brings along based on `mvn dependency:tree` [INFO] +-

[GitHub] accumulo issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based...

2017-08-09 Thread milleruntime
Github user milleruntime commented on the issue: https://github.com/apache/accumulo/pull/289 > @milleruntime What's your feeling on using javax.validation.constraints right in the method signature? I am on the fence with using external validation. One one hand, it doesn't

[GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...

2017-08-09 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/289#discussion_r132199113 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java --- @@ -77,12 +81,12 @@ * Generates a