[GitHub] activemq-artemis pull request #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: AddressSize show a negative number. Why?

2016-09-21 Thread Clebert Suconic
would need a way to replicate the issue. or more information on how you got into that. On Wed, Sep 21, 2016 at 5:07 PM, Fabio Gomes dos Santos wrote: > Does the anyone know why the AddressSize shows a negative number on jmx? > > The queue as no message, but return this: > >

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/789 @hqstevenson are you getting notifications for these questions? either here or dev-list --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/789 @clebertsuconic agreed. This does look like an awesome idea though for end users trying to test with messaging systems. --- If your project is set up for it, you can reply to this

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/789 I guess this is intended for users to use on their tests? What was the intention, to refactor Artemis' testsuite, or to provide rules for users running their own tests?

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/789 I think it would also be good to have a clear explanation of why this approach is superior to the approach already adopted in the test-suite. Additional questions: 1.

[GitHub] activemq-artemis issue #787: ARTEMIS-743 Default the queue address to the qu...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/787 just to let you guys know.. I ran the testsuite and only got a few known failures. looks good. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/789 This looks a great idea... however.. there's no docs on how to use this. it would warrant a chapter on the user-docs.. and maybe examples on how to run tests

[GitHub] activemq-artemis pull request #789: ARTEMIS-737 - added JUnit rules for Arte...

2016-09-21 Thread hqstevenson
GitHub user hqstevenson opened a pull request: https://github.com/apache/activemq-artemis/pull/789 ARTEMIS-737 - added JUnit rules for Artemis servers and clients You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #784: ARTEMIS-740 Auto-reload diverts from bro...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

AddressSize show a negative number. Why?

2016-09-21 Thread Fabio Gomes dos Santos
Does the anyone know why the AddressSize shows a negative number on jmx? The queue as no message, but return this: ```NameValue TypeDisplay NameUpdate Interval Description AddressSize -3636362longAddressSize -1 N/A ``` -- Fábio Santos supergr...@gmail.com

[GitHub] activemq-artemis pull request #741: ARTEMIS-702 JMS 2 spec violation for rec...

2016-09-21 Thread jbertram
Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #783: Rename misleading divertBindingNotExists...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #785: Add missing @Overrides, flag as error in...

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #787: ARTEMIS-743 Default the queue address to the qu...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/787 I am happy with this. +1 for merge... Two small TODOS I would remove now.. but other than that good to merge... Will let @mtaylor also to comment on this. --- If

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79924952 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79924920 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/782 @mtaylor / @gemmellr This is now ready to merge... (tagging you guys since you both commented on this PR before) --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79900443 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79900532 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79899679 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ;

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79899253 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ;

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79898185 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/788#discussion_r79898051 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis --- @@ -105,6 +105,16 @@ if [ -z

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/788 ARTEMIS-732 loading wrong arch lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-732

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread Clebert Suconic
We can make any required changes. I don't think it was really intentional other than.. nobody extending it.. lets make it final ;) Once you have a PR / diff whatever I will take a look.. I want to make sure wildfly works.. I think Artemis should have as many Servers as possible integrated. If

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79863944 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -1290,10 +1291,7 @@ protected

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79863285 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79860213 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -1290,10 +1291,7 @@

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/787#discussion_r79860068 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java --- @@ -0,0 +1,242 @@ +/* + *

[GitHub] activemq-artemis pull request #786: ARTEMIS-742 = replication quorum broken

2016-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/786 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread John D. Ament
Yes, I believe we have a mostly working RA in TomEE now. The main change was something identified a while ago, the Resource Adapter class has to have an interface and be non-final. We were able to get that working for the most part in TomEE, where connection factories are injected from artemis.

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread Clebert Suconic
There's the artemis-ra where all the classes are. That artemis-ra is just for the packaging for the ra.xml Maybe we should move it somewhere else. Did you guys get to any code changes required? On Tue, Sep 20, 2016 at 6:58 PM, John D. Ament wrote: > Hey, > > Just

[GitHub] activemq-artemis pull request #787: ENTMQ-1844 Default the queue address to ...

2016-09-21 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/787 ENTMQ-1844 Default the queue address to the queue name https://issues.jboss.org/browse/ENTMQ-1844 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #786: ARTEMIS-742 = replication quorum broken

2016-09-21 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/786 ARTEMIS-742 = replication quorum broken https://issues.apache.org/jira/browse/ARTEMIS-742 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #785: Add missing @Overrides, flag as error in...

2016-09-21 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/785 Add missing @Overrides, flag as error in IDEs You can merge this pull request into a Git repository by running: $ git pull https://github.com/scop/activemq-artemis overrides

[GitHub] activemq-artemis pull request #784: ARTEMIS-740 Auto-reload diverts from bro...

2016-09-21 Thread scop
GitHub user scop opened a pull request: https://github.com/apache/activemq-artemis/pull/784 ARTEMIS-740 Auto-reload diverts from broker.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/scop/activemq-artemis divert-reload