[GitHub] activemq-artemis pull request #850: [ARTEMIS-802] Broker does not throw exce...

2016-10-18 Thread bayern39
GitHub user bayern39 opened a pull request: https://github.com/apache/activemq-artemis/pull/850 [ARTEMIS-802] Broker does not throw exception on divert with no name https://issues.apache.org/jira/browse/ARTEMIS-802 You can merge this pull request into a Git repository by running:

[GitHub] activemq-artemis issue #835: ARTEMIS-786 Store user's password in hash form ...

2016-10-18 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/835 ok, let me think about it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis issue #849: ARTEMIS-805 old JMS clients failing on new brok...

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/849 this commit would actually break stuff pretty badly. Even .artemis-distribution/src/test/scripts/validate-spaces.sh would be broken. --- If your project is set up for it,

[GitHub] activemq-artemis issue #849: ARTEMIS-805 old JMS clients failing on new brok...

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/849 @jbertram the failures showing at this build are real. I replicated the same issues through a local build. I would run the whole testsuite for such changes. --- If your

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

2016-10-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/849 ARTEMIS-805 old JMS clients failing on new broker Old JMS clients are getting a CCE related to SessionBindingQueryResponseMessage You can merge this pull request into a Git repository

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 sounds good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] activemq-artemis pull request #847: ARTEMIS-808 use privileges to stop execu...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/847 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #848: ARTEMIS-804 log ref when no DLA configur...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #835: ARTEMIS-786 Store user's password in hash form ...

2016-10-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/835 The whole masking/hashing process still seems like a bit of a jumble to me. To mask a password there's a raw Java command (e.g. "java -cp classPath>

[GitHub] activemq-artemis pull request #848: ARTEMIS-804 log ref when no DLA configur...

2016-10-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/848 ARTEMIS-804 log ref when no DLA configured You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-804

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Have to fix a bug introduced by refactoring. I think inner classes are looking better than an anonymous one. It might be better to add components to ProtocolTrackerCallBackImpl too make it

[GitHub] activemq-artemis issue #847: ARTEMIS-808 use privileges to stop executor

2016-10-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/847 @jmesnil, is this what you're looking for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis pull request #847: ARTEMIS-808 use privileges to stop execu...

2016-10-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/847 ARTEMIS-808 use privileges to stop executor You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-808

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben I understand it works now. I was just trying to be more generic on the implementation and support future needs. --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 A bit more this way? IMO I did not see why to change the method to addDataSource. It could be only one and this one is a dependency which is mandatory for broker startup. --- If your

Temporary Branch for ARTEMIS-780

2016-10-18 Thread Martyn Taylor
All, I'm starting to look at the improvements around the addressing model (ARTEMIS-780) there's going to be a fair amount of change involved that may break certain parts of the broker (at least until it's fully completed). For this reason, I've created a separate branch "ARTEMIS-780" to house

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/839#discussion_r83920395 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/storage/FileStorageConfiguration.java --- @@ -29,7 +29,7 @@

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/839#discussion_r83920218 --- Diff: artemis-server-osgi/src/main/java/org/apache/activemq/artemis/osgi/ProtocolTrackerCallBack.java --- @@ -25,4 +25,6 @@

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Rebase is done :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben can you rebase against master... and push -f at least? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 let me think about the class name... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/839 Well, I think it must be the same callback to avoid the protocol tracker to start the broker if the datasource is not bounded yet. It's just another "mandatory" dependency. I might rename

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

2016-10-18 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/839 @graben ^^^ (<<< just to send you a notification) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis pull request #846: [ARTEMIS-803] Fix colocated backups with...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/846 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #846: [ARTEMIS-803] Fix colocated backups with...

2016-10-18 Thread jmesnil
GitHub user jmesnil opened a pull request: https://github.com/apache/activemq-artemis/pull/846 [ARTEMIS-803] Fix colocated backups with http-upgrade acceptor * Do not offset ports for Netty connector/acceptor with http-upgrade enabled. * Pass the name of the ActiveMQ server

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

2016-10-18 Thread barreiro
Github user barreiro commented on the issue: https://github.com/apache/activemq-artemis/pull/548 Rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] activemq-artemis issue #845: ARTEMIS-801 Decode URL paths

2016-10-18 Thread dudaerich
Github user dudaerich commented on the issue: https://github.com/apache/activemq-artemis/pull/845 Hi @clebertsuconic my intention here was to fix tests which fail in our CI. The path to project directory contains '&' characters. Example of path: ```