[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1789 ---

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1781 ---

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162492929 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1781#discussion_r162491865 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java --- @@ -557,6 +592,25 @@ public Object

Re: [DISCUSS] Adding Derby as a dependency

Actually, I will keep this as is.. .the user should decide what driver to use... I will keep configurations by default as derby (if the user doesn't provide anything else on the CLI).. but that's just for easy of use. On Thu, Jan 18, 2018 at 5:18 PM, Clebert Suconic

Re: [DISCUSS] Adding Derby as a dependency

thanks.. it's all good... Actually I think not having the dependency on the main lib was a good outcome anyways... I could make a further change.. to programmatically download derby if the user allows it. On Thu, Jan 18, 2018 at 5:02 PM, Michael André Pearce

[GitHub] activemq-artemis pull request #1790: ARTEMIS-1606 - Change AddressInfo Routi...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1790 ---

[GitHub] activemq-artemis issue #1790: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1790 Looks like master is broken since merge of https://github.com/apache/activemq-artemis/pull/1742 thus your PR build failed, this fix though looks fine, i have run it manually

Re: [DISCUSS] Adding Derby as a dependency

Just for the record I gave an opinion in a discussion, I have not given a -1. I’m not veto or blocking anything. In actual fact as I said I’m for this I think it’s good. just I think as a community we should have some clear guidelines agreed of what goes in and what stays out, and how some

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1781#discussion_r162479786 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java --- @@ -557,6 +592,25 @@ public Object

Re: [DISCUSS] Rework NMS.AMQP

On 01/17/2018 03:50 PM, cmorgan wrote: Hi Everyone, Happy New Year. I have a progress update about the NMS AMQP API Rework. The work done in the fork, https://github.com/cjwmorgan-sol-sys/nms-amqp, is close to being finished. Duane and I have also signed the ICLA. I will follow what Tim

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473338 --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java --- @@ -557,6 +592,25 @@ public Object

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473145 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java --- @@ -423,8 +423,8 @@

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1781#discussion_r162472842 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/database-store.txt --- @@ -0,0 +1,18 @@ + +

Re: [DISCUSS] Adding Derby as a dependency

so, after my last update, When you create a server with the --jdbc option example: ./artemis create /tmp/myserver --jdbc the CLI will still help the user to configure the server... but instead of having the dependency ready, it will give you the following message:

[GitHub] activemq-artemis issue #1790: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1790 @michaelandrepearce The past PR has broken just this test: this is fixing it :+1: ---

[GitHub] activemq-artemis pull request #1790: ARTEMIS-1606 - Change AddressInfo Routi...

GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1790 ARTEMIS-1606 - Change AddressInfo RoutingType Set to use EnumSet This is fixing the broken testUnsupportedRoutingType test You can merge this pull request into a Git repository by

Re: [DISCUSS] Adding Derby as a dependency

I will remove the dependency to avoid confusion. The database example will download the derby driver and install it on the lib. I will also add a message during the broker creation telling the user to copy the driver in the right place. On Thu, Jan 18, 2018 at 1:44 PM Timothy Bish

Re: [DISCUSS] Adding Derby as a dependency

Agree with Robbie on this.  My view from the previous discussion on the Kafka bridge is that is would be a third party project that could be used by anyone that wished to have it but that it does not need to be (or should be) included with the broker either in the repo or the distribution. 

Re: [DISCUSS] Adding Derby as a dependency

On Thu, Jan 18, 2018 at 1:12 PM, Arthur Naseef wrote: > On the providing core persistence - that is core to Artemis, and Artemis > provides a reasonable solution to that problem out-of-the-box. There are > dozens, if not hundreds, or alternatives we could add as near-storage. >

[GitHub] activemq-artemis pull request #1742: ARTEMIS-1570 Flush appendExecutor befor...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1742 ---

Re: [DISCUSS] Adding Derby as a dependency

If I'm understanding the discussion well enough (apologies, TLDR) - one concern with adding this directly into core Artemis is ending up with too much complexity baked into the main product. Also, Mixing Concerns (i.e. reduced "separation of concerns"). Having a downstream project that

Re: [DISCUSS] Adding Derby as a dependency

Clebert, I was looking for a +1 from Mike. My understanding is that a -1 from a committer (or is it just PMC?) is a veto [1], and I felt that was Mike's position. I think your PR is a good one and I'd like to merge it ASAP. Anybody feel free to correct me if I'm wrong on the veto thing.

[GitHub] activemq-artemis pull request #1742: ARTEMIS-1570 Flush appendExecutor befor...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1742#discussion_r162421523 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/replication/SharedNothingReplicationTest.java

[GitHub] activemq-artemis issue #1742: ARTEMIS-1570 Flush appendExecutor before take ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1742 do you want to contribute more? I can help you in any way you need. ---

[GitHub] activemq-artemis issue #1742: ARTEMIS-1570 Flush appendExecutor before take ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1742 nice job on this one!!! impressed!!! ---

Re: [DISCUSS] Adding Derby as a dependency

I can't speak for others on the previous thread, but the below was not my position in that prior discussion at all. I don't think the proposed kafka bridge component should be bundled in the broker repo or distribution, regardless where else the code lives, but that it should instead have its own

[GitHub] activemq-artemis pull request #1742: ARTEMIS-1570 Flush appendExecutor befor...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1742#discussion_r162418130 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/replication/SharedNothingReplicationTest.java

Re: [DISCUSS] Adding Derby as a dependency

On Thu, Jan 18, 2018 at 11:47 AM, Justin Bertram wrote: > I don't see any contradictions or inequities here. I'd like to confirm a > +1 from you before I merge. Let me know what you think. I'm not sure if you asked a +1 from me or Michael.. but that's exactly what I

Re: [DISCUSS] Adding Derby as a dependency

> ...if I made the connector implementation code available in maven central will have it hosted in GitHub the source, then we’d be happy to have that packaged in to provide the functionality? Obviously I can only speak for myself here, but that's how I understood the previous discussion. Justin

Re: [DISCUSS] Adding Derby as a dependency

Ok so if I understood this if I made the connector implementation code available in maven central will have it hosted in GitHub the source, then we’d be happy to have that packaged in to provide the functionality? If that’s the case im +1 with this, and then I’ll work on doing that for the

Re: [DISCUSS] Adding Derby as a dependency

I just reviewed your PR, Clebert, and made a comment. In general I think it looks great. Nice work. I've been thinking about your concern, Michael, that the rules on integrations like this aren't clear. I went back and reviewed the mailing list discussion and the discussion on your PR for the

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162393664 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162392727 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10

[GitHub] activemq-artemis pull request #1783: ARTEMIS-1611 Added support for 1.x tran...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1783#discussion_r162391229 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/ServerMessageImpl.java --- @@ -0,0 +1,190 @@

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162390676 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162390344 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1789#discussion_r162390192 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/StompPluginTest.java --- @@ -127,10

[GitHub] activemq-artemis pull request #1783: ARTEMIS-1611 Added support for 1.x tran...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1783#discussion_r162389643 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/ServerMessageImpl.java --- @@ -0,0 +1,190 @@

[GitHub] activemq-artemis issue #1781: ARTEMIS-1613 Integrating JDBC into CLI (create...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1781 I think it's worth clarifying the specific purpose of Derby in the documentation. My understanding here is that Derby is being packaged for demonstration purposes only and shouldn't be

[GitHub] activemq-artemis pull request #1789: ARTEMIS-1619 - Add plugin support for a...

GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1789 ARTEMIS-1619 - Add plugin support for address lifecyle Adding callbacks to the plugin API for address creation, update and removals You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1787 ---

[GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ...

Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1787#discussion_r162367328 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -1284,7 +1284,7 @@

[GitHub] activemq-artemis issue #1787: ARTEMIS-1577 Address-settings policies not wor...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1787 +1 I’m happy as noted I can pr some bits later ---

[GitHub] activemq-artemis issue #1788: ARTEMIS-1617 - Properly set autoCreated flag o...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1788 Nice work, @cshannon. ---

[GitHub] activemq-artemis pull request #1788: ARTEMIS-1617 - Properly set autoCreated...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1788 ---

[GitHub] activemq-artemis pull request #1771: ARTEMIS-1600 Support masked passwords i...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1771 ---

[GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1787#discussion_r162358705 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -1284,7 +1284,7 @@

[GitHub] activemq-artemis issue #1783: ARTEMIS-1611 Added support for 1.x transformer...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1783 @jmesnil Made the changes you suggested. @clebertsuconic I agree with @jmesnil that adding back the original types is the clearest and safest thing to do, with the disadvantage of add

[GitHub] activemq-artemis pull request #1783: ARTEMIS-1611 Added support for 1.x tran...

Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1783#discussion_r162356443 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/ServerMessageImpl.java --- @@ -0,0 +1,192 @@ +/*

[GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1787#discussion_r162353710 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -736,11 +736,11 @@

[GitHub] activemq-artemis pull request #1787: ARTEMIS-1577 Address-settings policies ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1787#discussion_r162353815 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -736,11 +736,11 @@

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1775#discussion_r162352945 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -2790,6 +2790,14 @@

[GitHub] activemq-artemis issue #1775: ARTEMIS-1587 Add setting to control the queue ...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1775 Sorry guys but I am -1 on this. I thought the idea of this was to behave in a similar way to default-max-consumers, or default-purge-on-no-consumers. I am not happy about overriding the

[GitHub] activemq-artemis pull request #1788: ARTEMIS-1617 - Properly set autoCreated...

GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1788 ARTEMIS-1617 - Properly set autoCreated flag on address Flag needs to be set when auto creating an address so that the address can be removed later if auto delete is configured when

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1775#discussion_r162343251 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -2790,6 +2790,14 @@

[GitHub] activemq-artemis pull request #1777: ARTEMIS-1606 - Change AddressInfo Routi...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1777 ---

[GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 Great thanks, ill merge then. ---

[GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 These are the flamegraph of a couple of profiled tests, one on master: 

[GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 @michaelandrepearce I'm running a test before and after, but first can you try add ".jvmArgs("-XX:+UseG1GC")" and `.forks(2)` to your benchmark? ---

[GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 @franz1981 i was waiting on you, to give a thumbs up before i merged, is that a thumbs up? ---

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162272711 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int hashCode()

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162272578 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int hashCode()

[GitHub] activemq-artemis issue #1777: ARTEMIS-1606 - Change AddressInfo RoutingType ...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1777 Very good results! A lil OT but seems that we really start need a JMH folder with all the benchs on Artemis eh? :P ---