[GitHub] activemq-artemis pull request #2154: ARTEMIS-1948 dotnet example with high p...

2018-06-20 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2154 ARTEMIS-1948 dotnet example with high performant load You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2153: ARTEMIS-1947 return metadata in JSON se...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2153 ---

[GitHub] activemq-artemis issue #2153: ARTEMIS-1947 return metadata in JSON session m...

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2153 Looks good to me BTW. Feel free to merge it yourself. Or I can do it in 2 hours. ---

[GitHub] activemq-artemis issue #2153: ARTEMIS-1947 return metadata in JSON session m...

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2153 I have been just git cherry picking and pushing it directly. ---

[GitHub] activemq-artemis issue #2153: ARTEMIS-1947 return metadata in JSON session m...

2018-06-20 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2153 Yes, I think this would be suitable for 2.6.x. I'll send a PR. ---

[GitHub] activemq-artemis issue #2153: ARTEMIS-1947 return metadata in JSON session m...

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2153 nice one! now that we revert that other feature in 2.6.x.. isn't this suitable for 2.6.x? ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 > with heart beats.. you won't this test.. as ping/pongs will disconnect the client. The idle-timeout stuff defaults to killing after 60 seconds, which the test doesnt even

[GitHub] activemq-artemis pull request #2153: ARTEMIS-1947 return metadata in JSON se...

2018-06-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2153 ARTEMIS-1947 return metadata in JSON session mgmnt ops You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 It's pointless to argue anyway.. it's just a test and it's working as expected... I need to move to a different task ;) ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 with heart beats.. you won't this test.. as ping/pongs will disconnect the client. Disabling heart beats and still solving issues it's all that this fix was about and the

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 Yes, after a connection-reset-by-peer error which meant the broker knew the connection had gone, which it knew regardless of whether idle-timeout handling was enabled or not, but failed

[GitHub] activemq-artemis pull request #2152: ARTEMIS-1924 small tweaks on HeartBeat ...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2152 ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 @gemmellr the issue i was dealing with was a .NET client in windows not cleaning up after a disconnect, after I created the feature. So.. this is definitely related. We can create

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 To me it seemed more about cleaning up the client regardless of idle-timeout, and that it should do exactly the same if idle-timeout handling is enabled or if it wasn't using AMQP at

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 @gemmellr that I disagree with.. this is about no heart beat.. and disconnecting the client. ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 (I still don't think it should be in that class though per #2149 comments...but the test itself looks good now) ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 @gemmellr thanks.. I will merge it then ---

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 Looks good ---

[GitHub] activemq-artemis pull request #2152: ARTEMIS-1924 small tweaks on HeartBeat ...

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2152#discussion_r196822722 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@

[GitHub] activemq-artemis pull request #2152: ARTEMIS-1924 small tweaks on HeartBeat ...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2152#discussion_r196818582 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -137,18

[GitHub] activemq-artemis pull request #2151: ARTEMIS-1945 InVMNodeManager shared sta...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2151 ---

[GitHub] activemq-artemis pull request #2150: [ARTEMIS-1944] Typo mistake in broker.x...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2150 ---

[GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2149#discussion_r196814636 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -80,4 +88,68

[GitHub] activemq-artemis issue #2152: ARTEMIS-1924 small tweaks on HeartBeat test

2018-06-20 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2152 @gemmellr / @mtaylor can you review this? ---

[GitHub] activemq-artemis pull request #2152: ARTEMIS-1924 small tweaks on HeartBeat ...

2018-06-20 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2152 ARTEMIS-1924 small tweaks on HeartBeat test You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

Re: post-release updates of Artemis download pages

2018-06-20 Thread Robbie Gemmell
As I said some links just weren't updated to reflect the newer checksum distribution policy, but most were broken from pointing at the wrong download area/server and using the query arguments that aren't used there. That suggested the content was copied unchanged from download.html into

[GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726608 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -80,4 +88,68

[GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726336 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -80,4 +88,68

[GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2149#discussion_r196726944 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -80,4 +88,68

[GitHub] activemq-artemis pull request #2149: ARTEMIS-1924 Test consumer cleanup afte...

2018-06-20 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2149#discussion_r196724509 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java --- @@ -80,4 +88,68

[GitHub] activemq-artemis issue #2151: ARTEMIS-1945 InVMNodeManager shared state shou...

2018-06-20 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2151 Reproducing it is dependent by how the JIT will choose to optimize the code, that's why there isn't any tests on it. I can try to build one, but probably it will take seme time (to be

[GitHub] activemq-artemis pull request #2151: ARTEMIS-1945 InVMNodeManager shared sta...

2018-06-20 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2151 ARTEMIS-1945 InVMNodeManager shared state should be volatile State access should be atomic to be visibile between different threads. You can merge this pull request into a Git

[GitHub] activemq-artemis issue #2143: ARTEMIS-1547 - replace properties removed in e...

2018-06-20 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2143 For anyone else wondering later, the other JIRA appears to be https://issues.apache.org/jira/browse/ARTEMIS-1942 ---

[GitHub] activemq-artemis pull request #2150: [ARTEMIS-1944] Typo mistake in broker.x...

2018-06-20 Thread vkamble60
GitHub user vkamble60 opened a pull request: https://github.com/apache/activemq-artemis/pull/2150 [ARTEMIS-1944] Typo mistake in broker.xml at journal-buffer-timeout explanation jira :- https://issues.apache.org/jira/browse/ARTEMIS-1944 You can merge this pull request into a Git