Re: post-release updates of Artemis download pages

2018-07-12 Thread Clebert Suconic
that brings one subject to discuss... 2.6.1, 2.6.2 ... 2.6.x should all share the same documentation on 2.6.x... changes in doc on this branch should be only minor changes.. and any change here should be valid for any of the releases. As of now.. i will just update the link to avoid an invalid

Re: post-release updates of Artemis download pages

2018-07-12 Thread Robbie Gemmell
As Tim says it is still broken, I didn't change anything since my mail earlier. On 12 July 2018 at 21:29, Timothy Bish wrote: > On 07/12/2018 04:08 PM, Clebert Suconic wrote: >> >> @Robbie thanks for fixing it.. just came into it and realized you >> already did it.. thanks > > > Documentation

Re: post-release updates of Artemis download pages

2018-07-12 Thread Timothy Bish
On 07/12/2018 04:08 PM, Clebert Suconic wrote: @Robbie thanks for fixing it.. just came into it and realized you already did it.. thanks Documentation link for 2.6.1 on this page is still broken for me: http://activemq.apache.org/artemis/past-releases.html On Thu, Jul 12, 2018 at 10:09 AM,

Re: post-release updates of Artemis download pages

2018-07-12 Thread Clebert Suconic
as for previous docs.. I don't see a point to update the docs for 2.6.0 and 2.6.1.. as they are current.. we can add it when we move into 2.7.0... that's my plan at least. On Thu, Jul 12, 2018 at 10:09 AM, Robbie Gemmell wrote: > The 2.6.1 docs link at >

Re: post-release updates of Artemis download pages

2018-07-12 Thread Clebert Suconic
@Robbie thanks for fixing it.. just came into it and realized you already did it.. thanks On Thu, Jul 12, 2018 at 10:09 AM, Robbie Gemmell wrote: > The 2.6.1 docs link at > http://activemq.apache.org/artemis/past-releases.html is broken. The > link itself seems fine this time and the other 2.6.1

[GitHub] activemq-artemis pull request #2163: ARTEMIS-1956 move MessageCounterInfo to...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2163 ---

[GitHub] activemq-artemis pull request #2162: ARTEMIS-1954 eliminate all possible usa...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2162 ---

[GitHub] activemq-artemis issue #2162: ARTEMIS-1954 eliminate all possible usage of J...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2162 nice one @jbertram ---

[GitHub] activemq-artemis pull request #2166: [ARTEMIS-1958] Artemis may not be able ...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2166 ---

[GitHub] activemq-artemis issue #2166: [ARTEMIS-1958] Artemis may not be able to dele...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2166 @morefuntang are you sure you want your commit authored as 17103355 <17103...@cnsuning.com> ? ---

[GitHub] activemq-artemis pull request #2171: ARTEMIS-1966 Replication channel closed...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2171 ---

[GitHub] activemq-artemis issue #2171: ARTEMIS-1966 Replication channel closed but no...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2171 Thanks... I'm also adding a commit to improve the test you added. Take a look please for future references. (I decided to just change it instead of asking the change here).

[GitHub] activemq-artemis pull request #2176: ARTEMIS-1974 document LDAP role expansi...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2176 ---

[GitHub] activemq-artemis pull request #2182: ARTEMIS-1981 JDBCJournalImpl constructo...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2182 ---

[GitHub] activemq-artemis pull request #2182: ARTEMIS-1981 JDBCJournalImpl constructo...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2182#discussion_r202102353 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java --- @@ -94,7 +94,6 @@

Re: post-release updates of Artemis download pages

2018-07-12 Thread Clebert Suconic
I will fix this in today's afternoon sorry about that. (I have been away for 2 weeks and just getting back to work) On Thu, Jul 12, 2018 at 10:09 AM, Robbie Gemmell wrote: > The 2.6.1 docs link at > http://activemq.apache.org/artemis/past-releases.html is broken. The > link itself seems

[GitHub] activemq-artemis pull request #2179: NO-JIRAs

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2179 ---

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r202058086 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11

Re: post-release updates of Artemis download pages

2018-07-12 Thread Robbie Gemmell
The 2.6.1 docs link at http://activemq.apache.org/artemis/past-releases.html is broken. The link itself seems fine this time and the other 2.6.1 links work, there just dont seem to be any 2.6.1 docs. The 2.6.0 and 2.6.1 releases aren't mentioned on

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r202046654 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11 @@

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r202041562 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r202040381 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11 @@

[GitHub] activemq-artemis pull request #2180: ARTEMIS-1979 Table names with DB2 shoul...

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2180 ---

[GitHub] activemq-artemis issue #2182: ARTEMIS-1981 JDBCJournalImpl constructor isn't...

2018-07-12 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2182 @clebertsuconic This one is purely gardening while I was fixing other things on jdbc: if is fine I will left it here or I can close it too, if isn't worthing a whole PR ---

[GitHub] activemq-artemis pull request #2182: ARTEMIS-1981 JDBCJournalImpl constructo...

2018-07-12 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2182 ARTEMIS-1981 JDBCJournalImpl constructor isn't using tableName parameter Removed the unused/redundant constructor parameter tableName You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r202032181 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-07-12 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2181 ARTEMIS-1980 Warn on failed check of table existence should be info DB2 metadata checks should erroneously report stale table existence on not existing/just deleted table, making

[GitHub] activemq-artemis pull request #2180: ARTEMIS-1979 Table names with DB2 shoul...

2018-07-12 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2180 ARTEMIS-1979 Table names with DB2 should be upper-cases DB2 JDBC driver fail to retrieve metadata information if table names are lower-cases: similarly to Oracle, better force