gaohoward commented on issue #2534: ARTEMIS-1058 Jars in web tmp dir locked on
Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459631440
@clebertsuconic I'm not aware of the "encoded" issue, where can I get more
information about it?
The first commit is
clebertsuconic commented on issue #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459602236
I believe there is an issue with the original commit with encoded strings.
I believe you should use a file and some
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252921461
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252920340
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252920340
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252920340
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252920340
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252920340
##
File path:
gaohoward edited a comment on issue #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459588365
@clebertsuconic The commit ae00423 was valid. However on Windows when
running artemis as a service, stopping the
gaohoward commented on issue #2534: ARTEMIS-1058 Jars in web tmp dir locked on
Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459588365
@clebertsuconic The commit ae00423 was valid. However on Windows when
running artemis as a service, stopping the
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should
close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-459587945
@michaelandrepearce thanks to your review, I will address the comments.
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252919168
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252918453
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252918661
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252918453
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252918453
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252917956
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252917296
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252917296
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252916808
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252916780
##
File path:
michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-459583628
@onlyMIT to help with addressing the comments i sent a pr to your branch
with a number of
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252915920
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252915302
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252915242
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252914838
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252914292
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252914292
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252912679
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252912679
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252912679
##
File path:
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252910278
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252899919
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252899919
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252898402
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252891076
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252898402
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252898402
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252897572
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252896834
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252897572
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252896834
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252896834
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252893830
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252893793
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892706
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252892610
##
File path:
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252891076
##
File path:
yep, so far the best name is ActiveMQ-Artemis-native
I don't think this is a big deal and I don't intend to create a vote
for this.. as this is regular business. We are creating a separate
repository for the native part, not a project!
Let me know If you anyone think I'm wrong and this needs a
That makes sense then - having a separate repo and release cycle for the
native JNI library.
Perhaps, as Jeff suggested, ActiveMQ-Artemis-native would be a good name?
Art
On Thu, Jan 31, 2019 at 10:04 AM Clebert Suconic
wrote:
> forgot to answer another point.
>
> Right now it's for posix
asfgit merged pull request #2535: NO-JIRA update docs for gitbox
URL: https://github.com/apache/activemq-artemis/pull/2535
This is an automated message from the Apache Git Service.
To respond to the message, please log on
forgot to answer another point.
Right now it's for posix (Linux) only. but that could change as the
project progresses.
On Thu, Jan 31, 2019 at 11:51 AM Clebert Suconic
wrote:
>
> -- If the library is intended as a holder for "any JNI needed by Artemis,"
> then I don't see value in
-- If the library is intended as a holder for "any JNI needed by Artemis,"
then I don't see value in dis-associating it from Artemis. OTOH, if the
library has functionality that could be useful to other projects, outside
of Artemis, then I can see a value to breaking it away from the Artemis
name
jbertram opened a new pull request #2535: NO-JIRA update docs for gitbox
URL: https://github.com/apache/activemq-artemis/pull/2535
This is an automated message from the Apache Git Service.
To respond to the message, please
clebertsuconic commented on a change in pull request #2534: ARTEMIS-1058 Jars
in web tmp dir locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#discussion_r252722752
##
File path:
clebertsuconic commented on issue #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534#issuecomment-459394318
The problem is only on windows service?
On this case, we could revert ae00423034b6905564f6729f681dc8e29c86422e
+1
I have a slight nit-pick. The Wiki page [1] refers to the old git-wip-us
URL [2]. This URL *will* properly redirect to gitbox, but git itself will
display a warning about the redirect so it would be nice to use the gitbox
URL.
Justin
[1]
gaohoward opened a new pull request #2534: ARTEMIS-1058 Jars in web tmp dir
locked on Windows
URL: https://github.com/apache/activemq-artemis/pull/2534
This is the second commit. It improves the windows service
configuration file so that the service can be shutdown
gracefully (clean
TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate
after shared store is reconnected
URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-459300835
Fixed missing license.
This is an
I also think the code should destroy the mutex (by calling
pthread_mutext_destroy) as part of the cleanup on failure, but I did not
include it on PR #2530.
On Thu, Jan 31, 2019 at 5:54 AM Clebert Suconic
wrote:
> That is correct. The JVM will die upon critical failures.
>
>
> We should address
CNNJYB opened a new pull request #2533: ARTEMIS-2244 checkDepage method placed
outside CRITICAL_DELIVER avoid critical analyzer timeout
URL: https://github.com/apache/activemq-artemis/pull/2533
We found server crash becauseof critical analyzer timeout, thread dump can
be seen in
73 matches
Mail list logo
