[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463096446 Okay great! You are correct regarding a header for when a group is assigned to a consumer. That's the

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463095530 So yes i think if you find a way to elegantly achieve that without a performance impact i personally would be open to

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463094268 @michaelandrepearce no worries. I really appreciate all the work you guys are doing and just wanted to check whether

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you want.

[GitHub] billpoole-mi edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
billpoole-mi edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is a cooperation

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is cooperation between

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

2019-02-12 Thread GitBox
billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463025385 I have a couple of questions regarding the "support rebalancing groups when a consumer is added" aspect of this change:

[GitHub] qihongxu opened a new pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed

2019-02-12 Thread GitBox
qihongxu opened a new pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed URL: https://github.com/apache/activemq-artemis/pull/2549 When deleting large messages, artemis will use storePendingLargeMessage to insert a temporary record in journal for

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255985412 ## File path:

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255983228 ## File path:

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255960926 ## File path:

[GitHub] franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-02-12 Thread GitBox
franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462741716 This one should be kinda independent from the rest so can be merged without worrying about any conflicts, thanks!!!

[GitHub] michaelandrepearce commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462732912 Looking promising. @franz1981 with all the changes youve been working on for journals, im not sure what the merge

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255920956 ## File path:

[GitHub] michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-462731246 @onlyMIT looking better, i have some questions, which im sure all makes sense if explained,

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255918235 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255916966 ## File path:

[GitHub] onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

2019-02-12 Thread GitBox
onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-462671664 @michaelandrepearce move logic to SESSION_CREATE notification