[GitHub] activemq-artemis pull request #2336: ARTEMIS-1874 fix NPE setting object pro...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2336 ---

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-09-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r221341953 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-09-28 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r221341393 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-28 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221293865 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java --- @@ -41,4

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-09-28 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r221229493 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221189768 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java --- @@ -41,4 +41,13 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-28 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221191158 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java --- @@ -577,26 +587,62 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-27 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221139457 --- Diff: artemis-core-client/src/main/resources/activemq-version.properties --- @@ -20,4 +20,4 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-27 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221086337 --- Diff: artemis-core-client/src/main/resources/activemq-version.properties --- @@ -20,4 +20,4 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2187 ---

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-27 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221082377 --- Diff: artemis-core-client/src/main/resources/activemq-version.properties --- @@ -20,4 +20,4 @@

[GitHub] activemq-artemis pull request #2187: ARTEMIS-1545 Support JMS 2.0 Completion...

2018-09-27 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2187#discussion_r221079593 --- Diff: artemis-core-client/src/main/resources/activemq-version.properties --- @@ -20,4 +20,4 @@

[GitHub] activemq-artemis pull request #2337: ARTEMIS-1894 Avoiding apache.org URL on...

2018-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2337 ---

[GitHub] activemq-artemis pull request #2337: ARTEMIS-1894 Avoiding apache.org URL on...

2018-09-27 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2337 ARTEMIS-1894 Avoiding apache.org URL on codebase You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2334: ARTEMIS-2098 potential NPE when decodin...

2018-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2334 ---

[GitHub] activemq-artemis pull request #2336: ARTEMIS-1874 fix NPE setting object pro...

2018-09-27 Thread rpelisse
GitHub user rpelisse opened a pull request: https://github.com/apache/activemq-artemis/pull/2336 ARTEMIS-1874 fix NPE setting object property Upstream Issue: https://issues.apache.org/jira/browse/ARTEMIS-1874 Issue: https://issues.jboss.org/browse/JBEAP-15516 No upstream PR

[GitHub] activemq-artemis pull request #:

2018-09-26 Thread jbertram
Github user jbertram commented on the pull request: https://github.com/apache/activemq-artemis/commit/8ab3be71a3ebc5667c402c2b6e6458cb73bce616#commitcomment-30665944 @michaelandrepearce, I already cherry-picked it to 2.6.x. ---

[GitHub] activemq-artemis pull request #:

2018-09-26 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/8ab3be71a3ebc5667c402c2b6e6458cb73bce616#commitcomment-30665922 @jbertram will you cherry pick, or you want me to raise a second pr with cherry? ---

[GitHub] activemq-artemis pull request #2335: NO-JIRA Avoid possible double instantia...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2335 ---

[GitHub] activemq-artemis pull request #2335: NO-JIRA Avoid possible double instantia...

2018-09-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2335#discussion_r220723361 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -551,12 +551,16 @@

[GitHub] activemq-artemis pull request #2250: ARTEMIS-1996 MappedSequentialFileFactor...

2018-09-26 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2250#discussion_r220720824 --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java --- @@ -1796,15 +1826,15 @@ private

[GitHub] activemq-artemis pull request #2335: NO-JIRA Avoid possible double instantia...

2018-09-26 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2335#discussion_r220716297 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -551,12 +551,16 @@ public

[GitHub] activemq-artemis pull request #2335: NO-JIRA Avoid possible double instantia...

2018-09-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2335 NO-JIRA Avoid possible double instantiation of properties You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2334: ARTEMIS-2098 potential NPE when decodin...

2018-09-26 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2334#discussion_r220700987 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java --- @@ -196,6 +196,10 @@ protected void

[GitHub] activemq-artemis pull request #2250: ARTEMIS-1996 MappedSequentialFileFactor...

2018-09-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2250#discussion_r220699668 --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java --- @@ -1796,15 +1826,15 @@

[GitHub] activemq-artemis pull request #2334: ARTEMIS-2098 potential NPE when decodin...

2018-09-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2334#discussion_r220697913 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java --- @@ -196,6 +196,10 @@

[GitHub] activemq-artemis pull request #2333: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-26 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2333 ---

[GitHub] activemq-artemis pull request #2334: ARTEMIS-2098 potential NPE when decodin...

2018-09-26 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2334 ARTEMIS-2098 potential NPE when decoding protocol You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2331: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2331 ---

[GitHub] activemq-artemis pull request #2332: ARTEMIS-2094 - Fix Configuration change...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2332 ---

[GitHub] activemq-artemis pull request #2333: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2333 ARTEMIS-2095 - Typed Properties ThreadSafety (cherry picked from commit 8e40b2d) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2332: ARTEMIS-2094 - Fix Configuration change...

2018-09-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2332 ARTEMIS-2094 - Fix Configuration change loss when network Issue (cherry picked from commit cce0e19) You can merge this pull request into a Git repository by running: $

[GitHub] activemq-artemis pull request #2329: ARTEMIS-2096 Refactor AMQMessage abstra...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2329 ---

[GitHub] activemq-artemis pull request #2326: ARTEMIS-2094 - Configuration change los...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2326 ---

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2330 ---

[GitHub] activemq-artemis pull request #2331: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-26 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2331 ARTEMIS-2095 - Typed Properties ThreadSafety Add Concurrency Test to expose concurrency errors seen in logs. Add Fix to ensure TypedProperties to ensure threadsafety

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2328 ---

[GitHub] activemq-artemis pull request #2172: ARTEMIS-1961 track routed and unrouted ...

2018-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2172 ---

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220369450 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -68,22 +73,23 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220369406 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...

2018-09-25 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2330#discussion_r220325428 --- Diff: examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/management.xml --- @@ -21,9 +21,9 @@

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...

2018-09-25 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2330#discussion_r220322866 --- Diff: examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/management.xml --- @@ -21,9 +21,9 @@

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...

2018-09-25 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2330#discussion_r220322689 --- Diff: examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/management.xml --- @@ -21,9 +21,9 @@

[GitHub] activemq-artemis pull request #2330: ARTEMIS-2087 fix NPE; mask password in ...

2018-09-25 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2330 ARTEMIS-2087 fix NPE; mask password in example You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220281173 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220276768 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220276492 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220276439 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220273724 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220273130 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -68,22 +73,23 @@

[GitHub] activemq-artemis pull request #2329: ARTEMIS-2096 Refactor AMQMessage abstra...

2018-09-25 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2329 ARTEMIS-2096 Refactor AMQMessage abstraction Major refactoring of the AMQPMessage abstraction to resolve some issue of message corruption still present in the code and improve

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220155971 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@ public

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220179880 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -1056,4 +1107,26 @@ public

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2328#discussion_r220179027 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -68,22 +73,23 @@ public

[GitHub] activemq-artemis pull request #:

2018-09-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/30c3b592944ae7bd6089c8326413a923ee98ccb6#commitcomment-30637558 In artemis-commons/src/test/java/org/apache/activemq/artemis/utils/TypedPropertiesConcurrencyTest.java:

[GitHub] activemq-artemis pull request #:

2018-09-25 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/30c3b592944ae7bd6089c8326413a923ee98ccb6#commitcomment-30637432 In artemis-commons/src/test/java/org/apache/activemq/artemis/utils/TypedPropertiesConcurrencyTest.java: In

[GitHub] activemq-artemis pull request #2328: ARTEMIS-2095 - Typed Properties ThreadS...

2018-09-25 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2328 ARTEMIS-2095 - Typed Properties ThreadSafety Add Concurrency Test to expose concurrency errors seen in logs. Add Fix to ensure TypedProperties to ensure threadsafety

[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-09-25 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2181#discussion_r220121826 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -227,7 +227,11 @@

[GitHub] activemq-artemis pull request #:

2018-09-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/2485e17e526bf42a1443e9e79600c07e0d4b49f7#commitcomment-30604041 I created a new one, commit and pr is updated with the new one ---

[GitHub] activemq-artemis pull request #:

2018-09-22 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/2485e17e526bf42a1443e9e79600c07e0d4b49f7#commitcomment-30602822 I don’t have a computer to check now. If the JIRA Is already released in 2.6.2 the right thing to do is to

[GitHub] activemq-artemis pull request #2327: NO-JIRA update stomp doc a/b default be...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2327 ---

[GitHub] activemq-artemis pull request #2327: NO-JIRA update stomp doc a/b default be...

2018-09-21 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2327 NO-JIRA update stomp doc a/b default behavior You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work

[GitHub] activemq-artemis pull request #2326: ARTEMIS-1747 - Fix Configuration change...

2018-09-21 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2326 ARTEMIS-1747 - Fix Configuration change loss when network Issue Further fix around network loss. If network loss (split) and slave activates, for a period its config used

[GitHub] activemq-artemis pull request #2316: ARTEMIS-2087 support masked passwords i...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2316 ---

[GitHub] activemq-artemis pull request #2325: ARTEMIS-2093 NPE thrown by NettyConnect...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2325 ---

[GitHub] activemq-artemis pull request #2325: ARTEMIS-2093 NPE thrown by NettyConnect...

2018-09-21 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2325 ARTEMIS-2093 NPE thrown by NettyConnector::createConnection Given that NettyConnector::createConnection isn't happening on the channel's event loop, it could race with a channel

[GitHub] activemq-artemis pull request #2324: ARTEMIS-2092 fix first page messages lo...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2324 ---

[GitHub] activemq-artemis pull request #2318: ARTEMIS-2090 JDBC Journal is not deleti...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2318 ---

[GitHub] activemq-artemis pull request #2324: ARTEMIS-2092 fix first page messages lo...

2018-09-19 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2324 ARTEMIS-2092 fix first page messages lost on server crash bug Reproduction steps: 1. Send messages(using non transactional session), ensure the queue enters page mode and only one

[GitHub] activemq-artemis pull request #2323: ARTEMIS-2089 DB2 sending larger message...

2018-09-18 Thread franz1981
Github user franz1981 closed the pull request at: https://github.com/apache/activemq-artemis/pull/2323 ---

[GitHub] activemq-artemis pull request #2322: ARTEMIS-1991 document advanced destinat...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2322 ---

[GitHub] activemq-artemis pull request #2317: ARTEMIS-2089 DB2 sending larger message...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2317 ---

[GitHub] activemq-artemis pull request #2323: ARTEMIS-2089 DB2 sending larger message...

2018-09-18 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2323 ARTEMIS-2089 DB2 sending larger message (1MB) crashes the whole server (cherry picked from commit f7602e520af66ac44d6e8166330e44dcfcda34d1) You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #2315: ARTEMIS-1919 implement SNI properly

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2315 ---

[GitHub] activemq-artemis pull request #2322: ARTEMIS-1991 document advanced destinat...

2018-09-17 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2322 ARTEMIS-1991 document advanced destination options You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2320: NO-JIRA: ScaleDownTest checkstyle error...

2018-09-17 Thread RoddieKieley
Github user RoddieKieley closed the pull request at: https://github.com/apache/activemq-artemis/pull/2320 ---

[GitHub] activemq-artemis pull request #2321: NO-JIRA: ScaleDownTest checkstyle error...

2018-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2321 ---

[GitHub] activemq-artemis pull request #2321: NO-JIRA: ScaleDownTest checkstyle error...

2018-09-17 Thread RoddieKieley
GitHub user RoddieKieley opened a pull request: https://github.com/apache/activemq-artemis/pull/2321 NO-JIRA: ScaleDownTest checkstyle error fix Empty space removed that produced a checkstyle error. (cherry picked from commit 536edc05c435e31f095a283c44fe476846ef68cb) You

[GitHub] activemq-artemis pull request #2320: ScaleDownTest checkstyle error fix

2018-09-17 Thread RoddieKieley
GitHub user RoddieKieley opened a pull request: https://github.com/apache/activemq-artemis/pull/2320 ScaleDownTest checkstyle error fix Empty space removed that produced a checkstyle error. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2319: ARTEMIS-2000: scaleDown/scaledownconnec...

2018-09-17 Thread RoddieKieley
Github user RoddieKieley closed the pull request at: https://github.com/apache/activemq-artemis/pull/2319 ---

[GitHub] activemq-artemis pull request #2202: ARTEMIS-2000: For ScaleDown set the Rou...

2018-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2202 ---

[GitHub] activemq-artemis pull request #2319: ARTEMIS-2000: scaleDown/scaledownconnec...

2018-09-14 Thread RoddieKieley
GitHub user RoddieKieley opened a pull request: https://github.com/apache/activemq-artemis/pull/2319 ARTEMIS-2000: scaleDown/scaledownconnector call does not take routing type into account when creating queues on addresses Cherry picked the two commits from the main ARTEMIS-2000

[GitHub] activemq-artemis pull request #2318: ARTEMIS-2090 JDBC Journal is not deleti...

2018-09-14 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2318 ARTEMIS-2090 JDBC Journal is not deleting TX records JDBCJournalImpl::cleanupTxRecords is not committing the deleteJournalTxRecords statement leaving the TX records into the

[GitHub] activemq-artemis pull request #2317: ARTEMIS-2089 DB2 sending larger message...

2018-09-14 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2317 ARTEMIS-2089 DB2 sending larger message (1MB) crashes the whole server It declares JDBC journal Blobs for IBM DB2 DBMS matching max-blob-size in order to allow to store data with

[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

2018-09-13 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2305#discussion_r217584046 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java --- @@ -223,7 +224,7 @@ private int

[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

2018-09-13 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2305#discussion_r217573949 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java --- @@ -223,7 +224,7 @@ private int

[GitHub] activemq-artemis pull request #2316: ARTEMIS-2087 support masked passwords i...

2018-09-13 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2316 ARTEMIS-2087 support masked passwords in management.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2315: ARTEMIS-1919 implement SNI properly

2018-09-13 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2315 ARTEMIS-1919 implement SNI properly You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1919

[GitHub] activemq-artemis pull request #2306: ARTEMIS-1898 - make sure to send credit...

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2306 ---

[GitHub] activemq-artemis pull request #2314: ARTEMIS-2086 Removing HDR Histogram opt...

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2314 ---

[GitHub] activemq-artemis pull request #2314: ARTEMIS-2086 Removing HDR Histogram opt...

2018-09-13 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2314 ARTEMIS-2086 Removing HDR Histogram option You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis pull request #2313: ARTEMIS-2085 - Improve validation of MD...

2018-09-13 Thread rpelisse
Github user rpelisse closed the pull request at: https://github.com/apache/activemq-artemis/pull/2313 ---

[GitHub] activemq-artemis pull request #2313: ARTEMIS-2085 - Improve validation of MD...

2018-09-13 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2313#discussion_r217442584 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java --- @@ -406,7 +406,9 @@ public

[GitHub] activemq-artemis pull request #2313: ARTEMIS-2085 - Improve validation of MD...

2018-09-13 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2313#discussion_r217442671 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java --- @@ -603,7 +605,11 @@ public

[GitHub] activemq-artemis pull request #2313: ARTEMIS-2085 - Improve validation of MD...

2018-09-13 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2313#discussion_r217442386 --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java --- @@ -556,7 +556,7 @@ protected

[GitHub] activemq-artemis pull request #2305: NO-JIRA - Page.write() should throw exc...

2018-09-13 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2305#discussion_r217426008 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java --- @@ -223,7 +223,7 @@ private int

[GitHub] activemq-artemis pull request #2313: JBEAP-14106 - Improve validation of MDB...

2018-09-13 Thread rpelisse
GitHub user rpelisse opened a pull request: https://github.com/apache/activemq-artemis/pull/2313 JBEAP-14106 - Improve validation of MDB activation config properties values Issue: https://issues.jboss.org/browse/JBEAP-14106 No upstream issue Upstream PR:

[GitHub] activemq-artemis pull request #2311: JBEAP-14106 - Improve validation of MDB...

2018-09-13 Thread rpelisse
Github user rpelisse closed the pull request at: https://github.com/apache/activemq-artemis/pull/2311 ---

[GitHub] activemq-artemis pull request #2312: JBEAP-14106 - Improve validation of MDB...

2018-09-13 Thread rpelisse
GitHub user rpelisse opened a pull request: https://github.com/apache/activemq-artemis/pull/2312 JBEAP-14106 - Improve validation of MDB activation config properties values Issue: https://issues.jboss.org/browse/JBEAP-14106 No upstream issue You can merge this pull request into

[GitHub] activemq-artemis pull request #2311: JBEAP-14106 - Improve validation of MDB...

2018-09-13 Thread rpelisse
GitHub user rpelisse opened a pull request: https://github.com/apache/activemq-artemis/pull/2311 JBEAP-14106 - Improve validation of MDB activation config properties values Issue: https://issues.jboss.org/browse/JBEAP-14106 You can merge this pull request into a Git repository by

<    3   4   5   6   7   8   9   10   11   12   >