BigBlueHat opened a new issue #21:
URL: https://github.com/apache/incubator-annotator-website/issues/21
@tilgovi @Treora I'll let y'all take the first crack at revising this
issue--feel free to edit this issue directly (or revise and paste as a
comment...completely up to you). Happy to rev
tilgovi closed issue #21:
URL: https://github.com/apache/incubator-annotator-website/issues/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tilgovi commented on issue #81:
URL:
https://github.com/apache/incubator-annotator/issues/81#issuecomment-674584671
I propose we start by making some attempt to have core pieces of our
reusable code allow for synchronous iterators, but keep the asynchronous
consumer API.
I started
tilgovi commented on issue #80:
URL:
https://github.com/apache/incubator-annotator/issues/80#issuecomment-674584836
Is there any action here, or are we okay to leave the nodes split?
This is an automated message from the Apa
tilgovi commented on issue #75:
URL:
https://github.com/apache/incubator-annotator/issues/75#issuecomment-674586963
> The text MUST be normalized before recording the annotation. Thus HTML/XML
tags SHOULD be removed and character entities SHOULD be replaced with the
character that they en
tilgovi closed issue #51:
URL: https://github.com/apache/incubator-annotator/issues/51
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tilgovi commented on issue #51:
URL:
https://github.com/apache/incubator-annotator/issues/51#issuecomment-674593638
I'll close this for now, as it seems like we may not need this at the moment.
This is an automated message f
Treora commented on issue #80:
URL:
https://github.com/apache/incubator-annotator/issues/80#issuecomment-674803745
> Is there any action here, or are we okay to leave the nodes split?
I ended up thinking that running e.g.
`range.commonAncestorContainer.normalize()` in the cleanup wo
Treora commented on issue #81:
URL:
https://github.com/apache/incubator-annotator/issues/81#issuecomment-674807172
Looks good. I’d be fine with adopting this approach, but equally fine with
just keeping it in mind for when we have a need/requests for synchronous use.
Treora opened a new issue #85:
URL: https://github.com/apache/incubator-annotator/issues/85
In recent calls we (especially @tilgovi — so feel free to improve my
description) have discussed an approach to allow text selector
matching/describing implementations on other ‘document models’ tha
Treora commented on issue #85:
URL:
https://github.com/apache/incubator-annotator/issues/85#issuecomment-674836567
@tilgovi alluded to this chunking idea in #75:
> However, I think we should consider going a step further and writing a
text selector that consumes an iterator that yie
Treora opened a new pull request #86:
URL: https://github.com/apache/incubator-annotator/pull/86
When selection contains no characters, we can still show the spot that is
selected.
(my view has been that
tilgovi commented on pull request #87:
URL:
https://github.com/apache/incubator-annotator/pull/87#issuecomment-681311670
> My thinking was rather that the type definitions would be based on the WA
specification, rather than on the needs of our implementation. The type
definitions could be
tilgovi commented on pull request #87:
URL:
https://github.com/apache/incubator-annotator/pull/87#issuecomment-681312139
I'll take another look at `makeRefinable` and test out how it behaves when
called from TypeScript on different inputs.
I also think it may be okay to add back the
Treora commented on issue #60:
URL:
https://github.com/apache/incubator-annotator/issues/60#issuecomment-686651856
> Besides making a parser for the fragment identifier syntax itself, I
suppose we would want to implement the algorithm for resolving it. May well be
worthwhile if others are
tilgovi opened a new pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88
Define the DOM match functions in terms of Range and place the burden on
the caller to pass a Range. Remove the scope helper functions.
This change simplifies the code at the possible
Treora commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r484861032
##
File path: packages/dom/src/highlight-range.ts
##
@@ -73,8 +73,9 @@ function textNodesInRange(range: Range): Text[] {
}
// Collect the t
Treora commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r484880916
##
File path: packages/dom/src/highlight-range.ts
##
@@ -73,8 +73,9 @@ function textNodesInRange(range: Range): Text[] {
}
// Collect the t
Treora commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r484884585
##
File path: packages/dom/src/highlight-range.ts
##
@@ -73,8 +73,9 @@ function textNodesInRange(range: Range): Text[] {
}
// Collect the t
Treora commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-62247
I hope you don’t mind I turned my suggestions (except using AbstractRange)
into commits. I noticed that the `ownerDocument(range)` helper was not
permitted by the eslint
tilgovi commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r485064755
##
File path: packages/dom/src/text-quote/describe.ts
##
@@ -21,44 +21,31 @@
import seek from 'dom-seek';
import type { TextQuoteSelector } from
tilgovi commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-689010515
> I noticed that the ownerDocument(range) helper was not permitted by the
eslint rule forbidding relative parent imports. Was that your reason to repeat
the exact same
tilgovi commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r485068658
##
File path: packages/dom/src/text-quote/describe.ts
##
@@ -21,44 +21,31 @@
import seek from 'dom-seek';
import type { TextQuoteSelector } from
tilgovi commented on a change in pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88#discussion_r485069411
##
File path: packages/dom/test/highlight-range/highlight-range.test.ts
##
@@ -172,7 +172,7 @@ describe('highlightRange', () => {
const input
tilgovi commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-689016825
This looks good. I think I'm okay with removing the relative import rule for
now. I don't like having modules called `util`, or packages called `common` or
`utils` or a
tilgovi commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-689017845
So, to summarize, I'd rather you left the inline `ownerDocument` code, but
I'm okay with this as a temporary change before we extract a package. I like
the lint rule, b
tilgovi commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-689018248
Hah, I can't approve my own PR, but I may just merge this in the evening
then, with your changes. Thanks for taking a look.
---
Treora commented on pull request #88:
URL:
https://github.com/apache/incubator-annotator/pull/88#issuecomment-689082728
> I'll approve, but recommend renaming `util.ts` to just `owner-document.ts`
or `scope.ts`.
As it is not specific to scopes and now also used for other ranges,
`o
tilgovi merged pull request #88:
URL: https://github.com/apache/incubator-annotator/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tilgovi closed pull request #87:
URL: https://github.com/apache/incubator-annotator/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tilgovi commented on pull request #87:
URL:
https://github.com/apache/incubator-annotator/pull/87#issuecomment-690362276
Closing this. We pulled the DOM scope change out into #88 and we're
investigating a different pattern for composing the higher level match function
creators to be re-in
tilgovi opened a new issue #89:
URL: https://github.com/apache/incubator-annotator/issues/89
This can be as simple as a stub that describes the package as part of Apache
Annotator (incubating) and links to the main project.
tilgovi opened a new issue #90:
URL: https://github.com/apache/incubator-annotator/issues/90
In order to follow suggestions for releasing npm packages as
`apache-` without violating the spirit of producing convenience
packages from released source code, I copied, unmodified, the two packag
tilgovi opened a new issue #91:
URL: https://github.com/apache/incubator-annotator/issues/91
The existing function to describe text quotes can lock up the runtime if
given a very small quote with a lot of matches to disambiguate between. The
absolutely worst case scenario is to give it an
Treora commented on issue #85:
URL:
https://github.com/apache/incubator-annotator/issues/85#issuecomment-693569313
> Currently, our text quote anchoring function (in the dom package) is
hard-coded to search for text quote using Range, NodeIterator, TreeWalker. When
using the chunk approac
tilgovi opened a new issue #92:
URL: https://github.com/apache/incubator-annotator/issues/92
It would be helpful for everyone following along with the bleeding edge here
to be able to consume packages from npm. We could publish continually, we just
need to make it clear that these are deve
BigBlueHat opened a new pull request #22:
URL: https://github.com/apache/incubator-annotator-website/pull/22
The Markdown and templates (see `_layouts`) live in
the `src/` folder. All other static content (without
any need for processing) live directly in the `content/`
folder. Elev
BigBlueHat commented on pull request #22:
URL:
https://github.com/apache/incubator-annotator-website/pull/22#issuecomment-694542947
Not really any content of value, but the setup is in place. 😁
This is an automated message
Treora opened a new pull request #93:
URL: https://github.com/apache/incubator-annotator/pull/93
Should fix #91.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Treora commented on issue #90:
URL:
https://github.com/apache/incubator-annotator/issues/90#issuecomment-694930052
What exactly would a meta-package provide? Should it be just like the
current apache-annotator that you published to npm, and the issue is simply to
automate its publishing p
Treora edited a comment on issue #90:
URL:
https://github.com/apache/incubator-annotator/issues/90#issuecomment-694930052
What exactly would a meta-package provide? Should it be just like the
current apache-annotator that you published to npm, and the issue is simply to
automate its publi
Treora opened a new pull request #94:
URL: https://github.com/apache/incubator-annotator/pull/94
A step towards addressing issue #90. This first approach exports through
both ways I [mentioned
there](https://github.com/apache/incubator-annotator/issues/90#issuecomment-694930052),
so a use
Treora merged pull request #93:
URL: https://github.com/apache/incubator-annotator/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Treora closed issue #91:
URL: https://github.com/apache/incubator-annotator/issues/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
tilgovi commented on pull request #94:
URL:
https://github.com/apache/incubator-annotator/pull/94#issuecomment-695055922
> Before a release, we’d have to manually update the packages’ version
numbers in package.json. Also when adding a package, we’d have to add it
manually in several plac
tilgovi commented on a change in pull request #94:
URL: https://github.com/apache/incubator-annotator/pull/94#discussion_r491160231
##
File path: packages/apache-annotator/package.json
##
@@ -0,0 +1,41 @@
+{
+ "name": "apache-annotator",
+ "version": "0.1.0",
+ "description"
tilgovi commented on a change in pull request #94:
URL: https://github.com/apache/incubator-annotator/pull/94#discussion_r491160666
##
File path: packages/apache-annotator/src/index.ts
##
@@ -0,0 +1,7 @@
+import * as dom from '@annotator/dom';
+import * as selector from '@annot
Treora commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-695059327
I suppose we could continue using the `dev` tag that we once used? E.g.
[`@annotator/dom`](https://www.npmjs.com/package/@annotator/dom) has a release
`0.1.0-dev.9d100c0f`. A
tilgovi commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-695060189
> While it would be good to make our packages readily available in the npm
ecosystem, this need not mean they have to be on the npm central registry.
That's well said.
tilgovi commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-695063313
> But perhaps we could still try make this work by making the top-level
package the meta-package discussed in #90?
That won't work because I think lerna and/or yarn en
tilgovi commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-695064308
We could maybe use the GitHub package registry, too, if that's at all easier
to integrate for whatever reason.
-
Treora commented on a change in pull request #94:
URL: https://github.com/apache/incubator-annotator/pull/94#discussion_r491169674
##
File path: packages/apache-annotator/package.json
##
@@ -0,0 +1,41 @@
+{
+ "name": "apache-annotator",
+ "version": "0.1.0",
+ "description":
tilgovi commented on pull request #94:
URL:
https://github.com/apache/incubator-annotator/pull/94#issuecomment-695412156
I believe we do want the types and the dependencies. Even just importing
things leads to the build having babel import helpers from the runtime package.
We may not need
tilgovi merged pull request #94:
URL: https://github.com/apache/incubator-annotator/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tilgovi commented on issue #90:
URL:
https://github.com/apache/incubator-annotator/issues/90#issuecomment-695419350
Closed by #94.
This is an automated message from the Apache Git Service.
To respond to the message, please l
tilgovi closed issue #90:
URL: https://github.com/apache/incubator-annotator/issues/90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tilgovi closed issue #89:
URL: https://github.com/apache/incubator-annotator/issues/89
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tilgovi commented on issue #89:
URL:
https://github.com/apache/incubator-annotator/issues/89#issuecomment-695712549
Closed by bb78bd5.
This is an automated message from the Apache Git Service.
To respond to the message, plea
tilgovi opened a new pull request #95:
URL: https://github.com/apache/incubator-annotator/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ysndr opened a new issue #96:
URL: https://github.com/apache/incubator-annotator/issues/96
Hej
I'm currently packaging this library for the nix ecosystem under the NGI0
project.
I have a weird issue I can't really tell for where it comes from.
When running `yarn build` the type
tilgovi commented on issue #96:
URL:
https://github.com/apache/incubator-annotator/issues/96#issuecomment-699748065
The types build process is designed with a solution style, where each
package has is its own TypeScript build that emits declaration files. This
error looks like what happen
ysndr commented on issue #96:
URL:
https://github.com/apache/incubator-annotator/issues/96#issuecomment-700015551
Thanks I guess I found part of the error. The subpackages' src were not
included in the node_modules (issue related to nix yarn toolset). So apparently
not an issue with the p
ysndr closed issue #96:
URL: https://github.com/apache/incubator-annotator/issues/96
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tilgovi commented on issue #96:
URL:
https://github.com/apache/incubator-annotator/issues/96#issuecomment-700279048
@ysndr great! Let us know if anything else come sup.
This is an automated message from the Apache Git Servic
tilgovi merged pull request #95:
URL: https://github.com/apache/incubator-annotator/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
BigBlueHat commented on pull request #22:
URL:
https://github.com/apache/incubator-annotator-website/pull/22#issuecomment-705818713
@Treora made a few of your requested changes. 😃 The `index.html` file is
still not converted into Markdown, but could/can be at any point--right now
11ty jus
Treora commented on issue #75:
URL:
https://github.com/apache/incubator-annotator/issues/75#issuecomment-705834642
I started implementing this in the `text-position` branch. I started by
simply copying the code and tests from text quote selection, and adapting them
as needed.
--
Treora commented on issue #75:
URL:
https://github.com/apache/incubator-annotator/issues/75#issuecomment-705834642
I started implementing this in the `text-position` branch. I started by
simply copying the code and tests from text quote selection, and adapting them
as needed.
--
BigBlueHat commented on pull request #22:
URL:
https://github.com/apache/incubator-annotator-website/pull/22#issuecomment-705818713
@Treora made a few of your requested changes. 😃 The `index.html` file is
still not converted into Markdown, but could/can be at any point--right now
11ty jus
BigBlueHat commented on issue #21:
URL:
https://github.com/apache/incubator-annotator-website/issues/21#issuecomment-722484625
Looks like we posted this one in August:
https://cwiki.apache.org/confluence/display/INCUBATOR/August2020
---
tilgovi opened a new issue #97:
URL: https://github.com/apache/incubator-annotator/issues/97
Using tools from the microsoft/tsdoc ecosystem, create scripts to generate
TypeScript API documentation.
This is an automated messa
BigBlueHat merged pull request #22:
URL: https://github.com/apache/incubator-annotator-website/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Treora commented on issue #60:
URL:
https://github.com/apache/incubator-annotator/issues/60#issuecomment-722659798
We shortly discussed this topic in today’s call while looking over the open
issues. We agreed that just parsing the syntax is not much use, as it comes
together with a specif
Treora commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-722666886
Note from today’s call: supposedly yarn 2 should be able to install packages
from within a monorepo, so we could start with accepting that nightly users
have to use yarn 2, a
Treora opened a new pull request #98:
URL: https://github.com/apache/incubator-annotator/pull/98
Finally.
- Addresses #75 (support TextPositionSelector)
- Addresses #85 (Chunking abstraction); because having two selectors dealing
with text was the right moment to introduce such ab
vrish88 commented on issue #70:
URL:
https://github.com/apache/incubator-annotator/issues/70#issuecomment-737667397
Hello! I've been lurking here a while, so now to pop in! I came across
[elucidate](https://github.com/dlcs/elucidate-server) via the [w3c's
implementation test
results](htt
Treora commented on issue #70:
URL:
https://github.com/apache/incubator-annotator/issues/70#issuecomment-738020715
> Hello! I've been lurking here a while, so now to pop in!
Welcome! If you are interested in getting involved in some way, or just
curious, feel free to join the [maili
vrish88 commented on issue #70:
URL:
https://github.com/apache/incubator-annotator/issues/70#issuecomment-738342322
@Treora Actually, I may take you up on that. I've got a side project that
I'm really looking to use the whole annotation ecosystem for and I've got some
time off work now. I
tilgovi commented on a change in pull request #98:
URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540513682
##
File path: .eslintrc.js
##
@@ -111,6 +112,7 @@ module.exports = {
plugins: ['@typescript-eslint'],
rules: {
'@typescript
tilgovi commented on a change in pull request #98:
URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540515237
##
File path: packages/dom/src/normalize-range.ts
##
@@ -0,0 +1,156 @@
+/**
+ * @license
+ * Licensed to the Apache Software Foundation (ASF) unde
tilgovi commented on a change in pull request #98:
URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540515796
##
File path: packages/dom/src/normalize-range.ts
##
@@ -0,0 +1,156 @@
+/**
+ * @license
+ * Licensed to the Apache Software Foundation (ASF) unde
Treora commented on pull request #98:
URL:
https://github.com/apache/incubator-annotator/pull/98#issuecomment-750933430
> I'm not 100 on all the APIs yet, …
Me neither.
> …but I'd like to merge and then make incremental changes from there.
Excellent stuff.
Cool with me
Treora merged pull request #98:
URL: https://github.com/apache/incubator-annotator/pull/98
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Treora closed issue #85:
URL: https://github.com/apache/incubator-annotator/issues/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Treora closed issue #75:
URL: https://github.com/apache/incubator-annotator/issues/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Treora commented on issue #75:
URL:
https://github.com/apache/incubator-annotator/issues/75#issuecomment-750933811
Implemented in #98.
This is an automated message from the Apache Git Service.
To respond to the message, plea
Treora commented on issue #83:
URL:
https://github.com/apache/incubator-annotator/issues/83#issuecomment-750943153
> Prior art we could borrow from:
>
> * https://github.com/tilgovi/dom-anchor-text-quote (uses diff-match-patch)
> * https://github.com/robertknight/approx-string-mat
robertknight commented on issue #83:
URL:
https://github.com/apache/incubator-annotator/issues/83#issuecomment-751125582
> CC @robertknight (happy to hear if you have more research notes,
experimental results or other relevant tips from your experience developing
this!)
Aside from
robertknight edited a comment on issue #83:
URL:
https://github.com/apache/incubator-annotator/issues/83#issuecomment-751125582
> CC @robertknight (happy to hear if you have more research notes,
experimental results or other relevant tips from your experience developing
this!)
Asid
robertknight edited a comment on issue #83:
URL:
https://github.com/apache/incubator-annotator/issues/83#issuecomment-751125582
> CC @robertknight (happy to hear if you have more research notes,
experimental results or other relevant tips from your experience developing
this!)
Asid
robertknight edited a comment on issue #83:
URL:
https://github.com/apache/incubator-annotator/issues/83#issuecomment-751125582
> CC @robertknight (happy to hear if you have more research notes,
experimental results or other relevant tips from your experience developing
this!)
Asid
Treora opened a new pull request #99:
URL: https://github.com/apache/incubator-annotator/pull/99
A TextQuoteSelector can add as much prefix and suffix as desired. Until now,
we only added prefix and suffix as much as was strictly necessary to
disambiguate the target from other occurrences
vrish88 commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-754701314
Hey all! Sorry I haven't been able to make the subsequent meetings.
I'd be interested in using some of these non-versioned releases. Are there
any constraints around
Treora commented on issue #92:
URL:
https://github.com/apache/incubator-annotator/issues/92#issuecomment-75473
> I'd be interested in using some of these non-versioned releases. Are there
any constraints around publishing a "latest" build? Would you be open to a pr
that does it in GH
vrish88 opened a new pull request #100:
URL: https://github.com/apache/incubator-annotator/pull/100
Hello there,
This PR configures github to publish an artifact to npm with the `dev`
[tag](https://docs.npmjs.com/adding-dist-tags-to-packages#publishing-a-package-with-a-dist-tag).
I
Treora opened a new pull request #101:
URL: https://github.com/apache/incubator-annotator/pull/101
Taking a stab at #97. It seems to work, but suggestions/improvements welcome.
@tilgovi: you suggested
[@microsoft/api-documenter](https://www.npmjs.com/package/@microsoft/api-documenter
1 - 100 of 307 matches
Mail list logo
