On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
>>>> On 2018-10-28, Gintautas Grigelionis wrote:
>>>
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>>>> I wonder whether it wouldn't be a good idea
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>> I wonder whether it wouldn't be a good idea to create a separate class
>> for constants used during testing that lives in ant-testutil rather than
>> poluting the &q
Gintas, please allow me again to ask you to not commit code changes and
whitespace changes at the same time.
This diff consists of 920 lines, more than 800 of them are whitespace
changes that are completely unrelated to the commit message.
Stefan
-
On 2018-10-23, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>+/**
>+ * Magic property that makes unit tests based on BuildFileTest
>+ * or BuildFileRule ignore externally set basedir
>+ * (typically by Surefire/Fa
On 2018-10-20, Gintautas Grigelionis wrote:
> I believe that in order to execute Ant test suite in Surefire one must
> configure basedir which unfortunately affects Ant test projects.
I'm not sure I share the goal of trying to run the tests via Surefire at
all.
Antoine has been the one who set u
On 2018-10-12, Gintautas Grigelionis wrote:
> Equinox JarProcessor [1] seems to use pack200 CLI.
which is propbably going to be removed together with the Java API :-)
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.
Hi Krzysztof
I'm not actively working on Ivy so take my response with a grain of
salt.
On 2018-10-09, Dragan, Krzysztof wrote:
> Hi,
> scanning latest version of Apache Ivy(2.5.0-rc-1) using jdeprscan on
> jdk11 I noticed two problems with this jar.
> These two methods using internal jdk marke
On 2018-08-22, Matt Sicker wrote:
> Pretty much every implementation of javac will automatically convert the
> string concatenation code into StringBuilders. Decompile the byte code and
> see for yourself.
I know that :-)
The thing I qibble about is the commit message says "remove
redundancies"
On 2018-08-16, Jaikiran Pai wrote:
> While working on the documentation of the junitlauncher task, for fork
> support, I realized that when we first released this task, due to an
> oversight, I did not add support for setting system properties or
> environment variables through this task. The fork
On 2018-08-19, Jaikiran Pai wrote:
> The tstamp (antunit) test named "testMagicProperty" has been
> consistently failing (only) on Windows for a while now[1]. Both master
> and 1.9.x branches. The failure looks really odd and something that I
> haven't been able to understand yet. The one interest
> diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java
> b/src/main/org/apache/tools/ant/types/PatternSet.java
> -: new
> StringBuilder(baseString).append(";encoding->").append(encoding).toString();
> +: baseString + ";encoding->" + encoding;
I don'
On 2018-07-22, Gintautas Grigelionis wrote:
> I've found out that ant (🐜) is a Unicode character from 6.0 (2010)
> and a part of Emoji 1.0 as well. I wonder if we could have some good use of
> ant in red violet (or, actually, #a81c7d) emoji?
🐜 which looks quite idfferent from https://unicode-tabl
Hi all
with +1s by
Jaikiran Pai
Maarten Coene
Nicolas Lalevée
Stefan Bodewig (implicit)
and no other votes the vote has passed. I'll start the usual publish,
wait for mirrors, announce cycle now.
Thanks to everybody who voted
S
Hi all
with +1s by
Jaikiran Pai
Maarten Coene
Paul King (not binding but much appreciated)
Nicolas Lalevée
Stefan Bodewig (implicit)
and no other votes the vote has passed. I'll start the usual publish,
wait for mirrors, announce cycle now.
Thanks to everybody who voted
S
Hi all
I've created a new release candidate for 1.9.13 with a few bug fixes.
git tag: ANT_1.9.13_RC1
on commit: e7a4d8683
tarballs: https://dist.apache.org/repos/dist/dev/ant/
revision: 28014
Maven artifacts:
https://repository.apache.org/content/repositories/orgapache
Hi all
I've created a new release candidate for 1.10.5 with a few bug fixes and
and the "single source executable" feature for Java11.
git tag: ANT_1.10.5_RC1
on commit: c0848d2c6
tarballs: https://dist.apache.org/repos/dist/dev/ant/
revision: 28015
Maven artifacts:
ht
On 2018-07-07, Jaikiran Pai wrote:
> Here's a status of the current state of upstream repo branches
> "master" and "1.9.x".
Many thanks, Jaikiran and many thanks for the detailed report. I've been
able to reproduce the checks you've performed.
I'll build RCs for the next Ant releases soon.
Stef
On 2018-07-06, wrote:
> That would reduce the original "2f64e0b5" diff to (the extra lines
> starting with \ before the diff are added by the checker i wrote)
Thanks, Martijn
I've just committed the fix to Ant's URL inside jdepend.xsl.
Stefan
-
On 2018-07-06, Jaikiran Pai wrote:
> On 05/07/18 2:42 PM, Stefan Bodewig wrote:
>> On 2018-07-05, Jaikiran Pai wrote:
>>> I personally believe that reviewing these meaningless changes is a
>>> waste of time and energy. I'm in favour of rolling back the entire
On 2018-07-05, Jaikiran Pai wrote:
> I personally believe that reviewing these meaningless changes is a
> waste of time and energy. I'm in favour of rolling back the entire
> commit set if that's what it takes.
+1
although reverting the commits in both branches and merging back the
1.9.x branch
On 2018-07-04, wrote:
> Enhance the Java task to allow single file source program execution, a
> feature, introduced in Java 11
+1
Could you please add javadocs to the new getter/setter in
CommmandLineJava?
Thanks
Stefan
---
Gintas,
> - passfile="testpassfile.tmp"%/>
> + passfile="testpassfile.tmp"/>
the commit that introduced the issue was labeled "Trailing whitespace"
and I trusted to contain exactly that and didn't bother reviewing
it. Obviously it did not.
A single commit that spans a dozen mail messag
On 2018-07-04, wrote:
> Repository: ant
> Updated Branches:
> refs/heads/master e2c9cdd63 -> 1a0884e25 (forced update)
This is not good, Gintas. You've just broken the working copies of
anybody who has checked out master between you pushing e2c9cdd63 and
this commit. Really, this is not good,
On 2018-07-03, Jaikiran Pai wrote:
> I did some testing manually for this new method, with both symlinks
> and non-symlinks with both the string check version and the
> getParent() version. In both of those, I couldn't get it to break in
> any odd ways (which is a good thing). It also means that m
On 2018-07-03, Jan Matèrne (jhm) wrote:
> We already have something:
> mail: "This task may depend on external libraries that are not included in
> the Ant distribution. See Library Dependencies for more information."
> dependencies:
> "mail.jar Mail task with Mime encoding, and the MimeMail t
On 2018-07-02, Stefan Bodewig wrote:
> On 2018-07-02, Jaikiran Pai wrote:
>> I just checked the commits related to this and it looks mostly
>> correct. However, I am still not 100% sure we have covered it all with
>> this new method that was introduced[1] and used in the
Thank you, Simon
On 2018-07-02, Simon IJskes - QCG wrote:
> As bugzilla is unreachable for now:
>
> subject="Testemail" >
>
>
>
> $ JAVA_HOME=/usr/lib/jvm/java-8-oracle/
> ~/opt/apache-ant-1.10.4/bin/ant _testmail
> runs ok.
> _testmail:
> [mail]
k.
> Maybe some unit tests about it would be nice, just to be sure.
> Then, about tackling the bug, I am on the same page as you both. It looks
> good to me.
> Nicolas
>> Le 1 juil. 2018 à 11:27, Stefan Bodewig a écrit :
>> On 2018-06-28, Stefan Bodewig wrote:
&g
On 2018-07-02, Jaikiran Pai wrote:
> Sorry that I couldn't get to this earlier. My plan to spend more time
> on this during the weekend didn't work out.
It's been a weekend :-)
No worries.
> I just checked the commits related to this and it looks mostly
> correct. However, I am still not 100% s
On 2018-06-28, Stefan Bodewig wrote:
> On 2018-06-28, Jaikiran Pai wrote:
>> Which then makes me wonder - in the context of this specific
>> untar/expand/unzip issue, should we probably be using a different
>> custom very specific logic (which relies on canonical f
On 2018-06-28, Jaikiran Pai wrote:
> On 28/06/18 8:37 PM, Stefan Bodewig wrote:
>> /dir
>>/dir2
>>/dir3
>> link -> /dir/dir2
>> isLeadingPath("/dir/dir3", "/dir/dir3/link") returns true which it would
>> not do if links
On 2018-06-28, Jaikiran Pai wrote:
> However, looking at the FileUtils#isLeadingPath(...) implementation, I
> wonder why it even uses normalize. Given that the goal of that API (as
> stated in the javadoc) is to figure out if one path leads the other,
> to me that translates to being a check to se
Hi all
while looking into https://bz.apache.org/bugzilla/show_bug.cgi?id=62502
I realized that I had a false expectation of what normalize would do in
a certain edge case.
If you feed into it a path with more "../" segments than can be
travelled up, like
FileUtils.normalize("/tmp/dest/../../../.
On 2018-06-28, Stefan Bodewig wrote:
> The ASF installations allow everybody to create accounts and everybody
> to create new issues. This is a deliberate choice and is the same for
> JIRA and Bugzilla - and is the best choice for an open source project
> IMHO.
> I'm not sure
On 2018-06-28, Jan Matèrne (jhm) wrote:
>>> Just curious about our bugzilla infrastructure - do random users get
>>> to change the content of these bugs, even if they aren't the ones who
>>> reported the issue?
>> Yes.
>> Back when Bugzilla was introduced the developers and admins falsely
>> ass
On 2018-06-28, Jaikiran Pai wrote:
> Just curious about our bugzilla infrastructure - do random users get
> to change the content of these bugs, even if they aren't the ones who
> reported the issue?
Yes.
Back when Bugzilla was introduced the developers and admins falsely
assumed only sensible p
On 2018-06-25, Jaikiran Pai wrote:
> I'm initiating a newer vote mail for 2.3.0-rc1 release of Apache IvyDE
> project. This addresses the blocker issue that Nicolas identified, the
> last time a vote was initiated for this version.
As usual I've only checked the source archive matches the tag, al
LogCapturer.
For complete information on AntUnit, including instructions on how to
submit bug reports, patches, or suggestions for improvement, see the
Apache AntUnit website:
https://ant.apache.org/antlibs/antunit/index.html
Stefan Bodewig, on behalf of the Apache Ant community
-BEGIN PGP
On 2018-06-24, Gintautas Grigelionis wrote:
> On Sun, 24 Jun 2018 at 14:38, Stefan Bodewig wrote:
>> So if we went to a JUnit 4 only model in antlib-commons with what you
>> describe this would require the Antlib that updated to a new
>> antlibs-commons version to chan
Hi all
with +1s by Maarten Coene, Stefan Bodewig, Gintautas Grigelionis,
Jaikiran Pai and no other votes the vote has passed.
I'll publish the artifacts and announce the release later today.
Stefan
-
To unsubscribe, e
On 2018-06-22, Stefan Bodewig wrote:
> vote will be open for 72 hours and not close before 2018-06-25 05:30 UTC.
making my own vote explicit
+1
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additio
On 2018-06-24, Gintautas Grigelionis wrote:
> On Sun, 24 Jun 2018 at 12:43, Stefan Bodewig wrote:
>> On 2018-06-24, Gintautas Grigelionis wrote:
>>> Actually, the targets are written in a way that checks explicitly for
>>> JUnit 3. Should they be rewritten to chec
On 2018-06-24, Gintautas Grigelionis wrote:
> On Fri, 22 Jun 2018 at 09:45, Stefan Bodewig wrote:
>> On 2018-06-22, Gintautas Grigelionis wrote:
>>> Well, setup-for-junit-tests states that JUnit is not available and
>>> quits.
>> So it lacks a depend
sed to specify the file's encoding.
Bugzilla Report 62379
For complete information on Ant, including instructions
on how to submit bug reports, patches, or suggestions for improvement,
see the Apache Ant website:
http://ant.apache.org/
Stefan Bodewig, on behalf of the Apache Ant co
Hi all
with +1s by Jaikiran, Maarten and myself and no other votes this vote
has passed. I'll publish the artifacts and give the mirrors time to
catch up before announcing the release(s).
Thanks to all
Stefan
-
To unsubs
Hi all
with +1s by Jaikiran, Maarten and myself and no other votes this vote
has passed. I'll publish the artifacts and give the mirrors time to
catch up before announcing the release(s).
Thanks to all
Stefan
-
To unsubs
On 2018-06-22, Gintautas Grigelionis wrote:
> On Fri, 22 Jun 2018 at 07:22, Stefan Bodewig wrote:
>> On 2018-06-21, Gintautas Grigelionis wrote:
>>> P.S. I'm struggling to understand why "ant test" of antlibs bails
>>> because "compile-test
Hi all
this is the third RC for AntUnit 1.4 with the problems Gintas identified
fixed.
tag:
https://git-wip-us.apache.org/repos/asf?p=ant-antlibs-antunit.git;a=tag;h=fb7a42470f8a6de50686f37519e27a068c576606
tarballs:
https://dist.apache.org/repos/dist/dev/ant/antlibs/antunit/
svn
On 2018-06-21, Gintautas Grigelionis wrote:
> I decide to look at antlib builds,
Great.
> and I wonder why common/build.properties contain
> javac.-source=1.2
> javac.-target=1.2
Because this has been the baseline when we created the antlibs and
nobody has bothered to update them.
> Shouldn't
On 2018-06-19, Stefan Bodewig wrote:
> This Vote will be open at least for 72 hours and close no earlier than
> 2018-06-22 08:30UTC.
Making my own vote explicit
+1
Stefan
-
To unsubscribe, e-mail: dev-un
On 2018-06-19, Stefan Bodewig wrote:
> This Vote will be open at least for 72 hours and close no earlier than
> 2018-06-22 08:30UTC.
Making my own vote explicit
+1
Stefan
-
To unsubscribe, e-mail: dev-un
On 2018-06-21, Gintautas Grigelionis wrote:
> POM template has inconsistent Ant versions, 1.7.1 in compile scope and
> 1.8.1 in provided scope.
True.
This happened in c3f8655 which updated the dependencies to 1.8.1 because
one of the unit tests used a method of ant-testutil that hasn't been
pres
Hi all
this is the second RC for AntUnit 1.4 with the problems Jaikiran
identified fixed.
tag:
https://git-wip-us.apache.org/repos/asf?p=ant-antlibs-antunit.git;a=tag;h=21c61e523c767bd1433544596478e9af7ce98858
tarballs:
https://dist.apache.org/repos/dist/dev/ant/antlibs/antunit/
Hi all
when I set up the build for AntUnit I realized the source tarball didn't
contain the git config files that are part of the source repo and
changed the antlibs-common module to include them (they are part of
Ant's defaultexcludes for DirectoryScanner).
Later it dawned on me this may not be
On 2018-06-19, Jaikiran Pai wrote:
> I don't know if the copyright year issue should warrant a new vote. If it
> doesn't, then it's a +1 for this release from me.
I'm afraud it does. Strange this splipped through as it is one of the
things I check when vetting releases other people have
cut. Ove
Hi all
I've created a new release candidate for 1.10.4 with a bunch of bug
fixes and the "ZipSlip" adjustment.
git tag: ANT_1.10.4_RC1
on commit: 9dc3e788b
tarballs: https://dist.apache.org/repos/dist/dev/ant/
revision: 27553
Maven artifacts:
https://repository.apache.
Hi all
I've created a new release candidate for 1.9.12 with a bunch of bug
fixes and the "ZipSlip" adjustment.
git tag: ANT_1_9_12_RC1
on commit: 6e694d820
tarballs: https://dist.apache.org/repos/dist/dev/ant/
revision: 27552
Maven artifacts:
https://repository.apache.
On 2018-06-18, Stefan Bodewig wrote:
> Hi all
> there haven't been big changes but the race condition has been nagging
> us, so I've prepared artifacts to release them as AntUnit 1.4.
> tag:
>
> https://git-wip-us.apache.org/repos/asf?p=ant
Hi all
there haven't been big changes but the race condition has been nagging
us, so I've prepared artifacts to release them as AntUnit 1.4.
tag:
https://git-wip-us.apache.org/repos/asf?p=ant-antlibs-antunit.git;a=tag;h=c4af2e6f2ff632b896a15e7611e01b36bf4eada9
tarballs:
https://dist.a
test and vote on an AntUnit release.
>> -Jaikiran
>> On 18/06/18 12:45 PM, Stefan Bodewig wrote:
>>> OK, then I'll revert the antunit change so the source release ships with
>>> a released version of it and prepare release candidates sometime the
>>&
OK, then I'll revert the antunit change so the source release ships with
a released version of it and prepare release candidates sometime the
coming days.
The alternative would be to cut an AntUnit release first which also
works for me if enough people are willing to vote on that.
Stefan
---
On 2018-06-17, Jaikiran Pai wrote:
> This is a newer vote mail that I'm initiating for the 2.3.0-rc1
> release of IvyDE.
+1
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h.
Hi all
given https://dev.snyk.io/research/zip-slip-vulnerability lists Ant
1.9.12 as a release fixing a security problem it might be a good idea to
actually release 1.9.12 :-)
AFAICS there is no unfinished work in either branch, but I may be
wrong. I am aware there ar enhancement requests around
On 2018-06-16, Gintautas Grigelionis wrote:
> if services would become a new mechanism for adding tasks, modules
> would be of help by providing an API to discover them.
Which may be a bit more tricky than it looks as currently tasks don't
provide metadata about themselves (tag name, namespace ur
On 2018-06-16, Gintautas Grigelionis wrote:
> 2018-06-16 15:42 GMT+02:00 Stefan Bodewig :
>> On 2018-06-06, Gintautas Grigelionis wrote:
>>> 2018-06-06 14:31 GMT+02:00 Stefan Bodewig :
>>>> I guess here our API breaks down as we only ever deal with files or
&g
On 2018-06-16, Gintautas Grigelionis wrote:
> 2018-06-16 15:30 GMT+02:00 Stefan Bodewig :
>> On 2018-06-10, Gintautas Grigelionis wrote:
>>> I would treating Java modules as Ant resources help in this scenario?
>> What exactly - beyond using a module as a zipfileset -
On 2018-06-06, Gintautas Grigelionis wrote:
> 2018-06-06 14:31 GMT+02:00 Stefan Bodewig :
>> I guess here our API breaks down as we only ever deal with files or
>> directories (outside of the symlink task).
> FileSet documentation should be more explicit about the matte
On 2018-06-10, Gintautas Grigelionis wrote:
> I would treating Java modules as Ant resources help in this scenario?
What extactly - beyond using a module as a zipfileset - would you want
to do?
Stefan
-
To unsubscribe, e-mail:
Hi
please add your PGP key to dist.apache.org/release/ant/KEYS
* checksums and signatures are good
* for the files in updatesite it still contains .md5 and .sha but
nothing stronger, please add stronger hashes and remove the md5 files
unless they are read by eclipse
* source tarball and tag d
On 2018-06-16, Gintautas Grigelionis wrote:
> There is yet another point (please bear with me) regarding manual
> installation instructions. In Eclipse 4 series (which is our baseline) the
> "dropins" have a separate directory [1]; I don't think manual copying
> directly to features + plugins work
[As usual I'll only be able to review the legal stuff but probably won't
find time to do so before tomorrow or even Saturday (am currently
traveling).]
On 2018-06-13, Jaikiran Pai wrote:
> You can download the distribution from this URL:
> https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc
On 2018-06-13, Gintautas Grigelionis wrote:
> org.xml.sax.SAXParseException; systemId:
> http://ant.apache.org/ivy/ivyde/updatesite/p2-mirrors--xml.cgi?path=ivyde-2.3.0.rc1-201806132023-RELEASE&countryCode=se&timeZone=1&format=xml;
> lineNumber: 39; columnNumber: 3; Element type "link" lack matchi
On 2018-06-09, Gintautas Grigelionis wrote:
> ... needs a -html4 or -html5 option, otherwise the standard doclet emits a
> warning. Something for Bugzilla?
+1
Stefan
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
On 2018-06-08, Gintautas Grigelionis wrote:
> Then I was surprised that Dependency Check indicates that the latest
> XZ 1.8 has a vulnerability: should we ask them to investigate?
That's a false positive.
https://www.cvedetails.com/cve/CVE-2015-4035/ applies to the command
line tooling and is no
On 2018-06-06, Gintautas Grigelionis wrote:
> 2018-06-06 10:50 GMT+02:00 Stefan Bodewig :
>> On 2018-06-05, Gintautas Grigelionis wrote:
>>> Stefan is right -- "followsymlinks" for the fileset should have been
>> called
>>> "skipsymlinks"
On 2018-06-05, Gintautas Grigelionis wrote:
> Stefan is right -- "followsymlinks" for the fileset should have been called
> "skipsymlinks" or something like that.
I'm afraid I don't follow you here, what did you expect followsymlinks
going by the name? What would the "new semantics of followsymli
Hi all
one of the recurring issues that make Jenkins builds fail is a
thread-safety bug in AntUnit's log capturing code. This is supposed to
be fixed in AntUnit's master branch.
I propose to build an alpha version of AntUnit and push that to Ant's
lib/optional - and then monitor Jenkins for a whi
On 2018-06-03, Jaikiran Pai wrote:
> I missed this mail previously. Comments inline.
>>> Hi
>>> while reviewing some changes I realized DefaultInputHandler and
>>> SecureInputHandler may create unexpected outcomes if System.in or
>>> System.console() signal an end-of-stream and thus readLine/rea
On 2018-06-01, Gintautas Grigelionis wrote:
> thanks for reviewing this. I missed the fact that filesets had a similar
> attribute.
> Hope everything is consistent now.
What I meant with
>> you should probably check and document how the new followlinks attribute
>> interacts with fileset's follo
Hi Gintas
you should probably check and document how the new followlinks attribute
interacts with fileset's followsymlinks attribute.
Please add something to WHATSNEW.
Some additional notes inline.
On 2018-05-23, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/35a84fea/manual/Types/s
On 2018-05-21, wrote:
> --
> diff --git
> a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
> b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java
> @@ -97,7 +98,7 @@ public c
On 2018-05-20, Gintautas Grigelionis wrote:
> 2018-05-20 19:52 GMT+02:00 Stefan Bodewig :
>>> Hi all
>>> while running all tests locally I saw dependeset-test is failing, they
>>> are also failing on Jenkins.
>> Found it
>> https://github.com
On 2018-05-20, Gintautas Grigelionis wrote:
> This time, I tried to start a discussion first, and I got no response.
> There were attempts to modernize the codebase about a year ago. AFAICS
> there was no discussion then.
True. I for one didn't expect you to try weeding out all deprecated APIs
an
On 2018-05-20, Stefan Bodewig wrote:
> Hi all
> while running all tests locally I saw dependeset-test is failing, they
> are also failing on Jenkins. The last known good revision is
> 0020d1a16ba4207289d2380dc6981c85455b617f
> Is anybody already looking into this?
Found it
htt
Hi all
while running all tests locally I saw dependeset-test is failing, they
are also failing on Jenkins. The last known good revision is
0020d1a16ba4207289d2380dc6981c85455b617f
Is anybody already looking into this?
Stefan
-
On 2018-05-20, Gintautas Grigelionis wrote:
> 2018-05-18 16:51 GMT+02:00 Stefan Bodewig :
>> On 2018-05-18, Gintautas Grigelionis wrote:
>>> I believe that Streams API can at least implement the logic run by an
>>> original Enumeration in a more concise way, or prov
On 2018-05-18, Gintautas Grigelionis wrote:
> I believe that Streams API can at least implement the logic run by an
> original Enumeration in a more concise way, or provide more powerful idioms.
> That IMO makes it worth the while to investigate the Streams alternatives.
I agree to do that as soo
On 2018-05-03, Gintautas Grigelionis wrote:
> 2018-05-03 11:06 GMT+02:00 Stefan Bodewig :
>> I'm still not sure I understand which benefit you see by retrofitting
>> tests that have been written before @Parameterized was invented. They do
>> contain way too many asser
On 2018-04-30, Gintautas Grigelionis wrote:
> 2018-04-30 13:13 GMT+00:00 Stefan Bodewig :
>> On 2018-04-30, Gintautas Grigelionis wrote:
>>> the overarching goal, however, is to reduce verbosity, because
>>> verbosity makes it easier to hide mistakes.
>> Thi
On 2018-04-30, Gintautas Grigelionis wrote:
> I do realize that some changes might be a subject for discussion;
Gintas, please try to see what the others are saying. Most of the
changes are changes that nobody of those who've spoken up consider
improvements at all - apart from yourself. The outco
On 2018-04-30, Jaikiran Pai wrote:
> Changes like these are random personal preferences.
Right.
> The fact that these are being done even after the mail discussions we
> recently had, indicates that the request to not do such changes have
> been ignored. This is going down the route of a being s
On 2018-04-30, Gintautas Grigelionis wrote:
> My apologies for offending anyone; just one last silly question: why
> uniformity is not a requirement?
Who's uniformity do you pick? There are so many choices that only depend
on taste.
assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many s
On 2018-04-22, Gintautas Grigelionis wrote:
> I wish we could replace fetch.xml with an Ivy equivalent :-)
Using that would be against the very spirit of Gump :-)
The spirit of Gump would force Hamcrest 2.x upon Ant, so thought it
already did.
Stefan
---
On 2018-04-22, Gintautas Grigelionis wrote:
> Hmm... are you sure that Gump has hamcrest-library?
No, you are correct. I was under the impression it was using Hamcrest
2.x while it was not - Hamcrest 2.x only contains a single jar and if I
had looked close enough I would have seen the Matchers cl
Hi
when Apache Gump builds Ant it builds it against Hamcrest 2.x which used
to work fine as long as we didn't use many matchers. It looks as if one
of the breaking changes introduced with Hamcrest 2.x is the removal of
the Matchers class. See
http://vmgump-vm3.apache.org/ant/dist-ant/gump_work/bu
On 2018-04-20, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/5f4c43dd/src/main/org/apache/tools/ant/taskdefs/email/Message.java
> --
> diff --git a/src/main/org/apache/tools/ant/taskdefs/email/Message.java
> b/src/mai
On 2018-04-19, Jaikiran Pai wrote:
> In context of this[1] and many similar questions/confusion previously,
> I am wondering if our "ant -version" output should even include, a
> line in the output, the location which is used as ANT_HOME?
I'd prefer -diagnostics for that.
Stefan
---
On 2018-04-06, Gintautas Grigelionis wrote:
> The code sure looks scary, but the change really simple: remove
> extraneous labels on break/continue. I will double-check whether the
> labels still provide some useful hints to Java compiler.
Finally did so as well by now. Looks good, thanks.
Stef
there with diff smaller than several 1000 lines, I'd
appreciate that. :-)
> 2018-04-15 9:59 GMT+00:00 Stefan Bodewig :
>> IIRC the fallback would be to use the current working directory instead
>> of the "root" property if the former is not set. We can eas
201 - 300 of 4027 matches
Mail list logo
