Issue with docker setup

2021-06-27 Thread Sridhar K
... done Starting atlas-kafka ... done Starting atlas-hadoop ... done Starting atlas-hive... done ERROR: for atlas-hbase Container "3879a8299b65" is unhealthy. ERROR: Encountered errors while bringing up the project. Any suggestions? Regards, Sridhar K

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
> On Oct. 22, 2019, 6:31 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 123 (patched) > > <https://reviews.apache.org/r/71619/diff/7/?file=2169829#file2169829line123> > > > > I am not the right person

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > <https://reviews.apache.org/r/71619/diff/8/?file=2169830#file2169830line203> > > > > Instead of modifying addons/models/-A

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > <https://reviews.apache.org/r/71619/diff/8/?file=2169830#file2169830line203> > > > > Instead of modifying addons/models/-A

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
) <https://reviews.apache.org/r/71619/#comment306009> Instead of modifying addons/models/-Area0/0010-base_model.json, can you add this change in addons/models/-Area0/0011-base_model.json - Sridhar K On Oct. 22, 2019, 8:04 p.m., Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
ent305999> I am wondering if we should have a first class entity called "User" defined in base model and you have ml_user extend from it. what do you say? - Sridhar K On Oct. 22, 2019, 6:17 p.m., Na Li wrote: > > --

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Sridhar K
have names ending with "*Time" for consistency. - Sridhar K On Oct. 22, 2019, 3:42 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 71500: ATLAS-3414: Include metastore catalog name in hive database name and qualifiedName

2019-09-18 Thread Sridhar K
of Database Entitiy. Is there a reason why we did not do this in this version? - Sridhar K On Sept. 18, 2019, 5:41 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 71470: ATLAS-3378: Update JanusGraph to 0.4.0

2019-09-11 Thread Sridhar K
am wondering if have any simple queries done with functionality that use rinkerpop. - Sridhar K On Sept. 11, 2019, 7:20 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 71319: ATLAS-3380: Regression: After moving a table to a different database , db attribute in the table entity still points to the old db.

2019-08-19 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71319/#review217303 --- Ship it! Ship It! - Sridhar K On Aug. 19, 2019, 9:58 p.m

Re: Review Request 71294: ATLAS-3374: fix for incorrect basic/quick search results

2019-08-15 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71294/#review217220 --- Ship it! Ship It! - Sridhar K On Aug. 15, 2019, 9:48 a.m

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-18 Thread Sridhar K
> On July 18, 2019, 8:10 a.m., Sridhar K wrote: > > Ship It! Thanks for fixing it. - Sridhar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71089/#rev

Re: Review Request 71089: ATLAS-3338: avoid repeated calls to get index-field name during startup

2019-07-18 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71089/#review216713 --- Ship it! Ship It! - Sridhar K On July 17, 2019, 6:45 a.m

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sridhar K
ws.apache.org/r/71042/ > --- > > (Updated July 10, 2019, 8:11 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-3321 >

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sridhar K
> On July 10, 2019, 5:55 a.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use th

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sridhar K
> On July 10, 2019, 5:55 a.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use th

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Sridhar K
is changed. This needs some kind of design exercise. Can we please have a . meeting for it. - Sridhar K On July 9, 2019, 11:53 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 71006: [ATLAS-3313] Enhance Atlas server to process notifications from multiple Kafka topics

2019-07-08 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71006/#review216439 --- - Sridhar K On July 8, 2019, 1:26 p.m., Saqeeb Shaikh wrote

Re: Review Request 70930: ATLAS-3297: cache added/update entities in request-context, for use in entity-change listeners

2019-06-27 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70930/#review216200 --- Ship it! Ship It! - Sridhar K On June 22, 2019, 6:57 p.m

Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas due to ATLAS-3246 (Free-text search)

2019-06-14 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70840/#review215902 --- Ship it! Ship It! - Sridhar K On June 13, 2019, 9:08 p.m

Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas due to ATLAS-3246 (Free-text search)

2019-06-12 Thread Sridhar K
g some thing? - Sridhar K On June 12, 2019, 9:04 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-07 Thread Sridhar K
> On June 7, 2019, 1:55 p.m., Sridhar K wrote: > > intg/src/main/java/org/apache/atlas/ApplicationProperties.java > > Lines 52 (patched) > > <https://reviews.apache.org/r/70789/diff/2-3/?file=2147960#file2147960line52> > > > > It is confusing herewh

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-07 Thread Sridhar K
/ApplicationProperties.java Lines 52 (patched) <https://reviews.apache.org/r/70789/#comment302556> It is confusing herewhy two properties? - Sridhar K On June 7, 2019, 8 a.m., Madhan Neethiraj

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-06 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215726 --- Ship it! Ship It! - Sridhar K On June 6, 2019, 8:18 p.m

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-06 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215724 --- Ship it! Ship It! - Sridhar K On June 6, 2019, 8:18 p.m

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-06 Thread Sridhar K
> On June 6, 2019, 4:50 p.m., Sridhar K wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java > > Lines 27 (patched) > > <https://reviews.apache.org/r/70789/diff/1/?file=2147935#file2147935line27> > > > >

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

2019-06-06 Thread Sridhar K
ed) <https://reviews.apache.org/r/70789/#comment302529> searche ==> searches. - Sridhar K On June 6, 2019, 7:41 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically

Re: Review Request 70606: ATLAS-2901: Change classification name rule - Support multiple languages (unicode) and do not allow dot mark

2019-05-30 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70606/#review215605 --- Ship it! Ship It! - Sridhar K On May 21, 2019, 12:06 a.m

Re: Review Request 70701: ATLAS-3221: Refactor Impala integration code

2019-05-22 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70701/#review215480 --- Ship it! Ship It! - Sridhar K On May 22, 2019, 8:54 p.m

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

2019-05-22 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/#review215475 --- Ship it! Ship It! - Sridhar K On May 22, 2019, 5:36 p.m

Re: Review Request 70600: Adding the model files for Spark

2019-05-15 Thread Sridhar K
pes prefered. addons/models/1000-Hadoop/1090-spark_model.json Lines 359 (patched) <https://reviews.apache.org/r/70600/#comment301952> I am assuming that there will be relationships expressing lineage from hive to spark tables and vice versa? - Sridhar K On May 15, 2019, 7:39 p.m

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-08 Thread Sridhar K
> On May 9, 2019, 12:32 a.m., Sarath Subramanian wrote: > > Ship It! Let us hold on ship it. I need some clarity on this? - Sridhar --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-08 Thread Sridhar K
ns/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java Lines 189 (patched) <https://reviews.apache.org/r/70512/#comment301659> Can we move these three lines into one method? On a side note, why do we even maintain a wal file, when you delete the wal file immediately afte

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-08 Thread Sridhar K
We have CREATEVIEW. But, not VIEW type in ImpalaVertexType. Is that right? - Sridhar K On May 8, 2019, 9:36 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-08 Thread Sridhar K
ns/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java Lines 189 (patched) <https://reviews.apache.org/r/70512/#comment301659> Can we move these three lines into one method? On a side note, why do we even maintain a wal file, when you delete the wal file immediately afte

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-08 Thread Sridhar K
ns/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java Lines 189 (patched) <https://reviews.apache.org/r/70512/#comment301659> Can we move these three lines into one method? On a side note, why do we even maintain a wal file, when you delete the wal file immediately afte

Re: Review Request 70599: Import Service: Improvement to Handle Importing to Existing Entity

2019-05-08 Thread Sridhar K
Lines 41 (patched) <https://reviews.apache.org/r/70599/#comment301558> I understand what you are doing this for? But, do we have to replace the existing id? Why not keep using the existing id? - Sridhar K On May 8, 2019, 3:10 p.m., Ashutosh Mestry

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K
(patched) <https://reviews.apache.org/r/70605/#comment301578> Thanks for moving it to right file. - Sridhar K On May 7, 2019, 6:35 p.m., Le Ma wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K
(patched) <https://reviews.apache.org/r/70605/#comment301577> Too generic name. Can we get a btter name here. I suggest execTime. Or is it one of those name consistency issue? - Sridhar K On May 7, 2019, 6:35 p.m., Le Ma

Re: Review Request 70605: ATLAS-3197 Add QueryText for hive_table and hive_db

2019-05-07 Thread Sridhar K
I am talking about is "upgrade scenario". - Sridhar K On May 7, 2019, 6:35 p.m., Le Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 70600: Adding the model files for Spark

2019-05-07 Thread Sridhar K
) <https://reviews.apache.org/r/70600/#comment301525> I am assuming that we are going to reconsider these models. Especially, there is a possibility of these objects are represented as hive or habase objects in Atlas already. - Sridhar K On May 7, 2019, 8:01 p.m., Aadarsh Jajodia

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

2019-05-06 Thread Sridhar K
ariable? Use the same variable as above. addons/impala-bridge/pom.xml Lines 449 (patched) <https://reviews.apache.org/r/70512/#comment301478> Please move to variable. - Sridhar K On May 4, 2019, 9:23

Re: Review Request 70588: ATLAS-3188: Regression: Simple insert queries are being captured in ATLAS_HOOK topic

2019-05-03 Thread Sridhar K
g/r/70588/#comment301425> same here. - Sridhar K On May 3, 2019, 4:36 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re