Re: Review Request 73257: Add model types for Google cloud storage

2021-03-31 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/ --- (Updated March 31, 2021, 7:07 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-31 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/#review222755 --- Ship it! Ship It! - Sarath Subramanian On March 30, 2021,

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-31 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/#review222752 --- addons/models/3000-Cloud/3060-gcp_typedefs.json Lines 8

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/#review222743 --- Ship it! Ship It! - Madhan Neethiraj On March 31, 2021,

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Sidharth Mishra
> On March 30, 2021, 10:45 p.m., Madhan Neethiraj wrote: > > addons/models/3000-Cloud/3060-gcp_typedefs.json > > Lines 129 (patched) > > > > > > Please review if use of an enum is feasible here. This mainly

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/ --- (Updated March 31, 2021, 12:09 a.m.) Review request for atlas, Ashutosh

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/#review222741 --- addons/models/3000-Cloud/3060-gcp_typedefs.json Lines 32

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/ --- (Updated March 30, 2021, 10:28 p.m.) Review request for atlas, Ashutosh

Review Request 73257: Add model types for Google cloud storage

2021-03-25 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/ --- Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, and