Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222904 --- Ship it! Ship It! - Dharshana MK On April 29, 2021, 4:09

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 29, 2021, 4:09 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 29, 2021, 4:07 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222903 --- Ship it! Ship It! - Sarath Subramanian On April 28, 2021,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK
> On April 28, 2021, 1:02 p.m., Dharshana MK wrote: > > Thanks Sidharth Mishra > > We can obtain the qualified name from the input but getting the guid is > > tricky > > Can we also pass the guid of the term created in the response "remarks"? > > > > GET /v2/glossary > > POST /v2/glossary > >

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222901 --- Ship it! Ship It! - Dharshana MK On April 29, 2021, 1:36

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 29, 2021, 1:36 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
> On April 28, 2021, 1:02 p.m., Dharshana MK wrote: > > Thanks Sidharth Mishra > > We can obtain the qualified name from the input but getting the guid is > > tricky > > Can we also pass the guid of the term created in the response "remarks"? > > > > GET /v2/glossary > > POST /v2/glossary > >

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 29, 2021, 1:35 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra
> On April 28, 2021, 4:37 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > > Lines 1186 (patched) > > > > > > this method is unused, please review

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222895 --- Thanks Sidharth Mishra We can obtain the qualified name from the

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222894 --- Thanks Sidharth Mishra We can obtain the qualified name from the

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222891 --- Fix it, then Ship it!

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 28, 2021, 1:30 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
> On April 27, 2021, 10:42 a.m., Dharshana MK wrote: > > Based on the description I have a feed back. > > Only the termGuid in the relationship is updated. Once a relationship is > > created we expect the relationGuid also to be updated to keep it consistent > > with the previous response

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 28, 2021, 1:02 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 28, 2021, 12:01 a.m.) Review request for atlas, Ashutosh

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 28, 2021, midnight) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
> On April 27, 2021, 10:42 a.m., Dharshana MK wrote: > > Based on the description I have a feed back. > > Only the termGuid in the relationship is updated. Once a relationship is > > created we expect the relationGuid also to be updated to keep it consistent > > with the previous response

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222887 ---

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 27, 2021, 9:20 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 27, 2021, 9:20 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- (Updated April 27, 2021, 9:06 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-27 Thread Dharshana MK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/#review222876 --- Based on the description I have a feed back. Only the termGuid in

Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-26 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73304/ --- Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and