Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59799/
---

(Updated June 26, 2017, 8:37 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch includes changes to handle review comments from Madhan.

* Tested the patch from hive hook and hive entities are getting created in 
Atlas.


Repository: atlas


Description
---

This patch include changes that implements kafka new-consumer api for 
kafkaConsumer for Atlas Notification System.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties 5e59528b 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 16c0eb2c 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
8bd31fde 
  
notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
 95858278 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
 d4d78de9 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 a99cb105 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
ad7d93e2 
  
notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java
 2126be69 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
a8100290 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 13f2f0ba 
  typesystem/src/test/resources/atlas-application.properties c4ce5eaa 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 2f8245d2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 
ac3b5381 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 18fd2ee2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
 bdb60a2f 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
b59d3ee5 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 310b2e3e 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 98a7abcf 


Diff: https://reviews.apache.org/r/59799/diff/5/

Changes: https://reviews.apache.org/r/59799/diff/4-5/


Testing
---

Tested Kafka consumer on local embeded kafka /zookeeper env.
Tested Atlas Hive hook notifications.
Excecute Quick Start script.

Due to change in kafkaconsumer api the current notification related UT/IT's 
need to changed, i have not included this change in this patch but will 
included it shortly.


Thanks,

Nixon Rodrigues

Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59799/
---

(Updated June 26, 2017, 8:37 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-1766
https://issues.apache.org/jira/browse/ATLAS-1766


Repository: atlas


Description
---

This patch include changes that implements kafka new-consumer api for 
kafkaConsumer for Atlas Notification System.


Diffs
-

  distro/src/conf/atlas-application.properties 5e59528b 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 16c0eb2c 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
8bd31fde 
  
notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
 95858278 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java
 d4d78de9 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 a99cb105 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
ad7d93e2 
  
notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java
 2126be69 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
a8100290 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 13f2f0ba 
  typesystem/src/test/resources/atlas-application.properties c4ce5eaa 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 2f8245d2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 
ac3b5381 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 18fd2ee2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
 bdb60a2f 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
b59d3ee5 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 310b2e3e 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 98a7abcf 


Diff: https://reviews.apache.org/r/59799/diff/5/


Testing
---

Tested Kafka consumer on local embeded kafka /zookeeper env.
Tested Atlas Hive hook notifications.
Excecute Quick Start script.

Due to change in kafkaconsumer api the current notification related UT/IT's 
need to changed, i have not included this change in this patch but will 
included it shortly.


Thanks,

Nixon Rodrigues

Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/
---

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-1908
https://issues.apache.org/jira/browse/ATLAS-1908


Repository: atlas


Description
---

This patch handles old kafka consumer configs values to be added as new configs 
if new configs are not present , so that Kafka consumer starts gracefully even 
if new configs are not added explicitly.

eg. atlas.kafka.auto.commit.enable=false to atlas.kafka.enable.auto.commit=false
atlas.kafka.auto.offset.reset=smallest to 
atlas.kafka.auto.offset.reset=earliest
atlas.kafka.session.timeout.ms=3

Also added poll.timeout.ms in configs so kafka consumer can be 
configurable.This involve change in AtlasKafkaConsumer receive interface.


Diffs
-

  distro/src/conf/atlas-application.properties 474f253 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
9c15243 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
366c8a7 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 22e40f9 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
70059cb 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
c791d43 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 8324b57 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 9e5b864 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 650ca0a 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
c036cfa 


Diff: https://reviews.apache.org/r/60597/diff/1/


Testing
---

Executed UT/IT's using mvn clean install.
Tested KafkaConsumer with Hive Hook by creating table in hive.
Atlas starts gracefully and Kafka consumer is up without error when new 
properties are not added.


Thanks,

Nixon Rodrigues

Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/1/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60534: UI - Render HTML element based on attribute data-type while assigning Tag to entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60534/#review179548
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 29, 2017, 10:56 a.m., Kalyani Kashikar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60534/
> ---
> 
> (Updated June 29, 2017, 10:56 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1897
> https://issues.apache.org/jira/browse/ATLAS-1897
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While assigning tag to entity, It allows inputs based on attribute data-type.
> 
> 
> Note -This patch is dependent on ATLAS-1894.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/tag/addTagModalView.js 7eaf23c 
> 
> 
> Diff: https://reviews.apache.org/r/60534/diff/1/
> 
> 
> Testing
> ---
> 
> Validation for all input field has been verified.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 4, 2017, 10:34 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes setHadoopJWTCookie method in AtlasBaseClient, this method 
can be used to update the fresh hadoopJWT cookie when old cookie is expired 
instead creating the new object of AtlasClient.

Tested quickStart script with this AtlasClient api methods.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/2/

Changes: https://reviews.apache.org/r/60627/diff/1-2/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 5, 2017, 2:37 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes change in getting secureClient when hadoopJWtCookie is set.

Tested this changes with Basic Auth with TLS, and also when hadoopJWtCookie is 
set when Atlas is TLS enabled.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 


Diff: https://reviews.apache.org/r/60627/diff/3/

Changes: https://reviews.apache.org/r/60627/diff/2-3/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/
---

(Updated July 6, 2017, 8:12 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
Sarath Subramanian, and Hemanth Yamijala.


Changes
---

This patch includes changes to handle review comments from David & Apoorv.


Bugs: ATLAS-1906
https://issues.apache.org/jira/browse/ATLAS-1906


Repository: atlas


Description
---

This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as 
authentication header for Atlas.

Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will 
overload the Atlas Client constructor to support Knox SSO cookie by adding 
below constructor.

AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
AtlasClient(atlasURL, Cookie);


Diffs (updated)
-

  client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
  client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
  client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 


Diff: https://reviews.apache.org/r/60627/diff/4/

Changes: https://reviews.apache.org/r/60627/diff/3-4/


Testing
---

Unit test cases are running fine using mvn clean install.
Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.

AltasClient(atlasUrl, new Cookie("hadoop-jwt" , 
"eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");


Thanks,

Nixon Rodrigues

Re: Review Request 60794: Add Cross Origin [CORS] headers for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60794/#review180295
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 12, 2017, 8:48 a.m., Ruchi Solani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60794/
> ---
> 
> (Updated July 12, 2017, 8:48 a.m.)
> 
> 
> Review request for atlas and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1896
> https://issues.apache.org/jira/browse/ATLAS-1896
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties.
> 
> Properties for headers.
> 
> atlas.headers.Access-Control-Allow-Origin=*
> atlas.headers.Access-Control-Allow-Methods=GET,OPTIONS,HEAD,PUT,POST
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties 474f253 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  25aede3 
> 
> 
> Diff: https://reviews.apache.org/r/60794/diff/1/
> 
> 
> Testing
> ---
> 
> Adding header properties and tested by API, All Unit test cases are tested.
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>

Re: Review Request 60816: Addresses Use of KafkaConsumer in Thread by Implementing Kafka's ShutdownableThread

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60816/#review180404
---


Ship it!




Changes looks good to me. I have validated this change and entities are 
consumed from kafka and atlas entitites are created.
Shutdown exception is also resolved.

- Nixon Rodrigues


On July 13, 2017, 5:07 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60816/
> ---
> 
> (Updated July 13, 2017, 5:07 a.m.)
> 
> 
> Review request for atlas, Ayub Pathan, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1944
> https://issues.apache.org/jira/browse/ATLAS-1944
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Based on discussion with Kafka team member(s), turns out that _KafkaConsumer_ 
> is not thread-safe. This causes probelem during service shutdown as noted in 
> the ATLAS-1944.
> 
> **Solution**
> Kafa provides _ShutdownableThread_ which implements thread-safe way for doing 
> shutdown to _KafaConsumer_ as used in _AtlasKafkaConsumer_.
> 
> **References**
> - 
> [ShutdownableThread.java](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/util/ShutdownableThread.java)
> - [Usage sample]( 
> https://github.com/apache/kafka/blob/cb0325d484b957432048dd29419f0fa59c5f132d/core/src/main/scala/kafka/log/LogCleaner.scala#L138)
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  9e5b864e 
> 
> 
> Diff: https://reviews.apache.org/r/60816/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Executed exisiting tests.
> 
> **Functional tests**
> - Created entities via Hive.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/
---

(Updated July 14, 2017, 9:52 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Handled review comments from Sarath and Ashutosh.


Bugs: ATLAS-1908
https://issues.apache.org/jira/browse/ATLAS-1908


Repository: atlas


Description
---

This patch handles old kafka consumer configs values to be added as new configs 
if new configs are not present , so that Kafka consumer starts gracefully even 
if new configs are not added explicitly.

eg. atlas.kafka.auto.commit.enable=false to atlas.kafka.enable.auto.commit=false
atlas.kafka.auto.offset.reset=smallest to 
atlas.kafka.auto.offset.reset=earliest
atlas.kafka.session.timeout.ms=3

Also added poll.timeout.ms in configs so kafka consumer can be 
configurable.This involve change in AtlasKafkaConsumer receive interface.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties c3213df 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
9c15243 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
366c8a7 
  
notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
 22e40f9 
  notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
70059cb 
  notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
c791d43 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
 8324b57 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 0dea0e2 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
 650ca0a 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
c036cfa 


Diff: https://reviews.apache.org/r/60597/diff/2/

Changes: https://reviews.apache.org/r/60597/diff/1-2/


Testing
---

Executed UT/IT's using mvn clean install.
Tested KafkaConsumer with Hive Hook by creating table in hive.
Atlas starts gracefully and Kafka consumer is up without error when new 
properties are not added.


Thanks,

Nixon Rodrigues

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

> On July 13, 2017, 5:03 a.m., Ashutosh Mestry wrote:
> > distro/src/conf/atlas-application.properties
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768416#file1768416line82>
> >
> > Should this be 1000 ms? My thinking is 100 ms will be too short.

Yes 100 ms is small, i have changed it 1000 ms, some tuning might be required 
in that case this property atlas.kafka.poll.timeout.ms can be changed 
accordingly


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/#review180395
---


On July 14, 2017, 9:52 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60597/
> ---
> 
> (Updated July 14, 2017, 9:52 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1908
> https://issues.apache.org/jira/browse/ATLAS-1908
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles old kafka consumer configs values to be added as new 
> configs if new configs are not present , so that Kafka consumer starts 
> gracefully even if new configs are not added explicitly.
> 
> eg. atlas.kafka.auto.commit.enable=false to 
> atlas.kafka.enable.auto.commit=false
> atlas.kafka.auto.offset.reset=smallest to 
> atlas.kafka.auto.offset.reset=earliest
> atlas.kafka.session.timeout.ms=3
> 
> Also added poll.timeout.ms in configs so kafka consumer can be 
> configurable.This involve change in AtlasKafkaConsumer receive interface.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties c3213df 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> 9c15243 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 366c8a7 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  22e40f9 
>   notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
> 70059cb 
>   
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
> c791d43 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  8324b57 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0dea0e2 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  650ca0a 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> c036cfa 
> 
> 
> Diff: https://reviews.apache.org/r/60597/diff/2/
> 
> 
> Testing
> ---
> 
> Executed UT/IT's using mvn clean install.
> Tested KafkaConsumer with Hive Hook by creating table in hive.
> Atlas starts gracefully and Kafka consumer is up without error when new 
> properties are not added.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

[Nixon Rodrigues]

> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
> > Line 126 (original), 127 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768418#file1768418line127>
> >
> > can the new kafka consumer handle both "smallest" and "earliest" value 
> > for auto.offset.reset?

the new kafka consumer can handle only earliest, smallest causes exception 
while initialization of kafkaconsumer. so set earliet as default which was set 
earlier.


> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
> > Lines 133 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768418#file1768418line133>
> >
> > should this be subsetConfiguration.getLong("session.timeout.ms", 3000)?

Tried your suggestion but there was a parse error (below). The kafka config is 
expecting the long value in string format

 272 org.apache.kafka.common.config.ConfigException: Invalid value 3 
for configuration session.timeout.ms: Expected value to be an number.


> On July 13, 2017, 5:23 p.m., Sarath Subramanian wrote:
> > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java
> > Line 102 (original), 102 (patched)
> > <https://reviews.apache.org/r/60597/diff/1/?file=1768420#file1768420line102>
> >
> > why reduced poll timeout to 100L from 1000?

The return output of from poll method is mocked, so poll timeout will not 
matter as such, so set the timeout it less value to reduce execution time.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60597/#review180445
---


On July 14, 2017, 9:52 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60597/
> ---
> 
> (Updated July 14, 2017, 9:52 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1908
> https://issues.apache.org/jira/browse/ATLAS-1908
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles old kafka consumer configs values to be added as new 
> configs if new configs are not present , so that Kafka consumer starts 
> gracefully even if new configs are not added explicitly.
> 
> eg. atlas.kafka.auto.commit.enable=false to 
> atlas.kafka.enable.auto.commit=false
> atlas.kafka.auto.offset.reset=smallest to 
> atlas.kafka.auto.offset.reset=earliest
> atlas.kafka.session.timeout.ms=3
> 
> Also added poll.timeout.ms in configs so kafka consumer can be 
> configurable.This involve change in AtlasKafkaConsumer receive interface.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties c3213df 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> 9c15243 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 366c8a7 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java
>  22e40f9 
>   notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java 
> 70059cb 
>   
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java 
> c791d43 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java
>  8324b57 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0dea0e2 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  650ca0a 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> c036cfa 
> 
> 
> Diff: https://reviews.apache.org/r/60597/diff/2/
> 
> 
> Testing
> ---
> 
> Executed UT/IT's using mvn clean install.
> Tested KafkaConsumer with Hive Hook by creating table in hive.
> Atlas starts gracefully and Kafka consumer is up without error when new 
> properties are not added.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Review Request 60868: ATLAS-1940 :- Fix to remove duplicate type which causes Atlas server to fails on startup.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60868/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-1940
https://issues.apache.org/jira/browse/ATLAS-1940


Repository: atlas


Description
---

Problem:- Atlas server fails to initialize types on startup from graph store 
due to duplicate type registered.

Fix :- Added removeDuplicateTypeIfAny method which is called init of typeDef 
Store to remove duplicate types if any.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 9d9c59d 


Diff: https://reviews.apache.org/r/60868/diff/1/


Testing
---

Exiting UT and IT are running fine.
Quick Start script running fine.
Created new tags & types. 
Also tried creating duplicate type from rest client and UI which failed to 
create duplicates.


Thanks,

Nixon Rodrigues

Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61040/#review181192
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61040/
> ---
> 
> (Updated July 24, 2017, 3:50 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1981
> https://issues.apache.org/jira/browse/ATLAS-1981
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated search to use cached type-query string to improve performance
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b 
>   
> repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
>  dfb2ee27 
> 
> 
> Diff: https://reviews.apache.org/r/61040/diff/2/
> 
> 
> Testing
> ---
> 
> verified that the search returns correct results after this enhancement
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61040/#review181193
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61040/
> ---
> 
> (Updated July 24, 2017, 3:50 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1981
> https://issues.apache.org/jira/browse/ATLAS-1981
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated search to use cached type-query string to improve performance
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b 
>   
> repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java
>  dfb2ee27 
> 
> 
> Diff: https://reviews.apache.org/r/61040/diff/2/
> 
> 
> Testing
> ---
> 
> verified that the search returns correct results after this enhancement
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 61103: ATLAS-1985 :- Fix URLEncoding while redirecting to Active instance in HA.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/
---

Review request for atlas, Apoorv Naik, Ashutosh Kelkar, Madhan Neethiraj, and 
Sarath Subramanian.


Repository: atlas


Description
---

This patch provide fix for url-encoding in Activeserver Filter where url was 
encoded wrongly with HtmlQuoting.quoteHtmlChars method which is primarily meant 
for htmltext encoding.

Instead of using HtmlQuoting.quoteHtmlChars method used URLEncode.encode method 
to encode the URL.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
29d829f 
  webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java 
3396072 


Diff: https://reviews.apache.org/r/61103/diff/1/


Testing
---

Tested api redirected from passive to active
eg  /api/atlas/discovery/search/fulltext?limit=100&query=hive_table API is 
redirection to active with
/api/atlas/discovery/search/fulltext?limit%3D100%26query%3Dhive_table where 
querystring is encoded.

Existing UT and IT's passing.
Added new UT in ActiveServerFilterTest


Thanks,

Nixon Rodrigues

Re: Is this a valid issue? ATLAS-1903

[Nixon Rodrigues]

Hi Peter,

Thanks for filing this issue, yes it's an issue, please go ahead and
investigate the issue.
Assign jira in your name.

Nixon



On Fri, Jul 28, 2017 at 2:52 PM, Peter Gergo Barna 
wrote:

> Hi all,
> I have noticed while testing in my local env, that after Solr is stopped,
> Atlas still returns HTTP 200 OK for a type update,
> although, the update was not successful, and from the logs it can be seen
> that the problem is Solr being unavailable.
>
> I have created a JIRA issue about it: https://issues.apache.org/
> jira/browse/ATLAS-1903
> My question is, is this a valid issue, I mean is this a realistic scenario
> in a prod env?
> If it is, then I shell make an attempt to fix it.
>
> Thanks,
> Peter Gergo Barna
>

Re: Cassandra support for Atlas v1.0

[Nixon Rodrigues]

+1 for option #3

Cassandra as a store is good option for development purpose.

Nixon





On Fri, Apr 27, 2018, 1:07 AM Madhan Neethiraj  wrote:

> David - I agree on option #3 for 1.0 release.
>
> Thanks,
> Madhan
>
>
>
>
> On 4/26/18, 9:14 AM, "David Radley"  wrote:
>
> Hi there,
> We had a meeting to discuss how we would like to document the embedded
> Cassandra support in Atlas v1.0. We talked of 3 options :
>
> 1) Include it in the code base but do not document.
> 2) Document it as a tech preview
> 3) Document it in the same way as the embedded solr and hbase build.
> That
> means it will be document as being supported for development, but not
> in
> production.
>
> My preference is option 3). Are there any objections to this approach?
> many thanks, David.
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with
> number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
>
>
>
>

Re: Review Request 66976: ATLAS-2647: updated documentation with additional details on notification, hooks and basic search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66976/#review202550
---


Ship it!




Ship It!

- Nixon Rodrigues


On May 6, 2018, 5:52 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66976/
> ---
> 
> (Updated May 6, 2018, 5:52 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Ramesh Mani, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2647
> https://issues.apache.org/jira/browse/ATLAS-2647
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - updated documentation with additional details on notification, hooks
> - added screenshots for various basic search scenarios
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/images/add.gif 
> 1cb3dbf936e38b5c5efdc3e247a042eb1b1d23e9 
>   docs/src/site/resources/images/apache-incubator-logo.png 
> 81fb31ec7128939673f04d4748788ac4989c0d17 
>   docs/src/site/resources/images/apache-maven-project-2.png 
> 6c096ec0c7d50ecca14e76dd49b1fcb9382c3d07 
>   docs/src/site/resources/images/fix.gif 
> b7eb3dc44242af0aefef59f29411441b74815987 
>   docs/src/site/resources/images/icon_error_sml.gif 
> 12e9a01a930c8dfa20992254a9c2b19272d1d491 
>   docs/src/site/resources/images/icon_help_sml.gif 
> aaf20e6eea4148fe8fbb09bdf4595eb98334fff6 
>   docs/src/site/resources/images/icon_info_sml.gif 
> b776326703c341ce559f98f028bb92fe4c332a83 
>   docs/src/site/resources/images/icon_success_sml.gif 
> 0a195279b3f930efd5b4be22968615ca313cf8d0 
>   docs/src/site/resources/images/icon_warning_sml.gif 
> ac6ad6ada39ea693ac0500810196fe551833b2d0 
>   docs/src/site/resources/images/logos/build-by-maven-black.png 
> 919fd0f66a7f713920dd7422035db1c9d484351d 
>   docs/src/site/resources/images/logos/build-by-maven-white.png 
> 7d44c9c2e5742bdf8649ad282f83208f1da9b982 
>   docs/src/site/resources/images/profiles/pre-release.png 
> d448e850cd3f885844d0c28da7dddf4457e25300 
>   docs/src/site/resources/images/profiles/retired.png 
> f89f6a29c6b61beafd8d2f729085fbf1d17b0e86 
>   docs/src/site/resources/images/profiles/sandbox.png 
> f88b3626761f591fefcb7408ff290b4f48ebe0d9 
>   docs/src/site/resources/images/remove.gif 
> fc65631cad989e01ea73e3fc063ae37ff05310a0 
>   docs/src/site/resources/images/rss.png 
> a9850ee2cd5772d77d85b1e0cafb778713b4aa26 
>   docs/src/site/resources/images/twiki/search-basic-hive_column-PII.png 
> PRE-CREATION 
>   
> docs/src/site/resources/images/twiki/search-basic-hive_table-customers-or-provider.png
>  PRE-CREATION 
>   
> docs/src/site/resources/images/twiki/search-basic-hive_table-customers-owner_is_hive.png
>  PRE-CREATION 
>   docs/src/site/resources/images/twiki/search-basic-hive_table-customers.png 
> PRE-CREATION 
>   docs/src/site/resources/images/update.gif 
> b2a6d0bf63758c0374e27e1e73bc98b469b3173c 
>   docs/src/site/twiki/Architecture.twiki d0f1a0567 
>   docs/src/site/twiki/Bridge-Falcon.twiki  
>   docs/src/site/twiki/Bridge-HBase.twiki 7a5c908e8 
>   docs/src/site/twiki/Bridge-Hive.twiki 7c93ecd4f 
>   docs/src/site/twiki/Bridge-Kafka.twiki 7cdd548da 
>   docs/src/site/twiki/Bridge-Sqoop.twiki 480578bf3 
>   docs/src/site/twiki/Hook-HBase.twiki PRE-CREATION 
>   docs/src/site/twiki/Hook-Hive.twiki PRE-CREATION 
>   docs/src/site/twiki/Hook-Sqoop.twiki PRE-CREATION 
>   docs/src/site/twiki/Notification-Entity.twiki 9d883fc05 
>   docs/src/site/twiki/Notifications.twiki PRE-CREATION 
>   docs/src/site/twiki/Search-Basic.twiki 367b945a2 
>   docs/src/site/twiki/StormAtlasHook.twiki  
>   docs/src/site/twiki/index.twiki df7e7a3c7 
> 
> 
> Diff: https://reviews.apache.org/r/66976/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Apache Atlas 1.0 release preparation

[Nixon Rodrigues]

Madhan,

Thanks for the heads up for Atlas 1.0 release.

+1 for the release.


Best regards,

Nixon




On Wed, May 9, 2018, 6:13 AM Madhan Neethiraj  wrote:

> Atlas team,
>
>
>
> We have been busy adding multiple major features and improvements in
> master branch for months now. And it has been more than 3 months since
> Apache Atlas 1.0-alpha was released. It is time for GA release of Apache
> Atlas 1.0!
>
>
>
> Here is a short list of major features/updates:
>
>   - support for propagation of classifications along entity relationships
> – like lineage
>
>   - fine-grained metadata security, which enables access controls up to an
> entity instance level
>
>   - introduction of Glossary feature
>
>   - introduction of relationships as a first-class type
>
>   - replace use of Titan Graph DB with JanusGraph DB
>
>   - DSL rewrite, to replace use of Scala based implementation with Antlr
>
>   - introduction of V2 style notifications
>
>   - performance improvements in Atlas Hooks, by switching to use V2 style
> notifications
>
>   - significant updates in Atlas Web UI
>
>   - introduction of Atlas hook for HBase
>
>   - framework for Open Metadata & Governance (tech-preview)
>
>   - support for Cassandra and Elasticsearch (tech-preview)
>
>
>
> Here are the details of release activities, along with timelines for each:
>
>   - tentative date for the release will be next Friday, May-18-2018
>
>   - creation of release branch from current master: end of May-10 (PDT)
>
>   - send first release candidate for vote: end of May-12 (PDT)
>
>
>
> If you have any updates that needs to be in 1.0 release, please prioritize
> them to be committed before May-10.
>
>
>
> I volunteer to be the release manager for Apache Atlas 1.0 release.
>
>
>
> Regards,
>
> Madhan
>
>
>
>
>
>
>
>

Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2673
https://issues.apache.org/jira/browse/ATLAS-2673


Repository: atlas


Description
---

This patch handles decoding of encoded query string for DSL search.

Use case:-

DSL query :

/api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
fired on PASSIVE server redirects to ACTIVE server as

/api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
fails with

{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}


Diffs
-

  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 


Diff: https://reviews.apache.org/r/67085/diff/1/


Testing
---

Tested by accessing URL 
/api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
which redirects on active node now working properly.

And also on Active node.

Added few encode queryparam in ITs

Integration testcase working
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console

2018-05-11 10:39:16,828  
2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
2018-05-11 10:39:17,089  
2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
2018-05-11 10:39:17,351  
2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258


Thanks,

Nixon Rodrigues

Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2463
https://issues.apache.org/jira/browse/ATLAS-2463


Repository: atlas


Description
---

This patch adds documentation to Atlas authorization at entity level for simple 
authorizer.


Diffs
-

  docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
  docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
  docs/src/site/twiki/Configure-simple-authorizor.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 258dfbb7f 


Diff: https://reviews.apache.org/r/67114/diff/1/


Testing
---

Tested the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67114/
---

(Updated May 15, 2018, 12:22 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patches includes changes to fix typo error, changes and review comments by 
Nigel & David R.


Bugs: ATLAS-2463
https://issues.apache.org/jira/browse/ATLAS-2463


Repository: atlas


Description
---

This patch adds documentation to Atlas authorization at entity level for simple 
authorizer.


Diffs (updated)
-

  docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION 
  docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 
  docs/src/site/twiki/Configure-simple-authorizer.twiki PRE-CREATION 
  docs/src/site/twiki/index.twiki 258dfbb7f 


Diff: https://reviews.apache.org/r/67114/diff/2/

Changes: https://reviews.apache.org/r/67114/diff/1-2/


Testing
---

Tested the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

> On May 11, 2018, 1:54 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 116 (patched)
> > <https://reviews.apache.org/r/67085/diff/1/?file=2019898#file2019898line116>
> >
> > In ATLAS-2310, use of URLDecoder.decode() was replaced wito use 
> > UriUtils.encodeQuery() in ActiveServerFilter. Please review this patch 
> > https://reviews.apache.org/r/64538/.

In ATLAS-2310 the special characters in URL querystring were encoded using 
UriUtils.encodeQuery(), now in ATLAS-2673 this encoded queryString need to be 
decoded when it is read in DSL API.  This patch handles this fix.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review202937
-------


On May 11, 2018, 11 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 11, 2018, 11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/
---

(Updated May 16, 2018, 10:04 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch handles review comment from Madhan to use UriUtils.decode() for 
decoding since encoding in ActiveFilter is done from same API class.

Tested encoding query in browser and also tested the IT api calls status code.

127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10
 HTTP/1.1" 200 374 "-" "Java/1.8.0_172"
127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10
 HTTP/1.1" 200 66 "-" "Java/1.8.0_172"
127.0.0.1 - - [16/May/2018:06:44:14 +] "GET 
//localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10
 HTTP/1.1" 200 500 "-" "Java/1.8.0_172"


Bugs: ATLAS-2673
https://issues.apache.org/jira/browse/ATLAS-2673


Repository: atlas


Description
---

This patch handles decoding of encoded query string for DSL search.

Use case:-

DSL query :

/api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
fired on PASSIVE server redirects to ACTIVE server as

/api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
fails with

{
errorCode: "ATLAS-400-00-059",
errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 22 
type not found. Please refer to Atlas DSL grammar for more information"
}


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
  webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 


Diff: https://reviews.apache.org/r/67085/diff/2/

Changes: https://reviews.apache.org/r/67085/diff/1-2/


Testing
---

Tested by accessing URL 
/api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
which redirects on active node now working properly.

And also on Active node.

Added few encode queryparam in ITs

Integration testcase working
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console

2018-05-11 10:39:16,828  
2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
2018-05-11 10:39:17,089  
2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
2018-05-11 10:39:17,351  
2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258


Thanks,

Nixon Rodrigues

Re: Review Request 67085: ATLAS-2673: Decode query string for DSL search

[Nixon Rodrigues]

> On May 15, 2018, 1:46 p.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
> > Lines 116 (patched)
> > <https://reviews.apache.org/r/67085/diff/1/?file=2019898#file2019898line116>
> >
> > Nixon - sorry, my earlier comment was incorrect. What I meant to say 
> > was:
> >   ATLAS-2310 replaced use of URLDecoder.encode() with 
> > UriUtils.encodeQuery(). Perhaps the decoding should be done by 
> > corresponding UriUtils method - UriUtils.decode()?

Make sense to use same UriUtils class for decode the url. I have updated the 
patch on RB


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67085/#review203116
---


On May 16, 2018, 10:04 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67085/
> ---
> 
> (Updated May 16, 2018, 10:04 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2673
> https://issues.apache.org/jira/browse/ATLAS-2673
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles decoding of encoded query string for DSL search.
> 
> Use case:-
> 
> DSL query :
> 
> /api/atlas/v2/search/dsl?typeName=hive_table&query=name="weather2"
> fired on PASSIVE server redirects to ACTIVE server as
> 
> /api/atlas/v2/search/dsl?limit=25&offset=0&query=name=%2522weather2%2522&typeName=hive_table
> fails with
> 
> {
> errorCode: "ATLAS-400-00-059",
> errorMessage: "Invalid DSL query: `hive_table` name=%22weather2%22 | Reason: 
> DSL Semantic Error - weather2 type not found, DSL Semantic Error - weather2 
> type not found, DSL Semantic Error - 22 type not found, DSL Semantic Error - 
> 22 type not found. Please refer to Atlas DSL grammar for more information"
> }
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 0ca0ba748 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad3785935 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java ec340cfee 
> 
> 
> Diff: https://reviews.apache.org/r/67085/diff/2/
> 
> 
> Testing
> ---
> 
> Tested by accessing URL 
> /api/atlas/v2/search/dsl?typeName=Table&query=name="sales_fact" on passive 
> which redirects on active node now working properly.
> 
> And also on Active node.
> 
> Added few encode queryparam in ITs
> 
> Integration testcase working
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/388/console
> 
> 2018-05-11 10:39:16,828  
> 2018-05-11T10:39:16.566Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22Reporting%22&limit=10|200|262
> 2018-05-11 10:39:17,089  
> 2018-05-11T10:39:16.832Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=DB+where+name%3D%22encode_db_name%22&limit=10|200|257
> 2018-05-11 10:39:17,351  
> 2018-05-11T10:39:17.093Z|admin|127.0.0.1|GET|http://localhost:31000/api/atlas/v2/search/dsl?offset=0&query=Table+where+name%3D%2522sales_fact%2522&limit=10|200|258
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 67179: ATLAS-2697: V2 Notifications : "Propagated classification added" audit message is present instead of "classification added"

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67179/#review203318
---


Ship it!




Ship It!

- Nixon Rodrigues


On May 17, 2018, 6:22 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67179/
> ---
> 
> (Updated May 17, 2018, 6:22 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2697
> https://issues.apache.org/jira/browse/ATLAS-2697
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> With V2 notifications ,when tag is added to an entity , instead of 
> "classification added" audit , "Propagated classification added" audit 
> message is present.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  8344b70a2 
> 
> 
> Diff: https://reviews.apache.org/r/67179/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/418/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Review Request 67283: ATLAS-2718 :-Documentation for Atlas Ranger authorization.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67283/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Summary (updated)
-

ATLAS-2718 :-Documentation for Atlas Ranger authorization.


Bugs: ATLAS-2718
https://issues.apache.org/jira/browse/ATLAS-2718


Repository: atlas


Description (updated)
---

This patch includes documentation for Atlas Ranger authorization


Diffs (updated)
-

  docs/src/site/resources/images/twiki/policy-on-admin-service.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-entity-regx.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-entity.png PRE-CREATION 
  docs/src/site/resources/images/twiki/policy-on-types.png PRE-CREATION 
  docs/src/site/twiki/Atlas-Authorization-Model.twiki 4a6a7297d 
  docs/src/site/twiki/Atlas-Authorization-Ranger-Authorizer.twiki PRE-CREATION 
  docs/src/site/twiki/Atlas-Authorization-Simple-Authorizer.twiki 07753def3 
  docs/src/site/twiki/index.twiki 6cffcd756 


Diff: https://reviews.apache.org/r/67283/diff/1/


Testing (updated)
---

verified the documentation after running mvn site


Thanks,

Nixon Rodrigues

Re: [VOTE] Release Apache Atlas version 1.0.0

[Nixon Rodrigues]

*+1* for the release of candidate #0


   - Verified the signature and md5 hash keys
   - The build is going fine.
   - Tested Atlas with hbase-solr and berkeley-elasticsearch embedded
   profiles
   - Unit & Integration tests are passing
   - Rat check goes is good
   - Release tag is proper on git repo.
   - Quickstart script loads sample data correctly on UI
   - New Glossary UI looks good.
   - Terms can be associated with entities and category correctly from UI.
   - Propagated classifications are seen on UI correctly.
   - Relationships graph UI looks good.

Thanks Madhan for putting together Atlas 1.0.0 for voting.

Nixon


On Sun, May 27, 2018 at 7:29 AM, Madhan Neethiraj  wrote:

> Atlas team,
>
> Apache Atlas 1.0.0 release candidate #0 is now available for a vote within
> dev community. Links to the release artifacts are given below. Please
> review and vote.
>
> The vote will be open for at least 72 hours or until necessary votes are
> reached.
>   [ ] +1 approve
>   [ ] +0 no opinion
>   [ ] -1 disapprove (and reason why)
>
> Thanks,
> Madhan
>
>
> List of issues addressed in this release: https://issues.apache.org/
> jira/issues/?jql=project%20%3D%20Atlas%20AND%20resolution%
> 20!%3D%20Unresolved%20%20AND%20fixVersion%20%3D%201.0.0%
> 20ORDER%20BY%20key%20DESC
>
> Git tag for the release: https://github.com/apache/
> atlas/tree/release-1.0.0-rc0
>
> Sources for the release: https://dist.apache.org/repos/
> dist/dev/atlas/1.0.0-rc0/apache-atlas-1.0.0-sources.tar.gz
>
> Documentation for the release: http://atlas.apache.org/1.0.0-
> rc0/index.html
>
> Source release verification:
>   PGP Signature: https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc0/
> apache-atlas-1.0.0-sources.tar.gz.asc
>   SHA512 Hash: https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc0/
> apache-atlas-1.0.0-sources.tar.gz.sha512
>
> Keys to verify the signature of the release artifacts are available at:
> https://dist.apache.org/repos/dist/dev/atlas/KEYS
>
>
>
>

Re: [VOTE] Release Apache Atlas version 1.0.0 - rc2

[Nixon Rodrigues]

+1 for 1.0.0-rc2.

Thanks Madhan for putting Atlas 1.0.0 for release.

Nixon Rodrigues


On Fri, Jun 1, 2018, 5:20 PM David Radley  wrote:

> Thanks Madhan for putting out the release candidate 2 for Apache Atlas 1.0
>
>
>   - Built with embedded-hbase-solr profile successfully with no test
> failures
>   - built with clean install with no test failures.
>   - Ran quick start and the UI.
>
> +1 for release candidate #2.
>
> all the best, David.
>
> From:   Sarath Subramanian 
> To: dev@atlas.apache.org
> Date:   31/05/2018 17:17
> Subject:Re: [VOTE] Release Apache Atlas version 1.0.0 - rc2
>
>
>
> Thanks Madhan for putting out the release candidate 2 for Apache Atlas 1.0
>
>- Verified checksum and signature
>- Built with embedded-hbase-solr profile successfully with no test
>failures.
>- Validated new functionalities - glossary, relationships, lineage, tag
>propagation and UI enhancements
>
> +1 for release candidate #2.
>
>
> Thanks,
> Sarath Subramanian
>
>
> On Wed, May 30, 2018 at 12:31 AM, Madhan Neethiraj 
> wrote:
>
> > Atlas team,
> >
> > Apache Atlas 1.0.0 release candidate #2 is now available for a vote
> within
> > dev community.
> >
> > Following commit went into branch-1.0 since the last release candidate,
> > #1, was sent yesterday.
> >   ATLAS-2726: updated migration-import to add __name property to
> > classification edges
> >
> > Links to the release artifacts are given below. Please review and vote.
> >
> > The vote will be open for at least 72 hours or until necessary votes are
> > reached.
> >   [ ] +1 approve
> >   [ ] +0 no opinion
> >   [ ] -1 disapprove (and reason why)
> >
> > Thanks,
> > Madhan
> >
> >
> > List of issues addressed in this release:
> https://issues.apache.org/
>
> > jira/issues/?jql=project%20%3D%20Atlas%20AND%20resolution%
> > 20!%3D%20Unresolved%20%20AND%20fixVersion%20%3D%201.0.0%
> > 20ORDER%20BY%20key%20DESC
> >
> > Git tag for the release:
> https://github.com/apache/
>
> > atlas/tree/release-1.0.0-rc2
> >
> > Sources for the release:
> https://dist.apache.org/repos/
>
> > dist/dev/atlas/1.0.0-rc2/apache-atlas-1.0.0-sources.tar.gz
> >
> > Documentation for the release:
> http://atlas.apache.org/1.0.0-
>
> > rc0/index.html
> >
> > Source release verification:
> >   PGP Signature:
> https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/
>
> > apache-atlas-1.0.0-sources.tar.gz.asc
> >   SHA512 Hash:
> https://dist.apache.org/repos/dist/dev/atlas/1.0.0-rc2/
>
> > apache-atlas-1.0.0-sources.tar.gz.sha512
> >
> > Keys to verify the signature of the release artifacts are available at:
> >
> https://dist.apache.org/repos/dist/dev/atlas/KEYS
>
> >
> >
> >
> >
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>

Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/1/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67428: ATLAS-2691: updated documentation to add Downloads page

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67428/#review204240
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 3, 2018, 8:21 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67428/
> ---
> 
> (Updated June 3, 2018, 8:21 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2691
> https://issues.apache.org/jira/browse/ATLAS-2691
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - added Downloads page, per Apache release announcement requirements: 
> http://www.apache.org/legal/release-policy.html#release-announcements and 
> https://www.apache.org/dev/release-distribution#download-links
> - updated committers list
> -
> 
> 
> Diffs
> -
> 
>   docs/src/site/site.xml dbebe7d72 
>   docs/src/site/twiki/Downloads.twiki PRE-CREATION 
>   pom.xml 19c1a516c 
> 
> 
> Diff: https://reviews.apache.org/r/67428/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67430: ATLAS-2735: updated version in master branch to 2.0.0-SNAPSHOT

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67430/#review204242
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 4, 2018, 6:16 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67430/
> ---
> 
> (Updated June 4, 2018, 6:16 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2735
> https://issues.apache.org/jira/browse/ATLAS-2735
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated version in master branch to 2.0.0-SNAPSHOT
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml 3fbee253e 
>   addons/falcon-bridge/pom.xml 9db65dc1f 
>   addons/hbase-bridge-shim/pom.xml 7df600773 
>   addons/hbase-bridge/pom.xml eea6b6556 
>   addons/hdfs-model/pom.xml b5481ba48 
>   addons/hive-bridge-shim/pom.xml 3abd99da0 
>   addons/hive-bridge/pom.xml 581485439 
>   addons/kafka-bridge/pom.xml a43a063a3 
>   addons/sqoop-bridge-shim/pom.xml c8ca48506 
>   addons/sqoop-bridge/pom.xml 24747a9f2 
>   addons/storm-bridge-shim/pom.xml 802f12cbd 
>   addons/storm-bridge/pom.xml 9799f0dd4 
>   authorization/pom.xml 62a6ebb90 
>   client/client-v1/pom.xml e25a30881 
>   client/client-v2/pom.xml 66013f591 
>   client/common/pom.xml c6ef0b8aa 
>   client/pom.xml 728c70626 
>   common/pom.xml 7ce6fdce4 
>   dashboardv2/pom.xml f4776413f 
>   distro/pom.xml 562e3e5dd 
>   docs/pom.xml 765076692 
>   graphdb/api/pom.xml d0462b44d 
>   graphdb/common/pom.xml 71e3bbcdd 
>   graphdb/graphdb-impls/pom.xml 1e60a9c2a 
>   graphdb/janus/pom.xml 0d865682f 
>   graphdb/pom.xml 825dc20e8 
>   intg/pom.xml f3c6db3d0 
>   notification/pom.xml 079d42412 
>   om-fwk-ocf/pom.xml 8b1cefdb3 
>   omag-api/pom.xml 2338286ea 
>   omag-server/README.md f47466e86 
>   omag-server/pom.xml 527c5c3d1 
>   omas-assetconsumer/pom.xml 29935e734 
>   omas-connectedasset/pom.xml 219c972e0 
>   omrs/pom.xml 50b989804 
>   plugin-classloader/pom.xml a26aae08c 
>   pom.xml 4fc44c05f 
>   repository/pom.xml a6ee43f61 
>   server-api/pom.xml 075e95071 
>   shaded/hbase-client-shaded/pom.xml 8d95a5b45 
>   shaded/hbase-server-shaded/pom.xml 19bf73c37 
>   test-tools/pom.xml c1c59b998 
>   tools/atlas-migration-exporter/pom.xml 6880f3837 
>   webapp/pom.xml ef8f0ad05 
> 
> 
> Diff: https://reviews.apache.org/r/67430/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that there are no references to 1.0.0-SNAPSHOT in master branch
> - built Atlas successfully after updates to pom files
> - pre-commit test runs - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/463/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 11:44 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch includes fix to handle review comments and UTs to test 
validateTimeBoundry(timeBoundary) method.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/2/

Changes: https://reviews.apache.org/r/67410/diff/1-2/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 12:32 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch adds missing licence file in new class.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/3/

Changes: https://reviews.apache.org/r/67410/diff/2-3/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67435: Import-hbase.sh script ignores table's NORMALIZATION_ENABLED attribute.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67435/#review204253
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 4, 2018, 1:16 p.m., Ruchi Solani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67435/
> ---
> 
> (Updated June 4, 2018, 1:16 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2737
> https://issues.apache.org/jira/browse/ATLAS-2737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When HBase hook is in place , when table is created with 
> NORMALIZATION_ENABLED true/false , it is ingested correctly.
> If table is created with NORMALIZATION_ENABLED => true and import-hbase 
> script is run , request body has NORMALIZATION_ENABLED sent with default 
> false value.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  09998cf 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
>  8372f02 
> 
> 
> Diff: https://reviews.apache.org/r/67435/diff/1/
> 
> 
> Testing
> ---
> 
> sanity testing,
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 5, 2018, 7:25 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch inclues changes to validating timeboundry datatime range in 
AtlasClassificationType instead AtlasEntityStore.
Performed santity with valid & invalid timeboundries , All UT and ITs are 
passing in Apache jenkis.

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/466/console


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/pom.xml 57803bd6e 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
abacd7864 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
0badfcf92 
  pom.xml 87ca5dd5f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 


Diff: https://reviews.apache.org/r/67410/diff/4/

Changes: https://reviews.apache.org/r/67410/diff/3-4/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Review Request 67499: ATLAS-2730 - Added validation for Timezone in TimeBoundry values in classifications

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67499/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

Currently, timezone which is not null and not valid was treated as default 
system timezone.

This patch (ATLAS-2730-4.patch) adds validation for timezone to accept timezone 
in valid format.

eg:-

JST,IND,UTC
GMT+0
GMT+10:30
GMT-13
America/Los_Angeles
Asia/Singapore


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0585ebe1 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
1adb362dd 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
1ade5f704 


Diff: https://reviews.apache.org/r/67499/diff/1/


Testing
---

Performed manual testing by adding valid and invalid timezone in classification
Added test unittestcases


Thanks,

Nixon Rodrigues

Re: Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/#review204489
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 8, 2018, 2:05 p.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67508/
> ---
> 
> (Updated June 8, 2018, 2:05 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2747
> https://issues.apache.org/jira/browse/ATLAS-2747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes fix to render objects of non-primitive data-type.
> 
> #On edit popup only primitive datatypes objects are shown to edit.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/Overrides.js a96fc2c 
>   dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
>   dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 
> 
> 
> Diff: https://reviews.apache.org/r/67508/diff/1/
> 
> 
> Testing
> ---
> 
> Performed sanity test on UI
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to show the input and output entity

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/#review204678
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 13, 2018, 6:36 a.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67566/
> ---
> 
> (Updated June 13, 2018, 6:36 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2754
> https://issues.apache.org/jira/browse/ATLAS-2754
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Altas front end fail to show the entity. The server side can return the 
> correct json information for the altas record. but it does not show in the 
> front page.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8 
> 
> 
> Diff: https://reviews.apache.org/r/67566/diff/2/
> 
> 
> Testing
> ---
> 
> Sanity testing done for input and output object.
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67622: ATLAS-2708: added model for AWS types

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67622/#review204910
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 18, 2018, 12:44 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67622/
> ---
> 
> (Updated June 18, 2018, 12:44 a.m.)
> 
> 
> Review request for atlas, Barbara Eckman and Don Bosco Durai.
> 
> 
> Bugs: ATLAS-2708
> https://issues.apache.org/jira/browse/ATLAS-2708
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Models for AWS types from @Barbara Eckman: AWSBucket, AWSPseudoDir, 
> AWSObject; and related structs and relationships
> 
> 
> Diffs
> -
> 
>   addons/models/3000-Cloud/3010-aws_common_typedefs.json PRE-CREATION 
>   addons/models/3000-Cloud/3020-aws_s3_typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67622/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the models load in Atlas successfully without any 
> errors/warning.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2762
https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
---

Problem: In relationshipAttributes we don't have entity status and for showing 
entity status we need to make separate ajax call to read only one property i.e 
entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 
543de61dc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 cea63f02d 


Diff: https://reviews.apache.org/r/67682/diff/1/


Testing
---

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues

Re: Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
---

(Updated June 21, 2018, 1:18 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

This patch includes UI changes to render entity status attribute for entities 
on relationship tab. 
And the edge status with relationshipStatus attribute.


Bugs: ATLAS-2762
https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
---

Problem: In relationshipAttributes we don't have entity status and for showing 
entity status we need to make separate ajax call to read only one property i.e 
entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs (updated)
-

  dashboardv2/public/js/utils/CommonViewFunction.js 241b812 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 0d66235 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 138e2cc 
  dashboardv2/public/js/views/graph/RelationshipLayoutView.js edb7672 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 
543de61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 cea63f0 


Diff: https://reviews.apache.org/r/67682/diff/2/

Changes: https://reviews.apache.org/r/67682/diff/1-2/


Testing
---

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues

Re: Review Request 67701: ATLAS-2764: Time Bound classification : Few timezones throw "Invalid timezone exception"

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67701/#review205233
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 22, 2018, 10:28 a.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67701/
> ---
> 
> (Updated June 22, 2018, 10:28 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Folllowing timezones from UI are missing in java timezone and throw INVALID 
> timezone exception
> America/Punta_Arenas
> Asia/Atyrau
> Asia/Famagusta
> Asia/Yangon
> Europe/Saratov
> ROC
> It would be good to load timezone TimeZone.getAvailableIDs() on UI.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/tag/AddTimezoneItemView.js 3deab83 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 5012d51 
> 
> 
> Diff: https://reviews.apache.org/r/67701/diff/1/
> 
> 
> Testing
> ---
> 
> sanity testing done to check timezone list in dropdown
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Re: Review Request 67716: ATLAS-2765: updated authorization model to scrub search-result (clear entity-attributes, classifications) for entities the user doesn't have read access to

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67716/#review205363
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 24, 2018, 4:34 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67716/
> ---
> 
> (Updated June 24, 2018, 4:34 a.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval 
> bhatt, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2765
> https://issues.apache.org/jira/browse/ATLAS-2765
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - updated authorization model to scrub search-result (clear 
> entity-attributes, classifications) for entities the user doesn't have read 
> access to
> - updated APIs that retrieve entity classifications to require entity-read 
> permission, instead of entity-read-classification permission.
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
>  cc5db2ff9 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
> 285e0f6a0 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java
>  06ae6004b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java
>  PRE-CREATION 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
>  fd5885898 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  9d0cc9dc7 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> fb26598b2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  40593be76 
> 
> 
> Diff: https://reviews.apache.org/r/67716/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that entity-attributes and classifications in the search-result 
> are cleared for entities the user doesn't have read access to
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 67741: ATLAS-2766: UI - Turn off hyperlinks for entities with no entity-read access in search result display

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67741/#review205366
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 26, 2018, 1:42 p.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67741/
> ---
> 
> (Updated June 26, 2018, 1:42 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2766
> https://issues.apache.org/jira/browse/ATLAS-2766
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When ATLAS-2765 will be in place, the search result will have “-1” as guid 
> for entities on which the user doesn’t have ‘entity-read’ permission.  UI 
> will not hyperlink ‘Name’ column for such result entries. This will prevent 
> the user from clicking the link to go to entity details page and not able to 
> tag term/classification.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 7fa088b 
> 
> 
> Diff: https://reviews.apache.org/r/67741/diff/1/
> 
> 
> Testing
> ---
> 
> Verified for admin and rangertagsync user with type/classification policy on 
> entity, the entities with no access to type /classification where shown with  
> guid '-1' and hyperlink for this entities was disabled and tag 
> term/classification button are disabled.
> 
> Performed sanity UI test.
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Atlas 1.1.0 release heads up

[Nixon Rodrigues]

Atlas dev community,

Since Atlas 1.0 was released, there are around 30 plus commits on branch1.0
and 24 resolved issues

with fix version 1.1.0 after 1.0 release.
These bug fixes and improvements are important for stability and for other
dependent components that consume Atlas.

I propose that we do a 1.1.0 release from branch-1.0 and the tentative
release completion date would be 15th July 2018.

I volunteer to be the release manager for Apache Atlas 1.1.0 release.

Let me know your thoughts and concerns if any.

Regards
Nixon

Re: Review Request 67942: ATLAS-2788 : Add policy permissions for tagsync user.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67942/#review206193
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 17, 2018, 2:06 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67942/
> ---
> 
> (Updated July 17, 2018, 2:06 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2788
> https://issues.apache.org/jira/browse/ATLAS-2788
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tagsync user needs read permissions for accessing Tags / Classification from 
> Atlas-REST when using simple auth.
> PS : Seperate patch for branch-0.8 is attached on Apache JIRA.
> 
> 
> Diffs
> -
> 
>   authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8 
>   authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8 
>   distro/src/conf/atlas-simple-authz-policy.json 01104a8 
> 
> 
> Diff: https://reviews.apache.org/r/67942/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with fresh installation of Atlas and Ranger-Tagsync.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 68190: ATLAS-2809 - Updates to SimpleAuthorizer for Relationship endpoints

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68190/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2809
https://issues.apache.org/jira/browse/ATLAS-2809


Repository: atlas


Description
---

This patch adds authorization to relationship end points in SimpleAuthorization.

For following Action.

 RELATIONSHIP_ADD( "add-relationship"),
 RELATIONSHIP_UPDATE("update-relationship"),
 RELATIONSHIP_REMOVE("remove-relationship");


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 a0d78eb32 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
563485e3b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java 
9f8f7acb7 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
3cb7f655d 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 47c44ccc4 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 e2a8b7f26 
  authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8d9 
  authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8d9 
  distro/src/conf/atlas-simple-authz-policy.json 01104a8d9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 c1aca45ad 


Diff: https://reviews.apache.org/r/68190/diff/1/


Testing
---

Performed  testing from UI.


File Attachments


RangerAuthz servicedef JSON
  
https://reviews.apache.org/media/uploaded/files/2018/08/03/b07f608d-1bcc-4a99-a1d0-3effd802a4b7__ranger-servicedef-atlas-1.json


Thanks,

Nixon Rodrigues

Re: Review Request 68190: ATLAS-2809 - Updates to SimpleAuthorizer for Relationship endpoints

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68190/
---

(Updated Aug. 4, 2018, 5:50 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch includes code refactoring and code reuse from AtlasAccessRequest.


Bugs: ATLAS-2809
https://issues.apache.org/jira/browse/ATLAS-2809


Repository: atlas


Description
---

This patch adds authorization to relationship end points in SimpleAuthorization.

For following Action.

 RELATIONSHIP_ADD( "add-relationship"),
 RELATIONSHIP_UPDATE("update-relationship"),
 RELATIONSHIP_REMOVE("remove-relationship");


Diffs (updated)
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java 
4ae95109b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 a0d78eb32 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
563485e3b 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
 e79b97ccd 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasNoneAuthorizer.java 
9f8f7acb7 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
3cb7f655d 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 47c44ccc4 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 e2a8b7f26 
  authorization/src/main/resources/atlas-simple-authz-policy.json 01104a8d9 
  authorization/src/test/resources/atlas-simple-authz-policy.json 01104a8d9 
  distro/src/conf/atlas-simple-authz-policy.json 01104a8d9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 c1aca45ad 


Diff: https://reviews.apache.org/r/68190/diff/2/

Changes: https://reviews.apache.org/r/68190/diff/1-2/


Testing
---

Performed  testing from UI.


File Attachments


RangerAuthz servicedef JSON
  
https://reviews.apache.org/media/uploaded/files/2018/08/03/b07f608d-1bcc-4a99-a1d0-3effd802a4b7__ranger-servicedef-atlas-1.json


Thanks,

Nixon Rodrigues

Review Request 68341: ATLAS-2821 :- Update old atlas-simple-authz-policy.json file with relationship permission attributes

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68341/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2821
https://issues.apache.org/jira/browse/ATLAS-2821


Repository: atlas


Description
---

This patch inclues utility which will update old atlas-simple-authz-policy.json 
policy file with relationship default permission attributes for ROLE_ADMIN and 
DATA_STEWARD.

 

Usage : ./atlas_update_simple_auth_json.py 


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzUpdateTool.java
 PRE-CREATION 
  distro/src/bin/atlas_update_simple_auth_json.py PRE-CREATION 


Diff: https://reviews.apache.org/r/68341/diff/1/


Testing
---

Tested in cmd line with old atlas-simple-authz-policy.json for relationship 
default permissions.


Thanks,

Nixon Rodrigues

Re: Review Request 68344: ATLAS-2820 : UI : Add replication audits tab for AtlasCluster entity to show Export & Import audit

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68344/#review207309
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 14, 2018, 4 p.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68344/
> ---
> 
> (Updated Aug. 14, 2018, 4 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2820
> https://issues.apache.org/jira/browse/ATLAS-2820
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add Replication Audits tab in detail page if entity typename is 
> "AtlasCluster".
> 
> inside tab show list of audits in table structure using this new API.
> 
> /api/atlas/admin/expimp/audit?sourceClusterName=
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/collection/VSearchList.js 28c246f24 
>   
> dashboardv2/public/js/templates/audit/ReplicationAuditTableLayoutView_tmpl.html
>  PRE-CREATION 
>   dashboardv2/public/js/templates/common/TableLayout_tmpl.html a1104abba 
>   dashboardv2/public/js/templates/common/modal.html e000fa8a8 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> a322eddb6 
>   dashboardv2/public/js/utils/TableLayout.js a2ba0a659 
>   dashboardv2/public/js/utils/UrlLinks.js c6335b916 
>   dashboardv2/public/js/views/audit/ReplicationAuditTableLayoutView.js 
> PRE-CREATION 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c5f3e6958 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b4cb36ecc 
> 
> 
> Diff: https://reviews.apache.org/r/68344/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of sanity test
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
64c95203c 


Diff: https://reviews.apache.org/r/68363/diff/1/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68377/#review207396
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 16, 2018, 10:30 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68377/
> ---
> 
> (Updated Aug. 16, 2018, 10:30 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2826
> https://issues.apache.org/jira/browse/ATLAS-2826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated the logic to get entity-id for authorization, to support entities 
> that may not have qualifiedName as unique attribute
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java
>  8cdd6768a 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  d87c8300b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
>  87e9b59fc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d 
> 
> 
> Diff: https://reviews.apache.org/r/68377/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that save-search succeeds with this fix
> - pre-commit test run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/586/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 68377: ATLAS-2826: fix for failure in authorizing save-search operation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68377/#review207400
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 16, 2018, 11:44 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68377/
> ---
> 
> (Updated Aug. 16, 2018, 11:44 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2826
> https://issues.apache.org/jira/browse/ATLAS-2826
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated the logic to get entity-id for authorization, to support entities 
> that may not have qualifiedName as unique attribute
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java
>  8cdd6768a 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  d87c8300b 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java
>  87e9b59fc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 8ab41a31d 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 5abae95f7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  c8adcf153 
> 
> 
> Diff: https://reviews.apache.org/r/68377/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that save-search succeeds with this fix
> - pre-commit test run - 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/587/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[VOTE] Release Apache Atlas version 1.1.0 - rc0

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #0 is now available for a vote
within dev community.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes
are reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)


Thanks,
Nixon Rodrigues


List of issues addressed in this release:
https://issues.apache.org/jira/browse/ATLAS-2849?jql=project%20%3D%20Atlas%20AND%20resolution%20%3D%20Fixed%20%20%20%20AND%20fixVersion%20%3D%201.1.0%20ORDER%20BY%20key%20DESC

Git tag for the release: https://github.com/apache/atlas/tree/release-1.1.0-rc0

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz


Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash: 
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc0/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available
at: https://dist.apache.org/repos/dist/dev/atlas/KEYS

[VOTE] Release Apache Atlas version 1.1.0 - rc1

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #1 is now available for a vote within
dev community.

Following 2 commits went into branch-1.0 since the last release candidate,
#0, was sent last week.

  ATLAS-2844: Added eventTime field in EntityNotificationV2
  ATLAS-2853: Updated to send entity-notifications after successful graph
transaction commit.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes are
reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)

Here is my +1

Thanks,
Nixon Rodrigues

List of issues addressed in this release:
https://issues.apache.org/jira/browse/ATLAS-2849?jql=project%20%3D%20Atlas%20AND%20resolution%20%3D%20Fixed%20%20%20%20AND%20fixVersion%20%3D%201.1.0%20ORDER%20BY%20key%20DESC

Git tag for the release:
https://github.com/apache/atlas/tree/release-1.1.0-rc1

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz

Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc1/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available at:
https://dist.apache.org/repos/dist/dev/atlas/KEYS

[VOTE] Release Apache Atlas version 1.1.0 - rc2

[Nixon Rodrigues]

Atlas team,

Apache Atlas 1.1.0 release candidate #2 is now available for a vote within
dev community.

Following 1 commits went into branch-1.0 since the last release candidate,
#1, was sent 3 days back.

  ATLAS-2857:Fix Atlas release version in /api/atlas/version API.

Links to the release artifacts are given below. Please review and vote.

The vote will be open for at least 72 hours or until necessary votes are
reached.
  [ ] +1 approve
  [ ] +0 no opinion
  [ ] -1 disapprove (and reason why)

Here is my +1

Thanks,
Nixon Rodrigues

List of issues addressed in this release:
https://issues.apache.org/jira/issues/?jql=project%3DAtlas%20AND%20resolution%3DFixed%20AND%20fixVersion%3D1.1.0%20ORDER%20BY%20key%20DESC&startIndex=50

Git tag for the release:
https://github.com/apache/atlas/tree/release-1.1.0-rc2

Sources for the release:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz

Source release verification:
  PGP Signature:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz.asc
  SHA512 Hash:
https://dist.apache.org/repos/dist/dev/atlas/1.1.0-rc2/apache-atlas-1.1.0-sources.tar.gz.sha512

Keys to verify the signature of the release artifacts are available at:
https://dist.apache.org/repos/dist/dev/atlas/KEYS

Re: Review Request 68666: ATLAS-2827: fix for notification retry failure due to guid assignments in earlier attempt

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68666/#review208445
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 7, 2018, 6:51 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68666/
> ---
> 
> (Updated Sept. 7, 2018, 6:51 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2827
> https://issues.apache.org/jira/browse/ATLAS-2827
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While processing requests, Atlas assigns guids for entities that have 
> unassigned guids in the request. When a request (from notificaiton) is 
> retried due to failure in earlier attempts, the retry attempt might fail due 
> to guid assignment performed in the earlier attempt. The fix is to reset the 
> guid assignments before attempting a retry.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  6e2a03fa4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  4cd9909cb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/InstanceGraphMapper.java
>  8d405000b 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 891dcc846 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  0ac3ebbf8 
> 
> 
> Diff: https://reviews.apache.org/r/68666/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that retry attempts to process notifications succeed.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Sept. 7, 2018, 2:11 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

This patch includes fix for review comments and a check to validate that 
incoming request is from trustedProxy server. Atlas validates the below 
property value with request IP.

Property :atlas.proxyserver.knox.ip


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
64c95203c 


Diff: https://reviews.apache.org/r/68363/diff/2/

Changes: https://reviews.apache.org/r/68363/diff/1-2/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

[RESULT] [VOTE] Release Apache Atlas version 1.1.0 - rc2

[Nixon Rodrigues]

Atlas team,

Thanks for taking time to verify, give feedback and vote on Apache Atlas
1.1.0 release candidate #2.

More than 72 hours have passed since the email to vote for the release; the
vote is now closed. The vote passes with *10* +1s and no 0s and -1s.

Here are the vote details:

*Four* +1 votes from following PMC members:

  - Keval Bhatt

  - Madhan Neethiraj

  - Nixon Rodrigues

  - Sarath Subramanian


*Six* +1 votes from following committers/contributors:

  - Abhishek Kadam

  - Ashutosh Mestry (Committer)

  - Ramesh Mani

  - Sharmadha Sainath (Committer)

  - Tejas Rawool

  - Vishal Suvagia

Voting thread:
https://lists.apache.org/thread.html/dcf1698ab757b74e054a4792785645258b09be2b99b349d702180f05@%3Cdev.atlas.apache.org%3E

I will begin the process of creating the release artifacts for Apache Atlas
1.1.0.


Thanks & Regards,

Nixon Rodrigues

Review Request 68735: ATLAS-2860- Remove Atlas client dependency with atlas-application properties

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860


Repository: atlas


Description
---

This patch includes changes in Atlas client to remove the dependency with atlas 
application properties, so that it can be reused from non Atlas application env.


Diffs
-

  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
c0d0318d8 
  client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java 
ce4e014f7 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 
  client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
d5392b2e4 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 


Diff: https://reviews.apache.org/r/68735/diff/1/


Testing
---

Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.


Thanks,

Nixon Rodrigues

Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency with atlas-application properties

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/
---

(Updated Sept. 17, 2018, 6:37 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch consist fix to address review comment from Madhan N.


Bugs: ATLAS-2860
https://issues.apache.org/jira/browse/ATLAS-2860


Repository: atlas


Description
---

This patch includes changes in Atlas client to remove the dependency with atlas 
application properties, so that it can be reused from non Atlas application env.


Diffs (updated)
-

  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
c0d0318d8 
  client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java 
ce4e014f7 
  client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 
  client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
d5392b2e4 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 


Diff: https://reviews.apache.org/r/68735/diff/2/

Changes: https://reviews.apache.org/r/68735/diff/1-2/


Testing
---

Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas client.


Thanks,

Nixon Rodrigues

Re: Review Request 68735: ATLAS-2860- Remove Atlas client dependency with atlas-application properties

[Nixon Rodrigues]

> On Sept. 17, 2018, 4:29 p.m., Madhan Neethiraj wrote:
> > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java
> > Line 430 (original), 430 (patched)
> > <https://reviews.apache.org/r/68735/diff/1/?file=2089902#file2089902line430>
> >
> > Why make initializeState() methods public? These methods don't seem to 
> > be called from outside this class.

Make sense


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68735/#review208682
-------


On Sept. 17, 2018, 6:37 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68735/
> ---
> 
> (Updated Sept. 17, 2018, 6:37 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2860
> https://issues.apache.org/jira/browse/ATLAS-2860
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes changes in Atlas client to remove the dependency with 
> atlas application properties, so that it can be reused from non Atlas 
> application env.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java
>  c0d0318d8 
>   client/client-v1/src/test/java/org/apache/atlas/AtlasClientTest.java 
> ce4e014f7 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6f767e52 
>   
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> d5392b2e4 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java a35bdfee7 
> 
> 
> Diff: https://reviews.apache.org/r/68735/diff/2/
> 
> 
> Testing
> ---
> 
> Testing Atlas with QuickStart and Atlas_admin.py script which use Atlas 
> client.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[ANNOUNCE] Apache Atlas 1.1.0 released

[Nixon Rodrigues]

Hi All,

The Apache Atlas team is happy to announce the release of Apache Atlas
- version 1.1.0.

Atlas is a scalable and extensible set of core foundational governance
services – enabling enterprises to effectively and efficiently meet their
compliance requirements within Hadoop and allows integration with the whole
enterprise data ecosystem.

The release artifacts are available at:
http://www.apache.org/dyn/closer.cgi/atlas/1.1.0/

The binary artifacts are available from Maven central and its mirrors.

To use these artifacts, please use the following documentation:
http://atlas.apache.org/1.1.0/index.html

More details on Apache Atlas can be found at: http://atlas.apache.org/

We thank everyone who made this release possible.

Thanks,
The Apache Atlas team

Re: MODERATE for annou...@apache.org

[Nixon Rodrigues]

Craig,

Thanks for specifying the requirement for an announcement email. I have
resubmitted the announcement to annou...@apache.org with download page
instead of dyn/closer.

Thanks & Regards,
Nixon Rodrigues


On Tue, Sep 18, 2018 at 8:11 PM Private LIst Moderation <
mod-priv...@gsuite.cloud.apache.org> wrote:

> Hi,
>
> This announcement has been rejected because it does not conform to
> requirements for release announcements[1]. Please fix the announcement and
> resubmit the announcement. The downloads page
> http://atlas.apache.org/Downloads.html is fine. Please link to it instead
> of dyn/closer.
>
> Regards,
>
> Craig
>
> [1]
> Announcements of Apache project releases must contain a link to the
> relevant
> download page, which might be hosted on an Apache site or a third party
> site
> such as github.com <http://github.com/>. [1]
>
> The download page must provide public download links where current official
> source releases and accompanying cryptographic files may be obtained. [2]
>
> Links to the download artifacts must support downloads from mirrors. Links
> to
> metadata (SHA, ASC) must be from https://www.apache.org/dist/ <
> https://www.apache.org/dist/>/
> ** MD5 is no longer considered useful and should not be used. SHA is
> required. **
> Links to KEYS must be from https://www.apache.org/dist/ <
> https://www.apache.org/dist/>/ not release
> specific.
>
> Announcements that contain a link to the dyn/closer page alone will be
> rejected by the moderators.
>
> Announcements that contain a link to a web page that does not include a
> link
> to a mirror to the artifact plus links to the signature and at least one
> sha
> checksum will be rejected.
>
> Announcements that link to dist.apache.org <http://dist.apache.org/> will
> not be accepted.
> Likewise ones which link to SVN or Git code repos.
>
> [1] http://www.apache.org/legal/release-policy.html#release-announcements
> <http://www.apache.org/legal/release-policy.html#release-announcements>[2]
> https://www.apache.org/dev/release-distribution#download-links <
> https://www.apache.org/dev/release-distribution#download-links>
>
> > On Sep 18, 2018, at 6:11 AM,
> announce-reject-1537276285.18028.onocfcoiljhimhlfm...@apache.org wrote:
> >
> >
> > To approve:
> >   announce-accept-1537276285.18028.onocfcoiljhimhlfm...@apache.org
> > To reject:
> >   announce-reject-1537276285.18028.onocfcoiljhimhlfm...@apache.org
> > To give a reason to reject:
> > %%% Start comment
> > %%% End comment
> >
> >
> > From: Nixon Rodrigues 
> > Subject: [ANNOUNCE] Apache Atlas 1.1.0 released
> > Date: September 18, 2018 at 6:11:12 AM PDT
> > To: annou...@apache.org
> >
> >
> > Hi All,
> >
> > The Apache Atlas team is happy to announce the release of Apache Atlas -
> version 1.1.0.
> >
> > Atlas is a scalable and extensible set of core foundational governance
> > services – enabling enterprises to effectively and efficiently meet their
> > compliance requirements within Hadoop and allows integration with the
> whole
> > enterprise data ecosystem.
> >
> > The release artifacts are available at:
> http://www.apache.org/dyn/closer.cgi/atlas/1.1.0/ <
> http://www.apache.org/dyn/closer.cgi/atlas/1.1.0/>
> >
> > The binary artifacts are available from Maven central and its mirrors.
> >
> > To use these artifacts, please use the following documentation:
> http://atlas.apache.org/1.1.0/index.html <
> http://atlas.apache.org/1.1.0/index.html>
> >
> > More details on Apache Atlas can be found at: http://atlas.apache.org/ <
> http://atlas.apache.org/>
> >
> > We thank everyone who made this release possible.
> >
> > Thanks,
> > The Apache Atlas team
> >
> >
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org <mailto:c...@apache.org> http://db.apache.org/jdo <
> http://db.apache.org/jdo>
>

Re: Atlas 0.8.3 Release Heads-up

[Nixon Rodrigues]

+1 for 0.8.3 release.

Thanks
Nixon Rodrigues


On Mon, Oct 8, 2018, 11:53 AM Ashutosh Mestry 
wrote:

> Atlas Dev Community
>
> Since Atlas 0.8.2 was released, there have been 138 commits towards
> features, improvements and bug fixes.
>
> These commits can be broadly categorized as follows:
> - Export and Import process improvement. Noteworthy being, support for
> incremental export.
> - Hive Hook performance improvement. The most significant improvement
> was addressing bugs that led to spurious entity within Atlas for data
> inserts and improvement towards column lineage creation.
>- Migration export utility. This will help users migrate to Atlas 1.0.
> - Bug fixes.
>
> I propose that we create 0.8.3 release from branch-0.8. The tentative
> release completion date would be October 15, 2018.
>
> I volunteer to be the release manager for Apache Atlas 0.8.3 release. I
> plan on using https://issues.apache.org/jira/browse/ATLAS-2910 to track
> progress.
>
> Let me know your thoughts and concerns if any.
>
> Best regards,
>
> ~ ashutosh
>
>
>

Re: Referring existing entities in Atlas using Rest API

[Nixon Rodrigues]

Hi Anshu,

You can connect to existing entity be referring the guid of already created
entity.
Below is the format of JSON.

 {

"entity": {
 ...
 ...
"Location" : {
"guid": "<%Existing entity guid)%>",
"typeName": ""
...
...
}

}



On Thu, Oct 11, 2018 at 2:21 PM Anshu Shukla 
wrote:

> Hi,
>
> I have used Atlas-scripts in dev-support folder to create entities using
> the given json example file.
> But there is no example to guide and show how to connect to an already
> existing entity in case new entity have attribute of that type.
>
> Example-
>
>  Location is an attribute inside the  Source
> type.   [Using Rest API's]
>

Re: [VOTE] Release Apache Atlas v 0.8.3 - RC0

[Nixon Rodrigues]

+1 for the release of release-0.8.3-rc0


1) Tested with the rc0 bits with berkeley-elasticsearch profile.
2) UI loads fine.
3) Quickstart data loads correctly.
4) Verified signature & SHA512 hash.

Thanks, Ashutosh for putting for Apache Atlas
0.8.3 for release.

Thanks
Nixon


On Mon, Oct 22, 2018 at 11:01 AM Sharmadha Sainath 
wrote:

> +1 for the release
>
>
> 1.Verified the existing export & import functionality, incremental export,
> new options in the import , AtlasServer datatype and audits.
> 2.Verified Basic Search , DSL Search.
> 3.Verified the Basic UI functionalities such as search , navigate to
> entities , tag creation/association/disassociation.
>
> Thanks,
> Sharmadha S.
>
>
>
>
> On 10/21/18, 8:26 AM, "Apoorv Naik"  wrote:
>
> >+1 for the release Ashutosh.
> >
> >1. Verified signature
> >2. Built with embedded hbase and solr profile
> >3. Basic search and DSL works as expected
> >
> >Thanks for putting in the effort towards this release.
> >
> >*Apoorv Naik*
> >
> >
> >On Sat, Oct 20, 2018 at 11:35 AM Sarath Subramanian 
> >wrote:
> >
> >> Thanks Ashutosh for putting together release candidate #0 for Apache
> Atlas
> >> 0.8.3
> >>
> >> Verified the following:
> >>
> >>- Verified PGP Signature and hash
> >>- Build the source using embedded HBase and Solr profile, build was
> >>successful
> >>- Ran quick start and validated basic functionality - basic search,
> >>import-export, advanced search.
> >>
> >> +1 for release of Apache Atlas 0.8.3 rc0
> >>
> >> Thanks,
> >> Sarath
> >>
> >> On Wed, Oct 17, 2018 at 4:14 PM Ashutosh Mestry <
> ames...@hortonworks.com>
> >> wrote:
> >>
> >> > Apache Atlas 0.8.3 Release Candidate #0 is now available for a vote
> >> within
> >> > dev community.
> >> >
> >> > Links to the release artifacts are given below. Please review and
> vote.
> >> >
> >> > The vote will be open for at least 72 hours or until necessary votes
> are
> >> > reached.
> >> >   [ ] +1 approve
> >> >   [ ] +0 no opinion
> >> >   [ ] -1 disapprove (and reason why)
> >> >
> >> > Ashutosh Mestry
> >> >
> >> > List of issues addressed in this release:
> >> >
> >>
> https://issues.apache.org/jira/browse/ATLAS-2924?jql=project%20%3D%20ATLAS%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%200.8.3%20ORDER%20BY%20key%20DESC
> >> >
> >> > Git tag for the release:
> >> > https://github.com/apache/atlas/tree/release-0.8.3-rc0
> >> >
> >> > Sources for the release:
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc0/apache-atlas-0.8.3-sources.tar.gz
> >> >
> >> > Source release verification:
> >> > PGP Signature:
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc0/apache-atlas-0.8.3-sources.tar.gz.asc
> >> > SHA512
> >> > <
> >>
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc0/apache-atlas-0.8.3-sources.tar.gz.ascSHA512
> >> >
> >> > Hash:
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc0/apache-atlas-0.8.3-sources.tar.gz.sha512
> >> >
> >> > Keys to verify the signature of the release artifacts are available
> at:
> >> > https://dist.apache.org/repos/dist/dev/atlas/KEYS
> >> >
> >> >
> >> >
> >>
>

Re: Review Request 69179: Export: Connected: Adds Same Entity GUID to Creation Order Causing Failure to Import

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69179/#review210094
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 26, 2018, 5:26 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69179/
> ---
> 
> (Updated Oct. 26, 2018, 5:26 a.m.)
> 
> 
> Review request for atlas, Kapildeo Nayak, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Bugs: ATLAS-2900
> https://issues.apache.org/jira/browse/ATLAS-2900
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Root Cause**
> The starting entity is a table. During navigation to discover more entities, 
> the entities that are discovered also discover table using column connection. 
> This causes table to be re-added to the creation order list.
> 
> **Approach**
> 
> Convert entity creation order to unique list.
> 
> **CURL**
> 
> ```
> curl -X POST -u admin:admin -H "Content-Type: application/json" -H 
> "Cache-Control: no-cache" -d @../docs/export-options.json 
> http://localhost:21000/api/atlas/admin/export > ../docs/hr-1.zip
> ```
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  5e972a2cd 
>   repository/src/main/java/org/apache/atlas/repository/util/UniqueList.java 
> eebbc4eff 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
>  86afd7f43 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java
>  18e7c419f 
>   repository/src/test/resources/json/stocksDB-Entities/export-connected.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69179/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional tests.
> - Minor modification to existing test.
> 
> **Functional tests**
> Using CURL calls.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 69177: Export & Import: New Features Documentation

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69177/#review210136
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 26, 2018, 6:53 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69177/
> ---
> 
> (Updated Oct. 26, 2018, 6:53 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2839
> https://issues.apache.org/jira/browse/ATLAS-2839
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> 
> Augmented existing documentation.
> 
> Additional documentation uses markdown.
> 
> 
> Diffs
> -
> 
>   docs/pom.xml 19e916918 
>   docs/src/site/markdown/AtlasServer.md PRE-CREATION 
>   docs/src/site/markdown/ExportImportAudits.md PRE-CREATION 
>   docs/src/site/markdown/ImportEntityTransforms.md PRE-CREATION 
>   docs/src/site/markdown/Incremental-Export.md PRE-CREATION 
>   docs/src/site/markdown/ReplicatedToFromAttributes.md PRE-CREATION 
>   docs/src/site/markdown/SoftReference.md PRE-CREATION 
>   docs/src/site/resources/images/markdown/atlas-server-exp-imp-audits.png 
> PRE-CREATION 
>   docs/src/site/resources/images/markdown/atlas-server-properties.png 
> PRE-CREATION 
>   docs/src/site/twiki/Export-API.twiki 207499985 
>   docs/src/site/twiki/Export-HDFS-API.twiki 6c2006035 
>   docs/src/site/twiki/Import-Export-API.twiki 6b07b64ac 
> 
> 
> Diff: https://reviews.apache.org/r/69177/diff/2/
> 
> 
> Testing
> ---
> 
> **Tests**
> 
> Used mvn site:run to verify rendering.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: [VOTE] Release Apache Atlas v 0.8.3 - RC1

[Nixon Rodrigues]

Verified the rc1 bits provided.

+1 for release of 0.8.3 RC #1

Thanks,
Nixon Rodrigues

On Sat, Oct 27, 2018 at 12:47 PM Sarath Subramanian 
wrote:

> Thanks Ashutosh for Apache Atlas 0.8.3 RC #1.
>
> * Verified source checksum and validated signature
> * Build source using embedded-hbase-solr profile (build successful)
> * Ran quickstart and validated entities in atlas UI.
> * Validated basic search, advanced search and saved search feature.
> * Validated lineage filtering to hide process entities.
>
> +1
>
> Thanks,
> Sarath Subramanian
>
>
> On Fri, Oct 26, 2018 at 3:48 PM Ashutosh Mestry 
> wrote:
>
> > Apache Atlas 0.8.3 Release Candidate #1 is now available for a vote
> within
> > dev community.
> >
> > Following commits went into branch-0.8 since the last release candidate:
> > - ATLAS-2900: Exported connected bug fix.
> > - ATLAS-2934: Utility to detect and repair incorrect entity state.
> > - ATLAS-2935: Updated NPM package version and added package-lock.json.
> > - ATLAS-2927: Update lineage query for Process entities.
> > - ATLAS-2930: UI changes to handle softReference attribute elegantly.
> > - ATLAS-2931: Set isSoftReferenced method to JsonIgnore.
> > - ATLAS-2926: ZipSink out of memory error for very large entities.
> > - ATLAS-2917: Filter added for lineage to hide Process entity.
> > - ATLAS-2921: Updated import scripts exist status in case of Java error.
> > - ATLAS-2924: Used encoded property name in getEncodedProperty.
> >
> > Links to the release artifacts are given below. Please review and vote.
> >
> > The vote will be open for at least 72 hours or until necessary votes are
> > reached.
> >   [ ] +1 approve
> >   [ ] +0 no opinion
> >   [ ] -1 disapprove (and reason why)
> >
> > Ashutosh Mestry
> >
> > List of issues addressed in this release:
> >
> https://issues.apache.org/jira/browse/ATLAS-2924?jql=project%20%3D%20ATLAS%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%200.8.3%20ORDER%20BY%20key%20DESC
> >
> > Git tag for the release:
> > https://github.com/apache/atlas/tree/release-0.8.3-rc1
> >
> > Sources for the release:
> >
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc1/apache-atlas-0.8.3-sources.tar.gz
> >
> > Source release verification:
> > PGP Signature:
> >
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc1/apache-atlas-0.8.3-sources.tar.gz.asc
> > SHA512
> > <
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc1/apache-atlas-0.8.3-sources.tar.gz.ascSHA512
> >
> > Hash:
> >
> https://dist.apache.org/repos/dist/dev/atlas/0.8.3-rc1/apache-atlas-0.8.3-sources.tar.gz.sha512
> >
> > Keys to verify the signature of the release artifacts are available at:
> > https://dist.apache.org/repos/dist/dev/atlas/KEYS
> >
> >
> >
>

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Oct. 29, 2018, 1:07 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

This patch is revised by implementing with TrustedProxyAuthenticator which 
handles the authentication, and also handles review comments.

Property changed to "atlas.authentication.method.trustedproxy" to enable 
trusted support


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasTrustedProxyFilter.java 
PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/filters/TrustedProxyAuthenticator.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasProxyAuthenticator.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
24be5de20 


Diff: https://reviews.apache.org/r/68363/diff/3/

Changes: https://reviews.apache.org/r/68363/diff/2-3/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 69226: ATLAS-2949 : Remove duplicate attribute from the rdbms entity

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69226/#review210251
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 1, 2018, 9 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69226/
> ---
> 
> (Updated Nov. 1, 2018, 9 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2949
> https://issues.apache.org/jira/browse/ATLAS-2949
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Remove Asset from the superTypes list of the entity RDBMS because Dataset is 
> derived from the Asset type
> 
> 
> Diffs
> -
> 
>   addons/models/2000-RDBMS/2010-rdbms_model.json 7d1747bdf 
>   addons/models/2000-RDBMS/patches/001-rdbms_column_table_add_options.json 
> 202fadec2 
> 
> 
> Diff: https://reviews.apache.org/r/69226/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of testing and check the UI now duplicate attributes are 
> removed.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Nov. 2, 2018, 2:33 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

This patch implements hadoop proxyuser implementation for proxy with doAs


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 9a13cea65 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasProxyUsers.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/68363/diff/4/

Changes: https://reviews.apache.org/r/68363/diff/3-4/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Nov. 5, 2018, 2:25 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Updated patch with some refactoring and code to create session for doAs user


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasImpersonator.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/68363/diff/5/

Changes: https://reviews.apache.org/r/68363/diff/4-5/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Nov. 9, 2018, 12:59 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

Updated patch to reuse hadoop's ProxyUser class and code refactoring.


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 


Diff: https://reviews.apache.org/r/68363/diff/6/

Changes: https://reviews.apache.org/r/68363/diff/5-6/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 68363: ATLAS-2824 :- Atlas to support Trusted Knox Proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68363/
---

(Updated Nov. 13, 2018, 7:51 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan 
Neethiraj, and Sarath Subramanian.


Changes
---

This patch updates changes in SSLKerberosTest testcases and also added property 
to turn doAs on/off for trusted proxy. 
atlas.authentication.method.trustedproxy=true/false

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/805/console


Bugs: ATLAS-2824
https://issues.apache.org/jira/browse/ATLAS-2824


Repository: atlas


Description
---

This patch includes code to support request from knox proxy, where the proxy is 
already known and trusted to Atlas via configuration. Atlas intercepts the 
incoming requests and if it from knox proxy. Atlas allow the knox's doAs user 
to create session in Atlas. 

Configs required:-

atlas.authentication.allow.trustedproxy :- property allow trusted proxy support
atlas.proxyuser.knox.hosts :- property to add trusted hosts
atlas.proxyuser.knox.users :- property to add trusted users
atlas.proxyuser.knox.groups :- property to add trusted groups


Diffs (updated)
-

  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 e5c40d061 
  
webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java
 21d4f8526 
  webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
49d56b20c 


Diff: https://reviews.apache.org/r/68363/diff/7/

Changes: https://reviews.apache.org/r/68363/diff/6-7/


Testing
---

Tested 

* Atlas UI from  Trusted Knox Proxy with Knox SSO loginpage.
* Atlas UI from  Knox Proxy with Atlas Login.
* Atlas UI from  Knox Proxy with SSO Filter enabled at Atlas.
* Atlas UI with Atlas Login.
* Atlas api from curl with BASIS & Kerberos headers


https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console

Topology Used:-



  

federation
SSOCookieProvider
true

sso.authentication.provider.url
{KNOXHOST}/gateway/knoxsso/knoxauth/login.html



identity-assertion
Default
true

  
  
  ATLAS
  {ATLAS_HOST}:21000/
  
  
  ATLAS-API
  {ATLAS_HOST}:21000
  



Thanks,

Nixon Rodrigues

Re: Review Request 69495: ATLAS-2986: updated AtlasClient to skip doAs query parameter when username is same as the logged in user

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69495/#review211002
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 30, 2018, 11:48 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69495/
> ---
> 
> (Updated Nov. 30, 2018, 11:48 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2986
> https://issues.apache.org/jira/browse/ATLAS-2986
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated AtlasClient to skip doAs query parameter when username is same as the 
> logged in user
> 
> 
> Diffs
> -
> 
>   
> client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> 550ef5a81 
> 
> 
> Diff: https://reviews.apache.org/r/69495/diff/1/
> 
> 
> Testing
> ---
> 
> - performed import-hive and verified that doAs parameter is not sent by 
> AtlasClient in REST calls to Atlas server
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/860/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 69504: KNOX-1650 :- Knox Atlas Trusted Proxy with HA provider

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69504/
---

Review request for atlas, Knox, Larry McCay, Madhan Neethiraj, Sandeep More, 
and Sarath Subramanian.


Bugs: KNOX-1650
https://issues.apache.org/jira/browse/KNOX-1650


Repository: knox


Description
---

This patch provides implementation for HA dispatch (ATLAS & ATLAS-API) for 
trusted proxy. The DefaultDispatch used set  excluse WWW-AUTHENTICATE header 
which caused mismatch in header required for authentication.


Diffs
-

  
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/AtlasApiTrustedProxyHaDispatch.java
 PRE-CREATION 
  
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/AtlasTrustedProxyHaDispatch.java
 PRE-CREATION 
  
gateway-service-definitions/src/main/resources/services/atlas-api/0.1.2.0/service.xml
 95c571c6a 
  
gateway-service-definitions/src/main/resources/services/atlas/0.1.2.0/service.xml
 bd3ab8e0b 


Diff: https://reviews.apache.org/r/69504/diff/1/


Testing
---

Tested with ATLAS in HA with the update dispatch Provider and updated 
service.xml.


Thanks,

Nixon Rodrigues

Re: Review Request 69504: KNOX-1650 :- Knox Atlas Trusted Proxy with HA provider

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69504/
---

(Updated Dec. 4, 2018, 3:06 p.m.)


Review request for atlas, Knox, Larry McCay, Madhan Neethiraj, Sandeep More, 
and Sarath Subramanian.


Bugs: KNOX-1650
https://issues.apache.org/jira/browse/KNOX-1650


Repository: knox


Description (updated)
---

This patch provides implementation for HA dispatch (ATLAS & ATLAS-API) for 
trusted proxy. The DefaultDispatch used to exclude WWW-AUTHENTICATE header 
which caused mismatch in headers required for authentication.


Diffs
-

  
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/AtlasApiTrustedProxyHaDispatch.java
 PRE-CREATION 
  
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/AtlasTrustedProxyHaDispatch.java
 PRE-CREATION 
  
gateway-service-definitions/src/main/resources/services/atlas-api/0.1.2.0/service.xml
 95c571c6a 
  
gateway-service-definitions/src/main/resources/services/atlas/0.1.2.0/service.xml
 bd3ab8e0b 


Diff: https://reviews.apache.org/r/69504/diff/1/


Testing
---

Tested with ATLAS in HA with the update dispatch Provider and updated 
service.xml.


Thanks,

Nixon Rodrigues

Re: [DRAFT] Board report for Apache Atlas: December 2018

[Nixon Rodrigues]

Thanks for compiling the report.

+1 for the board report.

Nixon

On Wed, Dec 12, 2018 at 3:34 AM Ashutosh Mestry 
wrote:

> +1 for the board report.
>
> ~ ashutosh
>
>
> On 12/11/18, 2:01 PM, "Sarath Subramanian"  wrote:
>
>- 1 new contributor added in last 3 months: Nikhil Bonte
>
>
>
>

Review Request 69566: ATLAS-2995 : Term Entity disassociation doesn't happen via knox proxy

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69566/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2995
https://issues.apache.org/jira/browse/ATLAS-2995


Repository: atlas


Description
---

ISSUE:

Request to disassociate a term from an entity via knox proxy succeeds , but the 
disassociation doesn't happen.

Cause:

Knox Proxy Gateway does not support DELETE method api with body.

Solution :-

Come up with another API with PUT method with body.


Diffs
-

  dashboardv2/public/js/models/VGlossary.js f33ef0fe1 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 8ae8f9993 


Diff: https://reviews.apache.org/r/69566/diff/1/


Testing
---

Tested with new api method from UI with put method.


Thanks,

Nixon Rodrigues

Re: Atlas ExportAPI & Read Only Permission -> You are not authorized

[Nixon Rodrigues]

Adding Atlas dev,

Tom,

Your concern is right, this issue similar to the exceptional case like
ATLAS-2442.
Please add w-WRITE permission to your user or group to overcome this issue.


Regards,
Nixon


On Thu, Dec 13, 2018 at 10:23 PM  wrote:

>
>
> Hi All,
> we configured an Atlas (Version 0.8.0 with HDP 2.6.4) read only Group via
> policy-store.txt and so far it is working fine…. But similar like the issue
> described in https://issues.apache.org/jira/browse/ATLAS-2442 the access
> to the export API fails with ‘You are not authorized for CREATE on
> [OPERATION]’
>
> < HTTP/1.1 403 {"AuthorizationError":"You are not authorized for CREATE on
> [OPERATION] : *"}
>
> To me it looks like the export API is using a POST (no GET) and so Atlas
> rejects the same similar as we had with ATLAS-2442.
>
> Sample curl export command:
> curl -X POST -v -u "user:PW" -H "Content-Type: application/json" -H
> "Cache-Control: no-cache" -d '{
> "itemsToExport": [
> {
>  "typeName": "hive_db",
>  "uniqueAttributes": { "name": "mydb" },
>  "status": "ACTIVE"
> }
> ],
> "options": {
> "fetchType": "connected",
> "matchType": "matches"
> }
> }' "http://myatlas-server.com:21000/api/atlas/admin/export"; -o output.txt
>
> Its my understanding that a ready only user should be able to export,
> isn’t it? Any thoughts?
>
> Regards,
> Tom
>
>

Review Request 69639: ATLAS-3012 :- Import of hive_db fails to create deleted column entity which was recreated again.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69639/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Graham Wallis, Madhan 
Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-3012
https://issues.apache.org/jira/browse/ATLAS-3012


Repository: atlas


Description
---

Following is the test scenario:

In the source cluster :
1. create table with 3 columns (id,name,dob)
2. drop column dob
3. add the same dob column again.

Now table has 3 ACTIVE columns and 1 DELETED column.

Export the db into the target cluster.

In the target cluster :
only 2 ACTIVE (id,name) and 1 DELETED (dob) column is present. The ACTIVE 
column (dob) is not present.

The exported zip contains both the DELETED and the ACTIVE dob column entity.

In the source cluster ,
if GUID1 is GUID of ACTIVE dob entity , and GUID2 is GUID of deleted dob entity.
In the target cluster , 
GUID1 is GUID of DELETED entity.

Example : 
In source :
ACTIVE: 
https://atlas_source_host/index.html#!/detailPage/7cca7064-8519-4db3-aab5-ebd446d15070

DELETED: https:// atlas_source_host 
/index.html#!/detailPage/f7686214-7585-4da3-875f-3e5223875289

In target :
DELETED : https:// atlas_target_host 
/index.html#!/detailPage/7cca7064-8519-4db3-aab5-ebd446d15070

Entity with GUID f7686214-7585-4da3-875f-3e5223875289 is not found.

---
**Root Cause of issue**

During import of zip. The exported zip has two colums one active status and 
other with deleted status. During preCreate with getResolvedEntityVertex is 
called since the uniqueAttributes of both columns are same only first is 
created and during second entity creeateUpdate only status is updated, due this 
one Entity is created. The issue in uniqueNess of AtlasObjectId since does not 
take status of Entity in account.

**Fix for this issue**
Added new unique attribute status to AtlasObjectId and modified equals and 
hashcode methods


Diffs
-

  intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
a8958a83f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java
 bd05c9877 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 066abc109 


Diff: https://reviews.apache.org/r/69639/diff/1/


Testing
---

Tested import & Exported with above scenario.
Ut/IT's are passing


Thanks,

Nixon Rodrigues

Review Request 69652: ATLAS-3017 : Add Atlas server statistics rest endpoint

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69652/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3017
https://issues.apache.org/jira/browse/ATLAS-3017


Repository: atlas


Description
---

New REST API which expose atlas server statistics.


API - /api/atlas/admin/stats

O/P in json

{"lastMessageProcessedTimeStamp":"2 Jan, 2019 : 07:33 PM 
IST","startOffset":10,"currentOffset":40,"avgMessageProcessingTime":"589 
milliseconds","serverUpTime":"18 min 57 sec","serverStartTimeStamp":"2 Jan, 
2019 : 07:26 PM IST","BackendActiveStatus":true}


Diffs
-

  dashboardv2/public/js/models/VCommon.js 062e1b681 
  dashboardv2/public/js/router/Router.js f32357570 
  dashboardv2/public/js/templates/common/AtlasStatistics_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/site/Header.html 2042c99d3 
  dashboardv2/public/js/utils/UrlLinks.js 1bc5949ff 
  dashboardv2/public/js/views/common/AtlasStatistics.js PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 003e5b01b 
  webapp/src/main/java/org/apache/atlas/util/StatisticsUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/model/AtlasStatistics.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
9659a3827 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
698529160 


Diff: https://reviews.apache.org/r/69652/diff/1/


Testing
---

Testing using Postman REST client and Atlas UI.


Thanks,

Nixon Rodrigues

Re: Review Request 69660: ATLAS-3019 Handle NPE while transform and replicatedTo in import-export

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69660/#review211666
---


Ship it!




Ship It!

- Nixon Rodrigues


On Jan. 3, 2019, 1:01 p.m., Kapildeo Nayak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69660/
> ---
> 
> (Updated Jan. 3, 2019, 1:01 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles
> 1) Export fails on setting replicatedTo value to null in export JSON
> 
> 2) Using transforms (replace) with both supertype and subtype fails with NPE 
> during import
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java 
> 0e93744f1 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java
>  72b684b01 
> 
> 
> Diff: https://reviews.apache.org/r/69660/diff/1/
> 
> 
> Testing
> ---
> 
> Tested in import-export with transforms options.
> 
> 
> Thanks,
> 
> Kapildeo Nayak
> 
>

Re: Consensus for migration of git repositories to gitbox

[Nixon Rodrigues]

Thanks Apoorv for volunteering this effort

+1 for migrating Atlas repositories to gitbox server.

Regards,
Nixon



On Thu, Jan 10, 2019 at 11:50 AM Apoorv Naik  wrote:

> Hi Atlas devs,
>
> There's an ASF initiative to migrate the git-wip-us-apache.org
> repositories
> to the gitbox server before Feb 7, after which it'll be mass migrated
> without a warning. I volunteer to take this migration effort to avoid any
> disruption to commit activity.
>
> PMCs and committers, please share your +1 or -1 vote for this move (this is
> the first step in starting the migration)
>
> *Apoorv Naik*
>

Re: Review Request 69392: ATLAS-2810 - Add notifications from RelationshipStore

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69392/#review212010
---


Ship it!




Ship It!

- Nixon Rodrigues


On Jan. 4, 2019, 1:21 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69392/
> ---
> 
> (Updated Jan. 4, 2019, 1:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2810
> https://issues.apache.org/jira/browse/ATLAS-2810
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Notifications for relationship mutations.
> 
> To enable notifications, set property 
> "atlas.notification.relationships.enabled" to true.
> If property is not specified, notifications will be disabled by default.
> 
> If enabled, this will add message to kafka topic when relationship is 
> added/updated/deleted.
> 
> Sample messages :
> 
> ADD
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787083448,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_ADD","eventTime":1544787072298}}
> 
> UPDATE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787404692,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_UPDATE","eventTime":1544787404679}}
> 
> DELETE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787460081,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"DELETED","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_DELETE","eventTime":1544787459708}}
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5357f5 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> cccf0d4 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationsh

Re: Review Request 69392: ATLAS-2810 - Add notifications from RelationshipStore

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69392/#review212015
---



Failed tests:
  GlossaryServiceTest.testAddTermsToCategory:712 Glossary category update 
should've succeeded
  GlossaryServiceTest.testTermAssignmentAndDissociation:793 Term update 
should've succeeded
  GlossaryServiceTest.testUpdateGlossaryCategory:521 Customer category fetch 
should've succeeded

Tests run: 594, Failures: 3, Errors: 0, Skipped: 25

- Nixon Rodrigues


On Jan. 4, 2019, 1:21 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69392/
> ---
> 
> (Updated Jan. 4, 2019, 1:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2810
> https://issues.apache.org/jira/browse/ATLAS-2810
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Notifications for relationship mutations.
> 
> To enable notifications, set property 
> "atlas.notification.relationships.enabled" to true.
> If property is not specified, notifications will be disabled by default.
> 
> If enabled, this will add message to kafka topic when relationship is 
> added/updated/deleted.
> 
> Sample messages :
> 
> ADD
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787083448,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_ADD","eventTime":1544787072298}}
> 
> UPDATE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787404692,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_UPDATE","eventTime":1544787404679}}
> 
> DELETE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787460081,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"DELETED","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP

Review Request 69822: ATLAS-3033 - ATLAS Hive hook fails for CTAS query involving UDFs

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69822/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3033
https://issues.apache.org/jira/browse/ATLAS-3033


Repository: atlas


Description
---

ATLAS Hive Hook fails to notify for CTAS queries involving UDFs, Hook fails 
with the exception as below

org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table not found 
_dummy_table.


FIX :-  Added fix to skip hive _dummy_table temp table while getting Table 
object details from hiveContext during lineage input creation.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
 249f48b5f 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
4a6b41786 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 5c52cf442 


Diff: https://reviews.apache.org/r/69822/diff/1/


Testing
---

Tested by creating hive table with CTAS which creates temp table.


Thanks,

Nixon Rodrigues

Re: Review Request 69822: ATLAS-3033 - ATLAS Hive hook fails for CTAS query involving UDFs

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69822/
---

(Updated Jan. 28, 2019, 12:21 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

This patch addresses review comments from Madhan N.


Bugs: ATLAS-3033
https://issues.apache.org/jira/browse/ATLAS-3033


Repository: atlas


Description
---

ATLAS Hive Hook fails to notify for CTAS queries involving UDFs, Hook fails 
with the exception as below

org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table not found 
_dummy_table.


FIX :-  Added fix to skip hive _dummy_table temp table while getting Table 
object details from hiveContext during lineage input creation.


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
 249f48b5f 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
4a6b41786 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 5c52cf442 


Diff: https://reviews.apache.org/r/69822/diff/2/

Changes: https://reviews.apache.org/r/69822/diff/1-2/


Testing
---

Tested by creating hive table with CTAS which creates temp table.


Thanks,

Nixon Rodrigues

Re: Review Request 69822: ATLAS-3033 - ATLAS Hive hook fails for CTAS query involving UDFs

[Nixon Rodrigues]

> On Jan. 28, 2019, 4:58 p.m., Madhan Neethiraj wrote:
> > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java
> > Lines 151 (patched)
> > <https://reviews.apache.org/r/69822/diff/2/?file=2122882#file2122882line151>
> >
> > Please replace hardcoded value "Values__Tmp__Table__" with constant 
> > SemanticAnalyzer.VALUES_TMP_TABLE_NAME_PREFIX.

Madhan,

For Hive 1.2.1 version the constant VALUES_TMP_TABLE_NAME_PREFIX is private,its 
causing compile time issue, so its hardcoded here. 

ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] 
~/atlas-gitbox/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java:[151,140]
 VALUES_TMP_TABLE_NAME_PREFIX has private access in 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer
[INFO] 1 error


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69822/#review212385
-------


On Jan. 28, 2019, 12:21 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69822/
> ---
> 
> (Updated Jan. 28, 2019, 12:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3033
> https://issues.apache.org/jira/browse/ATLAS-3033
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS Hive Hook fails to notify for CTAS queries involving UDFs, Hook fails 
> with the exception as below
> 
> org.apache.hadoop.hive.ql.metadata.InvalidTableException: Table not found 
> _dummy_table.
> 
> 
> FIX :-  Added fix to skip hive _dummy_table temp table while getting Table 
> object details from hiveContext during lineage input creation.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  249f48b5f 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 4a6b41786 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  5c52cf442 
> 
> 
> Diff: https://reviews.apache.org/r/69822/diff/2/
> 
> 
> Testing
> ---
> 
> Tested by creating hive table with CTAS which creates temp table.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 69392: ATLAS-2810 - Add notifications from RelationshipStore

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69392/#review212408
---


Ship it!




Ship It!

- Nixon Rodrigues


On Jan. 24, 2019, 10:34 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69392/
> ---
> 
> (Updated Jan. 24, 2019, 10:34 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2810
> https://issues.apache.org/jira/browse/ATLAS-2810
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Notifications for relationship mutations.
> 
> To enable notifications, set property 
> "atlas.notification.relationships.enabled" to true.
> If property is not specified, notifications will be disabled by default.
> 
> If enabled, this will add message to kafka topic when relationship is 
> added/updated/deleted.
> 
> Sample messages :
> 
> ADD
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787083448,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_ADD","eventTime":1544787072298}}
> 
> UPDATE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787404692,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_UPDATE","eventTime":1544787404679}}
> 
> DELETE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787460081,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"DELETED","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_DELETE","eventTime":1544787459708}}
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5357f5 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> cccf0d4 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationsh

Re: Review Request 69899: ATLAS-3045 - fix assembly generation for atlas-tools

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69899/#review212606
---


Ship it!




Ship It!

- Nixon Rodrigues


On Feb. 5, 2019, 4:16 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69899/
> ---
> 
> (Updated Feb. 5, 2019, 4:16 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-3045
> https://issues.apache.org/jira/browse/ATLAS-3045
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> * The atlas-server-package.xml incorrectly tries to include the jar, and the 
> shell script from atlas-migration-exporter
> * classification-updater is not added to that atlas-server-package.xml
> * There is no separate classification-updater assembly created
> * the tools are not built with the rest of the Atlas server
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 12a709c19 
>   distro/src/main/assemblies/atlas-server-package.xml 248645a60 
>   distro/src/main/assemblies/classification-updater.xml PRE-CREATION 
>   pom.xml d9b2c9dc8 
> 
> 
> Diff: https://reviews.apache.org/r/69899/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with executing: "mvn -B -nsu -Dfindbugs.skip=true -Pgpg 
> -DskipDocs=true -Pdist -DskipTests -DskipITs install"
> and investigating the generated zips under distro/target/...
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Import hive metadata in kerberized atlas

[Nixon Rodrigues]

Sanket,

Ideally in a kerberized cluster, every component is expected to be running
in Kerberos mode.

Please find Kerberos related properties used in Atlas with values

atlas.authentication.keytab=/etc/security/keytabs/atlas.service.keytab //
atlas service keytab
atlas.authentication.method.kerberos=true
atlas.authentication.method.kerberos.keytab=/etc/security/keytabs/spnego.service.keytab
// spengo service keytab
atlas.authentication.method.kerberos.principal=HTTP/_h...@example.com
atlas.authentication.method.kerberos.name.rules=RULE:[1:$1@$0](
ambari...@example.com)s/.*/ambari-qa/\.\DEFAULT

HTH


On Tue, Feb 26, 2019 at 11:21 AM Sanket Gaykar 
wrote:

> Hi,
>
> We have kerberized atlas setup on dedicated instance. Hbase (Kerberos) is
> used as a storage backend. Whereas hive metastore uses simple
> authentication.
>
> Properties set for kerberos in atlas-appication.properties:
>
> atlas.authentication.method.kerberos=true
> atlas.authentication.keytab=/etc/atlas.keytab
> atlas.authentication.principal=atlas/@
>
> While executing import-hive.sh on hive cluster we get error:
> "Authentication is enabled and user is not specified. Specify user.name
> parameter"
>
> We also found properties atlas.authentication.*method*.keytab
> atlas.authentication.*method*.principal in *AtlasAuthenticationFilter*
> class.
>
> Can someone please tell what should be the values for this properties?
>

Re: Import hive metadata in kerberized atlas

[Nixon Rodrigues]

>>Does hive atlas hook also uses this kerberos properties while importing
>> data from metastore?

Yes

On Tue, Feb 26, 2019 at 3:09 PM Sanket Gaykar 
wrote:

> Hi Nixon,
>
> Thanks for reply.
> Does hive atlas hook also uses this kerberos properties while importing
> data from metastore?
>
> On Tue, 26 Feb 2019 at 14:55, Nixon Rodrigues <
> nixon.rodrig...@freestoneinfotech.com> wrote:
>
> > Sanket,
> >
> > Ideally in a kerberized cluster, every component is expected to be
> running
> > in Kerberos mode.
> >
> > Please find Kerberos related properties used in Atlas with values
> >
> > atlas.authentication.keytab=/etc/security/keytabs/atlas.service.keytab //
> > atlas service keytab
> > atlas.authentication.method.kerberos=true
> >
> >
> atlas.authentication.method.kerberos.keytab=/etc/security/keytabs/spnego.service.keytab
> > // spengo service keytab
> > atlas.authentication.method.kerberos.principal=HTTP/_h...@example.com
> > atlas.authentication.method.kerberos.name.rules=RULE:[1:$1@$0](
> > ambari...@example.com)s/.*/ambari-qa/\.\DEFAULT
> >
> > HTH
> >
> >
> > On Tue, Feb 26, 2019 at 11:21 AM Sanket Gaykar <
> sanketgaykar@gmail.com
> > >
> > wrote:
> >
> > > Hi,
> > >
> > > We have kerberized atlas setup on dedicated instance. Hbase (Kerberos)
> is
> > > used as a storage backend. Whereas hive metastore uses simple
> > > authentication.
> > >
> > > Properties set for kerberos in atlas-appication.properties:
> > >
> > > atlas.authentication.method.kerberos=true
> > > atlas.authentication.keytab=/etc/atlas.keytab
> > > atlas.authentication.principal=atlas/@
> > >
> > > While executing import-hive.sh on hive cluster we get error:
> > > "Authentication is enabled and user is not specified. Specify
> user.name
> > > parameter"
> > >
> > > We also found properties atlas.authentication.*method*.keytab
> > > atlas.authentication.*method*.principal in *AtlasAuthenticationFilter*
> > > class.
> > >
> > > Can someone please tell what should be the values for this properties?
> > >
> >
>

Re: Review Request 70064: ATLAS-3058: fix for failure in saved-search

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70064/#review213248
---


Ship it!




Ship It!

- Nixon Rodrigues


On Feb. 27, 2019, 6:04 a.m., madhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70064/
> ---
> 
> (Updated Feb. 27, 2019, 6:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3058
> https://issues.apache.org/jira/browse/ATLAS-3058
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Saved-search entity references its parent entity via relationship-attribute 
> userProfile. During validation of saved-search entity, the referenced 
> user-profile entity is not found in the store, since the user-profile entity 
> is created only when first search is saved for this user. Updated to use 
> internal-guid to resolve entity referenced by userProfile 
> relationship-attribute (instead of resolving by unique-attribute).
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasSavedSearchDTO.java
>  1a24e67d0 
>   
> repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasUserProfileDTO.java
>  982d646b3 
> 
> 
> Diff: https://reviews.apache.org/r/70064/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that saving/update/delete of favorite-searches succeed
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/934/
> 
> 
> Thanks,
> 
> madhan
> 
>

Re: [DRAFT] Board report for Apache Atlas: March 2019

[Nixon Rodrigues]

Madhan thanks for draft, It looks good.

Slight correction in needed in 2.0.0 release date.

>> 2.0.0plan to release by 12/31/2018


Nixon


On Thu, Mar 14, 2019 at 6:50 AM Madhan Neethiraj  wrote:

> Atlas team,
>
>
>
> Please review the draft board report below and send your feedback/comments.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
> ## Description:
>
>   Apache Atlas is a scalable and extensible set of core foundational
>
>   governance services that enables enterprises to effectively and
> efficiently
>
>   meet their compliance requirements within Hadoop and allows integration
> with
>
>   the complete enterprise data ecosystem
>
>
>
> ## Issues:
>
>   There are no issues requiring board attention at this time.
>
>
>
> ## Activity:
>
>   - significant updates to lineage UI - faster rendering, searchability,
> option to hide entities, highlight selected entity path, ..
>
>   - added option to ignore/prune metadata for temporary/staging Hive tables
>
>   - support for custom icons per entity-type
>
>   - significant performance improvements during create/update of entities
>
>   - added support for notifications on relationship changes
>
>   - model updates to remove use of ownedRef/inverseRef constraints
>
>   - enhancements to enable Atlas to be a reference implementation for
> Egeria
>   - working on 2.0.0 release, to support Hadoop 3, HBase 2, Solr 7, Kafka
> 2, Hive 3
>
>
>
> ## Health report:
>
>   - 5 new contributors added in last 3 months: Aadarsh, Binit, Le Ma,
> Sridhar K, Sridhar S
>
>
>
> ## PMC changes:
>
>   - Currently 33 PMC members
>
>   - No new PMC members added in last 3 months
>
>   - Last PMC member addition was on 6/21/2017
>
>
>
> ## Committer base changes:
>
>   - Currently 38 committers
>
>   - No new committers added in last 3 months
>
>   - Last addition to committer role was on 10/15/2018
>
>
>
> ## Releases:
>
>   2.0.0plan to release by 12/31/2018
>
>   0.8.3was released on 10/31/2018
>
>   1.1.0was released on 09/17/2018
>
>   1.0.0was released on 06/02/2018
>
>   0.8.2was released on 02/05/2018
>
>   1.0.0-alpha  was released on 01/25/2018
>
>   0.8.1was released on 08/29/2017
>
>   0.8-incubating   was released on 03/16/2017
>
>   0.7.1-incubating was released on 01/26/2017
>
>   0.7-incubating   was released on 07/09/2016
>
>   0.6-incubating   was released on 12/31/2015
>
>   0.5-incubating   was released on 07/11/2015
>
>
>
>