Re: Review Request 61926: ATLAS-2088: add dev-test scripts to invoke Atlas REST APIs

2017-08-27 Thread Nixon Rodrigues
Atlas server, can you add pointer to this scripts in twiki docs so that it is visible to new users. - Nixon Rodrigues On Aug. 26, 2017, 10:11 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to render the search table in Advance search

2017-09-12 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62149/#review185143 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 7, 2017, 6:53

Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

2017-09-18 Thread Nixon Rodrigues
. Tested Atlas form based Login Tested Atlas api with basic and knox cookie header. Thanks, Nixon Rodrigues

Re: Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted attribute value on property table

2017-09-22 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62493/#review185985 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 22, 2017, 7:29

Re: Review Request 62504: ATLAS-2039 : Unable to edit date value from UI when entity definition is POSTed without value for date attribute.

2017-09-22 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62504/#review185987 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 22, 2017, 12

Re: Review Request 62494: ATLAS-1905 : Search UI is confusing to user

2017-09-22 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62494/#review185988 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 22, 2017, 7:47

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

2017-09-22 Thread Nixon Rodrigues
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62382/#review185556 --- On Sept. 18, 2017, 1:06 p.m., Nixon Rodrigues wrote: > > -

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

2017-09-22 Thread Nixon Rodrigues
://reviews.apache.org/r/62382/diff/2/ Changes: https://reviews.apache.org/r/62382/diff/1-2/ Testing --- Tested Atlas with knox authentication Tested Atlas knox proxy with Form login and Knox SSO. Tested Atlas form based Login Tested Atlas api with basic and knox cookie header. Thanks, Nixon

Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not get honored when logging into Atlas UI

2017-09-26 Thread Nixon Rodrigues
/AtlasADAuthenticationProvider.java Lines 143 (patched) <https://reviews.apache.org/r/62566/#comment262715> if adUserSearchFilter is null or isblank, set default string "(sAMAccountName={0})", check line number number 97. - Nixon Rodrigues On Sept. 26, 2017, 11:32 a.m., G

Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Nixon Rodrigues
and loaded sample data, UI is loading fine. Thanks, Nixon Rodrigues

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Nixon Rodrigues
Diff: https://reviews.apache.org/r/62568/diff/1/ Testing --- Testing cases working. Run Quick Start script and loaded sample data, UI is loading fine. Thanks, Nixon Rodrigues

Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not get honored when logging into Atlas UI

2017-09-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62566/#review186241 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 11

Re: Review Request 62561: ATLAS-2153 : UI : Adding more columns to the search table masks the "Remove tag" button

2017-09-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62561/#review186242 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 7:20

Re: Review Request 62560: ATLAS-2130 : Call made to fetch tables of a database doesn't have exlcudeDeletedEntities parameter

2017-09-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62560/#review186243 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 7:15

Re: Review Request 62559: ATLAS-2168 : When a second search is fired in between the pages of the first search results , offset is not reset to 0

2017-09-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62559/#review186244 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 26, 2017, 7:12

Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

2017-10-04 Thread Nixon Rodrigues
--- Tested Atlas UI/API with Atlas and knox Kerberized Env with & without proxy and also with SSO on/off. Tested curl with call with --negotiate headers. Tested curl with call with hadoop-jwt knox cookie header. Thanks, Nixon Rodrigues

Re: Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

2017-10-10 Thread Nixon Rodrigues
/62769/diff/1-2/ Testing --- Tested Atlas UI/API with Atlas and knox Kerberized Env with & without proxy and also with SSO on/off. Tested curl with call with --negotiate headers. Tested curl with call with hadoop-jwt knox cookie header. Thanks, Nixon Rodrigues

Re: Review Request 62769: ATLAS-2166 - Added validation to prevent kerberos authentication when knox-proxy adds hadoop-auth header to proxied request

2017-10-13 Thread Nixon Rodrigues
Testing --- Tested Atlas UI/API with Atlas and knox Kerberized Env with & without proxy and also with SSO on/off. Tested curl with call with --negotiate headers. Tested curl with call with hadoop-jwt knox cookie header. Thanks, Nixon Rodrigues

Re: Review Request 63460: ATLAS-2222 : UI, Search using entity and trait attributes - ", " in string attribute filter throws 400 Bad request.

2017-11-01 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63460/#review189795 --- Ship it! Ship It! - Nixon Rodrigues On Nov. 1, 2017, 11:03

Re: Review Request 63580: ATLAS-2250 : Upgrade JQuery version to 3.*

2017-11-07 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63580/#review190290 --- Ship it! Ship It! - Nixon Rodrigues On Nov. 6, 2017, 1:33

Review Request 64061: ATLAS-2276 : Path value for hdfs_path type entity is set to lower case from hive-bridge.

2017-11-24 Thread Nixon Rodrigues
/hook/HiveHook.java 57f5efb5 Diff: https://reviews.apache.org/r/64061/diff/1/ Testing --- HiveBridge unittest-cases running properly. Create table and verified the hive/hdfs_path entities in Atlas. Tested import-hive script and verified the hive/hdfs_path entities in Atlas. Thanks, Nixon

Re: Review Request 64061: ATLAS-2276 : Path value for hdfs_path type entity is set to lower case from hive-bridge.

2017-11-27 Thread Nixon Rodrigues
--- HiveBridge unittest-cases running properly. Create table and verified the hive/hdfs_path entities in Atlas. Tested import-hive script and verified the hive/hdfs_path entities in Atlas. Thanks, Nixon Rodrigues

Re: Review Request 64061: ATLAS-2276 : Path value for hdfs_path type entity is set to lower case from hive-bridge.

2017-11-28 Thread Nixon Rodrigues
. Thanks, Nixon Rodrigues

Re: Review Request 72903: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations. Remove Import Audit params.

2020-10-23 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72903/#review222112 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 23, 2020, 3:22

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

2020-10-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72987/#review222124 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 23, 2020, 5:43

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-27 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72991/#review222134 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 27, 2020, 8:21

Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

2020-10-29 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72993/#review222147 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 29, 2020, 9:34

Re: Review Request 72943: ATLAS-3988 : REST GET entity API with type's GUID throws NPE

2020-11-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72943/#review222162 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 21, 2020, 6:51

Re: Review Request 72943: ATLAS-3988 : REST GET entity API with type's GUID throws NPE

2020-11-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72943/#review222163 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 21, 2020, 6:51

Re: Review Request 73030: ATLAS-4034: Export operation audit with result count 0 for empty exports is inconsistent ATLAS-4041: operation status info of IMPORT/EXPORT operation in the Admin import/expo

2020-11-25 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73030/#review37 --- Ship it! Ship It! - Nixon Rodrigues On Nov. 20, 2020, 2:22

Re: Review Request 73047: ATLAS-4054 : Change Atlas config for atlas.jetty.request.buffer.size

2020-12-02 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73047/#review76 --- Ship it! Ship It! - Nixon Rodrigues On Dec. 1, 2020, 8:12

Re: Review Request 73047: ATLAS-4054 : Change Atlas config for atlas.jetty.request.buffer.size

2020-12-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73047/#review79 --- Ship it! Ship It! - Nixon Rodrigues On Dec. 3, 2020, 12:53

Re: Review Request 73057: ATLAS-3913 Swagger documentation for APIs

2020-12-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73057/#review86 --- Ship it! Ship It! - Nixon Rodrigues On Dec. 3, 2020, 12:29

Review Request 73142: ATLAS-4101 : 500 internal server error is thrown instead of 400 malformed request from atlas when the payload is malformed.

2021-01-13 Thread Nixon Rodrigues
xpected character (']' (code 93)): expected a value\n at [Source: (org.eclipse.jetty.server.HttpInputOverHTTP); line: 1, column: 42]\n at [Source: (org.eclipse.jetty.server.HttpInputOverHTTP); line: 1, column: 41] (through reference chain: org.apache.atlas.model.typedef.AtlasTypesDef[\\"classificationDefs\\"])"} Thanks, Nixon Rodrigues

Re: Review Request 73132: ATLAS-4079 : Atlas-Upgrade jackson to 2.11.0+

2021-01-17 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73132/#review222484 --- Ship it! Ship It! - Nixon Rodrigues On Jan. 12, 2021, 9:39

Re: Review Request 73150: ATLAS-2932: improvements for easier readability

2021-01-20 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73150/#review222506 --- Ship it! Ship It! - Nixon Rodrigues On Jan. 21, 2021, 4:25

Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-21 Thread Nixon Rodrigues
--- Tested on normal cluster with password stored in jceks file and TLS cluster with password stored in jceks file in Atlas. Thanks, Nixon Rodrigues

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-28 Thread Nixon Rodrigues
normal cluster with password stored in jceks file and TLS cluster with password stored in jceks file in Atlas. Thanks, Nixon Rodrigues

Re: Review Request 73210: ATLAS-3976 : On creating a type with a type_name that already exists as a read-only user 409 is thrown instead on 403

2021-03-01 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73210/#review222643 --- Ship it! Ship It! - Nixon Rodrigues On March 1, 2021, 2:56

Re: Review Request 73213: ATLAS-4183 Upgrade deployment descriptor for webapp project

2021-03-02 Thread Nixon Rodrigues
-ATLAS-Build-Test/422/console - Nixon Rodrigues On March 2, 2021, 3:45 p.m., Deep Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [DRAFT] Board report for Apache Atlas: March 2021

2021-03-09 Thread Nixon Rodrigues
Madhan, Thanks for compiling and putting the draft together for review. The draft looks good +1. Regards Nixon On Wed, Mar 10, 2021 at 11:26 AM Madhan Neethiraj wrote: > Atlas team, > > Please review the draft board report below and send your feedback/comments. > > Thanks, > Madhan > > ## Desc

Re: Review Request 73231: Typo in dhasboardv2/v3 Enum.js Enums.serverAudits.SERVER_STATE_PASSIVE value

2021-03-17 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73231/#review222693 --- Ship it! Ship It! - Nixon Rodrigues On March 16, 2021, 7:12

Re: TLS connection between ATLAS client and KAFKA cluster

2021-03-30 Thread Nixon Rodrigues
Hi Raju, For Kafka in TLS, following properties are needed from the atlas end. atlas.kafka.security.protocol=SASL_SSL atlas.kafka.ssl.keystore.type=jks atlas.kafka.ssl.truststore.type=jks atlas.kafka.ssl.truststore.location= cert.stores.credential.provider.path= or you can set password di

Re: Review Request 73275: ATLAS-4179 : [Atlas: Glossary Term Bulk Import] Incorrect error message when only dependent term is not present in bulk import

2021-04-11 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73275/#review222802 --- Ship it! Ship It! - Nixon Rodrigues On April 9, 2021, 9:26

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

2021-04-22 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73271/#review222849 --- Ship it! Ship It! - Nixon Rodrigues On April 14, 2021, 6:40

Re: Review Request 73343: ATLAS-4279: Precommit is failing for DebugMetricsIT testcase

2021-05-10 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73343/#review222960 --- Ship it! Ship It! - Nixon Rodrigues On May 10, 2021, 7:04

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-05-14 Thread Nixon Rodrigues
n#L194 - Nixon Rodrigues On April 30, 2021, 7:39 a.m., Josh Yeh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 73375: Handle Spool Directory Creation by Different Users

2021-05-26 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73375/#review223049 --- Ship it! Ship It! - Nixon Rodrigues On May 25, 2021, 9:42

Re: Review Request 73388: ATLAS-4174 : [Atlas: Glossary Term Bulk Import] When the file size is large (5 mb) bulk import times out

2021-05-27 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73388/#review223063 --- Ship it! Ship It! - Nixon Rodrigues On May 27, 2021, 7:06

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

2021-06-03 Thread Nixon Rodrigues
/ProcessNamePatch.java Lines 120 (patched) <https://reviews.apache.org/r/73405/#comment312233> Add if debug is enabled case. if (LOG.isDebugEnabled()) { same for line 129 - Nixon Rodrigues On June 3, 2021, 9:43 p.m., Ashutosh Mestry

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

2021-06-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73405/#review223101 --- Ship it! Ship It! - Nixon Rodrigues On June 3, 2021, 9:43

Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

2021-06-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73317/#review223102 --- Ship it! Ship It! - Nixon Rodrigues On June 1, 2021, 6:59

Re: Review Request 73445: ATLAS-4350: Atlas - Jetty Version disclosure in http response

2021-07-08 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73445/#review223205 --- Ship it! Ship It! - Nixon Rodrigues On July 8, 2021, 10:52

Re: Review Request 73442: ATLAS-4150 Remove System Internal Entity Types from Metrics GET api

2021-07-12 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73442/#review223212 --- Ship it! Ship It! - Nixon Rodrigues On July 9, 2021, 7:41

Review Request 73453: ATLAS-4353 - Atlas typedef name issue with name="name"

2021-07-12 Thread Nixon Rodrigues
h name "name" with different category. Also tested java patch in upgrade scenario. https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/744/console Thanks, Nixon Rodrigues

Re: Planning for Apache Atlas 2.2.0 release

2021-07-28 Thread Nixon Rodrigues
+1 for the Atlas 2.2.0 release. Thanks Siddharth for volunteering the release. Regards, Nixon Rodrigue On Wed, Jul 28, 2021 at 1:23 PM Madhan Neethiraj wrote: > +1 for Apache Atlas 2.2.0 release. It has been a while now! > > > > Thanks Sid! > > > > Madhan > > > > > > *From: *Nikhil Bonte > *

Re: Review Request 73499: ATLAS-4382: Change pom version from 2.2.0-SNAPSHOT to 2.2.0

2021-08-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73499/#review223305 --- Remove empty file with name "test" - Nixon Rodrigues

Re: Review Request 73499: ATLAS-4382: Change pom version from 2.2.0-SNAPSHOT to 2.2.0

2021-08-04 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73499/#review223308 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 4, 2021, 4:31

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

2021-08-09 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73502/#review223327 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 5, 2021, 7:16

Re: [VOTE] Release Apache Atlas version 2.2.0 - rc1

2021-08-10 Thread Nixon Rodrigues
* Verified metric API, statistics modal. Regards Nixon Rodrigues

Re: [VOTE] Release Apache Atlas version 2.2.0 - rc1

2021-08-10 Thread Nixon Rodrigues
* Verified metric API, statistics modal. Regards Nixon Rodrigues On Tue, Aug 10, 2021 at 4:04 PM Nikhil Bonte < nikhil.bo...@freestoneinfotech.com> wrote: > Hi Sidharth > > +1 for Apache Atlas v2.2.0 rc1. > > Verified following: > * Verified md5, sha512, Signature >

Re: Review Request 73508: ATLAS-4233 [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

2021-08-17 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73508/#review223346 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 10, 2021, 6:09

Re: Review Request 73534: ATLAS-4385: Update version in branch-2.0 to 2.3.0-SNAPSHOT

2021-08-24 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73534/#review223386 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 25, 2021, 6:17

Re: Review Request 73536: ATLAS-4379 :- Atlas Filter changes for user inactivity on Atlas UI

2021-08-30 Thread Nixon Rodrigues
://reviews.apache.org/r/73536/diff/3/ Changes: https://reviews.apache.org/r/73536/diff/2-3/ Testing --- Tested Atlas UI flow on kerberos with trusted proxy and simple authentication flow. PC https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/819/console Thanks, Nixon Rodrigues

Re: Review Request 73536: ATLAS-4379 :- Atlas Filter changes for user inactivity on Atlas UI

2021-08-31 Thread Nixon Rodrigues
://reviews.apache.org/r/73536/diff/3-4/ Testing --- Tested Atlas UI flow on kerberos with trusted proxy and simple authentication flow. PC https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/819/console Thanks, Nixon Rodrigues

Re: [DRAFT] [REPORT] Apache Atlas - Sep-2021

2021-09-09 Thread Nixon Rodrigues
Madhan, Thanks for putting the draft for review. It Looks good to me. Regards, Nixon On Fri, 10 Sept 2021 at 06:51, Madhan Neethiraj wrote: > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > > ## Description: > The mission of Apache Atla

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-21 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73599/#review223512 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 21, 2021, 6:38

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73654/#review223630 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 19, 2021, 11:27

Re: Review Request 73639: ATLAS-4446 : Atlas - Upgrade elasticsearch to 7.14.0

2021-10-25 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73639/#review223669 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 22, 2021, 8:11

Re: Review Request 73347: ATLAS-4159 Fix build failure on Linux ARM64

2021-10-29 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73347/#review223695 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 29, 2021, 12:50

Re: Review Request 73691: ATLAS-4431: Random NPE when retrieving tasks (“part2 - additional null check”)

2021-11-08 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73691/#review223716 --- Ship it! Ship It! - Nixon Rodrigues On Nov. 8, 2021, 11:33

Re: [DRAFT] [REPORT] Apache Atlas - Dec-2021

2021-12-08 Thread Nixon Rodrigues
Thanks Madhan for putting this together. Draft report looks good to me. Regards, Nixon On Wed, 8 Dec 2021 at 14:50, Madhan Neethiraj wrote: > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > ## Description: > The mission of Apache Atlas

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73747/#review223826 --- Ship it! Ship It! - Nixon Rodrigues On Dec. 9, 2021, 12:26

Re: Review Request 73796: ATLAS-4528: updated log4j2 version to 2.17.1; removed references to org.apache.logging.NDC

2022-01-10 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73796/#review223945 --- Ship it! Ship It! - Nixon Rodrigues On Jan. 10, 2022, 3:58

Re: Review Request 73798: ATLAS-4529 : DSL Search : OrderBy does not work for ScriptEngineBasedExecutor (gremlin groovy)

2022-01-12 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73798/#review223957 --- Ship it! Ship It! - Nixon Rodrigues On Jan. 12, 2022, 8:55

Re: Review Request 73837: ATLAS-4552: added network name for all Atlas docker images

2022-02-10 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73837/#review224030 --- Ship it! Ship It! - Nixon Rodrigues On Feb. 10, 2022, 7:25

Re: Review Request 74027: ATLAS-4622: import fix to handle invalid zip entry

2022-06-16 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74027/#review224513 --- Ship it! Ship It! - Nixon Rodrigues On June 16, 2022, 12:11

Re: Review Request 74047: ATLAS:4558: Fix AtlasRepairIndex tool when tls is enabled

2022-07-06 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74047/#review224543 --- Ship it! Ship It! - Nixon Rodrigues On July 6, 2022, 1:09

Re: [DRAFT] [REPORT] Apache Atlas - July 2022

2022-07-10 Thread Nixon Rodrigues
+1 for the draft report. looks good. Thanks Madhan for putting the draft report in for review. Regards Nixon On Mon, 11 Jul 2022 at 11:16, Madhan Neethiraj wrote: > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > ## Description: > The mi

Re: Review Request 74063: ATLAS-4642: updated plugin classloader to remove use of non-final static class member

2022-07-21 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74063/#review224572 --- Ship it! Ship It! - Nixon Rodrigues On July 21, 2022, 1:06

Re: Review Request 73623: ATLAS-4442 : Support Relationship search

2022-09-11 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73623/#review224659 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 6, 2022, 7:48

Re: Review Request 73623: ATLAS-4442 : Support Relationship search

2022-09-11 Thread Nixon Rodrigues
> On Sept. 12, 2022, 5:16 a.m., Nixon Rodrigues wrote: > > Ship It! Good feature to have in Atlas - Nixon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73623/#rev

Re: Review Request 74163: ATLAS-4681: Relationship Search : SortBy is not working

2022-10-14 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74163/#review224793 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 12, 2022, 11:27

Re: [VOTE] Release Apache Atlas 2.3.0 rc1

2022-12-04 Thread Nixon Rodrigues
+1 for the Atlas 2.3.0 RC#1 for release The RC bits build looks good. Thanks Madhan for putting this together for release voting. Thanks and Regards Nixon Rodrigues On Sun, 4 Dec 2022 at 20:58, Nikhil Bonte wrote: > +1 for the Apache Atlas 2.3.0 release candidate #1. > > Performed

Re: [DRAFT] [REPORT] Apache Atlas - March 2023

2023-03-12 Thread Nixon Rodrigues
The draft report looks good. +1 Thanks Madhan for compiling it. Regards Nixon On Mon, 13 Mar 2023 at 07:46, Madhan Neethiraj wrote: > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > > > ## Description: > > The mission of Ap

Re: Review Request 71113: [ATLAS-3319] Add api to get lineage by uniqueAttributes

2019-07-18 Thread Nixon Rodrigues
http://atlas.apache.org/api/v2/resource_EntityREST.html#resource_EntityREST_getEntitiesByUniqueAttributes_GET - Nixon Rodrigues On July 18, 2019, 5:20 a.m., jiaqi shan wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use relationship attribute

2019-07-18 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71064/#review216722 --- Ship it! Ship It! - Nixon Rodrigues On July 15, 2019, 11:17

Re: Review Request 71115: ATLAS-3335 Update Sqoop/Storm hook to use relationship attributes

2019-07-18 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71115/#review216756 --- Ship it! Ship It! - Nixon Rodrigues On July 18, 2019, 1:50

Re: Review Request 71115: ATLAS-3335 Update Sqoop/Storm hook to use relationship attributes

2019-07-18 Thread Nixon Rodrigues
/PreCommit-ATLAS-Build-Test/1285/console - Nixon Rodrigues On July 18, 2019, 1:50 p.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 71129: [ATLAS-3344]-Atlas Metrics to include topic partition wise additional information

2019-07-25 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71129/#review216854 --- Ship it! Ship It! - Nixon Rodrigues On July 23, 2019, 8:59

Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.

2019-07-28 Thread Nixon Rodrigues
Lines 75 (patched) <https://reviews.apache.org/r/71160/#comment304149> Is there any need to type check for number here ? - Nixon Rodrigues On July 28, 2019, 6:22 p.m., Mandar Ambawane wrote: > > --- > This is a

Re: Review Request 71276: ATLAS-3369: Renaming an hive_table creates a new table and updates the existing table

2019-08-12 Thread Nixon Rodrigues
/events/AlterTableRename.java Line 39 (original), 39 (patched) <https://reviews.apache.org/r/71276/#comment304445> Can you fix this auto-import (*). - Nixon Rodrigues On Aug. 13, 2019, 6:21 a.m., Sarath Subramanian wrote: > > -

Re: Review Request 71270: Table-level Export & Import: Preserving REPL Additional Info

2019-08-12 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71270/#review217173 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 11, 2019, 4:56

Re: Review Request 71406: ATLAS-3387 Consider X-FORWARDED-FOR header for getting end user IP address when connected with proxy

2019-09-09 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71406/#review217646 --- Ship it! Ship It! - Nixon Rodrigues On Sept. 9, 2019, 5:32

Re: [DRAFT] Board report for Apache Atlas: September 2019

2019-09-11 Thread Nixon Rodrigues
Thanks Madhan for putting this together. Can you review and add ( ATLAS-3153 :- Add Keycloak authentication method to Atlas.) Looks good to me, +1 for the draft. Regards, Nixon On Thu, Sep 12, 2019 at 7:48 AM Madhan Neethiraj wrote: > Atlas team, > > Please review the draft board report belo

Review Request 71631: ATLAS-3427 - Atlas hooks enhancements for better fault-tolerance i.e. Kafka unavailability

2019-10-17 Thread Nixon Rodrigues
he/atlas/spool/SpoolFileStatus.java PRE-CREATION notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 1ae7c278c Diff: https://reviews.apache.org/r/71631/diff/1/ Testing --- Tested spooling on hive with atlas hive hook enabled in simple and kerberos env. Existing testcase working fine. Thanks, Nixon Rodrigues

Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet

2019-10-18 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71623/#review218290 --- Ship it! Ship It! - Nixon Rodrigues On Oct. 18, 2019, 10:31

Review Request 71640: ATLAS-3481:Hive Hook fails with "org.apache.kafka.common.KafkaException: Failed to load SSL keystore"

2019-10-21 Thread Nixon Rodrigues
he.org/job/PreCommit-ATLAS-Build-Test/1481/console Thanks, Nixon Rodrigues

Re: Review Request 71637: ATLAS-3488 Update with Filebase auth password with ShaPasswordEncoder with salt

2019-10-23 Thread Nixon Rodrigues
, Nixon Rodrigues, Sarath Subramanian, and Vishal Suvagia. Repository: atlas Description --- This patch updates the password encoder for filebased authentication with Sha256PasswordEncoder with salt. Updated the password in user-credentials file. Also added utility generate password

Re: Review Request 71637: ATLAS-3488 Update with Filebase auth password with ShaPasswordEncoder with salt

2019-10-24 Thread Nixon Rodrigues
, Nixon Rodrigues, Sarath Subramanian, and Vishal Suvagia. Changes --- Addressed Review comments by Madhan, Ashutosh & Sarath. Added fallback for authentication with v1 passwords. Added testcase for v1 password. Bugs: ATLAS-3488 https://issues.apache.org/jira/browse/ATLAS-

<    1   2   3   4   5   6   7   8   9   10   >