Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-26 Thread Madhan Neethiraj
> On Aug. 25, 2017, 4:31 a.m., Madhan Neethiraj wrote: > > distro/src/bin/atlas_config.py > > Lines 474 (patched) > > > > > > Instead hardcoding "localhost", use the config value of > > "atlas.server.bind.address".

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review183889 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 16, 2017, 11:15

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Richard Ding via Review Board
> On Aug. 25, 2017, 9:55 a.m., Nigel Jones wrote: > > distro/src/bin/atlas_start.py > > Lines 134 (patched) > > > > > > I notice we have a hardcoded max time of 5 minutes. I wonder if there's > > any scenarios where

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Richard Ding via Review Board
> On Aug. 25, 2017, 4:31 a.m., Madhan Neethiraj wrote: > > distro/src/bin/atlas_config.py > > Lines 474 (patched) > > > > > > Instead hardcoding "localhost", use the config value of > > "atlas.server.bind.address".

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Nigel Jones
> On Aug. 11, 2017, 12:11 p.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic t

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Nigel Jones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review183837 --- distro/src/bin/atlas_start.py Lines 134 (patched)

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review183822 --- distro/src/bin/atlas_config.py Lines 474 (patched)

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
> On Aug. 16, 2017, 9:22 a.m., David Radley wrote: > > distro/src/bin/atlas_start.py > > Lines 134 (patched) > > > > > > You are passing an empty string as the message. I suggest removing this > > parameter and hard

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- (Updated Aug. 16, 2017, 11:15 p.m.) Review request for atlas, David Radley, Mad

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic t

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review183025 --- distro/src/bin/atlas_start.py Lines 134 (patched)

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread David Radley
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic t

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-15 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- (Updated Aug. 15, 2017, 10:08 p.m.) Review request for atlas, David Radley, Mad

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-14 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- (Updated Aug. 14, 2017, 11:19 p.m.) Review request for atlas, David Radley, Mad

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-14 Thread Richard Ding via Review Board
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic t

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-11 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review182676 --- distro/src/bin/atlas_config.py Lines 71 (patched)

Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-10 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath Subramanian