ps://reviews.apache.org/r/47658/#review136133
-------
On June 3, 2016, 1:55 p.m., David Kantor wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47658/
> -
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review136132
-------
On June 3, 2016, 1:55 p.m., David Kantor wrote:
>
> ---
> This is an automatically generated e-mai
generated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review136791
-------
On June 6, 2016, 10:53 p.m., David Kantor wrote:
>
> ---
> Thi
.
Thanks,
David Kantor
Diff: https://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
do we need the HashSet since contains and all will both O(n)
>
> David Kantor wrote:
> HashSet.contains is O(1). I am using the HashSet to avoid the O(n)
> performance of ArrayList.contains. For a very small data set, the difference
> between HashSet.contains and Ar
t; > for map types, can we check if the reverseAttributeName is set on the
> > map type and remove it if set else ignore?
>
> David Kantor wrote:
> I'm thinking it may be better to remove the reverse attribute name when
> the type is registered and possibly issue a warning th
://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
/atlas/web/listeners/TestModule.java
9cb76d3d1660a0c806296c41d8108acc8925d3d0
Diff: https://reviews.apache.org/r/48565/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
t; > for map types, can we check if the reverseAttributeName is set on the
> > map type and remove it if set else ignore?
>
> David Kantor wrote:
> I'm thinking it may be better to remove the reverse attribute name when
> the type is registered and possibly issue a warning th
ed. Failing after waiting for timeout 80000 msecs
> >
> > Tests run: 43, Failures: 2, Errors: 0, Skipped: 0
>
> David Kantor wrote:
> I am getting this test failure, will investigate.
>
> David Kantor wrote:
> I have investigated th
unit and integration tests with no regressions.
Thanks,
David Kantor
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48565/#review138785
-------
On June 20, 2016, 9:57 p.m., David Kantor wrote:
>
> ---
> This
DEBUG?
webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java (line 85)
<https://reviews.apache.org/r/48945/#comment203852>
See earlier comment about changing log level to INFO.
- David Kantor
On June 20, 2016, 12:01 p.m., Shwe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48760/#review137871
---
Ship it!
Ship It!
- David Kantor
On June 15, 2016, 10:35
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
ed. Failing after waiting for timeout 80000 msecs
> >
> > Tests run: 43, Failures: 2, Errors: 0, Skipped: 0
>
> David Kantor wrote:
> I am getting this test failure, will investigate.
>
> David Kantor wrote:
> I have investigated th
://reviews.apache.org/r/45542/diff/
Testing
---
Ran all unit and integration tests with no regressions. Added test cases
Thanks,
David Kantor
hanism like Guice.
Also, for our use cases, it would be strongly preferable to enable hard delete
at the API and/or type level and not be limited to a system-wide configuration.
- David Kantor
On April 12, 2016, 3:27 p.m., Shwetha GS
test cases
Thanks,
David Kantor
---
Ran all unit and integration tests with no regressions. Added test cases to
GraphBackedTypeStoreTest
Thanks,
David Kantor
se/windows-hbase-site.xml.template PRE-CREATION
distro/src/test/python/scripts/TestMetadata.py
bb74f2004501473fc726fe58e8f9ad1ead3e18f1
Diff: https://reviews.apache.org/r/46444/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
eviews.apache.org/r/46444/#review129941
---
On April 30, 2016, 12:04 a.m., David Kantor wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46444/
> ---
and integration tests with no regressions. Added test cases
Thanks,
David Kantor
/apache/atlas/repository/graph/ReverseReferenceUpdateTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
a0175363eb5d613c97fe0f83c04dac0d7333ff55
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/47658/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47466/#review134008
---
Ship it!
Ship It!
- David Kantor
On May 18, 2016, 2:56 p.m
with no regressions.
Thanks,
David Kantor
this as Set and check on just typeName?
>
> David Kantor wrote:
> I don't understand how checking typeName would avoid the infinite
> recursion. The problem use case is when structs reference each other. So
> let's say there is a bi-directional reference between A and B. Whe
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/#review130045
-------
On April 29, 2016, 7:24 p.m., David Kantor wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46646/#review131314
---
Ship it!
Ship It!
- David Kantor
On May 2, 2016, 2:13 p.m
/GraphDatabase.java
(line 21)
<https://reviews.apache.org/r/46646/#comment195256>
Add more detail to javadoc
- David Kantor
On May 2, 2016, 3:58 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generated e
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/46444/#review131634
-------
On May 4, 2016, 4:04 p.m., David Kantor wrote:
>
> ---
> This is an automati
46444/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
with no regressions. Added test cases
Thanks,
David Kantor
king to the
structs themselves, which are not singletons like FieldMapping.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/#review128589
-------
Testing
---
Ran all unit and integration tests with no regressions. Added test cases
Thanks,
David Kantor
lp with this? Please advise.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/#review129505
---
On April
ws.apache.org/r/46330/#comment193032>
So the type system is being re-initialized every time get() is called?
Could be a performance issue.
- David Kantor
On April 18, 2016, 1:43 p.m., venkata madugundu wrote:
>
> ---
&g
> On April 12, 2016, 10:20 p.m., David Kantor wrote:
> > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java,
> > line 90
> > <https://reviews.apache.org/r/46011/diff/2/?file=1341479#file1341479line90>
> >
> > Configuring hard del
enough knowledge of
scala to do a meaningful. Please remove any extra whitespace denoted by red
blocks in the diff.
- David Kantor
On July 22, 2016, 2:05 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
. The fact that
it breaks StoreBackedTypeCache is a concern.
- David Kantor
On July 12, 2016, 4:11 p.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
8a0a6bc60818c3dd58e12386c55a471de2508b5e
Diff: https://reviews.apache.org/r/49869/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
/LineageQueryTest.scala
0e0ac8633a256dc7c8966c2b8d52eb942b52e1c6
Diff: https://reviews.apache.org/r/49929/diff/
Testing
---
All repository tests now pass, regardless of test order.
Thanks,
David Kantor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47466/#review144818
---
Ship it!
Ship It!
- David Kantor
On Aug. 4, 2016, 6:37 p.m
eviews.apache.org/r/49869/#review144724
-------
On Aug. 5, 2016, 3:12 a.m., David Kantor wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49869/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47466/#review145010
---
Ship it!
Ship It!
- David Kantor
On Aug. 5, 2016, 10:19 p.m
/GraphHelperTest.java
8a0a6bc60818c3dd58e12386c55a471de2508b5e
Diff: https://reviews.apache.org/r/49869/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
://reviews.apache.org/r/49869/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
c426d50f52dfd99835d9fcf1c6f95841ba4b5494
Diff: https://reviews.apache.org/r/48565/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
/cache/DefaultTypeCacheProviderTest.java
c426d50f52dfd99835d9fcf1c6f95841ba4b5494
Diff: https://reviews.apache.org/r/48565/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
ginal superTypes
optimization - and should be removed.
- David Kantor
On Jan. 31, 2017, 2:11 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generate
417/#comment236526>
What happens if there is no open transaction? Is rollback() a no-op or
otherwise innocuous? I assume it must be innocuous otherwise there would be
other problems.
- David Kantor
On Feb. 8, 2017, 12:47 a.m., Jeff Hagelberg
/56463/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
/main/java/org/apache/atlas/web/dao/UserDao.java
254d836e5389780b6d10a8d1a664a96b06ad8d1b
Diff: https://reviews.apache.org/r/56463/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
tests with no regressions.
Thanks,
David Kantor
dy applied this same change on
the fork.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/#review164757
------
/typesystem/types/utils/TypesUtil.java
5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
and integration tests with no regressions.
Thanks,
David Kantor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56102/#review163974
---
Ship it!
Ship It!
- David Kantor
On Feb. 1, 2017, 9:41 p.m
On Jan. 30, 2017, 10:42 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56102/
> -------
>
&g
> On Jan. 30, 2017, 9:04 p.m., David Kantor wrote:
> > .gitignore, line 1
> > <https://reviews.apache.org/r/54858/diff/3/?file=1604866#file1604866line1>
> >
> > Please set the bugs field to ATLAS-1378 and fix the summary to mention
> > ATLAS-1378 rathe
> On Jan. 5, 2017, 2:19 p.m., David Kantor wrote:
> > Hi Neeru, I've committed these changes and resolved ATLAS-1379. Please
> > close this review request as submitted. Thanks...
As requested on 1/5, please close this request as submitted, th
g/r/56283/#comment236039>
Add javadoc which explains what these methods are doing.
webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java (line 1)
<https://reviews.apache.org/r/56283/#comment236040>
Needs Apache header. Remove extra whitespace.
- David Kantor
On Feb. 6, 201
/atlas/repository/typestore/GraphBackedTypeStore.java
(line 95)
<https://reviews.apache.org/r/56126/#comment235497>
typo
- David Kantor
On Jan. 31, 2017, 8:22 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatica
858/#comment235024>
Please set the bugs field to ATLAS-1378 and fix the summary to mention
ATLAS-1378 rather than 1178.
- David Kantor
On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163571
---
Ship it!
Ship It!
- David Kantor
On Jan. 13, 2017, 4:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56856/#review166105
---
Ship it!
Ship It!
- David Kantor
On Feb. 20, 2017, 7:03 p.m
Is there a JIRA for the specific changes described here? If so, mentioned
the JIRA. If not, create one and mention it here.
- David Kantor
On Feb. 17, 2017, 4 p.m., Neeru Gupta wrote:
>
>
> On Feb. 17, 2017, 9:59 p.m., David Kantor wrote:
> > graphdb/titan1/readme.txt, line 30
> > <https://reviews.apache.org/r/56289/diff/5/?file=1638465#file1638465line30>
> >
> > "Configure the Atlas runtime to use Titan 1 by setting the
> >
eviews.apache.org/r/56860/#review166552
---
On Feb. 22, 2017, 11:48 p.m., David Kantor wrote:
>
> ---
> This is an automatically generated e-mail. To re
://reviews.apache.org/r/56860/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
es.
Good idea, I have applied the suggested changes.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56860/#review166483
------
://reviews.apache.org/r/56860/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java
PRE-CREATION
Diff: https://reviews.apache.org/r/56860/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
by Shwetha Shivalingamurthy. Perhaps she could comment on this.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56860/#review166483
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54899/#review164998
---
Ship it!
Ship It!
- David Kantor
On Feb. 9, 2017, 6:02 p.m
/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
-credentials.properties PRE-CREATION
webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java
254d836e5389780b6d10a8d1a664a96b06ad8d1b
Diff: https://reviews.apache.org/r/56463/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56463/#review165171
---
On Feb. 12, 2017, 5:41 p.m., David Kantor wrote:
>
> ---
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
V1 changes, please
post them to https://reviews.apache.org/r/56287/
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review165156
------
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java
5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
,
David Kantor
/TypesUtil.java
5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
at check the
use atlas.conf and the classpath.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56463/#review164967
--------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165870
---
Ship it!
Ship It!
- David Kantor
On Feb. 16, 2017, 6:55 a.m
://reviews.apache.org/r/56860/diff/4/
Changes: https://reviews.apache.org/r/56860/diff/3-4/
Testing
---
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
ren and parent pointers are out of sync.
> >
> > Am I missing something?
I added a test case that mimics your use case and could not reproduce the issue
- when I get the EntityA instance its children attribute contains the EntityB
instance, indicating the inverse reference w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54759/#review159368
---
Ship it!
Ship It!
- David Kantor
On Dec. 15, 2016, 5:20 p.m
ove this or change the level
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
(line 319)
<https://reviews.apache.org/r/54430/#comment230004>
looks like typo, i.e there is no space between p
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review157795
---
Ship it!
- David Kantor
On Dec. 2, 2016, 4:52 p.m., Neeru
. It will be committed
tomorrow (Wed Jan 4 2016) unless there are further comments on review board.
- David Kantor
On Jan. 3, 2017, 8:21 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
al replace of "Tinker Pop" with "TinkerPop"
graphdb/ibm-graph/readme.txt
Lines 79 (patched)
<https://reviews.apache.org/r/56724/#comment239449>
Remove "The"
graphdb/ibm-graph/readme.txt
Lines 94 (patched)
<https://reviews.apache.o
David Kantor created ATLAS-246:
--
Summary: QuickStart uses integer data type for dates, which causes
data loss
Key: ATLAS-246
URL: https://issues.apache.org/jira/browse/ATLAS-246
Project: Atlas
[
https://issues.apache.org/jira/browse/ATLAS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969828#comment-14969828
]
David Kantor commented on ATLAS-246:
I will be submitting a fix for this issue, so please assign
[
https://issues.apache.org/jira/browse/ATLAS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Kantor updated ATLAS-246:
---
Attachment: ATLAS-246-v0.patch
Patch for ATLAS-246
> QuickStart uses integer data type for da
David Kantor created ATLAS-257:
--
Summary: import_hive.sh fails when run under cygwin
Key: ATLAS-257
URL: https://issues.apache.org/jira/browse/ATLAS-257
Project: Atlas
Issue Type: Bug
1 - 100 of 353 matches
Mail list logo
