Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build #41

://reviews.apache.org/r/36935/#comment147957 { is missing - Suma Shivaprasad On July 30, 2015, 9:33 a.m., Shwetha GS wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36935

Re: Review Request 36935: ATLAS-86 Jenkins build failing as of build #41

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36935/#review93574 --- Can we run tests in distributed mode once? - Suma Shivaprasad

Review Request 37036: Configuration files and scripts for solr deployment

/ Testing --- NA Thanks, Suma Shivaprasad

Re: Review Request 37285: solr conf files and changes to make it work with upgraded titan

/atlasConfig/conf/stopwords.txt PRE-CREATION src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION Diff: https://reviews.apache.org/r/37285/diff/ Testing --- All tests pass . No new tests added Thanks, Suma Shivaprasad

Re: Review Request 37285: solr conf files and changes to make it work with upgraded titan

/solr/atlasConfig/conf/stopwords.txt PRE-CREATION src/conf/solr/atlasConfig/conf/synonyms.txt PRE-CREATION Diff: https://reviews.apache.org/r/37285/diff/ Testing --- All tests pass . No new tests added Thanks, Suma Shivaprasad

Review Request 37285: solr conf files and changes to make it work with upgraded titan

src/conf/solr/zoo.cfg PRE-CREATION Diff: https://reviews.apache.org/r/37285/diff/ Testing --- All tests pass . No new tests added Thanks, Suma Shivaprasad

Re: Review Request 37181: ATLAS-59 De-duping of entities

+1 - Suma Shivaprasad On Aug. 6, 2015, 11:59 a.m., Shwetha GS wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37181

Re: Review Request 36724: ATLAS-80 Support for variables in application properties

(line 99) https://reviews.apache.org/r/36724/#comment147345 +1. LGTM. Minor nit. Please correct indentation in the substituteVars function - Suma Shivaprasad On July 24, 2015, 5:52 a.m., Shwetha GS wrote

Re: Falcon

Hi Nigel, Yes the Falcon plugin was removed since it was not yet mature. Only HIve plugin is available as of now.There is work in progress to make these plugins reliable - https://issues.apache.org/jira/browse/ATLAS-58 The plan is to work on Storm and Kafka plugins next. Falcon is not yet planned

Re: Review Request 36359: Create configuration properties for HTTP and HTTPS server ports

On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: webapp/src/main/java/org/apache/atlas/Main.java, line 103 https://reviews.apache.org/r/36359/diff/1/?file=1003745#file1003745line103 Could remove protected to make it package private. Dont get what a protected static method

Review Request 36550: Integration with Hbase and solr

Its, all other tests succeed. Thanks, Suma Shivaprasad

Re: Review Request 36550: Integration with Hbase and solr

://reviews.apache.org/r/36550/diff/ Testing --- Ran all UTs and ITS. Except the hive hook security Its, all other tests succeed. Thanks, Suma Shivaprasad

Re: Review Request 36550: Integration with Hbase and solr

://reviews.apache.org/r/36550/diff/ Testing --- Ran all UTs and ITS. Except the hive hook security Its, all other tests succeed. Thanks, Suma Shivaprasad

Re: Unable to build Atlas

HI Rishabh, Can you pls do a clean checkout and try to build. There are some runtime files generated in dahsboard which was part of the older build process but the rat ignore is removed for them Thanks Suma On Mon, Oct 12, 2015 at 10:33 AM, Rishabh Bhardwaj wrote: > Hi,

Re: Review Request 39157: Configure Consumer Groups for Notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39157/#review102184 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 9, 2015, 1:40 a.m

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

8179/diff/ Testing --- Tests added in Parser, GremlinTest, GraphBackedDiscoveryTest Thanks, Suma Shivaprasad

Re: Review Request 39157: Configure Consumer Groups for Notifications

/KafkaNotification.java (line 223) <https://reviews.apache.org/r/39157/#comment159590> consumerConnector need to be shutdown - Suma Shivaprasad On Oct. 9, 2015, 1:40 a.m., Tom Beerbower wrote: > > --- > This is an automatically g

Re: Review Request 39157: Configure Consumer Groups for Notifications

> On Oct. 9, 2015, 4 p.m., Suma Shivaprasad wrote: > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java, > > line 226 > > <https://reviews.apache.org/r/39157/diff/1/?file=1093468#file1093468line226> > > > > consumerCo

Re: Titan: configuration in atlas

Hi Nigel, You should be able to point to the graph created in ATLAS through Rexster by following the steps at http://s3.thinkaurelius.com/docs/titan/current/server.html#_downloading_rexster_and_titan_separately. I was able to get the Rexster instance up this way but got some issue while loading

Re: Titan: configuration in atlas

conf pointed out in the above link and point to the directory where the data for them resides. Connecting through the gremlin shell also requires a .properties file with all these properties set to load the graph stored by ATLAS. Thanks Suma On Fri, Sep 4, 2015 at 5:47 PM, Suma Shivaprasad

Review Request 38179: ATLAS-128 - Equality matches on lists

Thanks, Suma Shivaprasad

Re: Review Request 38341: Provide Entity Change Notification

His can also be removed to use existing interfaces - Suma Shivaprasad On Sept. 14, 2015, 4:08 a.m., Tom Beerbower wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Search syntax

OR]^ > >>> [ERROR] > >>> > >>>/teeup/source_repo/atlas/typesystem/src/main/java/org/apache/atlas/types > >>>ys > >>> tem/types/TypeSystem.java:564: illegal start of type > >&

Re: Search syntax

Could be an issue with 0.5. I fixed an issue while querying for entities with traits as part of https://reviews.apache.org/r/38179/. . Should be committed soon. Thanks Suma On Wed, Sep 23, 2015 at 8:40 PM, Shwetha Shivalingamurthy < sshivalingamur...@hortonworks.com> wrote: > 'hive_table is ¹

Re: Search syntax

Hi Herman, You can fire a DSL query in the UI as "hive_table is "trait_name" Thanks Suma On Tue, Sep 22, 2015 at 8:24 AM, Herman Yu wrote: > Hi, > > With version v0.5, is search based on combination of a Trait and a type > supported? I have both hive_tables and

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99954 --- Ship it! Ship It! - Suma Shivaprasad On Sept. 22, 2015, 9:09

Re: [Atlas] A source code question

attrname is same as i.name in this case. So shoudnt be an issue Thanks Suma On Wed, Sep 16, 2015 at 1:20 PM, ltf wrote: > Hello, > In the following code, for ENUM, the key for fieldPos is i.name, but > others are attrName. > Is it a issue??? Thanks. > > > > > file :

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

ent156738> we should include the typedefinition as well in the exception? repository/src/main/java/org/apache/atlas/services/MetadataService.java (line 83) <https://reviews.apache.org/r/38393/#comment156739> pls add java doc for th args to make it clear - Suma Shivaprasad

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

tps://reviews.apache.org/r/38393/#comment156745> pls add docs for modelling unique entities by qualifiedName typesystem/src/main/resources/application.properties (line 59) <https://reviews.apache.org/r/38393/#comment156744> pls add comments for the configs - Suma Shivaprasad On Sept. 21

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

you pls fix the error message in other places where ValueCnversionException is being thrown curently :) Right now, we dont ge to know which attribute is causing the issue - Suma Shivaprasad On Sept. 21, 2015, 8:13 a.m., Shwe

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

/HiveMetaStoreBridge.java (line 277) <https://reviews.apache.org/r/38393/#comment156363> is sdQualifiedName supposed to be same as tableQualifiedName ? - Suma Shivaprasad On Sept. 15, 2015, 6:56 a.m., Shwetha GS

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

g/r/38393/#comment156374> we should make rge readTimeout configurable and also add connectTimeout common/src/main/java/org/apache/atlas/service/Services.java (line 38) <https://reviews.apache.org/r/38393/#comment156375> should we add a register and unregister service met

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

/KafkaNotification.java (line 131) <https://reviews.apache.org/r/38393/#comment156387> should we throw and exceptiopn instead? - Suma Shivaprasad On Sept. 15, 2015, 6:56 a.m., Shwetha GS wrote: > > --- > This is an automatically g

Re: Review Request 38179: ATLAS-128 - Equality matches on lists

Parser, GremlinTest, GraphBackedDiscoveryTest Thanks, Suma Shivaprasad

[VOTE] Release Apache Atlas version 0.6-incubating

Hi Folks, I have created a build for Apache Atlas 0.6-incubating, release candidate 0. Thanks to everyone who have contributed to this release and also tested this. The source tarball (*.tar.gz), signature (*.asc), checksum (*.md5, *.sha): >

[CANCEL][VOTE] Release Apache Atlas version 0.6-incubating Release candidate-0

Canceling release candidate-0 of Apache Atlas 0.6-incubating as there were issues with the source tar ball. Thanks Suma

Re: [VOTE] Release Apache Atlas version 0.6-incubating

t/dev/incubator/atlas/0.6.0-incubating-rc0/apache-atlas-0.6-incubating-sources.tar.gz > > > On Tue, Dec 8, 2015 at 9:26 AM, Suma Shivaprasad <suma...@apache.org> > wrote: > > > Hi Folks, > > > > I have created a build for Apache Atlas 0.6-incubating

Re: [VOTE] Release Apache Atlas version 0.6.0-incubating (Release Candidate 1)

ory: 173M/726M [INFO] Would request someone else to try the same and let me know. If its working fine, request you to reconsider the vote. Thanks Suma On Thu, Dec 10, 2015 at 1:58 PM, Suma Shivaprasad < sumasai.shivapra...@gmail.com> wrote: > Hi all, > > Tha

Re: [VOTE] Release Apache Atlas version 0.6.0-incubating (Release Candidate 1)

Srikanth Sundarrajan > > > > > > On Thu, Dec 10, 2015 at 4:31 PM, Sandeep Samudrala < > sandys...@gmail.com> > > > wrote: > > > > > > > +1.(non-binding) > > > > Verified build and signatures. > > > > > > > >

[ANNOUNCE] Apache Atlas 0.6-incubating released

Hi folks, The Apache Atlas team is happy to announce the release of Apache Atlas - version 0.6-incubating. Atlas is a scalable and extensible set of core foundational governance services – enabling enterprises to effectively and efficiently meet their compliance requirements within Hadoop and

Re: [VOTE] Release Apache Atlas version 0.6-incubating

gt; > wrote: > > > +1 looks good to me. > > On Dec 24, 2015 22:07, "Suma Shivaprasad" <suma...@apache.org> wrote: > > > > > Hello folks, > > > > > > This is a call for a vote on the Apache Atlas 0.6 incubating release. > > &g

Re: [VOTE] Release Apache Atlas version 0.6.0-incubating (Release Candidate 2)

Hi folks, Thanks for taking time to review and vote on this release. The vote passes with five binding +1's and one 0, no -1s. Binding: IPMC - Arun Murthy, Jitendra Pandey PPMC - Harish Butani, Shwetha GS, Suma Shivaprasad I'll start voting on Incubator general. Thanks! Regards, Suma On Tue

[VOTE] Release Apache Atlas version 0.6-incubating

Hello folks, This is a call for a vote on the Apache Atlas 0.6 incubating release. A vote was held on developer mailing list and it passed with five +1's. Vote thread: http://s.apache.org/nxl Results thread: http://s.apache.org/HyG The source tarball (*.tar.gz), signature (*.asc), checksum

Re: Review Request 47658: ATLAS-499: Update reverse references

> On June 3, 2016, 11:29 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java, > > line 443 > > <https://reviews.apache.org/r/47658/diff/5/?file=1405688#file1405688line443> > > &g

Re: Review Request 47658: ATLAS-499: Update reverse references

> On June 3, 2016, 11:25 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java, > > line 785 > > <https://reviews.apache.org/r/47658/diff/5/?file=1405688#file1405688line785> > > > >

ATLAS-542 Backward incompatible changes

Hi all, As part of changes in ATLAS-542 to make attribute names consistent across Datasets and Process inherited types, "name" will represent shorter name and "qualifiedName" will represent the fully qualified unique name which uniquely idenitifies the entity. One of the attribute names that

Re: Review Request 48280: ATLAS-515: Ability to initialize Kafka topics with more than 1 replica

. The changes looks good to me. - Suma Shivaprasad On June 9, 2016, 10:30 a.m., Hemanth Yamijala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47658: ATLAS-499: Update reverse references

/TypedInstanceToGraphMapper.java (line 783) <https://reviews.apache.org/r/47658/#comment201148> do we need the HashSet since contains and all will both O(n) - Suma Shivaprasad On June 3, 2016, 1:55 p.m., David Kantor

Re: Review Request 47658: ATLAS-499: Update reverse references

/TypedInstanceToGraphMapper.java (line 441) <https://reviews.apache.org/r/47658/#comment201149> for map types, can we check if the reverseAttributeName is set on the map type and remove it if set else ignore? - Suma Shivaprasad On June 3, 2016, 1:55 p.m., David Kantor

Re: Review Request 47841: ATLAS-826 Add support for singleton traits

/TypedInstanceToGraphMapper.java (line 661) <https://reviews.apache.org/r/47841/#comment199831> if there any way to support trait attribute updates by its type for singleton traits ? - Suma Shivaprasad On May 25, 2016, 6:54 p.m., Shwetha GS

Re: Review Request 48280: ATLAS-515: Ability to initialize Kafka topics with more than 1 replica

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48280/#review137355 --- Ship it! Ship It! - Suma Shivaprasad On June 13, 2016, 4:35

Re: Review Request 48452: ATLAS-885: optimize HBaseStoreManager to avoid expensive HTable instantiation every 5 seconds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48452/#review136754 --- Ship it! Ship It! - Suma Shivaprasad On June 9, 2016, 12:41

Re: Review Request 48050: ATLAS-503: Not all Hive tables are not imported into Atlas when interrupted with search queries while importing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48050/#review135675 --- Ship it! Ship It! - Suma Shivaprasad On May 30, 2016, 6:07

Re: Review Request 47841: ATLAS-826 Add support for singleton traits

/DeleteHandler.java (line 196) <https://reviews.apache.org/r/47841/#comment199827> with this is there any way to delete singleton traits if no references exist to that trait? - Suma Shivaprasad On May 25, 2016, 6:54 p.m., Shwetha GS

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

e? Any reason this was done? - Suma Shivaprasad On May 25, 2016, 6:41 p.m., Vimal Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review135160 --- Ship it! Ship It! - Suma Shivaprasad On May 26, 2016, 6:04

Re: [VOTE] Release Apache Atlas version 0.7-incubating

Hi all, Verified signatures, commit id and tag Compiled and built source tarball and verified that all tests passed. Please note that you need to export MAVEN_OPTS at have atleast -Xmx1536m for the build to succeed Ran quick start and verified entities created in the UI Verified that add,

Re: Review Request 48939: ATLAS-904 Handle process qualified name per Hive Operation

/web/resources/EntityResource.java 0713d30 Diff: https://reviews.apache.org/r/48939/diff/ Testing --- Existing tests modified to query with new qualified name. Need to add tests for INSERT INTO TABLE Thanks, Suma Shivaprasad

Re: Review Request 48939: ATLAS-904 Handle process qualified name per Hive Operation

modified to query with new qualified name. Need to add tests for INSERT INTO TABLE Thanks, Suma Shivaprasad

Re: Review Request 48939: ATLAS-904 Handle process qualified name per Hive Operation

sit: https://reviews.apache.org/r/48939/#review138565 --- On June 20, 2016, 4 a.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48945/#review138658 --- Ship it! Ship It! - Suma Shivaprasad On June 20, 2016, 12

Re: Review Request 48945: ATLAs-819 All user defined types should have a set of common attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48945/#review138656 --- Ship it! Ship It! - Suma Shivaprasad On June 20, 2016, 12

Re: Review Request 49191: ATLAS-947 Return state information in inputs and outputs lineage API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49191/#review139387 --- Ship it! Ship It! - Suma Shivaprasad On June 24, 2016, 10

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

ps://reviews.apache.org/r/45784/#review127310 --- On April 6, 2016, 7:08 p.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 430bb6b Diff: https://reviews.apache.org/r/45784/diff/ Testing --- Added tests in HiveHookIT Thanks, Suma Shivaprasad

Review Request 45843: Support for drop table, view

/ Testing --- Added test in HiveHookIT Thanks, Suma Shivaprasad

Re: Review Request 46011: ATLAS-622 Introduce soft delete

/DeleteHandler.java (line 244) <https://reviews.apache.org/r/46011/#comment191919> Please enable this check. Raising this to track so that we dont miss - Suma Shivaprasad On April 12, 2016, 3:27 p.m., Shwetha GS

Re: Review Request 46011: ATLAS-622 Introduce soft delete

/AtlasEdgeLabel.java <https://reviews.apache.org/r/46011/#comment191869> why is this removed? - Suma Shivaprasad On April 12, 2016, 3:27 p.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46011: ATLAS-622 Introduce soft delete

revert this for now. - Suma Shivaprasad On April 11, 2016, 8:55 a.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 45666: ATLAS-621 Introduce entity state in Id object

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45666/#review128018 --- Ship it! Ship It! - Suma Shivaprasad On April 9, 2016, 4:13

Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

/services/DefaultMetadataService.java 0a04c5f repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 430bb6b Diff: https://reviews.apache.org/r/45784/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 0a04c5f repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 430bb6b Diff: https://reviews.apache.org/r/45784/diff/ Testing (updated) --- Added tests in HiveHookIT Thanks, Suma

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

/ReservedTypesRegistrar.java 430bb6b Diff: https://reviews.apache.org/r/45784/diff/ Testing --- Added tests in HiveHookIT Thanks, Suma Shivaprasad

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45784/#review127310 --- On April 5, 2016, 11:58 p.m., Suma Shivaprasad wrote: > >

Re: Review Request 45784: Hve Hook - Support tracking lineage for External Tables( Create/alter) , Load, import, export

/ Testing --- Added tests in HiveHookIT Thanks, Suma Shivaprasad

Re: Review Request 46011: ATLAS-622 Introduce soft delete

s one single place for all the CRUD ops. - Suma Shivaprasad On April 11, 2016, 8:55 a.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

tps://reviews.apache.org/r/45499/#comment193970> should be sortOrder - Suma Shivaprasad On April 20, 2016, 9:22 p.m., Neeru Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

/DeleteHandler.java (line 312) <https://reviews.apache.org/r/46731/#comment199116> why is the check for isComposite removed? Can you pls explain? - Suma Shivaprasad On May 19, 2016, 5:41 a.m., Shwetha GS

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

/DefaultMetadataService.java (line 427) <https://reviews.apache.org/r/46731/#comment199115> if this needs to be fixed, pls raise a jira - Suma Shivaprasad On May 19, 2016, 5:41 a.m., Shwetha GS wrote: > > --- > This is an automatica

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

/EntityJerseyResourceIT.java (line 74) <https://reviews.apache.org/r/46731/#comment199118> pls add asserts for update test cases as well for updated entities - Suma Shivaprasad On May 19, 2016, 5:41 a.m., Shwetha GS

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 23, 2016, 5:02 a.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, > > line 318 > > <https://reviews.apache.org/r/46731/diff/3/?file=1387706#file1387706line318> > > > > why is the

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

/HiveHook.java (line 311) <https://reviews.apache.org/r/47638/#comment198814> pls change var name from nameChanged to nameNotModified. - Suma Shivaprasad On May 20, 2016, 6:42 a.m., Vimal Sharma wrote: > > --- > This is a

Re: Review Request 46922: Temporary tables should be ignored during table creation

/ Testing --- Added tests in HIveHookIT.testInsertIntoTempTable. Thanks, Suma Shivaprasad

Re: Review Request 47111: ATLAS-738 Add query ability on system properties like guid, state, createdtime etc

/Constants.java (line 70) <https://reviews.apache.org/r/47111/#comment196509> rename to getInternalAttribute? - Suma Shivaprasad On May 9, 2016, 8:02 a.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47111: ATLAS-738 Add query ability on system properties like guid, state, createdtime etc

/Constants.java (line 69) <https://reviews.apache.org/r/47111/#comment196510> move this as well to TypesUtil? - Suma Shivaprasad On May 9, 2016, 8:02 a.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47111: ATLAS-738 Add query ability on system properties like guid, state, createdtime etc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47111/#review132331 --- Ship it! Ship It! - Suma Shivaprasad On May 9, 2016, 8:02

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 9:56 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 579 > > <https://reviews.apache.org/r/46731/diff/2/?file=1363301#file1363301line579> > > > > would be better to keep the result c

Re: Review Request 46731: ATLAS-716 Entity update/delete notifications

> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66 > > <https://reviews.apache.org/r/46731/diff/2/?file=1363302#file1363302line66> > > > > why do we need String comparision here and

Re: Review Request 47135: Install Setup: SOLR

deeper and see how we can handle this. The same goes for replica - Suma Shivaprasad On May 9, 2016, 9:32 p.m., Tom Beerbower wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46905: ATLAS-667: Enforce lower bound when disconnecting references during entity deletion

/DeleteHandler.java (line 284) <https://reviews.apache.org/r/46905/#comment196773> the same case should be taken care of for maps? - Suma Shivaprasad On May 3, 2016, 8:26 p.m., David Kantor wrote: > > --- > This is a

Re: Review Request 47107: ATLAS_619 Normalize literals for hive queries

- HiveAStREwriteTest and IT asserttions in HiveHookIT Thanks, Suma Shivaprasad

Re: Review Request 46905: ATLAS-667: Enforce lower bound when disconnecting references during entity deletion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46905/#review132979 --- Ship it! Ship It! - Suma Shivaprasad On May 11, 2016, 11:15

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

/HiveLineageService.java (lines 65 - 66) <https://reviews.apache.org/r/47225/#comment197270> while we are anyways doing this, should we rename HiveLineageService to DataSetLineageService - Suma Shivaprasad On May 11, 2016, 9:21 a.m., Shwetha GS

Re: Review Request 47135: Install Setup: SOLR

> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > <https://reviews.apache.org/r/47135/diff/1/?file=1377049#file1377049line102> > > > > if this config is changed by a user through Ambari, we need to h

Re: Review Request 47135: Install Setup: SOLR

> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > <https://reviews.apache.org/r/47135/diff/1/?file=1377049#file1377049line102> > > > > if this config is changed by a user through Ambari, we need to h

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

/HiveLineageService.java (line 146) <https://reviews.apache.org/r/47225/#comment197271> rename to DataSetLineageQuery and remove all hive specific references ? - Suma Shivaprasad On May 11, 2016, 9:21 a.m., Shwetha GS

Re: Review Request 47225: ATLAS-713 Atlas UI is still showing the deleted column of a hive table (Entity response of hive table does not have it). - with browser cache disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47225/#review133548 --- Ship it! Ship It! - Suma Shivaprasad On May 17, 2016, 8:15

Re: Review Request 47107: ATLAS_619 Normalize literals for hive queries

----- On May 13, 2016, 7:20 a.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47107/ >

Re: Review Request 47107: ATLAS_619 Normalize literals for hive queries

/atlas/web/resources/HiveLineageJerseyResourceIT.java bc02f90 Diff: https://reviews.apache.org/r/47107/diff/ Testing --- Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT Thanks, Suma Shivaprasad

Re: Review Request 47107: ATLAS_619 Normalize literals for hive queries

cdf6049 webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java bc02f90 Diff: https://reviews.apache.org/r/47107/diff/ Testing --- Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT Thanks, Suma Shivaprasad

  1   2   3   4   5   6   7   8   9   10   >