Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

iew154325 ------- On Nov. 1, 2016, 8:37 p.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53156

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review153910 ------- On Nov. 1, 2016, 8:37 p.m., Suma Shivaprasad wrote: > >

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION Diff: https://reviews.apache.org/r/53156/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 53349: BugFix for Indexer NPE on StructDef lookup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53349/#review154452 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 1, 2016, 8:23

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

e combined updateByGuid and partialUpdateByGuid with an optional QueryParam for partialUpdates - Suma --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154445 ------

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

/rest/EntityRest.java PRE-CREATION Diff: https://reviews.apache.org/r/53156/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

ated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154462 ------- On Nov. 1, 2016, 10:17 p.m., Suma Shivaprasad wrote: > > --- > This is an automatically

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

--- Thanks, Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154473 ------- On Nov. 2, 2016, 1:23 a.m., Suma Shivaprasad wrote: > > --- > This is

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

webapp/pom.xml 82f307c webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION Diff: https://reviews.apache.org/r/53156/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

ader); could result in NPE when someone sets it explicitly to null via the setter. Fixed it - Suma --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154492 -------

Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs

, Suma Shivaprasad

Re: Review Request 53419: ATLAS-1268: added methods to retrieve attributeDefs in a type and all its superTypes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53419/#review154770 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 3, 2016, 7:40

Re: Review Request 53417: ATLAS-1266: fixed typedef APIs to update type-registry only on successful graph commit

/AtlasTypeDefGraphStore.java (line 927) <https://reviews.apache.org/r/53417/#comment224452> when indexing fails in GraphBackedSearchIndexer, shouldnt we bubble up the error? Else types can be created without indexes - Suma Shivaprasad On Nov. 3, 2016, 1:22 a.m., Madhan Neethiraj

Re: Review Request 53073: Lineage REST API v2 implementation

/ClosureQuery.scala (line 148) <https://reviews.apache.org/r/53073/#comment224501> is depth mandatory or should we also provide infinite depth to keep it backward compatible with older API. - Suma Shivaprasad On Nov. 3, 2016, 8:07 a.m., Sarath Subramanian

Re: Review Request 53432: [ATLAS-1267] V2 Client for TypesREST API and Integration tests

(line 40) <https://reviews.apache.org/r/53432/#comment224545> better to separate the configuration part of AtlasClient into AtlasClientBase and have the client extend that than AtlasClient - Suma Shivaprasad On Nov. 3, 2016, 4:54 p.m., Apoorv Naik

Re: Review Request 53417: ATLAS-1266: fixed typedef APIs to update type-registry only on successful graph commit

> On Nov. 3, 2016, 5:18 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java, > > line 1010 > > <https://reviews.apache.org/r/53417/diff/1/?file=1552756#file1552756line1010> > &g

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing --- Pending - UTS in progress REST layer testing is also pending Thanks, Suma Shivaprasad

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

/AtlasPrimitiveValueValidator.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing (updated) --- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad

Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53525/#review155176 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 7, 2016, 10:21

Re: Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

tps://reviews.apache.org/r/53526/#comment225025> Dataset has a more extended connotation in the sense that it means that the entity also participates in a lineage. Since dbs do not have that, the current supertypes look good to me - Suma Shivaprasad On Nov. 7, 2016, 7:40 p.m., Madhan Neethiraj

Re: Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

using the existing models and easily bootstrap existing tests from the mdoels json instead of creating test models in TestUtils etc. - Suma Shivaprasad On Nov. 7, 2016, 7:40 p.m., Madhan Neethiraj wrote: > > --- > This is a

Re: Review Request 53526: ATLAS-1272: updated types bootstrap to load from new format typedef JSON files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53526/#review155217 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 7, 2016, 10:29

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

webapp/src/test/java/org/apache/atlas/web/adapters/TestAtlasEntitiesREST.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing --- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad

Re: Review Request 53640: ATLAS-1283: added attribute AtlasBaseTypeDef.category

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53640/#review155642 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 10, 2016, 7:42

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

--- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing --- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

/test/java/org/apache/atlas/web/adapters/TestEntityREST.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing --- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

- tested create and update through the new APIs Have to add invalid case UTs Thanks, Suma Shivaprasad

Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan - Suma Shivaprasad On Nov. 14, 2016, 9:01 a.m., Shwetha GS wrote: > > --- > This is an autom

Re: Review Request 52257: Return system attributes in get entity definition

/GraphBackedSearchIndexer.java (line 161) <https://reviews.apache.org/r/52257/#comment225931> do we need composite for modification timestamp? It will help in equals match only and I dont see how that would be useful. - Suma Shivaprasad On Nov. 14, 2016, 4:50 a.m., Vimal Sharma

Re: Review Request 52257: Return system attributes in get entity definition

> On Nov. 14, 2016, 7:49 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, > > line 161 > > <https://reviews.apache.org/r/52257/diff/4/?file=1562618#file1562618line161> > > > >

Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend

--- Added valid case UTs REST layer - tested create and update through the new APIs Have to add invalid case UTs Thanks, Suma Shivaprasad

Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53525/#review155943 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 15, 2016, 8:17

Re: Review Request 53792: Build fix after commit for ATLAS-1081

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53792/#review155985 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 15, 2016, 5:52

Re: Review Request 53724: ATLAS-1116 Performance monitoring of backend methods in API requests

. Can this be made configurable and disabled if required? - Suma Shivaprasad On Nov. 16, 2016, 9:33 a.m., Shwetha GS wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53748: Updated equals and hashCode signatures

atures - Suma Shivaprasad On Nov. 15, 2016, 3:33 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 53748: Updated equals and hashCode

> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote: > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87 > > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87> > > > > Can we switch to/think of using Lo

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review156288 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 18, 2016, 7:15

Re: Atlas DSL Performance Idea

on to be turned > on/off. I was planning to make this be a global flag, but I can definitely > have different flags for the or/and optimizers. > > > > -Jeff > > > > *From:* Suma Shivaprasad [mailto:sumasai.shivapra...@gmail.com] > *Sent:* Friday, December 02, 2

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

(line 189) <https://reviews.apache.org/r/54058/#comment228809> add validations to have typename or supertype in the request to be provided mandatorily. Else it will end up running a query which may not be indexed. - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

/NotificationHookConsumerIT.java (line 104) <https://reviews.apache.org/r/54058/#comment228812> Use constants for qualifiedName, clusterName in all the tests - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

(line 179) <https://reviews.apache.org/r/54058/#comment228813> if we support search by typeName, can remove the TODO - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatica

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

/MetadataDiscoveryJerseyResourceIT.java (line 65) <https://reviews.apache.org/r/54058/#comment228818> remove if not needed - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > --- > This is an automatically gener

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

/BaseResourceIT.java (line 474) <https://reviews.apache.org/r/54058/#comment228819> would be good to add columns attribute since its a composite attribute - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote: > > ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

/EntityV2JerseyResourceIT.java (line 123) <https://reviews.apache.org/r/54058/#comment228820> will cause timing issues if we dont wait and match the notification that we need here. - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

/EntityV2JerseyResourceIT.java (line 288) <https://reviews.apache.org/r/54058/#comment228821> is this not available for test already in the same patch through EntitiesREST.searchEntities? - Suma Shivaprasad On Nov. 30, 2016, 11:22 p.m., Apoorv Naik

Re: Podling Report Draft for December 2016

Vimal, Thanks for taking this up. A couple of minor review comments. 1. We may want to remove Column level lineage for Hive CTAS queries given that there are some known issues with the current apache hive release or is it known to work with atleast one of them - then we could retain it 2. Also p

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

/EntityJerseyResourceIT.java (line 389) <https://reviews.apache.org/r/53960/#comment229019> better to overload the callAPI methods to have anotgher method for GET calls which dont have a requestObject - Suma Shivaprasad On Nov. 21, 2016, 7:07 p.m., Apoorv Naik

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

/FilterUtil.java (line 122) <https://reviews.apache.org/r/54233/#comment229024> didnt get why we need to toUppercase here..cant we directly do on typeCategory instead? - Suma Shivaprasad On Nov. 30, 2016, 10:33 p.m., Apoorv Naik

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

/AtlasTypeDefGraphStore.java (line 859) <https://reviews.apache.org/r/54233/#comment229025> why do we need the def to type transform? Cant we have the predicates on the def instead? - Suma Shivaprasad On Nov. 30, 2016, 10:33 p.m., Apoorv Naik

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54233/ > --- > > (Updated Nov. 30, 2016, 10:33 p.m.) > > > Review request for atlas, Madhan Neethiraj,

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

/AtlasTypeDefGraphStore.java (line 843) <https://reviews.apache.org/r/54233/#comment229055> pls add a test for this change - Suma Shivaprasad On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote: > > --- > This is a

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

/MetadataDiscoveryJerseyResourceIT.java (line 98) <https://reviews.apache.org/r/53960/#comment229066> use constantf for qualifiedName and hive_db - Suma Shivaprasad On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > ---

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

/DataSetLineageJerseyResourceIT.java (line 62) <https://reviews.apache.org/r/53960/#comment229067> switch to the modified API wo null for this IT - Suma Shivaprasad On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote: > > ---

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

/EntityDiscoveryJerseyResourceIT.java (line 72) <https://reviews.apache.org/r/54287/#comment229068> make changes in AtlasClientV2 for the client APIS - Suma Shivaprasad On Dec. 2, 2016, 10:56 p.m., Sarath Subramanian wrote: > > ---

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

/EntityDiscoveryJerseyResourceIT.java (line 100) <https://reviews.apache.org/r/54287/#comment229069> use constants for qualifiedName everywhere - Suma Shivaprasad On Dec. 2, 2016, 10:56 p.m., Sarath Subramanian wrote: > > ---

Re: Review Request 54500: ATLAS-1355: Fix for bad error translation from V2 API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54500/#review158415 --- Ship it! Ship It! - Suma Shivaprasad On Dec. 7, 2016, 10

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53960/#review158416 --- Ship it! Ship It! - Suma Shivaprasad On Dec. 7, 2016, 12:30

Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54233/#review158918 --- Ship it! Ship It! - Suma Shivaprasad On Dec. 8, 2016, 9:08

Re: Review Request 54824: ATLAS-1367: fix to use correct version of curator-client library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54824/#review159528 --- Ship it! Ship It! - Suma Shivaprasad On Dec. 16, 2016, 10

Re: Review Request 55031: ATLAS-1415: fix potential NPE issues found by Coverity scan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55031/#review160128 --- Ship it! Ship It! - Suma Shivaprasad On Dec. 25, 2016, 8:15

Re: 0.7.1 release of Apache Atlas

+1 for the release Thanks Suma On Thu, Jan 12, 2017 at 2:15 AM, Keval Bhatt wrote: > + 1 for the release. > > This release will resolve the issue of UI not loading after fresh build. > ATLAS-1199 > > Thanks > > On Thu, Jan 12, 2017 at 3:36 PM,

Review Request 55531: ATLAS-1467 Create/Full Update implementation

testing pending Error handling for unresolved references UTS for discovery Thanks, Suma Shivaprasad

Re: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release candidate 1 (dev group vote)

Verified * checksums * no binaries in release * build compile and tests * single node Atlas instance with HBase and Solr - came up fine. * Quickstart and ATLAS sanity tests - search, lineage +1(binding) for the release Thanks Suma On Wed, Jan 18, 2017 at 5:42 PM, Sarath Kumar Subramanian < sarat

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

testing pending Error handling for unresolved references UTS for discovery Thanks, Suma Shivaprasad

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55531/#review161668 --- On Jan. 19, 2017, 6:22 a.m., Suma Shivaprasad wrote: > > --- > This is an au

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

/EntityDiscoveryJerseyResourceIT.java 2ade5b0 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d7702e2 Diff: https://reviews.apache.org/r/55531/diff/ Testing --- UTs for create TODO: Update testing pending Error handling for unresolved references UTS for discovery Thanks, Suma

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

discovery Thanks, Suma Shivaprasad

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

//reviews.apache.org/r/55531/#review161657 --- On Jan. 19, 2017, 10:13 p.m., Suma Shivaprasad wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

y can hold a manager or an employee. So subType check would work there - Suma Shivaprasad On Jan. 20, 2017, 10:30 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

> On Jan. 20, 2017, 5:10 p.m., Suma Shivaprasad wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java, line > > 97 > > <https://reviews.apache.org/r/55753/diff/1/?file=1610433#file1610433line97> > > > > rename to resol

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55753/#review162455 --- Ship it! Ship It! - Suma Shivaprasad On Jan. 20, 2017, 10

Re: Review Request 55813: Porting performance and stability changes made in 0.7 branch into master

s gets called GremlinQuery - Suma Shivaprasad On Jan. 21, 2017, 2:19 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release candidate 3 (dev group vote)

candidate 3” is the update to build instructions in README.txt. There are > no other changes. > > > > > > > > We currently have 7 binding votes and 7 non-binding votes for the > earlier release candidates. Thank you everyone for validating the release > candi

Re: Review Request 55813: Porting performance and stability changes made in 0.7 branch into master

/DataSetLineageService.java (line 97) <https://reviews.apache.org/r/55813/#comment234109> This shoudnt have superTypeNames check directly in the query since there is no index on guid + typeName. I had removed it in ATLAS-1404 - Suma Shivaprasad On Jan. 23, 2017, 11:17 p.m., Sarath Subramanian

Review Request 55912: Add UTS for Array, map, struct and entity updates

0ff33ba Diff: https://reviews.apache.org/r/55912/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 55912: Add UTS for Array, map, struct and entity updates

» AtlasBase expected type Map ... TestEntityREST.testGetEntityById:97 expected: but was: TestEntityREST.testUpdateGetDeleteEntityByUniqueAttribute:171 expected: but was: Thanks, Suma Shivaprasad

Re: Review Request 55912: Add UTS for Array, map, struct and entity updates

: but was: Thanks, Suma Shivaprasad

Re: Review Request 56049: ATLAS-1472: updated type-registry to handle simultaneous updates from multiple threads

(line 769) <https://reviews.apache.org/r/56049/#comment234868> throw error when getISOktocommit is false - Suma Shivaprasad On Jan. 28, 2017, 1:01 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically gener

Re: Review Request 56049: ATLAS-1472: updated type-registry to handle simultaneous updates from multiple threads

(line 747) <https://reviews.apache.org/r/56049/#comment234869> can be combined with prev if block - Suma Shivaprasad On Jan. 28, 2017, 1:01 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e

Re: Review Request 56049: ATLAS-1472: updated type-registry to handle simultaneous updates from multiple threads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56049/#review163409 --- Ship it! Ship It! - Suma Shivaprasad On Jan. 28, 2017, 1:01

Re: Review Request 56105: ATLAS-1506: updated AtlasObjectId to support unqiueAttributes to identity the object

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56105/#review163626 --- Ship it! Ship It! - Suma Shivaprasad On Jan. 31, 2017, 1:08

Review Request 56113: Fixed issues with deletion during updates

/r/56113/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56113: Fixed issues with deletion during updates

webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3 Diff: https://reviews.apache.org/r/56113/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56113: Fixed issues with deletion during updates

/AtlasStructFormatConverter.java 8777510 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 47e1fa3 Diff: https://reviews.apache.org/r/56113/diff/ Testing --- Thanks, Suma Shivaprasad

Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

/apache/atlas/web/rest/EntityREST.java aa209f9 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java cfe9909 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java ee36fdf Diff: https://reviews.apache.org/r/56206/diff/ Testing --- Thanks, Suma

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

/TestEntitiesREST.java cfe9909 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java ee36fdf webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d9bffe9 Diff: https://reviews.apache.org/r/56206/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

failing . This is pending. Thanks, Suma Shivaprasad

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

Diff: https://reviews.apache.org/r/56206/diff/ Testing --- ENtityJerseyResourceIt tests failing . This is pending. Thanks, Suma Shivaprasad

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

pters/TestEntityREST.java ee36fdf webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d9bffe9 Diff: https://reviews.apache.org/r/56206/diff/ Testing --- ENtityJerseyResourceIt tests failing . This is pending. Thanks, Suma Shivaprasad

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

/java/org/apache/atlas/web/adapters/TestEntityREST.java ee36fdf webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d9bffe9 Diff: https://reviews.apache.org/r/56206/diff/ Testing --- ENtityJerseyResourceIt tests failing . This is pending. Thanks,

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56206/#review164250 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 4, 2017, 12:09

Review Request 56535: Add tests for DeleteHandlerV1

a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Re: Review Request 56553: ATLAS-1550: for unit test failure in TypeSystemTest.testDuplicateTypenames()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56553/#review165144 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 10, 2017, 5:20

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/AtlasEntityGraphDiscoveryV1.java (line 92) <https://reviews.apache.org/r/56585/#comment237203> throw error when entity is null? - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj wrote: > > ---

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/AtlasEntityGraphDiscoveryV1.java (line 111) <https://reviews.apache.org/r/56585/#comment237204> consider throwing error when entity is null - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj wrote: > > -

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/EntityGraphMapper.java (line 611) <https://reviews.apache.org/r/56585/#comment237208> this is the current behaviour in case of soft delete to keep track of deleted elements - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56585/#review165401 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 13, 2017, 11

<    1   2   3   4   5   6   7   8   9   10   >